[net-next 16/17] can: dev: can_put_echo_skb(): add software tx timestamps

2021-01-13 Thread Marc Kleine-Budde
From: Vincent Mailhol Call skb_tx_timestamp() within can_put_echo_skb() so that a software tx timestamp gets attached to the skb. There two main reasons to include this call in can_put_echo_skb(): * It easily allow to enable the tx timestamp on all devices with just one small change. *

[net-next 17/17] can: tcan4x5x: remove __packed attribute from struct tcan4x5x_map_buf

2021-01-13 Thread Marc Kleine-Budde
The first member of struct tcan4x5x_map_buf is the struct tcan4x5x_buf_cmd, which has a size of 4 bytes. It's followed by an array of u8. The compiler places the array directly after the struct tcan4x5x_buf_cmd. This patch removes the not needed attribute __packed from the struct tcan4x5x_map_buf.

[net-next 07/17] can: dev: move netlink related code into seperate file

2021-01-13 Thread Marc Kleine-Budde
This patch moves the netlink related code of the CAN device infrastructure into a separate file. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-7-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/Makefile | 1 + drivers/net/can/de

[net-next 06/17] can: dev: move skb related into seperate file

2021-01-13 Thread Marc Kleine-Budde
This patch moves the skb related code of the CAN device infrastructure into a separate file. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-6-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/Makefile | 1 + drivers/net/can/dev/dev

[net-next 03/17] can: dev: move driver related infrastructure into separate subdir

2021-01-13 Thread Marc Kleine-Budde
This patch moves the CAN driver related infrastructure into a separate subdir. It will be split into more files in the coming patches. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-3-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/Mak

[net-next 12/17] can: dev: extend struct can_skb_priv to hold CAN frame length

2021-01-13 Thread Marc Kleine-Budde
In order to implement byte queue limits (bql) in CAN drivers, the length of the CAN frame needs to be passed into the networking stack after queueing and after transmission completion. To avoid to calculate this length twice, extend the struct can_skb_priv to hold the length of the CAN frame and e

[net-next 05/17] can: dev: move length related code into seperate file

2021-01-13 Thread Marc Kleine-Budde
This patch moves all CAN frame length related code of the CAN device infrastructure into a separate file. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-5-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- MAINTAINERS | 1 + drivers/net

[net-next 01/17] MAINTAINERS: adjust entry to tcan4x5x file split

2021-01-13 Thread Marc Kleine-Budde
From: Lukas Bulwahn Commit 7813887ea972 ("can: tcan4x5x: rename tcan4x5x.c -> tcan4x5x-core.c") and commit 67def4ef8bb9 ("can: tcan4x5x: move regmap code into seperate file") split the file tcan4x5x.c into two files, but missed to adjust the TI TCAN4X5X DEVICE DRIVER section in MAINTAINERS. Henc

[net-next 02/17] MAINTAINERS: CAN network layer: add missing header file can-ml.h

2021-01-13 Thread Marc Kleine-Budde
This patch add the can-ml.h to the list of maintained files of the CAN network layer. Fixes: ffd956eef69b ("can: introduce CAN midlayer private and allocate it automatically") Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-2-...@pengutronix.de Signed-off-by: M

[net-next 04/17] can: dev: move bittiming related code into seperate file

2021-01-13 Thread Marc Kleine-Budde
This patch moves the bittiming related code of the CAN device infrastructure into a separate file. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- MAINTAINERS | 1 + drivers/net/ca

pull-request: can-next 2021-01-14

2021-01-13 Thread Marc Kleine-Budde
Hello Jakub, hello David, this is the corrected version of yesterday's pull request, it consists of 17 patches for net-next/master. The first two patches update the MAINTAINERS file, Lukas Bulwahn's patch fixes the files entry for the tcan4x5x driver, which was broken by me in net-next. A patch b

[PATCH net-next] net: bridge: use eth_type_vlan in br_dev_queue_push_xmit

2021-01-13 Thread menglong8 . dong
From: Menglong Dong Replace the check for ETH_P_8021Q and ETH_P_8021AD in br_dev_queue_push_xmit with eth_type_vlan. Signed-off-by: Menglong Dong --- net/bridge/br_forward.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-13 Thread Jiri Pirko
Thu, Jan 14, 2021 at 03:27:16AM CET, k...@kernel.org wrote: >On Wed, 13 Jan 2021 13:12:12 +0100 Jiri Pirko wrote: >> This patchset introduces support for modular switch systems. >> NVIDIA Mellanox SN4800 is an example of such. It contains 8 slots >> to accomodate line cards. Available line cards in

[PATCH net-next] net: core: use eth_type_vlan in tap_get_user_xdp

2021-01-13 Thread menglong8 . dong
From: Menglong Dong Replace the check for ETH_P_8021Q and ETH_P_8021AD in tap_get_user_xdp with eth_type_vlan. Signed-off-by: Menglong Dong --- drivers/net/tap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/tap.c b/drivers/net/tap.c index 3c652c8ac5ba..e007

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-13 Thread Jiri Pirko
Thu, Jan 14, 2021 at 03:07:18AM CET, and...@lunn.ch wrote: >> $ devlink lc provision netdevsim/netdevsim10 lc 0 type card4ports >> $ devlink lc >> netdevsim/netdevsim10: >> lc 0 state provisioned type card4ports >> supported_types: >>card1port card2ports card4ports >> lc 1 state unp

[PATCH net-next] net: tap: use eth_type_vlan in tap_get_user

2021-01-13 Thread menglong8 . dong
From: Menglong Dong Replace the check for ETH_P_8021Q and ETH_P_8021AD in tap_get_user with eth_type_vlan. Signed-off-by: Menglong Dong --- drivers/net/tap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/tap.c b/drivers/net/tap.c index 3c652c8ac5ba..cf9197fe

Re: [net-next 09/17] can: length: can_fd_len2dlc(): simplify length calculcation

2021-01-13 Thread Marc Kleine-Budde
On 1/14/21 2:59 AM, Vincent MAILHOL wrote: > On Tue. 14 Jan 2021 at 06:14, Marc Kleine-Budde wrote: >> >> If the length paramter in len2dlc() exceeds the size of the len2dlc array, we >> return 0xF. This is equal to the last 16 members of the array. >> >> This patch removes these members from the

Re: pull-request: can-next 2021-01-13

2021-01-13 Thread Marc Kleine-Budde
0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git > tags/linux-can-next-for-5.12-20210113 Please don't pull. This request contains a bug. I've deleted the tag and send a fixed pull request soon.

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Heiner Kallweit
On 13.01.2021 23:01, Russell King - ARM Linux admin wrote: > On Wed, Jan 13, 2021 at 10:34:53PM +0100, Heiner Kallweit wrote: >> On 13.01.2021 13:36, claudiu.bez...@microchip.com wrote: >>> On 13.01.2021 13:09, Heiner Kallweit wrote: On 13.01.2021 10:29, claudiu.bez...@microchip.com wrote: >>>

Re: [Patch net] cls_flower: call nla_ok() before nla_next()

2021-01-13 Thread Cong Wang
On Tue, Jan 12, 2021 at 6:22 PM Xin Long wrote: > > On Wed, Jan 13, 2021 at 1:43 AM Cong Wang wrote: > > > > On Tue, Jan 12, 2021 at 3:52 AM Xin Long wrote: > > > > > > On Tue, Jan 12, 2021 at 10:56 AM Cong Wang > > > wrote: > > > > > > > > From: Cong Wang > > > > > > > > fl_set_enc_opt() sim

Re: [Patch net] cls_flower: call nla_ok() before nla_next()

2021-01-13 Thread Cong Wang
On Tue, Jan 12, 2021 at 5:38 PM Jakub Kicinski wrote: > > On Mon, 11 Jan 2021 18:55:48 -0800 Cong Wang wrote: > > From: Cong Wang > > > > fl_set_enc_opt() simply checks if there are still bytes left to parse, > > but this is not sufficent as syzbot seems to be able to generate > > malformatted ne

Re: [PATCH mlx5-next v1 1/5] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-01-13 Thread Leon Romanovsky
On Wed, Jan 13, 2021 at 12:00:00PM -0800, Alexander Duyck wrote: > On Tue, Jan 12, 2021 at 10:09 PM Leon Romanovsky wrote: > > > > On Tue, Jan 12, 2021 at 01:59:51PM -0800, Alexander Duyck wrote: > > > On Mon, Jan 11, 2021 at 10:39 PM Leon Romanovsky wrote: > > > > > > > > On Mon, Jan 11, 2021 at

Re: [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data

2021-01-13 Thread Kalle Valo
"Coelho, Luciano" writes: >> BTW, I thought network people don't want to have Cc-to-stable in the >> patch, so I didn't put it by myself. Is this rule still valid? > > In the wireless side of network, we've always used Cc stable when > needed Yeah, we handle stable patches differently from the

Re: [PATCH mlx5-next v1 2/5] PCI: Add SR-IOV sysfs entry to read number of MSI-X vectors

2021-01-13 Thread Leon Romanovsky
On Wed, Jan 13, 2021 at 02:44:45PM -0800, Alexander Duyck wrote: > On Tue, Jan 12, 2021 at 10:19 PM Leon Romanovsky wrote: > > > > On Tue, Jan 12, 2021 at 01:34:50PM -0800, Alexander Duyck wrote: > > > On Mon, Jan 11, 2021 at 10:56 PM Leon Romanovsky wrote: > > > > > > > > On Mon, Jan 11, 2021 at

Re: [PATCH] crypto: Rename struct device_private to bcm_device_private

2021-01-13 Thread Herbert Xu
On Tue, Jan 05, 2021 at 12:02:37AM +0100, Jiri Olsa wrote: > Renaming 'struct device_private' to 'struct bcm_device_private', > because it clashes with 'struct device_private' from > 'drivers/base/base.h'. > > While it's not a functional problem, it's causing two distinct > type hierarchies in BTF

Re: [PATCH net v3] net: macb: Add default usrio config to default gem config

2021-01-13 Thread kernel test robot
Hi Atish, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Atish-Patra/net-macb-Add-default-usrio-config-to-default-gem-config/20210114-034147 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/n

Re: [PATCH v1 net-next 00/15] nvme-tcp receive offloads

2021-01-13 Thread David Ahern
On 1/13/21 6:27 PM, Sagi Grimberg wrote: >> Changes since RFC v1: >> = >> * Split mlx5 driver patches to several commits >> * Fix nvme-tcp handling of recovery flows. In particular, move queue >> offlaod >>    init/teardown to the start/stop functions. > > I

[PATCH net-next v5 3/5] net: phylink: allow attaching phy for SFP modules on 802.3z mode

2021-01-13 Thread Marek Behún
Some SFPs may contain an internal PHY which may in some cases want to connect with the host interface in 1000base-x/2500base-x mode. Do not fail if such PHY is being attached in one of these PHY interface modes. Signed-off-by: Marek Behún Reviewed-by: Russell King Reviewed-by: Pali Rohár Cc: An

[PATCH net-next v5 1/5] net: sfp: add SFP_PASSWORD address

2021-01-13 Thread Marek Behún
Add SFP_PASSWORD = 0x7b to the diagnostics enumerator. This address is described in SFF-8436 and SFF-8636. Signed-off-by: Marek Behún --- include/linux/sfp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/sfp.h b/include/linux/sfp.h index 38893e4dd0f0..81b40b2d6b1b 100644 ---

[PATCH net-next v5 4/5] net: sfp: create/destroy I2C mdiobus before PHY probe/after PHY release

2021-01-13 Thread Marek Behún
Instead of configuring the I2C mdiobus when SFP driver is probed, create/destroy the mdiobus before the PHY is probed for/after it is released. This way we can tell the mdio-i2c code which protocol to use for each SFP transceiver. Signed-off-by: Marek Behún Reviewed-by: Pali Rohár Cc: Andrew Lu

[PATCH net-next v5 2/5] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-13 Thread Marek Behún
Some multigig SFPs from RollBall and Hilink do not expose functional MDIO access to the internal PHY of the SFP via I2C address 0x56 (although there seems to be read-only clause 22 access on this address). Instead these SFPs PHY can be accessed via I2C via the SFP Enhanced Digital Diagnostic Inter

[PATCH net-next v5 5/5] net: sfp: add support for multigig RollBall transceivers

2021-01-13 Thread Marek Behún
This adds support for multigig copper SFP modules from RollBall/Hilink. These modules have a specific way to access clause 45 registers of the internal PHY. We also need to wait at least 22 seconds after deasserting TX disable before accessing the PHY. The code waits for 25 seconds just to be sure

[PATCH net-next v5 0/5] Support for RollBall 10G copper SFP modules

2021-01-13 Thread Marek Behún
Hello, this is v5 of series adding support for RollBall/Hilink SFP modules. Checked with: checkpatch.pl --max-line-length=80 Changes from v4: - added patch adding SFP_PASSWORD = 0x7b to sfp.h - patch adding RollBall MDIO I2C protocol support - removed forgotten comment that was no longer tru

[PATCH net-next v16 1/6] dt-bindings: net: Add 5GBASER phy interface

2021-01-13 Thread Marek Behún
From: Pavana Sharma Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Acked-by: Rob Herring Signed-off-by: Marek Behún --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + 1 file changed, 1 insertion(+)

[PATCH net-next v16 2/6] net: phy: Add 5GBASER interface mode

2021-01-13 Thread Marek Behún
From: Pavana Sharma Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Marek Behún --- Documentation/networking/phy.rst | 6 ++ include/linux/phy.h | 4 2 files changed, 10 insertions(+) d

[PATCH net-next v16 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-13 Thread Marek Behún
From: Pavana Sharma The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X). T

[PATCH net-next v16 6/6] net: dsa: mv88e6xxx: implement .port_set_policy for Amethyst

2021-01-13 Thread Marek Behún
The 16-bit Port Policy CTL register from older chips is on 6393x changed to Port Policy MGMT CTL, which can access more data, but indirectly and via 8-bit registers. The original 16-bit value is divided into first two 8-bit register in the Port Policy MGMT CTL. We can therefore use the previous c

[PATCH net-next v16 4/6] net: dsa: mv88e6xxx: wrap .set_egress_port method

2021-01-13 Thread Marek Behún
There are two implementations of the .set_egress_port method, and both of them, if successful, set chip->*gress_dest_port variable. To avoid code repetition, wrap this method into mv88e6xxx_set_egress_port. Signed-off-by: Marek Behún Reviewed-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chi

[PATCH net-next v16 3/6] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int

2021-01-13 Thread Marek Behún
From: Pavana Sharma Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or -errno (-ENODEV or -EOPNOTSUPP). Signed-off-by: Pavana Sharma Reviewed-by: Andrew Lunn Reviewed-by: Vladimir

[PATCH net-next v16 0/6] Add support for mv88e6393x family of Marvell

2021-01-13 Thread Marek Behún
Hello, this is version 16 of patches adding support for Amethyst family to mv88e6xxx. It should apply cleanly on net-next. This series is tested on Marvell CN9130-CRB. Changes from v15: - put 1baseKR_Full back into phylink_validate method for Amethyst, it seems I misunderstood the meaning

Re: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-13 Thread Jason Wang
On 2021/1/7 上午11:48, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Tuesday, January 5, 2021 6:53 PM On Tue, Jan 05, 2021 at 12:30:15PM +, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Tuesday, January 5, 2021 5:45 PM On Tue, Jan 05, 2021 at 12:02:33PM +, Parav Pandit

[PATCH] tcp_cubic: use memset and offsetof init

2021-01-13 Thread Yejune Deng
In bictcp_reset(), use memset and offsetof instead of = 0. Signed-off-by: Yejune Deng --- net/ipv4/tcp_cubic.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c index c7bf5b2..ffcbe46 100644 --- a/net/ipv4/tcp_cubic.c +++

Re: [PATCH] net: stmmac: Fixed mtu channged by cache aligned

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 11:41:09 +0800 David Wu wrote: > Since the original mtu is not used when the mtu is updated, > the mtu is aligned with cache, this will get an incorrect. > For example, if you want to configure the mtu to be 1500, > but mtu 1536 is configured in fact. > > Fixed: eaf4fac478077 (

Re: [PATCH net-next 1/3] bus: mhi: core: Add helper API to return number of free TREs

2021-01-13 Thread Jakub Kicinski
On Thu, 14 Jan 2021 09:27:49 +0530 Manivannan Sadhasivam wrote: > On Wed, Jan 13, 2021 at 07:33:01PM -0800, Jakub Kicinski wrote: > > On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote: > > > From: Hemant Kumar > > > > > > Introduce mhi_get_free_desc_count() API to return number > > > of TRE

Re: [PATCH bpf v2 1/2] bpf: support PTR_TO_MEM{,_OR_NULL} register spilling

2021-01-13 Thread Alexei Starovoitov
On Wed, Jan 13, 2021 at 2:29 PM KP Singh wrote: > > On Wed, Jan 13, 2021 at 6:38 AM Gilad Reti wrote: > > > > Add support for pointer to mem register spilling, to allow the verifier > > to track pointers to valid memory addresses. Such pointers are returned > > for example by a successful call of

Re: [PATCH net-next 1/3] bus: mhi: core: Add helper API to return number of free TREs

2021-01-13 Thread Manivannan Sadhasivam
On Wed, Jan 13, 2021 at 07:33:01PM -0800, Jakub Kicinski wrote: > On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote: > > From: Hemant Kumar > > > > Introduce mhi_get_free_desc_count() API to return number > > of TREs available to queue buffer. MHI clients can use this > > API to know before h

Re: [PATCH net-next] tcp: assign skb hash after tcp_event_data_sent

2021-01-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 11 Jan 2021 15:05:52 -0800 you wrote: > Move skb_set_hash_from_sk s.t. it's called after instead of before > tcp_event_data_sent is called. This enables congestion control > modules to change the socket hash right b

Re: [PATCH net V3] cxgb4/chtls: Fix tid stuck due to wrong update of qid

2021-01-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 12 Jan 2021 11:06:00 +0530 you wrote: > TID stuck is seen when there is a race in > CPL_PASS_ACCEPT_RPL/CPL_ABORT_REQ and abort is arriving > before the accept reply, which sets the queue number. > In this case HW ends u

Re: [PATCH bpf-next 1/2] trace: bpf: Allow bpf to attach to bare tracepoints

2021-01-13 Thread kernel test robot
Hi Qais, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Qais-Yousef/Allow-attaching-to-bare-tracepoints/20210112-022350 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master

Re: [PATCH bpf-next] bpf: reject too big ctx_size_in for raw_tp test run

2021-01-13 Thread Alexei Starovoitov
On Wed, Jan 13, 2021 at 3:28 PM Yonghong Song wrote: > > > > On 1/13/21 1:48 PM, Song Liu wrote: > > > > > >> On Jan 12, 2021, at 9:17 PM, Yonghong Song wrote: > >> > >> > >> > >> On 1/12/21 3:42 PM, Song Liu wrote: > >>> syzbot reported a WARNING for allocating too big memory: > >>> WARNING: CPU

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-13 Thread Jason Wang
On 2021/1/13 下午10:33, Willem de Bruijn wrote: On Tue, Jan 12, 2021 at 11:11 PM Jason Wang wrote: On 2021/1/13 上午7:47, Willem de Bruijn wrote: On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich wrote: On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich wrote: On Tue, Jan 12, 2021 at 9:41 PM Y

Re: [PATCH net] i40e: fix potential NULL pointer dereferencing

2021-01-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 11 Jan 2021 18:11:38 + you wrote: > Currently, the function i40e_construct_skb_zc only frees the input xdp > buffer when the output skb is successfully built. On error, the > function i40e_clean_rx_irq_zc does not co

Re: [PATCH v1 1/1] time64.h: Consolidated PSEC_PER_SEC definition

2021-01-13 Thread Jakub Kicinski
On Tue, 12 Jan 2021 17:37:09 +0200 Andy Shevchenko wrote: > We have currently three users of the PSEC_PER_SEC each of them defining it > individually. Instead, move it to time64.h to be available for everyone. > > There is a new user coming with the same constant in use. It will also > make its li

Re: [PATCH net-next 1/3] bus: mhi: core: Add helper API to return number of free TREs

2021-01-13 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote: > From: Hemant Kumar > > Introduce mhi_get_free_desc_count() API to return number > of TREs available to queue buffer. MHI clients can use this > API to know before hand if ring is full without calling queue > API. > > Signed-off-by: Hemant

Re: [PATCH net-next] dpaa2-mac: fix the remove path for non-MAC interfaces

2021-01-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 11 Jan 2021 19:18:02 +0200 you wrote: > From: Ioana Ciornei > > Check if the interface is indeed connected to a MAC before trying to > close the DPMAC object representing it. Without this check we end up > working

Re: [PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-13 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:43:14 +0200 Vladimir Oltean wrote: > +struct ocelot_devlink_private { > + struct ocelot *ocelot; > +}; I don't think you ever explained to me why you don't put struct ocelot in the priv. - ocelot = devm_kzalloc(&pdev->dev, sizeof(*ocelot), GFP_KERNEL); - if

Re: [PATCH net-next] dpaa2-eth: add support for Rx VLAN filtering

2021-01-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 11 Jan 2021 19:07:25 +0200 you wrote: > From: Ionut-robert Aron > > Declare Rx VLAN filtering as supported and user-changeable only when > there are VLAN filtering entries available on the DPNI object. Even > then

Re: [PATCH v4 net-next 00/10] Configuring congestion watermarks on ocelot switch using devlink-sb

2021-01-13 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:43:06 +0200 Vladimir Oltean wrote: > In some applications, it is important to create resource reservations in > the Ethernet switches, to prevent background traffic, or deliberate > attacks, from inducing denial of service into the high-priority traffic. > > These patches gi

Re: [PATCH iproute2-next] ip: don't use program name to select command

2021-01-13 Thread David Ahern
On 1/11/21 12:05 PM, Matteo Croce wrote: > From: Matteo Croce > > ip has an ancient behaviour of looking at its program name to determine > the command to run. If the name is longer than 2 characters, the first two > letters are stripped and the others are interpreted as the command name: > >

Re: [PATCH net-next] net: core: use eth_type_vlan in __netif_receive_skb_core

2021-01-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 11 Jan 2021 02:42:21 -0800 you wrote: > From: Menglong Dong > > Replace the check for ETH_P_8021Q and ETH_P_8021AD in > __netif_receive_skb_core with eth_type_vlan. > > Signed-off-by: Menglong Dong > > [...] H

Re: [PATCH] octeontx2-pf: Add flow classification using IP next level protocol

2021-01-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 11 Jan 2021 16:55:37 +0530 you wrote: > This patch adds support to install flow rules using ipv4 proto or > ipv6 next header field to distinguish between tcp/udp/sctp/esp/ah > flows when user doesn't specify the oth

Re: [PATCH 1/2] bpf, libbpf: Avoid unused function warning on bpf_tail_call_static

2021-01-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 13 Jan 2021 14:36:08 -0800 you wrote: > Add inline to __always_inline making it match the linux/compiler.h. > Adding this avoids an unused function warning on bpf_tail_call_static > when compining with -Wall. > > Sig

Re: [net 1/2] can: isotp: isotp_getname(): fix kernel information leak

2021-01-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Wed, 13 Jan 2021 22:21:57 +0100 you wrote: > From: Oliver Hartkopp > > Initialize the sockaddr_can structure to prevent a data leak to user space. > > Suggested-by: Cong Wang > Reported-by: syzbot+057884e2f453e8afe...@sy

[PATCH net-next v4 13/13] selftests: Add separate option to nettest for address binding

2021-01-13 Thread David Ahern
Add separate option to nettest to specify local address binding in client mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/fcnal-test.sh | 12 ++-- tools/testing/selftests/net/nettest.c | 11 +-- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/

[PATCH net-next v4 00/13] selftests: Updates to allow single instance of nettest for client and server

2021-01-13 Thread David Ahern
Update nettest to handle namespace change internally to allow a single instance to run both client and server modes. Device validation needs to be moved after the namespace change and a few run time options need to be split to allow values for client and server. v4 - really fix the memory leak wit

[PATCH net-next v4 11/13] selftests: Add separate options for server device bindings

2021-01-13 Thread David Ahern
From: David Ahern Add new options to nettest to specify device binding and expected device binding for server mode, and update fcnal-test script. This is needed to allow a single instance of nettest running both server and client modes to use different device bindings. Signed-off-by: David Ahern

[PATCH net-next v4 05/13] selftests: Add support to nettest to run both client and server

2021-01-13 Thread David Ahern
From: David Ahern Add option to nettest to run both client and server within a single instance. Client forks a child process to run the server code. A pipe is used for the server to tell the client it has initialized and is ready or had an error. This avoid unnecessary sleeps to handle such race

[PATCH net-next v4 12/13] selftests: Remove exraneous newline in nettest

2021-01-13 Thread David Ahern
Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/net/nettest.c b/tools/testing/selftests/net/nettest.c index 1707af21eb15..55c586eb2393 100644 --- a/tools/testing/selftests/net/nettest.c +++ b/tools/te

[PATCH net-next v4 10/13] selftests: Add new option for client-side passwords

2021-01-13 Thread David Ahern
From: David Ahern Add new option to nettest to specify MD5 password to use for client side. Update fcnal-test script. This is needed for a single instance running both server and client modes to test password mismatches. Signed-off-by: David Ahern --- tools/testing/selftests/net/fcnal-test.sh

[PATCH net-next v4 09/13] selftests: Consistently specify address for MD5 protection

2021-01-13 Thread David Ahern
From: David Ahern nettest started with -r as the remote address for MD5 passwords. The -m argument was added to use prefixes with a length when that feature was added to the kernel. Since -r is used to specify remote address for client mode, change nettest to only use -m for MD5 passwords and upd

[PATCH net-next v4 08/13] selftests: Make address validation apply only to client mode

2021-01-13 Thread David Ahern
From: David Ahern When a single instance of nettest is used for client and server make sure address validation is only done for client mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/ne

[PATCH net-next v4 02/13] selftests: Move convert_addr up in nettest

2021-01-13 Thread David Ahern
From: David Ahern convert_addr needs to be invoked in a different location. Move the code up to avoid a forward declaration. Code move only. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 252 +- 1 file changed, 126 insertions(+), 126 deletions(

[PATCH net-next v4 06/13] selftests: Use separate stdout and stderr buffers in nettest

2021-01-13 Thread David Ahern
From: David Ahern When a single instance of nettest is doing both client and server modes, stdout and stderr messages can get interlaced and become unreadable. Allocate a new set of buffers for the child process handling server mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/n

[PATCH net-next v4 07/13] selftests: Add missing newline in nettest error messages

2021-01-13 Thread David Ahern
From: David Ahern A few logging lines are missing the newline, or need it moved up for cleaner logging. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/net/nettest.c

[PATCH net-next v4 03/13] selftests: Move address validation in nettest

2021-01-13 Thread David Ahern
From: David Ahern IPv6 addresses can have a device name to declare a scope (e.g., fe80::5054:ff:fe12:3456%eth0). The next patch adds support to switch network namespace before running client or server code (or both), so move the address validation to the server and client functions. IPv4 multica

[PATCH net-next v4 01/13] selftests: Move device validation in nettest

2021-01-13 Thread David Ahern
From: David Ahern Later patch adds support for switching network namespaces before running client, server or both. Device validations need to be done after the network namespace switch, so add a helper to do it and invoke in server and client code versus inline with argument parsing. Move related

[PATCH net-next v4 04/13] selftests: Add options to set network namespace to nettest

2021-01-13 Thread David Ahern
From: David Ahern Add options to specify server and client network namespace to use before running respective functions. Signed-off-by: Seth David Schoen Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 56 ++- 1 file changed, 55 insertions(+), 1

Re: [PATCH net-next] net: ethtool: allow MAC drivers to override ethtool get_ts_info

2021-01-13 Thread Jakub Kicinski
On Sun, 10 Jan 2021 17:35:25 +0100 Andrew Lunn wrote: > On Sun, Jan 10, 2021 at 11:13:44AM +, Russell King wrote: > > Check whether the MAC driver has implemented the get_ts_info() > > method first, and call it if present. If this method returns > > -EOPNOTSUPP, defer to the phylib or default

Re: [PATCH bpf-next 1/2] trace: bpf: Allow bpf to attach to bare tracepoints

2021-01-13 Thread kernel test robot
Hi Qais, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Qais-Yousef/Allow-attaching-to-bare-tracepoints/20210112-022350 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master

[PATCH net] net: dsa: mv88e6xxx: do not allow inband AN for 2500base-x mode

2021-01-13 Thread Marek Behún
Commit a5a6858b793ff ("net: dsa: mv88e6xxx: extend phylink to Serdes PHYs") introduced method mv88e6390_serdes_pcs_config(), which is called (indirectly) by phylink to configure the PCS. This method enables inband AN if requested by phylink. It seems though that for 2500base-x mode some of these

Re: [PATCH 2/2] tools/bpftool: Add -Wall when building BPF programs

2021-01-13 Thread Yonghong Song
On 1/13/21 2:36 PM, Ian Rogers wrote: No additional warnings are generated by enabling this, but having it enabled will help avoid regressions. Signed-off-by: Ian Rogers Acked-by: Yonghong Song

Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > Resending the stragglers again. > > > This set is part of a larger effort attempting to clean-up W=1 > > kern

Re: [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking

2021-01-13 Thread Sukadev Bhattiprolu
Jakub Kicinski [k...@kernel.org] wrote: > On Tue, 12 Jan 2021 10:14:34 -0800 Sukadev Bhattiprolu wrote: > > Use more consistent locking when reading/writing the adapter->state > > field. This patch set fixes a race condition during ibmvnic_open() > > where the adapter could be left in the PROBED st

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 13:12:12 +0100 Jiri Pirko wrote: > This patchset introduces support for modular switch systems. > NVIDIA Mellanox SN4800 is an example of such. It contains 8 slots > to accomodate line cards. Available line cards include: > 16X 100GbE (QSFP28) > 8X 200GbE (QSFP56) > 4X 400GbE (Q

Re: [PATCH v3 1/3] PCI: Disable parity checking if broken_parity is set

2021-01-13 Thread Heiner Kallweit
On 06.01.2021 20:34, Heiner Kallweit wrote: > On 06.01.2021 20:22, Bjorn Helgaas wrote: >> On Wed, Jan 06, 2021 at 06:50:22PM +0100, Heiner Kallweit wrote: >>> If we know that a device has broken parity checking, then disable it. >>> This avoids quirks like in r8169 where on the first parity error

pull-request: can-next 2021-01-13

2021-01-13 Thread Marc Kleine-Budde
ommit f50e2f9f791647aa4e5b19d0064f5cabf630bf6e: hci: llc_shdlc: style: Simplify bool comparison (2021-01-12 20:18:30 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-5.12-20210113 for you to fetch chang

[net-next 01/17] MAINTAINERS: adjust entry to tcan4x5x file split

2021-01-13 Thread Marc Kleine-Budde
From: Lukas Bulwahn Commit 7813887ea972 ("can: tcan4x5x: rename tcan4x5x.c -> tcan4x5x-core.c") and commit 67def4ef8bb9 ("can: tcan4x5x: move regmap code into seperate file") split the file tcan4x5x.c into two files, but missed to adjust the TI TCAN4X5X DEVICE DRIVER section in MAINTAINERS. Henc

[net-next 06/17] can: dev: move skb related into seperate file

2021-01-13 Thread Marc Kleine-Budde
This patch moves the skb related code of the CAN device infrastructure into a separate file. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-6-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/Makefile | 1 + drivers/net/can/dev/dev

[net-next 02/17] MAINTAINERS: CAN network layer: add missing header file can-ml.h

2021-01-13 Thread Marc Kleine-Budde
This patch add the can-ml.h to the list of maintained files of the CAN network layer. Fixes: ffd956eef69b ("can: introduce CAN midlayer private and allocate it automatically") Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-2-...@pengutronix.de Signed-off-by: M

[net-next 05/17] can: dev: move length related code into seperate file

2021-01-13 Thread Marc Kleine-Budde
This patch moves all CAN frame length related code of the CAN device infrastructure into a separate file. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-5-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- MAINTAINERS | 1 + drivers/net

[net-next 04/17] can: dev: move bittiming related code into seperate file

2021-01-13 Thread Marc Kleine-Budde
This patch moves the bittiming related code of the CAN device infrastructure into a separate file. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- MAINTAINERS | 1 + drivers/net/ca

[net-next 10/17] can: length: canfd_sanitize_len(): add function to sanitize CAN-FD data length

2021-01-13 Thread Marc Kleine-Budde
The data field in CAN-FD frames have specifig frame length (0, 1, 2, 3, 4, 5, 6, 7, 8, 12, 16, 20, 24, 32, 48, 64). This function "rounds" up a given length to the next valid CAN-FD frame length. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-10-...@pengutronix

[net-next 07/17] can: dev: move netlink related code into seperate file

2021-01-13 Thread Marc Kleine-Budde
This patch moves the netlink related code of the CAN device infrastructure into a separate file. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-7-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/Makefile | 1 + drivers/net/can/de

[net-next 14/17] can: dev: can_get_echo_skb(): extend to return can frame length

2021-01-13 Thread Marc Kleine-Budde
In order to implement byte queue limits (bql) in CAN drivers, the length of the CAN frame needs to be passed into the networking stack after queueing and after transmission completion. To avoid to calculate this length twice, extend can_get_echo_skb() to return that value. Convert all users of thi

[net-next 12/17] can: dev: extend struct can_skb_priv to hold CAN frame length

2021-01-13 Thread Marc Kleine-Budde
In order to implement byte queue limits (bql) in CAN drivers, the length of the CAN frame needs to be passed into the networking stack after queueing and after transmission completion. To avoid to calculate this length twice, extend the struct can_skb_priv to hold the length of the CAN frame and e

[net-next 15/17] can: dev: can_rx_offload_get_echo_skb(): extend to return can frame length

2021-01-13 Thread Marc Kleine-Budde
In order to implement byte queue limits (bql) in CAN drivers, the length of the CAN frame needs to be passed into the networking stack after queueing and after transmission completion. To avoid to calculate this length twice, extend can_rx_offload_get_echo_skb() to return that value. Convert all u

[net-next 11/17] can: length: can_skb_get_frame_len(): introduce function to get data length of frame in data link layer

2021-01-13 Thread Marc Kleine-Budde
From: Vincent Mailhol This patch adds the function can_skb_get_frame_len() which returns the length of a CAN frame on the data link layer, including Start-of-frame, Identifier, various other bits, the actual data, the CRC, the End-of-frame, the Inter frame spacing. Co-developed-by: Arunachalam S

[net-next 09/17] can: length: can_fd_len2dlc(): simplify length calculcation

2021-01-13 Thread Marc Kleine-Budde
If the length paramter in len2dlc() exceeds the size of the len2dlc array, we return 0xF. This is equal to the last 16 members of the array. This patch removes these members from the array, uses ARRAY_SIZE() for the length check, and returns CANFD_MAX_DLC (which is 0xf). Reviewed-by: Vincent Mail

[net-next 17/17] can: tcan4x5x: remove __packed attribute from struct tcan4x5x_map_buf

2021-01-13 Thread Marc Kleine-Budde
The first member of struct tcan4x5x_map_buf is the struct tcan4x5x_buf_cmd, which has a size of 4 bytes. It's followed by an array of u8. The compiler places the array directly after the struct tcan4x5x_buf_cmd. This patch removes the not needed attribute __packed from the struct tcan4x5x_map_buf.

[net-next 08/17] can: length: convert to kernel coding style

2021-01-13 Thread Marc Kleine-Budde
This patch converts the file into the kernel coding style. Reviewed-by: Vincent Mailhol Link: https://lore.kernel.org/r/2021041930.693847-8-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/length.c | 28 1 file changed, 16 insertions(+

  1   2   3   4   >