Re: [net-next 09/15] net/mlx5e: CT: Support offload of +trk+new ct rules

2021-01-09 Thread Roi Dayan
On 2021-01-08 11:59 PM, Marcelo Ricardo Leitner wrote: Hi, On Thu, Jan 07, 2021 at 09:30:48PM -0800, Saeed Mahameed wrote: @@ -1429,6 +1600,14 @@ mlx5_tc_ct_add_ft_cb(struct mlx5_tc_ct_priv *ct_priv, u16 zone, if (err) goto err_insert; + nf_ct_zone_init(&ctzone, z

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-09 Thread Roi Dayan
On 2021-01-10 9:45 AM, Roi Dayan wrote: On 2021-01-08 11:48 PM, Marcelo Ricardo Leitner wrote: Hi, On Thu, Jan 07, 2021 at 09:30:47PM -0800, Saeed Mahameed wrote: From: Roi Dayan Connection tracking associates the connection state per packet. The first packet of a connection is assigned

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-09 Thread Roi Dayan
On 2021-01-08 11:48 PM, Marcelo Ricardo Leitner wrote: Hi, On Thu, Jan 07, 2021 at 09:30:47PM -0800, Saeed Mahameed wrote: From: Roi Dayan Connection tracking associates the connection state per packet. The first packet of a connection is assigned with the +trk+new state. The connection en

[PATCH iproute2 v3 1/1] build: Fix link errors on some systems

2021-01-09 Thread Roi Dayan
Since moving get_rate() and get_size() from tc to lib, on some systems we fail to link because of missing math lib. Move the functions that require math lib to their own c file and add -lm to dcb that now use those functions. ../lib/libutil.a(utils.o): In function `get_rate': utils.c:(.text+0x10dc

possible deadlock in lock_sock_nested

2021-01-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f6e7a024 Merge tag 'arc-5.11-rc3' of git://git.kernel.org/.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=135c95fb50 kernel config: https://syzkaller.appspot.com/x/.config?x=8aa30b9da402d224 das

[PATCH bpf 2/2] libbpf: allow loading empty BTFs

2021-01-09 Thread Andrii Nakryiko
Empty BTFs do come up (e.g., simple kernel modules with no new types and strings, compared to the vmlinux BTF) and there is nothing technically wrong with them. So remove unnecessary check preventing loading empty BTFs. Reported-by: Christopher William Snowhill Fixes: ("d8123624506c libbpf: Fix B

[PATCH bpf 1/2] bpf: allow empty module BTFs

2021-01-09 Thread Andrii Nakryiko
Some modules don't declare any new types and end up with an empty BTF, containing only valid BTF header and no types or strings sections. This currently causes BTF validation error. There is nothing wrong with such BTF, so fix the issue by allowing module BTFs with no types or strings. Reported-by

[PATCH net-next v5] GTP: add support for flow based tunneling API

2021-01-09 Thread Pravin B Shelar
Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- v4-v5: - coding style changes v3-v4: - add check for

Re: [PATCH] dt-bindings: net: renesas,etheravb: RZ/G2H needs tx-internal-delay-ps

2021-01-09 Thread Jakub Kicinski
On Tue, 5 Jan 2021 16:15:16 +0100 Geert Uytterhoeven wrote: > The merge resolution of the interaction of commits 307eea32b202864c > ("dt-bindings: net: renesas,ravb: Add support for r8a774e1 SoC") and > d7adf6331189cbe9 ("dt-bindings: net: renesas,etheravb: Convert to > json-schema") missed that "

Re: [PATCH 5/7] ibmvnic: use a lock to serialize remove/reset

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 23:12:34 -0800 Sukadev Bhattiprolu wrote: > Use a separate lock to serialze ibmvnic_reset() and ibmvnic_remove() > functions. ibmvnic_reset() schedules work for the worker thread and > ibmvnic_remove() flushes the work before removing the adapter. We > don't want any work to be

Re: [PATCH 2/7] ibmvnic: update reset function prototypes

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 23:12:31 -0800 Sukadev Bhattiprolu wrote: > The reset functions need just the 'reset reason' parameter and not > the ibmvnic_rwi list element. Update the functions so we can simplify > the handling of the ->rwi_list in a follow-on patch. > > Fixes: 2770a7984db5 ("ibmvnic: Intro

Re: [PATCH V2 net-next 1/3] dt-bindings: net: convert Broadcom Starfighter 2 binding to the json-schema

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 6 Jan 2021 22:32:00 +0100 you wrote: > From: Rafał Miłecki > > This helps validating DTS files. Only the current (not deprecated one) > binding was converted. > > Minor changes: > 1. Dropped dsa/dsa.txt referen

Re: [PATCH net-next v4] GTP: add support for flow based tunneling API

2021-01-09 Thread Jakub Kicinski
On Tue, 5 Jan 2021 20:45:05 -0800 Pravin B Shelar wrote: > @@ -477,40 +572,99 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, > struct net_device *dev, >struct gtp_pktinfo *pktinfo) > { > struct gtp_dev *gtp = netdev_priv(dev); > + struct gtpu_metadata

Re: [PATCH V2 net-next 1/3] dt-bindings: net: convert Broadcom Starfighter 2 binding to the json-schema

2021-01-09 Thread Jakub Kicinski
On Wed, 6 Jan 2021 22:32:00 +0100 Rafał Miłecki wrote: > From: Rafał Miłecki > > This helps validating DTS files. Only the current (not deprecated one) > binding was converted. > > Minor changes: > 1. Dropped dsa/dsa.txt references > 2. Updated node name to match dsa.yaml requirement > 3. Fixed

Re: [PATCH net] dt-bindings: net: dwmac: fix queue priority documentation

2021-01-09 Thread Jakub Kicinski
On Tue, 5 Jan 2021 16:47:48 +0100 Sebastien Laveze (OSS) wrote: > From: Seb Laveze > > The priority field is not the queue priority (queue priority is fixed) > but a bitmask of priorities assigned to this queue. > > In receive, priorities relate to tagged frames priorities. > > In transmit, pr

Re: [PATCH net-next 0/8] MPTCP: Add MP_PRIO support and rework local address IDs

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 16:47:54 -0800 you wrote: > Here are some patches we've merged in the MPTCP tree that are ready for > net-next. > > Patches 1 and 2 rework the assignment of local address IDs to allow them > to be assi

Re: [PATCH net-next] r8169: deprecate support for RTL_GIGA_MAC_VER_27

2021-01-09 Thread Jakub Kicinski
On Fri, 8 Jan 2021 13:24:16 +0100 Heiner Kallweit wrote: > RTL8168dp is ancient anyway, and I haven't seen any trace of its early > version 27 yet. This chip versions needs quite some special handling, > therefore it would facilitate driver maintenance if support for it > could be dropped. For now

Re: [PATCH net-next v2 0/3] r8169: small improvements

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 12:55:32 +0100 you wrote: > This series includes a number of smaller improvements. > > v2: > - return on WARN in patch 1 > > Heiner Kallweit (3): > r8169: replace BUG_ON with WARN in _rtl_eri_write >

Re: [PATCH net-next] net: dsa: dsa_legacy_fdb_{add,del} can be static

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 9 Jan 2021 01:30:54 +0200 you wrote: > From: Vladimir Oltean > > Introduced in commit 37b8da1a3c68 ("net: dsa: Move FDB add/del > implementation inside DSA") in net/dsa/legacy.c, these functions were > moved agai

Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-09 Thread Jakub Kicinski
On Fri, 8 Jan 2021 19:59:48 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > Add devlink integration into the mscc_ocelot switchdev driver. Only the > probed interfaces are registered with devlink, because for convenience, > struct devlink_port was included into struct ocelot_port_privat

Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-09 Thread Jakub Kicinski
On Fri, 8 Jan 2021 19:59:48 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > Add devlink integration into the mscc_ocelot switchdev driver. Only the > probed interfaces are registered with devlink, because for convenience, > struct devlink_port was included into struct ocelot_port_privat

Re: [PATCH v3 net-next 04/10] net: dsa: felix: reindent struct dsa_switch_ops

2021-01-09 Thread Jakub Kicinski
On Fri, 8 Jan 2021 19:59:44 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > The devlink function pointer names are super long, and they would break > the alignment. So reindent the existing ops now by adding one tab. Therefore it'd be tempting to prefix them with dl_ rather than full d

Re: [PATCH net-next] net: dsa: felix: the switch does not support DMA

2021-01-09 Thread Florian Fainelli
On 1/9/2021 12:34 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The code that sets the DMA mask to 64 bits is bogus, it is taken from > the enetc driver together with the rest of the PCI probing boilerplate. > > Since this patch is touching the error path to delete err_dma, let's > a

Re: [PATCH v3 net-next 02/10] net: mscc: ocelot: add ops for decoding watermark threshold and occupancy

2021-01-09 Thread Jakub Kicinski
On Fri, 8 Jan 2021 19:59:42 +0200 Vladimir Oltean wrote: > + *inuse = (val & GENMASK(23, 12)) >> 12; FWIW FIELD_GET()

Re: [PATCH net-next] devlink: fix return of uninitialized variable err

2021-01-09 Thread Jakub Kicinski
On Fri, 8 Jan 2021 21:21:13 +0800 wangyunjian wrote: > From: Yunjian Wang > > There is a potential execution path in which variable err is > returned without being properly initialized previously. Fix > this by initializing variable err to 0. > > Addresses-Coverity: ("Uninitialized scalar variab

Re: [PATCH net-next v2 0/6] dpaa2-mac: various updates

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 11:07:21 +0200 you wrote: > The first two patches of this series extends the MAC statistics support > to also work for network interfaces which have their link status handled > by firmware (TYPE_FIXED).

Re: [PATCH net 0/2] mlxsw: core: Thermal control fixes

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 8 Jan 2021 16:52:08 +0200 you wrote: > From: Ido Schimmel > > This series includes two fixes for thermal control in mlxsw. > > Patch #1 validates that the alarm temperature threshold read from a > transceiver is abo

[PATCH net-next v2 01/11] selftests: Move device validation in nettest

2021-01-09 Thread David Ahern
From: David Ahern Later patch adds support for switching network namespaces before running client, server or both. Device validations need to be done after the network namespace switch, so add a helper to do it and invoke in server and client code versus inline with argument parsing. Move related

Re: [net v2] tipc: fix NULL deref in tipc_link_xmit()

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 8 Jan 2021 14:13:37 +0700 you wrote: > From: Hoang Le > > The buffer list can have zero skb as following path: > tipc_named_node_up()->tipc_node_xmit()->tipc_link_xmit(), so > we need to check the list before casting

[PATCH net-next v2 08/11] selftests: Make address validation apply only to client mode

2021-01-09 Thread David Ahern
From: David Ahern When a single instance of nettest is used for client and server make sure address validation is only done for client mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/ne

[PATCH net-next v2 06/11] selftests: Use separate stdout and stderr buffers in nettest

2021-01-09 Thread David Ahern
From: David Ahern When a single instance of nettest is doing both client and server modes, stdout and stderr messages can get interlaced and become unreadable. Allocate a new set of buffers for the child process handling server mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/n

[PATCH net-next v2 10/11] selftests: Add new option for client-side passwords

2021-01-09 Thread David Ahern
From: David Ahern Add new option to nettest to specify MD5 password to use for client side. Update fcnal-test script. This is needed for a single instance running both server and client modes to test password mismatches. Signed-off-by: David Ahern --- tools/testing/selftests/net/fcnal-test.sh

[PATCH net-next v2 11/11] selftests: Add separate options for server device bindings

2021-01-09 Thread David Ahern
From: David Ahern Add new options to nettest to specify device binding and expected device binding for server mode, and update fcnal-test script. This is needed to allow a single instance of nettest running both server and client modes to use different device bindings. Signed-off-by: David Ahern

[PATCH net-next v2 05/11] selftests: Add support to nettest to run both client and server

2021-01-09 Thread David Ahern
From: David Ahern Add option to nettest to run both client and server within a single instance. Client forks a child process to run the server code. A pipe is used for the server to tell the client it has initialized and is ready or had an error. This avoid unnecessary sleeps to handle such race

[PATCH net-next v2 09/11] selftests: Consistently specify address for MD5 protection

2021-01-09 Thread David Ahern
From: David Ahern nettest started with -r as the remote address for MD5 passwords. The -m argument was added to use prefixes with a length when that feature was added to the kernel. Since -r is used to specify remote address for client mode, change nettest to only use -m for MD5 passwords and upd

[PATCH net-next v2 07/11] selftests: Add missing newline in nettest error messages

2021-01-09 Thread David Ahern
From: David Ahern A few logging lines are missing the newline, or need it moved up for cleaner logging. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/net/nettest.c

[PATCH net-next v2 03/11] selftests: Move address validation in nettest

2021-01-09 Thread David Ahern
From: David Ahern IPv6 addresses can have a device name to declare a scope (e.g., fe80::5054:ff:fe12:3456%eth0). The next patch adds support to switch network namespace before running client or server code (or both), so move the address validation to the server and client functions. IPv4 multica

[PATCH net-next v2 00/11] selftests: Updates to allow single instance of nettest for client and server

2021-01-09 Thread David Ahern
Update nettest to handle namespace change internally to allow a single instance to run both client and server modes. Device validation needs to be moved after the namespace change and a few run time options need to be split to allow values for client and server. David Ahern (11): selftests: Move

[PATCH net-next v2 04/11] selftests: Add options to set network namespace to nettest

2021-01-09 Thread David Ahern
From: David Ahern Add options to specify server and client network namespace to use before running respective functions. Signed-off-by: Seth David Schoen Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 56 ++- 1 file changed, 55 insertions(+), 1

[PATCH net-next v2 02/11] selftests: Move convert_addr up in nettest

2021-01-09 Thread David Ahern
From: David Ahern convert_addr needs to be invoked in a different location. Move the code up to avoid a forward declaration. Code move only. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 252 +- 1 file changed, 126 insertions(+), 126 deletions(

Re: [PATCH net-next 0/2] net-gro: GRO_DROP deprecation

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 03:39:01 -0800 you wrote: > From: Eric Dumazet > > GRO_DROP has no practical use and can be removed, > once ice driver is cleaned up. > > This removes one useless conditionel test in napi_gro_frags()

Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2021-01-09 Thread Pali Rohár
On Saturday 09 January 2021 23:19:54 Russell King - ARM Linux admin wrote: > On Sat, Jan 09, 2021 at 08:14:47PM +0100, Pali Rohár wrote: > > On Saturday 09 January 2021 15:46:01 Russell King - ARM Linux admin wrote: > > > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wrote: > > > > On Wed,

Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2021-01-09 Thread Russell King - ARM Linux admin
On Sat, Jan 09, 2021 at 08:14:47PM +0100, Pali Rohár wrote: > On Saturday 09 January 2021 15:46:01 Russell King - ARM Linux admin wrote: > > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wrote: > > > On Wed, Jan 06, 2021 at 04:37:48PM +0100, Pali Rohár wrote: > > > > From: Russell King > >

Re: [PATCH 00/11] selftests: Updates to allow single instance of nettest for client and server

2021-01-09 Thread Jakub Kicinski
On Sat, 9 Jan 2021 16:12:22 -0700 David Ahern wrote: > On 1/9/21 4:04 PM, Jakub Kicinski wrote: > > Do you want to address the checkpatch issues, tho? > > Yes, I thought I had fixed those. Evidently missed a few. Thanks, I'm never sure if people intentionally use different style rules in selfte

Re: [PATCH 00/11] selftests: Updates to allow single instance of nettest for client and server

2021-01-09 Thread David Ahern
On 1/9/21 4:04 PM, Jakub Kicinski wrote: > Do you want to address the checkpatch issues, tho? Yes, I thought I had fixed those. Evidently missed a few.

Re: [PATCH 00/11] selftests: Updates to allow single instance of nettest for client and server

2021-01-09 Thread Jakub Kicinski
On Sat, 9 Jan 2021 11:02:02 -0800 Jakub Kicinski wrote: > On Sat, 9 Jan 2021 11:55:39 -0700 David Ahern wrote: > > On 1/9/21 11:53 AM, David Ahern wrote: > > > Update nettest to handle namespace change internally to allow a > > > single instance to run both client and server modes. Device validat

[PATCH net-next] r8169: make use of the unaligned access helpers

2021-01-09 Thread Heiner Kallweit
Instead of open-coding unaligned access let's use the predefined unaligned access helpers. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169

Re: [PATCH 1/1] r8152: Add Lenovo Powered USB-C Travel Hub

2021-01-09 Thread Jakub Kicinski
On Sat, 09 Jan 2021 10:39:27 +0100 Leon Schuermann wrote: > Jakub Kicinski writes: > > On Fri, 8 Jan 2021 21:27:27 +0100 Leon Schuermann wrote: > >> This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to > >> work with the cdc_ether driver. > > > > When you say "used to work" d

Re: [net] selftests/tls: fix selftests after adding ChaCha20-Poly1305

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 9 Jan 2021 00:37:45 +0300 you wrote: > TLS selftests where broken because of wrong variable types used. > Fix it by changing u16 -> uint16_t > > Fixes: 4f336e88a870 ("selftests/tls: add CHACHA20-POLY1305 to tls selftes

Re: [PATCH net V3] net: ipv6: Validate GSO SKB before finish IPv6 processing

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 7 Jan 2021 15:50:18 +0200 you wrote: > There are cases where GSO segment's length exceeds the egress MTU: > - Forwarding of a TCP GRO skb, when DF flag is not set. > - Forwarding of an skb that arrived on a virtualisa

[PATCH net v2 1/3] net: support kmap_local forced debugging in skb_frag_foreach

2021-01-09 Thread Willem de Bruijn
From: Willem de Bruijn Skb frags may be backed by highmem and/or compound pages. Highmem pages need kmap_atomic mappings to access. But kmap_atomic maps a single page, not the entire compound page. skb_foreach_page iterates over an skb frag, in one step in the common case, page by page only if k

[PATCH net v2 3/3] esp: avoid unneeded kmap_atomic call

2021-01-09 Thread Willem de Bruijn
From: Willem de Bruijn esp(6)_output_head uses skb_page_frag_refill to allocate a buffer for the esp trailer. It accesses the page with kmap_atomic to handle highmem. But skb_page_frag_refill can return compound pages, of which kmap_atomic only maps the first underlying page. skb_page_frag_refi

[PATCH net v2 2/3] net: compound page support in skb_seq_read

2021-01-09 Thread Willem de Bruijn
From: Willem de Bruijn skb_seq_read iterates over an skb, returning pointer and length of the next data range with each call. It relies on kmap_atomic to access highmem pages when needed. An skb frag may be backed by a compound page, but kmap_atomic maps only a single page. There are not enough

[PATCH net v2 0/3] skb frag: kmap_atomic fixes

2021-01-09 Thread Willem de Bruijn
From: Willem de Bruijn skb frags may be backed by highmem and/or compound pages. Various code calls kmap_atomic to safely access highmem pages. But this needs additional care for compound pages. Fix a few issues: patch 1 expect kmap mappings with CONFIG_DEBUG_KMAP_LOCAL_FORCE_MAP patch 2 fixes k

Re: [PATCH net 2/3] net: compound page support in skb_seq_read

2021-01-09 Thread Willem de Bruijn
On Fri, Jan 8, 2021 at 12:11 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > skb_seq_read iterates over an skb, returning pointer and length of > the next data range with each call. > > It relies on kmap_atomic to access highmem pages when needed. > > An skb frag may be backed by a comp

Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 15:36:45 +0100 Andrew Lunn wrote: > > +static void ar9331_get_stats64(struct dsa_switch *ds, int port, > > + struct rtnl_link_stats64 *s) > > +{ > > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv; > > + struct ar9331_sw_port *p = &p

[PATCH net-next 2/2] r8169: tweak max read request size for newer chips also in jumbo mtu mode

2021-01-09 Thread Heiner Kallweit
So far we don't increase the max read request size if we switch to jumbo mode before bringing up the interface for the first time. Let's change this. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH net-next 1/2] r8169: align RTL8168e jumbo pcie read request size with vendor driver

2021-01-09 Thread Heiner Kallweit
Align behavior with r8168 vendor driver and don't reduce max read request size for RTL8168e in jumbo mode. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_mai

[PATCH net-next 0/2] r8169: improve jumbo configuration

2021-01-09 Thread Heiner Kallweit
Small improvements to jumbo configuration. Heiner Kallweit (2): r8169: align RTL8168e jumbo pcie read request size with vendor driver r8169: tweak max read request size for newer chips also in jumbo mtu mode drivers/net/ethernet/realtek/r8169_main.c | 15 +++ 1 file changed,

Re: [PATCH net-next] net/bridge: fix misspellings using codespell tool

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 20:03:49 -0800 Randy Dunlap wrote: > On 1/7/21 6:53 PM, menglong8.d...@gmail.com wrote: > > From: Menglong Dong > > > > Some typos are found out by codespell tool: > > > > $ codespell ./net/bridge/ > > ./net/bridge/br_stp.c:604: permanant ==> permanent > > ./net/bridge/br_stp

Re: [PATCH net-next 0/4] net: ipa: support COMPILE_TEST

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 17:34:00 -0600 Alex Elder wrote: > This series adds the IPA driver as a possible target when > the COMPILE_TEST configuration is enabled. Two small changes to > dependent subsystems needed to be made for this to work. > > Version 2 of this series adds one more patch, which add

Re: [PATCH net 1/1] netxen_nic: fix MSI/MSI-x interrupts

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 02:15:20 -0800 Manish Chopra wrote: > For all PCI functions on the netxen_nic adapter, interrupt > mode (INTx or MSI) configuration is dependent on what has > been configured by the PCI function zero in the shared > interrupt register, as these adapters do not support mixed > mod

Re: [PATCH] changes for Pavana

2021-01-09 Thread Marek Behún
Still one more change needed for 5gabe-r to work. I am going to sent fix 5gbase-r and send this patches myself. I will leave Pavana as the author. Marek

[PATCH] wireguard: netlink: add multicast notification for peer changes

2021-01-09 Thread Linus Lotz
This commit adds a new multicast group to the netlink api for wireguard. The purpose of this multicast group is to notify userspace when the peers of an interface change. Right now this is only done when the endpoint is changed by whatever means. An example for an consumer of this API would be a s

Re: [PATCH net-next v2 3/6] bus: fsl-mc: return -EPROBE_DEFER when a device is not yet discovered

2021-01-09 Thread Andrew Lunn
On Fri, Jan 08, 2021 at 11:07:24AM +0200, Ioana Ciornei wrote: > From: Ioana Ciornei > > The fsl_mc_get_endpoint() should return a pointer to the connected > fsl_mc device, if there is one. By interrogating the MC firmware, we > know if there is an endpoint or not so when the endpoint device is >

Re: [PATCH net-next v2 4/6] dpaa2-eth: retry the probe when the MAC is not yet discovered on the bus

2021-01-09 Thread Andrew Lunn
On Fri, Jan 08, 2021 at 11:07:25AM +0200, Ioana Ciornei wrote: > From: Ioana Ciornei > > The fsl_mc_get_endpoint() function now returns -EPROBE_DEFER when the > dpmac device was not yet discovered by the fsl-mc bus. When this > happens, pass the error code up so that we can retry the probe at a >

Re: [PATCH] net/ipv6: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'.

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 10:47:34 +0800 Jiapeng Zhong wrote: > The print format of this parameter does not match, because it is defined > as int type, so modify the matching format of this parameter to %d format. > > Signed-off-by: Jiapeng Zhong > Reported-by: Abaci > --- > net/ipv6/proc.c | 2 +- >

WARNING in rds_rdma_extra_size

2021-01-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:6207214a Merge tag 'afs-fixes-04012021' of git://git.kerne.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=146967c0d0 kernel config: https://syzkaller.appspot.com/x/.config?x=8aa30b9da402d224 das

Re: Kernel panic on shutdown (qede+bond+bridge) - KASAN: use-after-free in netif_skb_features+0x90a/0x9b0

2021-01-09 Thread Jakub Kicinski
On Thu, 07 Jan 2021 00:15:24 +0100 Igor Raits wrote: > I've been trying out the latest CentOS 8 Stream kernel and found that I > get kernel panic (https://bugzilla.redhat.com/show_bug.cgi?id=1913481) > when trying to reboot the server. With debug kernel I've got following: > > [ 531.818434] > ===

Re: [PATCH net-next] ibmvnic: merge do_change_param_reset into do_reset

2021-01-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 6 Jan 2021 15:35:14 -0600 you wrote: > Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so > linkwatch_event can run") introduced do_change_param_reset function to > solve the rtnl lock issue. Majority

[PATCH net-next] net: dsa: felix: the switch does not support DMA

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean The code that sets the DMA mask to 64 bits is bogus, it is taken from the enetc driver together with the rest of the PCI probing boilerplate. Since this patch is touching the error path to delete err_dma, let's also change the err_alloc_felix label which was incorrect. The

WARNING in bpf_prog_test_run_raw_tp

2021-01-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f6e7a024 Merge tag 'arc-5.11-rc3' of git://git.kernel.org/.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=16f6472b50 kernel config: https://syzkaller.appspot.com/x/.config?x=8aa30b9da402d224 dashboar

Re: [PATCH] Incorrect filename in drivers/net/phy/Makefile

2021-01-09 Thread Randy Dunlap
On 1/9/21 11:48 AM, Andrew Lunn wrote: > On Sat, Jan 09, 2021 at 10:17:38AM +0100, Zhi Han wrote: >> Thanks a lot for the .config file. >> I also tested it, with mdio-bus.o in the Makefile, glad to got that there is >> no problem of that, although I don't know the reason/trick yet. > > I'm not 100

Re: [PATCH] Incorrect filename in drivers/net/phy/Makefile

2021-01-09 Thread Andrew Lunn
On Sat, Jan 09, 2021 at 10:17:38AM +0100, Zhi Han wrote: > Thanks a lot for the .config file. > I also tested it, with mdio-bus.o in the Makefile, glad to got that there is > no problem of that, although I don't know the reason/trick yet. I'm not 100% sure, but i think: obj-$(CONFIG_MDIO_DEVICE)

Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2021-01-09 Thread Pali Rohár
On Saturday 09 January 2021 15:46:01 Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wrote: > > On Wed, Jan 06, 2021 at 04:37:48PM +0100, Pali Rohár wrote: > > > From: Russell King > > > > > > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have

Re: [PATCH 00/11] selftests: Updates to allow single instance of nettest for client and server

2021-01-09 Thread Jakub Kicinski
On Sat, 9 Jan 2021 11:55:39 -0700 David Ahern wrote: > On 1/9/21 11:53 AM, David Ahern wrote: > > Update nettest to handle namespace change internally to allow a > > single instance to run both client and server modes. Device validation > > needs to be moved after the namespace change and a few run

[PATCH 05/11] selftests: Add support to nettest to run both client and server

2021-01-09 Thread David Ahern
From: David Ahern Add option to nettest to run both client and server within a single instance. Client forks a child process to run the server code. A pipe is used for the server to tell the client it has initialized and is ready or had an error. This avoid unnecessary sleeps to handle such race

[PATCH 02/11] selftests: Move convert_addr up in nettest

2021-01-09 Thread David Ahern
From: David Ahern convert_addr needs to be invoked in a different location. Move the code up to avoid a forward declaration. Code move only. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 252 +- 1 file changed, 126 insertions(+), 126 deletions(

[PATCH 03/11] selftests: Move address validation in nettest

2021-01-09 Thread David Ahern
From: David Ahern IPv6 addresses can have a device name to declare a scope (e.g., fe80::5054:ff:fe12:3456%eth0). The next patch adds support to switch network namespace before running client or server code (or both), so move the address validation to the server and client functions. IPv4 multica

Re: [PATCH 00/11] selftests: Updates to allow single instance of nettest for client and server

2021-01-09 Thread David Ahern
On 1/9/21 11:53 AM, David Ahern wrote: > Update nettest to handle namespace change internally to allow a > single instance to run both client and server modes. Device validation > needs to be moved after the namespace change and a few run time > options need to be split to allow values for client a

[PATCH 01/11] selftests: Move device validation in nettest

2021-01-09 Thread David Ahern
From: David Ahern Later patch adds support for switching network namespaces before running client, server or both. Device validations need to be done after the network namespace switch, so add a helper to do it and invoke in server and client code versus inline with argument parsing. Move related

[PATCH 04/11] selftests: Add options to set network namespace to nettest

2021-01-09 Thread David Ahern
From: David Ahern Add options to specify server and client network namespace to use before running respective functions. Signed-off-by: Seth David Schoen Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 56 ++- 1 file changed, 55 insertions(+), 1

[PATCH 09/11] selftests: Consistently specify address for MD5 protection

2021-01-09 Thread David Ahern
From: David Ahern nettest started with -r as the remote address for MD5 passwords. The -m argument was added to use prefixes with a length when that feature was added to the kernel. Since -r is used to specify remote address for client mode, change nettest to only use -m for MD5 passwords and upd

[PATCH 10/11] selftests: Add new option for client-side passwords

2021-01-09 Thread David Ahern
From: David Ahern Add new option to nettest to specify MD5 password to use for client side. Update fcnal-test script. This is needed for a single instance running both server and client modes to test password mismatches. Signed-off-by: David Ahern --- tools/testing/selftests/net/fcnal-test.sh

[PATCH 06/11] selftests: Use separate stdout and stderr buffers in nettest

2021-01-09 Thread David Ahern
From: David Ahern When a single instance of nettest is doing both client and server modes, stdout and stderr messages can get interlaced and become unreadable. Allocate a new set of buffers for the child process handling server mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/n

[PATCH 11/11] selftests: Add separate options for server device bindings

2021-01-09 Thread David Ahern
From: David Ahern Add new options to nettest to specify device binding and expected device binding for server mode, and update fcnal-test script. This is needed to allow a single instance of nettest running both server and client modes to use different device bindings. Signed-off-by: David Ahern

[PATCH 07/11] selftests: Add missing newline in nettest error messages

2021-01-09 Thread David Ahern
From: David Ahern A few logging lines are missing the newline, or need it moved up for cleaner logging. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/net/nettest.c

[PATCH 08/11] selftests: Make address validation apply only to client mode

2021-01-09 Thread David Ahern
From: David Ahern When a single instance of nettest is used for client and server make sure address validation is only done for client mode. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/ne

[PATCH 00/11] selftests: Updates to allow single instance of nettest for client and server

2021-01-09 Thread David Ahern
Update nettest to handle namespace change internally to allow a single instance to run both client and server modes. Device validation needs to be moved after the namespace change and a few run time options need to be split to allow values for client and server. David Ahern (11): selftests: Move

memory leak in tcp_cdg_init

2021-01-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:36bbbd0e Merge branch 'rcu/urgent' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16ef4dfb50 kernel config: https://syzkaller.appspot.com/x/.config?x=b991a69440391446 das

[PATCH v6 net-next 12/15] net: openvswitch: ensure dev_get_stats can sleep

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean There is an effort to convert .ndo_get_stats64 to sleepable context, and for that to work, we need to prevent callers of dev_get_stats from using atomic locking. The OVS vport driver calls ovs_vport_get_stats from ovs_vport_cmd_fill_info, a function with 7 callers: 5 under

[PATCH v6 net-next 08/15] net: allow ndo_get_stats64 to return an int error code

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean Some drivers need to do special tricks to comply with the new policy of ndo_get_stats64 being sleepable. For example, the bonding driver, which derives its stats from its lower interfaces, must recurse with dev_get_stats into its lowers with no locks held. But for that to wo

[PATCH v6 net-next 01/15] net: mark dev_base_lock for deprecation

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean There is a movement to eliminate the usage of dev_base_lock, which exists since as far as I could track the kernel history down (the "7a2deb329241 Import changeset" commit from the bitkeeper branch). The dev_base_lock approach has multiple issues: - It is global and not per

[PATCH v6 net-next 15/15] net: mark ndo_get_stats64 as being able to sleep

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean Now that all callers have been converted to not use atomic context when calling dev_get_stats, it is time to update the documentation and put a notice in the function that it expects process context. Signed-off-by: Vladimir Oltean --- Changes in v6: Rebase on top of Jakub'

[PATCH v6 net-next 11/15] net: catch errors from dev_get_stats

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean dev_get_stats can now return error codes. Convert all remaining call sites to look at that error code and stop processing. The effects of simulating a kernel error (returning -ENOMEM) upon existing programs or kernel interfaces: - ifconfig and "cat /proc/net/dev" print up

[PATCH v6 net-next 09/15] scsi: fcoe: propagate errors from dev_get_stats

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean The FCoE callback for the Link Error Status Block retrieves the FCS error count using dev_get_stats. This function can now return errors. Propagate these all the way to the sysfs device attributes. Signed-off-by: Vladimir Oltean --- Changes in v6: None. Changes in v5: Non

[PATCH v6 net-next 14/15] net: bonding: ensure .ndo_get_stats64 can sleep

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean There is an effort to convert .ndo_get_stats64 to sleepable context, and for that to work, we need to prevent callers of dev_get_stats from using atomic locking. The bonding driver retrieves its statistics recursively from its lower interfaces, with additional care to only

[PATCH v6 net-next 13/15] net: net_failover: ensure .ndo_get_stats64 can sleep

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean The failover framework sets up a virtio_net interface [ when it has the VIRTIO_NET_F_STANDBY feature ] and a VF interface, having the same MAC address, in a standby/active relationship. When the active VF is unplugged, the standby virtio_net temporarily kicks in. The failov

[PATCH v6 net-next 10/15] net: openvswitch: propagate errors from dev_get_stats

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean The dev_get_stats function can now return an error code, so the code that retrieves vport statistics and sends them through netlink needs to propagate that error code. Modify the drastic BUG_ON checks to operate only on the -EMSGSIZE error code (the only error code previous

[PATCH v6 net-next 07/15] net: remove return value from dev_get_stats

2021-01-09 Thread Vladimir Oltean
From: Vladimir Oltean After commit 28172739f0a2 ("net: fix 64 bit counters on 32 bit arches"), dev_get_stats got an additional argument for storage of statistics. At this point, dev_get_stats could return either the passed "storage" argument, or the output of .ndo_get_stats64. Then commit caf586

  1   2   >