Re: [PATCH] Bluetooth: avoid u128_xor() on potentially misaligned inputs

2021-01-05 Thread Marcel Holtmann
Hi Ard, > u128_xor() takes pointers to quantities that are assumed to be at least > 64-bit aligned, which is not guaranteed to be the case in the smp_c1() > routine. So switch to crypto_xor() instead. > > Signed-off-by: Ard Biesheuvel > --- > net/bluetooth/smp.c | 5 ++--- > 1 file changed, 2 ins

Re: [net] cxgb4: advertise NETIF_F_HW_CSUM

2021-01-05 Thread Tariq Toukan
On 1/5/2021 10:29 PM, Jakub Kicinski wrote: On Tue, 5 Jan 2021 22:27:49 +0530 Rohit Maheshwari wrote: advertise NETIF_F_HW_CSUM instead of protocol specific values of NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM. This change is added long back in other drivers. This issue is seen recently when TLS

Re: [PATCH net] net: lapb: Decrease the refcount of "struct lapb_cb" in lapb_device_event

2021-01-05 Thread Martin Schiller
On 2020-12-31 18:43, Xie He wrote: In lapb_device_event, lapb_devtostruct is called to get a reference to an object of "struct lapb_cb". lapb_devtostruct increases the refcount of the object and returns a pointer to it. However, we didn't decrease the refcount after we finished using the pointer.

Re: [PATCH net-next 3/3] net: ipa: support COMPILE_TEST

2021-01-05 Thread kernel test robot
Hi Alex, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Alex-Elder/net-ipa-support-COMPILE_TEST/20210106-104149 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3db1a3fa988

Re: [PATCH AUTOSEL 5.4 075/130] net/lapb: fix t1 timer handling for LAPB_STATE_0

2021-01-05 Thread Martin Schiller
On 2020-12-24 10:49, Xie He wrote: On Wed, Dec 23, 2020 at 9:01 AM Xie He wrote: I don't think this patch is suitable for stable branches. This patch is part of a patch series that changes the lapb module from "establishing the L2 connection only when needed by L3", to "establishing the L2

[PATCH net-next 2/2] net: broadcom: share header defining UniMAC registers

2021-01-05 Thread Rafał Miłecki
From: Rafał Miłecki UniMAC is integrated into multiple Broadcom's Ethernet controllers so use a shared header file for it and avoid some code duplication. Signed-off-by: Rafał Miłecki --- MAINTAINERS | 2 + drivers/net/ethernet/broadcom/bcmsysport.h| 35 +

[PATCH net-next 1/2] bgmac: add bgmac_umac_*() helpers for accessing UniMAC registers

2021-01-05 Thread Rafał Miłecki
From: Rafał Miłecki UniMAC is a hardware block commonly used in Broadcom Ethernet controllers that should get its own header file. Not every controller has it mapped at the 0x800 offset so add bgmac access helpers. They will allow using shared register defines. Signed-off-by: Rafał Miłecki ---

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Bartosz Golaszewski
On Tue, Jan 5, 2021 at 12:03 AM Rob Herring wrote: > > DT properties which can have multiple entries need to specify what the > entries are and define how many entries there can be. In the case of > only a single entry, just 'maxItems: 1' is sufficient. > > Add the missing entry constraints. These

[PATCH bpf-next 1/4] selftests/bpf: sync RCU before unloading bpf_testmod

2021-01-05 Thread Andrii Nakryiko
If some of the subtests use module BTFs through ksyms, they will cause bpf_prog to take a refcount on bpf_testmod module, which will prevent it from successfully unloading. Module's refcnt is decremented when bpf_prog is freed, which generally happens in RCU callback. So we need to trigger syncroni

[PATCH bpf-next 4/4] selftests/bpf: test kernel module ksym externs

2021-01-05 Thread Andrii Nakryiko
Add per-CPU variable to bpf_testmod.ko and use those from new selftest to validate it works end-to-end. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/bpf_testmod/bpf_testmod.c | 3 ++ .../selftests/bpf/prog_tests/ksyms_module.c | 33 +++ .../selftests/bpf/progs/test_k

[PATCH bpf-next 3/4] libbpf: support kernel module ksym externs

2021-01-05 Thread Andrii Nakryiko
Add support for searching for ksym externs not just in vmlinux BTF, but across all module BTFs, similarly to how it's done for CO-RE relocations. Kernels that expose module BTFs through sysfs are assumed to support new ldimm64 instruction extension with BTF FD provided in insn[1].imm field, so no e

[PATCH bpf-next 2/4] bpf: support BPF ksym variables in kernel modules

2021-01-05 Thread Andrii Nakryiko
Add support for directly accessing kernel module variables from BPF programs using special ldimm64 instructions. This functionality builds upon vmlinux ksym support, but extends ldimm64 with src_reg=BPF_PSEUDO_BTF_ID to allow specifying kernel module BTF's FD in insn[1].imm field. During BPF progr

[PATCH bpf-next 0/4] Support kernel module ksym variables

2021-01-05 Thread Andrii Nakryiko
Add support for using kernel module global variables (__ksym externs in BPF program). BPF verifier will now support ldimm64 with src_reg=BPF_PSEUDO_BTF_ID and non-zero insn[1].imm field, specifying module BTF's FD. In such case, module BTF object, similarly to BPF maps referenced from ldimm64 with

Re: [PATCH 05/10] dma: tx49 removal

2021-01-05 Thread Vinod Koul
On 05-01-21, 15:02, Thomas Bogendoerfer wrote: > Signed-off-by: Thomas Bogendoerfer Applied after fixing subsystem name, thanks -- ~Vinod

[PATCH ipsec-next] xfrm: interface: enable TSO on xfrm interfaces

2021-01-05 Thread Eyal Birger
Underlying xfrm output supports gso packets. Declare support in hw_features and adapt the xmit MTU check to pass GSO packets. Signed-off-by: Eyal Birger --- net/xfrm/xfrm_interface.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_interface.c b/net/xfr

Re: [PATCH bpf-next 3/3] selftests/bpf: add tests for user- and non-CO-RE BPF_CORE_READ() variants

2021-01-05 Thread Alexei Starovoitov
On Tue, Jan 05, 2021 at 01:03:47PM -0800, Andrii Nakryiko wrote: > > > > > > - handling 32-bit vs 64-bit UAPI structs uniformly; > > > > what do you mean? > > 32-bit user space running on 64-bit kernel works through 'compat' syscalls. > > If bpf progs are accessing 64-bit uapi structs in such cas

Re: [PATCH v2] net: qrtr: fix null pointer dereference in qrtr_ns_remove

2021-01-05 Thread Qinglang Miao
Hi Markus, I'd like to take some of your advice in this patch, but I noticed that this one has been applied. Some of your advice would be considered kindly on my future work. Thanks. 在 2021/1/5 21:14, Markus Elfring 写道: A null-ptr-deref bug is reported by Hulk Robot like this: Can it be c

Re: [PATCH mlx5-next 0/4] Dynamically assign MSI-X vectors count

2021-01-05 Thread Leon Romanovsky
On Sun, Jan 03, 2021 at 10:24:36AM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > The number of MSI-X vectors is PCI property visible through lspci, that > field is read-only and configured by the device. > > The static assignment of an amount of MSI-X vectors doesn't allow util

Re: [PATCH v3 4/4] bpf: add tests for ints larger than 128 bits

2021-01-05 Thread Andrii Nakryiko
On Tue, Jan 5, 2021 at 6:45 AM Sean Young wrote: > > clang supports arbitrary length ints using the _ExtInt extension. This > can be useful to hold very large values, e.g. 256 bit or 512 bit types. > > Larger types (e.g. 1024 bits) are possible but I am unaware of a use > case for these. > > This

Re: [PATCH v3 1/4] btf: add support for ints larger than 128 bits

2021-01-05 Thread Andrii Nakryiko
On Tue, Jan 5, 2021 at 9:10 PM Andrii Nakryiko wrote: > > On Tue, Jan 5, 2021 at 6:45 AM Sean Young wrote: > > > > clang supports arbitrary length ints using the _ExtInt extension. This > > can be useful to hold very large values, e.g. 256 bit or 512 bit types. > > > > Larger types (e.g. 1024 bit

Re: [PATCH v3 3/4] bpftool: add support for ints larger than 128 bits

2021-01-05 Thread Andrii Nakryiko
On Tue, Jan 5, 2021 at 6:45 AM Sean Young wrote: > > clang supports arbitrary length ints using the _ExtInt extension. This > can be useful to hold very large values, e.g. 256 bit or 512 bit types. > > This requires the _ExtInt extension enabled in clang, which is under > review. > > Link: > http

Re: [PATCH v3 1/4] btf: add support for ints larger than 128 bits

2021-01-05 Thread Andrii Nakryiko
On Tue, Jan 5, 2021 at 6:45 AM Sean Young wrote: > > clang supports arbitrary length ints using the _ExtInt extension. This > can be useful to hold very large values, e.g. 256 bit or 512 bit types. > > Larger types (e.g. 1024 bits) are possible but I am unaware of a use > case for these. > > This

[PATCH net-next v4] GTP: add support for flow based tunneling API

2021-01-05 Thread Pravin B Shelar
Following patch add support for LWT flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- v3-v4: - add check for non-zero dst port v2-v3: -

[PATCH net 6/7] chtls: Added a check to avoid NULL pointer dereference

2021-01-05 Thread Ayush Sawal
In case of server removal lookup_stid() may return NULL pointer, which is used as listen_ctx. So added a check before accessing this pointer. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Vinay Kumar Yadav Signed-off-by: Ayush Sawal --- drivers/net/ethernet/chel

[PATCH net 5/7] chtls: Replace skb_dequeue with skb_peek

2021-01-05 Thread Ayush Sawal
The skb is unlinked twice, one in __skb_dequeue in function chtls_reset_synq() and another in cleanup_syn_rcv_conn(). So in this patch using skb_peek() instead of __skb_dequeue(), so that unlink will be handled only in cleanup_syn_rcv_conn(). Fixes: cc35c88ae4db ("crypto : chtls - CPL handler defi

[PATCH net 7/7] chtls: Fix chtls resources release sequence

2021-01-05 Thread Ayush Sawal
CPL_ABORT_RPL is sent after releasing the resources by calling chtls_release_resources(sk); and chtls_conn_done(sk); eventually causing kernel panic. Fixing it by calling release in appropriate order. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Vinay Kumar Yadav

[PATCH net 4/7] chtls: Avoid unnecessary freeing of oreq pointer

2021-01-05 Thread Ayush Sawal
In chtls_pass_accept_request(), removing the chtls_reqsk_free() call to avoid oreq freeing twice. Here oreq is the pointer to struct request_sock. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal --- drivers/net/ethernet/

[PATCH net 3/7] chtls: Fix panic when route to peer not configured

2021-01-05 Thread Ayush Sawal
If route to peer is not configured, we might get non tls devices from dst_neigh_lookup() which is invalid, adding a check to avoid it. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal --- .../chelsio/inline_crypto/chtls/c

[PATCH net 0/7] Bug fixes for chtls driver

2021-01-05 Thread Ayush Sawal
patch 1: Fix hardware tid leak. patch 2: Remove invalid set_tcb call. patch 3: Fix panic when route to peer not configured. patch 4: Avoid unnecessary freeing of oreq pointer. patch 5: Replace skb_dequeue with skb_peek. patch 6: Added a check to avoid NULL pointer dereference patch. patch 7: Fix ch

[PATCH net 2/7] chtls: Remove invalid set_tcb call

2021-01-05 Thread Ayush Sawal
At the time of SYN_RECV, connection information is not initialized at FW, updating tcb flag over uninitialized connection causes adapter crash. We don't need to update the flag during SYN_RECV state, so avoid this. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohi

[PATCH net 1/7] chtls: Fix hardware tid leak

2021-01-05 Thread Ayush Sawal
send_abort_rpl() is not calculating cpl_abort_req_rss offset and ends up sending wrong TID with abort_rpl WR causng tid leaks. Replaced send_abort_rpl() with chtls_send_abort_rpl() as it is redundant. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohit Maheshwari

Re: [PATCH 2/3] hv_netvsc: Wait for completion on request NVSP_MSG4_TYPE_SWITCH_DATA_PATH

2021-01-05 Thread kernel test robot
Hi Long, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc2 next-20210104] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documente

[PATCH] ptp: ptp_ines: prevent build when HAS_IOMEM is not set

2021-01-05 Thread Randy Dunlap
ptp_ines.c uses devm_platform_ioremap_resource(), which is only built/available when CONFIG_HAS_IOMEM is enabled. CONFIG_HAS_IOMEM is not enabled for arch/s390/, so builds on S390 have a build error: s390-linux-ld: drivers/ptp/ptp_ines.o: in function `ines_ptp_ctrl_probe': ptp_ines.c:(.text+0x17e6

Re: [PATCH netdev 0/5] virtio-net support xdp socket zero copy xmit

2021-01-05 Thread Jason Wang
On 2021/1/6 上午10:55, Xuan Zhuo wrote: On Wed, 6 Jan 2021 10:46:43 +0800, Jason Wang wrote: On 2021/1/5 下午8:42, Xuan Zhuo wrote: On Tue, 5 Jan 2021 17:32:19 +0800, Jason Wang wrote: On 2021/1/5 下午5:11, Xuan Zhuo wrote: The first patch made some adjustments to xsk. Thanks a lot for the wor

RE: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-05 Thread Dongseok Yi
On 2021-01-06 12:07, Willem de Bruijn wrote: > > On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote: > > > > On 2021-01-05 06:03, Willem de Bruijn wrote: > > > > > > On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > > > > > > > skbs in frag_list could be shared by pskb_expand_head() from BPF.

Re: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-05 Thread Willem de Bruijn
On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote: > > On 2021-01-05 06:03, Willem de Bruijn wrote: > > > > On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > > > > > skbs in frag_list could be shared by pskb_expand_head() from BPF. > > > > Can you elaborate on the BPF connection? > > With the

Re: [PATCH netdev 0/5] virtio-net support xdp socket zero copy xmit

2021-01-05 Thread Jason Wang
On 2021/1/5 下午8:42, Xuan Zhuo wrote: On Tue, 5 Jan 2021 17:32:19 +0800, Jason Wang wrote: On 2021/1/5 下午5:11, Xuan Zhuo wrote: The first patch made some adjustments to xsk. Thanks a lot for the work. It's rather interesting. The second patch itself can be used as an independent patch to

[PATCH net-next 2/3] soc: qcom: mdt_loader: define stubs for COMPILE_TEST

2021-01-05 Thread Alex Elder
Define stub functions for the exposed MDT functions in case QCOM_MDT_LOADER is not configured. This allows users of these functions to link correctly for COMPILE_TEST builds without QCOM_SCM enabled. Signed-off-by: Alex Elder --- include/linux/soc/qcom/mdt_loader.h | 35

[PATCH net-next 3/3] net: ipa: support COMPILE_TEST

2021-01-05 Thread Alex Elder
Arrange for the IPA driver to be built when COMPILE_TEST is enabled. Update the help text to reflect that we support two Qualcomm SoCs. Suggested-by: Jakub Kicinski Signed-off-by: Alex Elder --- drivers/net/ipa/Kconfig | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --gi

[PATCH net-next 1/3] remoteproc: qcom: expose types for COMPILE_TEST

2021-01-05 Thread Alex Elder
Stub functions are defined for SSR notifier registration in case QCOM_RPROC_COMMON is not configured. As a result, code that uses these functions can link successfully even if the common remoteproc code is not built. Code that registers an SSR notifier function likely needs the types defined in "

[PATCH net-next 0/3] net: ipa: support COMPILE_TEST

2021-01-05 Thread Alex Elder
This series adds the IPA driver as a possible target when the COMPILE_TEST configuration is enabled. Two small changes to dependent subsystems needed to be made for this to work. David/Jakub, it would be best to take all three of these patches through the same tree. I have discussed this with Bj

Re: [PATCHv2 bpf-next] tools/resolve_btfids: Warn when having multiple IDs for single type

2021-01-05 Thread Alexei Starovoitov
On Tue, Jan 5, 2021 at 3:42 PM Jiri Olsa wrote: > > The kernel image can contain multiple types (structs/unions) > with the same name. This causes distinct type hierarchies in > BTF data and makes resolve_btfids fail with error like: > > BTFIDS vmlinux > FAILED unresolved symbol udp6_sock > > a

[PATCH] net: dsa: fix led_classdev build errors

2021-01-05 Thread Randy Dunlap
Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y. This limits the latter to =m when LEDS_CLASS=m. microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_setup': (.text+0xf80): undefined reference to `led_classdev_register_ext' microblaze-l

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Dmitry Torokhov
On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > .../input/touchscreen/elan,elants_i2c.yaml| 1 + Acked-by: Dmitry Torokhov -- Dmitry

RE: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-05 Thread Dongseok Yi
On 2021-01-05 06:03, Willem de Bruijn wrote: > > On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > > > skbs in frag_list could be shared by pskb_expand_head() from BPF. > > Can you elaborate on the BPF connection? With the following registered ptypes, /proc/net # cat ptype Type Device

[PATCH 3/3] hv_netvsc: Process NETDEV_GOING_DOWN on VF hot remove

2021-01-05 Thread Long Li
From: Long Li On VF hot remove, NETDEV_GOING_DOWN is sent to notify the VF is about to go down. At this time, the VF is still sending/receiving traffic and we request the VSP to switch datapath. On completion, the datapath is switched to synthetic and we can proceed with VF hot remove. Signed-o

[PATCH 2/3] hv_netvsc: Wait for completion on request NVSP_MSG4_TYPE_SWITCH_DATA_PATH

2021-01-05 Thread Long Li
From: Long Li The completion indicates if NVSP_MSG4_TYPE_SWITCH_DATA_PATH has been processed by the VSP. The traffic is steered to VF or synthetic after we receive this completion. Signed-off-by: Long Li --- drivers/net/hyperv/netvsc.c | 34 +++-- drivers/net/hy

[PATCH 1/3] hv_netvsc: Check VF datapath when sending traffic to VF

2021-01-05 Thread Long Li
From: Long Li The driver needs to check if the datapath has been switched to VF before sending traffic to VF. Signed-off-by: Long Li --- drivers/net/hyperv/netvsc_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/ne

Re: [PATCH net-next V3 0/2] net: ks8851: Add KS8851 PHY support

2021-01-05 Thread David Miller
From: Marek Vasut Date: Tue, 5 Jan 2021 15:11:49 +0100 > The KS8851 has a reduced internal PHY, which is accessible through its > registers at offset 0xe4. The PHY is compatible with KS886x PHY present > in Micrel switches, including the PHY ID Low/High registers swap, which > is present both in

Re: [PATCH] selftests: fix the return value for UDP GRO test

2021-01-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 5 Jan 2021 18:17:40 +0800 you wrote: > The udpgro.sh will always return 0 (unless the bpf selftest was not > build first) even if there are some failed sub test-cases. > > Therefore the kselftest framework will report

Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Heiner Kallweit
On 06.01.2021 01:52, Russell King - ARM Linux admin wrote: > On Wed, Jan 06, 2021 at 01:44:03AM +0100, Heiner Kallweit wrote: >> The machine type check is there to protect from (theoretical) cases >> where the n2100 code (incl. the RTL8169 quirk) may be compiled in, >> but the kernel is used on ano

Re: [PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-05 Thread David Miller
From: Michael Ellerman Date: Tue, 5 Jan 2021 20:15:15 +1100 > Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() > into error") the ppc32_allmodconfig build fails with: > > ERROR: modpost: missing MODULE_LICENSE() in > drivers/net/ethernet/freescale/fs_enet/mii-fec.o > ERRO

Re: [PATCH net v2] macvlan: remove redundant null check on data

2021-01-05 Thread David Miller
From: wangyunjian Date: Tue, 5 Jan 2021 14:31:34 +0800 > From: Yunjian Wang > > Because macvlan_common_newlink() and macvlan_changelink() already > checked NULL data parameter, so the additional check is unnecessary, > just remove it. > > Fixes: 79cf79abce71 ("macvlan: add source mode") > Sign

Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Russell King - ARM Linux admin
On Wed, Jan 06, 2021 at 01:44:03AM +0100, Heiner Kallweit wrote: > The machine type check is there to protect from (theoretical) cases > where the n2100 code (incl. the RTL8169 quirk) may be compiled in, > but the kernel is used on another machine. That is far from a theoretical case. The ARM port

Re: [PATCH net,stable v3] net: cdc_ncm: correct overhead in delayed_ndp_size

2021-01-05 Thread David Miller
From: Jouni Seppänen Date: Tue, 5 Jan 2021 06:52:49 +0200 > From: Jouni K. Seppänen > > Aligning to tx_ndp_modulus is not sufficient because the next align > call can be cdc_ncm_align_tail, which can add up to ctx->tx_modulus + > ctx->tx_remainder - 1 bytes. This used to lead to occasional cra

Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Russell King - ARM Linux admin
On Tue, Jan 05, 2021 at 06:28:33PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 05, 2021 at 10:42:31AM +0100, Heiner Kallweit wrote: > > { > > - if (dev->bus->number == 0 && > > - (dev->devfn == PCI_DEVFN(1, 0) || > > -dev->devfn == PCI_DEVFN(2, 0))) > > - dev->broken_parity

Re: [PATCH v2] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

2021-01-05 Thread David Miller
From: Qinglang Miao Date: Tue, 5 Jan 2021 13:57:54 +0800 > A null-ptr-deref bug is reported by Hulk Robot like this: > -- > KASAN: null-ptr-deref in range [0x0128-0x012f] > Call Trace: > qrtr_ns_remove+0x22/0x40 [ns] > qrtr_proto_fini+0xa/0x31 [qrtr] > __x64_sy

Re: [PATCH net 0/3] net: hns3: fixes for -net

2021-01-05 Thread David Miller
From: Huazhong Tan Date: Tue, 5 Jan 2021 11:37:25 +0800 > There are some bugfixes for the HNS3 ethernet driver. Series applies and queued up for -stable, thanks

[net-next PATCH v12 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-05 Thread Pavana Sharma
Thanks Marek for catching this. I will have a closer look and update the patchset.

Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Heiner Kallweit
On 06.01.2021 01:28, Bjorn Helgaas wrote: > On Tue, Jan 05, 2021 at 10:42:31AM +0100, Heiner Kallweit wrote: >> Simplify the quirk by using new PCI core function >> pci_quirk_broken_parity(). In addition make the quirk >> more specific, use device id 0x8169 instead of PCI_ANY_ID. >> >> Signed-off-b

Re: [PATCH net v2] docs: net: fix documentation on .ndo_get_stats

2021-01-05 Thread David Miller
From: Jakub Kicinski Date: Mon, 4 Jan 2021 17:22:24 -0800 > Fix calling context. > > Signed-off-by: Jakub Kicinski Applied, thanks.

[net PATCH 2/2] tools: selftests: add test for changing routes with PTMU exceptions

2021-01-05 Thread Sean Tranchetti
From: Sean Tranchetti Adds new 2 new tests to the PTMU script: pmtu_ipv4/6_route_change. These tests explicitly test for a recently discovered problem in the IPv6 routing framework where PMTU exceptions were not properly released when replacing a route via "ip route change ...". After creating

Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Bjorn Helgaas
On Tue, Jan 05, 2021 at 10:42:31AM +0100, Heiner Kallweit wrote: > Simplify the quirk by using new PCI core function > pci_quirk_broken_parity(). In addition make the quirk > more specific, use device id 0x8169 instead of PCI_ANY_ID. > > Signed-off-by: Heiner Kallweit > --- > arch/arm/mach-iop32

Re: [PATCH net] net: vlan: avoid leaks on register_vlan_dev() failures

2021-01-05 Thread David Miller
From: Jakub Kicinski Date: Wed, 30 Dec 2020 19:40:27 -0800 > VLAN checks for NETREG_UNINITIALIZED to distinguish between > registration failure and unregistration in progress. > > Since commit cb626bf566eb ("net-sysfs: Fix reference count leak") > registration failure may, however, result in NET

Re: [PATCH net] net: suggest L2 discards be counted towards rx_dropped

2021-01-05 Thread David Miller
From: Jakub Kicinski Date: Wed, 30 Dec 2020 19:37:53 -0800 > From the existing definitions it's unclear which stat to > use to report filtering based on L2 dst addr in old > broadcast-medium Ethernet. > > Signed-off-by: Jakub Kicinski Applied.

Re: [PATCH net-next v1 00/13] Generic zcopy_* functions

2021-01-05 Thread Jonathan Lemon
On Tue, Jan 05, 2021 at 03:45:55PM -0800, Florian Fainelli wrote: > On 1/5/21 3:40 PM, Jonathan Lemon wrote: > > On Tue, Jan 05, 2021 at 03:11:03PM -0800, Florian Fainelli wrote: > >> On 1/5/21 2:06 PM, Jonathan Lemon wrote: > >>> From: Jonathan Lemon > >>> > >>> This is set of cleanup patches for

[net PATCH 1/2] net: ipv6: fib: flush exceptions when purging route

2021-01-05 Thread Sean Tranchetti
From: Sean Tranchetti Route removal is handled by two code paths. The main removal path is via fib6_del_route() which will handle purging any PMTU exceptions from the cache, removing all per-cpu copies of the DST entry used by the route, and releasing the fib6_info struct. The second removal loc

Re: [PATCH] CDC-NCM: remove "connected" log message

2021-01-05 Thread Roland Dreier
> now that you put it that way, I get the merit of what you are saying. > Very well. I will submit the first set of patches. > > May I add your "Tested-by"? Yes, absolutely: Tested-by: Roland Dreier

Re: [PATCH net-next] net: nfc: nci: Change the NCI close sequence

2021-01-05 Thread David Miller
From: Bongsu Jeon Date: Mon, 28 Dec 2020 10:46:31 +0900 > From: Bongsu Jeon > > Change the NCI close sequence because the NCI Command timer should be > deleted after flushing the NCI command work queue. > > Signed-off-by: Bongsu Jeon Applied.

Re: [PATCH] neighbour: Disregard DEAD dst in neigh_update

2021-01-05 Thread David Miller
From: Tong Zhu Date: Wed, 30 Dec 2020 17:54:23 -0500 > In 4.x kernel a dst in DST_OBSOLETE_DEAD state is associated > with loopback net_device and leads to loopback neighbour. It > leads to an ethernet header with all zero addresses. > > A very troubling case is working with mac80211 and ath9k.

Re: [PATCH v3 net-next] net: kcm: Replace fput with sockfd_put

2021-01-05 Thread David Miller
From: Zheng Yongjun Date: Wed, 30 Dec 2020 17:18:09 +0800 > The function sockfd_lookup uses fget on the value that is stored in > the file field of the returned structure, so fput should ultimately be > applied to this value. This can be done directly, but it seems better > to use the specific m

Re: [PATCH net-next] net/mlxfw: Use kzalloc for allocating only one thing

2021-01-05 Thread David Miller
From: Zheng Yongjun Date: Wed, 30 Dec 2020 16:18:35 +0800 > Use kzalloc rather than kcalloc(1,...) > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > @@ > > - kcalloc(1, > + kzalloc( > ...) > // > > Signed-off-by: Zheng Yongju

Re: [PATCH v4 net RESEND] net/sonic: Fix some resource leaks in error handling paths

2021-01-05 Thread David Miller
From: Finn Thain Date: Sun, 03 Jan 2021 11:26:26 +1100 > From: Christophe JAILLET > > A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors(). > > This is correctly freed in the remove function, but not in the error > handling path of the probe function. Fix this by adding the m

Re: [PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0.

2021-01-05 Thread David Miller
From: YANG LI Date: Wed, 30 Dec 2020 14:07:30 +0800 > The warning was because of the following line in function > liquidio_set_fec(): > > retval = wait_for_sc_completion_timeout(oct, sc, 0); > if (retval) > return (-EIO); > > If this statement is not true, retval must be 0 and not upd

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Paul Cercueil
Hi, Le mar. 5 janv. 2021 à 16:27, Mathieu Poirier a écrit : Adding Suman and Paul - guys please have a look. On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: DT properties which can have multiple entries need to specify what the entries are and define how many entries there ca

Re: [PATCH net-next v1 00/13] Generic zcopy_* functions

2021-01-05 Thread Florian Fainelli
On 1/5/21 3:40 PM, Jonathan Lemon wrote: > On Tue, Jan 05, 2021 at 03:11:03PM -0800, Florian Fainelli wrote: >> On 1/5/21 2:06 PM, Jonathan Lemon wrote: >>> From: Jonathan Lemon >>> >>> This is set of cleanup patches for zerocopy which are intended >>> to allow a introduction of a different zeroco

Re: [pull request][net-next 00/16] mlx5 SW steering updates 2021-01-05

2021-01-05 Thread David Miller
From: Saeed Mahameed Date: Tue, 5 Jan 2021 15:03:17 -0800 > From: Saeed Mahameed > > Hi Jakub, Dave > > This series introduces some refactoring to SW steering to support > different formats of different Hardware. > For more information please see tag log below. > > Please pull and let me kno

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Suman Anna
On 1/5/21 5:27 PM, Mathieu Poirier wrote: > Adding Suman and Paul - guys please have a look. > > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: >> DT properties which can have multiple entries need to specify what the >> entries are and define how many entries there can be. In the ca

[PATCHv2 bpf-next] tools/resolve_btfids: Warn when having multiple IDs for single type

2021-01-05 Thread Jiri Olsa
The kernel image can contain multiple types (structs/unions) with the same name. This causes distinct type hierarchies in BTF data and makes resolve_btfids fail with error like: BTFIDS vmlinux FAILED unresolved symbol udp6_sock as reported by Qais Yousef [1]. This change adds warning when mul

Re: [PATCH net-next v3] net: mhi: Add raw IP mode support

2021-01-05 Thread David Miller
From: Loic Poulain Date: Tue, 29 Dec 2020 10:04:54 +0100 > MHI net is protocol agnostic, the payload protocol depends on the modem > configuration, which can be either RMNET (IP muxing and aggregation) or > raw IP. This patch adds support for incomming IPv4/IPv6 packets, that > was previously unc

Re: [PATCH net-next v1 00/13] Generic zcopy_* functions

2021-01-05 Thread Jonathan Lemon
On Tue, Jan 05, 2021 at 03:11:03PM -0800, Florian Fainelli wrote: > On 1/5/21 2:06 PM, Jonathan Lemon wrote: > > From: Jonathan Lemon > > > > This is set of cleanup patches for zerocopy which are intended > > to allow a introduction of a different zerocopy implementation. > > > > The top level A

Re: [PATCH net v2] net: bareudp: add missing error handling for bareudp_link_config()

2021-01-05 Thread Cong Wang
On Tue, Jan 5, 2021 at 2:39 PM Jakub Kicinski wrote: > > On Tue, 5 Jan 2021 12:38:54 -0800 Cong Wang wrote: > > On Tue, Jan 5, 2021 at 11:07 AM Jakub Kicinski wrote: > > > +static void bareudp_dellink(struct net_device *dev, struct list_head > > > *head) > > > +{ > > > + struct bareudp_dev

Re: UBSAN: shift-out-of-bounds in gred_change

2021-01-05 Thread Randy Dunlap
On 12/31/20 1:09 PM, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:3db1a3fa Merge tag 'staging-5.11-rc1' of git://git.kernel... > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=155708db50 > kernel config: https://syz

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Mathieu Poirier
Adding Suman and Paul - guys please have a look. On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > DT properties which can have multiple entries need to specify what the > entries are and define how many entries there can be. In the case of > only a single entry, just 'maxItems: 1' is

Re: [PATCH RESEND net-next 0/4] enetc: code cleanups

2021-01-05 Thread David Miller
From: Michael Walle Date: Mon, 28 Dec 2020 14:00:30 +0100 > This are some code cleanups in the MDIO part of the enetc. They are > intended to make the code more readable. Series applied, thank you.

[PATCH net 0/3] net: fix netfilter defrag/ip tunnel pmtu blackhole

2021-01-05 Thread Florian Westphal
Christian Perle reported a PMTU blackhole due to unexpected interaction between the ip defragmentation that comes with connection tracking and ip tunnels. Unfortunately setting 'nopmtudisc' on the tunnel breaks the test scenario even without netfilter. Christinas setup looks like this: +

[PATCH net 3/3] net: ip: always refragment ip defragmented packets

2021-01-05 Thread Florian Westphal
Conntrack reassembly records the largest fragment size seen in IPCB. However, when this gets forwarded/transmitted, fragmentation will only be forced if one of the fragmented packets had the DF bit set. In that case, a flag in IPCB will force fragmentation even if the MTU is large enough. This sh

[PATCH net 1/3] selftests: netfilter: add selftest for ipip pmtu discovery with enabled connection tracking

2021-01-05 Thread Florian Westphal
Convert Christians bug description into a reproducer. Cc: Shuah Khan Cc: Pablo Neira Ayuso Reported-by: Christian Perle Signed-off-by: Florian Westphal --- tools/testing/selftests/netfilter/Makefile| 3 +- .../selftests/netfilter/ipip-conntrack-mtu.sh | 206 ++ 2 files c

Re: [PATCH net-next] nfc: Add a virtual nci device driver

2021-01-05 Thread Bongsu Jeon
On Tue, Jan 5, 2021 at 4:48 AM Jakub Kicinski wrote: > > On Thu, 31 Dec 2020 14:22:45 +0900 Bongsu Jeon wrote: > > On Tue, Dec 29, 2020 at 6:16 AM Jakub Kicinski wrote: > > > > > > On Mon, 28 Dec 2020 18:45:07 +0900 Bongsu Jeon wrote: > > > > From: Bongsu Jeon > > > > > > > > A NCI virtual devic

[PATCH net 2/3] net: fix pmtu check in nopmtudisc mode

2021-01-05 Thread Florian Westphal
For some reason ip_tunnel insist on setting the DF bit anyway when the inner header has the DF bit set, EVEN if the tunnel was configured with 'nopmtudisc'. This means that the script added in the previous commit cannot be made to work by adding the 'nopmtudisc' flag to the ip tunnel configuration

Re: [PATCH] net: phy: Trigger link_change_notify on PHY_HALTED

2021-01-05 Thread Heiner Kallweit
On 05.01.2021 17:11, Marek Vasut wrote: > In case the PHY transitions to PHY_HALTED state in phy_stop(), the > link_change_notify callback is not triggered. That's because the > phydev->state = PHY_HALTED in phy_stop() is assigned first, and > phy_state_machine() is called afterward. For phy_state_

Re: [PATCH net-next v1 00/13] Generic zcopy_* functions

2021-01-05 Thread Florian Fainelli
On 1/5/21 2:06 PM, Jonathan Lemon wrote: > From: Jonathan Lemon > > This is set of cleanup patches for zerocopy which are intended > to allow a introduction of a different zerocopy implementation. > > The top level API will use the skb_zcopy_*() functions, while > the current TCP specific zeroco

[net-next 13/16] net/mlx5: DR, Add STE tx/rx actions per-device API

2021-01-05 Thread Saeed Mahameed
From: Yevgeny Kliteynik Extend the STE context struct with per-device tx/rx actions. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Saeed Mahameed Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/steering/dr_ste.h| 12 1 file changed, 12 insertions(+) diff -

[net-next 15/16] net/mlx5: DR, Add STE modify header actions per-device API

2021-01-05 Thread Saeed Mahameed
From: Yevgeny Kliteynik Extend the STE context struct with per-device modify header actions. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Saeed Mahameed Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_ste.h | 23 +++ 1 file changed, 23 insertions(+)

[net-next 16/16] net/mlx5: DR, Move STEv0 modify header logic

2021-01-05 Thread Saeed Mahameed
From: Yevgeny Kliteynik Move HW specific modify header fields and logic to STEv0 file and use the new STE context callbacks. Since STEv0 and STEv1 modify actions values are different, each version has its own implementation. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Alex Vesker Reviewed-by

[net-next 14/16] net/mlx5: DR, Move STEv0 action apply logic

2021-01-05 Thread Saeed Mahameed
From: Yevgeny Kliteynik Use STE tx/rx actions per-device API: move HW specific action apply logic from dr_ste to STEv0 file - STEv0 and STEv1 actions format is different, each version should have its own implementation. Signed-off-by: Alex Vesker Signed-off-by: Yevgeny Kliteynik Reviewed-by: S

[net-next 11/16] net/mlx5: DR, Add STE setters and getters per-device API

2021-01-05 Thread Saeed Mahameed
From: Yevgeny Kliteynik Extend the STE context struct with various per-device setters and getters. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Saeed Mahameed Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/steering/dr_ste.h| 12 1 file changed, 12 inserti

[net-next 10/16] net/mlx5: DR, Move action apply logic to dr_ste

2021-01-05 Thread Saeed Mahameed
From: Yevgeny Kliteynik The action apply logic is device specific per STE version, moving to the STE layer will allow implementing it for both devices while keeping DR upper layers the same. Signed-off-by: Alex Vesker Signed-off-by: Yevgeny Kliteynik Reviewed-by: Saeed Mahameed Signed-off-by:

[net-next 12/16] net/mlx5: DR, Move STEv0 setters and getters

2021-01-05 Thread Saeed Mahameed
From: Yevgeny Kliteynik Use the new setters and getters API for STEv0: move HW specific setter and getters from dr_ste to STEv0 file. Since STEv0 and STEv1 format are different each version should implemented different setters and getters. Rename remaining static functions w/o mlx5 prefix. Signe

[net-next 07/16] net/mlx5: DR, Merge similar DR STE SET macros

2021-01-05 Thread Saeed Mahameed
From: Yevgeny Kliteynik Merge DR_STE_STE macros for better code reuse, the macro DR_STE_SET_MASK_V and DR_STE_SET_TAG are merged to avoid tag and bit_mask function creation which are usually the same. Signed-off-by: Alex Vesker Signed-off-by: Yevgeny Kliteynik Reviewed-by: Saeed Mahameed Sign

  1   2   3   4   >