Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

On Thursday 31 December 2020 18:13:38 Andrew Lunn wrote: > > > Looking at sfp_module_info(), adding a check for i2c_block_size < 2 > > > when determining what length to return. ethtool should do the right > > > thing, know that the second page has not been returned to user space. > > > > But if we

[PATCH iproute2-next v2 3/7] dcb: Generalize dcb_set_attribute()

The function dcb_set_attribute() takes a fully-formed payload as an argument. For callers that need to build a nested attribute, such as is the case for DCB APP table, this is not great, because with libmnl, they would need to construct a separate netlink message just to pluck out the payload and h

[PATCH iproute2-next v2 6/7] dcb: Add a subtool for the DCB APP object

DCB APP interfaces are standardized in 802.1q-2018, and allow configuration of traffic prioritization rules based on several possible headers. Add a dcb subtool for maintenance and display of the APP table. For example: # dcb app add dev eni1np1 dscp-prio 0:0 CS3:3 CS6:6 # dcb app show de

[PATCH iproute2-next v2 5/7] dcb: Support -N to suppress translation to human-readable names

Some DSCP values can be translated to symbolic names. That may not be always desirable. Introduce a command-line option similar to other tools, -N or --Numeric, to suppress this translation. Signed-off-by: Petr Machata --- Notes: v2: - Make it -N / --Numeric instead of -n / --no-nice-nam

[PATCH iproute2-next v2 1/7] lib: rt_names: Add rtnl_dsfield_get_name()

For formatting DSCP (not full dsfield), it would be handy to be able to just get the name from the name table, and not get any of the remaining cruft related to formatting. Add a new entry point to just fetch the name table string uninterpreted. Use it from rtnl_dsfield_n2a(). Signed-off-by: Petr

[PATCH iproute2-next v2 2/7] lib: Generalize parse_mapping()

The function parse_mapping() assumes the key is a number, with a single configurable exception, which is using "all" to mean "all possible keys". If a caller wishes to use symbolic names instead of numbers, they cannot reuse this function. To facilitate reuse in these situations, convert parse_map

[PATCH iproute2-next v2 7/7] dcb: Add a subtool for the DCBX object

The Linux DCBX object is a 1-byte bitfield of flags that configure whether the DCBX protocol is implemented in the device or in the host, and which version of the protocol should be used. Add a tool to access the per-port Linux DCBX object. For example: # dcb dcbx set dev eni1np1 host iee

[PATCH iproute2-next v2 0/7] dcb: Support APP, DCBX objects

Add support to the dcb tool for the following two DCB objects: - APP, which allows configuration of traffic prioritization rules based on several possible packet headers. - DCBX, which is a 1-byte bitfield of flags that configure whether the DCBX protocol is implemented in the device or in th

[PATCH iproute2-next v2 4/7] dcb: Generalize dcb_get_attribute()

The function dcb_get_attribute() assumes that the caller knows the exact size of the looked-for payload. It also assumes that the response comes wrapped in an DCB_ATTR_IEEE nest. The former assumption does not hold for the IEEE APP table, which has variable size. The latter one does not hold for DC

[PATCH iproute2 0/3] dcb: Fixes

dcb currently sends all netlink messages with a type RTM_GETDCB, even the set ones. In patch #1, send the setters as RTM_SETDCB. In patch #2, plug a leak. In patch #3, change the command line option for namespace change from devlink-like -N / --Netns to ip-like -n / --netns. Petr Machata (3):

[PATCH iproute2 3/3] dcb: Change --Netns/-N to --netns/-n

This to keep compatible with the major tools, ip and tc. Also document the option in the man page, which was neglected. Signed-off-by: Petr Machata --- dcb/dcb.c | 8 man/man8/dcb.8 | 7 +++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/dcb/dcb.c b/dcb/dcb.c i

[PATCH iproute2 2/3] dcb: Plug a leaking DCB socket buffer

DCB socket buffer is allocated in dcb_init(), but never freed(). Free it in dcb_fini(). Signed-off-by: Petr Machata --- dcb/dcb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dcb/dcb.c b/dcb/dcb.c index f5c62790e27e..0e3c87484f2a 100644 --- a/dcb/dcb.c +++ b/dcb/dcb.c @@ -38,6 +38,7 @@ st

[PATCH iproute2 1/3] dcb: Set values with RTM_SETDCB type

dcb currently sends all netlink messages with a type RTM_GETDCB, even the set ones. Change to the appropriate type. Signed-off-by: Petr Machata --- dcb/dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dcb/dcb.c b/dcb/dcb.c index adec57476e1d..f5c62790e27e 100644 --- a/dc

Re: [PATCH iproute2-next 7/9] dcb: Support -n to suppress translation to nice names

David Ahern writes: > On 12/23/20 11:25 AM, Petr Machata wrote: >> diff --git a/dcb/dcb.c b/dcb/dcb.c >> index a59b63ac9159..e6cda7337924 100644 >> --- a/dcb/dcb.c >> +++ b/dcb/dcb.c >> @@ -467,7 +467,8 @@ static void dcb_help(void) >> " dcb [ -f | --force ] { -b | --batch }

Re: Race Condition Observed in ARP Processing.

Sure, will raise a patch post testing. On Thu, Dec 31, 2020 at 10:53:59AM -0800, Cong Wang wrote: > On Tue, Dec 29, 2020 at 8:06 AM Chinmay Agarwal > wrote: > > > > Hi All, > > > > We found a crash while performing some automated stress tests on a 5.4 > > kernel based device. > > > > We found o

RE: [PATCH] can: rcar: Update help description for CAN_RCAR config

Hi Prabhakar, Thanks for the patch. > -Original Message- > From: Lad Prabhakar > Sent: 31 December 2020 16:00 > To: Geert Uytterhoeven ; Wolfgang Grandegger > ; Marc Kleine-Budde ; David S. > Miller ; Jakub Kicinski ; Masahiro > Yamada > Cc: linux-...@vger.kernel.org; netdev@vger.kernel

INFO: trying to register non-static key in l2cap_sock_teardown_cb

Hello, syzbot found the following issue on: HEAD commit:3db1a3fa Merge tag 'staging-5.11-rc1' of git://git.kernel... git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=15dccfb750 kernel config: https://syzkaller.appspot.com/x/.config?x=2ae878fbf640b72b das