Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-23 Thread Greg KH
On Wed, Dec 23, 2020 at 07:21:16PM -0800, Roland Dreier wrote: > The cdc_ncm driver passes network connection notifications up to > usbnet_link_change(), which is the right place for any logging. > Remove the netdev_info() duplicating this from the driver itself. > > This stops devices such as my

Re: [PATCH v5 bpf-next 0/2] introduce xdp_init_buff/xdp_prepare_buff

2020-12-23 Thread Marcin Wojtas
Hi Lorenzo, wt., 22 gru 2020 o 22:13 Lorenzo Bianconi napisał(a): > > Introduce xdp_init_buff and xdp_prepare_buff utility routines to initialize > xdp_buff data structure and remove duplicated code in all XDP capable > drivers. > > Changes since v4: > - fix xdp_init_buff/xdp_prepare_buff (natur

Re: Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-23 Thread Yongji Xie
On Thu, Dec 24, 2020 at 10:41 AM Jason Wang wrote: > > > On 2020/12/23 下午8:14, Yongji Xie wrote: > > On Wed, Dec 23, 2020 at 5:05 PM Jason Wang wrote: > >> > >> On 2020/12/22 下午10:52, Xie Yongji wrote: > >>> To support vhost-vdpa bus driver, we need a way to share the > >>> vhost-vdpa backend pro

Re: [PATCH] bpf: fix: address of local auto-variable assigned to a function parameter.

2020-12-23 Thread Yonghong Song
On 12/23/20 11:01 PM, YANG LI wrote: Assigning local variable txq to the outputting parameter xdp->txq is not safe, txq will be released after the end of the function call. Then the result of using xdp is unpredictable. Fix this error by defining the struct xdp_txq_info in function dev_map_ru

Re: [PATCH v4 01/11] dt-bindings: usb: convert usb-device.txt to YAML schema

2020-12-23 Thread Chunfeng Yun
On Mon, 2020-12-21 at 12:09 -0700, Rob Herring wrote: > On Wed, Dec 16, 2020 at 05:30:02PM +0800, Chunfeng Yun wrote: > > Convert usb-device.txt to YAML schema usb-device.yaml > > > > Signed-off-by: Chunfeng Yun > > --- > > v4: no changes, update dependent series: > > https://patchwork.kernel

Re: Re: [RFC v2 08/13] vdpa: Introduce process_iotlb_msg() in vdpa_config_ops

2020-12-23 Thread Yongji Xie
On Thu, Dec 24, 2020 at 10:37 AM Jason Wang wrote: > > > On 2020/12/23 下午7:06, Yongji Xie wrote: > > On Wed, Dec 23, 2020 at 4:37 PM Jason Wang wrote: > >> > >> On 2020/12/22 下午10:52, Xie Yongji wrote: > >>> This patch introduces a new method in the vdpa_config_ops to > >>> support processing the

[PATCH] bpf: fix: address of local auto-variable assigned to a function parameter.

2020-12-23 Thread YANG LI
Assigning local variable txq to the outputting parameter xdp->txq is not safe, txq will be released after the end of the function call. Then the result of using xdp is unpredictable. Fix this error by defining the struct xdp_txq_info in function dev_map_run_prog() as a static type. Signed-off-by

Re: [PATCH] net/mlx5e: remove h from printk format specifier

2020-12-23 Thread Leon Romanovsky
On Wed, Dec 23, 2020 at 11:45:12AM -0800, t...@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is alr

Re: [PATCH] rdma.8: Add basic description for users unfamiliar with rdma

2020-12-23 Thread Alan Perry
On 12/23/20 12:19 AM, Leon Romanovsky wrote: On Tue, Dec 22, 2020 at 08:47:51PM -0800, Alan Perry wrote: Add a description section with basic info about the rdma command for users unfamiliar with it. Signed-off-by: Alan Perry --- man/man8/rdma.8 | 6 +- 1 file changed, 5 insertion(+)

Re: [PATCH] rdma.8: Add basic description for users unfamiliar with rdma

2020-12-23 Thread Leon Romanovsky
On Tue, Dec 22, 2020 at 08:47:51PM -0800, Alan Perry wrote: > Add a description section with basic info about the rdma command for users > unfamiliar with it. > > Signed-off-by: Alan Perry > --- > man/man8/rdma.8 | 6 +- > 1 file changed, 5 insertion(+), 1 deletion(-) > > diff --git a/man/man

Re: [PATCH net v4 2/2] vhost_net: fix tx queue stuck when sendmsg fails

2020-12-23 Thread Jason Wang
On 2020/12/24 下午12:37, wangyunjian wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Thursday, December 24, 2020 11:10 AM To: wangyunjian ; netdev@vger.kernel.org; m...@redhat.com; willemdebruijn.ker...@gmail.com Cc: virtualizat...@lists.linux-foundation.org;

RE: [PATCH net v4 2/2] vhost_net: fix tx queue stuck when sendmsg fails

2020-12-23 Thread wangyunjian
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, December 24, 2020 11:10 AM > To: wangyunjian ; netdev@vger.kernel.org; > m...@redhat.com; willemdebruijn.ker...@gmail.com > Cc: virtualizat...@lists.linux-foundation.org; Lilijun (Jerry) > ; chenchanghu ;

[PATCH] CDC-NCM: remove "connected" log message

2020-12-23 Thread Roland Dreier
The cdc_ncm driver passes network connection notifications up to usbnet_link_change(), which is the right place for any logging. Remove the netdev_info() duplicating this from the driver itself. This stops devices such as my "TRENDnet USB 10/100/1G/2.5G LAN" (ID 20f4:e02b) adapter from spamming th

Re: [PATCH net v4 2/2] vhost_net: fix tx queue stuck when sendmsg fails

2020-12-23 Thread Jason Wang
On 2020/12/24 上午10:25, wangyunjian wrote: From: Yunjian Wang Currently the driver doesn't drop a packet which can't be sent by tun (e.g bad packet). In this case, the driver will always process the same packet lead to the tx queue stuck. To fix this issue: 1. in the case of persistent failur

Re: [RFC v2 06/13] vduse: Introduce VDUSE - vDPA Device in Userspace

2020-12-23 Thread Jason Wang
On 2020/12/23 下午10:17, Yongji Xie wrote: On Wed, Dec 23, 2020 at 4:08 PM Jason Wang wrote: On 2020/12/22 下午10:52, Xie Yongji wrote: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In

Re: [External] Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-23 Thread Jason Wang
On 2020/12/23 下午8:14, Yongji Xie wrote: On Wed, Dec 23, 2020 at 5:05 PM Jason Wang wrote: On 2020/12/22 下午10:52, Xie Yongji wrote: To support vhost-vdpa bus driver, we need a way to share the vhost-vdpa backend process's memory with the userspace VDUSE process. This patch tries to make use

Re: [PATCH net v4 2/2] vhost_net: fix tx queue stuck when sendmsg fails

2020-12-23 Thread Willem de Bruijn
On Wed, Dec 23, 2020 at 9:25 PM wangyunjian wrote: > > From: Yunjian Wang > > Currently the driver doesn't drop a packet which can't be sent by tun > (e.g bad packet). In this case, the driver will always process the > same packet lead to the tx queue stuck. > > To fix this issue: > 1. in the cas

Re: [RFC v2 08/13] vdpa: Introduce process_iotlb_msg() in vdpa_config_ops

2020-12-23 Thread Jason Wang
On 2020/12/23 下午7:06, Yongji Xie wrote: On Wed, Dec 23, 2020 at 4:37 PM Jason Wang wrote: On 2020/12/22 下午10:52, Xie Yongji wrote: This patch introduces a new method in the vdpa_config_ops to support processing the raw vhost memory mapping message in the vDPA device driver. Signed-off-by:

Re: [RFC v2 00/13] Introduce VDUSE - vDPA Device in Userspace

2020-12-23 Thread Jason Wang
On 2020/12/23 下午6:59, Yongji Xie wrote: On Wed, Dec 23, 2020 at 2:38 PM Jason Wang wrote: On 2020/12/22 下午10:52, Xie Yongji wrote: This series introduces a framework, which can be used to implement vDPA Devices in a userspace program. The work consist of two parts: control path forwarding a

[PATCH net v4 0/2] fixes for vhost_net

2020-12-23 Thread wangyunjian
From: Yunjian Wang This series include two fixes patches for vhost_net. --- v4: * update patch 2/2 return check and commit log suggested * by Willem de Bruijn v3: * update patch 2/2 code styles and commit log suggested * by Jason Wang and Willem de Bruijn v2: * update patch 1/2

[PATCH net v4 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2020-12-23 Thread wangyunjian
From: Yunjian Wang Currently the vhost_zerocopy_callback() maybe be called to decrease the refcount when sendmsg fails in tun. The error handling in vhost handle_tx_zerocopy() will try to decrease the same refcount again. This is wrong. To fix this issue, we only call vhost_net_ubuf_put() when vq

[PATCH net v4 2/2] vhost_net: fix tx queue stuck when sendmsg fails

2020-12-23 Thread wangyunjian
From: Yunjian Wang Currently the driver doesn't drop a packet which can't be sent by tun (e.g bad packet). In this case, the driver will always process the same packet lead to the tx queue stuck. To fix this issue: 1. in the case of persistent failure (e.g bad packet), the driver can skip this d

Re: [PATCH v2] vhost/vsock: add IOTLB API support

2020-12-23 Thread Jason Wang
On 2020/12/23 下午10:36, Stefano Garzarella wrote: This patch enables the IOTLB API support for vhost-vsock devices, allowing the userspace to emulate an IOMMU for the guest. These changes were made following vhost-net, in details this patch: - exposes VIRTIO_F_ACCESS_PLATFORM feature and inits

Re: [PATCH net-next v1] stmmac: intel: Add PCI IDs for TGL-H platform

2020-12-23 Thread Jakub Kicinski
On Thu, 24 Dec 2020 01:23:25 + Wong, Vee Khee wrote: > > On Wed, 23 Dec 2020 00:03:37 +0800 Muhammad Husaini Zulkifli wrote: > > > From: Noor Azura Ahmad Tarmizi > > > > > > Add TGL-H PCI info and PCI IDs for the new TSN Controller to the list > > > of supported devices. > > > > > > Signed-o

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 14:17:29 -0800 Florian Fainelli wrote: > On 12/23/2020 1:11 PM, Jakub Kicinski wrote: > > On Wed, 23 Dec 2020 22:00:44 +0100 Andrew Lunn wrote: > >> On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote: > >>> On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote:

RE: [PATCH net-next v1] stmmac: intel: Add PCI IDs for TGL-H platform

2020-12-23 Thread Wong, Vee Khee
> -Original Message- > From: Jakub Kicinski > Sent: Thursday, December 24, 2020 4:14 AM > To: Zulkifli, Muhammad Husaini > Cc: da...@davemloft.net; peppe.cavall...@st.com; > alexandre.tor...@st.com; joab...@synopsys.com; > netdev@vger.kernel.org; Ahmad Tarmizi, Noor Azura > ; Voon, Wei

Re: [PATCH 1/3 v4 bpf-next] bpf: save correct stopping point in file seq iteration.

2020-12-23 Thread Daniel Borkmann
On 12/18/20 10:01 PM, Andrii Nakryiko wrote: On Fri, Dec 18, 2020 at 12:47 PM Jonathan Lemon wrote: From: Jonathan Lemon On some systems, some variant of the following splat is repeatedly seen. The common factor in all traces seems to be the entry point to task_file_seq_next(). With the pa

Re: [PATCH v2 bpf] selftests/bpf: work-around EBUSY errors from hashmap update/delete

2020-12-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Wed, 23 Dec 2020 12:06:52 -0800 you wrote: > 20b6cc34ea74 ("bpf: Avoid hashtab deadlock with map_locked") introduced > a possibility of getting EBUSY error on lock contention, which seems to happen > very deterministically in te

Re: [PATCH v4 07/11] dt-bindings: phy: convert MIPI DSI PHY binding to YAML schema

2020-12-23 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年12月16日 週三 下午5:30寫道: > > Convert MIPI DSI PHY binding to YAML schema mediatek,dsi-phy.yaml > Reviewed-by: Chun-Kuang Hu > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Signed-off-by: Chunfeng Yun > --- > v4: > 1. add maintainer Philipp add support mt8183 suggest

Re: [PATCH v4 06/11] dt-bindings: phy: convert HDMI PHY binding to YAML schema

2020-12-23 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年12月16日 週三 下午5:30寫道: > > Convert HDMI PHY binding to YAML schema mediatek,hdmi-phy.yaml > Reviewed-by: Chun-Kuang Hu > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Signed-off-by: Chunfeng Yun > Reviewed-by: Rob Herring > --- > v4: add maintainer Philipp > v3: ad

Re: WARNING in isotp_tx_timer_handler

2020-12-23 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:614cb589 Merge tag 'acpi-5.11-rc1-2' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=151d558f50 kernel config: https://syzkaller.appspot.com/x/.config?x=3e7e34a

[net 0/4][pull request] Intel Wired LAN Driver Updates 2020-12-23

2020-12-23 Thread Tony Nguyen
Commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") disabled S0ix flows for systems that have various incarnations of the i219-LM ethernet controller. This was done because of some regressions caused by an earlier commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable

[net 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems"

2020-12-23 Thread Tony Nguyen
From: Mario Limonciello commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") disabled s0ix flows for systems that have various incarnations of the i219-LM ethernet controller. This changed caused power consumption regressions on the following shipping Dell Comet Lake

[net 4/4] e1000e: Export S0ix flags to ethtool

2020-12-23 Thread Tony Nguyen
From: Mario Limonciello This flag can be used by an end user to disable S0ix flows on a buggy system or by an OEM for development purposes. If you need this flag to be persisted across reboots, it's suggested to use a udev rule to call adjust it until the kernel could have your configuration in

[net 1/4] e1000e: Only run S0ix flows if shutdown succeeded

2020-12-23 Thread Tony Nguyen
From: Mario Limonciello If the shutdown failed, the part will be thawed and running S0ix flows will put it into an undefined state. Reported-by: Alexander Duyck Reviewed-by: Alexander Duyck Signed-off-by: Mario Limonciello Tested-by: Yijun Shen Signed-off-by: Tony Nguyen --- drivers/net/et

[net 2/4] e1000e: bump up timeout to wait when ME un-configures ULP mode

2020-12-23 Thread Tony Nguyen
From: Mario Limonciello Per guidance from Intel ethernet architecture team, it may take up to 1 second for unconfiguring ULP mode. However in practice this seems to be taking up to 2 seconds on some Lenovo machines. Detect scenarios that take more than 1 second but less than 2.5 seconds and emi

[PATCH v3 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay

2020-12-23 Thread Martin Blumenstingl
Amlogic Meson G12A, G12B and SM1 SoCs have a more advanced RGMII RX delay register which allows picoseconds precision. Deprecate the old "amlogic,rx-delay-ns" in favour of the generic "rx-internal-delay-ps" property. For older SoCs the only known supported values were 0ns and 2ns. The new SoCs hav

[PATCH v3 0/5] dwmac-meson8b: picosecond precision RX delay support

2020-12-23 Thread Martin Blumenstingl
Hello, with the help of Jianxin Pan (many thanks!) the meaning of the "new" PRG_ETH1[19:16] register bits on Amlogic Meson G12A, G12B and SM1 SoCs are finally known. These SoCs allow fine-tuning the RGMII RX delay in 200ps steps (contrary to what I have thought in the past [0] these are not some "

[PATCH v3 3/5] net: stmmac: dwmac-meson8b: use picoseconds for the RGMII RX delay

2020-12-23 Thread Martin Blumenstingl
Amlogic Meson G12A, G12B and SM1 SoCs have a more advanced RGMII RX delay register which allows picoseconds precision. Parse the new "rx-internal-delay-ps" property or fall back to the value from the old "amlogic,rx-delay-ns" property. No upstream DTB uses the old "amlogic,rx-delay-ns" property (y

[PATCH v3 2/5] net: stmmac: dwmac-meson8b: fix enabling the timing-adjustment clock

2020-12-23 Thread Martin Blumenstingl
The timing-adjustment clock only has to be enabled when a) there is a 2ns RX delay configured using device-tree and b) the phy-mode indicates that the RX delay should be enabled. Only enable the RX delay if both are true, instead of (by accident) also enabling it when there's the 2ns RX delay conf

[PATCH v3 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function

2020-12-23 Thread Martin Blumenstingl
Newer SoCs starting with the Amlogic Meson G12A have more a precise RGMII RX delay configuration register. This means more complexity in the code. Extract the existing RGMII delay configuration code into a separate function to make it easier to read/understand even when adding more logic in the fut

[PATCH v3 5/5] net: stmmac: dwmac-meson8b: add support for the RGMII RX delay on G12A

2020-12-23 Thread Martin Blumenstingl
Amlogic Meson G12A (and newer: G12B, SM1) SoCs have a more advanced RX delay logic. Instead of fine-tuning the delay in the nanoseconds range it now allows tuning in 200 picosecond steps. This support comes with new bits in the PRG_ETH1[19:16] register. Add support for validating the RGMII RX dela

Re: [PATCH net v3 0/4] net-sysfs: fix race conditions in the xps code

2020-12-23 Thread Alexander Duyck
On Wed, Dec 23, 2020 at 1:23 PM Antoine Tenart wrote: > > Hello all, > > This series fixes race conditions in the xps code, where out of bound > accesses can occur when dev->num_tc is updated, triggering oops. The > root cause is linked to locking issues. An explanation is given in each > of the c

Re: [PATCH net 1/2] net: mrp: fix definitions of MRP test packets

2020-12-23 Thread Horatiu Vultur
Hi Andrew, The 12/23/2020 19:41, Andrew Lunn wrote: > > > > @@ -96,7 +96,7 @@ struct br_mrp_ring_test_hdr { > > > __be16 state; > > > __be16 transitions; > > > __be32 timestamp; > > > -}; > > > +} __attribute__((__packed__)); > > > > Yes, I agree that this should be packed

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Florian Fainelli
On 12/23/2020 1:11 PM, Jakub Kicinski wrote: > On Wed, 23 Dec 2020 22:00:44 +0100 Andrew Lunn wrote: >> On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote: >>> On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote:

Re: [PATCH net 0/2] MRP without hardware offload?

2020-12-23 Thread Horatiu Vultur
The 12/23/2020 15:45, Rasmus Villemoes wrote: > > Hi Horatiu and net folks Hi Rasmus, > > I'm having quite some trouble getting MRP working in a simple setup > involving three mv88e6250 switches in a ring, with one node set as > manager and the other two as clients. > > I'm reasonably confiden

Re: [PATCH net 1/2] net: mrp: fix definitions of MRP test packets

2020-12-23 Thread Horatiu Vultur
The 12/23/2020 15:45, Rasmus Villemoes wrote: Hi Rasmus, > > Wireshark says that the MRP test packets cannot be decoded - and the > reason for that is that there's a two-byte hole filled with garbage > between the "transitions" and "timestamp" members. > > So Wireshark decodes the two garbage by

[PATCH net v3 1/4] net-sysfs: take the rtnl lock when storing xps_cpus

2020-12-23 Thread Antoine Tenart
Two race conditions can be triggered when storing xps cpus, resulting in various oops and invalid memory accesses: 1. Calling netdev_set_num_tc while netif_set_xps_queue: - netif_set_xps_queue uses dev->tc_num as one of the parameters to compute the size of new_dev_maps when allocating it

[PATCH net v3 3/4] net-sysfs: take the rtnl lock when storing xps_rxqs

2020-12-23 Thread Antoine Tenart
Two race conditions can be triggered when storing xps rxqs, resulting in various oops and invalid memory accesses: 1. Calling netdev_set_num_tc while netif_set_xps_queue: - netif_set_xps_queue uses dev->tc_num as one of the parameters to compute the size of new_dev_maps when allocating it

[PATCH net v3 4/4] net-sysfs: take the rtnl lock when accessing xps_rxqs_map and num_tc

2020-12-23 Thread Antoine Tenart
Accesses to dev->xps_rxqs_map (when using dev->num_tc) should be protected by the rtnl lock, like we do for netif_set_xps_queue. I didn't see an actual bug being triggered, but let's be safe here and take the rtnl lock while accessing the map in sysfs. Fixes: 8af2c06ff4b1 ("net-sysfs: Add interfac

[PATCH net v3 2/4] net-sysfs: take the rtnl lock when accessing xps_cpus_map and num_tc

2020-12-23 Thread Antoine Tenart
Accesses to dev->xps_cpus_map (when using dev->num_tc) should be protected by the rtnl lock, like we do for netif_set_xps_queue. I didn't see an actual bug being triggered, but let's be safe here and take the rtnl lock while accessing the map in sysfs. Fixes: 184c449f91fe ("net: Add support for XP

[PATCH net v3 0/4] net-sysfs: fix race conditions in the xps code

2020-12-23 Thread Antoine Tenart
Hello all, This series fixes race conditions in the xps code, where out of bound accesses can occur when dev->num_tc is updated, triggering oops. The root cause is linked to locking issues. An explanation is given in each of the commit logs. We had a discussion on the v1 of this series about usin

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 22:00:44 +0100 Andrew Lunn wrote: > On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote: > > On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: > > > On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote: > > > > When mdiobus_register() fails, priv->mdio

Re: [PATCH] net: ena: remove h from printk format specifier

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 11:31:44 -0800 t...@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already

Re: [RFC PATCH v2 3/8] net: sparx5: add hostmode with phylink support

2020-12-23 Thread Andrew Lunn
On Wed, Dec 23, 2020 at 09:58:52PM +0100, Alexandre Belloni wrote: > On 22/12/2020 15:41:41+0100, Andrew Lunn wrote: > > > Yes the register based injection/extration is not going to be fast, but > > > the FDMA and its driver is being sent later as separate series to keep > > > the size of this revi

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Andrew Lunn
On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote: > On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: > > On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote: > > > When mdiobus_register() fails, priv->mdio allocated > > > by mdiobus_alloc() has not been freed, which leads

Re: [PATCH net v2] ibmvnic: continue fatal error reset after passive init

2020-12-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 23 Dec 2020 14:49:04 -0600 you wrote: > Commit f9c6cea0b385 ("ibmvnic: Skip fatal error reset after passive init") > says "If the passive > CRQ initialization occurs before the FATAL reset task is processed, > the FATAL

Re: [PATCH net v2 1/3] net: fix race conditions in xps by locking the maps and dev->tc_num

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 21:56:56 +0100 Antoine Tenart wrote: > You understood correctly, the only reason to move this code out of sysfs > was to access the xps_map lock. Without the need, the code can stay in > sysfs. > > Patch 2 is not only moving the code out of sysfs, but also reworking > xps_cpus_

Re: [RFC PATCH v2 3/8] net: sparx5: add hostmode with phylink support

2020-12-23 Thread Alexandre Belloni
On 22/12/2020 15:41:41+0100, Andrew Lunn wrote: > > Yes the register based injection/extration is not going to be fast, but > > the FDMA and its driver is being sent later as separate series to keep > > the size of this review down. > > FDMA? > > I need a bit more background here, just to make us

Winter solstice pause

2020-12-23 Thread Jakub Kicinski
Hi all, just a quick FYI. Patches had slowed down to a trickle, so we'll most likely leave the trees be until Monday starting now. Many reviewers and maintainers are likely to be AFK for the next few days. Please let us know if anything requires urgent attention :)

Re: [PATCH net v2 1/3] net: fix race conditions in xps by locking the maps and dev->tc_num

2020-12-23 Thread Antoine Tenart
Quoting Jakub Kicinski (2020-12-23 21:43:15) > On Wed, 23 Dec 2020 21:35:15 +0100 Antoine Tenart wrote: > > > > - For net-next, to resend patches 2 and 3 from v2 (they'll have to be > > > > slightly reworked, to take into account the review from Alexander and > > > > the rtnl lock). The patches

Re: [PATCH] amd-xgbe: remove h from printk format specifier

2020-12-23 Thread Joe Perches
On Wed, 2020-12-23 at 12:33 -0800, Tom Rix wrote: > On 12/23/20 12:14 PM, Joe Perches wrote: > > On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This change fixes the checkpatch warning described in this commit > > > commit cbacb5ab0aa0 ("docs: printk-for

[PATCH net v2] ibmvnic: continue fatal error reset after passive init

2020-12-23 Thread Lijun Pan
Commit f9c6cea0b385 ("ibmvnic: Skip fatal error reset after passive init") says "If the passive CRQ initialization occurs before the FATAL reset task is processed, the FATAL error reset task would try to access a CRQ message queue that was freed, causing an oops. The problem may be most likely to o

Re: [PATCH net v2 1/3] net: fix race conditions in xps by locking the maps and dev->tc_num

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 21:35:15 +0100 Antoine Tenart wrote: > > > - For net-next, to resend patches 2 and 3 from v2 (they'll have to be > > > slightly reworked, to take into account the review from Alexander and > > > the rtnl lock). The patches can be sent once the ones for net land in > > > ne

Re: [PATCH -next] atmel/at76c50x-usb: use DEFINE_MUTEX (and mutex_init() had been too late)

2020-12-23 Thread Kalle Valo
Zheng Yongjun writes: > Signed-off-by: Zheng Yongjun Empty commit log. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] enic: Remove redundant free in enic_set_ringparam

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 20:38:33 +0800 Dinghao Liu wrote: > The error handling paths in enic_alloc_vnic_resources() > have called enic_free_vnic_resources() before returning. > So we may not need to call it again on failure at caller > side. > > Signed-off-by: Dinghao Liu But it's harmless, right? S

Re: [PATCH] amd-xgbe: remove h from printk format specifier

2020-12-23 Thread Tom Rix
On 12/23/20 12:14 PM, Joe Perches wrote: > On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote: >> From: Tom Rix >> >> This change fixes the checkpatch warning described in this commit >> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of >> unnecessary %h[xudi] and %hh[xu

Re: [PATCH net v2 1/3] net: fix race conditions in xps by locking the maps and dev->tc_num

2020-12-23 Thread Antoine Tenart
Quoting Jakub Kicinski (2020-12-23 21:11:10) > On Wed, 23 Dec 2020 20:36:33 +0100 Antoine Tenart wrote: > > Quoting Jakub Kicinski (2020-12-23 19:27:29) > > > On Tue, 22 Dec 2020 08:12:28 -0800 Alexander Duyck wrote: > > > > On Tue, Dec 22, 2020 at 1:21 AM Antoine Tenart > > > > wrote: > > > >

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: > On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote: > > When mdiobus_register() fails, priv->mdio allocated > > by mdiobus_alloc() has not been freed, which leads > > to memleak. > > > > Signed-off-by: Dinghao Liu > > Fixes: bfa4

Re: [PATCH v2] net/ncsi: Use real net-device for response handler

2020-12-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 23 Dec 2020 13:55:23 +0800 you wrote: > When aggregating ncsi interfaces and dedicated interfaces to bond > interfaces, the ncsi response handler will use the wrong net device to > find ncsi_dev, so that the ncsi interfa

[PATCH] via-velocity: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

Re: [PATCH net] ibmvnic: continue fatal error reset after passive init

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 14:10:32 -0600 Lijun Pan wrote: > On Wed, Dec 23, 2020 at 10:50 AM Jakub Kicinski wrote: > > > > On Wed, 23 Dec 2020 02:21:09 -0600 Lijun Pan wrote: > > > On Tue, Dec 22, 2020 at 8:48 PM Jakub Kicinski wrote: > > > > On Sat, 19 Dec 2020 15:40:34 -0600 Lijun Pan wrote: >

[PATCH] qed: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

Re: [PATCH net] net: dcb: Validate netlink message in DCB handler

2020-12-23 Thread Jakub Kicinski
On Tue, 22 Dec 2020 22:49:44 +0100 Petr Machata wrote: > DCB uses the same handler function for both RTM_GETDCB and RTM_SETDCB > messages. dcb_doit() bounces RTM_SETDCB mesasges if the user does not have > the CAP_NET_ADMIN capability. > > However, the operation to be performed is not decided from

[PATCH] nfp: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

Re: [PATCH net 0/3] net: ipa: GSI interrupt handling fixes

2020-12-23 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 22 Dec 2020 12:00:09 -0600 you wrote: > This series implements fixes for some issues related to handling > interrupts when GSI channel and event ring commands complete. > > The first issue is that the completion condit

Re: [PATCH] amd-xgbe: remove h from printk format specifier

2020-12-23 Thread Joe Perches
On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already

Re: [PATCH net v2 1/3] net: fix race conditions in xps by locking the maps and dev->tc_num

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 20:36:33 +0100 Antoine Tenart wrote: > Quoting Jakub Kicinski (2020-12-23 19:27:29) > > On Tue, 22 Dec 2020 08:12:28 -0800 Alexander Duyck wrote: > > > On Tue, Dec 22, 2020 at 1:21 AM Antoine Tenart wrote: > > > > > > > If I understood correctly, as things are a bit too co

Re: [PATCH net-next v1] stmmac: intel: Add PCI IDs for TGL-H platform

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 00:03:37 +0800 Muhammad Husaini Zulkifli wrote: > From: Noor Azura Ahmad Tarmizi > > Add TGL-H PCI info and PCI IDs for the new TSN Controller to the list > of supported devices. > > Signed-off-by: Noor Azura Ahmad Tarmizi > Signed-off-by: Voon Weifeng > Signed-off-by: Muha

Re: [PATCH net] ibmvnic: continue fatal error reset after passive init

2020-12-23 Thread Lijun Pan
On Wed, Dec 23, 2020 at 10:50 AM Jakub Kicinski wrote: > > On Wed, 23 Dec 2020 02:21:09 -0600 Lijun Pan wrote: > > On Tue, Dec 22, 2020 at 8:48 PM Jakub Kicinski wrote: > > > On Sat, 19 Dec 2020 15:40:34 -0600 Lijun Pan wrote: > > > > Commit f9c6cea0b385 ("ibmvnic: Skip fatal error reset after pa

[PATCH v2 bpf] selftests/bpf: work-around EBUSY errors from hashmap update/delete

2020-12-23 Thread Andrii Nakryiko
20b6cc34ea74 ("bpf: Avoid hashtab deadlock with map_locked") introduced a possibility of getting EBUSY error on lock contention, which seems to happen very deterministically in test_maps when running 1024 threads on low-CPU machine. In libbpf CI case, it's a 2 CPU VM and it's hitting this 100% of t

[PATCH] net/mlx5e: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] igb: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] amd-xgbe: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

Re: [PATCH] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag on Zynq

2020-12-23 Thread Charles Keepax
On Wed, Dec 23, 2020 at 08:24:41PM +0100, Andrew Lunn wrote: > On Wed, Dec 23, 2020 at 06:41:44PM +, Charles Keepax wrote: > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > > macb_set_tx_clk were gated on the presence of this flag. > > > > if (!bp->tx_clk || !(bp->caps & MACB_

Re: [PATCH net] net: ipa: fix interconnect enable bug

2020-12-23 Thread Jakub Kicinski
On Tue, 22 Dec 2020 18:18:31 +0200 Georgi Djakov wrote: > On 12/22/20 17:16, Alex Elder wrote: > > When the core clock rate and interconnect bandwidth specifications > > were moved into configuration data, a copy/paste bug was introduced, > > causing the memory interconnect bandwidth to be set thre

Re: [PATCH net v2 1/3] net: fix race conditions in xps by locking the maps and dev->tc_num

2020-12-23 Thread Antoine Tenart
Hi Jakub, Quoting Jakub Kicinski (2020-12-23 19:27:29) > On Tue, 22 Dec 2020 08:12:28 -0800 Alexander Duyck wrote: > > On Tue, Dec 22, 2020 at 1:21 AM Antoine Tenart wrote: > > > > > If I understood correctly, as things are a bit too complex now, you > > > would prefer that we go for the solutio

[PATCH] net: ena: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

Re: [PATCH] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag on Zynq

2020-12-23 Thread Andrew Lunn
On Wed, Dec 23, 2020 at 06:41:44PM +, Charles Keepax wrote: > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > macb_set_tx_clk were gated on the presence of this flag. > > if (!bp->tx_clk || !(bp->caps & MACB_CAPS_CLK_HW_CHG)) > > However the flag was not added to anything other

[PATCH] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag on Zynq

2020-12-23 Thread Charles Keepax
A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of macb_set_tx_clk were gated on the presence of this flag. if (!bp->tx_clk || !(bp->caps & MACB_CAPS_CLK_HW_CHG)) However the flag was not added to anything other than the new sama7g5_gem, turning that function call into a no op for all o

[PATCH net] ppp: hold mutex when unbridging channels in unregister path

2020-12-23 Thread Tom Parkin
Channels are bridged using the PPPIOCBRIDGECHAN ioctl, which executes with the ppp_mutex held. Unbridging may occur in two code paths: firstly an explicit PPPIOCUNBRIDGECHAN ioctl, and secondly on channel unregister. The latter may occur when closing the /dev/ppp instance or on teardown of the ch

Re: [PATCH net-next] net: tipc: Replace expression with offsetof()

2020-12-23 Thread Jakub Kicinski
On Tue, 22 Dec 2020 21:34:07 +0800 Zheng Yongjun wrote: > Use the existing offsetof() macro instead of duplicating code. > > Signed-off-by: Zheng Yongjun # Form letter - net-next is closed We have already sent the networking pull request for 5.11 and therefore net-next is closed for new drivers

Re: [PATCH] dt-bindings: net: qcom,ipa: Drop unnecessary type ref on 'memory-region'

2020-12-23 Thread Jakub Kicinski
On Mon, 21 Dec 2020 21:01:21 -0700 Rob Herring wrote: > 'memory-region' is a common property, so it doesn't need a type ref here. > > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Alex Elder > Cc: netdev@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Jakub Kicinski

Re: [PATCH net 1/2] net: mrp: fix definitions of MRP test packets

2020-12-23 Thread Andrew Lunn
> > @@ -96,7 +96,7 @@ struct br_mrp_ring_test_hdr { > > __be16 state; > > __be16 transitions; > > __be32 timestamp; > > -}; > > +} __attribute__((__packed__)); > > Yes, I agree that this should be packed but it also needs to be 32 bit > alligned, so extra 2 bytes are needed

[PATCH net] net: mvpp2: fix pkt coalescing int-threshold configuration

2020-12-23 Thread stefanc
From: Stefan Chulski The packet coalescing interrupt threshold has separated registers for different aggregated/cpu (sw-thread). The required value should be loaded for every thread but not only for 1 current cpu. Fixes: 213f428f5056 ("net: mvpp2: add support for TX interrupts and RX queue dist

Re: [RFC PATCH v2 8/8] arm64: dts: sparx5: Add the Sparx5 switch node

2020-12-23 Thread Steen Hegelund
On 19.12.2020 21:24, Andrew Lunn wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe + port13: port@13 { + reg = <13>; + /* Example: CU SFP, 1G speed */ + max-speed = <1>;

[PATCH iproute2-next 4/9] lib: Generalize parse_mapping()

2020-12-23 Thread Petr Machata
The function parse_mapping() assumes the key is a number, with a single configurable exception, which is using "all" to mean "all possible keys". If a caller wishes to use symbolic names instead of numbers, they cannot reuse this function. To facilitate reuse in these situations, convert parse_map

[PATCH iproute2-next 9/9] dcb: Add a subtool for the DCBX object

2020-12-23 Thread Petr Machata
The Linux DCBX object is a 1-byte bitfield of flags that configure whether the DCBX protocol is implemented in the device or in the host, and which version of the protocol should be used. Add a tool to access the per-port Linux DCBX object. For example: # dcb dcbx set dev eni1np1 host iee

[PATCH iproute2-next 1/9] dcb: Set values with RTM_SETDCB type

2020-12-23 Thread Petr Machata
dcb currently sends all netlink messages with a type RTM_GETDCB, even the set ones. Change to the appropriate type. Signed-off-by: Petr Machata --- dcb/dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dcb/dcb.c b/dcb/dcb.c index adec57476e1d..f5c62790e27e 100644 --- a/dc

Re: [PATCH net v2 1/3] net: fix race conditions in xps by locking the maps and dev->tc_num

2020-12-23 Thread Jakub Kicinski
On Tue, 22 Dec 2020 08:12:28 -0800 Alexander Duyck wrote: > On Tue, Dec 22, 2020 at 1:21 AM Antoine Tenart wrote: > > Quoting Alexander Duyck (2020-12-22 00:21:57) > > > > > > Looking over this patch it seems kind of obvious that extending the > > > xps_map_mutex is making things far more comple

  1   2   >