RE: [PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2020-12-14 Thread wangyunjian
> -Original Message- > From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com] > Sent: Tuesday, December 15, 2020 10:46 AM > To: wangyunjian > Cc: Network Development ; Michael S. Tsirkin > ; Jason Wang ; Willem de Bruijn > ; virtualizat...@lists.linux-foundation.org; > Lilijun (Je

[PATCH net-next v3 2/4] sch_htb: Hierarchical QoS hardware offload

2020-12-14 Thread Maxim Mikityanskiy
HTB doesn't scale well because of contention on a single lock, and it also consumes CPU. This patch adds support for offloading HTB to hardware that supports hierarchical rate limiting. This solution addresses two main problems of scaling HTB: 1. Contention by flow classification. Currently the f

Re: linux-next: build warning after merge of the net-next tree

2020-12-14 Thread Ioana Ciornei
On Tue, Dec 15, 2020 at 07:01:25AM +1100, Stephen Rothwell wrote: > Hi all, > > On Thu, 26 Nov 2020 17:40:57 +1100 Stephen Rothwell > wrote: > > > > After merging the net-next tree, today's linux-next build (htmldocs) > > produced this warning: > > > > include/linux/phy.h:869: warning: Function

[PATCH net-next v3 4/4] net/mlx5e: Support HTB offload

2020-12-14 Thread Maxim Mikityanskiy
This commit adds support for HTB offload in the mlx5e driver. Performance: NIC: Mellanox ConnectX-6 Dx CPU: Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (24 cores with HT) 100 Gbit/s line rate, 500 UDP streams @ ~200 Mbit/s each 48 traffic classes, flower used for steering No shaping (rat

[PATCH net-next v3 3/4] sch_htb: Stats for offloaded HTB

2020-12-14 Thread Maxim Mikityanskiy
This commit adds support for statistics of offloaded HTB. Bytes and packets counters for leaf and inner nodes are supported, the values are taken from per-queue qdiscs, and the numbers that the user sees should have the same behavior as the software (non-offloaded) HTB. Signed-off-by: Maxim Mikity

[PATCH net-next v3 1/4] net: sched: Add multi-queue support to sch_tree_lock

2020-12-14 Thread Maxim Mikityanskiy
The existing qdiscs that set TCQ_F_MQROOT don't use sch_tree_lock. However, hardware-offloaded HTB will start setting this flag while also using sch_tree_lock. The current implementation of sch_tree_lock basically locks on qdisc->dev_queue->qdisc, and it works fine when the tree is attached to som

[PATCH net-next v3 0/4] HTB offload

2020-12-14 Thread Maxim Mikityanskiy
This series adds support for HTB offload to the HTB qdisc, and adds usage to mlx5 driver. The previous RFCs are available at [1], [2]. The feature is intended to solve the performance bottleneck caused by the single lock of the HTB qdisc, which prevents it from scaling well. The HTB algorithm its

[PATCH iproute2-next] tc/htb: Hierarchical QoS hardware offload

2020-12-14 Thread Maxim Mikityanskiy
This commit adds support for configuring HTB in offload mode. HTB offload eliminates the single qdisc lock in the datapath and offloads the algorithm to the NIC. The new 'offload' parameter is added to enable this mode: # tc qdisc replace dev eth0 root handle 1: htb offload Classes are create

Re: [PATCH -next v2] net/mlx5_core: remove unused including

2020-12-14 Thread Saeed Mahameed
On Wed, 2020-12-09 at 15:01 +0800, Zou Wei wrote: > Remove including that don't need it. > > Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name") > Signed-off-by: Zou Wei > --- Applied to net-next-mlx5. Thanks!

Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

2020-12-14 Thread Saeed Mahameed
On Tue, 2020-12-08 at 16:25 -0800, David Miller wrote: > From: Zheng Yongjun > Date: Tue, 8 Dec 2020 21:56:25 +0800 > > > Simplify the return expression. > > > > Signed-off-by: Zheng Yongjun > > Applied. > Hey Dave, it's great to have you back! I still don't see this patch in net-next, i wi

[PATCH v2 net-next 2/2] nfc: s3fwrn5: Remove unused NCI prop commands

2020-12-14 Thread Bongsu Jeon
From: Bongsu Jeon Remove the unused NCI prop commands that s3fwrn5 driver doesn't use. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/nci.c | 25 - drivers/nfc/s3fwrn5/nci.h | 22 -- 2 files changed, 47 deletions(-) diff --git a/drivers/nfc/s3fw

[PATCH v2 net-next 0/2] nfc: s3fwrn5: Refactor the s3fwrn5 module

2020-12-14 Thread Bongsu Jeon
From: Bongsu Jeon Refactor the s3fwrn5 module. 1/2 is to remove the unneeded delay for NFC sleep. 2/2 is to remove the unused NCI prop commands. ChangeLog: v2: - Update the commit messages. Bongsu Jeon (2): nfc: s3fwrn5: Remove the delay for NFC sleep nfc: s3fwrn5: Remove unused NCI pro

[PATCH v2 net-next 1/2] nfc: s3fwrn5: Remove the delay for NFC sleep

2020-12-14 Thread Bongsu Jeon
From: Bongsu Jeon Remove the delay for NFC sleep because the delay is only needed to guarantee that the NFC is awake. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/phy_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/s3fwrn5/phy_common.c b/drivers

[PATCH net-next] phy: fix kdoc warning

2020-12-14 Thread Jakub Kicinski
Kdoc does not like it when multiline comment follows the networking style of starting right on the first line: include/linux/phy.h:869: warning: Function parameter or member 'config_intr' not described in 'phy_driver' Signed-off-by: Jakub Kicinski --- include/linux/phy.h | 3 ++- 1 file change

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 09:37:34PM -0800, Joe Perches wrote: > On Tue, 2020-12-15 at 07:18 +0200, Leon Romanovsky wrote: > > On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > > > I prefer revisions to single patches (as opposed to large patch series) > > > in the same thread. > > > > I

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-14 Thread Saeed Mahameed
On Mon, 2020-12-14 at 17:53 -0800, Alexander Duyck wrote: > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed > wrote: > > Hi Dave, Jakub, Jason, > > > > This series form Parav was the theme of this mlx5 release cycle, > > we've been waiting anxiously for the auxbus infrastructure to make > > it int

RE: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-14 Thread Parav Pandit
> From: Alexander Duyck > Sent: Tuesday, December 15, 2020 7:24 AM > > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed > wrote: > > > > Hi Dave, Jakub, Jason, > > > > Just to clarify a few things for myself. You mention virtualization and SR-IOV > in your patch description but you cannot suppor

Re: [PATCH] net: check skb partial checksum offset after trim

2020-12-14 Thread Vasily Averin
On 12/15/20 12:07 AM, Willem de Bruijn wrote: > On Mon, Dec 14, 2020 at 3:56 PM Jakub Kicinski wrote: >> >> On Sun, 13 Dec 2020 20:59:54 -0500 Willem de Bruijn wrote: >>> On Sun, Dec 13, 2020 at 2:37 PM Vasily Averin wrote: >> On 12/11/20 6:37 PM, Vasily Averin wrote: >>> It seems for me

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Joe Perches
On Tue, 2020-12-15 at 07:18 +0200, Leon Romanovsky wrote: > On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > > I prefer revisions to single patches (as opposed to large patch series) > > in the same thread. > > It depends which side you are in that game. From the reviewer point of >

[PATCH v2] net/connector: Add const qualifier to cb_id

2020-12-14 Thread Geoff Levand
The connector driver never modifies any cb_id passed to it, so add a const qualifier to those arguments so callers can declare their struct cb_id as a constant object. Fixes build warnings like these when passing a constant struct cb_id: warning: passing argument 1 of ‘cn_add_callback’ discards

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > On Mon, 2020-12-14 at 11:03 -0800, Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote: > > > On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote: > > > > It is fix for semantic patch warning

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-14 Thread David Ahern
On 12/13/20 11:21 AM, Boris Pismenny wrote: >>> as zerocopy for the following reasons: >>> (1) The former places buffers *exactly* where the user requests >>> regardless of the order of response arrivals, while the latter places >>> packets >>> in anonymous buffers according to packet arrival orde

Re: [net-next v4 01/15] net/mlx5: Fix compilation warning for 32-bit platform

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 02:31:25PM -0800, Alexander Duyck wrote: > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed wrote: > > > > From: Parav Pandit > > > > MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field. > > > > Defining an enum for such bit fields on 32-bit platform results in below >

Re: [PATCH net-next] seg6: fix the max number of supported SRv6 behavior attributes

2020-12-14 Thread Jakub Kicinski
On Sat, 12 Dec 2020 02:00:05 +0100 Andrea Mayer wrote: > The set of required attributes for a given SRv6 behavior is identified > using a bitmap stored in an unsigned long, since the initial design of > SRv6 networking in Linux. Recently the same approach has been used for > identifying the optiona

Re: BUG: soft lockup in mac80211_hwsim_beacon

2020-12-14 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:2c85ebc5 Linux 5.10 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148fcc1350 kernel config: https://syzkaller.appspot.com/x/.config?x=8aff533d6c635e6 dashboard link: https://syzkalle

Re: [PATCH net 2/2] vhost_net: fix high cpu load when sendmsg fails

2020-12-14 Thread Jason Wang
On 2020/12/15 上午9:48, wangyunjian wrote: From: Yunjian Wang Currently we break the loop and wake up the vhost_worker when sendmsg fails. When the worker wakes up again, we'll meet the same error. This will cause high CPU load. To fix this issue, we can skip this description by ignoring the er

[PATCHv4 net-next] octeontx2-pf: Add RSS multi group support

2020-12-14 Thread Geetha sowjanya
Hardware supports 8 RSS groups per interface. Currently we are using only group '0'. This patch allows user to create new RSS groups/contexts and use the same as destination for flow steering rules. usage: To steer the traffic to RQ 2,3 ethtool -X eth0 weight 0 0 1 1 context new (It will print th

[PATCH net-next v4] GTP: add support for flow based tunneling API

2020-12-14 Thread Pravin B Shelar
Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- v3-v4: - add check for non-zero dst port v2-v3: - Fi

Re: [PATCH][next] net: hns3: fix expression that is currently always true

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 15 Dec 2020 00:00:33 + you wrote: > From: Colin Ian King > > The || condition in hdev->fd_active_type != HCLGE_FD_ARFS_ACTIVE || > hdev->fd_active_type != HCLGE_FD_RULE_NONE will always be true because > hdev

Re: [PATCH net-next v2] GTP: add support for flow based tunneling API

2020-12-14 Thread Pravin Shelar
On Mon, Dec 14, 2020 at 12:29 AM Jonas Bonn wrote: > > Hi Pravin, > > On 13/12/2020 20:32, Pravin Shelar wrote: > > On Sat, Dec 12, 2020 at 11:56 PM Jonas Bonn wrote: > >> > >> Hi Pravin, > >> > >> I've been thinking a bit about this and find it more and more > >> interesting. Could you post a b

Re: [net-next PATCH v3] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 12:31:24 -0800 you wrote: > From: Alexander Duyck > > There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG > message in the case of IPv6 or a fragmentation request in the case of > IPv

Re: [PATCH v2 1/1] net: Fix use of proc_fs

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 22:25:50 +0200 Yonatan Linik wrote: > proc_fs was used, in af_packet, without a surrounding #ifdef, > although there is no hard dependency on proc_fs. > That caused the initialization of the af_packet module to fail > when CONFIG_PROC_FS=n. > > Specifically, proc_create_net() w

Re: [PATCH net-next v4 0/5] vsock: Add flags field in the vsock address

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 18:11:17 +0200 you wrote: > vsock enables communication between virtual machines and the host they are > running on. Nested VMs can be setup to use vsock channels, as the multi > transport support has b

Re: [PATCH -next] nfc/pn533/usb: convert comma to semicolon

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 21:43:14 +0800 you wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/nfc/pn533/usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH net V3] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 13 Dec 2020 16:39:29 +0200 you wrote: > With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be > logically done when HW_CSUM offload is off. > > Fixes: 2342a8512a1e ("net: Add TLS TX offload features")

Re: [PATCH v4 net-next] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 21:16:12 +0200 you wrote: > Currently ocelot_set_rx_mode calls ocelot_mact_learn directly, which has > a very nice ocelot_mact_wait_for_completion at the end. Introduced in > commit 639c1b2625af ("net: m

Re: [PATCH net-next] nfc: s3fwrn5: Remove unused nci prop commands

2020-12-14 Thread Bongsu Jeon
On Tue, Dec 15, 2020 at 1:02 AM Krzysztof Kozlowski wrote: > > On Mon, Dec 14, 2020 at 08:46:58PM +0900, Bongsu Jeon wrote: > > From: Bongsu Jeon > > > > remove the unused nci prop commands that samsung driver doesn't use. > > Don't send patches one-by-one, but group them in a patchset. > > Previ

[net-next] tipc: do sanity check payload of a netlink message

2020-12-14 Thread Hoang Huu Le
From: Hoang Le When we initialize nlmsghdr with no payload inside tipc_nl_compat_dumpit() the parsing function returns -EINVAL. We fix it by making the parsing call conditional. Acked-by: Jon Maloy Signed-off-by: Hoang Le --- net/tipc/netlink_compat.c | 12 +++- 1 file changed, 7 inse

[PATCH] tipc: do sanity check payload of a netlink message

2020-12-14 Thread Hoang Huu Le
From: Hoang Le When we initialize nlmsghdr with no payload inside tipc_nl_compat_dumpit() the parsing function returns -EINVAL. We fix it by making the parsing call conditional. Acked-by: Jon Maloy Signed-off-by: Hoang Le --- net/tipc/netlink_compat.c | 12 +++- 1 file changed, 7 inse

Re: [PATCH net-next] nfc: s3fwrn5: Release the nfc firmware

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 13 Dec 2020 18:58:50 +0900 you wrote: > From: Bongsu Jeon > > add the code to release the nfc firmware when the firmware image size is > wrong. > > Signed-off-by: Bongsu Jeon > > [...] Here is the summary with

Re: [PATCH net-next] net: vxget: clean up sparse warnings

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 15:44:26 -0800 you wrote: > This code is copying strings in 64 bit quantities, the device > returns them in big endian. As long as we store in big endian > IOW endian on both sides matches, we're good, s

Re: [PATCH net-next v2 0/4] net: avoid indirect calls in dst functions

2020-12-14 Thread Jakub Kicinski
On Fri, 11 Dec 2020 23:33:36 + Brian Vazquez wrote: > From: brianvv We'd prefer you to use your normal name rather than just "brianvv". > Use of the indirect call wrappers in some dst related functions for the > ipv6/ipv4 case. This is a small improvent for CONFIG_RETPOLINE=y Any numbers yo

Re: [PATCH] net/connector: Add const qualifier to cb_id

2020-12-14 Thread Jakub Kicinski
On Sat, 12 Dec 2020 18:47:01 -0800 Geoff Levand wrote: > The connector driver never modifies any cb_id passed to it, so add a const > qualifier to those arguments so callers can declare their struct cb_id as a > constant object. > > Fixes build warnings like these when passing a constant struct cb

Re: pull-request: can-next 2020-12-14

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 14:31:38 +0100 you wrote: > Hello Jakub, hello David, > > this is a series of 7 patches for net-next/master. > > All 7 patches are by me and target the m_can driver. First there are 4 cleanup >

Re: [PATCH net-next v2 00/15] mlxsw: Introduce initial XM router support

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 13:30:26 +0200 you wrote: > From: Ido Schimmel > > This patch set implements initial eXtended Mezzanine (XM) router > support. > > The XM is an external device connected to the Spectrum-{2,3} ASICs u

Re: [PATCH net-next 0/5] bnxt_en: Improve firmware flashing.

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 13 Dec 2020 06:51:41 -0500 you wrote: > This patchset improves firmware flashing in 2 ways: > > - If firmware returns NO_SPACE error during flashing, the driver will > create the UPDATE directory with more staging

Re: [PATCH net-next v3] inet_ecn: Use csum16_add() helper for IP_ECN_set_* helpers

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 15:26:38 +0100 you wrote: > Jakub pointed out that the IP_ECN_set* helpers basically open-code > csum16_add(), so let's switch them over to using the helper instead. > > v2: > - Use __be16 for check_add

Re: [PATCH v2] net: drop bogus skb with CHECKSUM_PARTIAL and offset beyond end of trimmed packet

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 22:07:39 +0300 you wrote: > syzbot reproduces BUG_ON in skb_checksum_help(): > tun creates (bogus) skb with huge partial-checksummed area and > small ip packet inside. Then ip_rcv trims the skb based on

Re: [PATCH v2] MAINTAINERS: add mvpp2 driver entry

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 17:51:14 +0100 you wrote: > Since its creation Marvell NIC driver for Armada 375/7k8k and > CN913x SoC families mvpp2 has been lacking an entry in MAINTAINERS, > which sometimes lead to unhandled bugs th

Re: [linux-nfc] [PATCH net-next] MAINTAINERS: Update maintainer for SAMSUNG S3FWRN5 NFC

2020-12-14 Thread Bongsu Jeon
On Tue, Dec 15, 2020 at 12:44 AM Krzysztof Kozlowski wrote: > > On Mon, Dec 14, 2020 at 09:28:23PM +0900, Bongsu Jeon wrote: > > From: Bongsu Jeon > > > > add an email to look after the SAMSUNG NFC driver. > > Hi Bongsu, > > Review and testing is always appreciated. However before adding an entry

Re: [PATCH v1 bpf-next 05/11] tcp: Migrate TCP_NEW_SYN_RECV requests.

2020-12-14 Thread Martin KaFai Lau
On Tue, Dec 15, 2020 at 02:03:13AM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Thu, 10 Dec 2020 10:49:15 -0800 > > On Thu, Dec 10, 2020 at 02:15:38PM +0900, Kuniyuki Iwashima wrote: > > > From: Martin KaFai Lau > > > Date: Wed, 9 Dec 2020 16:07:07 -0800 > > > > On Tue

Re: [PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2020-12-14 Thread Willem de Bruijn
On Mon, Dec 14, 2020 at 8:59 PM wangyunjian wrote: > > From: Yunjian Wang > > Currently the vhost_zerocopy_callback() maybe be called to decrease > the refcount when sendmsg fails in tun. The error handling in vhost > handle_tx_zerocopy() will try to decrease the same refcount again. > This is wr

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-14 Thread David Ahern
On 12/14/20 6:53 PM, Alexander Duyck wrote: >> example subfunction usage sequence: >> --- >> Change device to switchdev mode: >> $ devlink dev eswitch set pci/:06:00.0 mode switchdev >> >> Add a devlink port of subfunction flaovur: >> $ devlink port add pci/:

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Stephen Rothwell
Hi Jakub, On Mon, 14 Dec 2020 18:06:29 -0800 Jakub Kicinski wrote: > > AFAIU all we can do is tell Linus about the merge issue, and point > at Stephen's resolution. This is the correct response. -- Cheers, Stephen Rothwell pgpnhmtyKgstY.pgp Description: OpenPGP digital signature

Re: [PATCH net] nfp: do not send control messages during cleanup

2020-12-14 Thread Jakub Kicinski
On Fri, 11 Dec 2020 10:27:38 +0100 Simon Horman wrote: > On cleanup the txbufs are freed before app cleanup. But app clean-up may > result in control messages due to use of common control paths. There is no > need to clean-up the NIC in such cases so simply discard requests. Without > such a check

Re: [PATCH v2] net: bridge: Fix a warning when del bridge sysfs

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 20:29:21 +0800 you wrote: > I got a warining report: > > br_sysfs_addbr: can't create group bridge4/bridge > [ cut here ] > sysfs group 'bridge' not found for kobject 'bridge4' >

[stabe-rc 5.9 ] sched: core.c:7270 Illegal context switch in RCU-bh read-side critical section!

2020-12-14 Thread Naresh Kamboju
There are two warnings "WARNING: suspicious RCU usage" noticed on arm64 juno-r2 device while running selftest bpf test_tc_edt.sh and net: udpgro_bench.sh. These warnings are occurring intermittently. metadata: git branch: linux-5.9.y git repo: https://git.kernel.org/pub/scm/linux/kernel/git/s

Re: [PATCH net-next v2] net: dsa: mv88e6xxx: don't set non-existing learn2all bit for 6220/6250

2020-12-14 Thread Jakub Kicinski
On Thu, 10 Dec 2020 12:06:44 +0100 Rasmus Villemoes wrote: > The 6220 and 6250 switches do not have a learn2all bit in global1, ATU > control register; bit 3 is reserverd. > > On the switches that do have that bit, it is used to control whether > learning frames are sent out the ports that have th

[PATCH v2] net: korina: fix return value

2020-12-14 Thread Vincent Stehlé
The ndo_start_xmit() method must not attempt to free the skb to transmit when returning NETDEV_TX_BUSY. Therefore, make sure the korina_send_packet() function returns NETDEV_TX_OK when it frees a packet. Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") Suggested-by: Jakub

Re: [PATCH net v2] net: openvswitch: fix TTL decrement exception action execution

2020-12-14 Thread Jakub Kicinski
On Mon, 7 Dec 2020 05:08:39 -0500 Eelco Chaudron wrote: > Currently, the exception actions are not processed correctly as the wrong > dataset is passed. This change fixes this, including the misleading > comment. > > In addition, a check was added to make sure we work on an IPv4 packet, > and not

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 18:11:21 -0800 Andrew Morton wrote: > On Mon, 14 Dec 2020 18:06:29 -0800 Jakub Kicinski wrote: > > Hm. The code is in net-next by now. I was thinking of sending the > > Networking PR later today (tonight?) as well. I'm happy to hold off > > or do whatever you require, but I'd

Re: [PATCH net-next 00/10] Netfilter/IPVS updates for net-next

2020-12-14 Thread Jakub Kicinski
On Sun, 13 Dec 2020 00:05:03 +0100 Pablo Neira Ayuso wrote: > 1) Missing dependencies in NFT_BRIDGE_REJECT, from Randy Dunlap. > > 2) Use atomic_inc_return() instead of atomic_add_return() in IPVS, >from Yejune Deng. > > 3) Simplify check for overquota in xt_nfacct, from Kaixu Xia. > > 4) Mo

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Andrew Morton
On Mon, 14 Dec 2020 18:06:29 -0800 Jakub Kicinski wrote: > On Mon, 14 Dec 2020 17:40:21 -0800 Andrew Morton wrote: > > On Mon, 14 Dec 2020 17:29:43 -0800 Roman Gushchin wrote: > > > On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > > > > On Fri, 4 Dec 2020 20:20:05 +1100 Step

Re: pull-request: bpf-next 2020-12-14

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 22:43:16 +0100 Daniel Borkmann wrote: > 1) Expose bpf_sk_storage_*() helpers to iterator programs, from Florent > Revest. > > 2) Add AF_XDP selftests based on veth devs to BPF selftests, from Weqaar > Janjua. > > 3) Support for finding BTF based kernel attach targets through

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 17:40:21 -0800 Andrew Morton wrote: > On Mon, 14 Dec 2020 17:29:43 -0800 Roman Gushchin wrote: > > On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > > > On Fri, 4 Dec 2020 20:20:05 +1100 Stephen Rothwell > > > wrote: > > > > Today's linux-next merge of t

Re: [PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-14 Thread Jakub Kicinski
On Sun, 13 Dec 2020 21:59:45 +0800 Cambda Zhu wrote: > > On Dec 13, 2020, at 06:32, Jakub Kicinski wrote: > > On Tue, 8 Dec 2020 17:19:10 +0800 Cambda Zhu wrote: > >> For each TCP zero window probe, the icsk_backoff is increased by one and > >> its max value is tcp_retries2. If tcp_retries2 is

[PATCH] net: core: fix msleep() is not accurate

2020-12-14 Thread Yejune Deng
See Documentation/timers/timers-howto.rst, msleep() is not for (1ms - 20ms), use usleep_range() instead. Signed-off-by: Yejune Deng --- net/core/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index d33099f..c0aa52f 100644 --- a/net/c

Re: [PATCH v2 net-next] ice, xsk: Move Rx allocation out of while-loop

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 09:54:10 +0100 you wrote: > From: Björn Töpel > > Instead doing the check for allocation in each loop, move it outside > the while loop and do it every NAPI loop. > > This change boosts the xdpsock rx

Re: [PATCHv6 net-next 0/3] Add devlink and devlink health reporters to

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 11:55:23 +0530 you wrote: > Add basic devlink and devlink health reporters. > Devlink health reporters are added for NPA block. > > Address Jakub's comment to add devlink support for error reporting. >

Re: [PATCH net-next] net/mediatek: simplify the mediatek code return expression

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 16:38:01 +0800 you wrote: > Simplify the return expression at mtk_eth_path.c file, simplify this all. > > Signed-off-by: Zheng Yongjun > --- > drivers/net/ethernet/mediatek/mtk_eth_path.c | 16 ---

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-14 Thread Alexander Duyck
On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed wrote: > > Hi Dave, Jakub, Jason, > > This series form Parav was the theme of this mlx5 release cycle, > we've been waiting anxiously for the auxbus infrastructure to make it into > the kernel, and now as the auxbus is in and all the stars are aligned

Re: [PATCH net-next 0/9] mptcp: Another set of miscellaneous MPTCP fixes

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 10 Dec 2020 14:24:57 -0800 you wrote: > This is another collection of MPTCP fixes and enhancements that we have > tested in the MPTCP tree: > > Patch 1 cleans up cgroup attachment for in-kernel subflow sockets. > >

Re: [PATCHv2] selftests: test_vxlan_under_vrf: mute unnecessary error message

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Fri, 11 Dec 2020 12:24:20 +0800 you wrote: > The cleanup function in this script that tries to delete hv-1 / hv-2 > vm-1 / vm-2 netns will generate some uncessary error messages: > > Cannot remove namespace file "/run/netn

Re: [PATCH] bpf,x64: pad NOPs to make images converge more easily

2020-12-14 Thread Gary Lin
On Mon, Dec 14, 2020 at 04:31:44PM +0100, Daniel Borkmann wrote: > On 12/14/20 9:15 AM, Gary Lin wrote: > > On Mon, Dec 14, 2020 at 11:56:22AM +0800, Gary Lin wrote: > > > On Fri, Dec 11, 2020 at 09:05:05PM +0100, Daniel Borkmann wrote: > > > > On 12/11/20 9:19 AM, Gary Lin wrote: > > > > > The x64

[PATCH net 0/2] fixes for vhost_net

2020-12-14 Thread wangyunjian
From: Yunjian Wang This series include two fixes patches for vhost_net. Yunjian Wang (2): vhost_net: fix ubuf refcount incorrectly when sendmsg fails vhost_net: fix high cpu load when sendmsg fails drivers/vhost/net.c | 27 --- 1 file changed, 12 insertions(+), 15 d

[PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2020-12-14 Thread wangyunjian
From: Yunjian Wang Currently the vhost_zerocopy_callback() maybe be called to decrease the refcount when sendmsg fails in tun. The error handling in vhost handle_tx_zerocopy() will try to decrease the same refcount again. This is wrong. To fix this issue, we only call vhost_net_ubuf_put() when vq

[PATCH net 2/2] vhost_net: fix high cpu load when sendmsg fails

2020-12-14 Thread wangyunjian
From: Yunjian Wang Currently we break the loop and wake up the vhost_worker when sendmsg fails. When the worker wakes up again, we'll meet the same error. This will cause high CPU load. To fix this issue, we can skip this description by ignoring the error. When we exceeds sndbuf, the return value

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Andrew Morton
On Mon, 14 Dec 2020 17:29:43 -0800 Roman Gushchin wrote: > On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > > Hi all, > > > > On Fri, 4 Dec 2020 20:20:05 +1100 Stephen Rothwell > > wrote: > > > > > > Today's linux-next merge of the akpm-current tree got conflicts in: > > >

Re: [PATCH] selftests/bpf: clarify build error if no vmlinux

2020-12-14 Thread Andrii Nakryiko
On Mon, Dec 14, 2020 at 12:21 PM Kamal Mostafa wrote: > > If Makefile cannot find any of the vmlinux's in its VMLINUX_BTF_PATHS list, > it tries to run btftool incorrectly, with VMLINUX_BTF unset: > > bpftool btf dump file $(VMLINUX_BTF) format c > > Such that the keyword 'format' is misinterp

Re: [PATCH][next] net: hns3: fix expression that is currently always true

2020-12-14 Thread Huazhong Tan
On 2020/12/15 8:00, Colin King wrote: From: Colin Ian King The || condition in hdev->fd_active_type != HCLGE_FD_ARFS_ACTIVE || hdev->fd_active_type != HCLGE_FD_RULE_NONE will always be true because hdev->fd_active_type cannot be equal to two different values at the same time. The expression i

Re: [PATCH] net: korina: remove busy skb free

2020-12-14 Thread Vincent Stehlé
On Mon, Dec 14, 2020 at 01:08:32PM -0800, Jakub Kicinski wrote: > On Mon, 14 Dec 2020 11:03:12 +0100 Julian Wiedmann wrote: > > > diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c > > > index bf48f0ded9c7d..9d84191de6824 100644 > > > --- a/drivers/net/ethernet/korina.c > >

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Roman Gushchin
On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > Hi all, > > On Fri, 4 Dec 2020 20:20:05 +1100 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the akpm-current tree got conflicts in: > > > > include/linux/memcontrol.h > > mm/memcontrol.c > > > > between com

Re: [PATCH] net: mhi: Fix unexpected queue wake

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 10 Dec 2020 12:25:07 +0100 you wrote: > This patch checks that MHI queue is not full before waking up the net > queue. This fix sporadic MHI queueing issues in xmit. Indeed xmit and > its symmetric complete callback

[PATCH net-next] sfc: reduce the number of requested xdp ev queues

2020-12-14 Thread Ivan Babrou
Without this change the driver tries to allocate too many queues, breaching the number of available msi-x interrupts on machines with many logical cpus and default adapter settings: Insufficient resources for 12 XDP event queues (24 other channels, max 32) Which in turn triggers EINVAL on XDP pro

Re: [PATCH] net: korina: remove busy skb free

2020-12-14 Thread Vincent Stehlé
On Mon, Dec 14, 2020 at 11:03:12AM +0100, Julian Wiedmann wrote: > On 13.12.20 18:20, Vincent Stehlé wrote: ... > > @@ -216,7 +216,6 @@ static int korina_send_packet(struct sk_buff *skb, > > struct net_device *dev) > > netif_stop_queue(dev); > > else { > >

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Bjorn Helgaas
On Mon, Dec 14, 2020 at 11:56:31PM +0100, Ian Kumlien wrote: > On Mon, Dec 14, 2020 at 8:19 PM Bjorn Helgaas wrote: > > If you're interested, you could probably unload the Realtek drivers, > > remove the devices, and set the PCI_EXP_LNKCTL_LD (Link Disable) bit > > in 02:04.0, e.g., > > > > # R

Re: [PATCH][c89] wrong usage of compiler constants

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 16:30:01 + sylvain.bertr...@legeek.net wrote: > From: Sylvain BERTRAND > > Using a c89 compiler fails due some wrong usage of compiler constants. Are you saying it fails on some known compilers in the code you're fixing? We have a strong preference to ask contributors to

Re: [PATCH] devlink: use _BITUL() macro instead of BIT() in the UAPI header

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 12:21:57 +0100 Tobias Klauser wrote: > The BIT() macro is not available for the UAPI headers. Moreover, it can > be defined differently in user space headers. Thus, replace its usage > with the _BITUL() macro which is already used in other macro definitions > in . > > Fixes: dc

Re: [net-next 0/2] Adds CMSG+rx timestamps to TCP rx. zerocopy

2020-12-14 Thread Jakub Kicinski
On Fri, 11 Dec 2020 10:44:17 -0800 Arjun Roy wrote: > From: Arjun Roy > > This patch series provides CMSG and receive timestamp support to TCP > receive zerocopy. Patch 1 refactors CMSG pending state for > tcp_recvmsg() to avoid the use of magic numbers; patch 2 implements > receive timestamp via

Re: [net-next 2/2] tcp: Add receive timestamp support for receive zerocopy.

2020-12-14 Thread Jakub Kicinski
On Fri, 11 Dec 2020 10:44:19 -0800 Arjun Roy wrote: > From: Arjun Roy > > tcp_recvmsg() uses the CMSG mechanism to receive control information > like packet receive timestamps. This patch adds CMSG fields to > struct tcp_zerocopy_receive, and provides receive timestamps > if available to the user

[PATCH][next] net: hns3: fix expression that is currently always true

2020-12-14 Thread Colin King
From: Colin Ian King The || condition in hdev->fd_active_type != HCLGE_FD_ARFS_ACTIVE || hdev->fd_active_type != HCLGE_FD_RULE_NONE will always be true because hdev->fd_active_type cannot be equal to two different values at the same time. The expression is always true which is not correct. Fix t

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 11:30:08 +0100 Vasyl Gomonovych wrote: > It is fix for semantic patch warning available in > scripts/coccinelle/misc/boolinit.cocci > Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable > Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable > > Signed

[PATCH][next] netfilter: nftables: fix incorrect increment of loop counter

2020-12-14 Thread Colin King
From: Colin Ian King The intention of the err_expr cleanup path is to iterate over the allocated expr_array objects and free them, starting from i - 1 and working down to the start of the array. Currently the loop counter is being incremented instead of decremented and also the index i is being u

[PATCH][next] ath11k: add missing null check on allocated skb

2020-12-14 Thread Colin King
From: Colin Ian King Currently the null check on a newly allocated skb is missing and this can lead to a null pointer dereference is the allocation fails. Fix this by adding a null check and returning -ENOMEM. Addresses-Coverity: ("Dereference null return") Fixes: 43ed15e1ee01 ("ath11k: put hw t

Re: [PATCH net-next v2 3/3] use __netdev_notify_peers in hyperv

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 15:19:30 -0600 Lijun Pan wrote: > Start to use the lockless version of netdev_notify_peers. > Call the helper where notify variable used to be set true. > Remove the notify bool variable and sort the variables > in reverse Christmas tree order. > > Cc: Haiyang Zhang > Signed-o

Re: [PATCH v2 net-next] net: phy: mchp: Add 1588 support for LAN8814 Quad PHY

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 23:26:58 +0530 Divya Koppera wrote: > This patch add supports for 1588 Hardware Timestamping support > to LAN8814 Quad Phy. It supports L2 and Ipv4 encapsulations. > > Signed-off-by: Divya Koppera > --- > v1 -> v2 > * Fixed warnings > Reported-by: kernel test robot Still do

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Ian Kumlien
On Mon, Dec 14, 2020 at 8:19 PM Bjorn Helgaas wrote: > > On Mon, Dec 14, 2020 at 04:47:32PM +0100, Ian Kumlien wrote: > > On Mon, Dec 14, 2020 at 3:02 PM Bjorn Helgaas wrote: > > > On Mon, Dec 14, 2020 at 10:14:18AM +0100, Ian Kumlien wrote: > > > > On Mon, Dec 14, 2020 at 6:44 AM Bjorn Helgaas

Re: [net-next PATCH v12 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-12-14 Thread Rob Herring
On Fri, 11 Dec 2020 22:46:04 +1000, Pavana Sharma wrote: > Add 5gbase-r PHY interface mode. > > Signed-off-by: Pavana Sharma > --- > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

Re: [PATCH] net: mscc: ocelot: Fix a resource leak in the error handling path of the probe function

2020-12-14 Thread Alexandre Belloni
On 13/12/2020 12:48:38+0100, Christophe JAILLET wrote: > In case of error after calling 'ocelot_init()', it must be undone by a > corresponding 'ocelot_deinit()' call, as already done in the remove > function. > > Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") > Signed-off-by

Re: [net-next v4 01/15] net/mlx5: Fix compilation warning for 32-bit platform

2020-12-14 Thread Saeed Mahameed
On Mon, 2020-12-14 at 14:31 -0800, Alexander Duyck wrote: > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed > wrote: > > From: Parav Pandit > > > > MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field. > > > > Defining an enum for such bit fields on 32-bit platform results in > > below > > w

  1   2   3   4   >