Re: [PATCH net-next v2] GTP: add support for flow based tunneling API

2020-12-12 Thread Jonas Bonn
Hi Pravin, I've been thinking a bit about this and find it more and more interesting. Could you post a bit of information about the ip-route changes you'll make in order to support GTP LWT encapsulation? Could you provide an example command line? I understand the advantages here of couplin

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-12 Thread Miguel Ojeda
On Sat, Dec 12, 2020 at 5:18 PM Guenter Roeck wrote: > > This patch results in: > > arch/sh/kernel/cpu/sh4a/smp-shx3.c: In function 'shx3_prepare_cpus': > arch/sh/kernel/cpu/sh4a/smp-shx3.c:76:3: error: ignoring return value of > 'request_irq' declared with attribute 'warn_unused_result' > > when

Re: [PATCH v2 net-next 6/6] net: dsa: ocelot: request DSA to fix up lack of address learning on CPU port

2020-12-12 Thread Florian Fainelli
On 12/12/2020 6:40 PM, Vladimir Oltean wrote: > Given the following setup: > > ip link add br0 type bridge > ip link set eno0 master br0 > ip link set swp0 master br0 > ip link set swp1 master br0 > ip link set swp2 master br0 > ip link set swp3 master br0 > > Currently, packets received on a

Re: [PATCH v2 net-next 5/6] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

2020-12-12 Thread Florian Fainelli
On 12/12/2020 6:40 PM, Vladimir Oltean wrote: > Some DSA switches (and not only) cannot learn source MAC addresses from > packets injected from the CPU. They only perform hardware address > learning from inbound traffic. > > This can be problematic when we have a bridge spanning some DSA switch

Re: [PATCH v2 net-next 2/6] net: dsa: don't use switchdev_notifier_fdb_info in dsa_switchdev_event_work

2020-12-12 Thread Florian Fainelli
On 12/12/2020 6:40 PM, Vladimir Oltean wrote: > Currently DSA doesn't add FDB entries on the CPU port, because it only > does so through switchdev, which is associated with a net_device, and > there are none of those for the CPU port. > > But actually FDB addresses on the CPU port have some use

Re: [PATCH v2 net-next 3/6] net: dsa: move switchdev event implementation under the same switch/case statement

2020-12-12 Thread Florian Fainelli
On 12/12/2020 6:40 PM, Vladimir Oltean wrote: > We'll need to start listening to SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE > events even for interfaces where dsa_slave_dev_check returns false, so > we need that check inside the switch-case statement for SWITCHDEV_FDB_*. > > This movement also avoids a

Re: [PATCH v2 net-next 4/6] net: dsa: exit early in dsa_slave_switchdev_event if we can't program the FDB

2020-12-12 Thread Florian Fainelli
On 12/12/2020 6:40 PM, Vladimir Oltean wrote: > Right now, the following would happen for a switch driver that does not > implement .port_fdb_add or .port_fdb_del. > > dsa_slave_switchdev_event returns NOTIFY_OK and schedules: > -> dsa_slave_switchdev_event_work >-> dsa_port_fdb_add >

[PATCH] net/connector: Add const qualifier to cb_id

2020-12-12 Thread Geoff Levand
The connector driver never modifies any cb_id passed to it, so add a const qualifier to those arguments so callers can declare their struct cb_id as a constant object. Fixes build warnings like these when passing a constant struct cb_id: warning: passing argument 1 of ‘cn_add_callback’ discards

[PATCH v2 net-next 1/6] net: bridge: notify switchdev of disappearance of old FDB entry upon migration

2020-12-12 Thread Vladimir Oltean
Currently the bridge emits atomic switchdev notifications for dynamically learnt FDB entries. Monitoring these notifications works wonders for switchdev drivers that want to keep their hardware FDB in sync with the bridge's FDB. For example station A wants to talk to station B in the diagram below

[PATCH v2 net-next 2/6] net: dsa: don't use switchdev_notifier_fdb_info in dsa_switchdev_event_work

2020-12-12 Thread Vladimir Oltean
Currently DSA doesn't add FDB entries on the CPU port, because it only does so through switchdev, which is associated with a net_device, and there are none of those for the CPU port. But actually FDB addresses on the CPU port have some use cases of their own, if the switchdev operations are initia

[PATCH v2 net-next 6/6] net: dsa: ocelot: request DSA to fix up lack of address learning on CPU port

2020-12-12 Thread Vladimir Oltean
Given the following setup: ip link add br0 type bridge ip link set eno0 master br0 ip link set swp0 master br0 ip link set swp1 master br0 ip link set swp2 master br0 ip link set swp3 master br0 Currently, packets received on a DSA slave interface (such as swp0) which should be routed by the soft

[PATCH v2 net-next 5/6] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

2020-12-12 Thread Vladimir Oltean
Some DSA switches (and not only) cannot learn source MAC addresses from packets injected from the CPU. They only perform hardware address learning from inbound traffic. This can be problematic when we have a bridge spanning some DSA switch ports and some non-DSA ports (which we'll call "foreign in

[PATCH v2 net-next 4/6] net: dsa: exit early in dsa_slave_switchdev_event if we can't program the FDB

2020-12-12 Thread Vladimir Oltean
Right now, the following would happen for a switch driver that does not implement .port_fdb_add or .port_fdb_del. dsa_slave_switchdev_event returns NOTIFY_OK and schedules: -> dsa_slave_switchdev_event_work -> dsa_port_fdb_add -> dsa_port_notify(DSA_NOTIFIER_FDB_ADD) -> dsa_switc

[PATCH v2 net-next 3/6] net: dsa: move switchdev event implementation under the same switch/case statement

2020-12-12 Thread Vladimir Oltean
We'll need to start listening to SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE events even for interfaces where dsa_slave_dev_check returns false, so we need that check inside the switch-case statement for SWITCHDEV_FDB_*. This movement also avoids a useless allocation / free of switchdev_work on the untreate

[PATCH v2 net-next 0/6] Offload software learnt bridge addresses to DSA

2020-12-12 Thread Vladimir Oltean
This small series tries to make DSA behave a bit more sanely when bridged with "foreign" (non-DSA) interfaces. When a station A connected to a DSA switch port needs to talk to another station B connected to a non-DSA port through the Linux bridge, DSA must explicitly add a route for station B towar

Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Florian Fainelli
On 12/12/2020 4:49 PM, Vladimir Oltean wrote: > On Sun, Dec 13, 2020 at 01:34:10AM +0100, Andrew Lunn wrote: >> On Sun, Dec 13, 2020 at 12:14:19AM +, Vladimir Oltean wrote: >>> On Sun, Dec 13, 2020 at 01:08:55AM +0100, Andrew Lunn wrote: >> And you need some way to cleanup the allocated

Re: [PATCH net-next 3/3] use __netdev_notify_peers in hyperv

2020-12-12 Thread Jakub Kicinski
On Wed, 9 Dec 2020 00:18:11 -0600 Lijun Pan wrote: > Start to use the lockless version of netdev_notify_peers. > > Cc: Haiyang Zhang > Signed-off-by: Lijun Pan > --- > drivers/net/hyperv/netvsc_drv.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/hy

Re: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 8 Dec 2020 19:33:46 -0800 you wrote: > According to the X.25 documentation, there was a plan to implement > X.25-over-802.2-LLC. It never finished but left various code stubs in the > X.25 code. At this time it is

Re: [PATCH net-next] net: dsa: mt7530: enable MTU normalization

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 01:03:22 +0800 DENG Qingfang wrote: > MT7530 has a global RX length register, so we are actually changing its > MRU. > Enable MTU normalization for this reason. > > Signed-off-by: DENG Qingfang Applied, thanks and thanks for the reviews.

Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Vladimir Oltean
On Sun, Dec 13, 2020 at 01:34:10AM +0100, Andrew Lunn wrote: > On Sun, Dec 13, 2020 at 12:14:19AM +, Vladimir Oltean wrote: > > On Sun, Dec 13, 2020 at 01:08:55AM +0100, Andrew Lunn wrote: > > > > > And you need some way to cleanup the allocated memory when the commit > > > > > never happens be

Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Andrew Lunn
On Sun, Dec 13, 2020 at 12:14:19AM +, Vladimir Oltean wrote: > On Sun, Dec 13, 2020 at 01:08:55AM +0100, Andrew Lunn wrote: > > > > And you need some way to cleanup the allocated memory when the commit > > > > never happens because some other layer has said No! > > > > > > So this would be a fa

Re: [PATCH net v2] tun: fix ubuf refcount incorrectly on error path

2020-12-12 Thread Willem de Bruijn
> > > afterwards, the error handling in vhost handle_tx() will try to > > > decrease the same refcount again. This is wrong and fix this by delay > > > copying ubuf_info until we're sure there's no errors. > > > > I think the right approach is to address this in the error paths, rather > > than >

Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Vladimir Oltean
On Sun, Dec 13, 2020 at 01:08:55AM +0100, Andrew Lunn wrote: > > > And you need some way to cleanup the allocated memory when the commit > > > never happens because some other layer has said No! > > > > So this would be a fatal problem with the switchdev transactional model > > if I am not misunder

Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Andrew Lunn
On Sat, Dec 12, 2020 at 10:18:59PM +, Vladimir Oltean wrote: > On Sat, Dec 12, 2020 at 11:06:41PM +0100, Andrew Lunn wrote: > > > + /* Complication created by the fact that addition has two phases, but > > > + * deletion only has one phase, and we need reference counting. > > > + * The strate

Re: [PATCH] net: check skb partial checksum offset after trim

2020-12-12 Thread Willem de Bruijn
On Sat, Dec 12, 2020 at 5:01 AM Vasily Averin wrote: > > On 12/11/20 6:37 PM, Vasily Averin wrote: > > It seems for me the similar problem can happen in __skb_trim_rcsum(). > > Also I doubt that that skb_checksum_start_offset(skb) checks in > > __skb_postpull_rcsum() and skb_csum_unnecessary() are

[PATCH net-next] net: vxget: clean up sparse warnings

2020-12-12 Thread Jakub Kicinski
This code is copying strings in 64 bit quantities, the device returns them in big endian. As long as we store in big endian IOW endian on both sides matches, we're good, so swap to_be64, not from be64. This fixes ~60 sparse warnings. Signed-off-by: Jakub Kicinski --- .../net/ethernet/neterion/v

Re: [Patch bpf-next 0/3] bpf: introduce timeout map

2020-12-12 Thread Cong Wang
On Sat, Dec 12, 2020 at 2:25 PM Cong Wang wrote: > > On Fri, Dec 11, 2020 at 11:55 AM Andrii Nakryiko > wrote: > > > > On Fri, Dec 11, 2020 at 2:28 AM Cong Wang wrote: > > > > > > From: Cong Wang > > > > > > This patchset introduces a new bpf hash map which has timeout. > > > Patch 1 is a prepa

Re: [PATCH v4] net/ipv4/inet_fragment: Batch fqdir destroy works

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 15:36:53 +0100 Eric Dumazet wrote: > On Fri, Dec 11, 2020 at 12:24 PM SeongJae Park wrote: > > From: SeongJae Park > > > > On a few of our systems, I found frequent 'unshare(CLONE_NEWNET)' calls > > make the number of active slab objects including 'sock_inode_cache' type > > r

[PATCH net-next 00/10] Netfilter/IPVS updates for net-next

2020-12-12 Thread Pablo Neira Ayuso
Hi Jakub, David, The following patchset contains Netfilter updates for net-next: 1) Missing dependencies in NFT_BRIDGE_REJECT, from Randy Dunlap. 2) Use atomic_inc_return() instead of atomic_add_return() in IPVS, from Yejune Deng. 3) Simplify check for overquota in xt_nfacct, from Kaixu Xia.

[PATCH net-next 02/10] ipvs: replace atomic_add_return()

2020-12-12 Thread Pablo Neira Ayuso
From: Yejune Deng atomic_inc_return() looks better Signed-off-by: Yejune Deng Acked-by: Julian Anastasov Signed-off-by: Pablo Neira Ayuso --- net/netfilter/ipvs/ip_vs_core.c | 2 +- net/netfilter/ipvs/ip_vs_sync.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/n

[PATCH net-next 04/10] netfilter: nfnl_acct: remove data from struct net

2020-12-12 Thread Pablo Neira Ayuso
From: Wang Shanker This patch removes nfnl_acct_list from struct net to reduce the default memory footprint for the netns structure. Signed-off-by: Miao Wang Signed-off-by: Pablo Neira Ayuso --- include/net/net_namespace.h| 3 --- net/netfilter/nfnetlink_acct.c | 38 +

[PATCH net-next 01/10] netfilter: nft_reject_bridge: fix build errors due to code movement

2020-12-12 Thread Pablo Neira Ayuso
From: Randy Dunlap Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko by selecting NF_REJECT_IPV4, which provides the missing symbols. ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined! ERROR: modpost: "nf_reject_skb_v4_unreach" [net/

[PATCH net-next 05/10] netfilter: use actual socket sk for REJECT action

2020-12-12 Thread Pablo Neira Ayuso
From: Jan Engelhardt True to the message of commit v5.10-rc1-105-g46d6c5ae953c, _do_ actually make use of state->sk when possible, such as in the REJECT modules. Reported-by: Minqiang Chen Cc: Jason A. Donenfeld Signed-off-by: Jan Engelhardt Signed-off-by: Pablo Neira Ayuso --- include/net/

Re: [PATCH] net: bcmgenet: Fix a resource leak in an error handling path in the probe functin

2020-12-12 Thread Florian Fainelli
On 12/12/2020 10:20 AM, Christophe JAILLET wrote: > If the 'register_netdev()' call fails, we must undo a previous > 'bcmgenet_mii_init()' call. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")> Signed-off-by: > Christophe JAILLET Acked-by: Florian Fainelli > --- > The missi

[PATCH net-next 03/10] netfilter: Remove unnecessary conversion to bool

2020-12-12 Thread Pablo Neira Ayuso
From: Kaixu Xia Here we could use the '!=' expression to fix the following coccicheck warning: ./net/netfilter/xt_nfacct.c:30:41-46: WARNING: conversion to bool not needed here Reported-by: Tosk Robot Signed-off-by: Kaixu Xia Signed-off-by: Pablo Neira Ayuso --- net/netfilter/xt_nfacct.c |

[PATCH net-next 07/10] netfilter: nftables: generalize set expressions support

2020-12-12 Thread Pablo Neira Ayuso
Currently, the set infrastucture allows for one single expressions per element. This patch extends the existing infrastructure to allow for up to two expressions. This is not updating the netlink API yet, this is coming as an initial preparation patch. Signed-off-by: Pablo Neira Ayuso --- includ

[PATCH net-next 08/10] netfilter: nftables: move nft_expr before nft_set

2020-12-12 Thread Pablo Neira Ayuso
Move the nft_expr structure definition before nft_set. Expressions are used by rules and sets, remove unnecessary forward declarations. This comes as preparation to support for multiple expressions per set element. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 54 +

[PATCH net-next 09/10] netfilter: nftables: generalize set extension to support for several expressions

2020-12-12 Thread Pablo Neira Ayuso
This patch replaces NFT_SET_EXPR by NFT_SET_EXT_EXPRESSIONS. This new extension allows to attach several expressions to one set element (not only one single expression as NFT_SET_EXPR provides). This patch prepares for support for several expressions per set element in the netlink userspace API. S

[PATCH net-next 10/10] netfilter: nftables: netlink support for several set element expressions

2020-12-12 Thread Pablo Neira Ayuso
This patch adds three new netlink attributes to encapsulate a list of expressions per set elements: - NFTA_SET_EXPRESSIONS: this attribute provides the set definition in terms of expressions. New set elements get attached the list of expressions that is specified by this new netlink attribute.

Re: [PATCH] nfc: s3fwrn5: let core configure the interrupt trigger

2020-12-12 Thread Jakub Kicinski
On Thu, 10 Dec 2020 22:18:24 +0100 Krzysztof Kozlowski wrote: > If interrupt trigger is not set when requesting the interrupt, the core > will take care of reading trigger type from Devicetree. There is no > point to do it in the driver. > > Signed-off-by: Krzysztof Kozlowski Applied, thank you

[PATCH net-next 06/10] netfilter: ctnetlink: add timeout and protoinfo to destroy events

2020-12-12 Thread Pablo Neira Ayuso
From: Florian Westphal DESTROY events do not include the remaining timeout. Add the timeout if the entry was removed explicitly. This can happen when a conntrack gets deleted prematurely, e.g. due to a tcp reset, module removal, netdev notifier (nat/masquerade device went down), ctnetlink and so

Re: [PATCH net-next v4 3/3] net: add sysfs attribute to control napi threaded mode

2020-12-12 Thread Jakub Kicinski
On Tue, 8 Dec 2020 16:54:44 -0800 Wei Wang wrote: > +static void dev_disable_threaded_all(struct net_device *dev) > +{ > + struct napi_struct *napi; > + > + list_for_each_entry(napi, &dev->napi_list, dev_list) > + napi_set_threaded(napi, false); > +} This is an implementation

Re: [PATCH net-next v4 2/3] net: implement threaded-able napi poll loop support

2020-12-12 Thread Jakub Kicinski
On Sat, 12 Dec 2020 14:50:22 -0800 Jakub Kicinski wrote: > > @@ -6731,6 +6790,7 @@ void napi_disable(struct napi_struct *n) > > msleep(1); > > > > hrtimer_cancel(&n->timer); > > + napi_kthread_stop(n); > > I'm surprised that we stop the thread on napi_disable() but there is n

Re: [PATCH net-next v4 2/3] net: implement threaded-able napi poll loop support

2020-12-12 Thread Jakub Kicinski
On Tue, 8 Dec 2020 16:54:43 -0800 Wei Wang wrote: > This patch allows running each napi poll loop inside its own > kernel thread. > The threaded mode could be enabled through napi_set_threaded() > api, and does not require a device up/down. The kthread gets > created on demand when napi_set_thread

Re: [PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-12 Thread Jakub Kicinski
On Tue, 8 Dec 2020 17:19:10 +0800 Cambda Zhu wrote: > For each TCP zero window probe, the icsk_backoff is increased by one and > its max value is tcp_retries2. If tcp_retries2 is greater than 63, the > probe0 timeout shift may exceed its max bits. On x86_64/ARMv8/MIPS, the > shift count would be m

Re: [Patch bpf-next 0/3] bpf: introduce timeout map

2020-12-12 Thread Cong Wang
On Fri, Dec 11, 2020 at 11:55 AM Andrii Nakryiko wrote: > > On Fri, Dec 11, 2020 at 2:28 AM Cong Wang wrote: > > > > From: Cong Wang > > > > This patchset introduces a new bpf hash map which has timeout. > > Patch 1 is a preparation, patch 2 is the implementation of timeout > > map, patch 3 cont

Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Vladimir Oltean
On Sat, Dec 12, 2020 at 11:06:41PM +0100, Andrew Lunn wrote: > > + /* Complication created by the fact that addition has two phases, but > > +* deletion only has one phase, and we need reference counting. > > +* The strategy is to do the memory allocation in the prepare phase, > > +*

Re: [PATCH net-next v2] GTP: add support for flow based tunneling API

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 20:40:17 -0800 Pravin B Shelar wrote: > Following patch add support for flow based tunneling API > to send and recv GTP tunnel packet over tunnel metadata API. > This would allow this device integration with OVS or eBPF using > flow based tunneling APIs. > > Signed-off-by: Prav

Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Andrew Lunn
> + /* Complication created by the fact that addition has two phases, but > + * deletion only has one phase, and we need reference counting. > + * The strategy is to do the memory allocation in the prepare phase, > + * but initialize the refcount in the commit phase. > + * >

Re: [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 22:34:56 +0800 Kevin Lo wrote: > This patch sets the default return value to -IGC_ERR_NVM in > igc_write_nvm_srwr. > Without this change it wouldn't lead to a shadow RAM write EEWR timeout. > > Signed-off-by: Kevin Lo This is a fix, please add a Fixes tag. Please CC the mai

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-12 Thread Jakub Kicinski
On Sat, 12 Dec 2020 23:39:20 +0200 Yonatan Linik wrote: > On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote: > > > > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote: > > > proc_fs was used, in af_packet, without a surrounding #ifdef, > > > although there is no hard dependency on proc_f

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Jens Axboe
On 12/12/20 2:42 PM, Victor Stewart wrote: > On Sat, Dec 12, 2020 at 6:02 PM Jens Axboe wrote: >> >> On 12/12/20 10:58 AM, Victor Stewart wrote: >>> On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote: On 12/12/20 10:25 AM, Victor Stewart wrote: > On Sat, Dec 12, 2020 at 5:07 PM Jens A

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Victor Stewart
On Sat, Dec 12, 2020 at 6:02 PM Jens Axboe wrote: > > On 12/12/20 10:58 AM, Victor Stewart wrote: > > On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote: > >> > >> On 12/12/20 10:25 AM, Victor Stewart wrote: > >>> On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: > > On 12/12/20 8:31 AM,

Re: pull request (net-next): ipsec-next 2020-12-12

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 09:57:36 +0100 you wrote: > Just one patch this time: > > 1) Redact the SA keys with kernel lockdown confidentiality. >If enabled, no secret keys are sent to uuserspace. >From Antony Anto

Re: [PATCH] net: qlcnic: remove casting dma_alloc_coherent

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 08:59:20 + Xu Wang wrote: > Remove casting the values returned by dma_alloc_coherent. > > Signed-off-by: Xu Wang This patch does not apply to net-next, please rebase against: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ if you want it to be appli

Re: [PATCH] xfrm: redact SA secret with lockdown confidentiality

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 09:57:37 +0100 you wrote: > From: Antony Antony > > redact XFRM SA secret in the netlink response to xfrm_get_sa() > or dumpall sa. > Enable lockdown, confidentiality mode, at boot or at run time. > >

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-12 Thread Yonatan Linik
On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote: > > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote: > > proc_fs was used, in af_packet, without a surrounding #ifdef, > > although there is no hard dependency on proc_fs. > > That caused the initialization of the af_packet module to fai

Re: [PATCH v2 3/3] net: mhi: Add dedicated alloc thread

2020-12-12 Thread Jakub Kicinski
On Thu, 10 Dec 2020 12:15:51 +0100 Loic Poulain wrote: > The buffer allocation for RX path is currently done by a work executed > in the system workqueue. The work to do is quite simple and consists > mostly in allocating and queueing as much as possible buffers to the MHI > RX channel. > > It app

[PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Vladimir Oltean
Currently any DSA switch that is strict when implementing the mdb operations prints these benign errors after the addresses expire, with at least 2 ports bridged: [ 286.013814] mscc_felix :00:00.5 swp3: failed (err=-2) to del object (id=3) The reason has to do with this piece of code:

[net-next PATCH v3] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Alexander Duyck
From: Alexander Duyck There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG message in the case of IPv6 or a fragmentation request in the case of IPv4. This results in the socket stalling for a second or more as it does not respond to the message by retransmitting the SYN frame.

Re: pull-request: wireless-drivers-next-2020-12-12

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 05:08:39 + (UTC) you wrote: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > [...] Here is the summary with

Re: [net-next v3 00/14] Add mlx5 subfunction support

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 22:12:11 -0800 Saeed Mahameed wrote: > Hi Dave, Jakub, Jason, > > This series form Parav was the theme of this mlx5 release cycle, > we've been waiting anxiously for the auxbus infrastructure to make it into > the kernel, and now as the auxbus is in and all the stars are aligne

[net-next PATCH v2] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Alexander Duyck
From: Alexander Duyck There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG message in the case of IPv6 or a fragmentation request in the case of IPv4. This results in the socket stalling for a second or more as it does not respond to the message by retransmitting the SYN frame.

Incorrect --help / manpage for -color for ip, tc, bridge

2020-12-12 Thread Witold Baryluk
iproute 5.9.0 Apparently ip -c is a shortcut to ip -color but in tc, tc -c doesn't work, one needs to say tc -col or tc -color I understand there is tc -conf, which has tc -c. But: Help says: root@debian:~# tc Usage:tc [ OPTIONS ] OBJECT { COMMAND | help } tc [-force] -batch filename

Re: [net-next PATCH] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Alexander Duyck
On Sat, Dec 12, 2020 at 11:07 AM Yuchung Cheng wrote: > > On Sat, Dec 12, 2020 at 11:01 AM Alexander Duyck > wrote: > > > > On Sat, Dec 12, 2020 at 10:34 AM Yuchung Cheng wrote: > > > > > > On Fri, Dec 11, 2020 at 5:28 PM Alexander Duyck > > > wrote: > > > > > > > > From: Alexander Duyck > > >

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote: > proc_fs was used, in af_packet, without a surrounding #ifdef, > although there is no hard dependency on proc_fs. > That caused the initialization of the af_packet module to fail > when CONFIG_PROC_FS=n. > > Specifically, proc_create_net() w

Re: [RFC] ravb: Add support for optional txc_refclk

2020-12-12 Thread Adam Ford
On Sat, Dec 12, 2020 at 11:55 AM Sergei Shtylyov wrote: > > Hello! > > On 12.12.2020 19:56, Adam Ford wrote: > > > The SoC expects the txv_refclk is provided, but if it is provided > > by a programmable clock, there needs to be a way to get and enable > > this clock to operate. It needs to be opt

Re: [PATCH v10 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-12 Thread Andrew Lunn
On Fri, Dec 11, 2020 at 10:05:40AM +0100, Steen Hegelund wrote: > Add the Microchip Sparx5 ethernet serdes PHY driver for the 6G, 10G and 25G > interfaces available in the Sparx5 SoC. > > Signed-off-by: Bjarni Jonasson > Signed-off-by: Steen Hegelund Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v10 4/4] arm64: dts: sparx5: Add Sparx5 serdes driver node

2020-12-12 Thread Andrew Lunn
On Fri, Dec 11, 2020 at 10:05:41AM +0100, Steen Hegelund wrote: > Add Sparx5 serdes driver node, and enable it generally for all > reference boards. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund Reviewed-by: Andrew Lunn Andrew

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-12 Thread Ioana Ciornei
On Sat, Dec 12, 2020 at 04:58:56PM +0100, Jon Nettleton wrote: > On Fri, Dec 11, 2020 at 5:56 PM Ioana Ciornei wrote: > > > > On Fri, Dec 11, 2020 at 04:29:14PM +, Daniel Thompson wrote: > > > On Fri, Dec 11, 2020 at 02:01:28PM +, Ioana Ciornei wrote: > > > > On Thu, Dec 10, 2020 at 08:06:

Re: [PATCH v10 2/4] phy: Add ethernet serdes configuration option

2020-12-12 Thread Andrew Lunn
On Fri, Dec 11, 2020 at 10:05:39AM +0100, Steen Hegelund wrote: > Provide a new ethernet phy configuration structure, that > allow PHYs used for ethernet to be configured with > speed, media type and clock information. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund Reviewed-by:

Re: pull-request: mac80211-next 2020-12-11

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 15:25:51 +0100 you wrote: > Hi Dave, > > Welcome back! > > I'm a bit late with this, I guess, but I hope you can still > pull it into net-next for 5.11. Nothing really stands out, > we have some

Re: [PATCH v10 1/4] dt-bindings: phy: Add sparx5-serdes bindings

2020-12-12 Thread Andrew Lunn
On Fri, Dec 11, 2020 at 10:05:38AM +0100, Steen Hegelund wrote: > Document the Sparx5 ethernet serdes phy driver bindings. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > Reviewed-by: Rob Herring Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Andrew Lunn
> +/* DSA can directly translate this to a normal MDB add, but on the CPU port. > + * But because multiple user ports can join the same multicast group and the > + * bridge will emit a notification for each port, we need to add/delete the > + * entry towards the host only once, so we reference coun

[PATCH v4 net-next] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-12 Thread Vladimir Oltean
Currently ocelot_set_rx_mode calls ocelot_mact_learn directly, which has a very nice ocelot_mact_wait_for_completion at the end. Introduced in commit 639c1b2625af ("net: mscc: ocelot: Register poll timeout should be wall time not attempts"), this function uses readx_poll_timeout which triggers a lo

[PATCH v2 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Vladimir Oltean
Currently any DSA switch that is strict when implementing the mdb operations prints these benign errors after the addresses expire, with at least 2 ports bridged: [ 286.013814] mscc_felix :00:00.5 swp3: failed (err=-2) to del object (id=3) The reason has to do with this piece of code:

Re: [net-next PATCH] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Alexander Duyck
On Sat, Dec 12, 2020 at 10:34 AM Yuchung Cheng wrote: > > On Fri, Dec 11, 2020 at 5:28 PM Alexander Duyck > wrote: > > > > From: Alexander Duyck > > > > There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG > > message in the case of IPv6 or a fragmentation request in the case of

[PATCH] net: bcmgenet: Fix a resource leak in an error handling path in the probe functin

2020-12-12 Thread Christophe JAILLET
If the 'register_netdev()' call fails, we must undo a previous 'bcmgenet_mii_init()' call. Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Christophe JAILLET --- The missing 'bcmgenet_mii_exit()' call is added here, instead of in the error handling path in order to avoi

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Jens Axboe
On 12/12/20 10:58 AM, Victor Stewart wrote: > On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote: >> >> On 12/12/20 10:25 AM, Victor Stewart wrote: >>> On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: On 12/12/20 8:31 AM, Victor Stewart wrote: > RE our conversation on the "[RFC 0/1]

Re: [PATCH v5 2/2] net: dsa: qca: ar9331: export stats64

2020-12-12 Thread Jakub Kicinski
On Sat, 12 Dec 2020 15:48:52 +0200 Vladimir Oltean wrote: > > + stats->rx_packets = u64_stats_read(&s->rx64byte) + > > + u64_stats_read(&s->rx128byte) + u64_stats_read(&s->rx256byte) + > > + u64_stats_read(&s->rx512byte) + u64_stats_read(&s->rx1024byte) + > > + u64_s

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Victor Stewart
On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote: > > On 12/12/20 10:25 AM, Victor Stewart wrote: > > On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: > >> > >> On 12/12/20 8:31 AM, Victor Stewart wrote: > >>> RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO > >>> cmsgs" thread

Re: [RFC] ravb: Add support for optional txc_refclk

2020-12-12 Thread Sergei Shtylyov
Hello! On 12.12.2020 19:56, Adam Ford wrote: The SoC expects the txv_refclk is provided, but if it is provided by a programmable clock, there needs to be a way to get and enable this clock to operate. It needs to be optional since it's only necessary for those with programmable clocks. Signed

[PATCH v3 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-12 Thread Lorenzo Bianconi
Introduce xdp_prepare_buff utility routine to initialize per-descriptor xdp_buff fields (e.g. xdp_buff pointers). Rely on xdp_prepare_buff() in all XDP capable drivers. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++--- drivers/net/ethernet/broadcom

[PATCH v3 bpf-next 1/2] net: xdp: introduce xdp_init_buff utility routine

2020-12-12 Thread Lorenzo Bianconi
Introduce xdp_init_buff utility routine to initialize xdp_buff fields const over NAPI iterations (e.g. frame_sz or rxq pointer). Rely on xdp_init_buff in all XDP capable drivers. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c| 3 +-- drivers/net/ethernet

[PATCH v3 bpf-next 0/2] introduce xdp_init_buff/xdp_prepare_buff

2020-12-12 Thread Lorenzo Bianconi
Introduce xdp_init_buff and xdp_prepare_buff utility routines to initialize xdp_buff data structure and remove duplicated code in all XDP capable drivers. Changes since v2: - precompute xdp->data as hard_start + headroom and save it in a local variable to reuse it for xdp->data_end and xdp->data

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Jens Axboe
On 12/12/20 10:25 AM, Victor Stewart wrote: > On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: >> >> On 12/12/20 8:31 AM, Victor Stewart wrote: >>> RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO >>> cmsgs" thread... >>> >>> https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7n

Re: [PATCH v5 2/2] net: dsa: qca: ar9331: export stats64

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 11:53:22 +0100 Oleksij Rempel wrote: > Add stats support for the ar9331 switch. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/dsa/qca/ar9331.c | 256 ++- > 1 file changed, 255 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/d

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Victor Stewart
On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: > > On 12/12/20 8:31 AM, Victor Stewart wrote: > > RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO > > cmsgs" thread... > > > > https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7nZYoziPTD-Wp03+fcsUwh3CuSc=81...@mail.gmail.com/

Re: [PATCH net-next 13/15] mlxsw: spectrum_router_xm: Introduce basic XM cache flushing

2020-12-12 Thread Ido Schimmel
On Fri, Dec 11, 2020 at 08:24:27PM -0800, Jakub Kicinski wrote: > On Fri, 11 Dec 2020 19:04:11 +0200 Ido Schimmel wrote: > > From: Jiri Pirko > > > > Upon route insertion and removal, it is needed to flush possibly cached > > entries from the XM cache. Extend XM op context to carry information >

Re: [PATCH v5 1/2] net: dsa: add optional stats64 support

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 11:53:21 +0100 Oleksij Rempel wrote: > +static void dsa_slave_get_stats64(struct net_device *dev, > + struct rtnl_link_stats64 *s) > +{ > + struct dsa_port *dp = dsa_slave_to_port(dev); > + struct dsa_switch *ds = dp->ds; > + > + if (!ds

Re: [PATCH net-next v3 0/4] vsock: Add flags field in the vsock address

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 16:24:13 +0100 Stefano Garzarella wrote: > On Fri, Dec 11, 2020 at 12:32:37PM +0200, Andra Paraschiv wrote: > >vsock enables communication between virtual machines and the host they are > >running on. Nested VMs can be setup to use vsock channels, as the multi > >transport suppo

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Jens Axboe
On 12/12/20 8:31 AM, Victor Stewart wrote: > RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO > cmsgs" thread... > > https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7nZYoziPTD-Wp03+fcsUwh3CuSc=81...@mail.gmail.com/ > > here are the patches we discussed. > > Victor Stewart (3

Re: [PATCH] net/mlx4: Use true,false for bool variable

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 11:05:18 +0100 Vasyl Gomonovych wrote: > Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable > Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable Apart from addressing Joe's comment please name the tool which produced those.

[RFC] ravb: Add support for optional txc_refclk

2020-12-12 Thread Adam Ford
The SoC expects the txv_refclk is provided, but if it is provided by a programmable clock, there needs to be a way to get and enable this clock to operate. It needs to be optional since it's only necessary for those with programmable clocks. Signed-off-by: Adam Ford diff --git a/drivers/net/eth

[PATCH AUTOSEL 5.9 14/23] vxlan: Copy needed_tailroom from lowerdev

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit a5e74021e84bb5eadf760aaf2c583304f02269be ] While vxlan doesn't need any extra tailroom, the lowerdev might need it. In that case, copy it over to reduce the chance for additional (re)allocations in the transmit path. Signed-off-by: Sven Eckelmann Link: ht

[PATCH AUTOSEL 5.9 13/23] vxlan: Add needed_headroom for lower device

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit 0a35dc41fea67ac4495ce7584406bf9557a6e7d0 ] It was observed that sending data via batadv over vxlan (on top of wireguard) reduced the performance massively compared to raw ethernet or batadv on raw ethernet. A check of perf data showed that the vxlan_build_s

[PATCH AUTOSEL 5.9 19/23] iwlwifi: pcie: add some missing entries for AX210

2020-12-12 Thread Sasha Levin
From: Golan Ben Ami [ Upstream commit 9b15596c5006d82b2f82810e8cbf80d8c6e7e7b4 ] Some subsytem device IDs were missing from the list, so some AX210 devices were not recognized. Add them. Signed-off-by: Golan Ben Ami Signed-off-by: Luca Coelho Signed-off-by: Kalle Valo Link: https://lore.ke

[PATCH AUTOSEL 5.4 06/14] vxlan: Add needed_headroom for lower device

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit 0a35dc41fea67ac4495ce7584406bf9557a6e7d0 ] It was observed that sending data via batadv over vxlan (on top of wireguard) reduced the performance massively compared to raw ethernet or batadv on raw ethernet. A check of perf data showed that the vxlan_build_s

[PATCH AUTOSEL 5.4 11/14] iwlwifi: pcie: add one missing entry for AX210

2020-12-12 Thread Sasha Levin
From: Luca Coelho [ Upstream commit 5febcdef30902fa870128b9789b873199f13aff1 ] The 0x0024 subsytem device ID was missing from the list, so some AX210 devices were not recognized. Add it. Signed-off-by: Luca Coelho Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/iwlwifi.20201202143

[PATCH AUTOSEL 5.4 07/14] vxlan: Copy needed_tailroom from lowerdev

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit a5e74021e84bb5eadf760aaf2c583304f02269be ] While vxlan doesn't need any extra tailroom, the lowerdev might need it. In that case, copy it over to reduce the chance for additional (re)allocations in the transmit path. Signed-off-by: Sven Eckelmann Link: ht

  1   2   >