Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications

2020-12-09 Thread Rasmus Villemoes
On 05/12/2020 22.27, Jakub Kicinski wrote: > On Sat, 5 Dec 2020 22:11:39 +0100 Rasmus Villemoes wrote: >>> Looks like a nice clean up on a quick look. >>> >>> Please separate patches 1 and 11 (which are the two bug fixes I see) >> >> I think patch 2 is a bug fix as well, but I'd like someone from

Re: [PATCH net v2] lan743x: fix rx_napi_poll/interrupt ping-pong

2020-12-09 Thread Heiner Kallweit
Am 10.12.2020 um 04:55 schrieb Sven Van Asbroeck: > From: Sven Van Asbroeck > > Even if there is more rx data waiting on the chip, the rx napi poll fn > will never run more than once - it will always read a few buffers, then > bail out and re-arm interrupts. Which results in ping-pong between nap

Re: [PATCH 1/1] net/ipv4/inet_fragment: Batch fqdir destroy works

2020-12-09 Thread SeongJae Park
On Thu, 10 Dec 2020 01:17:58 +0100 Eric Dumazet wrote: > > > On 12/8/20 10:45 AM, SeongJae Park wrote: > > From: SeongJae Park > > > > In 'fqdir_exit()', a work for destruction of the 'fqdir' is enqueued. > > The work function, 'fqdir_work_fn()', calls 'rcu_barrier()'. In case of > > intensi

[PATCH v16 0/4] userspace MHI client interface driver

2020-12-09 Thread Hemant Kumar
This patch series adds support for UCI driver. UCI driver enables userspace clients to communicate to external MHI devices like modem. UCI driver probe creates standard character device file nodes for userspace clients to perform open, read, write, poll and release file operations. These file opera

[PATCH v16 3/4] docs: Add documentation for userspace client interface

2020-12-09 Thread Hemant Kumar
MHI userspace client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently QMI MHI channel is supported by this driver. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo --- Documentation/mhi/index.rst

[PATCH v16 1/4] bus: mhi: core: Add helper API to return number of free TREs

2020-12-09 Thread Hemant Kumar
Introduce mhi_get_free_desc_count() API to return number of TREs available to queue buffer. MHI clients can use this API to know before hand if ring is full without calling queue API. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi/c

[PATCH v16 4/4] bus: mhi: Add userspace client interface driver

2020-12-09 Thread Hemant Kumar
This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI device object instantiates UCI channel object when device file node is opened. UCI chan

[PATCH v16 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file

2020-12-09 Thread Hemant Kumar
Currently this macro is defined in internal MHI header as a TRE length mask. Moving it to external header allows MHI client drivers to set this upper bound for the transmit buffer size. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi

Re: [PATCH] mt76: Fixed kernel test robot warning

2020-12-09 Thread Kalle Valo
Souptick Joarder writes: > Kernel test robot throws below warning -> > >drivers/net/wireless/mediatek/mt76/tx.c: In function > 'mt76_txq_schedule': >>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' >>> set but not used [-Wunused-but-set-variable] > 499 | struct m

Re: Urgent: BUG: PPP ioctl Transport endpoint is not connected

2020-12-09 Thread Martin Zaharinov
And one other From other mailing I see you send patch to Denys Fedoryshchenko this patch is : diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index 255a5def56e9..2acf4b0eabd1 100644 --- a/drivers/net/ppp/ppp_generic.c +++ b/drivers/net/ppp/ppp_generic.c @@ -3161,6 +3

Re: Urgent: BUG: PPP ioctl Transport endpoint is not connected

2020-12-09 Thread Martin Zaharinov
> On 9 Dec 2020, at 20:10, Guillaume Nault wrote: > > On Wed, Dec 09, 2020 at 06:57:44PM +0200, Martin Zaharinov wrote: >>> On 9 Dec 2020, at 18:40, Guillaume Nault wrote: >>> On Wed, Dec 09, 2020 at 04:47:52PM +0200, Martin Zaharinov wrote: Hi All I have problem with latest k

[PATCH v3 1/1] xdp: avoid calling kfree twice

2020-12-09 Thread Zhu Yanjun
In the function xdp_umem_pin_pages, if npgs != umem->npgs and npgs >= 0, the function xdp_umem_unpin_pages is called. In this function, kfree is called to handle umem->pgs, and then in the function xdp_umem_pin_pages, kfree is called again to handle umem->pgs. Eventually, to umem->pgs, kfree is cal

Re: memory leak in bpf

2020-12-09 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:a68a0262 mm/madvise: remove racy mm ownership check git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11facf1750 kernel config: https://syzkaller.appspot.com/x/.config?x=4305fa9ea70c7a9f

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-09 Thread Saeed Mahameed
On Wed, 2020-12-09 at 20:34 -0700, David Ahern wrote: > On 12/9/20 10:15 AM, Saeed Mahameed wrote: > > > My personal experience with this one is mlx5/ConnectX4-LX with a > > > limit > > > > This limit was removed from mlx5 > > https://patchwork.ozlabs.org/project/netdev/patch/20200107191335.12272-

Re: [PATCH 1/1] net/ipv4/inet_fragment: Batch fqdir destroy works

2020-12-09 Thread SeongJae Park
On Wed, 9 Dec 2020 15:16:59 -0800 Jakub Kicinski wrote: > On Tue, 8 Dec 2020 10:45:29 +0100 SeongJae Park wrote: > > From: SeongJae Park > > > > In 'fqdir_exit()', a work for destruction of the 'fqdir' is enqueued. > > The work function, 'fqdir_work_fn()', calls 'rcu_barrier()'. In case of > >

Re: [PATCH net-next] net: lapbether: Consider it successful if (dis)connecting when already (dis)connected

2020-12-09 Thread Martin Schiller
On 2020-12-08 23:50, Xie He wrote: When the upper layer instruct us to connect (or disconnect), but we have already connected (or disconnected), consider this operation successful rather than failed. This can help the upper layer to correct its record about whether we are connected or not her

Re: [PATCH net-next] net: x25: Fix handling of Restart Request and Restart Confirmation

2020-12-09 Thread Martin Schiller
On 2020-12-09 21:16, Xie He wrote: On Wed, Dec 9, 2020 at 2:31 AM Martin Schiller wrote: >> 1. When the x25 module gets loaded, layer 2 may already be running and >> connected. In this case, although we are in X25_LINK_STATE_0, we still >> need to handle the Restart Request received, rather th

Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling

2020-12-09 Thread Martin Schiller
On 2020-12-09 23:11, Xie He wrote: On Wed, Dec 9, 2020 at 1:47 AM Xie He wrote: On Wed, Dec 9, 2020 at 1:41 AM Martin Schiller wrote: > > Right. > By the way: A "Restart Collision" is in practice a very common event to > establish the Layer 3. Oh, I see. Thanks! Hi Martin, When you submit

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-09 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Wed, 9 Dec 2020 17:53:19 -0800 > On Thu, Dec 10, 2020 at 01:57:19AM +0900, Kuniyuki Iwashima wrOAote: > [ ... ] > > > > > > I think it is a bit complex to pass the new listener from > > > > > reuseport_detach_sock() to inet_csk_listen_stop(). > > > > > > > > > >

[PATCH net-next] net: qualcomm: rmnet: Update rmnet device MTU based on real device

2020-12-09 Thread Subash Abhinov Kasiviswanathan
Packets sent by rmnet to the real device have variable MAP header lengths based on the data format configured. This patch adds checks to ensure that the real device MTU is sufficient to transmit the MAP packet comprising of the MAP header and the IP packet. This check is enforced when rmnet devices

Re: [PATCH net-next 3/7] net: hns3: add support for forwarding packet to queues of specified TC when flow director rule hit

2020-12-09 Thread Saeed Mahameed
On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: > From: Jian Shen > > For some new device, it supports forwarding packet to queues > of specified TC when flow director rule hit. So extend the > command handle to support it. > ... > static int hclge_config_action(struct hclge_dev *hdev,

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-09 Thread Neftin, Sasha
On 12/10/2020 04:24, Alexander Duyck wrote: On Wed, Dec 9, 2020 at 6:44 AM Hans de Goede wrote: Hi, On 12/8/20 5:14 PM, Alexander Duyck wrote: On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote: Hi, On 12/8/20 6:08 AM, Neftin, Sasha wrote: On 12/7/2020 17:41, Limonciello, Mario wrote:

Re: [PATCH v1 bpf-next 05/11] tcp: Migrate TCP_NEW_SYN_RECV requests.

2020-12-09 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Wed, 9 Dec 2020 16:07:07 -0800 > On Tue, Dec 01, 2020 at 11:44:12PM +0900, Kuniyuki Iwashima wrote: > > This patch renames reuseport_select_sock() to __reuseport_select_sock() and > > adds two wrapper function of it to pass the migration type defined in the > > pre

Re: [PATCH net-next 2/7] net: hns3: add support for tc mqprio offload

2020-12-09 Thread Saeed Mahameed
On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: > From: Jian Shen > > Currently, the HNS3 driver only supports offload for tc number > and prio_tc. This patch adds support for other qopts, including > queues count and offset for each tc. > > When enable tc mqprio offload, it's not allowed

Re: [PATCH v3] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-09 Thread David Miller
From: Mickey Rachamim Date: Wed, 9 Dec 2020 15:47:39 +0200 > Add maintainers info for new Marvell Prestera Ethernet switch driver. > > Signed-off-by: Mickey Rachamim > --- > 1. Update +W to link to the project source github page. > 2. Remove +L as inherited from the entry of networking drivers.

Re: [PATCH net-next 0/7] net: hns3: updates for -next

2020-12-09 Thread David Miller
From: Huazhong Tan Date: Thu, 10 Dec 2020 11:42:05 +0800 > This patchset adds support for tc mqprio offload, hw tc > offload of tc flower, and adpation for max rss size changes. ZSeries applied, thanks.

Re: [PATCH v2 1/1] xdp: avoid calling kfree twice

2020-12-09 Thread Zhu Yanjun
On Wed, Dec 9, 2020 at 6:44 PM Toke Høiland-Jørgensen wrote: > > Zhu Yanjun writes: > > > On Wed, Dec 9, 2020 at 1:12 AM Daniel Borkmann wrote: > >> > >> On 12/9/20 6:03 AM, Zhu Yanjun wrote: > >> > In the function xdp_umem_pin_pages, if npgs != umem->npgs and > >> > npgs >= 0, the function xdp_

Re: [PATCH] net: bonding: retrieve device statistics under RTNL, not RCU

2020-12-09 Thread kernel test robot
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc7 next-20201209] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-09 Thread David Ahern
On 12/9/20 1:15 AM, Boris Pismenny wrote: > On 09/12/2020 2:38, David Ahern wrote: >> >> The AF_XDP reference was to differentiate one zerocopy use case (all >> packets go to userspace) from another (kernel managed TCP socket with >> zerocopy payload). You are focusing on a very narrow use case - k

[PATCH net v2] lan743x: fix rx_napi_poll/interrupt ping-pong

2020-12-09 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Even if there is more rx data waiting on the chip, the rx napi poll fn will never run more than once - it will always read a few buffers, then bail out and re-arm interrupts. Which results in ping-pong between napi and interrupt. This defeats the purpose of napi, and is b

Re: [PATCH net-next v3 3/3] dt-bindings: net: dsa: add bindings for xrs700x switches

2020-12-09 Thread Rob Herring
On Mon, Dec 07, 2020 at 04:03:55PM -0600, George McCollister wrote: > Add documentation and an example for Arrow SpeedChips XRS7000 Series > single chip Ethernet switches. > > Signed-off-by: George McCollister > Reviewed-by: Florian Fainelli > --- > .../devicetree/bindings/net/dsa/arrow,xrs700x

[PATCH net-next 1/7] net: hns3: refine the struct hane3_tc_info

2020-12-09 Thread Huazhong Tan
From: Jian Shen Currently, there are multiple members related to tc information in struct hnae3_knic_private_info. Merge them into a new struct hnae3_tc_info. Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 17 drivers/net

[PATCH net-next 0/7] net: hns3: updates for -next

2020-12-09 Thread Huazhong Tan
This patchset adds support for tc mqprio offload, hw tc offload of tc flower, and adpation for max rss size changes. Guojia Liao (3): net: hns3: add support for max 512 rss size net: hns3: adjust rss indirection table configure command net: hns3: adjust rss tc mode configure command Jian Sh

[PATCH net-next 3/7] net: hns3: add support for forwarding packet to queues of specified TC when flow director rule hit

2020-12-09 Thread Huazhong Tan
From: Jian Shen For some new device, it supports forwarding packet to queues of specified TC when flow director rule hit. So extend the command handle to support it. Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 2 ++ .../net/e

[PATCH net-next 4/7] net: hns3: add support for hw tc offload of tc flower

2020-12-09 Thread Huazhong Tan
From: Jian Shen Some new device supports forwarding packet to queues of specified TC when flow director rule hit. So add support to configure flow director rule by tc flower. To avoid rule conflict, add a new flow director mode HCLGE_FD_TC_FLOWER_ACTIVE, and only one mode can be active at the sam

[PATCH net-next 2/7] net: hns3: add support for tc mqprio offload

2020-12-09 Thread Huazhong Tan
From: Jian Shen Currently, the HNS3 driver only supports offload for tc number and prio_tc. This patch adds support for other qopts, including queues count and offset for each tc. When enable tc mqprio offload, it's not allowed to change queue numbers by ethtool. For hardware limitation, the que

[PATCH net-next 6/7] net: hns3: adjust rss indirection table configure command

2020-12-09 Thread Huazhong Tan
From: Guojia Liao For the max rss size of PF may be up to 512, so adjust the command of configuring rss indirection table to support queue id larger than 255. The width of queue id is extended from 8 bits to 10 bits. The high 2 bits are stored in filed rss_qid_h when the queue id is larger than 2

[PATCH net-next 5/7] net: hns3: add support for max 512 rss size

2020-12-09 Thread Huazhong Tan
From: Guojia Liao Currently, the driver gets the max rss size from configuration file when initialization. Both the PF and VF share the same max rss size, and no more than 128. For DEVICE_VERSION_V3, the max rss size for PF can be up to 512, so there is a new field in configuration file to store

[PATCH net-next 7/7] net: hns3: adjust rss tc mode configure command

2020-12-09 Thread Huazhong Tan
From: Guojia Liao For the max rss size of PF may be up to 512, the max queue number of single tc may be up to 512 too. For the total queue numbers may be up to 1280, so the queue offset of each tc may be more than 1024. So adjust the rss tc mode configuration command, including extend tc size fie

Re: [PATCH net-next] nfp: silence set but not used warning with IPV6=n

2020-12-09 Thread David Miller
From: Jakub Kicinski Date: Wed, 9 Dec 2020 08:18:21 -0800 > Test robot reports: > > drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function > 'nfp_net_tls_rx_resync_req': > drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable > 'ipv6h' set but not used [-Wunused-but-

Re: [PATCH v2 net-next 1/1] net: stmmac: allow stmmac to probe for C45 PHY devices

2020-12-09 Thread David Miller
From: Wong Vee Khee Date: Thu, 10 Dec 2020 06:47:00 +0800 > Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45. > This extended the probing of C45 PHY devices on the MDIO bus. > > Signed-off-by: Wong Vee Khee > --- > v2 changelog: > - Added conditional check for gmac4. Applied, tha

Re: [PATCH v2 2/2] dt-bindings: net: dsa: lantiq, lantiq-gswip: add example for xRX330

2020-12-09 Thread Rob Herring
On Sun, Dec 06, 2020 at 02:27:13PM +0100, Aleksander Jan Bajkowski wrote: > Add compatible string and example for xRX300 and xRX330. > > Signed-off-by: Aleksander Jan Bajkowski > --- > .../bindings/net/dsa/lantiq-gswip.txt | 110 +- > 1 file changed, 109 insertions(+), 1

Re: [PATCH v1 net-next 04/15] net/tls: expose get_netdev_for_sock

2020-12-09 Thread David Ahern
On 12/9/20 12:41 AM, Boris Pismenny wrote: > > You are correct, and bond support is currently under review for TLS, > i.e., search for "TLS TX HW offload for Bond". The same approach that ok, missed that. > is applied there is relevant here. More generally, this offload is > very similar in conc

Re: [PATCH RESEND net-next 0/2] Add support for VSOL V2801F/CarlitoxxPro CPGOS03 GPON module

2020-12-09 Thread David Miller
From: Russell King - ARM Linux admin Date: Wed, 9 Dec 2020 11:21:52 + > Hi, > > This patch set adds support for the V2801F / CarlitoxxPro module. This > requires two changes: > > 1) the module only supports single byte reads to the ID EEPROM, >while we need to still permit sequential re

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-09 Thread David Ahern
On 12/9/20 10:15 AM, Saeed Mahameed wrote: >> My personal experience with this one is mlx5/ConnectX4-LX with a >> limit > > This limit was removed from mlx5 > https://patchwork.ozlabs.org/project/netdev/patch/20200107191335.12272-5-sae...@mellanox.com/ > Note: you still need to use ehttool to incr

Re: [PATCH net-next] net: x25: Fix handling of Restart Request and Restart Confirmation

2020-12-09 Thread David Miller
From: Xie He Date: Wed, 9 Dec 2020 00:16:04 -0800 > 1. When the x25 module gets loaded, layer 2 may already be running and > connected. In this case, although we are in X25_LINK_STATE_0, we still > need to handle the Restart Request received, rather than ignore it. > > 2. When we are in X25_LIN

Re: [PATCH net-next 0/3] mptcp: a bunch of fixes

2020-12-09 Thread David Miller
From: Paolo Abeni Date: Wed, 9 Dec 2020 12:03:28 +0100 > This series includes a few fixes following-up the > recent code refactor for the MPTCP RX and TX paths. > > Boundling them together, since the fixes are somewhat > related. Series applied, thanks.

Re: [PATCH net-next v2] net: hdlc_x25: Remove unnecessary skb_reset_network_header calls

2020-12-09 Thread David Miller
From: Xie He Date: Tue, 8 Dec 2020 17:40:13 -0800 > 1. In x25_xmit, skb_reset_network_header is not necessary before we call > lapb_data_request. The lapb module doesn't need skb->network_header. > So there is no need to set skb->network_header before calling > lapb_data_request. > > 2. In x25_

Re: [PATCH v2 net-next] net/mlx4: simplify the return expression of mlx4_init_cq_table()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 09:20:02 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread kernel test robot
:b65054597872ce3aefbc6a666385eabdf9e288da config: mips-randconfig-r026-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin

Re: [PATCH net-next] ibmvnic: fix rx buffer tracking and index management in replenish_rx_pool partial success

2020-12-09 Thread David Miller
From: Dany Madden Date: Wed, 9 Dec 2020 20:53:31 -0500 > From: "Dwip N. Banerjee" > > We observed that in the error case for batched send_subcrq_indirect() the > driver does not account for the partial success case. This caused Linux to > crash when free_map and pool index are inconsistent. >

Re: [PATCH net-next 00/11] mptcp: Add port parameter to ADD_ADDR option

2020-12-09 Thread David Miller
From: Mat Martineau Date: Wed, 9 Dec 2020 15:51:17 -0800 > The ADD_ADDR MPTCP option is used to announce available IP addresses > that a peer may connect to when adding more TCP subflows to an existing > MPTCP connection. There is an optional port number field in that > ADD_ADDR header, and this

Re: [PATCH net 0/4] Netfilter fixes for net

2020-12-09 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 9 Dec 2020 23:18:06 +0100 > Hi Jakub, David, > > The following patchset contains Netfilter fixes for net: > > 1) Switch to RCU in x_tables to fix possible NULL pointer dereference, >from Subash Abhinov Kasiviswanathan. > > 2) Fix netlink dump of dynset t

Re: [net-next v4 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2020-12-09

2020-12-09 Thread David Miller
From: Tony Nguyen Date: Wed, 9 Dec 2020 13:13:03 -0800 > This series contains updates to ice driver only. > > Bruce changes the allocation of ice_flow_prof_params from stack to heap to > avoid excessive stack usage. Corrects a misleading comment and silences a > sparse warning that is not a pro

Re: [net 0/9][pull request] Intel Wired LAN Driver Updates 2020-12-09

2020-12-09 Thread David Miller
From: Tony Nguyen Date: Wed, 9 Dec 2020 17:02:43 -0800 > git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 1GbE Pulled, thanks Tony.

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-09 Thread Alexander Duyck
On Wed, Dec 9, 2020 at 6:44 AM Hans de Goede wrote: > > Hi, > > On 12/8/20 5:14 PM, Alexander Duyck wrote: > > On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 12/8/20 6:08 AM, Neftin, Sasha wrote: > >>> On 12/7/2020 17:41, Limonciello, Mario wrote: > > First of

Re: [PATCH v3 3/8] net: macb: add function to disable all macb clocks

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 03:03:34PM +0200, Claudiu Beznea wrote: > Add function to disable all macb clocks. > > Signed-off-by: Claudiu Beznea > Suggested-by: Andrew Lunn Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v3 4/8] net: macb: unprepare clocks in case of failure

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 03:03:35PM +0200, Claudiu Beznea wrote: > Unprepare clocks in case of any failure in fu540_c000_clk_init(). > > Fixes: c218ad559020 ("macb: Add support for SiFive FU540-C000") > Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn Andrew

[PATCH net-next] rtnetlink: RCU-annotate both dimensions of rtnl_msg_handlers

2020-12-09 Thread Jakub Kicinski
We use rcu_assign_pointer to assign both the table and the entries, but the entries are not marked as __rcu. This generates sparse warnings. Signed-off-by: Jakub Kicinski --- net/core/rtnetlink.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/net/c

Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-09 Thread Andrew Lunn
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 01b53f86004c..f6a094c81e86 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -66,9 +66,11 @@ source "drivers/phy/broadcom/Kconfig" > source "drivers/phy/cadence/Kconfig" > source "drivers/phy/freescale/Kconfig" >

linux-next: manual merge of the net-next tree with the netfilter tree

2020-12-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/netfilter/nf_tables_api.c between commit: 42f1c2712090 ("netfilter: nftables: comment indirect serialization of commit_mutex with rtnl_mutex") from the netfilter tree and commit: 872f69034194 ("treewide: renam

[PATCH net-next] ibmvnic: fix rx buffer tracking and index management in replenish_rx_pool partial success

2020-12-09 Thread Dany Madden
From: "Dwip N. Banerjee" We observed that in the error case for batched send_subcrq_indirect() the driver does not account for the partial success case. This caused Linux to crash when free_map and pool index are inconsistent. Driver needs to update the rx pools "available" count when some batch

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-09 Thread Martin KaFai Lau
On Thu, Dec 10, 2020 at 01:57:19AM +0900, Kuniyuki Iwashima wrote: [ ... ] > > > > I think it is a bit complex to pass the new listener from > > > > reuseport_detach_sock() to inet_csk_listen_stop(). > > > > > > > > __tcp_close/tcp_disconnect/tcp_abort > > > > |-tcp_set_state > > > > | |-unhas

Re: [PATCH 07/20] ethernet: ucc_geth: use qe_muram_free_addr()

2020-12-09 Thread Andrew Lunn
On Sat, Dec 05, 2020 at 08:17:30PM +0100, Rasmus Villemoes wrote: > This removes the explicit NULL checks, and allows us to stop storing > at least some of the _offset values separately. > > Signed-off-by: Rasmus Villemoes This seems to rely on one of the missing patches. Please don't split patc

Re: [PATCH 01/20] ethernet: ucc_geth: set dev->max_mtu to 1518

2020-12-09 Thread Andrew Lunn
On Sat, Dec 05, 2020 at 08:17:24PM +0100, Rasmus Villemoes wrote: > All the buffers and registers are already set up appropriately for an > MTU slightly above 1500, so we just need to expose this to the > networking stack. AFAICT, there's no need to implement .ndo_change_mtu > when the receive buff

Re: [PATCH net-next] net: emulex: benet: simplify the return expression of be_if_create()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:19:57 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: marvell: octeontx2: simplify the otx2_ptp_adjfine()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:27:26 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: marvell: octeontx2: simplify the otx2_ptp_adjfine()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:27:26 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: stmmac: simplify the return dwmac5_rxp_disable()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:23:25 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: sja1105: simplify the return sja1105_cls_flower_stats()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:25:04 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: hinic: simplify the return hinic_configure_max_qnum()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:22:41 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: dsa: simplify the return rtl8366_vlan_prepare()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:26:21 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: marvell: octeontx2: simplify the return expression of rvu_npa_init()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:18:44 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: freescale: dpaa: simplify the return dpaa_eth_refill_bpools()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:21:07 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: cisco: enic: simplify the return vnic_cq_alloc()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:20:31 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: marvell: prestera: simplify the return expression of prestera_port_close()

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 17:17:51 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 11:59:50PM +0100, Andrew Lunn wrote: > > so basically my point was that I think you are adding a lot of infra > > in core DSA that only mv88e6xxx will use. > > That is true already, since mv88e6xxx is currently the only driver > which supports D in DSA. And it has been Marve

[net 3/9] igb: XDP extack message on error

2020-12-09 Thread Tony Nguyen
From: Sven Auhagen Add an extack error message when the RX buffer size is too small for the frame size. Fixes: 9cbc948b5a20 ("igb: add XDP support") Suggested-by: Maciej Fijalkowski Reviewed-by: Maciej Fijalkowski Acked-by: Maciej Fijalkowski Signed-off-by: Sven Auhagen Tested-by: Sandeep Pe

[net 5/9] igb: use xdp_do_flush

2020-12-09 Thread Tony Nguyen
From: Sven Auhagen Since it is a new XDP implementation change xdp_do_flush_map to xdp_do_flush. Fixes: 9cbc948b5a20 ("igb: add XDP support") Suggested-by: Maciej Fijalkowski Reviewed-by: Maciej Fijalkowski Acked-by: Maciej Fijalkowski Signed-off-by: Sven Auhagen Tested-by: Sandeep Penigalap

[net 6/9] igb: avoid transmit queue timeout in xdp path

2020-12-09 Thread Tony Nguyen
From: Sven Auhagen Since we share the transmit queue with the network stack, it is possible that we run into a transmit queue timeout. This will reset the queue. This happens under high load when XDP is using the transmit queue pretty much exclusively. netdev_start_xmit() sets the trans_start va

[net 4/9] igb: skb add metasize for xdp

2020-12-09 Thread Tony Nguyen
From: Sven Auhagen add metasize if it is set in xdp Fixes: 9cbc948b5a20 ("igb: add XDP support") Suggested-by: Maciej Fijalkowski Reviewed-by: Maciej Fijalkowski Acked-by: Maciej Fijalkowski Signed-off-by: Sven Auhagen Tested-by: Sandeep Penigalapati Signed-off-by: Tony Nguyen --- drivers

[net 9/9] ice: avoid premature Rx buffer reuse

2020-12-09 Thread Tony Nguyen
From: Björn Töpel The page recycle code, incorrectly, relied on that a page fragment could not be freed inside xdp_do_redirect(). This assumption leads to that page fragments that are used by the stack/XDP redirect can be reused and overwritten. To avoid this, store the page count prior invoking

[net 8/9] ixgbe: avoid premature Rx buffer reuse

2020-12-09 Thread Tony Nguyen
From: Björn Töpel The page recycle code, incorrectly, relied on that a page fragment could not be freed inside xdp_do_redirect(). This assumption leads to that page fragments that are used by the stack/XDP redirect can be reused and overwritten. To avoid this, store the page count prior invoking

[net 7/9] i40e: avoid premature Rx buffer reuse

2020-12-09 Thread Tony Nguyen
From: Björn Töpel The page recycle code, incorrectly, relied on that a page fragment could not be freed inside xdp_do_redirect(). This assumption leads to that page fragments that are used by the stack/XDP redirect can be reused and overwritten. To avoid this, store the page count prior invoking

[net 2/9] igb: take VLAN double header into account

2020-12-09 Thread Tony Nguyen
From: Sven Auhagen Increase the packet header padding to include double VLAN tagging. This patch uses a macro for this. Fixes: 9cbc948b5a20 ("igb: add XDP support") Suggested-by: Maciej Fijalkowski Reviewed-by: Maciej Fijalkowski Acked-by: Maciej Fijalkowski Signed-off-by: Sven Auhagen Teste

[net 1/9] igb: XDP xmit back fix error code

2020-12-09 Thread Tony Nguyen
From: Sven Auhagen The igb XDP xmit back function should only return defined error codes. Fixes: 9cbc948b5a20 ("igb: add XDP support") Reported-by: Dan Carpenter Acked-by: Maciej Fijalkowski Signed-off-by: Sven Auhagen Tested-by: Sandeep Penigalapati Signed-off-by: Tony Nguyen --- drivers/

[net 0/9][pull request] Intel Wired LAN Driver Updates 2020-12-09

2020-12-09 Thread Tony Nguyen
This series contains updates to igb, ixgbe, i40e, and ice drivers. Sven Auhagen fixes issues with igb XDP: return correct error value in XDP xmit back, increase header padding to include space for double VLAN, add an extack error when Rx buffer is too small for frame size, set metasize if it is se

Re: [PATCH v2 net-next 0/2] nfc: s3fwrn5: Change I2C interrupt trigger to EDGE_RISING

2020-12-09 Thread David Miller
From: Bongsu Jeon Date: Tue, 8 Dec 2020 23:10:10 +0900 > From: Bongsu Jeon > > For stable Samsung's I2C interrupt handling, I changed the interrupt > trigger from IRQ_TYPE_LEVEL_HIGH to IRQ_TYPE_EDGE_RISING and removed > the hard coded interrupt trigger type in the i2c module for the flexibl

Re: [PATCH net-next] net: micrel: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:34:02 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: mlx5: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:34:41 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] hisilicon/hns: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:35:31 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH v2 net-next 1/1] net: stmmac: allow stmmac to probe for C45 PHY devices

2020-12-09 Thread Andrew Lunn
On Thu, Dec 10, 2020 at 06:47:00AM +0800, Wong Vee Khee wrote: > Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45. > This extended the probing of C45 PHY devices on the MDIO bus. > > Signed-off-by: Wong Vee Khee Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net 0/2] mlx4_en fixes

2020-12-09 Thread David Miller
From: Tariq Toukan Date: Wed, 9 Dec 2020 15:03:37 +0200 > Hi, > > This patchset by Moshe contains fixes to the mlx4 Eth driver, > addressing issues in restart flow. > > Patch 1 protects the restart task from being rescheduled while active. > Please queue for -stable >= v2.6. > Patch 2 recons

Re: [PATCH net-next] hisilicon/hns3: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:36:30 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: mv88e6xxx: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:39:38 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: ipa: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:40:03 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: thunderbolt: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:38:52 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: usb: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:38:11 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: ethernet: ti: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:37:16 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: freescale: convert comma to semicolon

2020-12-09 Thread David Miller
From: Zheng Yongjun Date: Wed, 9 Dec 2020 21:37:39 +0800 > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied.

  1   2   3   4   >