Re: [PATCH V2 net 4/4] net: ena: return error code from ena_xdp_xmit_buff

2020-11-21 Thread Shay Agroskin
Jakub Kicinski writes: On Thu, 19 Nov 2020 22:28:51 +0200 Shay Agroskin wrote: The function mistakenly returns NETDEV_TX_OK regardless of the transmission success. This patch fixes this behavior by returning the error code from the function. Fixes: 548c4940b9f1 ("net: ena: Implement XDP_TX

Re: [PATCH mlx5-next 11/16] net/mlx5: Add VDPA priority to NIC RX namespace

2020-11-21 Thread Eli Cohen
On Sat, Nov 21, 2020 at 04:01:55PM -0800, Jakub Kicinski wrote: > On Fri, 20 Nov 2020 15:03:34 -0800 Saeed Mahameed wrote: > > From: Eli Cohen > > > > Add a new namespace type to the NIC RX root namespace to allow for > > inserting VDPA rules before regular NIC but after bypass, thus allowing > >

[PATCH net 2/2] devlink: Make sure devlink instance and port are in same net namespace

2020-11-21 Thread Parav Pandit
When devlink reload operation is not used, netdev of an Ethernet port may be present in different net namespace than the net namespace of the devlink instance. Ensure that both the devlink instance and devlink port netdev are located in same net namespace. Fixes: 070c63f20f6c ("net: devlink: allo

[PATCH net 0/2] devlink port attribute fixes

2020-11-21 Thread Parav Pandit
This patchset contains 2 small fixes for devlink port attributes. Patch summary: Patch-1 synchronize the devlink port attribute reader with net namespace change operation Patch-2 Ensure to return devlink port's netdevice attributes when netdev and devlink instance belong to same ne

[PATCH net 1/2] devlink: Hold rtnl lock while reading netdev attributes

2020-11-21 Thread Parav Pandit
A netdevice of a devlink port can be moved to different net namespace than its parent devlink instance. This scenario occurs when devlink reload is not used for maintaining backward compatibility. When netdevice is undergoing migration to net namespace, its ifindex and name may change. In such us

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-21 Thread Matthew Wilcox
On Sat, Nov 21, 2020 at 08:50:58AM -0800, t...@redhat.com wrote: > The fixer review is > https://reviews.llvm.org/D91789 > > A run over allyesconfig for x86_64 finds 62 issues, 5 are false positives. > The false positives are caused by macros passed to other macros and by > some macro expansions t

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-11-21 Thread Alexei Starovoitov
On Sat, Nov 21, 2020 at 10:59 AM Pablo Neira Ayuso wrote: > > We're lately discussing more and more usecases in the NFWS meetings > where the egress can get really useful. We also discussed in the meeting XYZ that this hook is completely pointless. Got the hint?

Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

2020-11-21 Thread Joe Perches
On Sun, 2020-11-22 at 00:04 +0100, Marc Kleine-Budde wrote: > On 11/21/20 8:50 PM, Joe Perches wrote: > > > What about moving the default to the end if the case, which is more > > > common anyways: > > > > > > diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c > > > b/drivers/net/can/usb/

[PATCH net] ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init

2020-11-21 Thread Wang Hai
kmemleak report a memory leak as follows: unreferenced object 0x8880059c6a00 (size 64): comm "ip", pid 23696, jiffies 4296590183 (age 1755.384s) hex dump (first 32 bytes): 20 01 00 10 00 00 00 00 00 00 00 00 00 00 00 00 ... 1c 00 00 00 00 00 00 00 00 00 00 00 07 00 00

[net-next 0/5] Add CHACHA20-POLY1305 cipher to Kernel TLS

2020-11-21 Thread Vadim Fedorenko
RFC 7905 defines usage of ChaCha20-Poly1305 in TLS connections. This cipher is widely used nowadays and it's good to have a support for it in TLS connections in kernel Vadim Fedorenko (5): net/tls: make inline helpers protocol-aware net/tls: add CHACHA20-POLY1305 specific defines and structure

[net-next 5/5] selftests/tls: add CHACHA20-POLY1305 to tls selftests

2020-11-21 Thread Vadim Fedorenko
Add new cipher as a variant of standart tls selftests Signed-off-by: Vadim Fedorenko --- tools/testing/selftests/net/tls.c | 40 --- 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net

[net-next 3/5] net/tls: add CHACHA20-POLY1305 specific behavior

2020-11-21 Thread Vadim Fedorenko
RFC 7905 defines special behavior for ChaCha-Poly TLS sessions. The differences are in the calculation of nonce and the absence of explicit IV. This behavior is like TLSv1.3 partly. Signed-off-by: Vadim Fedorenko --- include/net/tls.h | 9 ++--- net/tls/tls_sw.c | 6 -- 2 files changed,

[net-next 4/5] net/tls: add CHACHA20-POLY1305 configuration

2020-11-21 Thread Vadim Fedorenko
Add ChaCha-Poly specific configuration code. Signed-off-by: Vadim Fedorenko --- net/tls/tls_main.c | 3 +++ net/tls/tls_sw.c | 18 ++ 2 files changed, 21 insertions(+) diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c index 8d93cea..47b7c53 100644 --- a/net/tls/tls_main.c

[net-next 1/5] net/tls: make inline helpers protocol-aware

2020-11-21 Thread Vadim Fedorenko
Inline functions defined in tls.h have a lot of AES-specific constants. Remove these constants and change argument to struct tls_prot_info to have an access to cipher type in later patches Signed-off-by: Vadim Fedorenko --- include/net/tls.h | 26 -- net/tls/t

[net-next 2/5] net/tls: add CHACHA20-POLY1305 specific defines and structures

2020-11-21 Thread Vadim Fedorenko
To provide support for ChaCha-Poly cipher we need to define specific constants and structures. Signed-off-by: Vadim Fedorenko --- include/net/tls.h| 1 + include/uapi/linux/tls.h | 15 +++ 2 files changed, 16 insertions(+) diff --git a/include/net/tls.h b/include/net/tls.h

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-21 Thread Richard Cochran
On Sat, Nov 21, 2020 at 03:26:11AM +0200, Vladimir Oltean wrote: > On Thu, Nov 19, 2020 at 06:51:15PM +, tristram...@microchip.com wrote: > > I think the right implementation is for the driver to remember this receive > > timestamp > > of Pdelay_Req and puts it in the tail tag when it sees a

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-21 Thread Richard Cochran
On Sat, Nov 21, 2020 at 03:26:11AM +0200, Vladimir Oltean wrote: > On Thu, Nov 19, 2020 at 06:51:15PM +, tristram...@microchip.com wrote: > > The receive and transmit latencies are different for different connected > > speed. So the > > driver needs to change them when the link changes. For

Re: [PATCH net 1/4] netfilter: nftables_offload: set address type in control dissector

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 13:35:58 +0100 Pablo Neira Ayuso wrote: > If the address type is missing through the control dissector, then > matching on IPv4 and IPv6 addresses does not work. Doesn't work where? Are you talking about a specific driver? > Set it accordingly so > rules that specify an IP add

Re: [PATCH net-next v3 1/5] net: implement threaded-able napi poll loop support

2020-11-21 Thread Jakub Kicinski
On Wed, 18 Nov 2020 11:10:05 -0800 Wei Wang wrote: > +int napi_set_threaded(struct napi_struct *n, bool threaded) > +{ > + ASSERT_RTNL(); > + > + if (n->dev->flags & IFF_UP) > + return -EBUSY; > + > + if (threaded == !!test_bit(NAPI_STATE_THREADED, &n->state)) > +

[PATCH] dpaa2-eth: Fix compile error due to missing devlink support

2020-11-21 Thread Ezequiel Garcia
The dpaa2 driver depends on devlink, so it should select NET_DEVLINK in order to fix compile errors, such as: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err': dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report' drivers/net/ethernet/freescale/d

Re: [PATCH] octeontx2-af: Add support for RSS hashing based on Transport protocol field

2020-11-21 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 20 Nov 2020 15:09:06 +0530 you wrote: > Add support to choose RSS flow key algorithm with IPv4 transport protocol > field included in hashing input data. This will be enabled by default. > There-by enabling 3/5 tupl

Re: [PATCH mlx5-next 11/16] net/mlx5: Add VDPA priority to NIC RX namespace

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 15:03:34 -0800 Saeed Mahameed wrote: > From: Eli Cohen > > Add a new namespace type to the NIC RX root namespace to allow for > inserting VDPA rules before regular NIC but after bypass, thus allowing > DPDK to have precedence in packet processing. How does DPDK and VDPA relat

Re: [PATCH mlx5-next 09/16] net/mlx5: Expose IP-in-IP TX and RX capability bits

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 15:03:32 -0800 Saeed Mahameed wrote: > From: Aya Levin > > Expose FW indication that it supports stateless offloads for IP over IP > tunneled packets per direction. In some HW like ConnectX-4 IP-in-IP > support is not symmetric, it supports steering on the inner header but > i

Re: [PATCH V2 net 4/4] net: ena: return error code from ena_xdp_xmit_buff

2020-11-21 Thread Jakub Kicinski
On Thu, 19 Nov 2020 22:28:51 +0200 Shay Agroskin wrote: > The function mistakenly returns NETDEV_TX_OK regardless of the > transmission success. This patch fixes this behavior by returning the > error code from the function. > > Fixes: 548c4940b9f1 ("net: ena: Implement XDP_TX action") > Signed-of

Re: [PATCH net 15/15] ibmvnic: add some debugs

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 16:40:49 -0600 Lijun Pan wrote: > From: Sukadev Bhattiprolu > > We sometimes run into situations where a soft/hard reset of the adapter > takes a long time or fails to complete. Having additional messages that > include important adapter state info will hopefully help understa

Re: [PATCH net 12/15] ibmvnic: fix NULL pointer dereference in reset_sub_crq_queues

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 16:40:46 -0600 Lijun Pan wrote: > adapter->tx_scrq and adapter->rx_scrq could be NULL if the previous reset > did not complete after freeing sub crqs. Check for NULL before > dereferencing them. > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c > b/drivers/net/ethernet/ibm/ibm

Re: [PATCH net 04/15] ibmvnic: remove free_all_rwi function

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 16:40:38 -0600 Lijun Pan wrote: > From: Dany Madden > > Remove free_all_rwi() since it is no longer used. (__ibmvnic_remove() was > the last user of free_all_rwi()). Squash this with the appropriate change, please.

Re: [PATCH net 01/15] ibmvnic: handle inconsistent login with reset

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 16:40:35 -0600 Lijun Pan wrote: > From: Dany Madden > > Inconsistent login with the vnicserver is causing the device to be > removed. This does not give the device a chance to recover from error > state. This patch schedules a FATAL reset instead to bring the adapter > up. >

Re: [PATCH net 02/15] ibmvnic: process HMC disable command

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 15:36:37 -0800 Jakub Kicinski wrote: > On Fri, 20 Nov 2020 16:40:36 -0600 Lijun Pan wrote: > > From: Dany Madden > > > > Currently ibmvnic does not support the disable vnic command from the > > Hardware Management Console. This patch enables ibmvnic to process > > CRQ message

Re: [PATCH net 02/15] ibmvnic: process HMC disable command

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 16:40:36 -0600 Lijun Pan wrote: > From: Dany Madden > > Currently ibmvnic does not support the disable vnic command from the > Hardware Management Console. This patch enables ibmvnic to process > CRQ message 0x07, disable vnic adapter. What user-visible problem does this one

Re: [PATCH] tun: honor IOCB_NOWAIT flag

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 07:59:54 -0700 Jens Axboe wrote: > tun only checks the file O_NONBLOCK flag, but it should also be checking > the iocb IOCB_NOWAIT flag. Any fops using ->read/write_iter() should check > both, otherwise it breaks users that correctly expect O_NONBLOCK semantics > if IOCB_NOWAIT

Re: pull-request: can-next 2020-11-20

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 14:32:53 +0100 Marc Kleine-Budde wrote: > The first patch is by Yegor Yefremov and he improves the j1939 documentaton by > adding tables for the CAN identifier and its fields. > > Then there are 8 patches by Oliver Hartkopp targeting the CAN driver > infrastructure and drivers.

Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

2020-11-21 Thread Marc Kleine-Budde
On 11/21/20 8:50 PM, Joe Perches wrote: >> What about moving the default to the end if the case, which is more common >> anyways: >> >> diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c >> b/drivers/net/can/usb/peak_usb/pcan_usb_core.c > [] >> @@ -295,16 +295,16 @@ static void peak_usb_wr

Re: [PATCH net] devlink: Fix reload stats structure

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 15:40:37 +0200 Moshe Shemesh wrote: > Fix reload stats structure exposed to the user. Change stats structure > hierarchy to have the reload action as a parent of the stat entry and > then stat entry includes value per limit. This will also help to avoid > string concatenation on

Re: [PATCH net] net/af_iucv: set correct sk_protocol for child sockets

2020-11-21 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 20 Nov 2020 11:06:57 +0100 you wrote: > Child sockets erroneously inherit their parent's sk_type (ie. SOCK_*), > instead of the PF_IUCV protocol that the parent was created with in > iucv_sock_create(). > > We're curren

Re: [PATCH net-next 0/5] net: hns3: misc updates for -next

2020-11-21 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 20 Nov 2020 17:16:18 +0800 you wrote: > This series includes some misc updates for the HNS3 ethernet driver. > > #1 adds support for 1280 queues > #2 adds mapping for BAR45 which is needed by RoCE client. > #3 ext

Re: [PATCH net-next] net: bridge: switch to net core statistics counters handling

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 12:22:23 +0100 Heiner Kallweit wrote: > Use netdev->tstats instead of a member of net_bridge for storing > a pointer to the per-cpu counters. This allows us to use core > functionality for statistics handling. > > Signed-off-by: Heiner Kallweit Applied, thanks!

Re: [PATCH net-next] MAINTAINERS: Update page pool entry

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 10:36:19 +0100 Jesper Dangaard Brouer wrote: > Add some file F: matches that is related to page_pool. > > Signed-off-by: Jesper Dangaard Brouer > --- > MAINTAINERS |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f827f504251b..e

Re: [Patch stable] netfilter: clear skb->next in NF_HOOK_LIST()

2020-11-21 Thread Florian Westphal
Cong Wang wrote: > From: Cong Wang > > NF_HOOK_LIST() uses list_del() to remove skb from the linked list, > however, it is not sufficient as skb->next still points to other > skb. We should just call skb_list_del_init() to clear skb->next, > like the rest places which using skb list. > > This h

Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14

2020-11-21 Thread Jakub Kicinski
On Thu, 19 Nov 2020 18:24:39 +0100 Yves-Alexis Perez wrote: > Starting with iOS 14 released in September 2020, connectivity using the > personal hotspot USB tethering function of iOS devices is broken. > > Communication between the host and the device (for example ICMP traffic > or DNS resolution

Re: [PATCH net-next] compat: always include linux/compat.h from net/compat.h

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 22:25:35 +0100 Arnd Bergmann wrote: > On Sat, Nov 21, 2020 at 6:52 PM Jakub Kicinski wrote: > > > > We're about to do some reshuffling in networking headers and make > > some of the file lose the implicit includes. This results in: > > > > In file included from net/ipv4/netfilt

[PATCH net-next v2] compat: always include linux/compat.h from net/compat.h

2020-11-21 Thread Jakub Kicinski
We're about to do reshuffling in networking headers and eliminate some implicit includes. This results in: In file included from ../net/ipv4/netfilter/arp_tables.c:26: include/net/compat.h:60:40: error: unknown type name ‘compat_uptr_t’; did you mean ‘compat_ptr_ioctl’? struct sockaddr __user

Re: [PATCH v2 net] ptp: clockmatrix: bug fix for idtcm_strverscmp

2020-11-21 Thread Jakub Kicinski
On Wed, 18 Nov 2020 22:50:24 -0500 min.li...@renesas.com wrote: > From: Min Li > > Feed kstrtou8 with NULL terminated string. > > Changes since v1: > -Only strcpy 15 characters to leave 1 space for '\0' > > Signed-off-by: Min Li > -static int idtcm_strverscmp(const char *ver1, const char *ver

Re: [PATCH net-next] compat: always include linux/compat.h from net/compat.h

2020-11-21 Thread Arnd Bergmann
On Sat, Nov 21, 2020 at 6:52 PM Jakub Kicinski wrote: > > We're about to do some reshuffling in networking headers and make > some of the file lose the implicit includes. This results in: > > In file included from net/ipv4/netfilter/arp_tables.c:26: > include/net/compat.h:57:23: error: conflicting

Re: [PATCH v4] aquantia: Remove the build_skb path

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 13:22:04 -0800 Jakub Kicinski wrote: > On Thu, 19 Nov 2020 23:52:55 + Ramsay, Lincoln wrote: > > When performing IPv6 forwarding, there is an expectation that SKBs > > will have some headroom. When forwarding a packet from the aquantia > > driver, this does not always happen

Re: [PATCH v4] aquantia: Remove the build_skb path

2020-11-21 Thread Jakub Kicinski
On Thu, 19 Nov 2020 23:52:55 + Ramsay, Lincoln wrote: > When performing IPv6 forwarding, there is an expectation that SKBs > will have some headroom. When forwarding a packet from the aquantia > driver, this does not always happen, triggering a kernel warning. > > aq_ring.c has this code (edit

Re: [PATCH] cxgb4: Fix build failure when CONFIG_TLS=m

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 13:25:28 -0600 Tom Seewald wrote: > After commit 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough") > whenever CONFIG_TLS=m and CONFIG_CHELSIO_T4=y, the following build > failure occurs: > > ld: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o: in function > `cxgb_selec

Re: [PATCHv3] bonding: wait for sysfs kobject destruction before freeing struct slave

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 16:39:51 +0100 Greg Kroah-Hartman wrote: > On Fri, Nov 20, 2020 at 02:28:27PM +, Jamie Iles wrote: > > syzkaller found that with CONFIG_DEBUG_KOBJECT_RELEASE=y, releasing a > > struct slave device could result in the following splat: > > This is a potential use-after-free i

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 21:58:37 +0100 Johannes Berg wrote: > On Sat, 2020-11-21 at 12:55 -0800, Jakub Kicinski wrote: > > It is more complicated. We can go back to an skb field if this work is > > expected to yield results for mac80211. Would you mind sending a patch? > > I can do that, but I'm not

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Johannes Berg
On Sat, 2020-11-21 at 12:55 -0800, Jakub Kicinski wrote: > [snip] > Ack, you have to figure out all the places anyway, the question is > whether you put probes there or calls in the source code. > > Shifting the maintenance burden but also BPF is flexibility. Yeah, true. Though I'd argue also vis

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 20:30:44 +0100 Johannes Berg wrote: > On Sat, 2020-11-21 at 10:35 -0800, Jakub Kicinski wrote: > > On Sat, 21 Nov 2020 19:12:21 +0100 Johannes Berg wrote: > > > > So I'm leaning towards reverting the whole thing. You can attach > > > > kretprobes and record the information you

Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-21 Thread Miguel Ojeda
On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada wrote: > > Our goal is to always enable __must_check where appreciate, so this > CONFIG option is no longer needed. This would be great. It also implies we can then move it to `compiler_attributes.h` since it does not depend on config options anymor

Re: [PATCH bpf-next v2 5/5] selftests/bpf: xsk selftests - Bi-directional Sockets - SKB, DRV

2020-11-21 Thread Weqaar Janjua
On Fri, 20 Nov 2020 at 20:45, Yonghong Song wrote: > > > > On 11/20/20 5:00 AM, Weqaar Janjua wrote: > > Adds following tests: > > > > 1. AF_XDP SKB mode > > d. Bi-directional Sockets > >Configure sockets as bi-directional tx/rx sockets, sets up fill > >and completion rings on

[PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix

2020-11-21 Thread Vlad Buslov
Currently both filter and action flags use same "TCA_" prefix which makes them hard to distinguish to code and confusing for users. Create aliases for existing action flags constants with "TCA_ACT_" prefix. Signed-off-by: Vlad Buslov --- include/uapi/linux/rtnetlink.h | 11 +++ net/sched

[PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-21 Thread Masahiro Yamada
Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). A lot of warn_unused_result warnings existed in 2006, but until now they have been fixed thanks to people doing allmodconfig tests. Our goal is to always enable __must_check where appreciate, so this CONFIG option is no longer needed.

Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

2020-11-21 Thread Joe Perches
On Sat, 2020-11-21 at 14:17 +0100, Marc Kleine-Budde wrote: > On 11/20/20 7:34 PM, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > >

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Johannes Berg
On Sat, 2020-11-21 at 10:35 -0800, Jakub Kicinski wrote: > On Sat, 21 Nov 2020 19:12:21 +0100 Johannes Berg wrote: > > > So I'm leaning towards reverting the whole thing. You can attach > > > kretprobes and record the information you need in BPF maps. > > > > I'm not going to object to reverting

Re: [PATCH net-next,v3 0/9] netfilter: flowtable bridge and vlan enhancements

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 19:56:21 +0100 Pablo Neira Ayuso wrote: > > Please gather some review tags from senior netdev developers. I don't > > feel confident enough to apply this as 100% my own decision. > > Fair enough. > > This requirement for very specific Netfilter infrastructure which does > no

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-11-21 Thread Pablo Neira Ayuso
Hi Lukas, On Sun, Oct 11, 2020 at 10:26:57AM +0200, Lukas Wunner wrote: > On Tue, Sep 15, 2020 at 12:02:03AM +0200, Daniel Borkmann wrote: > > today it is possible and > > perfectly fine to e.g. redirect to a host-facing veth from tc ingress which > > then goes into container. Only traffic that go

Re: [PATCH net-next,v3 0/9] netfilter: flowtable bridge and vlan enhancements

2020-11-21 Thread Pablo Neira Ayuso
On Sat, Nov 21, 2020 at 10:15:51AM -0800, Jakub Kicinski wrote: > On Sat, 21 Nov 2020 13:31:38 +0100 Pablo Neira Ayuso wrote: > > On Mon, Nov 16, 2020 at 11:56:58PM +0100, Pablo Neira Ayuso wrote: > > > On Mon, Nov 16, 2020 at 02:45:21PM -0800, Jakub Kicinski wrote: > > > > On Mon, 16 Nov 2020 23

Re: [PATCH net-next] compat: always include linux/compat.h from net/compat.h

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 09:52:24 -0800 Jakub Kicinski wrote: > In file included from net/ipv4/netfilter/arp_tables.c:26: > include/net/compat.h:57:23: error: conflicting types for ‘uintptr_t’ > #define compat_uptr_t uintptr_t >^ > include/asm-generic/compat.h:22:13: not

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 19:12:21 +0100 Johannes Berg wrote: > > So I'm leaning towards reverting the whole thing. You can attach > > kretprobes and record the information you need in BPF maps. > > I'm not going to object to reverting it (and perhaps redoing it better > later), but I will point out t

Re: [PATCH net-next,v3 0/9] netfilter: flowtable bridge and vlan enhancements

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 13:31:38 +0100 Pablo Neira Ayuso wrote: > On Mon, Nov 16, 2020 at 11:56:58PM +0100, Pablo Neira Ayuso wrote: > > On Mon, Nov 16, 2020 at 02:45:21PM -0800, Jakub Kicinski wrote: > > > On Mon, 16 Nov 2020 23:36:15 +0100 Pablo Neira Ayuso wrote: > > > > > Are you saying A -> B

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Johannes Berg
On Sat, 2020-11-21 at 10:06 -0800, Jakub Kicinski wrote: > On Sat, 21 Nov 2020 17:52:27 +0100 Florian Westphal wrote: > > Ido Schimmel wrote: > > > Other suggestions? > > > > Aleksandr, why was this made into an skb extension in the first place? > > > > AFAIU this feature is usually always dis

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 17:52:27 +0100 Florian Westphal wrote: > Ido Schimmel wrote: > > Other suggestions? > > Aleksandr, why was this made into an skb extension in the first place? > > AFAIU this feature is usually always disabled at build time. > For debug builds (test farm /debug kernel etc) i

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-21 Thread Joe Perches
On Sat, 2020-11-21 at 09:18 -0800, James Bottomley wrote: > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > > A difficult part of automating commits is composing the subsystem > > preamble in the commit log. For the ongoing effort of a fixer > > producing one or two fixes a release the

[PATCH net-next] compat: always include linux/compat.h from net/compat.h

2020-11-21 Thread Jakub Kicinski
We're about to do some reshuffling in networking headers and make some of the file lose the implicit includes. This results in: In file included from net/ipv4/netfilter/arp_tables.c:26: include/net/compat.h:57:23: error: conflicting types for ‘uintptr_t’ #define compat_uptr_t uintptr_t

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Johannes Berg
On Sat, 2020-11-21 at 17:52 +0100, Florian Westphal wrote: > > Aleksandr, why was this made into an skb extension in the first place? > > AFAIU this feature is usually always disabled at build time. > For debug builds (test farm /debug kernel etc) its always needed. > > If thats the case this u6

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-21 Thread James Bottomley
On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > A difficult part of automating commits is composing the subsystem > preamble in the commit log. For the ongoing effort of a fixer > producing > one or two fixes a release the use of 'treewide:' does not seem > appropriate. > > It would b

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-21 Thread Joe Perches
On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > A difficult part of automating commits is composing the subsystem > preamble in the commit log. For the ongoing effort of a fixer producing > one or two fixes a release the use of 'treewide:' does not seem appropriate. > > It would be be

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Florian Westphal
Ido Schimmel wrote: > On Thu, Oct 29, 2020 at 05:36:19PM +, Aleksandr Nogikh wrote: > > From: Aleksandr Nogikh > > > > Remote KCOV coverage collection enables coverage-guided fuzzing of the > > code that is not reachable during normal system call execution. It is > > especially helpful for f

[RFC] MAINTAINERS tag for cleanup robot

2020-11-21 Thread trix
A difficult part of automating commits is composing the subsystem preamble in the commit log. For the ongoing effort of a fixer producing one or two fixes a release the use of 'treewide:' does not seem appropriate. It would be better if the normal prefix was used. Unfortunately normal is not con

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Ido Schimmel
+ Florian On Thu, Oct 29, 2020 at 05:36:19PM +, Aleksandr Nogikh wrote: > From: Aleksandr Nogikh > > Remote KCOV coverage collection enables coverage-guided fuzzing of the > code that is not reachable during normal system call execution. It is > especially helpful for fuzzing networking subs

Re: [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer

2020-11-21 Thread Florian Fainelli
On 11/21/2020 3:44 AM, Kurt Kanzenbach wrote: > When DSA is not loaded when the driver is probed an error message is > printed. But, that's not really an error, just a defer. Use dev_err_probe() > instead. > > Signed-off-by: Kurt Kanzenbach Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes

2020-11-21 Thread Florian Fainelli
On 11/21/2020 3:44 AM, Kurt Kanzenbach wrote: > Remove unused and add needed includes. No functional change. > > Suggested-by: Vladimir Oltean > Signed-off-by: Kurt Kanzenbach Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 0/3] net/sched: fix over mtu packet of defrag in

2020-11-21 Thread Jamal Hadi Salim
On 2020-11-20 2:28 p.m., Cong Wang wrote: On Thu, Nov 19, 2020 at 3:39 PM wrote: From: wenxu Currently kernel tc subsystem can do conntrack in act_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last

[PATCH ipsec-next] xfrm: interface: support collect metadata mode

2020-11-21 Thread Eyal Birger
This commit adds support for 'collect_md' mode on xfrm interfaces. Each net can have one collect_md device, created by providing the IFLA_XFRM_COLLECT_METADATA flag at creation. This device cannot be altered and has no if_id or link device attributes. On transmit to this device, the if_id is fetc

Re: [PATCHv4 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-21 Thread Jiri Pirko
Sat, Nov 21, 2020 at 05:02:00AM CET, george.cher...@marvell.com wrote: >Add health reporters for RVU NPA block. >NPA Health reporters handle following HW event groups > - GENERAL events > - ERROR events > - RAS events > - RVU event >An event counter per event is maintained in SW. > >Output: > # dev

SO_REUSEADDR compatibility problems

2020-11-21 Thread James Courtier-Dutton
Hi, The use case I am struggling with is the use of a Windows program running in wine that is sending and receiving UDP packets. This particular windows program uses SO_REUSEADDR socket option and opens two sockets. Lets call the first one socket A, and the second one Socket B. The SO_REUSEADDR f

Re: [net,v2] net/packet: fix packet receive on L3 devices without visible hard header

2020-11-21 Thread Willem de Bruijn
On Sat, Nov 21, 2020 at 2:56 AM Jason A. Donenfeld wrote: > > On 11/21/20, Eyal Birger wrote: > > In the patchset merged by commit b9fcf0a0d826 > > ("Merge branch 'support-AF_PACKET-for-layer-3-devices'") L3 devices which > > did not have header_ops were given one for the purpose of protocol pars

Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

2020-11-21 Thread Marc Kleine-Budde
On 11/20/20 7:34 PM, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gusta

Re: [PATCH v3] dt-bindings: misc: convert fsl,qoriq-mc from txt to YAML

2020-11-21 Thread Rob Herring
On Thu, Nov 12, 2020 at 03:32:54PM +0200, Laurentiu Tudor wrote: > From: Ionut-robert Aron > > Convert fsl,qoriq-mc to YAML in order to automate the verification > process of dts files. In addition, update MAINTAINERS accordingly > and, while at it, add some missing files. > > Signed-off-by: Ion

Re: [EXT] Re: [RFC, net-next] net: qos: introduce a redundancy flow action

2020-11-21 Thread Jamal Hadi Salim
Hi, On 2020-11-20 2:32 a.m., Xiaoliang Yang wrote: Hi Jamal, On 2020-11-19 0:11, Jamal Hadi Salim wrote: The 11/17/2020 14:30, Xiaoliang Yang wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you [..] We already have mirroring + ability to add/pop tags. Would the follow

[PATCH net 1/4] netfilter: nftables_offload: set address type in control dissector

2020-11-21 Thread Pablo Neira Ayuso
If the address type is missing through the control dissector, then matching on IPv4 and IPv6 addresses does not work. Set it accordingly so rules that specify an IP address succesfully match on packets. Fixes: c9626a2cbdb2 ("netfilter: nf_tables: add hardware offload support") Signed-off-by: Pablo

[PATCH net 2/4] netfilter: nftables_offload: build mask based from the matching bytes

2020-11-21 Thread Pablo Neira Ayuso
Userspace might match on prefix bytes of header fields if they are on the byte boundary, this requires that the mask is adjusted accordingly. Use NFT_OFFLOAD_MATCH_EXACT() for meta since prefix byte matching is not allowed for this type of selector. Fixes: c9626a2cbdb2 ("netfilter: nf_tables: add

[PATCH net 4/4] netfilter: nf_tables: avoid false-postive lockdep splat

2020-11-21 Thread Pablo Neira Ayuso
From: Florian Westphal There are reports wrt lockdep splat in nftables, e.g.: [ cut here ] WARNING: CPU: 2 PID: 31416 at net/netfilter/nf_tables_api.c:622 lockdep_nfnl_nft_mutex_not_held+0x28/0x38 [nf_tables] ... These are caused by an earlier, unrelated bug such as a n A

[PATCH net 3/4] netfilter: ipset: prevent uninit-value in hash_ip6_add

2020-11-21 Thread Pablo Neira Ayuso
From: Eric Dumazet syzbot found that we are not validating user input properly before copying 16 bytes [1]. Using NLA_BINARY in ipaddr_policy[] for IPv6 address is not correct, since it ensures at most 16 bytes were provided. We should instead make sure user provided exactly 16 bytes. In old k

[PATCH net 0/4] Netfilter fixes for net

2020-11-21 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter fixes for net: 1) Fix missing control data in flow dissector, otherwise IP address matching in hardware offload infra does not work. 2) Fix hardware offload match on prefix IP address when userspace does not send a bitwise expression to represe

Re: [PATCH net-next,v3 0/9] netfilter: flowtable bridge and vlan enhancements

2020-11-21 Thread Pablo Neira Ayuso
On Mon, Nov 16, 2020 at 11:56:58PM +0100, Pablo Neira Ayuso wrote: > On Mon, Nov 16, 2020 at 02:45:21PM -0800, Jakub Kicinski wrote: > > On Mon, 16 Nov 2020 23:36:15 +0100 Pablo Neira Ayuso wrote: > > > > Are you saying A -> B traffic won't match so it will update the cache, > > > > since conntrack

[PATCH net-next 0/1] net: dsa: hellcreek: Add TAPRIO offloading

2020-11-21 Thread Kurt Kanzenbach
Hi, The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic schedules may be configured individually on each front port. Each port has eight egress queues. The traffic is mapped to a traffic class respectively via the PCP field of a VLAN tagged frame. This is a respin of the orig

Re: [PATCH net-next,v5 0/9] netfilter: flowtable bridge and vlan enhancements

2020-11-21 Thread Pablo Neira Ayuso
Hi, On Fri, Nov 20, 2020 at 03:09:37PM +, Alexander Lobakin wrote: > From: Pablo Neira Ayuso > Date: Fri, 20 Nov 2020 13:49:12 +0100 [...] > > The following patchset augments the Netfilter flowtable fastpath to > > support for network topologies that combine IP forwarding, bridge and > > VLAN

[PATCH net-next 1/1] net: dsa: hellcreek: Add TAPRIO offloading support

2020-11-21 Thread Kurt Kanzenbach
The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic schedules may be configured individually on each front port. Each port has eight egress queues. The traffic is mapped to a traffic class respectively via the PCP field of a VLAN tagged frame. The TAPRIO Qdisc already implemen

[PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer

2020-11-21 Thread Kurt Kanzenbach
When DSA is not loaded when the driver is probed an error message is printed. But, that's not really an error, just a defer. Use dev_err_probe() instead. Signed-off-by: Kurt Kanzenbach --- drivers/net/dsa/hirschmann/hellcreek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups

2020-11-21 Thread Kurt Kanzenbach
Hi, fix two minor issues in the hellcreek driver. Thanks, Kurt Kurt Kanzenbach (2): net: dsa: tag_hellcreek: Cleanup includes net: dsa: hellcreek: Don't print error message on defer drivers/net/dsa/hirschmann/hellcreek.c | 2 +- net/dsa/tag_hellcreek.c| 4 +--- 2 files chan

[PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes

2020-11-21 Thread Kurt Kanzenbach
Remove unused and add needed includes. No functional change. Suggested-by: Vladimir Oltean Signed-off-by: Kurt Kanzenbach --- net/dsa/tag_hellcreek.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/dsa/tag_hellcreek.c b/net/dsa/tag_hellcreek.c index 2061de06eafb..a098

[PATCH] e1000e: remove the redundant value assignment in e1000_update_nvm_checksum_spt

2020-11-21 Thread xiakaixu1987
From: Kaixu Xia Both of the statements are value assignment of the variable act_offset. The first value assignment is overwritten by the second and is useless. Remove it. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 7 --- 1 file chang

Re: [RFC PATCH bpf-next 0/8] Socket migration for SO_REUSEPORT.

2020-11-21 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Thu, 19 Nov 2020 18:31:57 -0800 > On Fri, Nov 20, 2020 at 07:17:49AM +0900, Kuniyuki Iwashima wrote: > > From: Martin KaFai Lau > > Date: Wed, 18 Nov 2020 17:49:13 -0800 > > > On Tue, Nov 17, 2020 at 06:40:15PM +0900, Kuniyuki Iwashima wrote: > > > > The SO_RE

Re: [RFC PATCH bpf-next 3/8] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-11-21 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Thu, 19 Nov 2020 17:53:46 -0800 > On Fri, Nov 20, 2020 at 07:09:22AM +0900, Kuniyuki Iwashima wrote: > > From: Martin KaFai Lau > > Date: Wed, 18 Nov 2020 15:50:17 -0800 > > > On Tue, Nov 17, 2020 at 06:40:18PM +0900, Kuniyuki Iwashima wrote: > > > > This patch le

[PATCH 1/2] net: pch_gbe: Use dma_set_mask_and_coherent to simplify code

2020-11-21 Thread Christophe JAILLET
'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. Signed-off-by: Christophe JAILLET --- .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 14 -- 1 file changed, 4 insertions(+), 10 dele

[PATCH 2/2] net: pch_gbe: Use 'dma_free_coherent()' to undo 'dma_alloc_coherent()'

2020-11-21 Thread Christophe JAILLET
Memory allocation are done with 'dma_alloc_coherent()'. Be consistent and use 'dma_free_coherent()' to free the corresponding memory. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

  1   2   >