Re: [PATCHv3 iproute2-next 3/5] lib: add libbpf support

2020-11-04 Thread Hangbin Liu
On Wed, Nov 04, 2020 at 07:33:40PM -0700, David Ahern wrote: > On 11/4/20 1:22 AM, Hangbin Liu wrote: > > If we move this #ifdef HAVE_LIBBPF to bpf_legacy.c, we need to rename > > them all. With current patch, we limit all the legacy functions in > > bpf_legacy > > and doesn't mix them with libbpf

Re: [PATCH mlx5-next v1 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-11-04 Thread Dan Williams
On Wed, Nov 4, 2020 at 11:32 PM gregkh wrote: > > On Wed, Nov 04, 2020 at 03:21:23PM -0800, Dan Williams wrote: > > On Tue, Nov 3, 2020 at 7:45 AM Jason Gunthorpe wrote: > > [..] > > > > +MODULE_DEVICE_TABLE(auxiliary, mlx5v_id_table); > > > > + > > > > +static struct auxiliary_driver mlx5v_drive

Re: [net 05/27] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

2020-11-04 Thread Marc Kleine-Budde
On 11/5/20 5:47 AM, Vincent MAILHOL wrote: >>> Okay, we can take this as a quick fix but to me it seems a little >>> strange to be dropping what is effectively locally generated frames. > > For those who are not familiar with SocketCAN and to make sure that we > are all aligned here, let me give a

Re: Very slow realtek 8169 ethernet performance, but only one interface, on ThinkPad T14.

2020-11-04 Thread Qu Wenruo
On 2020/11/5 下午3:01, Heiner Kallweit wrote: > On 05.11.2020 03:48, Qu Wenruo wrote: >> Hi, >> >> Not sure if this is a regression or not, but just find out that after >> upgrading to v5.9 kernel, one of my ethernet port on my ThinkPad T14 (ryzen >> version) becomes very slow. >> >> Only *2~3* M

[PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-04 Thread Xie He
This driver transports LAPB (X.25 link layer) frames over TTY links. I can safely say that this driver has no actual user because it was not working at all until: commit 8fdcabeac398 ("drivers/net/wan/x25_asy: Fix to make it work") The code in its current state still has problems: 1. The uses of

Re: [PATCH mlx5-next v1 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-11-04 Thread gregkh
On Wed, Nov 04, 2020 at 03:21:23PM -0800, Dan Williams wrote: > On Tue, Nov 3, 2020 at 7:45 AM Jason Gunthorpe wrote: > [..] > > > +MODULE_DEVICE_TABLE(auxiliary, mlx5v_id_table); > > > + > > > +static struct auxiliary_driver mlx5v_driver = { > > > + .name = "vnet", > > > + .probe = mlx5v_

Re: [PATCH 00/10] thunderbolt: Add DMA traffic test driver

2020-11-04 Thread Mika Westerberg
On Wed, Nov 04, 2020 at 08:39:01PM +0200, Yehezkel Bernat wrote: > On Wed, Nov 4, 2020 at 4:00 PM Mika Westerberg > wrote: > > > > Hi all, > > > > This series adds a new Thunderbolt service driver that can be used on > > manufacturing floor to test that each Thunderbolt/USB4 port is functional. >

Re: [PATCH bpf-next 6/6] i40e: use batched xsk Tx interfaces to increase performance

2020-11-04 Thread Magnus Karlsson
On Thu, Nov 5, 2020 at 12:12 AM Maciej Fijalkowski wrote: > > On Wed, Nov 04, 2020 at 03:09:02PM +0100, Magnus Karlsson wrote: > > From: Magnus Karlsson > > > > Use the new batched xsk interfaces for the Tx path in the i40e driver > > to improve performance. On my machine, this yields a throughpu

[PATCH net-next] net: udp: introduce UDP_MIB_MEMERRORS for udp_mem

2020-11-04 Thread menglong8 . dong
From: Menglong Dong When udp_memory_allocated is at the limit, __udp_enqueue_schedule_skb will return a -ENOBUFS, and skb will be dropped in __udp_queue_rcv_skb without any counters being done. It's hard to find out what happened once this happen. So we introduce a UDP_MIB_MEMERRORS to do this j

Re: [PATCH 09/10] thunderbolt: Add DMA traffic test driver

2020-11-04 Thread Mika Westerberg
On Wed, Nov 04, 2020 at 08:38:10PM +0200, Yehezkel Bernat wrote: > On Wed, Nov 4, 2020 at 4:00 PM Mika Westerberg > wrote: > > > > +#define DMA_TEST_DATA_PATTERN 0x0123456789abcdefLL > > Have you considered making it configurable? For mem test, for example, there > is > a reason to try

Re: Very slow realtek 8169 ethernet performance, but only one interface, on ThinkPad T14.

2020-11-04 Thread Heiner Kallweit
On 05.11.2020 03:48, Qu Wenruo wrote: > Hi, > > Not sure if this is a regression or not, but just find out that after > upgrading to v5.9 kernel, one of my ethernet port on my ThinkPad T14 (ryzen > version) becomes very slow. > > Only *2~3* Mbps. > > The laptop has two ethernet interfaces, one

Re: [PATCH net-next v2] net: sched: implement action-specific terse dump

2020-11-04 Thread Cong Wang
On Wed, Nov 4, 2020 at 4:39 PM Jakub Kicinski wrote: > > On Mon, 2 Nov 2020 22:12:43 +0200 Vlad Buslov wrote: > > Allow user to request action terse dump with new flag value > > TCA_FLAG_TERSE_DUMP. Only output essential action info in terse dump (kind, > > stats, index and cookie, if set by the

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-11-04 Thread Yunsheng Lin
On 2020/11/5 14:16, Cong Wang wrote: > On Wed, Nov 4, 2020 at 10:04 PM Cong Wang wrote: >> >> On Mon, Nov 2, 2020 at 11:24 PM Yunsheng Lin wrote: > From my understanding, we can do anything about the old qdisc (including > destorying the old qdisc) after some_qdisc_is_busy() return false.

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-11-04 Thread Yunsheng Lin
On 2020/11/5 14:04, Cong Wang wrote: > On Mon, Nov 2, 2020 at 11:24 PM Yunsheng Lin wrote: From my understanding, we can do anything about the old qdisc (including destorying the old qdisc) after some_qdisc_is_busy() return false. >>> >>> But the current code does the reset _before_ some

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-11-04 Thread Cong Wang
On Wed, Nov 4, 2020 at 10:04 PM Cong Wang wrote: > > On Mon, Nov 2, 2020 at 11:24 PM Yunsheng Lin wrote: > > >> From my understanding, we can do anything about the old qdisc (including > > >> destorying the old qdisc) after some_qdisc_is_busy() return false. > > > > > > But the current code does

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-11-04 Thread Cong Wang
On Mon, Nov 2, 2020 at 11:24 PM Yunsheng Lin wrote: > >> From my understanding, we can do anything about the old qdisc (including > >> destorying the old qdisc) after some_qdisc_is_busy() return false. > > > > But the current code does the reset _before_ some_qdisc_is_busy(). ;) > > If lock is tak

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-04 Thread Saeed Mahameed
On Wed, 2020-11-04 at 17:57 +0530, George Cherian wrote: > Add health reporters for RVU NPA block. ^^^ NIX ? Cc: Jiri Anyway, could you please spare some words on what is NPA and what is NIX? Regarding the reporters names, all drivers register well known generic n

Re: [PATCH net 1/2] ibmvnic: notify peers when failover and migration happen

2020-11-04 Thread drt
On 2020-10-30 13:27, Jakub Kicinski wrote: On Wed, 28 Oct 2020 00:57:41 -0500 Lijun Pan wrote: We need to notify peers only when failover and migration happen. It is unnecessary to call that in other events like FATAL, NON_FATAL, CHANGE_PARAM, and TIMEOUT resets since in those scenarios the MAC

[RFC PATCH bpf-next 1/5] bpf: add in-kernel split BTF support

2020-11-04 Thread Andrii Nakryiko
Adjust in-kernel BTF implementation to support a split BTF mode of operation. Changes are mostly mirroring libbpf split BTF changes, with the exception of start_id being 0 for in-kernel implementation due to simpler read-only mode. Otherwise, for split BTF logic, most of the logic of jumping to ba

[RFC PATCH bpf-next 3/5] kbuild: Add CONFIG_DEBUG_INFO_BTF_MODULES option or module BTFs

2020-11-04 Thread Andrii Nakryiko
Add Kconfig option to generate kernel module split BTFs, if pahole's version support it. Kernel module BTF has to be re-grenerated if either vmlinux's BTF changes or .ko changes. To achieve that, I needed a helper similar to if_changed, but that would allow to filter out vmlinux from the list of up

[RFC PATCH bpf-next 5/5] tools/bpftool: add support for in-kernel and named BTF in `btf show`

2020-11-04 Thread Andrii Nakryiko
Display vmlinux BTF name and kernel module names when listing available BTFs on the system. In human-readable output mode, module BTFs are reported with "name [module-name]", while vmlinux BTF is reported as "name [vmlinux]". vmlinux BTF, as returned from the kernel, has an empty name. Square brac

[RFC PATCH bpf-next 2/5] bpf: assign ID to vmlinux BTF and return extra info for BTF in GET_OBJ_INFO

2020-11-04 Thread Andrii Nakryiko
Allocate ID for vmlinux BTF. This makes it visible when iterating over all BTF objects in the system. To allow distinguishing vmlinux BTF (and later kernel module BTF) from user-provided BTFs, expose extra kernel_btf flag, as well as BTF name (empty for vmlinux BTF, but will be used for kernel modu

[RFC PATCH bpf-next 4/5] bpf: load and verify kernel module BTFs

2020-11-04 Thread Andrii Nakryiko
Add kernel module listener that will load/validate and unload module BTF. Module BTFs gets ID generated for them, which makes it possible to iterate them with existing BTF iteration API. They are given their respective module's names, which will get reported through GET_OBJ_INFO API. They are also

[RFC PATCH bpf-next 0/5] Integrate kernel module BTF support

2020-11-04 Thread Andrii Nakryiko
This patch set adds BTF generation for kernel modules using a compact split BTF approach. Respective patches have all the details. New Kconfig CONFIG_DEBUG_INTO_BTF_MODULES is added, which is defaulted to y, but is conditional on pahole v1.19 version, which is going to have a support for --btf_bas

Re: [net 05/27] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

2020-11-04 Thread Vincent MAILHOL
On Wed, 5 Nov 2020 02:46, Oliver Hartkopp wrote: > On 04.11.20 17:02, Jakub Kicinski wrote: >> On Wed, 4 Nov 2020 15:59:25 +0100 Oliver Hartkopp wrote: >>> On 04.11.20 09:16, Eric Dumazet wrote: > So skb_orphan(skb) in CAN before calling netif_rx() is better IMO. >>> >>> Unfortunately you

[PATCH v2 bpf-next 11/11] tools/bpftool: add bpftool support for split BTF

2020-11-04 Thread Andrii Nakryiko
Add ability to work with split BTF by providing extra -B flag, which allows to specify the path to the base BTF file. Acked-by: Song Liu Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/btf.c | 9 ++--- tools/bpf/bpftool/main.c | 15 ++- tools/bpf/bpftool/main.h | 1 + 3

[PATCH v2 bpf-next 03/11] libbpf: unify and speed up BTF string deduplication

2020-11-04 Thread Andrii Nakryiko
From: Andrii Nakryiko Revamp BTF dedup's string deduplication to match the approach of writable BTF string management. This allows to transfer deduplicated strings index back to BTF object after deduplication without expensive extra memory copying and hash map re-construction. It also simplifies

[PATCH v2 bpf-next 00/11] libbpf: split BTF support

2020-11-04 Thread Andrii Nakryiko
This patch set adds support for generating and deduplicating split BTF. This is an enhancement to the BTF, which allows to designate one BTF as the "base BTF" (e.g., vmlinux BTF), and one or more other BTFs as "split BTF" (e.g., kernel module BTF), which are building upon and extending base BTF wit

[PATCH v2 bpf-next 07/11] libbpf: fix BTF data layout checks and allow empty BTF

2020-11-04 Thread Andrii Nakryiko
Make data section layout checks stricter, disallowing overlap of types and strings data. Additionally, allow BTFs with no type data. There is nothing inherently wrong with having BTF with no types (put potentially with some strings). This could be a situation with kernel module BTFs, if module doe

[PATCH v2 bpf-next 09/11] libbpf: accomodate DWARF/compiler bug with duplicated identical arrays

2020-11-04 Thread Andrii Nakryiko
In some cases compiler seems to generate distinct DWARF types for identical arrays within the same CU. That seems like a bug, but it's already out there and breaks type graph equivalence checks, so accommodate it anyway by checking for identical arrays, regardless of their type ID. Acked-by: Song

[PATCH v2 bpf-next 06/11] selftests/bpf: add checking of raw type dump in BTF writer APIs selftests

2020-11-04 Thread Andrii Nakryiko
From: Andrii Nakryiko Add re-usable btf_helpers.{c,h} to provide BTF-related testing routines. Start with adding a raw BTF dumping helpers. Raw BTF dump is the most succinct and at the same time a very human-friendly way to validate exact contents of BTF types. Cross-validate raw BTF dump and wr

[PATCH v2 bpf-next 05/11] selftests/bpf: add split BTF basic test

2020-11-04 Thread Andrii Nakryiko
Add selftest validating ability to programmatically generate and then dump split BTF. Acked-by: Song Liu Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/btf_split.c | 99 +++ tools/testing/selftests/bpf/test_progs.h | 11 +++ 2 files changed, 110 insert

[PATCH v2 bpf-next 08/11] libbpf: support BTF dedup of split BTFs

2020-11-04 Thread Andrii Nakryiko
Add support for deduplication split BTFs. When deduplicating split BTF, base BTF is considered to be immutable and can't be modified or adjusted. 99% of BTF deduplication logic is left intact (module some type numbering adjustments). There are only two differences. First, each type in base BTF get

[PATCH v2 bpf-next 10/11] selftests/bpf: add split BTF dedup selftests

2020-11-04 Thread Andrii Nakryiko
Add selftests validating BTF deduplication for split BTF case. Add a helper macro that allows to validate entire BTF with raw BTF dump, not just type-by-type. This saves tons of code and complexity. Acked-by: Song Liu Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/btf_helpers.c

[PATCH v2 bpf-next 04/11] libbpf: implement basic split BTF support

2020-11-04 Thread Andrii Nakryiko
Support split BTF operation, in which one BTF (base BTF) provides basic set of types and strings, while another one (split BTF) builds on top of base's types and strings and adds its own new types and strings. From API standpoint, the fact that the split BTF is built on top of the base BTF is trans

[PATCH v2 bpf-next 02/11] selftest/bpf: relax btf_dedup test checks

2020-11-04 Thread Andrii Nakryiko
Remove the requirement of a strictly exact string section contents. This used to be true when string deduplication was done through sorting, but with string dedup done through hash table, it's no longer true. So relax test harness to relax strings checks and, consequently, type checks, which now do

[PATCH v2 bpf-next 01/11] libbpf: factor out common operations in BTF writing APIs

2020-11-04 Thread Andrii Nakryiko
Factor out commiting of appended type data. Also extract fetching the very last type in the BTF (to append members to). These two operations are common across many APIs and will be easier to refactor with split BTF, if they are extracted into a single place. Acked-by: Song Liu Signed-off-by: Andr

[PATCH] page_frag: Recover from memory pressure

2020-11-04 Thread Matthew Wilcox (Oracle)
When the machine is under extreme memory pressure, the page_frag allocator signals this to the networking stack by marking allocations with the 'pfmemalloc' flag, which causes non-essential packets to be dropped. Unfortunately, even after the machine recovers from the low memory condition, the page

Re: [PATCH net-next] sctp: bring inet(6)_skb_parm back to sctp_input_cb

2020-11-04 Thread Marcelo Ricardo Leitner
On Wed, Nov 04, 2020 at 02:55:32PM +0800, Xin Long wrote: > inet(6)_skb_parm was removed from sctp_input_cb by Commit a1dd2cf2f1ae > ("sctp: allow changing transport encap_port by peer packets"), as it > thought sctp_input_cb->header is not used any more in SCTP. > > syzbot reported a crash: > >

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-04 Thread David Ahern
On 11/4/20 1:43 PM, Andrii Nakryiko wrote: > > What users writing BPF programs can expect from iproute2 in terms of > available BPF features is what matters. And by not enforcing a > specific minimal libbpf version, iproute2 version doesn't matter all > that much, because libbpf version that iprou

Re: [PATCH v2 0/3] wireless: convert tasklets to use new

2020-11-04 Thread Allen Pais
This series converts the remaining drivers to use new tasklet_setup() API. The patches are based on wireless-drivers-next (c2568c8c9e63) Is this series queue? I haven't seen any email. This is the last series as part of the tasklet conversion effort. They are queued in linux-wireless patch

Re: [PATCH v8 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-11-04 Thread Andrea Parri
On Wed, Nov 04, 2020 at 01:45:05PM -0800, Jakub Kicinski wrote: > On Wed, 4 Nov 2020 13:43:48 -0800 Jakub Kicinski wrote: > > On Wed, 4 Nov 2020 16:40:27 +0100 Andrea Parri (Microsoft) wrote: > > > From: Andres Beltran > > > > > > Currently, pointers to guest memory are passed to Hyper-V as > >

Re: [PATCH bpf-next 1/2] selftest/bpf: add missed ip6ip6 test back

2020-11-04 Thread Hangbin Liu
On Wed, Nov 04, 2020 at 10:40:34AM -0800, Martin KaFai Lau wrote: > > + check $TYPE > > + config_device > > + add_ipip6tnl_tunnel > > + ip link set dev veth1 mtu 1500 > > + attach_bpf $DEV ipip6_set_tunnel ipip6_get_tunnel > From looking at the ipip6_set_tunnel in test_tunnel_kern.c. > I

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-04 Thread David Ahern
On 11/4/20 3:21 AM, Daniel Borkmann wrote: > >> Then libbpf release process can incorporate proper testing of libbpf >> and iproute2 combination. >> Or iproute2 should stay as-is with obsolete bpf support. >> >> Few years from now the situation could be different and shared libbpf >> would >> be t

Re: [PATCH v3 net-next 07/21] net: usb: aqc111: Add support for getting and setting of MAC address

2020-11-04 Thread Anant Thazhemadam
Hi, I only recently browsed through the code, and had some queries regarding the changes introduced by this commit. On 21/11/18 3:43 pm, Igor Russkikh wrote: > From: Dmitry Bezrukov > > Signed-off-by: Dmitry Bezrukov > Signed-off-by: Igor Russkikh > --- > drivers/net/usb/aqc111.c | 47 +++

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-04 Thread Florian Fainelli
On 11/3/2020 9:35 AM, Dan Murphy wrote: > Andrew > > On 11/3/20 11:18 AM, Andrew Lunn wrote: >> On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote: >>> Andrew >>> >>> On 10/30/20 3:15 PM, Andrew Lunn wrote: > +static int dp83td510_config_init(struct phy_device *phydev) > +{

Very slow realtek 8169 ethernet performance, but only one interface, on ThinkPad T14.

2020-11-04 Thread Qu Wenruo
Hi, Not sure if this is a regression or not, but just find out that after upgrading to v5.9 kernel, one of my ethernet port on my ThinkPad T14 (ryzen version) becomes very slow. Only *2~3* Mbps. The laptop has two ethernet interfaces, one needs a passive adapter, the other one is a standard R

Re: [PATCH net-next v3 1/4] ethtool: Add 10base-T1L link mode entries

2020-11-04 Thread Florian Fainelli
On 10/30/2020 10:29 AM, Dan Murphy wrote: > Add entries for the 10base-T1L full and half duplex supported modes. > > $ ethtool eth0 > Supported ports: [ TP ] > Supported link modes: 10baseT1L/Half 10baseT1L/Full > Supported pause frame use: Symmetric Receive-only >

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-04 Thread David Ahern
On 11/4/20 2:28 AM, Jiri Benc wrote: > On Tue, 3 Nov 2020 18:45:59 -0800, Alexei Starovoitov wrote: >> libbpf is the only library I know that is backward and forward compatible. > > This is great to hear. It means there will be no problem with iproute2 > using the system libbpf. As libbpf is both

Re: [PATCHv3 iproute2-next 3/5] lib: add libbpf support

2020-11-04 Thread David Ahern
On 11/4/20 1:22 AM, Hangbin Liu wrote: > If we move this #ifdef HAVE_LIBBPF to bpf_legacy.c, we need to rename > them all. With current patch, we limit all the legacy functions in bpf_legacy > and doesn't mix them with libbpf.h. What do you think? Let's rename conflicts with a prefix -- like legac

Re: [RESEND PATCH v3] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

2020-11-04 Thread Anant Thazhemadam
On 05/11/20 5:54 am, Jakub Kicinski wrote: > On Mon, 2 Nov 2020 23:09:46 +0530 Anant Thazhemadam wrote: >> Currently, __usbnet_{read|write}_cmd() use usb_control_msg(). >> However, this could lead to potential partial reads/writes being >> considered valid, and since most of the callers of >> us

Re: [PATCH] compiler-clang: remove version check for BPF Tracing

2020-11-04 Thread Miguel Ojeda
On Wed, Nov 4, 2020 at 8:11 PM Nick Desaulniers wrote: > > bpftrace parses the kernel headers and uses Clang under the hood. Remove > the version check when __BPF_TRACING__ is defined (as bpftrace does) so > that this tool can continue to parse kernel headers, even with older > clang sources. Ack

Re: [PATCH net-next 0/8] Netfilter updates for net-next

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 15:11:41 +0100 Pablo Neira Ayuso wrote: > 1) Move existing bridge packet reject infra to nf_reject_{ipv4,ipv6}.c >from Jose M. Guisado. > > 2) Consolidate nft_reject_inet initialization and dump, also from Jose. > > 3) Add the netdev reject action, from Jose. > > 4) Allow

[PATCH v2] net: macvlan: remove redundant initialization in macvlan_dev_netpoll_setup

2020-11-04 Thread menglong8 . dong
From: Menglong Dong The initialization for err with 0 seems useless, as it is soon updated with -ENOMEM. So, we can remove it. Changes since v1: -Keep -ENOMEM still. Signed-off-by: Menglong Dong --- drivers/net/macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

Re: [PATCH net-next v2 0/7] mptcp: Miscellaneous MPTCP fixes

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 11:05:02 -0800 Mat Martineau wrote: > This is a collection of small fixup and minor enhancement patches that > have accumulated in the MPTCP tree while net-next was closed. These are > prerequisites for larger changes we have queued up. > > Patch 1 refines receive buffer autotu

Re: [PATCH net] r8169: work around short packet hw bug on RTL8125

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 18:52:18 +0100 Heiner Kallweit wrote: > Network problems with RTL8125B have been reported [0] and with help > from Realtek it turned out that this chip version has a hw problem > with short packets (similar to RTL8168evl). Having said that activate > the same workaround as for RT

Re: [PATCH net-next] enetc: Remove Tx checksumming offload code

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 16:02:13 +0200 Claudiu Manoil wrote: > Tx checksumming has been defeatured and completely removed > from the h/w reference manual. Made a little cleanup for the > TSE case as this is complementary code. > > Signed-off-by: Claudiu Manoil Applied, thanks!

Re: [PATCH V2] fsl/fman: add missing put_devcie() call in fman_port_probe()

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 19:23:23 +0800 Yu Kuai wrote: > --- a/drivers/net/ethernet/freescale/fman/fman_port.c > +++ b/drivers/net/ethernet/freescale/fman/fman_port.c > @@ -1792,20 +1792,21 @@ static int fman_port_probe(struct platform_device > *of_dev) > if (!fm_node) { > dev_err(po

Re: [PATCH -next] dpaa_eth: use false and true for bool variables

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 12:13:29 + Madalin Bucur wrote: > > Fix coccicheck warnings: > > > > ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable > > ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable > > > > Reported-by: Hulk Robot > > Signed-off-by: Zou Wei > >

Re: [PATCH net-next 6/6] ionic: useful names for booleans

2020-11-04 Thread Saeed Mahameed
On Wed, 2020-11-04 at 14:33 -0800, Shannon Nelson wrote: > With a few more uses of true and false in function calls, we > need to give them some useful names so we can tell from the > calling point what we're doing. > Aha! The root cause of the issue is passing booleans to functions in first plac

Re: [PATCH net-next 5/6] ionic: use mc sync for multicast filters

2020-11-04 Thread Saeed Mahameed
On Wed, 2020-11-04 at 14:33 -0800, Shannon Nelson wrote: > We should be using the multicast sync routines for the > multicast filters. > > Fixes: 1800eee16676 ("net: ionic: Replace in_interrupt() usage.") > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/ionic_lif.c | 1

Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 16:17:03 +0530 Vinay Kumar Yadav wrote: > user can initialize tls ulp using setsockopt call on socket > before listen() in case of tls-toe (TLS_HW_RECORD) and same > setsockopt call on connected socket in case of kernel tls (TLS_SW). > In presence of tls-toe devices, TLS ulp is

[PATCH v22 20/23] Audit: Add new record for multiple process LSM attributes

2020-11-04 Thread Casey Schaufler
Create a new audit record type to contain the subject information when there are multiple security modules that require such data. This record is linked with the same timestamp and serial number using the audit_alloc_local() mechanism. The record is produced only in cases where there is more than o

[PATCH v22 17/23] NET: Store LSM netlabel data in a lsmblob

2020-11-04 Thread Casey Schaufler
Netlabel uses LSM interfaces requiring an lsmblob and the internal storage is used to pass information between these interfaces, so change the internal data from a secid to a lsmblob. Update the netlabel interfaces and their callers to accommodate the change. This requires that the modules using ne

Re: [PATCH net-next 4/6] ionic: batch rx buffer refilling

2020-11-04 Thread Saeed Mahameed
On Wed, 2020-11-04 at 14:33 -0800, Shannon Nelson wrote: > We don't need to refill the rx descriptors on every napi > if only a few were handled. Waiting until we can batch up > a few together will save us a few Rx cycles. > > Signed-off-by: Shannon Nelson > --- > .../net/ethernet/pensando/ioni

[PATCH v22 16/23] LSM: security_secid_to_secctx in netlink netfilter

2020-11-04 Thread Casey Schaufler
Change netlink netfilter interfaces to use lsmcontext pointers, and remove scaffolding. Reviewed-by: Kees Cook Reviewed-by: John Johansen Acked-by: Stephen Smalley Signed-off-by: Casey Schaufler Cc: netdev@vger.kernel.org Cc: netfilter-de...@vger.kernel.org --- net/netfilter/nfnetlink_queue.c

Re: [PATCH net-next v2 1/2][RESEND] net: phy: adin: disable diag clock & disable standby mode in config_aneg

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 09:44:35 +0200 Alexandru Ardelean wrote: > When the PHY powers up, the diagnostics clock isn't enabled (bit 2 in > register PHY_CTRL_1 (0x0012)). > Also, the PHY is not in standby mode, so bit 13 in PHY_CTRL_3 (0x0017) is > always set at power up. > > The standby mode and the di

[PATCH v22 14/23] LSM: Use lsmcontext in security_secid_to_secctx

2020-11-04 Thread Casey Schaufler
Replace the (secctx,seclen) pointer pair with a single lsmcontext pointer to allow return of the LSM identifier along with the context and context length. This allows security_release_secctx() to know how to release the context. Callers have been modified to use or save the returned data from the n

Re: [RFC 6/9] staging: dpaa2-switch: add .ndo_start_xmit() callback

2020-11-04 Thread Andrew Lunn
> +static int dpaa2_switch_build_single_fd(struct ethsw_core *ethsw, > + struct sk_buff *skb, > + struct dpaa2_fd *fd) > +{ > + struct device *dev = ethsw->dev; > + struct sk_buff **skbh; > + dma_addr_t addr; > +

[PATCH v22 13/23] LSM: Ensure the correct LSM context releaser

2020-11-04 Thread Casey Schaufler
Add a new lsmcontext data structure to hold all the information about a "security context", including the string, its size and which LSM allocated the string. The allocation information is necessary because LSMs have different policies regarding the lifecycle of these strings. SELinux allocates and

Re: [PATCH net-next 00/16] selftests: net: bridge: add tests for MLDv2

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 19:23:56 +0200 Nikolay Aleksandrov wrote: > This is the second selftests patch-set for the new multicast functionality > which adds tests for the bridge's MLDv2 support. The tests use full > precooked packets which are sent via mausezahn and the resulting state > after each test

[PATCH v22 08/23] LSM: Use lsmblob in security_task_getsecid

2020-11-04 Thread Casey Schaufler
Change the security_task_getsecid() interface to fill in a lsmblob structure instead of a u32 secid in support of LSM stacking. Audit interfaces will need to collect all possible secids for possible reporting. Reviewed-by: Kees Cook Reviewed-by: John Johansen Acked-by: Stephen Smalley Acked-by:

[PATCH v22 06/23] LSM: Use lsmblob in security_secid_to_secctx

2020-11-04 Thread Casey Schaufler
Change security_secid_to_secctx() to take a lsmblob as input instead of a u32 secid. It will then call the LSM hooks using the lsmblob element allocated for that module. The callers have been updated as well. This allows for the possibility that more than one module may be called upon to translate

Re: [PATCH] compiler-clang: remove version check for BPF Tracing

2020-11-04 Thread Nathan Chancellor
On Wed, Nov 04, 2020 at 11:10:51AM -0800, Nick Desaulniers wrote: > bpftrace parses the kernel headers and uses Clang under the hood. Remove > the version check when __BPF_TRACING__ is defined (as bpftrace does) so > that this tool can continue to parse kernel headers, even with older > clang sourc

[PATCH v22 05/23] LSM: Use lsmblob in security_secctx_to_secid

2020-11-04 Thread Casey Schaufler
Change the security_secctx_to_secid interface to use a lsmblob structure in place of the single u32 secid in support of module stacking. Change its callers to do the same. The security module hook is unchanged, still passing back a secid. The infrastructure passes the correct entry from the lsmblo

Re: [PATCH] compiler-clang: remove version check for BPF Tracing

2020-11-04 Thread Andrew Morton
On Wed, 4 Nov 2020 11:10:51 -0800 Nick Desaulniers wrote: > bpftrace parses the kernel headers and uses Clang under the hood. Remove > the version check when __BPF_TRACING__ is defined (as bpftrace does) so > that this tool can continue to parse kernel headers, even with older > clang sources.

Re: [PATCH net-next 3/6] ionic: add lif quiesce

2020-11-04 Thread Saeed Mahameed
On Wed, 2020-11-04 at 14:33 -0800, Shannon Nelson wrote: > After the queues are stopped, expressly quiesce the lif. > This assures that even if the queues were in an odd state, > the firmware will close up everything cleanly. > > Signed-off-by: Shannon Nelson > --- > .../net/ethernet/pensando/io

Re: [RFC 5/9] staging: dpaa2-switch: handle Rx path on control interface

2020-11-04 Thread Andrew Lunn
> +/* Manage all NAPI instances for the control interface. > + * > + * We only have one RX queue and one Tx Conf queue for all > + * switch ports. Therefore, we only need to enable the NAPI instance once, > the > + * first time one of the switch ports runs .dev_open(). > + */ > + > +static void dp

Re: [PATCH v3 net-next] net: dsa: mt7530: support setting MTU

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 13:06:18 +0800 DENG Qingfang wrote: > MT7530/7531 has a global RX packet length register, which can be used > to set MTU. > > Supported packet length values are 1522 (1518 if untagged), 1536, > 1552, and multiple of 1024 (from 2048 to 15360). > > Signed-off-by: DENG Qingfang

Re: [net-next 09/12] net/mlx5e: Validate stop_room size upon user input

2020-11-04 Thread Saeed Mahameed
On Wed, 2020-11-04 at 14:02 -0800, Jakub Kicinski wrote: > On Tue, 3 Nov 2020 11:47:35 -0800 Saeed Mahameed wrote: > > From: Vladyslav Tarasiuk > > > > Stop room is a space that may be taken by WQEs in the SQ during a > > packet > > transmit. It is used to check if next packet has enough room in

Re: [PATCH net-next v2] net: sched: implement action-specific terse dump

2020-11-04 Thread Jakub Kicinski
On Mon, 2 Nov 2020 22:12:43 +0200 Vlad Buslov wrote: > Allow user to request action terse dump with new flag value > TCA_FLAG_TERSE_DUMP. Only output essential action info in terse dump (kind, > stats, index and cookie, if set by the user when creating the action). This > is different from filter

Re: [PATCH net-next 3/3] ptp: idt82p33: optimize _idt82p33_adjfine

2020-11-04 Thread Vladimir Oltean
On Wed, Nov 04, 2020 at 08:46:57AM -0800, Richard Cochran wrote: > On Wed, Nov 04, 2020 at 11:01:49AM -0500, min.li...@renesas.com wrote: > > From: Min Li > > > > Use div_s64 so that the neg_adj is not needed. > > Back in the day, I coded the neg_adj because there was some issue with > signed 64 b

[PATCH v3 net-next 3/3] ptp: idt82p33: optimize _idt82p33_adjfine

2020-11-04 Thread min.li.xe
From: Min Li Use div_s64 so that the neg_adj is not needed. Signed-off-by: Min Li Acked-by: Richard Cochran --- drivers/ptp/ptp_idt82p33.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c index b1528a0..e970

Re: [PATCH net-next 0/6] net: ipa: tell GSI the IPA version

2020-11-04 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:53:54 -0600 Alex Elder wrote: > The GSI code that supports IPA avoids having knowledge about the > IPA layer it serves. One result of this is that Boolean flags are > used during GSI initialization to convey that certain hardware > version-dependent special behaviors should

[PATCH v3 net-next 1/3] ptp: idt82p33: add adjphase support

2020-11-04 Thread min.li.xe
From: Min Li Add idt82p33_adjphase() to support PHC write phase mode. Changes since v1: -Fix broken build Changes since v2: -Fix trailing space Signed-off-by: Min Li Acked-by: Richard Cochran --- drivers/ptp/ptp_idt82p33.c | 222 - drivers/ptp/pt

[PATCH v3 net-next 2/3] ptp: idt82p33: use i2c_master_send for bus write

2020-11-04 Thread min.li.xe
From: Min Li Refactor idt82p33_xfer and use i2c_master_send for write operation. Because some I2C controllers are only working with single-burst write transaction. Changes since v1: - Fix broken build. Signed-off-by: Min Li Acked-by: Richard Cochran --- drivers/ptp/ptp_idt82p33.c | 50 +

Re: [PATCH] compiler-clang: remove version check for BPF Tracing

2020-11-04 Thread Song Liu
> On Nov 4, 2020, at 12:33 PM, Jarkko Sakkinen wrote: > > On Wed, Nov 04, 2020 at 11:10:51AM -0800, Nick Desaulniers wrote: >> bpftrace parses the kernel headers and uses Clang under the hood. Remove >> the version check when __BPF_TRACING__ is defined (as bpftrace does) so >> that this tool c

Re: [RESEND PATCH v3] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

2020-11-04 Thread Jakub Kicinski
On Mon, 2 Nov 2020 23:09:46 +0530 Anant Thazhemadam wrote: > Currently, __usbnet_{read|write}_cmd() use usb_control_msg(). > However, this could lead to potential partial reads/writes being > considered valid, and since most of the callers of > usbnet_{read|write}_cmd() don't take partial reads/wr

Re: [PATCH net-next v2 06/19] net: phy: mscc: use phy_trigger_machine() to notify link change

2020-11-04 Thread Vladimir Oltean
On Sun, Nov 01, 2020 at 02:51:01PM +0200, Ioana Ciornei wrote: > From: Ioana Ciornei > > According to the comment describing the phy_mac_interrupt() function, it > it intended to be used by MAC drivers which have noticed a link change > thus its use in the mscc PHY driver is improper and, most pr

Re: [PATCH net-next v2 07/19] net: phy: mscc: implement generic .handle_interrupt() callback

2020-11-04 Thread Vladimir Oltean
On Sun, Nov 01, 2020 at 02:51:02PM +0200, Ioana Ciornei wrote: > From: Ioana Ciornei > > In an attempt to actually support shared IRQs in phylib, we now move the > responsibility of triggering the phylib state machine or just returning > IRQ_NONE, based on the IRQ status register, to the PHY driv

Re: [PATCH net-next v2 08/19] net: phy: mscc: remove the use of .ack_interrupt()

2020-11-04 Thread Vladimir Oltean
On Sun, Nov 01, 2020 at 02:51:03PM +0200, Ioana Ciornei wrote: > From: Ioana Ciornei > > In preparation of removing the .ack_interrupt() callback, we must replace > its occurrences (aka phy_clear_interrupt), from the 2 places where it is > called from (phy_enable_interrupts and phy_disable_interr

[PATCH v22 14/23] LSM: Use lsmcontext in security_secid_to_secctx

2020-11-04 Thread Casey Schaufler
Replace the (secctx,seclen) pointer pair with a single lsmcontext pointer to allow return of the LSM identifier along with the context and context length. This allows security_release_secctx() to know how to release the context. Callers have been modified to use or save the returned data from the n

[PATCH v22 13/23] LSM: Ensure the correct LSM context releaser

2020-11-04 Thread Casey Schaufler
Add a new lsmcontext data structure to hold all the information about a "security context", including the string, its size and which LSM allocated the string. The allocation information is necessary because LSMs have different policies regarding the lifecycle of these strings. SELinux allocates and

[PATCH v22 08/23] LSM: Use lsmblob in security_task_getsecid

2020-11-04 Thread Casey Schaufler
Change the security_task_getsecid() interface to fill in a lsmblob structure instead of a u32 secid in support of LSM stacking. Audit interfaces will need to collect all possible secids for possible reporting. Reviewed-by: Kees Cook Reviewed-by: John Johansen Acked-by: Stephen Smalley Acked-by:

Re: [PATCH bpf-next 04/11] libbpf: implement basic split BTF support

2020-11-04 Thread Andrii Nakryiko
On Mon, Nov 2, 2020 at 9:41 PM Song Liu wrote: > > > > > On Nov 2, 2020, at 9:02 PM, Andrii Nakryiko > > wrote: > > > > On Mon, Nov 2, 2020 at 3:24 PM Song Liu wrote: > >> > >> > >> > >>> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote: > >>> > >> > >> [...] > >> > >>> > >>> BTF deduplicati

Re: [PATCH v2 net-next 1/3] ptp: idt82p33: add adjphase support

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 18:13:44 -0500 min.li...@renesas.com wrote: > From: Min Li > > Add idt82p33_adjphase() to support PHC write phase mode. > > Changes since v1: > -Fix broken build One more trivial thing detected by checkpatch: ERROR: trailing whitespace #41: FILE: drivers/ptp/ptp_idt82p33.c:1

[PATCH v22 06/23] LSM: Use lsmblob in security_secid_to_secctx

2020-11-04 Thread Casey Schaufler
Change security_secid_to_secctx() to take a lsmblob as input instead of a u32 secid. It will then call the LSM hooks using the lsmblob element allocated for that module. The callers have been updated as well. This allows for the possibility that more than one module may be called upon to translate

[PATCH v22 05/23] LSM: Use lsmblob in security_secctx_to_secid

2020-11-04 Thread Casey Schaufler
Change the security_secctx_to_secid interface to use a lsmblob structure in place of the single u32 secid in support of module stacking. Change its callers to do the same. The security module hook is unchanged, still passing back a secid. The infrastructure passes the correct entry from the lsmblo

Re: [PATCH v3] lan743x: fix for potential NULL pointer dereference with bare card

2020-11-04 Thread Sergej Bauer
On Wednesday, November 4, 2020 4:38:33 AM MSK Jakub Kicinski wrote: > On Mon, 2 Nov 2020 01:35:55 +0300 Sergej Bauer wrote: > > This is the 3rd revision of the patch fix for potential null pointer > > dereference with lan743x card. > > > > The simpliest way to reproduce: boot with bare lan743x an

Re: [PATCH bpf-next 1/6] i40e: introduce lazy Tx completions for AF_XDP zero-copy

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 15:33:20 -0800 Jakub Kicinski wrote: > I feel like this needs a big fat warning somewhere. > > It's perfectly fine to never complete TCP packets, s/TCP/normal XDP/, sorry > but AF_XDP could be used to implement protocols in user space. What > if someone wants to implement some

  1   2   3   4   >