On Wed, 04 Nov 2020, Lee Jones wrote:
> On Tue, 03 Nov 2020, Jakub Kicinski wrote:
>
> > On Mon, 2 Nov 2020 11:44:43 + Lee Jones wrote:
> > > When AIX_EVENT is not defined, the 'if' body will be empty, which
> > > makes GCC complain. Place bracketing around the invocation to protect
> > > i
On Tue, 03 Nov 2020, Jakub Kicinski wrote:
> On Mon, 2 Nov 2020 11:44:43 + Lee Jones wrote:
> > When AIX_EVENT is not defined, the 'if' body will be empty, which
> > makes GCC complain. Place bracketing around the invocation to protect
> > it.
> >
> > Fixes the following W=1 kernel build wa
Marek Behún
> Sent: Wednesday, November 4, 2020 2:03 PM
[...]
> BTW Hayes, is it possible for me gaining access to Realtek
> documentation for these chips under NDA? For example via my employer,
> CZ.NIC? I can't find any such information on Realtek website.
I have to ask my boss.
Maybe I reply
inet(6)_skb_parm was removed from sctp_input_cb by Commit a1dd2cf2f1ae
("sctp: allow changing transport encap_port by peer packets"), as it
thought sctp_input_cb->header is not used any more in SCTP.
syzbot reported a crash:
[ ] BUG: KASAN: use-after-free in decode_session6+0xe7c/0x1580
[ ]
On Wed, 4 Nov 2020 01:57:10 +
Hayes Wang wrote:
> Marek Behún
> > Sent: Wednesday, November 4, 2020 3:22 AM
> > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> > index b1770489aca5..85dda591c838 100644
> > --- a/drivers/net/usb/r8152.c
> > +++ b/drivers/net/usb/r8152.c
> > @
On Tue, 3 Nov 2020 23:47:12 +0200
Vladimir Oltean wrote:
> On Tue, Nov 03, 2020 at 08:22:24PM +0100, Marek Behún wrote:
> > Add pla_ and usb_ prefixed versions of ocp_read_* and ocp_write_*
> > functions. This saves us from always writing MCU_TYPE_PLA/MCU_TYPE_USB
> > as parameter.
> >
> > Signe
From: Kaixu Xia
Fix the gcc warning:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c:2673:9: warning: this 'for'
clause does not guard... [-Wmisleading-indentation]
2673 | for (i = 0; i < n; ++i) \
Reported-by: Tosk Robot
Signed-off-by: Kaixu Xia
---
drivers/net/ethernet/chelsio
On Wed. 4 Nov 2020 10:21, Jakub Kicinski wrote:
> On Tue, 3 Nov 2020 23:06:14 +0100 Marc Kleine-Budde wrote:
>> From: Vincent Mailhol
>>
>> If a driver calls can_get_echo_skb() during a hardware IRQ (which is often,
>> but
>> not always, the case), the 'WARN_ON(in_irq)' in
>> net/core/skbuff.c#s
On Wed, Nov 04, 2020 at 10:17:30AM +0800, Hangbin Liu wrote:
> On Tue, Nov 03, 2020 at 02:55:54PM -0800, Alexei Starovoitov wrote:
> > > The scope of bpf in iproute2 is tiny - a few tc modules (and VRF but it
> > > does not need libbpf) which is a small subset of the functionality and
> > > command
> My untrained eye tells me that in the 'after patch' case (the worse
> one), there are less branch misses, and less cache misses. So by all
> perf metrics, the throughput should be better, but it isn't. What gives?
Maybe the frame has been pushed out of the L1 cache. The classify code
is pulling
On Tue, Nov 03, 2020 at 06:40:44PM -0700, David Ahern wrote:
> On 11/3/20 3:55 PM, Alexei Starovoitov wrote:
> > The bpf support in "tc" command instead of being obviously old and obsolete
> > will be sort-of working with unpredictable delay between released kernel
> > and released iproute2 version
> +config SPI_AX88796C_COMPRESSION
> + bool "SPI transfer compression"
> + default n
> + depends on SPI_AX88796C
> + help
> + Say Y here to enable SPI transfer compression. It saves up
> + to 24 dummy cycles during each transfer which may noticably
> + speed up sho
Support ECM mode based on cdc_ether with relative mii functions,
when CONFIG_USB_RTL8152 is not set, or the device is not supported
by r8152 driver.
Both r8152 and r8153_ecm would check the return value of
rtl8152_get_version() in porbe(). If rtl8152_get_version()
return none zero value, the r8152
On Tue, Nov 03, 2020 at 02:55:54PM -0800, Alexei Starovoitov wrote:
> > The scope of bpf in iproute2 is tiny - a few tc modules (and VRF but it
> > does not need libbpf) which is a small subset of the functionality and
> > commands within the package.
>
> When Hangbin sent this patch set I got exc
Hello:
This series was applied to bpf/bpf-next.git (refs/heads/master):
On Tue, 03 Nov 2020 13:34:48 -0800 you wrote:
> From: Alexander Duyck
>
> Recently a bug was missed due to the fact that test_tcpbpf_user is not a
> part of test_progs. In order to prevent similar issues in the future move
On Tue, Nov 3, 2020 at 3:22 PM Jakub Kicinski wrote:
>
> Applied, but going forward please limit any refactoring and extensions
> to the HDLC code. I thought you are actually using it. If that's not
> the case let's leave the code be, it's likely going to be removed in
> a few years time.
OK. I u
On Tue, Nov 3, 2020 at 4:20 PM Martin KaFai Lau wrote:
>
> On Tue, Nov 03, 2020 at 01:34:40PM -0800, Alexander Duyck wrote:
> > Move the test functionality from test_tcpbpf_user into the test_progs
> > framework so that it will be run any time the test_progs framework is run.
> > This will help to
Hi,
I was testing a simple patch:
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index c6806eef906f..e0cda3a65f28 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -511,6 +511,9 @@ static void dsa_skb_tx_timestamp(struct dsa_slave_priv *p,
struct sk_buff *clone;
unsigned int t
Marek Behún
> Sent: Wednesday, November 4, 2020 3:22 AM
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index b1770489aca5..85dda591c838 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -6862,20 +6862,12 @@ static void rtl8152_disconnect(struct
> usb_i
On Mon, 2 Nov 2020 11:34:35 -0600 Alex Elder wrote:
> With IPA v3.5.1, if IPA aggregation is active at the time an
> underlying GSI channel reset is performed, some special handling
> is required.
>
> There is logic in ipa_endpoint_reset() that arranges for that
> special handling, but it's done
On Mon, 2 Nov 2020 21:58:33 +0530 Vinay Kumar Yadav wrote:
> patch adds a logic to utilize multiple queues to process requests.
> The queue selection logic uses a round-robin distribution technique
> using a counter.
>
> Signed-off-by: Ayush Sawal
> Signed-off-by: Vinay Kumar Yadav
Applied tha
On Mon, 2 Nov 2020 13:46:01 + Colin King wrote:
> From: Colin Ian King
>
> An incorrect sizeof() is being used, sizeof(u64 *) is not correct,
> it should be sizeof(*sq->sqb_ptrs).
>
> Fixes: caa2da34fd25 ("octeontx2-pf: Initialize and config queues")
> Addresses-Coverity: ("Sizeof not porta
On Mon, 2 Nov 2020 12:16:15 + Colin King wrote:
> From: Colin Ian King
>
> The variable err is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
On Mon, 2 Nov 2020 09:38:30 +0100 (CET) Julia Lawall wrote:
> From: kernel test robot
>
> Condition !A || A && B is equivalent to !A || B.
>
> Generated by: scripts/coccinelle/misc/excluded_middle.cocci
>
> Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script")
> CC: Denis E
On Mon, 2 Nov 2020 09:52:07 +0800 Willy Liu wrote:
> Realtek single-port 2.5Gbps Ethernet PHYs are list as below:
> RTL8226-CG: the 1st generation 2.5Gbps single port PHY
> RTL8226B-CG/RTL8221B-CG: the 2nd generation 2.5Gbps single port PHY
> RTL8221B-VB-CG: the 3rd generation 2.5Gbps single port P
On Wed, 4 Nov 2020 01:39:52 + Hayes Wang wrote:
> Jakub Kicinski
> > Sent: Wednesday, November 4, 2020 12:16 AM
> [...]
> > > So no, please do not create such a common file, it is not needed or a
> > > good idea.
> >
> > I wouldn't go that far, PCI subsystem just doesn't want everyone to
On Mon, 2 Nov 2020 00:22:54 +0100 Sebastian Andrzej Siewior wrote:
> This is the in_interrupt() clean for FSL DPAA framework and the two
> users.
>
> The `napi' parameter has been renamed to `sched_napi', the other parts
> are same as in the previous post [0].
>
> [0] https://lkml.kernel.org/r/
Jakub Kicinski
> Sent: Wednesday, November 4, 2020 12:16 AM
[...]
> > So no, please do not create such a common file, it is not needed or a
> > good idea.
>
> I wouldn't go that far, PCI subsystem just doesn't want everyone to add
> IDs to the shared file unless there is a reason.
>
> *Do n
On 11/3/20 3:55 PM, Alexei Starovoitov wrote:
> The bpf support in "tc" command instead of being obviously old and obsolete
> will be sort-of working with unpredictable delay between released kernel
> and released iproute2 version. The iproute2 release that suppose to match
> kernel
> release will
On Mon, 2 Nov 2020 01:35:55 +0300 Sergej Bauer wrote:
> This is the 3rd revision of the patch fix for potential null pointer
> dereference
> with lan743x card.
>
> The simpliest way to reproduce: boot with bare lan743x and issue "ethtool
> ethN"
> commant where ethN is the interface with lan743
On Sun, 1 Nov 2020 23:30:44 +0100 Heiner Kallweit wrote:
> We had to remove flag IRQF_NO_THREAD because it conflicts with shared
> interrupts in case legacy interrupts are used. Following up on the
> linked discussion set IRQF_NO_THREAD if MSI or MSI-X is used, because
> both guarantee that interru
On Sun, 1 Nov 2020 23:23:52 +0100 Heiner Kallweit wrote:
> Lowest number of tx descriptors used in the vendor drivers is 256 in
> r8169. r8101/r8168/r8125 use 1024 what seems to be the hw limit. Stay
> on the safe side and go with 256, same as number of rx descriptors.
>
> Signed-off-by: Heiner Ka
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote:
> From: Guvenc Gulce
>
> Deliver SMCD device information via netlink based
> diagnostic interface.
>
> Signed-off-by: Guvenc Gulce
> Signed-off-by: Karsten Graul
> ---
> include/uapi/linux/smc.h | 2 +
> include/uapi/linux/smc_diag
On Sun, 1 Nov 2020 15:42:13 +0200 Ido Schimmel wrote:
> From: Ido Schimmel
>
> Jiri says:
>
> This is a preparation patchset for follow-up support of boards with
> extended mezzanine (XM), which are going to allow extended (scale-wise)
> router offload.
>
> XM requires a separate set of PRM re
On Sun, 01 Nov 2020 13:16:32 + Alexander Lobakin wrote:
> NETIF_F_GSO_UDP_L4 and NETIF_F_GSO_FRAGLIST allow drivers to offload
> GSO UDP L4. This works well on simple setups, but when any logical
> netdev (e.g. VLAN) is present, kernel stack always performs software
> resegmentation which actua
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote:
> From: Guvenc Gulce
>
> Deliver SMCD Linkgroup information via netlink based
> diagnostic interface.
>
> Signed-off-by: Guvenc Gulce
> Signed-off-by: Karsten Graul
> ---
> include/uapi/linux/smc_diag.h | 7 +++
> net/smc/smc_diag.c
On Tue, 3 Nov 2020 23:06:14 +0100 Marc Kleine-Budde wrote:
> From: Vincent Mailhol
>
> If a driver calls can_get_echo_skb() during a hardware IRQ (which is often,
> but
> not always, the case), the 'WARN_ON(in_irq)' in
> net/core/skbuff.c#skb_release_head_state() might be triggered, under netwo
Thanks for providing the numbers. Do you think that dropping (up to)
7 packets is acceptable?
net.ipv4.tcp_syn_retries = 6
tcp clients wouldn't even get that far leading to connect establish issues.
-rama
On Tue, Nov 03, 2020 at 09:15:41PM +, Matthew Wilcox wrote:
On Tue, Nov 03, 2020 at
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote:
> From: Guvenc Gulce
>
> During link creation add network and ib-device name to
> link structure. This is needed for diagnostic purposes.
>
> When diagnostic information is gathered, we need to traverse
> device, linkgroup and link structur
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote:
> From: Guvenc Gulce
>
> During smc ib-device creation, add network device name to smc
> ib-device structure. Register for netdevice name changes and
> update ib-device accordingly. This is needed for diagnostic purposes.
>
> Signed-off-by:
On Tue, 3 Nov 2020 09:25:49 +0100 Eelco Chaudron wrote:
> Silence suspicious RCU usage warning in ovs_flow_tbl_masks_cache_resize()
> by replacing rcu_dereference() with rcu_dereference_ovsl().
>
> In addition, when creating a new datapath, make sure it's configured under
> the ovs_lock.
>
> Fix
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote:
> From: Guvenc Gulce
>
> Add link counters to the structure of the smc ib device, one counter
> per
> ib port. Increase/decrease the counters as needed in the
> corresponding
> routines.
>
> Signed-off-by: Guvenc Gulce
> Signed-off-by: Kar
On Mon, 2 Nov 2020 11:44:43 + Lee Jones wrote:
> When AIX_EVENT is not defined, the 'if' body will be empty, which
> makes GCC complain. Place bracketing around the invocation to protect
> it.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/fddi/skfp/ecm.c: In function
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
drivers/net/ethernet/ibm/ibmvnic.c
between commit:
1d8504937478 ("powerpc/vnic: Extend "failover pending" window")
from the net tree and commit:
16b5f5ce351f ("ibmvnic: merge do_change_param_reset into do_reset")
On Tue, 2020-11-03 at 09:46 -0800, David Awogbemila wrote:
> From: Catherine Sullivan
>
> During TX, skbs' data addresses are dma_map'ed and passed to the NIC.
> This means that the device can perform DMA directly from these
> addresses
> and the driver does not have to copy the buffer content in
On Tue, Nov 03, 2020 at 01:34:40PM -0800, Alexander Duyck wrote:
> Move the test functionality from test_tcpbpf_user into the test_progs
> framework so that it will be run any time the test_progs framework is run.
> This will help to prevent future test escapes as the individual tests, such
> as t
TUNNEL_GENEVE_OPT is set on tun_flags in struct sw_flow_key when
a packet is coming from a geneve tunnel no matter the size of geneve
option is zero or not. On the other hand, TUNNEL_VXLAN_OPT or
TUNNEL_ERSPAN_OPT is set when the VXLAN or ERSPAN option is available.
Currently, ovs kernel module on
On Tue, 2020-11-03 at 09:46 -0800, David Awogbemila wrote:
> This patch lets the driver reuse buffers that have been freed by the
> networking stack.
>
> In the raw addressing case, this allows the driver avoid allocating
> new
> buffers.
> In the qpl case, the driver can avoid copies.
>
> Signed
On Tue, Nov 03, 2020 at 04:24:30PM +0200, Ido Schimmel wrote:
>
> I have the changes you requested here:
> https://github.com/idosch/ethtool/commit/b34d15839f2662808c566c04eda726113e20ee59
>
> Do you want to integrate it with your nl_parse() rework or should I?
I pushed the combined series to
On Tue, Nov 03, 2020 at 05:57:47PM -0500, Kenny Ho wrote:
> On Tue, Nov 3, 2020 at 4:04 PM Alexei Starovoitov
> wrote:
> >
> > On Tue, Nov 03, 2020 at 02:19:22PM -0500, Kenny Ho wrote:
> > > On Tue, Nov 3, 2020 at 12:43 AM Alexei Starovoitov
> > > wrote:
> > > > On Mon, Nov 2, 2020 at 9:39 PM Ken
> > > /* BUFFER_ALIGN(adr) calculates the number of bytes to the next
> > > alignment. */ -#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32)adr)) %
> > > ALIGNMENT)
> > > +#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((long)adr)) % ALIGNMENT)
> >
> > I can't see any reason to change unsigned type to sign
On Mon, 2 Nov 2020 18:45:10 -0700 David Ahern wrote:
> On 11/1/20 4:39 AM, Ido Schimmel wrote:
> > From: Ido Schimmel
> >
> > The nexthop notification chain is a per-namespace chain and not a global
> > one like the netdev notification chain.
> >
> > Therefore, a single (global) listener cannot
On Sat, 31 Oct 2020 11:10:38 -0700 Xie He wrote:
> The main purpose of this series is the last patch. The previous 4 patches
> are just code clean-ups so that the last patch will not make the code too
> messy. The patches must be applied in sequence.
>
> The receiving code of this driver doesn't s
On Tue, 2020-11-03 at 09:46 -0800, David Awogbemila wrote:
> From: Catherine Sullivan
>
> Add support to use raw dma addresses in the rx path. Due to this new
> support we can alloc a new buffer instead of making a copy.
>
> RX buffers are handed to the networking stack and are
> re-allocated as
On Sat, 31 Oct 2020 04:46:45 -0500 Lijun Pan wrote:
> Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so
> linkwatch_event can run") introduced do_change_param_reset function to
> solve the rtnl lock issue. Majority of the code in do_change_param_reset
> duplicates do_reset. Also, we c
On Tue, Nov 3, 2020 at 4:04 PM Alexei Starovoitov
wrote:
>
> On Tue, Nov 03, 2020 at 02:19:22PM -0500, Kenny Ho wrote:
> > On Tue, Nov 3, 2020 at 12:43 AM Alexei Starovoitov
> > wrote:
> > > On Mon, Nov 2, 2020 at 9:39 PM Kenny Ho wrote:
>
> Sounds like either bpf_lsm needs to be made aware of c
On Tue, Nov 03, 2020 at 03:32:55PM -0700, David Ahern wrote:
> On 11/3/20 10:47 AM, Alexei Starovoitov wrote:
> > since David is deaf to technical arguments,
> It is not that I am "deaf to technical arguments"; you do not like my
> response.
>
> The scope of bpf in iproute2 is tiny - a few tc modu
Am 2020-11-01 13:50, schrieb Ioana Ciornei:
From: Ioana Ciornei
This patch set aims to actually add support for shared interrupts in
phylib and not only for multi-PHY devices. While we are at it,
streamline the interrupt handling in phylib.
For the Broadcom BCM54140:
Tested-by: Michael Walle
On 11/3/20 5:52 AM, Andrea Mayer wrote:
> this selftest is designed for evaluating the new SRv6 End.DT4 behavior
> used, in this example, for implementing IPv4 L3 VPN use cases.
>
> Signed-off-by: Andrea Mayer
> ---
> .../selftests/net/srv6_end_dt4_l3vpn_test.sh | 494 ++
> 1 fi
On Tue, 2020-11-03 at 09:46 -0800, David Awogbemila wrote:
> From: Catherine Sullivan
>
> Add support to describe device for parsing device options. As
> the first device option, add raw addressing.
>
> "Raw Addressing" mode (as opposed to the current "qpl" mode) is an
> operational mode which a
On 11/3/20 5:52 AM, Andrea Mayer wrote:
> Before this patch, a sniffer attached to a VRF used as the receiving
> interface of L3 tunneled packets detects them as malformed packets and
> it complains about that (i.e.: tcpdump shows bogus packets).
>
> The reason is that a tunneled L3 packet does no
On 11/3/20 10:47 AM, Alexei Starovoitov wrote:
> since David is deaf to technical arguments,
It is not that I am "deaf to technical arguments"; you do not like my
response.
The scope of bpf in iproute2 is tiny - a few tc modules (and VRF but it
does not need libbpf) which is a small subset of the
On 11/3/20 10:39 PM, Anant Thazhemadam wrote:
> In both can_rcv(), and canfd_rcv(), when skb->len = 0, cfd->len
> (which is uninitialized) is accessed by pr_warn_once().
>
> Performing the validation check for cfd->len separately, after the
> validation check for skb->len is done, resolves this
On Sat, 2020-10-31 at 10:50 +0800, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
> b/drivers/net/etherne
:19:59 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git
tags/linux-can-fixes-for-5.10-20201103
for you to fetch changes up to ab07ff1c92fa60f29438e655a1b4abab860ed0b6:
can: flexcan: flexcan_remove(): dis
From: Zhang Changzhong
If can_init_proc() fail to create /proc/net/can directory, can_remove_proc()
will trigger a warning:
WARNING: CPU: 6 PID: 7133 at fs/proc/generic.c:672 remove_proc_entry+0x17b0
Kernel panic - not syncing: panic_on_warn set ...
Fix to return early from can_remove_proc() if
From: Oleksij Rempel
For now we have only node name as common rule for all CAN controllers
Signed-off-by: Oleksij Rempel
Reviewed-by: Rob Herring
Link: https://lore.kernel.org/r/20201022075218.11880-2-o.rem...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
.../bindings/net/can/can-contr
From: Yegor Yefremov
The address was wrongly assigned to the PGN field and vice versa.
Signed-off-by: Yegor Yefremov
Link: https://lore.kernel.org/r/20201022083708.8755-1-yegorsli...@googlemail.com
Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Signed-off-by: Marc Kleine-Budde
From: Oleksij Rempel
In order to automate the verification of DT nodes convert
fsl-flexcan.txt to fsl,flexcan.yaml
Signed-off-by: Oleksij Rempel
Reviewed-by: Rob Herring
Link: https://lore.kernel.org/r/20201022075218.11880-3-o.rem...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
.../bi
From: Yegor Yefremov
This patch adds backquotes for code samples.
Signed-off-by: Yegor Yefremov
Link:
https://lore.kernel.org/r/20201026094442.16587-1-yegorsli...@googlemail.com
Signed-off-by: Marc Kleine-Budde
---
Documentation/networking/j1939.rst | 88 +++---
1 fil
From: Yegor Yefremov
Due to naming conflicts, jacd was renamed to j1939acd in:
https://github.com/linux-can/can-utils/pull/199
Signed-off-by: Yegor Yefremov
Link: https://lore.kernel.org/r/20201020081134.3597-1-yegorsli...@googlemail.com
Link: https://github.com/linux-can/can-utils/pull/19
From: Dan Carpenter
These values come from skb->data so Smatch considers them untrusted. I
believe Smatch is correct but I don't have a way to test this.
The usb_if->dev[] array has 2 elements but the index is in the 0-15
range without checks. The cfd->len can be up to 255 but the maximum
vali
From: kernel test robot
drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:176:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 875347fe5756 ("can: mcp25xxfd: add regmap infrastructure")
Signed-off-by: kernel test robot
Link: https
From: Stephane Grosjean
Echo management is driven by PUCAN_MSG_LOOPED_BACK bit, while loopback
frames are identified with PUCAN_MSG_SELF_RECEIVE bit. Those bits are set
for each outgoing frame written to the IP core so that a copy of each one
will be placed into the rx path. Thus,
- when PUCAN_M
From: Zhang Changzhong
When a netdev down event occurs after a successful call to
j1939_sk_bind(), j1939_netdev_notify() can handle it correctly.
But if the netdev already in down state before calling j1939_sk_bind(),
j1939_sk_release() will stay in wait_event_interruptible() blocked
forever. Be
From: Geert Uytterhoeven
The help text for the CAN_ISOTP config symbol uses the acronym "PDU". However,
this acronym is not explained here, nor in Documentation/networking/can.rst.
Expand the acronym to make it easier for users to decide if they need to enable
the CAN_ISOTP option or not.
Sign
From: Stephane Grosjean
Fabian Inostroza has discovered a potential
problem in the hardware timestamp reporting from the PCAN-USB USB CAN interface
(only), related to the fact that a timestamp of an event may precede the
timestamp used for synchronization when both records are part of the same U
From: Joakim Zhang
After double check with Layerscape CAN owner (Pankaj Bansal), confirm that
LS1021A doesn't support ECC feature, so remove FLEXCAN_QUIRK_DISABLE_MECR
quirk.
Fixes: 99b7668c04b27 ("can: flexcan: adding platform specific details for
LS1021A")
Cc: Pankaj Bansal
Signed-off-by: Jo
From: Joakim Zhang
For SoCs with ECC supported, even use FLEXCAN_QUIRK_DISABLE_MECR quirk to
disable non-correctable errors interrupt and freeze mode, had better use
FLEXCAN_QUIRK_SUPPORT_ECC quirk to initialize all memory.
Fixes: cdce844865bea ("can: flexcan: add vf610 support for FlexCAN")
Sig
From: Oleksij Rempel
All user space generated SKBs are owned by a socket (unless injected into the
key via AF_PACKET). If a socket is closed, all associated skbs will be cleaned
up.
This leads to a problem when a CAN driver calls can_put_echo_skb() on a
unshared SKB. If the socket is closed prio
From: Zhang Changzhong
The driver forgets to call clk_disable_unprepare() in error path after
a success calling for clk_prepare_enable().
Fix it by adding a clk_disable_unprepare() in error path.
Signed-off-by: Zhang Changzhong
Link:
https://lore.kernel.org/r/1594973079-27743-1-git-send-email
From: Yegor Yefremov
This patches fixes the syntax an spelling of the j1939 documentation.
Signed-off-by: Yegor Yefremov
Link: https://lore.kernel.org/r/20201020101043.6369-1-yegorsli...@googlemail.com
Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Signed-off-by: Marc Kleine-Bud
During debugging it turned out that some people have setups where the SPI
communication is more prone to CRC errors.
Increase the severity of both the transfer retry and transfer failure message
to give users feedback without the need to recompile the driver with debug
enabled.
Cc: Manivannan Sad
From: Oliver Hartkopp
The can_get_echo_skb() function returns the number of received bytes to
be used for netdev statistics. In the case of RTR frames we get a valid
(potential non-zero) data length value which has to be passed for further
operations. But on the wire RTR frames have no payload le
From: Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count. Call pm_runtime_put if
pm_runtime_get_sync fails.
Signed-off-by: Navid Emamdoost
Link: https://lore.kernel.org/r/20200605033239.60664-1-navid.emamdo...@gmail.com
Fixes:
From: Colin Ian King
Don't populate the const array plen on the stack but instead it static. Makes
the object code smaller by 926 bytes.
Before:
textdata bss dec hex filename
265311943 64 285386f7a net/can/isotp.o
After:
textdata bss dec he
From: Joakim Zhang
With below sequence, we can see wakeup default is enabled after re-load module,
if it was enabled before, so we need disable wakeup in flexcan_remove().
| # cat /sys/bus/platform/drivers/flexcan/5a8e.can/power/wakeup
| disabled
| # echo enabled > /sys/bus/platform/drivers/
From: Joakim Zhang
After double check with Layerscape CAN owner (Pankaj Bansal), confirm
that LX2160A indeed supports ECC feature, so correct the feature table.
For SoCs with ECC supported, even use FLEXCAN_QUIRK_DISABLE_MECR quirk to
disable non-correctable errors interrupt and freeze mode, had
From: Oliver Hartkopp
As reported by Thomas Wagner:
https://github.com/hartkopp/can-isotp/issues/34
the timeout handling for data frames is not enabled when the isotp socket is
used in listen-only mode (sockopt CAN_ISOTP_LISTEN_MODE). This mode is enabled
by the isotpsniffer application whi
From: Tom Rix
A break is not needed if it is preceded by a return.
Signed-off-by: Tom Rix
Link: https://lore.kernel.org/r/20201019172412.31143-1-t...@redhat.com
Signed-off-by: Marc Kleine-Budde
---
.../net/can/spi/mcp251xfd/mcp251xfd-core.c| 22 +--
1 file changed, 11 inse
A CAN driver, using the rx-offload infrastructure, is reading CAN frames
(usually in IRQ context) from the hardware and placing it into the rx-offload
queue to be delivered to the networking stack via NAPI.
In case the rx-offload queue is full, trying to add more skbs results in the
skbs being dro
From: Vincent Mailhol
If a driver calls can_get_echo_skb() during a hardware IRQ (which is often, but
not always, the case), the 'WARN_ON(in_irq)' in
net/core/skbuff.c#skb_release_head_state() might be triggered, under network
congestion circumstances, together with the potential risk of a NULL p
On Mon, 02 Nov 2020 14:58:08 -0800 Saeed Mahameed wrote:
> On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote:
> > This series contains updates to ice driver only.
>
> ...
>
> > Tony renames Flow Director functions to be more generic as their use
> > is expanded.
> >
> > Real expands ntuple
On 2020-11-03 10:07 a.m., Vlad Buslov wrote:
On Tue 03 Nov 2020 at 03:48, David Ahern wrote:
On 10/31/20 2:25 PM, Vlad Buslov wrote:
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
index 5ad84e663d01..b486f52900f0 100644
--- a/include/uapi/linux/rtnetlink.h
+++ b/
On Mon, 2 Nov 2020 23:09:10 +0530 Vinay Kumar Yadav wrote:
> Correct skb refcount in alloc_ctrl_skb(), causing skb memleak
> when chtls_send_abort() called with NULL skb.
> it was always leaking the skb, correct it by incrementing skb
> refs by one.
>
> Fixes: cc35c88ae4db ("crypto : chtls - CPL
On Tue, Nov 03, 2020 at 08:22:24PM +0100, Marek Behún wrote:
> Add pla_ and usb_ prefixed versions of ocp_read_* and ocp_write_*
> functions. This saves us from always writing MCU_TYPE_PLA/MCU_TYPE_USB
> as parameter.
>
> Signed-off-by: Marek Behún
> ---
You just made it harder for everyone to f
On Fri, 30 Oct 2020 23:32:22 +0530 Rohit Maheshwari wrote:
> There could be a case where ACK for tls exchanges prior to start
> marker is missed out, and by the time tls is offloaded. This pkt
> should not be discarded and handled carefully. It could be
> plaintext alone or plaintext + finish as we
On Mon, 2 Nov 2020 10:27:28 -0500 min.li...@renesas.com wrote:
> From: Min Li
>
> Add idt82p33_adjwritephase() to support PHC write phase mode.
>
> Changes since v1:
> - Fix broken build on 32 bit machine due to 64 bit division.
Oh, and also please mark this as [PATCH net-next] in the subject,
On Mon, 2 Nov 2020 10:27:28 -0500 min.li...@renesas.com wrote:
> From: Min Li
>
> Add idt82p33_adjwritephase() to support PHC write phase mode.
>
> Changes since v1:
> - Fix broken build on 32 bit machine due to 64 bit division.
>
> Signed-off-by: Min Li
> ---
> drivers/ptp/ptp_idt82p33.c | 3
In can_rcv(), cfd->len is uninitialized when skb->len = 0, and this
uninitialized cfd->len is accessed nonetheless by pr_warn_once().
Fix this uninitialized variable access by checking cfd->len's validity
condition (cfd->len > CAN_MAX_DLEN) separately after the skb->len's
condition is checked, and
1 - 100 of 368 matches
Mail list logo
