Re: WARNING in dma_map_page_attrs

syzbot has found a reproducer for the following issue on: HEAD commit:3cb12d27 Merge tag 'net-5.10-rc1' of git://git.kernel.org/.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=1312539050 kernel config: https://syzkaller.appspot.com/x/.config?x=46c6fea3eb82

Re: [net v2] tcp: Prevent low rmem stalls with SO_RCVLOWAT.

Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 23 Oct 2020 11:47:09 -0700 you wrote: > From: Arjun Roy > > With SO_RCVLOWAT, under memory pressure, > it is possible to enter a state where: > > 1. We have not received enough bytes to satisfy SO_RCVLOWAT. > 2. We ha

Re: [net v2] tcp: Prevent low rmem stalls with SO_RCVLOWAT.

On Fri, 23 Oct 2020 11:47:09 -0700 Arjun Roy wrote: > From: Arjun Roy > > With SO_RCVLOWAT, under memory pressure, > it is possible to enter a state where: > > 1. We have not received enough bytes to satisfy SO_RCVLOWAT. > 2. We have not entered buffer pressure (see tcp_rmem_pressure()). > 3. Bu

Re: [net v2 3/7] cxgb4/ch_ktls: creating skbs causes panic

On Fri, 23 Oct 2020 11:01:30 +0530 Rohit Maheshwari wrote: > Creating SKB per tls record and freeing the original one causes > panic. There will be race if connection reset is requested. By > freeing original skb, refcnt will be decremented and that means, > there is no pending record to send, and

Re: [net v2 2/7] ch_ktls: Correction in finding correct length

On Fri, 23 Oct 2020 11:01:29 +0530 Rohit Maheshwari wrote: > There is a possibility of linear skbs coming in. Correcting > the length extraction logic. > > Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling") > Signed-off-by: Rohit Maheshwari > @@ -980,6 +979,10 @@ chcr_ktls_write_tcp

Re: [net v2 1/7] cxgb4/ch_ktls: decrypted bit is not enough

On Fri, 23 Oct 2020 11:01:28 +0530 Rohit Maheshwari wrote: > +#if IS_ENABLED(CONFIG_CHELSIO_TLS_DEVICE) > + cxgb4_is_ktls_skb(skb) || > +#endif > (proto != IPPROTO_TCP && proto != IPPROTO_UDP)) > txq = txq % pi->nqsets; > > diff --git a/driv

Re: [PATCH] net: ucc_geth: Drop extraneous parentheses in comparison

Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 23 Oct 2020 14:32:36 +1100 you wrote: > Clang warns about the extra parentheses in this comparison: > > drivers/net/ethernet/freescale/ucc_geth.c:1361:28: > warning: equality comparison with extraneous parentheses >

Re: [PATCH net 0/3] ionic: memory usage fixes

Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 22 Oct 2020 16:55:28 -0700 you wrote: > This patchset addresses some memory leaks and incorrect > io reads. > > Shannon Nelson (3): > ionic: clean up sparse complaints > ionic: no rx flush in deinit > ionic: fix

Re: [PATCH] net: ucc_geth: Drop extraneous parentheses in comparison

On Fri, 23 Oct 2020 14:32:36 +1100 Michael Ellerman wrote: > Clang warns about the extra parentheses in this comparison: > > drivers/net/ethernet/freescale/ucc_geth.c:1361:28: > warning: equality comparison with extraneous parentheses > if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII

Re: [PATCH net 0/3] ionic: memory usage fixes

On Thu, 22 Oct 2020 16:55:28 -0700 Shannon Nelson wrote: > This patchset addresses some memory leaks and incorrect > io reads. Applied, thanks! Looks like a fixes tag on patch 3 points to harmless refactoring - better point to the commit where problem first existed IMO.

Re: [PATCH net,v2] chelsio/chtls: fix tls record info to user

On Fri, 23 Oct 2020 00:35:57 +0530 Vinay Kumar Yadav wrote: > chtls_pt_recvmsg() receives a skb with tls header and subsequent > skb with data, need to finalize the data copy whenever next skb > with tls header is available. but here current tls header is > overwritten by next available tls header,

Re: [PATCH net] net: ipa: command payloads already mapped

On Wed, 21 Oct 2020 20:00:29 -0500 Alex Elder wrote: > IPA transactions describe actions to be performed by the IPA > hardware. Three cases use IPA transactions: transmitting a socket > buffer; providing a page to receive packet data; and issuing an IPA > immediate command. An IPA transaction co

Re: [PATCH iproute2-next 3/5] lib: add libbpf support

On Thu, Oct 22, 2020 at 8:39 PM Hangbin Liu wrote: > > This patch converts iproute2 to use libbpf for loading and attaching > BPF programs when it is available, which is started by Toke's > implementation[1]. With libbpf iproute2 could correctly process BTF > information and support the new-style

Re: [PATCH v2 1/1] powerpc/vnic: Extend "failover pending" window

Lijun Pan [l...@linux.vnet.ibm.com] wrote: >On Oct 19, 2020, at 2:52 PM, Sukadev Bhattiprolu ><[1]suka...@linux.ibm.com> wrote: > >From 67f8977f636e462a1cd1eadb28edd98ef4f2b756 Mon Sep 17 00:00:00 2001 >From: Sukadev Bhattiprolu <[2]suka...@linux.vnet.ibm.com> >Date: Thu, 10 Se

[PATCH v9 1/4] bus: mhi: core: Add helper API to return number of free TREs

Introduce mhi_get_free_desc_count() API to return number of TREs available to queue buffer. MHI clients can use this API to know before hand if ring is full without calling queue API. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi/c

[PATCH v9 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file

Currently this macro is defined in internal MHI header as a TRE length mask. Moving it to external header allows MHI client drivers to set this upper bound for the transmit buffer size. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi

[PATCH v9 3/4] docs: Add documentation for userspace client interface

MHI userspace client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently Loopback MHI channel is supported by this driver. Signed-off-by: Hemant Kumar --- Documentation/mhi/index.rst | 1 + Documentation/

[PATCH v9 0/4] userspace MHI client interface driver

This patch series adds support for UCI driver. UCI driver enables userspace clients to communicate to external MHI devices like modem and WLAN. UCI driver probe creates standard character device file nodes for userspace clients to perform open, read, write, poll and release file operations. These f

[PATCH v9 4/4] bus: mhi: Add userspace client interface driver

This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI device object instantiates UCI channel object when device file node is opened. UCI chan

Re: [GIT PULL] Networking

Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Thu, 22 Oct 2020 14:48:26 -0700 you wrote: > Hi Linus! > > Latest fixes from the networking tree. Experimenting with the format > of the description further, I'll find out if you liked it based on how > it ends up loo

Re: [PATCH v2 2/2] net: phy: adin: implement cable-test support

On Thu, Oct 22, 2020 at 10:45:51AM +0300, Alexandru Ardelean wrote: > The ADIN1300/ADIN1200 support cable diagnostics using TDR. > > The cable fault detection is automatically run on all four pairs looking at > all combinations of pair faults by first putting the PHY in standby (clear > the LINK_E

Re: [PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg

On Thu, Oct 22, 2020 at 10:45:50AM +0300, Alexandru Ardelean wrote: > When the PHY powers up, the diagnostics clock isn't enabled (bit 2 in > register PHY_CTRL_1 (0x0012)). > Also, the PHY is not in standby mode, so bit 13 in PHY_CTRL_3 (0x0017) is > always set at power up. > > The standby mode an

Re: [PATCH 4/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

> +int mv88e6123_serdes_get_regs_len(struct mv88e6xxx_chip *chip, int port) > +{ > + if (mv88e6xxx_serdes_get_lane(chip, port) == 0) > + return 0; > + > + return 26 * sizeof(u16); > +} Hi Chris Where did 26 come from? Andrew

Re: [PATCH 3/4] net: dsa: mv88e6xxx: Handle error in serdes_get_regs

On Thu, Oct 22, 2020 at 02:25:14PM +1300, Chris Packham wrote: > If the underlying read operation failed we would end up writing stale > data to the supplied buffer. This would end up with the last > successfully read value repeating. Fix this by only writing the data > when we know the read was go

Re: [RFC bpf-next 09/16] bpf: Add BPF_TRAMPOLINE_BATCH_ATTACH support

On Fri, Oct 23, 2020 at 1:31 PM Steven Rostedt wrote: > > On Fri, 23 Oct 2020 13:03:22 -0700 > Andrii Nakryiko wrote: > > > Basically, maybe ftrace subsystem could provide a set of APIs to > > prepare a set of functions to attach to. Then BPF subsystem would just > > do what it does today, except

RE: [PATCH] vsock: ratelimit unknown ioctl error message

From: Stefano Garzarella > Sent: 23 October 2020 15:10 > > On Fri, Oct 23, 2020 at 01:21:13PM +0100, Colin King wrote: > >From: Colin Ian King > > > >When exercising the kernel with stress-ng with some ioctl tests the > >"Unknown ioctl" error message is spamming the kernel log at a high > >rate

RE: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

From: Segher Boessenkool > Sent: 23 October 2020 19:27 > > On Fri, Oct 23, 2020 at 06:58:57PM +0100, Al Viro wrote: > > On Fri, Oct 23, 2020 at 03:09:30PM +0200, David Hildenbrand wrote: > > > > > Now, I am not a compiler expert, but as I already cited, at least on > > > x86-64 clang expects that

Re: [PATCH net] ip_tunnel: fix over-mtu packet send fail without TUNNEL_DONT_FRAGMENT flags

On Wed, 21 Oct 2020 17:21:55 +0800 we...@ucloud.cn wrote: > From: wenxu > > The TUNNEL_DONT_FRAGMENT flags specific the tunnel outer ip can do > fragment or not in the md mode. Without the TUNNEL_DONT_FRAGMENT > should always do fragment. So it should not care the frag_off in > inner ip. Can you

Re: [PATCH v3 18/56] net: phy: fix kernel-doc markups

On Fri, Oct 23, 2020 at 06:33:05PM +0200, Mauro Carvalho Chehab wrote: > Some functions have different names between their prototypes > and the kernel-doc markup. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/net/phy/mdio_bus.c | 2 +- > drivers/net/phy/phy-c45.c| 2 +- > driver

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

On Fri, Oct 23 2020 at 09:10, Nitesh Narayan Lal wrote: > On 10/23/20 4:58 AM, Peter Zijlstra wrote: >> On Thu, Oct 22, 2020 at 01:47:14PM -0400, Nitesh Narayan Lal wrote: >> So shouldn't we then fix the drivers / interface first, to get rid of >> this inconsistency? >> > Considering we agree that

Re: [PATCH] net treewide: Use skb_is_gso

On Wed, 21 Oct 2020 18:30:30 +0800 Yi Li wrote: > This patch introduces the use of the inline func skb_is_gso in place of > tests for skb_shinfo(skb)->gso_size. > > - if (skb_shinfo(skb)->gso_size) > + if (skb_is_gso(skb)) > > - if (unlikely(skb_shinfo(skb)->gso_size)) > + if (unlikely(skb_is_gso

Re: [RFC PATCH v1 1/6] net: phy: add CAN PHY Virtual Bus

On Fri, Oct 23, 2020 at 12:56:21PM +0200, Oleksij Rempel wrote: > Most of CAN PHYs (transceivers) are not attached to any data bus, so we > are not able to communicate with them. For this case, we introduce a CAN > specific virtual bus to make use of existing PHY framework. I don't think you are m

[RFC PATCH net-next] net: use a dedicated tracepoint for kfree_skb_list()

kfree_skb_list() calls kfree_skb(), thus triggering as many dropwatch events as the number of skbs in the list. This can disturb the analysis of packet drops, e.g. with fragmented echo requests generated by ICMP sockets, or with regular SCTP packets: when consume_skb() frees them, the kernel's drop

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

On 2020-10-22 21:21, Paul Moore wrote: > On Wed, Oct 21, 2020 at 12:39 PM Richard Guy Briggs wrote: > > Here is an exmple I was able to generate after updating the testsuite > > script to include a signalling example of a nested audit container > > identifier: > > > > > > type=PROCTITLE msg=a

Re: [RFC bpf-next 09/16] bpf: Add BPF_TRAMPOLINE_BATCH_ATTACH support

On Fri, 23 Oct 2020 13:03:22 -0700 Andrii Nakryiko wrote: > Basically, maybe ftrace subsystem could provide a set of APIs to > prepare a set of functions to attach to. Then BPF subsystem would just > do what it does today, except instead of attaching to a specific > kernel function, it would atta

Re: [RFC PATCH v1 0/6] add initial CAN PHY support

On Fri, Oct 23, 2020 at 12:56:20PM +0200, Oleksij Rempel wrote: > This patch set is introducing PHY support for CAN. The device tree binding needs documenting. It might also help me get my head around the virtual MDIO bus and how PHYs are added to it. Andrew

[PATCH/RFC net-next v3] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

The driver does not implement a shutdown handler which leads to issues when using kexec in certain scenarios. The NIC keeps on fetching descriptors which gets flagged by the IOMMU with errors like this: DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request

Re: [PATCH] vsock: ratelimit unknown ioctl error message

On Fri, 23 Oct 2020 16:09:47 +0200 Stefano Garzarella wrote: > On Fri, Oct 23, 2020 at 01:21:13PM +0100, Colin King wrote: > >From: Colin Ian King > > > >When exercising the kernel with stress-ng with some ioctl tests the > >"Unknown ioctl" error message is spamming the kernel log at a high > >rat

Re: [RFC PATCH v1 3/6] net: phy: add CAN interface mode

On Fri, Oct 23, 2020 at 12:56:23PM +0200, Oleksij Rempel wrote: > Signed-off-by: Oleksij Rempel > --- > drivers/net/phy/phy.c | 2 ++ > include/linux/phy.h | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index 35525a671400..4fb355df3

Re: [RFC PATCH v1 1/6] net: phy: add CAN PHY Virtual Bus

On Fri, Oct 23, 2020 at 12:56:21PM +0200, Oleksij Rempel wrote: > Most of CAN PHYs (transceivers) are not attached to any data bus, so we > are not able to communicate with them. For this case, we introduce a CAN > specific virtual bus to make use of existing PHY framework. > > Signed-off-by: Olek

Re: [PATCH] RFC: net: phy: of phys probe/reset issue

> Yes there is: have your Ethernet PHY compatible string be of the form > "ethernet." and then there is no need for such hacking. > of_get_phy_id() will parse that compatible and that will trigger > of_mdiobus_register_phy() to take the phy_device_create() path. Yep. That does seem like th

Re: [RFC bpf-next 13/16] libbpf: Add trampoline batch attach support

On Thu, Oct 22, 2020 at 2:03 AM Jiri Olsa wrote: > > Adding trampoline batch attach support so it's possible to use > batch mode to load tracing programs. > > Adding trampoline_attach_batch bool to struct bpf_object_open_opts. > When set to true the bpf_object__attach_skeleton will try to load > a

Re: [PATCH/RFC net v2] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

On Thu, 22 Oct 2020 19:45:20 -0700 Moritz Fischer wrote: > The driver does not implement a shutdown handler which leads to issues > when using kexec in certain scenarios. The NIC keeps on fetching > descriptors which gets flagged by the IOMMU with errors like this: > > DMAR: DMAR:[DMA read] Reques

Re: [RFC bpf-next 09/16] bpf: Add BPF_TRAMPOLINE_BATCH_ATTACH support

On Thu, Oct 22, 2020 at 8:01 AM Jiri Olsa wrote: > > Adding BPF_TRAMPOLINE_BATCH_ATTACH support, that allows to attach > tracing multiple fentry/fexit pograms to trampolines within one > syscall. > > Currently each tracing program is attached in seprate bpf syscall > and more importantly by separa

Re: [RFC bpf-next 08/16] bpf: Use delayed link free in bpf_link_put

On Thu, Oct 22, 2020 at 8:01 AM Jiri Olsa wrote: > > Moving bpf_link_free call into delayed processing so we don't > need to wait for it when releasing the link. > > For example bpf_tracing_link_release could take considerable > amount of time in bpf_trampoline_put function due to > synchronize_rc

Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function

On 10/23/2020 1:11 PM, Loic Poulain wrote: Hi Hemant, On Fri, 23 Oct 2020 at 05:06, Hemant Kumar > wrote: Hi Loic, On 10/16/20 2:20 AM, Loic Poulain wrote: > This function can be used by client driver to determine whether it's > possible to que

Re: Remove __napi_schedule_irqoff?

On 18/10/2020 11:20, Heiner Kallweit wrote: On 18.10.2020 10:02, Eric Dumazet wrote: On Sun, Oct 18, 2020 at 1:29 AM Jakub Kicinski wrote: On Sat, 17 Oct 2020 15:45:57 +0200 Heiner Kallweit wrote: When __napi_schedule_irqoff was added with bc9ad166e38a ("net: introduce napi_schedule_irqof

Re: [GIT PULL] Networking

The pull request you sent on Thu, 22 Oct 2020 14:48:26 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git tags/net-5.10-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3cb12d27ff655e57e8efe3486dca2a22f4e30578 Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] Networking

On Thu, Oct 22, 2020 at 2:48 PM Jakub Kicinski wrote: > > Latest fixes from the networking tree. Experimenting with the format > of the description further, I'll find out if you liked it based on how > it ends up looking in the tree :) Looks fine to me. Honestly, the format isn't a huge deal, as

Re: [GIT PULL] vhost,vdpa,virtio: cleanups, fixes

The pull request you sent on Fri, 23 Oct 2020 11:38:32 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9313f8026328d0309d093f6774be4b8f5340c0e5 Thank you! -- Deet-doot-dot, I am a b

[PATCH net 0/3] net/smc: fixes 2020-10-23

Please apply the following patch series for smc to netdev's net tree. Patch 1 fixes a potential null pointer dereference. Patch 2 takes care of a suppressed return code and patch 3 corrects the system EID in the ISM driver. Karsten Graul (3): net/smc: fix null pointer dereference in smc_listen_

[PATCH net 1/3] net/smc: fix null pointer dereference in smc_listen_decline()

smc_listen_work() calls smc_listen_decline() on label out_decl, providing the ini pointer variable. But this pointer can still be null when the label out_decl is reached. Fix this by checking the ini variable in smc_listen_work() and call smc_listen_decline() with the result directly. Fixes: a7c9c

[PATCH net 3/3] s390/ism: fix incorrect system EID

The system EID that is defined by the ISM driver is not correct. Using an incorrect system EID allows to communicate with remote Linux systems that use the same incorrect system EID, but when it comes to interoperability with other operating systems then the system EIDs do never match which prevent

[PATCH net 2/3] net/smc: fix suppressed return code

The patch that repaired the invalid return code in smcd_new_buf_create() missed to take care of errno ENOSPC which has a special meaning that no more DMBEs can be registered on the device. Fix that by keeping this errno value during the translation of the return code. Fixes: 6b1bbf94ab36 ("net/smc

Re: [PATCH net 1/2] mpls: Make MPLS_IPTUNNEL select NET_MPLS_GSO

On Fri, Oct 23, 2020 at 11:23:04AM -0700, Jakub Kicinski wrote: > On Fri, 23 Oct 2020 18:19:43 +0200 Guillaume Nault wrote: > > Since commit b7c24497baea ("mpls: load mpls_gso after mpls_iptunnel"), > > mpls_iptunnel.ko has a softdep on mpls_gso.ko. For this to work, we > > need to ensure that mpls

[net v2] tcp: Prevent low rmem stalls with SO_RCVLOWAT.

From: Arjun Roy With SO_RCVLOWAT, under memory pressure, it is possible to enter a state where: 1. We have not received enough bytes to satisfy SO_RCVLOWAT. 2. We have not entered buffer pressure (see tcp_rmem_pressure()). 3. But, we do not have enough buffer space to accept more packets. In th

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

On Fri, Oct 23, 2020 at 06:58:57PM +0100, Al Viro wrote: > On Fri, Oct 23, 2020 at 03:09:30PM +0200, David Hildenbrand wrote: > > > Now, I am not a compiler expert, but as I already cited, at least on > > x86-64 clang expects that the high bits were cleared by the caller - in > > contrast to gcc.

Re: [net] tcp: Prevent low rmem stalls with SO_RCVLOWAT.

On Fri, 23 Oct 2020 10:48:57 -0700 Arjun Roy wrote: > From: Arjun Roy > > With SO_RCVLOWAT, under memory pressure, > it is possible to enter a state where: > > 1. We have not received enough bytes to satisfy SO_RCVLOWAT. > 2. We have not entered buffer pressure (see tcp_rmem_pressure()). > 3. Bu

Re: [PATCH net 1/2] mpls: Make MPLS_IPTUNNEL select NET_MPLS_GSO

On Fri, 23 Oct 2020 18:19:43 +0200 Guillaume Nault wrote: > Since commit b7c24497baea ("mpls: load mpls_gso after mpls_iptunnel"), > mpls_iptunnel.ko has a softdep on mpls_gso.ko. For this to work, we > need to ensure that mpls_gso.ko is built whenever MPLS_IPTUNNEL is set. Does it generate an err

Re: [PATCH] RFC: net: phy: of phys probe/reset issue

On 10/23/20 10:47 AM, Grygorii Strashko wrote: > Hi All, > > The main intention of this mail is to trigger discussion to find a proper > solution. All code is hackish and based on v5.9. > > Problem statement: > > There is an issue observed with MDIO OF PHYs discover/reset sequence in > case PHY

Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

It was <2020-10-23 pią 18:27>, when Krzysztof Kozlowski wrote: > On Fri, 23 Oct 2020 at 18:05, Rob Herring wrote: >> >> On Wed, 21 Oct 2020 23:49:07 +0200, Łukasz Stelmach wrote: >> > Add bindings for AX88796C SPI Ethernet Adapter. >> > >> > Signed-off-by: Łukasz Stelmach >> > --- >> > .../bindi

Re: [PATCHv4 net-next] dropwatch: Support monitoring of dropped frames

On Fri, 23 Oct 2020 06:29:43 +0200 izabela.bakoll...@gmail.com wrote: > From: Izabela Bakollari > > Dropwatch is a utility that monitors dropped frames by having userspace > record them over the dropwatch protocol over a file. This augument > allows live monitoring of dropped frames using tools l

Re: [PATCHv3 net 2/2] IPv6: reply ICMP error if the first fragment doesn't include all headers

On Fri, 23 Oct 2020 14:43:47 +0800 Hangbin Liu wrote: > diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c > index ec448b71bf9a..0bda77d7e6b8 100644 > --- a/net/ipv6/icmp.c > +++ b/net/ipv6/icmp.c > @@ -145,6 +145,7 @@ static bool is_ineligible(const struct sk_buff *skb) > int ptr = (u8 *)(ipv6_h

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

On Fri, Oct 23, 2020 at 03:09:30PM +0200, David Hildenbrand wrote: > Now, I am not a compiler expert, but as I already cited, at least on > x86-64 clang expects that the high bits were cleared by the caller - in > contrast to gcc. I suspect it's the same on arm64, but again, I am no > compiler exp

[net] tcp: Prevent low rmem stalls with SO_RCVLOWAT.

From: Arjun Roy With SO_RCVLOWAT, under memory pressure, it is possible to enter a state where: 1. We have not received enough bytes to satisfy SO_RCVLOWAT. 2. We have not entered buffer pressure (see tcp_rmem_pressure()). 3. But, we do not have enough buffer space to accept more packets. In th

Re: [PATCH 1/3] sched: better handling for busy polling loops

On Thu, 22 Oct 2020 20:29:42 -0700 Josh Don wrote: > Busy polling loops in the kernel such as network socket poll and kvm > halt polling have performance problems related to process scheduler load > accounting. > > Both of the busy polling examples are opportunistic - they relinquish > the cpu if

[PATCH] RFC: net: phy: of phys probe/reset issue

Hi All, The main intention of this mail is to trigger discussion to find a proper solution. All code is hackish and based on v5.9. Problem statement: There is an issue observed with MDIO OF PHYs discover/reset sequence in case PHY has reset line with default state is (1). In this case, when Linu

Re: [RFC][PATCH v3 3/3] Rename nla_strlcpy to nla_strscpy.

On Fri, Oct 23, 2020 at 08:29:20AM -0700, Jakub Kicinski wrote: > On Fri, 23 Oct 2020 08:07:44 + David Laight wrote: > > FWIW I suspect the 'return -ERR on overflow' is going to bite us. > > Code that does p += strsxxx(p, ..., lim - p, ...) assuming (or not > > caring) about overflow goes badl

Re: [PATCH net RFC] net: Clear IFF_TX_SKB_SHARING for all Ethernet devices using skb_padto

On Thu, 22 Oct 2020 19:25:40 -0700 Xie He wrote: > On Thu, Oct 22, 2020 at 6:56 PM Xie He wrote: > > My patch isn't complete. Because there are so many drivers with this > > problem, I feel it's hard to solve them all at once. So I only grepped > > "skb_padto" under "drivers/net/ethernet". There a

Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

On Fri, Oct 23, 2020 at 06:51:05PM +0200, Eric Dumazet wrote: > On Fri, Oct 23, 2020 at 6:48 PM Ricardo Dias wrote: > > > > > In that case, I can change the patch to only iterate the ehash bucket > > only when the listening socket is using the loopback interface, correct? > > No, the fix should

Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

On Fri, Oct 23, 2020 at 06:36:29PM +0200, Eric Dumazet wrote: > On Fri, Oct 23, 2020 at 6:06 PM Ricardo Dias wrote: > > > And what about the loopback interface? Why couldn't the loopback > > interface also use a single RX queue? > > > > Loopback is using a per-cpu queue, with no crossing, for ef

[PATCH v3 20/56] net: core: fix some kernel-doc markups

Some identifiers have different names between their prototypes and the kernel-doc markup. In the specific case of netif_subqueue_stopped(), keep the current markup for __netif_subqueue_stopped(), adding a new one for netif_subqueue_stopped(). Signed-off-by: Mauro Carvalho Chehab --- include/lin

[PATCH v3 21/56] mac80211: fix kernel-doc markups

Some identifiers have different names between their prototypes and the kernel-doc markup. Others need to be fixed, as kernel-doc markups should use this format: identifier - description In the specific case of __sta_info_flush(), add a documentation for sta_info_flush(), as this one is th

[PATCH v3 18/56] net: phy: fix kernel-doc markups

Some functions have different names between their prototypes and the kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- drivers/net/phy/mdio_bus.c | 2 +- drivers/net/phy/phy-c45.c| 2 +- drivers/net/phy/phy.c| 2 +- drivers/net/phy/phy_device.c | 2 +- drivers/net/phy/phy

[PATCH v3 19/56] net: datagram: fix some kernel-doc markups

Some identifiers have different names between their prototypes and the kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- net/core/datagram.c | 2 +- net/core/dev.c| 4 ++-- net/core/skbuff.c | 2 +- net/ethernet/eth.c| 6 +++--- net/sunrpc/rpc_pipe.c | 3 ++- 5 files

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

On 23.10.20 16:47, 'Greg KH' wrote: > On Fri, Oct 23, 2020 at 02:39:24PM +, David Laight wrote: >> From: David Hildenbrand >>> Sent: 23 October 2020 15:33 >> ... >>> I just checked against upstream code generated by clang 10 and it >>> properly discards the upper 32bit via a mov w23 w2. >>> >>>

Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

On Fri, 23 Oct 2020 at 18:05, Rob Herring wrote: > > On Wed, 21 Oct 2020 23:49:07 +0200, Łukasz Stelmach wrote: > > Add bindings for AX88796C SPI Ethernet Adapter. > > > > Signed-off-by: Łukasz Stelmach > > --- > > .../bindings/net/asix,ax88796c.yaml | 69 +++ > > 1 fil

[PATCH net 0/2] mpls: fix dependencies on mpls_gso.ko

Since commit b7c24497baea ("mpls: load mpls_gso after mpls_iptunnel"), mpls_iptunnel tries to load mpls_gso. Therefore, we need to build mpls_gso when mpls_iptunnel is selected (patch 1). There's also the act_mpls module that can push MPLS headers on GSO packets. This module also depends on mpls_g

Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function

On 10/23/2020 9:44 AM, Jakub Kicinski wrote: On Thu, 22 Oct 2020 20:06:37 -0700 Hemant Kumar wrote: @@ -1173,6 +1173,17 @@ int mhi_queue_buf(struct mhi_device *mhi_dev, enum dma_data_direction dir, } EXPORT_SYMBOL_GPL(mhi_queue_buf); +bool mhi_queue_is_full(struct mhi_device *mhi_dev,

[PATCH net 2/2] net/sched: act_mpls: Add softdep on mpls_gso.ko

TCA_MPLS_ACT_PUSH and TCA_MPLS_ACT_MAC_PUSH might be used on gso packets. Such packets will thus require mpls_gso.ko for segmentation. Fixes: 2a2ea50870ba ("net: sched: add mpls manipulation actions to TC") Signed-off-by: Guillaume Nault --- net/sched/Kconfig| 2 ++ net/sched/act_mpls.c | 1

[PATCH net 1/2] mpls: Make MPLS_IPTUNNEL select NET_MPLS_GSO

Since commit b7c24497baea ("mpls: load mpls_gso after mpls_iptunnel"), mpls_iptunnel.ko has a softdep on mpls_gso.ko. For this to work, we need to ensure that mpls_gso.ko is built whenever MPLS_IPTUNNEL is set. Fixes: b7c24497baea ("mpls: load mpls_gso after mpls_iptunnel") Signed-off-by: Guillaum

Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

On Fri, Oct 23, 2020 at 05:56:07PM +0200, Eric Dumazet wrote: > On Fri, Oct 23, 2020 at 5:51 PM Ricardo Dias wrote: > > > > On Fri, Oct 23, 2020 at 04:03:27PM +0200, Eric Dumazet wrote: > > > On Fri, Oct 23, 2020 at 1:14 PM Ricardo Dias wrote: > > > > > > ... > > > > > > Note that normally, all p

Re: [PATCH v4] net: macb: add support for high speed interface

On Fri, Oct 23, 2020 at 05:39:07PM +0200, Parshuram Thombare wrote: > This patch adds support for 10GBASE-R interface to the linux driver for > Cadence's ethernet controller. > This controller has separate MAC's and PCS'es for low and high speed paths. > High speed PCS supports 100M, 1G, 2.5G, 5G a

Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

On Wed, 21 Oct 2020 23:49:07 +0200, Łukasz Stelmach wrote: > Add bindings for AX88796C SPI Ethernet Adapter. > > Signed-off-by: Łukasz Stelmach > --- > .../bindings/net/asix,ax88796c.yaml | 69 +++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/d

Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

On Fri, Oct 23, 2020 at 04:03:27PM +0200, Eric Dumazet wrote: > On Fri, Oct 23, 2020 at 1:14 PM Ricardo Dias wrote: > > > > When the TCP stack is in SYN flood mode, the server child socket is > > created from the SYN cookie received in a TCP packet with the ACK flag > > set. > > > ... > > This pa

Re: [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support

On Fri, Oct 23, 2020 at 08:56:10AM +0200, Greg KH wrote: > On Fri, Oct 23, 2020 at 09:49:46AM +0300, Leon Romanovsky wrote: > > On Thu, Oct 22, 2020 at 05:33:28PM -0700, Dave Ertman wrote: > > > > <...> > > > > > Dave Ertman (1): > > > Add auxiliary bus support > > > > We are in merge window now

Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function

On Thu, 22 Oct 2020 20:06:37 -0700 Hemant Kumar wrote: > > @@ -1173,6 +1173,17 @@ int mhi_queue_buf(struct mhi_device *mhi_dev, enum > > dma_data_direction dir, > > } > > EXPORT_SYMBOL_GPL(mhi_queue_buf); > > > > +bool mhi_queue_is_full(struct mhi_device *mhi_dev, enum dma_data_direction >

[PATCH] cxgb4/ch_ktls: fix call_kern.cocci warnings

: kernel test robot Signed-off-by: Julia Lawall --- Hello, Please check on this. Normally, it relates to the call site of the function. julia url: https://github.com/0day-ci/linux/commits/Rohit-Maheshwari/cxgb4-ch_ktls-Fixes-in-nic-tls-code/20201023-133301 base: https://git.kernel.org/pub/scm

[PATCH v4] net: macb: add support for high speed interface

This patch adds support for 10GBASE-R interface to the linux driver for Cadence's ethernet controller. This controller has separate MAC's and PCS'es for low and high speed paths. High speed PCS supports 100M, 1G, 2.5G, 5G and 10G through rate adaptation implementation. However, since it doesn't sup

[GIT PULL] vhost,vdpa,virtio: cleanups, fixes

Was holding out for a couple of big new features including vop and rpmsg support for 1.0, but it looks like they won't make it in time. virtio i2c might be ready soon but that's a new driver so if it's ready soon it's probably ok to merge outside the merge window ... we'll see. The following chang

Re: [RFC PATCH 1/6] docs: networking: add the document for DFL Ether Group driver

Hi Xu Before i look at the other patches, i want to understand the architecture properly. > +=== > +DFL device driver for Ether Group private feature on Intel(R) PAC N3000 > +==

Re: [PATCH net] vhost_vdpa: Return -EFUALT if copy_from_user() fails

On Fri, Oct 23, 2020 at 03:08:53PM +0300, Dan Carpenter wrote: > The copy_to/from_user() functions return the number of bytes which we > weren't able to copy but the ioctl should return -EFAULT if they fail. > > Fixes: a127c5bbb6a8 ("vhost-vdpa: fix backend feature ioctls") > Signed-off-by: Dan Ca

Re: [RFC][PATCH v3 3/3] Rename nla_strlcpy to nla_strscpy.

On Fri, 23 Oct 2020 08:07:44 + David Laight wrote: > FWIW I suspect the 'return -ERR on overflow' is going to bite us. > Code that does p += strsxxx(p, ..., lim - p, ...) assuming (or not > caring) about overflow goes badly wrong. I don't really care either way, but in netlink there's usually

general protection fault in call_commit_handler

Hello, syzbot found the following issue on: HEAD commit:9ff9b0d3 Merge tag 'net-next-5.10' of git://git.kernel.org.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=1237720790 kernel config: https://syzkaller.appspot.com/x/.config?x=10a98dcaa4fa65a2 das

Fw: [Bug 209823] New: system panic since commit d18d22ce8f62839365c984b1df474d3975ed4eb2

Begin forwarded message: Date: Fri, 23 Oct 2020 03:38:54 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 209823] New: system panic since commit d18d22ce8f62839365c984b1df474d3975ed4eb2 https://bugzilla.kernel.org/show_bug.cgi?id=209823

Re: [RFC][PATCH v3 3/3] Rename nla_strlcpy to nla_strscpy.

Le vendredi 23 octobre 2020, 01:05:51 CEST Jakub Kicinski a écrit : > On Thu, 22 Oct 2020 13:04:32 -0700 Kees Cook wrote: > > > > > From: Francis Laniel > > > > > > > > > > Calls to nla_strlcpy are now replaced by calls to nla_strscpy which > > > > > is the > > > > > new name of this function. >

Re: [RFC][PATCH v3 3/3] Rename nla_strlcpy to nla_strscpy.

Le vendredi 23 octobre 2020, 10:07:44 CEST David Laight a écrit : > From: Jakub Kicinski > > > Sent: 23 October 2020 00:06 > > > > On Thu, 22 Oct 2020 13:04:32 -0700 Kees Cook wrote: > > > > > > From: Francis Laniel > > > > > > > > > > > > Calls to nla_strlcpy are now replaced by calls to nla_s

[PATCH iproute2-next v4 1/2] tc: skip actions that don't have options attribute when printing

From: Vlad Buslov Modify implementations that return error from action_until->print_aopt() callback to silently skip actions that don't have their corresponding TCA_ACT_OPTIONS attribute set (some actions already behave like this). Print action kind before returning from action_until->print_aopt(

[PATCH iproute2-next v4 0/2] Implement filter terse dump mode support

Implement support for terse dump mode which provides only essential classifier/action info (handle, stats, cookie, etc.). Use new TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from kernel. Vlad Buslov (2): tc: skip actions that don't have options attribute when printing tc:

[PATCH iproute2-next v4 2/2] tc: implement support for terse dump

From: Vlad Buslov Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when user requested it with following example CLI (-br for 'brief'): $ tc -s -br filter show dev ens1f0 ingress filter protocol ip p

  1   2   >