Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-21 Thread Krzysztof Kozlowski
On Wed, Oct 21, 2020 at 11:49:07PM +0200, Łukasz Stelmach wrote: > Add bindings for AX88796C SPI Ethernet Adapter. > > Signed-off-by: Łukasz Stelmach > --- > .../bindings/net/asix,ax88796c.yaml | 69 +++ > 1 file changed, 69 insertions(+) > create mode 100644 Documenta

Re: [PATCH v3 1/5] dt-bindings: vendor-prefixes: Add asix prefix

2020-10-21 Thread Krzysztof Kozlowski
On Wed, Oct 21, 2020 at 11:49:06PM +0200, Łukasz Stelmach wrote: > Add the prefix for ASIX Electronics Corporation End the sentence with a full stop. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] net: xfrm: fix a race condition during allocing spi

2020-10-21 Thread Herbert Xu
On Thu, Oct 22, 2020 at 01:53:15PM +0800, zhuoliang.zhang wrote: > > there are 2 related hash lists : net->xfrm.state_bydst and > net->xfrm.state_byspi: > > 1. a new state x is alloced in xfrm_state_alloc() and added into the > bydst hlist in __find_acq_core() on the LHS; > 2. on the RHS, state_

[PATCH net v2] net: Properly typecast int values to set sk_max_pacing_rate

2020-10-21 Thread Ke Li
In setsockopt(SO_MAX_PACING_RATE) on 64bit systems, sk_max_pacing_rate, after extended from 'u32' to 'unsigned long', takes unintentionally hiked value whenever assigned from an 'int' value with MSB=1, due to binary sign extension in promoting s32 to u64, e.g. 0x8000 becomes 0x8000.

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-21 Thread Joel Stanley
On Wed, 21 Oct 2020 at 12:40, Arnd Bergmann wrote: > > On Wed, Oct 21, 2020 at 12:39 PM Joel Stanley wrote: > > > > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c > > b/drivers/net/ethernet/faraday/ftgmac100.c > > index 331d4bdd4a67..15cdfeb135b0 100644 > > --- a/drivers/net/ethernet/fa

Re: [PATCH net] net: Properly typecast int values to set sk_max_pacing_rate

2020-10-21 Thread Li, Ke
Thanks for review and comment, Jakub! Please check my v2 patch. Best, -Ke On 10/21/20, 8:53 PM, "Jakub Kicinski" wrote: On Mon, 19 Oct 2020 20:31:49 -0400 Ke Li wrote: > In setsockopt(SO_MAX_PACING_RATE) on 64bit systems, sk_max_pacing_rate, > after extended from 'u32' to 'unsigned

RE: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-21 Thread Danielle Ratson
> -Original Message- > From: Michal Kubecek > Sent: Wednesday, October 21, 2020 11:48 AM > To: Danielle Ratson > Cc: Jiri Pirko ; Andrew Lunn ; Jakub > Kicinski ; Ido Schimmel ; > netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko > ; f.faine...@gmail.com; mlxsw ; Ido > Schimmel ;

[PATCH] net-veth: Fix memleak in veth_newlink

2020-10-21 Thread Dinghao Liu
When rtnl_configure_link() fails, peer needs to be freed just like when register_netdevice() fails. Signed-off-by: Dinghao Liu --- drivers/net/veth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 8c737668008a..6c68094399cc 100644 --- a/drivers

Re: Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-21 Thread dinghao . liu
> > On 21.10.20 07:21, Dinghao Liu wrote: > > When rtnl_configure_link() fails, peer needs to be > > freed just like when register_netdevice() fails. > > > > Signed-off-by: Dinghao Liu > > Acked-by: Oliver Hartkopp > > Btw. as the vxcan.c driver bases on veth.c the same issue can be found >

Re: [PATCH net] chelsio/chtls: fix tls record info to user

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 01:09:31 +0530 Vinay Kumar Yadav wrote: > tls record header is not getting updated correctly causing > application to close the connection in between data copy. > fixing it by finalizing current record whenever tls header > received. Please improve this commit message.

Re: [PATCH net v2] ibmvnic: save changed mac address to adapter->mac_addr

2020-10-21 Thread Jakub Kicinski
On Tue, 20 Oct 2020 17:39:19 -0500 Lijun Pan wrote: > After mac address change request completes successfully, the new mac > address need to be saved to adapter->mac_addr as well as > netdev->dev_addr. Otherwise, adapter->mac_addr still holds old > data. > > Fixes: 62740e97881c ("net/ibmvnic: Upda

Re: [PATCH net] net: Properly typecast int values to set sk_max_pacing_rate

2020-10-21 Thread Jakub Kicinski
On Mon, 19 Oct 2020 20:31:49 -0400 Ke Li wrote: > In setsockopt(SO_MAX_PACING_RATE) on 64bit systems, sk_max_pacing_rate, > after extended from 'u32' to 'unsigned long', takes unintentionally > hiked value whenever assigned from an 'int' value with MSB=1, due to > binary sign extension in promoting

Re: [PATCH net] selftests: mptcp: depends on built-in IPv6

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 17:35:32 -0700 (PDT) Mat Martineau wrote: > > Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a > > consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no > > longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6 > > will stay disabl

[PATCH] Docs/bpf: Improve bpf_design_QA.rst

2020-10-21 Thread Rhys Rustad-Elliott
- Rephrase wording such that the file flows better - Improve consistency with respect to word use, grammar and style - Remove point on loops not being supported as BPF now has support for bounded loops Signed-off-by: Rhys Rustad-Elliott --- Documentation/bpf/bpf_design_QA.rst | 382 +++

Re: [PATCH v4] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 10:30:43 -0400 Michael S. Tsirkin wrote: > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > When control vq is not negotiated, that commit causes a crash: > > [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! Applied, thank you!

Re: [PATCH v4] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Jason Wang
On 2020/10/21 下午10:30, Michael S. Tsirkin wrote: This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. When control vq is not negotiated, that commit causes a crash: [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! [ 72.230266] invalid opcode: [#1] PREEMPT SMP [ 72

Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-21 Thread Xin Long
On Wed, Oct 21, 2020 at 5:13 PM Michael Tuexen wrote: > > > On 21. Oct 2020, at 06:16, Xin Long wrote: > > > > On Wed, Oct 21, 2020 at 5:23 AM Marcelo Ricardo Leitner > > wrote: > >> > >> On Tue, Oct 20, 2020 at 11:15:26PM +0200, Michael Tuexen wrote: > On 20. Oct 2020, at 23:11, Marcelo Ri

Re: [RFC PATCH net-next 7/9] net: dsa: microchip: ksz9477: add hardware time stamping support

2020-10-21 Thread Richard Cochran
On Thu, Oct 22, 2020 at 02:39:35AM +0300, Vladimir Oltean wrote: > So how _does_ that work for TI PHYTER? > > As far as we understand, the PHYTER appears to autonomously mangle PTP packets > in the following way: > - subtracting t2 on RX from the correctionField of the Pdelay_Req > - adding t3 on

Re: [RFC PATCH net-next 7/9] net: dsa: microchip: ksz9477: add hardware time stamping support

2020-10-21 Thread Richard Cochran
I'm just catching up with this. Really. Truly. Please -- Include the maintainer on CC for such patches! In case you don't know who that is, you can always consult the MAINTAINERS file. There you will find the following entry. PTP HARDWARE CLOCK SUPPORT M: Richard Cochran L:

RE: [EXT] Re: [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

2020-10-21 Thread Andy Duan
From: Greg Ungerer Sent: Thursday, October 22, 2020 9:14 AM > Hi Andrew, > > On 21/10/20 11:37 pm, Andrew Lunn wrote: > >> +if (fep->quirks & FEC_QUIRK_CLEAR_SETUP_MII) { > >> +/* Clear MMFR to avoid to generate MII event by writing > MSCR. > >> + * MII event generati

Re: [PATCH v3] rtnetlink: fix data overflow in rtnl_calcit()

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 10:00:53 +0800 zhudi wrote: > From: Di Zhu > > "ip addr show" command execute error when we have a physical > network card with a large number of VFs > > The return value of if_nlmsg_size() in rtnl_calcit() will exceed > range of u16 data type when any network cards has a lar

[PATCH 2/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097/6095/6185

2020-10-21 Thread Chris Packham
Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for the MV88E6097/6095/6185 so that ports 8 & 9 can be supported as serdes ports and directly connected to other network interfaces or to SFPs without a PHY. Signed-off-by: Chris Packham Reviewed-by: Andrew Lunn --- Changes in

[PATCH 0/4] net: dsa: mv88e6xxx: serdes link without phy

2020-10-21 Thread Chris Packham
This small series gets my hardware into a working state. The key points are to make sure we don't force the link and that we ask the MAC for the link status. I also have updated my dts to say `phy-mode = "1000base-x";` and `managed = "in-band-status";` I've included patch #4 in this series but I d

[PATCH 3/4] net: dsa: mv88e6xxx: Handle error in serdes_get_regs

2020-10-21 Thread Chris Packham
If the underlying read operation failed we would end up writing stale data to the supplied buffer. This would end up with the last successfully read value repeating. Fix this by only writing the data when we know the read was good. This will mean that failed values will return 0x. Signed-off-b

[PATCH 1/4] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-21 Thread Chris Packham
When a port is configured with 'managed = "in-band-status"' switch chips like the 88E6390 need to propagate the SERDES link state to the MAC because the link state is not correctly detected. This causes problems on the 88E6185/88E6097 where the link partner won't see link link state changes because

[PATCH 4/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-21 Thread Chris Packham
Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for the MV88E6123 so that the ports without a built-in PHY supported as serdes ports and directly connected to other network interfaces or to SFPs. Also implement serdes_get_regs_len and serdes_get_regs to aid future debugging. S

Re: [PATCH net] chelsio/chtls: Utilizing multiple rxq/txq to process requests

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 10:39:22 +0530 Vinay Kumar Yadav wrote: > On 10/21/2020 9:56 AM, Jakub Kicinski wrote: > > On Wed, 21 Oct 2020 01:13:06 +0530 Vinay Kumar Yadav wrote: > >> patch adds a logic to utilize multiple queues to process requests. > >> The queue selection logic uses a round-robin dist

Re: [PATCH net] net: hdlc_raw_eth: Clear the IFF_TX_SKB_SHARING flag after calling ether_setup

2020-10-21 Thread Xie He
On Wed, Oct 21, 2020 at 6:02 PM Jakub Kicinski wrote: > > Applied, thank you. > > In the future please try to provide a Fixes: tag. OK. Thanks! I'll remember this in the future!

Re: [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

2020-10-21 Thread Greg Ungerer
Hi Andrew, On 21/10/20 11:37 pm, Andrew Lunn wrote: + if (fep->quirks & FEC_QUIRK_CLEAR_SETUP_MII) { + /* Clear MMFR to avoid to generate MII event by writing MSCR. +* MII event generation condition: +* - writing MSCR: +* -

Re: [PATCH] net: ethernet: mtk-star-emac: select REGMAP_MMIO

2020-10-21 Thread Jakub Kicinski
On Tue, 20 Oct 2020 09:35:15 +0200 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The driver depends on mmio regmap API but doesn't select the appropriate > Kconfig option. This fixes it. > > Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") > Cc: No need, we queue a

Re: [PATCH net] net: hdlc_raw_eth: Clear the IFF_TX_SKB_SHARING flag after calling ether_setup

2020-10-21 Thread Jakub Kicinski
On Mon, 19 Oct 2020 23:34:20 -0700 Xie He wrote: > This driver calls ether_setup to set up the network device. > The ether_setup function would add the IFF_TX_SKB_SHARING flag to the > device. This flag indicates that it is safe to transmit shared skbs to > the device. > > However, this is not tru

[PATCH net] net: ipa: command payloads already mapped

2020-10-21 Thread Alex Elder
IPA transactions describe actions to be performed by the IPA hardware. Three cases use IPA transactions: transmitting a socket buffer; providing a page to receive packet data; and issuing an IPA immediate command. An IPA transaction contains a scatter/gather list (SGL) to hold the set of actions

Re: [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-21 Thread kernel test robot
Hi "Łukasz, I love your patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on arm/for-next net-next/master net/master linus/master sparc-next/master v5.9 next-20201021] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [RFC PATCH net-next 1/9] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-10-21 Thread Florian Fainelli
On 10/21/2020 5:16 PM, Vladimir Oltean wrote: On Wed, Oct 21, 2020 at 08:52:01AM +0200, Kurt Kanzenbach wrote: On Mon Oct 19 2020, Christian Eggers wrote: The node names should be switch. See dsa.yaml. +compatible = "microchip,ksz9477"; +reg = <0>; +reset

Re: [PATCH net v2] net: hdlc: In hdlc_rcv, check to make sure dev is an HDLC device

2020-10-21 Thread Jakub Kicinski
On Mon, 19 Oct 2020 18:31:52 -0700 Xie He wrote: > The hdlc_rcv function is used as hdlc_packet_type.func to process any > skb received in the kernel with skb->protocol == htons(ETH_P_HDLC). > The purpose of this function is to provide second-stage processing for > skbs not assigned a "real" L3 skb

Re: [PATCH net] selftests: mptcp: depends on built-in IPv6

2020-10-21 Thread Mat Martineau
On Wed, 21 Oct 2020, Matthieu Baerts wrote: Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6 will stay disabled and selftests will fail. We

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-21 Thread Jacob Keller
On 10/21/2020 5:02 PM, Jakub Kicinski wrote: > On Wed, 21 Oct 2020 22:25:48 +0200 Thomas Gleixner wrote: >> On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote: >>> On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote: However, IMHO we would still need a logic to prevent the devices fro

Re: [RFC PATCH net-next 1/9] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-10-21 Thread Vladimir Oltean
On Wed, Oct 21, 2020 at 08:52:01AM +0200, Kurt Kanzenbach wrote: > On Mon Oct 19 2020, Christian Eggers wrote: > The node names should be switch. See dsa.yaml. > > > +compatible = "microchip,ksz9477"; > > +reg = <0>; > > +reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-21 Thread Stephen Hemminger
On Thu, 22 Oct 2020 01:48:58 +0200 Petr Machata wrote: > Stephen Hemminger writes: > > > On Tue, 20 Oct 2020 22:43:37 +0200 > > Petr Machata wrote: > > > >> Jakub Kicinski writes: > >> > >> > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: > >> >> +static void dcb_ets_print_cbs(F

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 22:25:48 +0200 Thomas Gleixner wrote: > On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote: > > On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote: > >> However, IMHO we would still need a logic to prevent the devices from > >> creating excess vectors. > > > > Managed i

Re: [RFC][PATCH v3 3/3] Rename nla_strlcpy to nla_strscpy.

2020-10-21 Thread Kees Cook
On Tue, Oct 20, 2020 at 06:47:07PM +0200, laniel_fran...@privacyrequired.com wrote: > From: Francis Laniel > > Calls to nla_strlcpy are now replaced by calls to nla_strscpy which is the new > name of this function. > > Signed-off-by: Francis Laniel The Subject could also be: "treewide: Rename

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-21 Thread Petr Machata
Stephen Hemminger writes: > On Tue, 20 Oct 2020 22:43:37 +0200 > Petr Machata wrote: > >> Jakub Kicinski writes: >> >> > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: >> >> +static void dcb_ets_print_cbs(FILE *fp, const struct ieee_ets *ets) >> >> +{ >> >> + print_string(PRINT_ANY, "

Re: [RFC][PATCH v3 2/3] Modify return value of nla_strlcpy to match that of strscpy.

2020-10-21 Thread Kees Cook
On Tue, Oct 20, 2020 at 06:47:06PM +0200, laniel_fran...@privacyrequired.com wrote: > From: Francis Laniel > > nla_strlcpy now returns -E2BIG if src was truncated when written to dst. > It also returns this error value if dstsize is 0 or higher than INT_MAX. > > For example, if src is "foo\0" a

Re: [RFC][PATCH v3 1/3] Fix unefficient call to memset before memcpu in nla_strlcpy.

2020-10-21 Thread Kees Cook
On Tue, Oct 20, 2020 at 06:47:05PM +0200, laniel_fran...@privacyrequired.com wrote: > From: Francis Laniel > > Before this commit, nla_strlcpy first memseted dst to 0 then wrote src into > it. > This is inefficient because bytes whom number is less than src length are > written > twice. > > T

Re: [RFC PATCH net-next 7/9] net: dsa: microchip: ksz9477: add hardware time stamping support

2020-10-21 Thread Vladimir Oltean
On Mon, Oct 19, 2020 at 07:24:33PM +0200, Christian Eggers wrote: > Add routines required for TX hardware time stamping. > > The KSZ9563 only supports one step time stamping > (HWTSTAMP_TX_ONESTEP_P2P), which requires linuxptp-2.0 or later. PTP > mode is permanently enabled (changes tail tag; depe

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-21 Thread Al Viro
On Wed, Oct 21, 2020 at 06:13:01PM +0200, Greg KH wrote: > On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > > From: David Laight > > > > This lets the compiler inline it into import_iovec() generating > > much better code. > > > > Signed-off-by: David Laight > > Signed-off-b

Re: [PATCH bpf] bpf, libbpf: guard bpf inline asm from bpf_tail_call_static

2020-10-21 Thread Andrii Nakryiko
On Wed, Oct 21, 2020 at 1:33 PM Daniel Borkmann wrote: > > Yaniv reported a compilation error after pulling latest libbpf: > > [...] > ../libbpf/src/root/usr/include/bpf/bpf_helpers.h:99:10: error: > unknown register name 'r0' in asm > : "r0", "r1", "r2", "r3", "r4", "r5

Re: [PATCH net v2] ibmvnic: fix ibmvnic_set_mac

2020-10-21 Thread Maciej Fijalkowski
On Wed, Oct 21, 2020 at 01:07:12AM -0500, Lijun Pan wrote: > Jakub Kicinski brought up a concern in ibmvnic_set_mac(). > ibmvnic_set_mac() does this: > > ether_addr_copy(adapter->mac_addr, addr->sa_data); > if (adapter->state != VNIC_PROBED) > rc = __ibmvnic_set_mac(netde

Re: [PATCH v2 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip

2020-10-21 Thread Pali Rohár
On Tuesday 20 October 2020 14:57:54 Jerome Pouiller wrote: > From: Jérôme Pouiller > > Add Silabs SDIO ID to sdio_ids.h. > > Note that the values used by Silabs are uncommon. A driver cannot fully > rely on the SDIO PnP. It should also check if the device is declared in > the DT. > > Signed-off

Re: [PATCH bpf] bpf, libbpf: guard bpf inline asm from bpf_tail_call_static

2020-10-21 Thread Yaniv Agman
‫בתאריך יום ד׳, 21 באוק׳ 2020 ב-23:33 מאת ‪Daniel Borkmann‬‏ <‪dan...@iogearbox.net‬‏>:‬ > > Yaniv reported a compilation error after pulling latest libbpf: > > [...] > ../libbpf/src/root/usr/include/bpf/bpf_helpers.h:99:10: error: > unknown register name 'r0' in asm > :

Re: [PATCH bpf-next 1/3] bpf: Support for pointers beyond pkt_end.

2020-10-21 Thread kernel test robot
master config: i386-randconfig-r026-20201021 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/1aa4c81ae1dbbc3b6de7416f0384cde6cc8739b1 git remote add linux-review https://github.com/0day-ci/linux

Re: [PATCH bpf v3 1/2] bpf_redirect_neigh: Support supplying the nexthop as a helper parameter

2020-10-21 Thread David Ahern
On 10/20/20 3:25 PM, Toke Høiland-Jørgensen wrote: > From: Toke Høiland-Jørgensen > > Based on the discussion in [0], update the bpf_redirect_neigh() helper to > accept an optional parameter specifying the nexthop information. This makes > it possible to combine bpf_fib_lookup() and bpf_redirect_

[PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-21 Thread Łukasz Stelmach
ASIX AX88796[1] is a versatile ethernet adapter chip, that can be connected to a CPU with a 8/16-bit bus or with an SPI. This driver supports SPI connection. The driver has been ported from the vendor kernel for ARTIK5[2] boards. Several changes were made to adapt it to the current kernel which in

[PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-21 Thread Łukasz Stelmach
Add bindings for AX88796C SPI Ethernet Adapter. Signed-off-by: Łukasz Stelmach --- .../bindings/net/asix,ax88796c.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml diff --git a/Documentation/dev

[PATCH v3 0/5] AX88796C SPI Ethernet Adapter

2020-10-21 Thread Łukasz Stelmach
This is a driver for AX88796C Ethernet Adapter connected in SPI mode as found on ARTIK5 evaluation board. The driver has been ported from a v3.10.9 vendor kernel for ARTIK5 board. Changes in v3: - modify vendor-prefixes.yaml in a separate patch - fix several problems in the dt binding - re

[PATCH v3 4/5] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-21 Thread Łukasz Stelmach
Add node for ax88796c ethernet chip. Signed-off-by: Łukasz Stelmach --- arch/arm/boot/dts/exynos3250-artik5-eval.dts | 29 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts index 20446a

[PATCH v3 5/5] ARM: defconfig: Enable ax88796c driver

2020-10-21 Thread Łukasz Stelmach
Enable ax88796c driver for the ethernet chip on Exynos3250-based ARTIK5 boards. Signed-off-by: Łukasz Stelmach --- arch/arm/configs/exynos_defconfig | 2 ++ arch/arm/configs/multi_v7_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/

[PATCH v3 1/5] dt-bindings: vendor-prefixes: Add asix prefix

2020-10-21 Thread Łukasz Stelmach
Add the prefix for ASIX Electronics Corporation Signed-off-by: Łukasz Stelmach --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefi

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-21 Thread Nitesh Narayan Lal
On 10/21/20 4:25 PM, Thomas Gleixner wrote: > On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote: >> On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote: >>> However, IMHO we would still need a logic to prevent the devices from >>> creating excess vectors. >> Managed interrupts are preventing

RE: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-21 Thread David Laight
From: Greg KH > Sent: 21 October 2020 17:13 > > On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > > From: David Laight > > > > This lets the compiler inline it into import_iovec() generating > > much better code. > > > > Signed-off-by: David Laight > > Signed-off-by: Christoph

Re: [PATCH v1 net-next 2/5] net: mscc: ocelot: set vcap IS2 chain to goto PSFP chain

2020-10-21 Thread joergen.andrea...@microchip.com
The 10/20/2020 23:27, Vladimir Oltean wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Oct 20, 2020 at 03:23:18PM +0800, Xiaoliang Yang wrote: > > VSC9959 supports Per-Stream Filtering and Policing(PSFP), which is > > processing aft

Re: [PATCH bpf] bpf, libbpf: guard bpf inline asm from bpf_tail_call_static

2020-10-21 Thread Yonghong Song
On 10/21/20 1:32 PM, Daniel Borkmann wrote: Yaniv reported a compilation error after pulling latest libbpf: [...] ../libbpf/src/root/usr/include/bpf/bpf_helpers.h:99:10: error: unknown register name 'r0' in asm : "r0", "r1", "r2", "r3", "r4", "r5"); [...] Th

[PATCH bpf] bpf, libbpf: guard bpf inline asm from bpf_tail_call_static

2020-10-21 Thread Daniel Borkmann
Yaniv reported a compilation error after pulling latest libbpf: [...] ../libbpf/src/root/usr/include/bpf/bpf_helpers.h:99:10: error: unknown register name 'r0' in asm : "r0", "r1", "r2", "r3", "r4", "r5"); [...] The issue got triggered given Yaniv was compiling tracin

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-21 Thread Thomas Gleixner
On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote: > On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote: >> However, IMHO we would still need a logic to prevent the devices from >> creating excess vectors. > > Managed interrupts are preventing exactly that by pinning the interrupts > and queu

Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create

2020-10-21 Thread Saeed Mirzamohammadi
Attached the syzkaller C repro. Tested-by: Saeed Mirzamohammadi repro.c Description: Binary data > On Oct 20, 2020, at 9:45 AM, Saeed Mirzamohammadi > wrote: > > Thanks! Yes, that looks good to me. > > Saeed > >> On Oct 20, 2020, at 4:50 AM, Pablo Neira Ayuso wrote: >> >> On Mon, Oct 19

[RFC PATCH net-next 0/3] sock: Fix sock queue mapping to include device

2020-10-21 Thread Harshitha Ramamurthy
In XPS, the transmit queue selected for a packet is saved in the associated sock for the packet and is then used to avoid recalculating the queue on subsequent sends. The problem is that the corresponding device is not also recorded so that when the queue mapping is referenced it may correspond to

[RFC PATCH net-next 2/3] sock: Use dev_and_queue structure for RX queue mapping in sock

2020-10-21 Thread Harshitha Ramamurthy
From: Tom Herbert Replace sk_rx_queue_mapping with sk_rx_dev_and_queue_mapping and change associated function to set, get, and clear mapping. This patch ensures that the queue picked for transmit is correct by setting the queue and ifindex and then retrieving the queue number only if the ifindex

[RFC PATCH net-next 3/3] sock: Use dev_and_queue structure for TX queue mapping in sock

2020-10-21 Thread Harshitha Ramamurthy
From: Tom Herbert Replace sk_tx_queue_mapping with sk_tx_dev_and_queue_mapping and change associated functions to set, get, and clear mapping. This patch ensures that the queue picked for transmit is correct by setting the queue and ifindex and then retriveing the queue number only if the ifindex

[RFC PATCH net-next 1/3] sock: Definition and general functions for dev_and_queue structure

2020-10-21 Thread Harshitha Ramamurthy
From: Tom Herbert Add struct dev_and_queue which holds and ifindex and queue pair. Add generic functions to get the queue for the ifindex held as well as functions to set, clear the pair in a structure. Signed-off-by: Tom Herbert Signed-off-by: Harshitha Ramamurthy --- include/net/sock.h | 52

Re: lan78xx: /sys/class/net/eth0/carrier stuck at 1

2020-10-21 Thread Andrew Lunn
On Wed, Oct 21, 2020 at 05:00:53PM +0200, Juerg Haefliger wrote: > Hi, > > If the lan78xx driver is compiled into the kernel and the network cable is > plugged in at boot, /sys/class/net/eth0/carrier is stuck at 1 and doesn't > toggle if the cable is unplugged and replugged. > > If the network ca

[RFC,net-next, 4/4] selftests: add selftest for the SRv6 End.DT4 behavior

2020-10-21 Thread Andrea Mayer
this selftest is designed for evaluating the new SRv6 End.DT4 behavior used, in this example, for implementing IPv4 L3 VPN use cases. Signed-off-by: Andrea Mayer --- .../selftests/net/srv6_end_dt4_l3vpn_test.sh | 490 ++ 1 file changed, 490 insertions(+) create mode 100755 tool

[RFC,net-next, 1/4] vrf: push mac header for tunneled packets when sniffer is attached

2020-10-21 Thread Andrea Mayer
Before this patch, a sniffer attached to a VRF used as the receiving interface of L3 tunneled packets detects them as malformed packets and it complains about that (i.e.: tcpdump shows bogus packets). The reason is that a tunneled L3 packet does not carry any L2 information and when the VRF is set

[RFC,net-next, 3/4] seg6: add support for the SRv6 End.DT4 behavior

2020-10-21 Thread Andrea Mayer
SRv6 End.DT4 is defined in the SRv6 Network Programming [1]. The SRv6 End.DT4 is used to implement IPv4 L3VPN use-cases in multi-tenants environments. It decapsulates the received packets and it performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation

Re: [PATCH v3] net: macb: add support for high speed interface

2020-10-21 Thread Russell King - ARM Linux admin
On Wed, Oct 21, 2020 at 07:44:05PM +0200, Parshuram Thombare wrote: > This patch adds support for 10GBASE-R interface to the linux driver for > Cadence's ethernet controller. > This controller has separate MAC's and PCS'es for low and high speed paths. > High speed PCS supports 100M, 1G, 2.5G, 5G a

[RFC,net-next, 2/4] seg6: add callbacks for customizing the creation/destruction of a behavior

2020-10-21 Thread Andrea Mayer
We introduce two callbacks used for customizing the creation/destruction of a SRv6 behavior. Such callbacks are defined in the new struct seg6_local_lwtunnel_ops and hereafter we provide a brief description of them: - build_state(...): used for calling the custom constructor of the behavior du

[RFC,net-next, 0/4] seg6: add support for SRv6 End.DT4 behavior

2020-10-21 Thread Andrea Mayer
This patchset adds support for the SRv6 End.DT4 behavior. The SRv6 End.DT4 is used to implement multi-tenant IPv4 L3VPN. It decapsulates the received packets and performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation leverages a VRF device. SRv6 End.

Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions

2020-10-21 Thread David Ahern
On 10/21/20 12:32 PM, Stephen Hemminger wrote: > On Mon, 19 Oct 2020 17:23:01 +0200 > Guillaume Nault wrote: > >> +} else if (matches(*argv, "pop_eth") == 0) { > > Using matches allows for shorter command lines but can be make > for bad user experience if strings overlap. > > For ex

Re: [Bug 209767] New: Bonding 802.3ad layer2+3 transmits on both slaves within single connection

2020-10-21 Thread Jakub Kicinski
CC some bonding folks On Tue, 20 Oct 2020 07:54:29 -0700 Stephen Hemminger wrote: > Begin forwarded message: > > Date: Tue, 20 Oct 2020 10:42:34 + > From: bugzilla-dae...@bugzilla.kernel.org > To: step...@networkplumber.org > Subject: [Bug 209767] New: Bonding 802.3ad layer2+3 transmits on bo

Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions

2020-10-21 Thread Stephen Hemminger
On Mon, 19 Oct 2020 17:23:01 +0200 Guillaume Nault wrote: > + } else if (matches(*argv, "pop_eth") == 0) { Using matches allows for shorter command lines but can be make for bad user experience if strings overlap. For example 'p' here will match the pop_eth and not the push_eth. Is

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-21 Thread Stephen Hemminger
On Tue, 20 Oct 2020 22:43:37 +0200 Petr Machata wrote: > Jakub Kicinski writes: > > > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: > >> +static void dcb_ets_print_cbs(FILE *fp, const struct ieee_ets *ets) > >> +{ > >> + print_string(PRINT_ANY, "cbs", "cbs %s ", ets->cbs ? "on" : "o

[PATCH bpf-next 2/3] selftests/bpf: Add skb_pkt_end test

2020-10-21 Thread Alexei Starovoitov
From: Alexei Starovoitov Add a test that currently makes LLVM generate assembly code: $ llvm-objdump -S skb_pkt_end.o : ; if (skb_shorter(skb, ETH_IPV4_TCP_SIZE)) 0: 61 12 50 00 00 00 00 00 r2 = *(u32 *)(r1 + 80) 1: 61 14 4c 00 00 00 00 00 r4 = *(

[PATCH bpf-next 0/3] bpf: Pointers beyond packet end.

2020-10-21 Thread Alexei Starovoitov
From: Alexei Starovoitov In some cases LLVM uses the knowledge that branch is taken to optimze the code which causes the verifier to reject valid programs. Teach the verifier to recognize that r1 = skb->data; r1 += 10; r2 = skb->data_end; if (r1 > r2) { here r1 points beyond packet_end and subs

[PATCH bpf-next 3/3] selftests/bpf: Add asm tests for pkt vs pkt_end comparison.

2020-10-21 Thread Alexei Starovoitov
From: Alexei Starovoitov Add few assembly tests for packet comparison. Signed-off-by: Alexei Starovoitov --- .../testing/selftests/bpf/verifier/ctx_skb.c | 42 +++ 1 file changed, 42 insertions(+) diff --git a/tools/testing/selftests/bpf/verifier/ctx_skb.c b/tools/testing/se

[PATCH bpf-next 1/3] bpf: Support for pointers beyond pkt_end.

2020-10-21 Thread Alexei Starovoitov
From: Alexei Starovoitov This patch adds the verifier support to recognize inlined branch conditions. The LLVM knows that the branch evaluates to the same value, but the verifier couldn't track it. Hence causing valid programs to be rejected. The potential LLVM workaround: https://reviews.llvm.or

[PATCH v3] net: macb: add support for high speed interface

2020-10-21 Thread Parshuram Thombare
This patch adds support for 10GBASE-R interface to the linux driver for Cadence's ethernet controller. This controller has separate MAC's and PCS'es for low and high speed paths. High speed PCS supports 100M, 1G, 2.5G, 5G and 10G through rate adaptation implementation. However, since it doesn't sup

Re: [PATCH net] gianfar: Account for Tx PTP timestamp in the skb headroom

2020-10-21 Thread Jakub Kicinski
On Tue, 20 Oct 2020 20:36:05 +0300 Claudiu Manoil wrote: > When PTP timestamping is enabled on Tx, the controller > inserts the Tx timestamp at the beginning of the frame > buffer, between SFD and the L2 frame header. This means > that the skb provided by the stack is required to have > enough head

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-10-21 Thread Richard Guy Briggs
On 2020-10-21 12:49, Steve Grubb wrote: > On Wednesday, October 21, 2020 12:39:26 PM EDT Richard Guy Briggs wrote: > > > I think I have a way to generate a signal to multiple targets in one > > > syscall... The added challenge is to also give those targets different > > > audit container identifie

pressure for better clocks

2020-10-21 Thread rjmcmahon
Hi All, Iperf 2.0.14 provides end/end latency measurements but requires sync'ed clocks. The lack of attention to network latency is a major deficit to the networking industry and impairs user experience. I find one of the many problems with the tech industry is that cheap mass market stuff p

Re: [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 10:27:36 +0100 Russell King - ARM Linux admin wrote: > On Tue, Oct 20, 2020 at 01:12:49PM -0600, Robert Hancock wrote: > > The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper > > operation in 1000BaseX mode. It should be safe to ensure this bit is > > disabl

Re: [PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-21 Thread Chuck Lever
> On Oct 20, 2020, at 3:16 AM, Martijn de Gouw > wrote: > > Hi, > > On 20-10-2020 00:04, J. Bruce Fields wrote: >> On Mon, Oct 19, 2020 at 03:46:39PM +, Martijn de Gouw wrote: >>> Hi >>> >>> On 19-10-2020 17:23, J. Bruce Fields wrote: On Mon, Oct 19, 2020 at 01:42:27PM +0200, Marti

Re: [PATCH v3] tg3: Avoid NULL pointer dereference in netif_device_attach()

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 15:38:09 +0800 Defang Bo wrote: > Similar to commit<1b0ff89852d7>("tg3: Avoid NULL pointer dereference in > tg3_io_error_detected()") > This patch avoids NULL pointer dereference add a check for netdev being NULL > on tg3_resume(). > > Signed-off-by: Defang Bo Are you actua

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-10-21 Thread Steve Grubb
On Wednesday, October 21, 2020 12:39:26 PM EDT Richard Guy Briggs wrote: > > I think I have a way to generate a signal to multiple targets in one > > syscall... The added challenge is to also give those targets different > > audit container identifiers. > > Here is an exmple I was able to generat

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-10-21 Thread Richard Guy Briggs
On 2020-10-02 15:52, Richard Guy Briggs wrote: > On 2020-08-21 15:15, Paul Moore wrote: > > On Wed, Jul 29, 2020 at 3:41 PM Richard Guy Briggs wrote: > > > On 2020-07-05 11:10, Paul Moore wrote: > > > > On Sat, Jun 27, 2020 at 9:22 AM Richard Guy Briggs > > > > wrote: > > > > ... > > > > > > >

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Andrew Lunn
> i'll think about the frame-generator; Here were the two main problems i can remember with my first version: How do you discover what is can actually do? You probably need to collect up all the open PHY datasheets and get an idea what the different vendors provide, what is common, what could be

Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-21 Thread Greg KH
On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > From: David Laight > > This lets the compiler inline it into import_iovec() generating > much better code. > > Signed-off-by: David Laight > Signed-off-by: Christoph Hellwig > --- > fs/read_write.c | 179

[PATCH net] selftests: mptcp: depends on built-in IPv6

2020-10-21 Thread Matthieu Baerts
Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6 will stay disabled and selftests will fail. We also need CONFIG_IPV6 to be built-in. For more

Re: [PATCH net] mptcp: depends on IPV6 but not as a module

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 12:51:53 +0200 Matthieu Baerts wrote: > Like TCP, MPTCP cannot be compiled as a module. Obviously, MPTCP IPv6' > support also depends on CONFIG_IPV6. But not all functions from IPv6 > code are exported. > > To simplify the code and reduce modifications outside MPTCP, it was > d

lan78xx: /sys/class/net/eth0/carrier stuck at 1

2020-10-21 Thread Juerg Haefliger
Hi, If the lan78xx driver is compiled into the kernel and the network cable is plugged in at boot, /sys/class/net/eth0/carrier is stuck at 1 and doesn't toggle if the cable is unplugged and replugged. If the network cable is *not* plugged in at boot, all seems to work fine. I.e., post-boot cable

Re: [PATCH 2/2] net: phy: adin: implement cable-test support

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 5:28 PM Andrew Lunn wrote: > > > Actually, I'd also be interested [for this PHY], to report a > > "significance impedance" detection, which is similar to the > > short-detection that is already done. > > You can add that as just another element of the enum. > > > At first,

Re: [PATCH v4] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Willem de Bruijn
On Wed, Oct 21, 2020 at 10:30 AM Michael S. Tsirkin wrote: > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > When control vq is not negotiated, that commit causes a crash: > > [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! > [ 72.230266] invalid opcode: [#1]

  1   2   >