Re: [PATCH nf v2] netfilter: conntrack: connection timeout after re-register

2020-10-08 Thread Jozsef Kadlecsik
Hi Francesco, On Thu, 8 Oct 2020, Francesco Ruggeri wrote: > On Wed, Oct 7, 2020 at 12:32 PM Francesco Ruggeri wrote: > > > > If the first packet conntrack sees after a re-register is an outgoing > > keepalive packet with no data (SEG.SEQ = SND.NXT-1), td_end is set to > > SND.NXT-1. When the

Re: [PATCH bpf-next] bpf: add tcp_notsent_lowat bpf setsockopt

2020-10-08 Thread Nikita Shirokov
чт, 8 окт. 2020 г. в 23:27, Yonghong Song : > > > > On 10/8/20 10:08 PM, Nikita V. Shirokov wrote: > > Adding support for TCP_NOTSENT_LOWAT sockoption > > (https://lwn.net/Articles/560082/ ) in tcpbpf > > > > Signed-off-by: Nikita V. Shirokov > > --- > > include/uapi/linux/bpf.h

Re: [PATCH v2 bpf-next 3/4] selftests/bpf: Add profiler test

2020-10-08 Thread Yonghong Song
On 10/8/20 6:12 PM, Alexei Starovoitov wrote: From: Alexei Starovoitov The main purpose of the profiler test to check different llvm generation patterns to make sure the verifier can load these large programs. Note that profiler.inc.h test doesn't follow strict kernel coding style. The code

Re: [PATCH bpf-next] bpf: add tcp_notsent_lowat bpf setsockopt

2020-10-08 Thread Yonghong Song
On 10/8/20 10:08 PM, Nikita V. Shirokov wrote: Adding support for TCP_NOTSENT_LOWAT sockoption (https://lwn.net/Articles/560082/ ) in tcpbpf Signed-off-by: Nikita V. Shirokov --- include/uapi/linux/bpf.h | 2 +- net/core/filter.c |

[PATCH] net: intel: ice: Use uintptr_t for casting data

2020-10-08 Thread Pujin Shi
Fix up a compiler error on 64bit architectures where pointers. In file included from drivers/net/ethernet/intel/ice/ice_flex_pipe.c:6:0: drivers/net/ethernet/intel/ice/ice_flex_pipe.c: In function 'ice_free_flow_profs': drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from pointer

Re: [Patch net] can: initialize skbcnt in j1939_tp_tx_dat_new()

2020-10-08 Thread Marc Kleine-Budde
;> >> git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git >> tags/linux-can-fixes-for-5.9-20201008 >> >> I've send a proper pull request some seconds ago. > > Sorry for the rush but I didn't want to wait too much, since we're > already

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-08 Thread Kurt Kanzenbach
On Thu Oct 08 2020, Vladimir Oltean wrote: > On Tue, Oct 06, 2020 at 12:13:04PM +0200, Kurt Kanzenbach wrote: >> >> >> +static const struct hellcreek_platform_data de1soc_r1_pdata = { >> >> >> + .num_ports = 4, >> >> >> + .is_100_mbits= 1, >> >> >> + .qbv_support = 1, >

[PATCH net] net/tls: remove a duplicate function prototype

2020-10-08 Thread Randy Dunlap
Remove one of the two instances of the function prototype for tls_validate_xmit_skb(). Signed-off-by: Randy Dunlap Cc: Boris Pismenny Cc: Aviad Yehezkel Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Kicinski To: netdev@vger.kernel.org --- Sorry, resending to netdev@ also. include/net/tl

Re: [PATCH net 000/117] net: avoid to remove module when its debugfs is being used

2020-10-08 Thread Nicolai Stange
Taehee Yoo writes: > On Fri, 9 Oct 2020 at 01:14, Johannes Berg wrote: > On Thu, 2020-10-08 at 15:59 +, David Laight wrote: > >> From: Taehee Yoo >> > Sent: 08 October 2020 16:49 >> > >> > When debugfs file is opened, its module should not be removed until >> > it's closed. >> > Because debu

[PATCH bpf-next] bpf: add tcp_notsent_lowat bpf setsockopt

2020-10-08 Thread Nikita V. Shirokov
Adding support for TCP_NOTSENT_LOWAT sockoption (https://lwn.net/Articles/560082/) in tcpbpf Signed-off-by: Nikita V. Shirokov --- include/uapi/linux/bpf.h | 2 +- net/core/filter.c | 4 tools/testing/selftests/bpf/progs/connect4_pr

Re: [PATCH net 000/117] net: avoid to remove module when its debugfs is being used

2020-10-08 Thread Nicolai Stange
Johannes Berg writes: > On Thu, 2020-10-08 at 15:59 +, David Laight wrote: >> From: Taehee Yoo >> > Sent: 08 October 2020 16:49 >> > >> > When debugfs file is opened, its module should not be removed until >> > it's closed. >> > Because debugfs internally uses the module's data. >> > So, it

[bpf-next PATCH 6/6] bpf, sockmap: Add memory accounting so skbs on ingress lists are visible

2020-10-08 Thread John Fastabend
Move skb->sk assignment out of sk_psock_bpf_run() and into individual callers. Then we can use proper skb_set_owner_r() call to assign a sk to a skb. This improves things by also charging the truesize against the sockets sk_rmem_alloc counter. With this done we get some accounting in place to ensur

[bpf-next PATCH 4/6] bpf, sockmap: remove dropped data on errors in redirect case

2020-10-08 Thread John Fastabend
In the sk_skb redirect case we didn't handle the case where we overrun the sk_rmem_alloc entry on ingress redirect or sk_wmem_alloc on egress. Because we didn't have anything implemented we simply dropped the skb. This meant data could be dropped if socket memory accounting was in place. This fixe

[bpf-next PATCH 5/6] bpf, sockmap: Remove skb_orphan and let normal skb_kfree do cleanup

2020-10-08 Thread John Fastabend
Calling skb_orphan() is unnecessary in the strp rcv handler because the skb is from a skb_clone() in __strp_recv. So it never has a destructor or a sk assigned. Plus its confusing to read because it might hint to the reader that the skb could have an sk assigned which is not true. Even if we did ha

[bpf-next PATCH 3/6] bpf, sockmap: remove skb_set_owner_w wmem will be taken later from sendpage

2020-10-08 Thread John Fastabend
The skb_set_owner_w is unnecessary here. The sendpage call will create a fresh skb and set the owner correctly from workqueue. Its also not entirely harmless because it consumes cycles, but also impacts resource accounting by increasing sk_wmem_alloc. This is charging the socket we are going to sen

[bpf-next PATCH 2/6] bpf, sockmap: On receive programs try to fast track SK_PASS ingress

2020-10-08 Thread John Fastabend
When we receive an skb and the ingress skb verdict program returns SK_PASS we currently set the ingress flag and put it on the workqueue so it can be turned into a sk_msg and put on the sk_msg ingress queue. Then finally telling userspace with data_ready hook. Here we observe that if the workqueue

[bpf-next PATCH 0/6] sockmap/sk_skb program memory acct fixes

2020-10-08 Thread John Fastabend
Users of sockmap and skmsg trying to build proxys and other tools have pointed out to me the error handling can be problematic. If the proxy is under-provisioned and/or the BPF admin does not have the ability to update/modify memory provisions on the sockets its possible data may be dropped. For so

[bpf-next PATCH 1/6] bpf, sockmap: skb verdict SK_PASS to self already checked rmem limits

2020-10-08 Thread John Fastabend
For sk_skb case where skb_verdict program returns SK_PASS to continue to pass packet up the stack, the memory limits were already checked before enqueuing in skb_queue_tail from TCP side. So, lets remove the extra checks here. The theory is if the TCP stack believes we have memory to receive the pa

RE: [net] tipc: fix NULL pointer dereference in tipc_named_rcv

2020-10-08 Thread Hoang Huu Le
Hi Jon, Jakub, I tried with your comment. But looks like we got into circular locking and deadlock could happen like this: CPU0CPU1 lock(&n->lock#2); lock(&tn->nametbl_lock);

Re: [PATCH bpf-next V3 2/6] bpf: bpf_fib_lookup return MTU value as output when looked up

2020-10-08 Thread David Ahern
On 10/8/20 7:09 AM, Jesper Dangaard Brouer wrote: > The BPF-helpers for FIB lookup (bpf_xdp_fib_lookup and bpf_skb_fib_lookup) > can perform MTU check and return BPF_FIB_LKUP_RET_FRAG_NEEDED. The BPF-prog > don't know the MTU value that caused this rejection. > > If the BPF-prog wants to implemen

Re: [PATCH v2] vringh: fix __vringh_iov() when riov and wiov are different

2020-10-08 Thread Jason Wang
On 2020/10/9 上午4:42, Stefano Garzarella wrote: If riov and wiov are both defined and they point to different objects, only riov is initialized. If the wiov is not initialized by the caller, the function fails returning -EINVAL and printing "Readable desc 0x... after writable" error message. Th

Re: [RFC PATCH 18/24] vhost-vdpa: support ASID based IOTLB API

2020-10-08 Thread Jason Wang
On 2020/9/28 下午11:44, Eugenio Perez Martin wrote: -u64 iova, u64 size) +static int vhost_vdpa_unmap(struct vhost_vdpa *v, + struct vhost_iotlb *iotlb, + u64 iova, u64 size) { struct vdpa_device *vdpa = v-

Re: [PATCH bpf-next 5/6] bpf, selftests: make redirect_neigh test more extensible

2020-10-08 Thread Yonghong Song
On 10/8/20 2:31 PM, Daniel Borkmann wrote: Rename into test_tc_redirect.sh and move setup and test code into separate functions so they can be reused for newly added tests in here. Also remove the crude hack to override ifindex inside the object file via xxd and sed and just use a simple map i

Re: [RFC PATCH 10/24] vdpa: introduce config operations for associating ASID to a virtqueue group

2020-10-08 Thread Jason Wang
On 2020/10/1 下午9:29, Eli Cohen wrote: On Thu, Sep 24, 2020 at 11:21:11AM +0800, Jason Wang wrote: This patch introduces a new bus operation to allow the vDPA bus driver to associate an ASID to a virtqueue group. So in case of virtio_net, I would expect that all the data virtqueues will be as

Re: [RFC PATCH 09/24] vdpa: multiple address spaces support

2020-10-08 Thread Jason Wang
On 2020/10/1 下午9:23, Eli Cohen wrote: + /* Only support 1 address space */ + if (vdpa->ngroups != 1) + return -ENOTSUPP; Checkpatch warning: prefer EOPNOTSUPP Will fix. Thanks

Re: [RFC PATCH 09/24] vdpa: multiple address spaces support

2020-10-08 Thread Jason Wang
On 2020/10/1 下午9:21, Eli Cohen wrote: On Thu, Sep 24, 2020 at 11:21:10AM +0800, Jason Wang wrote: This patches introduces the multiple address spaces support for vDPA device. This idea is to identify a specific address space via an dedicated identifier - ASID. During vDPA device allocation, v

Re: [RFC PATCH 08/24] vdpa: introduce virtqueue groups

2020-10-08 Thread Jason Wang
On 2020/9/28 下午11:44, Eugenio Perez Martin wrote: On Thu, Sep 24, 2020 at 5:23 AM Jason Wang wrote: This patch introduces virtqueue groups to vDPA device. The virtqueue group is the minimal set of virtqueues that must share an address space. And the adddress space identifier could only be att

Re: [RFC PATCH 06/24] vhost-vdpa: switch to use vhost-vdpa specific IOTLB

2020-10-08 Thread Jason Wang
On 2020/9/30 下午8:02, Eli Cohen wrote: On Thu, Sep 24, 2020 at 11:21:07AM +0800, Jason Wang wrote: To ease the implementation of per group ASID support for vDPA device. This patch switches to use a vhost-vdpa specific IOTLB to avoid the unnecessary refactoring of the vhost core. Signed-off-by:

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-10-08 Thread Marcin Wojtas
Hi, sob., 20 cze 2020 o 11:21 Russell King napisał(a): > > Add a helper to convert the struct phylink_config pointer passed in > from phylink to the drivers internal struct mvpp2_port. > > Signed-off-by: Russell King > --- > .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 29 +--

Re: [PATCH bpf-next 4/6] bpf, selftests: add test for different array inner map size

2020-10-08 Thread Yonghong Song
On 10/8/20 2:31 PM, Daniel Borkmann wrote: Extend the "diff_size" subtest to also include a non-inlined array map variant where dynamic inner #elems are possible. Signed-off-by: Daniel Borkmann Ack with a minor comment below. Acked-by: Yonghong Song --- .../selftests/bpf/prog_tests/b

Fw: [Bug 209579] New: MPLS not forwarding packet, if packet type is not ipv4, ipv6

2020-10-08 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 08 Oct 2020 07:33:23 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 209579] New: MPLS not forwarding packet, if packet type is not ipv4, ipv6 https://bugzilla.kernel.org/show_bug.cgi?id=209579 Bug

Re: [PATCH bpf-next 3/6] bpf: allow for map-in-map with dynamic inner array map entries

2020-10-08 Thread Yonghong Song
On 10/8/20 2:31 PM, Daniel Borkmann wrote: Recent work in f4d05259213f ("bpf: Add map_meta_equal map ops") and 134fede4eecf ("bpf: Relax max_entries check for most of the inner map types") added support for dynamic inner max elements for most map-in-map types. Exceptions were maps like array o

Re: [Patch net] tipc: fix the skb_unshare() in tipc_buf_append()

2020-10-08 Thread Xin Long
On Fri, Oct 9, 2020 at 1:45 AM Cong Wang wrote: > > On Thu, Oct 8, 2020 at 1:45 AM Xin Long wrote: > > > > On Thu, Oct 8, 2020 at 12:12 PM Cong Wang wrote: > > > > > > skb_unshare() drops a reference count on the old skb unconditionally, > > > so in the failure case, we end up freeing the skb tw

Re: [net-next PATCH v1] net: phy: Move of_mdio from drivers/of to drivers/net/mdio

2020-10-08 Thread Florian Fainelli
On 10/8/2020 7:20 PM, Calvin Johnson wrote: Hi Rob, On Thu, Oct 08, 2020 at 11:35:07AM -0500, Rob Herring wrote: On Thu, Oct 8, 2020 at 9:47 AM Calvin Johnson wrote: Better place for of_mdio.c is drivers/net/mdio. Move of_mdio.c from drivers/of to drivers/net/mdio One thing off my todo

Re: [net-next PATCH v1] net: phy: Move of_mdio from drivers/of to drivers/net/mdio

2020-10-08 Thread Calvin Johnson
Hi Rob, On Thu, Oct 08, 2020 at 11:35:07AM -0500, Rob Herring wrote: > On Thu, Oct 8, 2020 at 9:47 AM Calvin Johnson > wrote: > > > > Better place for of_mdio.c is drivers/net/mdio. > > Move of_mdio.c from drivers/of to drivers/net/mdio > > One thing off my todo list. I'd started this ages ago[1

Re: [PATCHv2 net-next 17/17] sctp: enable udp tunneling socks

2020-10-08 Thread Xin Long
1-UDP-Encapsulation-of-SCTP/20201008-175211 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > 9faebeb2d80065926dfbc09cb73b1bb7779a89cd > config: i386-randconfig-s002-20201008 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > rep

Re: [RFC PATCH 05/24] vhost-vdpa: passing iotlb to IOMMU mapping helpers

2020-10-08 Thread Jason Wang
On 2020/9/30 下午7:26, Eli Cohen wrote: On Thu, Sep 24, 2020 at 11:21:06AM +0800, Jason Wang wrote: To prepare for the ASID support for vhost-vdpa, try to pass IOTLB object to dma helpers. Maybe it's worth mentioning here that this patch does not change any functionality and is presented as a p

Re: [PATCHv2 net-next 05/17] sctp: create udp4 sock and add its encap_rcv

2020-10-08 Thread Xin Long
On Fri, Oct 9, 2020 at 2:30 AM kernel test robot wrote: > > Hi Xin, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Enc

Re: [PATCHv2 net-next 06/17] sctp: create udp6 sock and set its encap_rcv

2020-10-08 Thread Xin Long
On Fri, Oct 9, 2020 at 5:20 AM kernel test robot wrote: > > Hi Xin, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Enc

Re: [PATCHv2 net-next 02/17] udp6: move the mss check after udp gso tunnel processing

2020-10-08 Thread Xin Long
On Thu, Oct 8, 2020 at 8:45 PM Willem de Bruijn wrote: > > On Thu, Oct 8, 2020 at 5:48 AM Xin Long wrote: > > > > For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for > > gso_size. When using UDP to encapsulate its packet, it will > > return error in udp6_ufo_fragment() as skb->len < g

Re: [PATCH net-next v2] virtio-net: ethtool configurable RXCSUM

2020-10-08 Thread Tonghao Zhang
On Wed, Sep 30, 2020 at 6:05 PM Willem de Bruijn wrote: > > On Wed, Sep 30, 2020 at 4:05 AM wrote: > > > > From: Tonghao Zhang > > > > Allow user configuring RXCSUM separately with ethtool -K, > > reusing the existing virtnet_set_guest_offloads helper > > that configures RXCSUM for XDP. This is

[PATCH v2 bpf-next 1/4] bpf: Propagate scalar ranges through register assignments.

2020-10-08 Thread Alexei Starovoitov
From: Alexei Starovoitov The llvm register allocator may use two different registers representing the same virtual register. In such case the following pattern can be observed: 1047: (bf) r9 = r6 1048: (a5) if r6 < 0x1000 goto pc+1 1050: ... 1051: (a5) if r9 < 0x2 goto pc+66 1052: ... 1053: (bf)

[PATCH v2 bpf-next 2/4] bpf: Track spill/fill of bounded scalars.

2020-10-08 Thread Alexei Starovoitov
From: Yonghong Song Under register pressure the llvm may spill registers with bounds into the stack. The verifier has to track them through spill/fill otherwise many kinds of bound errors will be seen. The spill/fill of induction variables was already happening. This patch extends this logic from

[PATCH v2 bpf-next 0/4] bpf: Make the verifier recognize llvm register allocation patterns.

2020-10-08 Thread Alexei Starovoitov
From: Alexei Starovoitov v1->v2: - fixed 32-bit mov issue spotted by John. - allowed r2=r1; r3=r2; sequence as suggested by John. - added comments, acks, more tests. Make two verifier improvements: - The llvm register allocator may use two different registers representing the same virtual regi

[PATCH v2 bpf-next 3/4] selftests/bpf: Add profiler test

2020-10-08 Thread Alexei Starovoitov
From: Alexei Starovoitov The main purpose of the profiler test to check different llvm generation patterns to make sure the verifier can load these large programs. Note that profiler.inc.h test doesn't follow strict kernel coding style. The code was formatted in the kernel style, but variable de

[PATCH v2 bpf-next 4/4] selftests/bpf: Asm tests for the verifier regalloc tracking.

2020-10-08 Thread Alexei Starovoitov
From: Alexei Starovoitov Add asm tests for register allocator tracking logic. Signed-off-by: Alexei Starovoitov Acked-by: Andrii Nakryiko --- .../testing/selftests/bpf/verifier/regalloc.c | 243 ++ 1 file changed, 243 insertions(+) create mode 100644 tools/testing/selftests/b

Re: [PATCH net-next] ne2k-pci: Enable RW-Bugfix

2020-10-08 Thread Jakub Kicinski
On Tue, 6 Oct 2020 18:56:06 +0200 Armin Wolf wrote: > Enable the ne2k-pci Read-before-Write Bugfix > since not doing so could (according to the Datasheet) > cause the system to lock up with some chips. > > Signed-off-by: Armin Wolf > --- > drivers/net/ethernet/8390/ne2k-pci.c | 2 +- > 1 file c

Re: [PATCH net-next] selftests: mptcp: interpret \n as a new line

2020-10-08 Thread Jakub Kicinski
On Tue, 06 Oct 2020 18:12:45 +0200 Paolo Abeni wrote: > On Tue, 2020-10-06 at 18:06 +0200, Matthieu Baerts wrote: > > In case of errors, this message was printed: > > > > (...) > > balanced bwidth with unbalanced delay 5233 max 5005 [ fail ] > > client exit code 0, server 0 > > \nne

Re: [PATCH net-next] net: mscc: ocelot: add missing VCAP ES0 and IS1 regmaps for VSC7514

2020-10-08 Thread Jakub Kicinski
On Tue, 6 Oct 2020 18:02:48 +0300 Vladimir Oltean wrote: > Without these definitions, the driver will crash in: > mscc_ocelot_probe > -> ocelot_init >-> ocelot_vcap_init > -> __ocelot_target_read_ix > > I missed this because I did not have the VSC7514 hardware to test, only > the VSC99

Re: [PATCH][RESEND] net: fec: Fix PHY init after phy_reset_after_clk_enable()

2020-10-08 Thread Jakub Kicinski
On Tue, 6 Oct 2020 15:52:53 +0200 Marek Vasut wrote: > The phy_reset_after_clk_enable() does a PHY reset, which means the PHY > loses its register settings. The fec_enet_mii_probe() starts the PHY > and does the necessary calls to configure the PHY via PHY framework, > and loads the correct regist

Re: [PATCH] net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()

2020-10-08 Thread Jakub Kicinski
On Wed, 7 Oct 2020 00:02:42 +0200 Marek Vasut wrote: > On 10/6/20 11:09 PM, Florian Fainelli wrote: > > On 10/6/2020 1:20 PM, Marek Vasut wrote: > >> The phy_reset_after_clk_enable() is always called with ndev->phydev, > >> however that pointer may be NULL even though the PHY device instance > >>

Re: [PATCH net-next] mptcp: fix infinite loop on recvmsg()/worker() race.

2020-10-08 Thread Jakub Kicinski
On Tue, 6 Oct 2020 08:27:34 +0200 Paolo Abeni wrote: > If recvmsg() and the workqueue race to dequeue the data > pending on some subflow, the current mapping for such > subflow covers several skbs and some of them have not > reached yet the received, either the worker or recvmsg() > can find a sub

Re: [PATCH net-next] net/sched: get rid of qdisc->padded

2020-10-08 Thread Jakub Kicinski
On Wed, 7 Oct 2020 09:51:11 -0700 Eric Dumazet wrote: > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h > index > 6c762457122fd0091cb0f2bf41bda73babc4ac12..d8fd8676fc724110630904909f64d7789f3a4b47 > 100644 > --- a/include/net/sch_generic.h > +++ b/include/net/sch_generic.h > @

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-08 Thread Coiby Xu
On Thu, Oct 08, 2020 at 04:39:40PM +0300, Dan Carpenter wrote: On Thu, Oct 08, 2020 at 07:58:04PM +0800, Coiby Xu wrote: -static int -qlge_reporter_coredump(struct devlink_health_reporter *reporter, - struct devlink_fmsg *fmsg, void *priv_ctx, - struct

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Coiby Xu
On Thu, Oct 08, 2020 at 04:31:42PM +0300, Dan Carpenter wrote: On Thu, Oct 08, 2020 at 07:58:03PM +0800, Coiby Xu wrote: Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu --- drivers/staging/qlge/Kconfig| 1

Re: [PATCH net-next RFC v1 00/10] nvme-tcp receive offloads

2020-10-08 Thread Sagi Grimberg
On 9/30/20 9:20 AM, Boris Pismenny wrote: This series adds support for nvme-tcp receive offloads which do not mandate the offload of the network stack to the device. Instead, these work together with TCP to offload: 1. copy from SKB to the block layer buffers 2. CRC verification for received P

Re: [PATCH] cxgb4: convert tasklets to use new tasklet_setup() API

2020-10-08 Thread Jakub Kicinski
On Tue, 6 Oct 2020 11:23:32 +0530 Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-o

Re: [next-next v3 05/10] net: cdc_ncm: convert tasklets to use new tasklet_setup() API

2020-10-08 Thread Jakub Kicinski
On Tue, 6 Oct 2020 11:41:54 +0530 Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > @@ -815,7

Re: [PATCH] net: stmmac: Don't call _irqoff() with hardirqs enabled

2020-10-08 Thread Vladimir Oltean
On Thu, Oct 08, 2020 at 05:27:49PM +0100, John Keeping wrote: > With threadirqs, stmmac_interrupt() is called on a thread with hardirqs > enabled so we cannot call __napi_schedule_irqoff(). Under lockdep it > leads to: > > [ cut here ] > WARNING: CPU: 0 PID: 28

Re: [PATCH nf v2] netfilter: conntrack: connection timeout after re-register

2020-10-08 Thread Francesco Ruggeri
On Wed, Oct 7, 2020 at 12:32 PM Francesco Ruggeri wrote: > > If the first packet conntrack sees after a re-register is an outgoing > keepalive packet with no data (SEG.SEQ = SND.NXT-1), td_end is set to > SND.NXT-1. > When the peer correctly acknowledges SND.NXT, tcp_in_window fails > check III (U

Re: [Patch net] ip_gre: set dev->hard_header_len properly

2020-10-08 Thread Xie He
On Thu, Oct 8, 2020 at 2:54 PM Xie He wrote: > > OK. If the t->encap_hlen header needs to be placed before the GRE > header, then I think the ipgre_header function should leave some space > before the GRE header to place the t->encap_hlen header, rather than > leaving space after the GRE header.

Re: [PATCH 1/2] ethtool: strset: allow ETHTOOL_A_STRSET_COUNTS_ONLY attr

2020-10-08 Thread Jakub Kicinski
On Wed, 7 Oct 2020 12:53:50 +0200 Johannes Berg wrote: > From: Johannes Berg > > The ETHTOOL_A_STRSET_COUNTS_ONLY flag attribute was previously > not allowed to be used, but now due to the policy size reduction > we would access the tb[] array out of bounds since we tried to > check for the attr

Re: [PATCH net-next RFC v1 01/10] iov_iter: Skip copy in memcpy_to_page if src==dst

2020-10-08 Thread Sagi Grimberg
You probably want Al to have a look at this..

Re: [PATCH net-next RFC v1 06/10] nvme-tcp: Add DDP data-path

2020-10-08 Thread Sagi Grimberg
  static   int nvme_tcp_offload_socket(struct nvme_tcp_queue *queue,   struct nvme_tcp_config *config) @@ -630,6 +720,7 @@ static void nvme_tcp_error_recovery(struct nvme_ctrl *ctrl)   static int nvme_tcp_process_nvme_cqe(struct nvme_tcp_queue *queue,   struct nvme_com

Re: [PATCH net-next RFC v1 08/10] nvme-tcp: Deal with netdevice DOWN events

2020-10-08 Thread Sagi Grimberg
On 9/30/20 9:20 AM, Boris Pismenny wrote: From: Or Gerlitz For ddp setup/teardown and resync, the offloading logic uses HW resources at the NIC driver such as SQ and CQ. These resources are destroyed when the netdevice does down and hence we must stop using them before the NIC driver destro

Re: [PATCH net-next RFC v1 07/10] nvme-tcp : Recalculate crc in the end of the capsule

2020-10-08 Thread Sagi Grimberg
crc offload of the nvme capsule. Check if all the skb bits are on, and if not recalculate the crc in SW and check it. Can you clarify in the patch description that this is only for pdu data digest and not header digest? This patch reworks the receive-side crc calculation to always run at t

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-08 Thread Dan Williams
On Thu, Oct 8, 2020 at 3:04 PM Ertman, David M wrote: > > > -Original Message- > > From: Leon Romanovsky > > Sent: Tuesday, October 6, 2020 10:23 AM > > To: Ertman, David M > > Cc: alsa-de...@alsa-project.org; ti...@suse.de; broo...@kernel.org; linux- > > r...@vger.kernel.org; j...@nvidi

Re: [PATCH net-next RFC v1 06/10] nvme-tcp: Add DDP data-path

2020-10-08 Thread Sagi Grimberg
bool nvme_tcp_resync_request(struct sock *sk, u32 seq, u32 flags); +void nvme_tcp_ddp_teardown_done(void *ddp_ctx); const struct tcp_ddp_ulp_ops nvme_tcp_ddp_ulp_ops __read_mostly = { + .resync_request = nvme_tcp_resync_request, + .ddp_teardown_done = nvme_tcp_ddp

Re: [Patch net] can: initialize skbcnt in j1939_tp_tx_dat_new()

2020-10-08 Thread Jakub Kicinski
> > That tag includes my previous oneline-patch-pull-request from 20201006, that > fixes the c_can driver on basically all stm32mp1 based boards. Would be good > to > see that in 5.9, as well. > > git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git > tags/linux-

Re: [PATCH net-next RFC v1 05/10] nvme-tcp: Add DDP offload control path

2020-10-08 Thread Sagi Grimberg
On 9/30/20 9:20 AM, Boris Pismenny wrote: This commit introduces direct data placement offload to NVME TCP. There is a context per queue, which is established after the handshake using the tcp_ddp_sk_add/del NDOs. Additionally, a resynchronization routine is used to assist hardware recovery f

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-08 Thread Ertman, David M
> -Original Message- > From: Leon Romanovsky > Sent: Tuesday, October 6, 2020 10:23 AM > To: Ertman, David M > Cc: alsa-de...@alsa-project.org; ti...@suse.de; broo...@kernel.org; linux- > r...@vger.kernel.org; j...@nvidia.com; dledf...@redhat.com; > netdev@vger.kernel.org; da...@davemloft

[PATCH][next] wlcore: Use fallthrough pseudo-keyword

2020-10-08 Thread Gustavo A. R. Silva
In order to enable -Wimplicit-fallthrough for Clang[1], replace the existing /* fall-through */ comments with the new pseudo-keyword macro fallthrough[2]. [1] https://git.kernel.org/linus/e2079e93f562c7f7a030eb7642017ee5eabaaa10 [2] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?hig

Re: [PATCH bpf-next 1/6] bpf: improve bpf_redirect_neigh helper description

2020-10-08 Thread David Ahern
On 10/8/20 2:31 PM, Daniel Borkmann wrote: > Follow-up to address David's feedback that we should better describe internals > of the bpf_redirect_neigh() helper. > > Suggested-by: David Ahern > Signed-off-by: Daniel Borkmann > --- > include/uapi/linux/bpf.h | 10 +++--- > tools/includ

Re: [PATCH bpf-next] bpf_fib_lookup: return target ifindex even if neighbour lookup fails

2020-10-08 Thread David Ahern
On 10/8/20 1:57 PM, Toke Høiland-Jørgensen wrote: > David Ahern writes: > >> On 10/8/20 7:53 AM, Toke Høiland-Jørgensen wrote: >>> The bpf_fib_lookup() helper performs a neighbour lookup for the destination >>> IP and returns BPF_FIB_LKUP_NO_NEIGH if this fails, with the expectation >>> that the

[PATCH][next] ray_cs: Use fallthrough pseudo-keyword

2020-10-08 Thread Gustavo A. R. Silva
In order to enable -Wimplicit-fallthrough for Clang[1], replace the existing /* fall through */ comments with the new pseudo-keyword macro fallthrough[2]. [1] https://git.kernel.org/linus/e2079e93f562c7f7a030eb7642017ee5eabaaa10 [2] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?hig

Re: [PATCH net-next RFC v1 04/10] net/tls: expose get_netdev_for_sock

2020-10-08 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [Patch net] ip_gre: set dev->hard_header_len properly

2020-10-08 Thread Xie He
On Thu, Oct 8, 2020 at 2:48 PM Willem de Bruijn wrote: > > > I see the ipgre_xmit function would pull the header our header_ops > > creates, and then call __gre_xmit. __gre_xmit will call > > gre_build_header to complete the GRE header. gre_build_header expects > > to find the base GRE header afte

Re: [PATCH net-next RFC v1 03/10] net: Introduce crc offload for tcp ddp ulp

2020-10-08 Thread Sagi Grimberg
This commit itroduces support for CRC offload to direct data placement introduces ULP on the receive side. Both DDP and CRC share a common API to initialize the offload for a TCP socket. But otherwise, both can be executed independently. From the API it not clear that the offl

Re: [PATCH net-next RFC v1 02/10] net: Introduce direct data placement tcp offload

2020-10-08 Thread Sagi Grimberg
+ * tcp_ddp.h + * Author: Boris Pismenny + * Copyright (C) 2020 Mellanox Technologies. + */ +#ifndef _TCP_DDP_H +#define _TCP_DDP_H + +#include Why is blkdev.h needed? +#include +#include +#include + +/* limits returned by the offload driver, zero means don't care */ +struct tc

Re: [Patch net] ip_gre: set dev->hard_header_len properly

2020-10-08 Thread Willem de Bruijn
On Thu, Oct 8, 2020 at 5:36 PM Xie He wrote: > > On Thu, Oct 8, 2020 at 1:32 PM Willem de Bruijn > wrote: > > > > On Thu, Oct 8, 2020 at 4:11 PM Xie He wrote: > > > > > > OK. I understand that t->tun_hlen is the GRE header length. What is > > > t->encap_hlen? > > > > I've looked at that closely

Re: [Patch net] can: initialize skbcnt in j1939_tp_tx_dat_new()

2020-10-08 Thread Marc Kleine-Budde
to net, in case there is a last > minute PR to Linus for 5.9? Yes, of you can pull Cong Wang's patch and my patch, that fixes the other missing init of skbcnt. That tag includes my previous oneline-patch-pull-request from 20201006, that fixes the c_can driver on basically all stm32mp1 ba

[PATCH 1/3] can: m_can_platform: don't call m_can_class_suspend in runtime suspend

2020-10-08 Thread Marc Kleine-Budde
From: Lucas Stach 0704c5743694 can: m_can_platform: remove unnecessary m_can_class_resume() call removed the m_can_class_resume() call in the runtime resume path to get rid of a infinite recursion, so the runtime resume now only handles the device clocks. Unfortunately it did not remove th

[PATCH 3/3] net: j1939: j1939_session_fresh_new(): fix missing initialization of skbcnt

2020-10-08 Thread Marc Kleine-Budde
This patch add the initialization of skbcnt, similar to: e009f95b1543 can: j1935: j1939_tp_tx_dat_new(): fix missing initialization of skbcnt Let's play save and initialize this skbcnt as well. Suggested-by: Jakub Kicinski Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") Sign

Re: [PATCH v4 0/4] isolation: limit msix vectors to housekeeping CPUs

2020-10-08 Thread Nitesh Narayan Lal
On 10/1/20 11:49 AM, Frederic Weisbecker wrote: > On Mon, Sep 28, 2020 at 02:35:25PM -0400, Nitesh Narayan Lal wrote: >> Nitesh Narayan Lal (4): >> sched/isolation: API to get number of housekeeping CPUs >> sched/isolation: Extend nohz_full to isolate managed IRQs >> i40e: Limit msix vectors

pull-request: can 2020-10-08

2020-10-08 Thread Marc Kleine-Budde
/mkl/linux-can.git tags/linux-can-fixes-for-5.9-20201008 for you to fetch changes up to 13ba4c434422837d7c8c163f9c8d854e67bf3c99: net: j1939: j1939_session_fresh_new(): fix missing initialization of skbcnt (2020-10-08 23:28:09 +0200) --

[PATCH 2/3] can: j1935: j1939_tp_tx_dat_new(): fix missing initialization of skbcnt

2020-10-08 Thread Marc Kleine-Budde
From: Cong Wang This fixes an uninit-value warning: BUG: KMSAN: uninit-value in can_receive+0x26b/0x630 net/can/af_can.c:650 Reported-and-tested-by: syzbot+3f3837e61a48d32b4...@syzkaller.appspotmail.com Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") Cc: Robin van der Gracht Cc:

Re: [GIT PULL] Networking

2020-10-08 Thread pr-tracker-bot
The pull request you sent on Thu, 8 Oct 2020 13:23:29 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6288c1d8024eebb7a1ccdbab80f6e857ac94eeb0 Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] vhost,vdpa: last minute fixes

2020-10-08 Thread pr-tracker-bot
The pull request you sent on Thu, 8 Oct 2020 16:30:51 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3fdd47c3b40ac48e6e6e5904cf24d12e6e073a96 Thank you! -- Deet-doot-dot, I am a bo

Re: [Patch net] ip_gre: set dev->hard_header_len properly

2020-10-08 Thread Xie He
On Thu, Oct 8, 2020 at 1:32 PM Willem de Bruijn wrote: > > On Thu, Oct 8, 2020 at 4:11 PM Xie He wrote: > > > > OK. I understand that t->tun_hlen is the GRE header length. What is > > t->encap_hlen? > > I've looked at that closely either. > > Appears to be to account for additional FOU/GUE encap:

[PATCH bpf-next 3/6] bpf: allow for map-in-map with dynamic inner array map entries

2020-10-08 Thread Daniel Borkmann
Recent work in f4d05259213f ("bpf: Add map_meta_equal map ops") and 134fede4eecf ("bpf: Relax max_entries check for most of the inner map types") added support for dynamic inner max elements for most map-in-map types. Exceptions were maps like array or prog array where the map_gen_lookup() callback

[PATCH bpf-next 2/6] bpf: add redirect_peer helper

2020-10-08 Thread Daniel Borkmann
Add an efficient ingress to ingress netns switch that can be used out of tc BPF programs in order to redirect traffic from host ns ingress into a container veth device ingress without having to go via CPU backlog queue [0]. For local containers this can also be utilized and path via CPU backlog que

[PATCH bpf-next 4/6] bpf, selftests: add test for different array inner map size

2020-10-08 Thread Daniel Borkmann
Extend the "diff_size" subtest to also include a non-inlined array map variant where dynamic inner #elems are possible. Signed-off-by: Daniel Borkmann --- .../selftests/bpf/prog_tests/btf_map_in_map.c | 39 - .../selftests/bpf/progs/test_btf_map_in_map.c | 43 +++

[PATCH bpf-next 1/6] bpf: improve bpf_redirect_neigh helper description

2020-10-08 Thread Daniel Borkmann
Follow-up to address David's feedback that we should better describe internals of the bpf_redirect_neigh() helper. Suggested-by: David Ahern Signed-off-by: Daniel Borkmann --- include/uapi/linux/bpf.h | 10 +++--- tools/include/uapi/linux/bpf.h | 10 +++--- 2 files changed, 14 ins

[PATCH bpf-next 0/6] Follow-up BPF helper improvements

2020-10-08 Thread Daniel Borkmann
This series addresses most of the feedback [0] that was to be followed up from the last series, that is, UAPI helper comment improvements and getting rid of the ifindex obj file hacks in the selftest by using a BPF map instead. The __sk_buff data/data_end pointer work, I'm planning to do in a later

[PATCH bpf-next 5/6] bpf, selftests: make redirect_neigh test more extensible

2020-10-08 Thread Daniel Borkmann
Rename into test_tc_redirect.sh and move setup and test code into separate functions so they can be reused for newly added tests in here. Also remove the crude hack to override ifindex inside the object file via xxd and sed and just use a simple map instead. Map given iproute2 does not support BTF

[PATCH bpf-next 6/6] bpf, selftests: add redirect_peer selftest

2020-10-08 Thread Daniel Borkmann
Extend the test_tc_redirect test and add a small test that exercises the new redirect_peer() helper for the IPv4 and IPv6 case. Signed-off-by: Daniel Borkmann --- .../selftests/bpf/progs/test_tc_peer.c| 45 +++ .../testing/selftests/bpf/test_tc_redirect.sh | 25 +++---

Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card

2020-10-08 Thread Jakub Kicinski
On Thu, 08 Oct 2020 19:10:57 +0200 Bjørn Mork wrote: > Jakub Kicinski writes: > > > I'm guessing that I'm supposed to take this patch into the networking > > tree, correct? > > Correct. > > > Is this net or net-next candidate? Bjørn? > > Sorry, should have made that explicit. This is for n

Re: [PATCHv2 net-next 06/17] sctp: create udp6 sock and set its encap_rcv

2020-10-08 Thread kernel test robot
Hi Xin, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Re: [net-next PATCH v4] net: dsa: rtl8366rb: Roof MTU for switch

2020-10-08 Thread Florian Fainelli
On 10/8/2020 2:03 PM, Linus Walleij wrote: The MTU setting for this DSA switch is global so we need to keep track of the MTU set for each port, then as soon as any MTU changes, roof the MTU to the biggest common denominator and poke that into the switch MTU setting. To achieve this we need a

Re: pull-request: bpf 2020-10-08

2020-10-08 Thread Jakub Kicinski
On Thu, 8 Oct 2020 16:51:54 +0200 Daniel Borkmann wrote: > Hi David, > > The following pull-request contains BPF updates for your *net* tree. > > We've added 2 non-merge commits during the last 8 day(s) which contain > a total of 2 files changed, 10 insertions(+), 4 deletions(-). > > The main c

  1   2   3   4   5   >