Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-07 Thread Wilken Gottwalt
On Tue, 6 Oct 2020 09:02:01 +0200 Johan Hovold wrote: > On Mon, Oct 05, 2020 at 02:07:23PM +0200, Wilken Gottwalt wrote: > > On Mon, 5 Oct 2020 18:36:36 +0700 Lars Melin wrote: > > > On 10/5/2020 18:06, Johan Hovold wrote: > > > > > Do you remember the interface layout and why you blacklisted i

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Dan Williams
On Wed, Oct 7, 2020 at 10:21 PM Leon Romanovsky wrote: > > On Wed, Oct 07, 2020 at 08:46:45PM +, Ertman, David M wrote: > > > -Original Message- > > > From: Parav Pandit > > > Sent: Wednesday, October 7, 2020 1:17 PM > > > To: Leon Romanovsky ; Ertman, David M > > > > > > Cc: Pierre-

Re: [PATCH 1/2] net/ipv6: always honour route mtu during forwarding

2020-10-07 Thread Maciej Żenczykowski
> On Thu, Oct 8, 2020 at 12:31 PM Maciej Żenczykowski > wrote: > > diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h > > index 2a5277758379..598415743f46 100644 > > --- a/include/net/ip6_route.h > > +++ b/include/net/ip6_route.h > > @@ -311,19 +311,13 @@ static inline bool rt6_duplica

[Patch net] can: initialize skbcnt in j1939_tp_tx_dat_new()

2020-10-07 Thread Cong Wang
This fixes an uninit-value warning: BUG: KMSAN: uninit-value in can_receive+0x26b/0x630 net/can/af_can.c:650 Reported-and-tested-by: syzbot+3f3837e61a48d32b4...@syzkaller.appspotmail.com Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") Cc: Robin van der Gracht Cc: Oleksij Rempel Cc

Re: [RFC 1/1] net/tls(TLS_SW): Handle -ENOSPC error return from device/AES-NI

2020-10-07 Thread Herbert Xu
Jakub Kicinski wrote: > > Why would the driver return EBUSY from an async API? What's the caller > supposed to do with that? The Crypto API offers two modes for callers to deal with congestion. If the request can be safely dropped (e.g., IPsec) then ENOSPC will be returned and should be dealt wit

Re: [PATCH 5/7] igb: use igb_rx_buffer_flip

2020-10-07 Thread Sven Auhagen
On Wed, Oct 07, 2020 at 11:32:57PM +0200, Maciej Fijalkowski wrote: > On Wed, Oct 07, 2020 at 05:25:04PM +0200, sven.auha...@voleatech.de wrote: > > From: Sven Auhagen > > > > Also use the new helper function igb_rx_buffer_flip in > > igb_build_skb/igb_add_rx_frag. > > > > Signed-off-by: Sven Au

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Leon Romanovsky
On Thu, Oct 08, 2020 at 04:56:01AM +, Parav Pandit wrote: > > > > From: Pierre-Louis Bossart > > Sent: Thursday, October 8, 2020 3:20 AM > > > > > > On 10/7/20 4:22 PM, Ertman, David M wrote: > > >> -Original Message- > > >> From: Pierre-Louis Bossart > > >> Sent: Wednesday, October 7

Re: [PATCH 2/7] igb: take vlan double header into account

2020-10-07 Thread Sven Auhagen
On Wed, Oct 07, 2020 at 11:06:15PM +0200, Maciej Fijalkowski wrote: > On Wed, Oct 07, 2020 at 05:25:01PM +0200, sven.auha...@voleatech.de wrote: > > From: Sven Auhagen > > > > Increase the packet header padding to include double VLAN tagging. > > This patch uses a macro for this. > > > > Signed-

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 08:46:45PM +, Ertman, David M wrote: > > -Original Message- > > From: Parav Pandit > > Sent: Wednesday, October 7, 2020 1:17 PM > > To: Leon Romanovsky ; Ertman, David M > > > > Cc: Pierre-Louis Bossart ; alsa- > > de...@alsa-project.org; pa...@mellanox.com; ti

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Parav Pandit
> From: Pierre-Louis Bossart > Sent: Thursday, October 8, 2020 3:20 AM > > > On 10/7/20 4:22 PM, Ertman, David M wrote: > >> -Original Message- > >> From: Pierre-Louis Bossart > >> Sent: Wednesday, October 7, 2020 1:59 PM > >> To: Ertman, David M ; Parav Pandit > >> ; Leon Romanovsky

[Patch net] tipc: fix the skb_unshare() in tipc_buf_append()

2020-10-07 Thread Cong Wang
skb_unshare() drops a reference count on the old skb unconditionally, so in the failure case, we end up freeing the skb twice here. And because the skb is allocated in fclone and cloned by caller tipc_msg_reassemble(), the consequence is actually freeing the original skb too, thus triggered the UAF

[PATCH 1/2] net/ipv6: always honour route mtu during forwarding

2020-10-07 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This matches the new ipv4 behaviour as of commit: commit 02a1b175b0e92d9e0fa5df3957ade8d733ceb6a0 Author: Maciej Żenczykowski Date: Wed Sep 23 13:18:15 2020 -0700 net/ipv4: always honour route mtu during forwarding The reasoning is similar: There doesn't see

[PATCH 2/2] net/ipv6: ensure ip6_dst_mtu_forward() returns at least IPV6_MIN_MTU

2020-10-07 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This is basically just a refactor. But it does affect (a presumably buggy) call site in: net/netfilter/nf_flow_table_core.c flow_offload_fill_route() Signed-off-by: Maciej Żenczykowski --- include/net/ip6_route.h | 4 ++-- net/ipv6/ip6_output.c | 2 -- 2 files

Re: [PATCH bpf-next V2 5/6] bpf: Add MTU check for TC-BPF packets after egress hook

2020-10-07 Thread John Fastabend
Maciej Żenczykowski wrote: > On Wed, Oct 7, 2020 at 3:37 PM John Fastabend > wrote: > > > > Daniel Borkmann wrote: > > > On 10/7/20 6:23 PM, Jesper Dangaard Brouer wrote: > > > [...] > > > > net/core/dev.c | 24 ++-- > > > > 1 file changed, 22 insertions(+), 2 deletions(-

Re: [PATCH v3 bpf-next 0/4] libbpf: auto-resize relocatable LOAD/STORE instructions

2020-10-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 7 Oct 2020 17:10:20 -0700 you wrote: > Patch set implements logic in libbpf to auto-adjust memory size (1-, 2-, 4-, > 8-bytes) of load/store (LD/ST/STX) instructions which have BPF CO-RE field > offset relocation asso

Re: [PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-07 Thread Alexei Starovoitov
On Wed, Oct 07, 2020 at 04:55:24PM -0700, John Fastabend wrote: > John Fastabend wrote: > > Alexei Starovoitov wrote: > > > From: Alexei Starovoitov > > > > > > The llvm register allocator may use two different registers representing > > > the > > > same virtual register. In such case the follow

Re: [PATCH net-next] net/sched: get rid of qdisc->padded

2020-10-07 Thread Cong Wang
On Wed, Oct 7, 2020 at 9:51 AM Eric Dumazet wrote: > > From: Eric Dumazet > > kmalloc() of sufficiently big portion of memory is cache-aligned > in regular conditions. If some debugging options are used, > there is no reason qdisc structures would need 64-byte alignment > if most other kernel str

Re: [PATCH iproute2-next v2 2/2] tc: implement support for terse dump

2020-10-07 Thread David Ahern
On 9/30/20 9:59 AM, Vlad Buslov wrote: > From: Vlad Buslov > > Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS > tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when > user requested it with following example CLI (-br for 'brief'): > >> tc -s -br

[Patch net] ip_gre: set dev->hard_header_len properly

2020-10-07 Thread Cong Wang
GRE tunnel has its own header_ops, ipgre_header_ops, and sets it conditionally. When it is set, it assumes the outer IP header is already created before ipgre_xmit(). This is not true when we send packets through a raw packet socket, where L2 headers are supposed to be constructed by user. Packet

[PATCH v3 bpf-next 0/4] libbpf: auto-resize relocatable LOAD/STORE instructions

2020-10-07 Thread Andrii Nakryiko
Patch set implements logic in libbpf to auto-adjust memory size (1-, 2-, 4-, 8-bytes) of load/store (LD/ST/STX) instructions which have BPF CO-RE field offset relocation associated with it. In practice this means transparent handling of 32-bit kernels, both pointer and unsigned integers. Signed int

[PATCH v3 bpf-next 2/4] libbpf: support safe subset of load/store instruction resizing with CO-RE

2020-10-07 Thread Andrii Nakryiko
From: Andrii Nakryiko Add support for patching instructions of the following form: - rX = *(T *)(rY + ); - *(T *)(rX + ) = rY; - *(T *)(rX + ) = , where T is one of {u8, u16, u32, u64}. For such instructions, if the actual kernel field recorded in CO-RE relocation has a different size than

[PATCH v3 bpf-next 3/4] libbpf: allow specifying both ELF and raw BTF for CO-RE BTF override

2020-10-07 Thread Andrii Nakryiko
From: Andrii Nakryiko Use generalized BTF parsing logic, making it possible to parse BTF both from ELF file, as well as a raw BTF dump. This makes it easier to write custom tests with manually generated BTFs. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 2 +- 1 file changed, 1 i

[PATCH v3 bpf-next 1/4] libbpf: skip CO-RE relocations for not loaded BPF programs

2020-10-07 Thread Andrii Nakryiko
Bypass CO-RE relocations step for BPF programs that are not going to be loaded. This allows to have BPF programs compiled in and disabled dynamically if kernel is not supposed to provide enough relocation information. In such case, there won't be unnecessary warnings about failed relocations. Fixe

[PATCH v3 bpf-next 4/4] selftests/bpf: validate libbpf's auto-sizing of LD/ST/STX instructions

2020-10-07 Thread Andrii Nakryiko
From: Andrii Nakryiko Add selftests validating libbpf's auto-resizing of load/store instructions when used with CO-RE relocations. An explicit and manual approach with using bpf_core_read() is also demonstrated and tested. Separate BPF program is supposed to fail due to using signed integers of s

RE: [PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-07 Thread John Fastabend
John Fastabend wrote: > Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > > > The llvm register allocator may use two different registers representing the > > same virtual register. In such case the following pattern can be observed: > > 1047: (bf) r9 = r6 > > 1048: (a5) if r6 < 0x1000 g

RE: [PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-07 Thread John Fastabend
Alexei Starovoitov wrote: > From: Alexei Starovoitov > > The llvm register allocator may use two different registers representing the > same virtual register. In such case the following pattern can be observed: > 1047: (bf) r9 = r6 > 1048: (a5) if r6 < 0x1000 goto pc+1 > 1050: ... > 1051: (a5) if

Re: [PATCH v2 bpf-next 4/4] selftests/bpf: validate libbpf's auto-sizing of LD/ST/STX instructions

2020-10-07 Thread Andrii Nakryiko
On Wed, Oct 7, 2020 at 4:30 PM Alexei Starovoitov wrote: > > On Wed, Oct 07, 2020 at 01:29:46PM -0700, Andrii Nakryiko wrote: > > diff --git a/tools/testing/selftests/bpf/progs/test_core_autosize.c > > b/tools/testing/selftests/bpf/progs/test_core_autosize.c > > new file mode 100644 > > index 000

Re: [PATCH v2 bpf-next 4/4] selftests/bpf: validate libbpf's auto-sizing of LD/ST/STX instructions

2020-10-07 Thread Alexei Starovoitov
On Wed, Oct 07, 2020 at 01:29:46PM -0700, Andrii Nakryiko wrote: > diff --git a/tools/testing/selftests/bpf/progs/test_core_autosize.c > b/tools/testing/selftests/bpf/progs/test_core_autosize.c > new file mode 100644 > index ..e999f2e2ea22 > --- /dev/null > +++ b/tools/testing/selftest

[net-next 3/3] e1000: remove unused and incorrect code

2020-10-07 Thread Tony Nguyen
From: Jesse Brandeburg The e1000_clear_vfta function was triggering a warning in kbuild-bot testing. It's actually a bug but has no functional impact. drivers/net/ethernet/intel/e1000/e1000_hw.c:4415:58: warning: Same expression in both branches of ternary operator. [duplicateExpressionTernary]

[net-next 2/3] i40e: Fix MAC address setting for a VF via Host/VM

2020-10-07 Thread Tony Nguyen
From: Aleksandr Loktionov Fix MAC setting flow for the PF driver. Without this change the MAC address setting was interpreted incorrectly in the following use cases: 1) Print incorrect VF MAC or zero MAC ip link show dev $pf 2) Don't preserve MAC between driver reload rmmod iavf; modprobe iavf 3

[net-next 1/3] i40e: Allow changing FEC settings on X722 if supported by FW

2020-10-07 Thread Tony Nguyen
From: Jaroslaw Gawin Starting with API version 1.10 firmware for X722 devices has ability to change FEC settings in PHY. Code added in this patch allows changing FEC settings if the capability flag indicates the device supports this feature. Signed-off-by: Jaroslaw Gawin Signed-off-by: Aleksand

[net-next 0/3][pull request] 40GbE Intel Wired LAN Driver Updates 2020-10-07

2020-10-07 Thread Tony Nguyen
This series contains updates to i40e and e1000 drivers. Jaroslaw adds support for changing FEC on i40e if the firmware supports it. Aleksandr fixes setting and reporting of VF MAC address under various circumstances for i40e. Jesse fixes a kbuild-bot warning regarding ternary operator on e1000.

Re: [PATCH net-next v3 5/5] bonding: update Documentation for port/bond terminology

2020-10-07 Thread Jarod Wilson
On Wed, Oct 7, 2020 at 2:14 PM Jarod Wilson wrote: > > Swap in port/bond terminology where appropriate, leaving all legacy sysfs > and procfs interface mentions in place, but marked as deprecated. > Additionally, add more netlink/iproute2 documentation, and note that this > is the preferred method

Re: [PATCH bpf-next] selftests/bpf: Additional asm tests for the verifier regalloc tracking.

2020-10-07 Thread Alexei Starovoitov
On Wed, Oct 7, 2020 at 3:50 PM Andrii Nakryiko wrote: > > On Wed, Oct 7, 2020 at 3:28 PM Alexei Starovoitov > wrote: > > > > From: Alexei Starovoitov > > > > Add asm tests for register allocator tracking logic implemented in the > > patches: > > https://lore.kernel.org/bpf/20201006200955.12350-

Re: [PATCH bpf-next] selftests/bpf: Additional asm tests for the verifier regalloc tracking.

2020-10-07 Thread Andrii Nakryiko
On Wed, Oct 7, 2020 at 3:28 PM Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > Add asm tests for register allocator tracking logic implemented in the > patches: > https://lore.kernel.org/bpf/20201006200955.12350-1-alexei.starovoi...@gmail.com/T/#t > > Signed-off-by: Alexei Starovoitov

Re: [PATCH bpf-next V2 5/6] bpf: Add MTU check for TC-BPF packets after egress hook

2020-10-07 Thread John Fastabend
Daniel Borkmann wrote: > On 10/7/20 6:23 PM, Jesper Dangaard Brouer wrote: > [...] > > net/core/dev.c | 24 ++-- > > 1 file changed, 22 insertions(+), 2 deletions(-) Couple high-level comments. Whats the problem with just letting the driver consume the packet? I would chal

[PATCH bpf-next] selftests/bpf: Additional asm tests for the verifier regalloc tracking.

2020-10-07 Thread Alexei Starovoitov
From: Alexei Starovoitov Add asm tests for register allocator tracking logic implemented in the patches: https://lore.kernel.org/bpf/20201006200955.12350-1-alexei.starovoi...@gmail.com/T/#t Signed-off-by: Alexei Starovoitov --- .../testing/selftests/bpf/verifier/regalloc.c | 159 ++

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Pierre-Louis Bossart
On 10/7/20 4:22 PM, Ertman, David M wrote: -Original Message- From: Pierre-Louis Bossart Sent: Wednesday, October 7, 2020 1:59 PM To: Ertman, David M ; Parav Pandit ; Leon Romanovsky Cc: alsa-de...@alsa-project.org; pa...@mellanox.com; ti...@suse.de; netdev@vger.kernel.org; ranjani.s

Re: [PATCH 7/7] igb: avoid transmit queue timeout in xdp path

2020-10-07 Thread Maciej Fijalkowski
On Wed, Oct 07, 2020 at 05:25:06PM +0200, sven.auha...@voleatech.de wrote: > From: Sven Auhagen > > Since we share the transmit queue with the slow path, > it is possible that we run into a transmit queue timeout. > This will reset the queue. > This happens under high load when the fast path is u

Re: [PATCH 6/7] igb: use xdp_do_flush

2020-10-07 Thread Maciej Fijalkowski
On Wed, Oct 07, 2020 at 05:25:05PM +0200, sven.auha...@voleatech.de wrote: > From: Sven Auhagen > > Since it is a new XDP implementation change xdp_do_flush_map > to xdp_do_flush. > > Signed-off-by: Sven Auhagen Suggested-by: Maciej Fijalkowski Reviewed-by: Maciej Fijalkowski

Re: [PATCH 5/7] igb: use igb_rx_buffer_flip

2020-10-07 Thread Maciej Fijalkowski
On Wed, Oct 07, 2020 at 05:25:04PM +0200, sven.auha...@voleatech.de wrote: > From: Sven Auhagen > > Also use the new helper function igb_rx_buffer_flip in > igb_build_skb/igb_add_rx_frag. > > Signed-off-by: Sven Auhagen > --- > drivers/net/ethernet/intel/igb/igb_main.c | 87 +--

Re: [PATCH bpf-next V2 5/6] bpf: Add MTU check for TC-BPF packets after egress hook

2020-10-07 Thread Daniel Borkmann
On 10/7/20 6:23 PM, Jesper Dangaard Brouer wrote: [...] net/core/dev.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index b433098896b2..19406013f93e 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3870,6 +3

[PATCH 16/17] can: xilinx_can: Check return value of set_reset_mode

2020-10-07 Thread Marc Kleine-Budde
From: Srinivas Neeli Check return value of set_reset_mode() for error. Addresses-Coverity: "check_return" Signed-off-by: Srinivas Neeli Signed-off-by: Michal Simek Link: https://lore.kernel.org/r/bac2c2b857986472a11db341b3f6f7a8905ad0dd.1600073396.git.michal.si...@xilinx.com Signed-off-by: Ma

[PATCH 13/17] dt-bindings: can: flexcan: remove ack_grp and ack_bit from fsl,stop-mode

2020-10-07 Thread Marc Kleine-Budde
Since commit: 048e3a34a2e7 can: flexcan: poll MCR_LPM_ACK instead of GPR ACK for stop mode acknowledgment the driver polls the IP core's internal bit MCR[LPM_ACK] as stop mode acknowledge and not the acknowledgment on chip level. This means the 4th and 5th value of the property "fsl,stop-mo

[PATCH 15/17] can: xilinx_can: Limit CANFD brp to 2

2020-10-07 Thread Marc Kleine-Budde
From: Srinivas Neeli Bit enlarging is observed for CANFD2.0 when brp is 1, So change brp_min value to 2. Signed-off-by: Srinivas Neeli Signed-off-by: Michal Simek Link: https://lore.kernel.org/r/bca871d7f3ca9c653d50e63c5b60028f2bdf3fb0.1600073396.git.michal.si...@xilinx.com Signed-off-by: Mar

[PATCH 07/17] can: dev: add a helper function to calculate the duration of one bit

2020-10-07 Thread Marc Kleine-Budde
From: Vincent Mailhol Rename macro CAN_CALC_SYNC_SEG to CAN_SYNC_SEG and make it available through include/linux/can/dev.h Add an helper function can_bit_time() which returns the duration (in time quanta) of one CAN bit. Rationale for this patch: the sync segment and the bit time are two concep

[PATCH 17/17] can: xilinx_can: Fix incorrect variable and initialize with a default value

2020-10-07 Thread Marc Kleine-Budde
From: Srinivas Neeli Some variables with incorrect type were passed to "of_property_read_u32" API, "of_property_read_u32" API was expecting an "u32 *" but the formal parameter that was passed was of type "int *". Fixed the issue by changing the variable types from "int" to "u32" and initialized w

[PATCH 14/17] can: flexcan: remove ack_grp and ack_bit handling from driver

2020-10-07 Thread Marc Kleine-Budde
Since commit: 048e3a34a2e7 can: flexcan: poll MCR_LPM_ACK instead of GPR ACK for stop mode acknowledgment the driver polls the IP core's internal bit MCR[LPM_ACK] as stop mode acknowledge and not the acknowledgment on chip level. This means the 4th and 5th value of the property "fsl,stop-mo

[PATCH 10/17] dt-bindings: can: rcar_canfd: Document r8a774e1 support

2020-10-07 Thread Marc Kleine-Budde
From: Lad Prabhakar Document the support for rcar_canfd on R8A774E1 SoC devices. Signed-off-by: Lad Prabhakar Reviewed-by: Marian-Cristian Rotariu Reviewed-by: Geert Uytterhoeven Acked-by: Rob Herring Link: https://lore.kernel.org/r/20201005081319.29322-2-prabhakar.mahadev-lad...@bp.renesas

[PATCH 04/17] MAINTAINERS: adjust to mcp251xfd file renaming

2020-10-07 Thread Marc Kleine-Budde
From: Lukas Bulwahn Commit 27cf93863cbc ("MAINTAINERS: Add entry for Microchip MCP25XXFD SPI-CAN network driver"), added the MCP25XXFD SPI-CAN NETWORK DRIVER section with the following two file entries: F: Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml F: drivers/ne

[PATCH 01/17] can: af_can: can_rcv_list_find(): fix kernel doc after variable renaming

2020-10-07 Thread Marc Kleine-Budde
This patch fixes the kernel doc for can_rcv_list_find() which was broken in commit: 3ee6d2bebef8 ("can: af_can: rename find_rcv_list() to can_rcv_list_find()") while renaming a variable, but forgetting to rename the kernel doc, too. Link: http://lore.kernel.org/r/20201006203748.1750156-2-..

[PATCH 12/17] dt-bindings: can: flexcan: list supported processors

2020-10-07 Thread Marc Kleine-Budde
From: Michael Walle The compatible is a pattern match. Explicitly list all possible values. Also mention that the ls1028ar1 must be followed by lx2160ar1. Signed-off-by: Michael Walle Link: https://lore.kernel.org/r/20201001091131.30514-2-mich...@walle.cc Signed-off-by: Marc Kleine-Budde ---

[PATCH 11/17] dt-bindings: can: rcar_can: Document r8a774e1 support

2020-10-07 Thread Marc Kleine-Budde
From: Lad Prabhakar Document SoC specific bindings for RZ/G2H (R8A774E1) SoC. Signed-off-by: Lad Prabhakar Reviewed-by: Marian-Cristian Rotariu Reviewed-by: Geert Uytterhoeven Acked-by: Rob Herring Link: https://lore.kernel.org/r/20201005081319.29322-3-prabhakar.mahadev-lad...@bp.renesas.co

[PATCH 05/17] can: raw: add missing error queue support

2020-10-07 Thread Marc Kleine-Budde
From: Vincent Mailhol Error queue are not yet implemented in CAN-raw sockets. The problem: a userland call to recvmsg(soc, msg, MSG_ERRQUEUE) on a CAN-raw socket would unqueue messages from the normal queue without any kind of error or warning. As such, it prevented CAN drivers from using the fu

[PATCH 09/17] dt-bindings: can: rcar_can: Add r8a7742 support

2020-10-07 Thread Marc Kleine-Budde
From: Lad Prabhakar Document RZ/G1H (r8a7742) SoC specific bindings. The R8A7742 CAN module is identical to R-Car Gen2 family. No driver change is needed due to the fallback compatible value "renesas,rcar-gen2-can". Signed-off-by: Lad Prabhakar Reviewed-by: Chris Paterson Link: https://lore.

[PATCH 02/17] can: softing: softing_card_shutdown(): add braces around empty body in an 'if' statement

2020-10-07 Thread Marc Kleine-Budde
This patch fixes the following warning when building the kernel with "W=1": warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Link: http://lore.kernel.org/r/20201006203748.1750156-3-...@pengutronix.de Fixes: 03fd3cf5a179 ("can: add driver for Softing card") Signed

[PATCH 06/17] can: dev: fix type of get_can_dlc() and get_canfd_dlc() macros

2020-10-07 Thread Marc Kleine-Budde
From: Vincent Mailhol The macros get_can_dlc() and get_canfd_dlc() are not visible in userland. As such, type u8 should be preferred over type __u8. Reference: https://lkml.org/lkml/2020/10/1/708 Signed-off-by: Vincent Mailhol Link: https://lore.kernel.org/r/20201002154219.4887-3-mailhol.vinc..

[PATCH 03/17] can: c_can: reg_map_{c,d}_can: mark as __maybe_unused

2020-10-07 Thread Marc Kleine-Budde
This patch marks the arrays reg_map_c_can and reg_map_d_can as __maybe_unused, as they are indeed unused in the c_can driver. This warning shows up, when compiling the kernel with "W=1": drivers/net/can/c_can/c_can.c:45: drivers/net/can/c_can/c_can.h:124:18: warning: ‘reg_map_d_can’ define

pull-request: can-next 2020-10-07

2020-10-07 Thread Marc Kleine-Budde
es since commit 9faebeb2d80065926dfbc09cb73b1bb7779a89cd: Merge branch 'ethtool-allow-dumping-policies-to-user-space' (2020-10-06 06:25:56 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-5.10-2

[PATCH 08/17] can: add ISO 15765-2:2016 transport protocol

2020-10-07 Thread Marc Kleine-Budde
From: Oliver Hartkopp CAN Transport Protocols offer support for segmented Point-to-Point communication between CAN nodes via two defined CAN Identifiers. As CAN frames can only transport a small amount of data bytes (max. 8 bytes for 'classic' CAN and max. 64 bytes for CAN FD) this segmentation i

Re: [PATCH bpf-next V2 1/6] bpf: Remove MTU check in __bpf_skb_max_len

2020-10-07 Thread Daniel Borkmann
On 10/7/20 6:22 PM, Jesper Dangaard Brouer wrote: [...] Signed-off-by: Jesper Dangaard Brouer (imported from commit 37f8552786cf46588af52b77829b730dd14524d3) slipped in?

Re: [net-next 01/15] net/mlx5: DR, Add buddy allocator utilities

2020-10-07 Thread Yevgeny Kliteynik
On 06-Oct-20 17:47, David Miller wrote: > From: Yevgeny Kliteynik > Date: Tue, 6 Oct 2020 16:02:24 +0300 > >> Buddy allocator allocates blocks of different sizes, so when it >> scans the bits array, the allocator looks for free *area* of at >> least the required size. >> Can't store this info in

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Ertman, David M
> -Original Message- > From: Pierre-Louis Bossart > Sent: Wednesday, October 7, 2020 1:59 PM > To: Ertman, David M ; Parav Pandit > ; Leon Romanovsky > Cc: alsa-de...@alsa-project.org; pa...@mellanox.com; ti...@suse.de; > netdev@vger.kernel.org; ranjani.sridha...@linux.intel.com; > fred..

Re: [PATCH 4/7] igb: skb add metasize for xdp

2020-10-07 Thread Maciej Fijalkowski
On Wed, Oct 07, 2020 at 05:25:03PM +0200, sven.auha...@voleatech.de wrote: > From: Sven Auhagen > > add metasize if it is set in xdp > > Signed-off-by: Sven Auhagen Suggested-by: Maciej Fijalkowski Reviewed-by: Maciej Fijalkowski

Re: [PATCH 3/7] igb: XDP extack message on error

2020-10-07 Thread Maciej Fijalkowski
On Wed, Oct 07, 2020 at 05:25:02PM +0200, sven.auha...@voleatech.de wrote: > From: Sven Auhagen > > Add an extack error message when the RX buffer size is too small > for the frame size. > > Signed-off-by: Sven Auhagen Suggested-by: Maciej Fijalkowski Reviewed-by: Maciej Fijalkowski

Re: [PATCH 2/7] igb: take vlan double header into account

2020-10-07 Thread Maciej Fijalkowski
On Wed, Oct 07, 2020 at 05:25:01PM +0200, sven.auha...@voleatech.de wrote: > From: Sven Auhagen > > Increase the packet header padding to include double VLAN tagging. > This patch uses a macro for this. > > Signed-off-by: Sven Auhagen > --- > drivers/net/ethernet/intel/igb/igb.h | 5 +

Re: [BUG] pfifo_fast may cause out-of-order CAN frame transmission

2020-10-07 Thread Vijayendra Suman
[PATCH] Patch with Network Performance Improvment qperf:tcp_lat Check Performed for __QDISC_STATE_DEACTIVATED before checking BYPASS flag qperf tcp_lat 65536bytes over an ib_switch For 64K packet Performance improvment is around 47 % and performance deviation is reduced to 5 % which was 27 %

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Pierre-Louis Bossart
Below is most simple, intuitive and matching with core APIs for name and design pattern wise. init() { err = ancillary_device_initialize(); if (err) return ret; err = ancillary_device_add(); if (ret) goto err_unwind; err

[PATCH net-next 1/3] net/smc: consolidate unlocking in same function

2020-10-07 Thread Karsten Graul
Static code checkers warn of inconsistent returns because the lgr mutex is locked in one function and unlocked in a function called by the locking function: net/smc/af_smc.c:823 smc_connect_rdma() warn: inconsistent returns 'smc_client_lgr_pending'. net/smc/af_smc.c:897 smc_connect_ism() warn: inc

[PATCH net-next 3/3] net/smc: restore smcd_version when all ISM V2 devices failed to init

2020-10-07 Thread Karsten Graul
Field ini->smcd_version is set to SMC_V2 before calling smc_listen_ism_init(). This clears the V1 bit that may be set. When all matching ISM V2 devices fail to initialize then the smcd_version field needs to get restored to allow any possible V1 devices to initialize. And be consistent, always go t

[PATCH net-next 2/3] net/smc: cleanup buffer usage in smc_listen_work()

2020-10-07 Thread Karsten Graul
coccinelle informs about net/smc/af_smc.c:1770:10-11: WARNING: opportunity for kzfree/kvfree_sensitive Its not that kzfree() would help here, the memset() is done to prepare the buffer for another socket receive. Fix that warning message by reordering the calls, while at it eliminate the unneeded

[PATCH net-next 0/3] net/smc: updates 2020-10-07

2020-10-07 Thread Karsten Graul
Please apply the following patch series for smc to netdev's net-next tree. Patch 1 and 2 address warnings from static code checkers, and patch 3 handles a case when all proposed ISM V2 devices fail to init and no V1 devices are tried afterwards. Karsten Graul (3): net/smc: consolidate unlocking

Re: [RFC 1/1] net/tls(TLS_SW): Handle -ENOSPC error return from device/AES-NI

2020-10-07 Thread Jakub Kicinski
On Wed, 7 Oct 2020 15:19:47 -0400 Pooja Trivedi wrote: > When an -ENOSPC error code is returned by the crypto device or AES-NI > layer, TLS SW path sets an EBADMSG on the socket causing the > application to fail. In an attempt to address the -ENOSPC in the TLS > SW path, changes were made in tls_s

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Ertman, David M
> -Original Message- > From: Parav Pandit > Sent: Wednesday, October 7, 2020 1:17 PM > To: Leon Romanovsky ; Ertman, David M > > Cc: Pierre-Louis Bossart ; alsa- > de...@alsa-project.org; pa...@mellanox.com; ti...@suse.de; > netdev@vger.kernel.org; ranjani.sridha...@linux.intel.com; > fre

Re: [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2020-10-07

2020-10-07 Thread Jakub Kicinski
On Wed, 7 Oct 2020 10:54:39 -0700 Tony Nguyen wrote: > This series contains updates to ice driver only. Reviewed-by: Jakub Kicinski

Re: [PATCH bpf-next v2] libbpf: fix compatibility problem in xsk_socket__create

2020-10-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 7 Oct 2020 13:42:26 +0200 you wrote: > From: Magnus Karlsson > > Fix a compatibility problem when the old XDP_SHARED_UMEM mode is used > together with the xsk_socket__create() call. In the old XDP_SHARED_UMEM > mode

[PATCH v2 bpf-next 4/4] selftests/bpf: validate libbpf's auto-sizing of LD/ST/STX instructions

2020-10-07 Thread Andrii Nakryiko
From: Andrii Nakryiko Add selftests validating libbpf's auto-resizing of load/store instructions when used with CO-RE relocations. An explicit and manual approach with using bpf_core_read() is also demonstrated and tested. Separate BPF program is supposed to fail due to using signed integers of s

[PATCH v2 bpf-next 0/4] libbpf: auto-resize relocatable LOAD/STORE instructions

2020-10-07 Thread Andrii Nakryiko
Patch set implements logic in libbpf to auto-adjust memory size (1-, 2-, 4-, 8-bytes) of load/store (LD/ST/STX) instructions which have BPF CO-RE field offset relocation associated with it. In practice this means transparent handling of 32-bit kernels, both pointer and unsigned integers. Signed int

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Ertman, David M
> -Original Message- > From: Leon Romanovsky > Sent: Tuesday, October 6, 2020 10:03 AM > To: Pierre-Louis Bossart > Cc: Ertman, David M ; alsa-devel@alsa- > project.org; pa...@mellanox.com; ti...@suse.de; netdev@vger.kernel.org; > ranjani.sridha...@linux.intel.com; fred...@linux.intel.com

[PATCH v2 bpf-next 1/4] libbpf: skip CO-RE relocations for not loaded BPF programs

2020-10-07 Thread Andrii Nakryiko
Bypass CO-RE relocations step for BPF programs that are not going to be loaded. This allows to have BPF programs compiled in and disabled dynamically if kernel is not supposed to provide enough relocation information. In such case, there won't be unnecessary warnings about failed relocations. Fixe

[PATCH v2 bpf-next 3/4] libbpf: allow specifying both ELF and raw BTF for CO-RE BTF override

2020-10-07 Thread Andrii Nakryiko
From: Andrii Nakryiko Use generalized BTF parsing logic, making it possible to parse BTF both from ELF file, as well as a raw BTF dump. This makes it easier to write custom tests with manually generated BTFs. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 2 +- 1 file changed, 1 i

[PATCH v2 bpf-next 2/4] libbpf: support safe subset of load/store instruction resizing with CO-RE

2020-10-07 Thread Andrii Nakryiko
From: Andrii Nakryiko Add support for patching instructions of the following form: - rX = *(T *)(rY + ); - *(T *)(rX + ) = rY; - *(T *)(rX + ) = , where T is one of {u8, u16, u32, u64}. For such instructions, if the actual kernel field recorded in CO-RE relocation has a different size than

Re: [PATCH net v3] net/tls: sendfile fails with ktls offload

2020-10-07 Thread Jakub Kicinski
On Thu, 8 Oct 2020 00:10:21 +0530 Rohit Maheshwari wrote: > At first when sendpage gets called, if there is more data, 'more' in > tls_push_data() gets set which later sets pending_open_record_frags, but > when there is no more data in file left, and last time tls_push_data() > gets called, pendin

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Ertman, David M
> -Original Message- > From: Alsa-devel On Behalf Of Leon > Romanovsky > Sent: Wednesday, October 7, 2020 12:26 PM > To: Ertman, David M > Cc: alsa-de...@alsa-project.org; pa...@mellanox.com; ti...@suse.de; > netdev@vger.kernel.org; ranjani.sridha...@linux.intel.com; Pierre-Louis > Bossar

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Ertman, David M
> -Original Message- > From: Pierre-Louis Bossart > Sent: Tuesday, October 6, 2020 8:18 AM > To: Leon Romanovsky ; Ertman, David M > > Cc: alsa-de...@alsa-project.org; pa...@mellanox.com; ti...@suse.de; > netdev@vger.kernel.org; ranjani.sridha...@linux.intel.com; > fred...@linux.intel.com

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Parav Pandit
> From: Leon Romanovsky > Sent: Thursday, October 8, 2020 12:56 AM > > > > This API is partially obscures low level driver-core code and needs > > > to provide clear and proper abstractions without need to remember > > > about put_device. There is already _add() interface why don't you do > > >

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Ertman, David M
> -Original Message- > From: Dan Williams > Sent: Wednesday, October 7, 2020 11:56 AM > To: Leon Romanovsky > Cc: Saleem, Shiraz ; Parav Pandit > ; Pierre-Louis Bossart louis.boss...@linux.intel.com>; Ertman, David M > ; alsa-de...@alsa-project.org; > pa...@mellanox.com; ti...@suse.de; n

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Ertman, David M
> -Original Message- > From: Ertman, David M > Sent: Wednesday, October 7, 2020 12:54 PM > To: 'Leon Romanovsky' > Cc: alsa-de...@alsa-project.org; pa...@mellanox.com; ti...@suse.de; > netdev@vger.kernel.org; ranjani.sridha...@linux.intel.com; Pierre-Louis > Bossart ; fred...@linux.intel.c

Re: [PATCH] vdpa/mlx5: Fix dependency on MLX5_CORE

2020-10-07 Thread Saeed Mahameed
On Wed, 2020-10-07 at 09:40 +0300, Eli Cohen wrote: > Remove propmt for selecting MLX5_VDPA by the user and modify > MLX5_VDPA_NET to select MLX5_VDPA. Also modify MLX5_VDPA_NET to > depend > on mlx5_core. > > This fixes an issue where configuration sets 'y' for MLX5_VDPA_NET > while > MLX5_CORE i

[net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2020-10-07

2020-10-07 Thread Tony Nguyen
This series contains updates to ice driver only. Andy Shevchenko changes usage to %*phD format to print small buffer as hex string. Bruce removes repeated words reported by checkpatch. Ani changes ice_info_get_dsn() to return void as it always returns success. Jake adds devlink reporting of fw.

[PATCH nf v2] netfilter: conntrack: connection timeout after re-register

2020-10-07 Thread Francesco Ruggeri
If the first packet conntrack sees after a re-register is an outgoing keepalive packet with no data (SEG.SEQ = SND.NXT-1), td_end is set to SND.NXT-1. When the peer correctly acknowledges SND.NXT, tcp_in_window fails check III (Upper bound for valid (s)ack: sack <= receiver.td_end) and returns fals

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 06:06:30PM +, Ertman, David M wrote: > > -Original Message- > > From: Leon Romanovsky > > Sent: Tuesday, October 6, 2020 10:03 AM > > To: Pierre-Louis Bossart > > Cc: Ertman, David M ; alsa-devel@alsa- > > project.org; pa...@mellanox.com; ti...@suse.de; netdev@

Re: [net-next v2 7/8] net: smc: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Karsten Graul
On Wed, 7 Oct 2020 15:42:18 +0530 Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > Acked-b

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Dan Williams
On Wed, Oct 7, 2020 at 6:37 AM Leon Romanovsky wrote: > > On Wed, Oct 07, 2020 at 01:09:55PM +, Saleem, Shiraz wrote: > > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support > > > > > > On Tue, Oct 6, 2020 at 12:21 PM Leon Romanovsky wrote: > > > > > > > > On Tue, Oct 06, 2020 at 05:41:00

[PATCH v4 1/2] netlink: policy: refactor per-attr policy writing

2020-10-07 Thread Johannes Berg
From: Johannes Berg Refactor the per-attribute policy writing into a new helper function, to be used later for dumping out the policy of a rejected attribute. v2: - fix some indentation v3: - change variable order in netlink_policy_dump_write() Reviewed-by: Jakub Kicinski Signed-off-by: Joha

[PATCH v3 0/2] netlink: export policy on validation failures

2020-10-07 Thread Johannes Berg
Export the policy used for attribute validation when it fails, so e.g. for an out-of-range attribute userspace immediately gets the valid ranges back. v2 incorporates the suggestion from Jakub to have a function to estimate the size (netlink_policy_dump_attr_size_estimate()) and check that it does

Re: [PATCH 10/19] xfrm: interface: support IP6IP6 and IP6IP tunnels processing with .cb_handler

2020-10-07 Thread Nicolas Dichtel
Le 07/10/2020 à 18:26, Xin Long a écrit : > On Wed, Oct 7, 2020 at 11:40 PM Nicolas Dichtel > wrote: [snip] >> Do you think that you will have time to send the patch before the release >> (v5.9) >> goes out? > Sure, I will do it tomorrow. > Thanks!

[PATCH net v3] net/tls: sendfile fails with ktls offload

2020-10-07 Thread Rohit Maheshwari
At first when sendpage gets called, if there is more data, 'more' in tls_push_data() gets set which later sets pending_open_record_frags, but when there is no more data in file left, and last time tls_push_data() gets called, pending_open_record_frags doesn't get reset. And later when 2 bytes of en

Re: net: Initialize return value in gro_cells_receive

2020-10-07 Thread Gregory Rose
On 10/7/2020 9:37 AM, Eric Dumazet wrote: On 10/7/20 5:50 PM, Gregory Rose wrote: On 10/7/2020 1:21 AM, Eric Dumazet wrote: On 10/6/20 8:53 PM, Gregory Rose wrote: The 'res' return value is uninitalized and may be returned with some random value.  Initialize to NET_RX_DROP as the defa

[PATCH v3 0/2] netlink: export policy on validation failures

2020-10-07 Thread Johannes Berg
Export the policy used for attribute validation when it fails, so e.g. for an out-of-range attribute userspace immediately gets the valid ranges back. v2 incorporates the suggestion from Jakub to have a function to estimate the size (netlink_policy_dump_attr_size_estimate()) and check that it does

  1   2   3   >