[PATCH net] r8169: fix handling ether_clk

2020-09-30 Thread Heiner Kallweit
Petr reported that system freezes on r8169 driver load on a system using ether_clk. The original change was done under the assumption that the clock isn't needed for basic operations like chip register access. But obviously that was wrong. Therefore effectively revert the original change, and in ad

Re: Altera TSE driver not working in 100mbps mode

2020-09-30 Thread Petko Manolov
On 20-10-01 01:59:25, Andrew Lunn wrote: > > The subject of this email thread is: > > Altera TSE driver not working in 100mbps mode > > Are you doing your testing at 1G or 100Mbps? I would suggest starting out at > 1G if you can. Well, this is the subject i used some time ago. It is related t

Re: INFO: task hung in tcf_action_init_1

2020-09-30 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-and-tested-by: syzbot+82752bc5331601cf4...@syzkaller.appspotmail.com Tested on: commit: d5b70379 request_module() git tree: https://github.com/congwang/linux.git net kernel config:

Re: Altera TSE driver not working in 100mbps mode

2020-09-30 Thread Petko Manolov
On 20-09-30 21:43:04, David Bilsby wrote: > > I've made some progress in integrating your TSE patches, in between doing my > main work. I've managed to get the code into the later 5.4.44 kernel and > compile without errors, however my initial attempts failed to configure the > driver. In case it w

RE: [Intel-wired-lan] [PATCH] e1000: do not panic on malformed rx_desc

2020-09-30 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of Tong > Zhang > Sent: Tuesday, September 8, 2020 9:23 AM > To: Kirsher, Jeffrey T ; David S. Miller > ; Jakub Kicinski ; intel-wired- > l...@lists.osuosl.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: ztong0...@gmail.com > Subject: [Intel-wired-

Re: [PATCH v5 bpf-next 2/2] selftests/bpf: add tests for BPF_F_PRESERVE_ELEMS

2020-09-30 Thread Alexei Starovoitov
On Wed, Sep 30, 2020 at 03:49:27PM -0700, Song Liu wrote: > + > +SEC("raw_tp/task_rename") > +int BPF_PROG(read_array_2) > +{ > + struct bpf_perf_event_value val; > + long ret; > + > + ret = bpf_perf_event_read_value(&array_2, 0, &val, sizeof(val)); > + return ret; > +} After remov

Re: dsa/mv88e6xxx: leaking packets on MV88E6341 switch

2020-09-30 Thread Peter Vollmer
On Wed, Sep 30, 2020 at 09:19:56PM +0200, Andrew Lunn wrote: > > What would be the best way to debug this ? Is there a way to dump the > > ATU MAC tables to see what's going on with the address learning ? > > If you jump to net-next, and use > > https://github.com/lunn/mv88e6xxx_dump > > You can

Re: RTL8402 stops working after hibernate/resume

2020-09-30 Thread Heiner Kallweit
On 30.09.2020 23:44, Petr Tesarik wrote: > On Wed, 30 Sep 2020 22:11:02 +0200 > Heiner Kallweit wrote: > >> On 30.09.2020 20:00, Petr Tesarik wrote: >> [...] >>> WoL still does not work on my laptop, but this might be an unrelated >>> issue, and I can even imagine the BIOS is buggy in this regard

Re: [PATCH bpf-next v7 2/2] selftests/bpf: Selftest for real time helper

2020-09-30 Thread Alexei Starovoitov
On Wed, Sep 30, 2020 at 07:05:04PM -0700, bimmy.puj...@intel.com wrote: > +SEC("realtime_helper") > +int realtime_helper_test(struct __sk_buff *skb) > +{ > + unsigned long long *lasttime; > + unsigned long long curtime; > + int key = 0; > + int err = 0; > + > + lasttime = bpf_ma

[PATCH bpf v3] bpf: fix "unresolved symbol" build error with resolve_btfids

2020-09-30 Thread Yonghong Song
Michal reported a build failure likes below: BTFIDS vmlinux FAILED unresolved symbol tcp_timewait_sock make[1]: *** [/.../linux-5.9-rc7/Makefile:1176: vmlinux] Error 255 This error can be triggered when config has CONFIG_NET enabled but CONFIG_INET disabled. In this case, there is no use

[PATCH 3/6] ASoC: SOF: Create client driver for IPC test

2020-09-30 Thread Dave Ertman
From: Ranjani Sridharan Create an SOF client driver for IPC flood test. This driver is used to set up the debugfs entries and the read/write ops for initiating the IPC flood test that would be used to measure the min/max/avg response times for sending IPCs to the DSP. Reviewed-by: Pierre-Louis B

[PATCH 0/6] Ancillary bus implementation and SOF multi-client support

2020-09-30 Thread Dave Ertman
Brief history of Ancillary Bus == The ancillary bus code was originally submitted upstream as virtual bus, and was submitted through the netdev tree.  This process generated up to v4.  This discussion can be found here: https://lore.kernel.org/netdev/0200520070227.

[PATCH 6/6] ASoC: SOF: debug: Remove IPC flood test support in SOF core

2020-09-30 Thread Dave Ertman
From: Fred Oh Remove the IPC flood test support in the SOF core as it is now added in the IPC flood test client. Reviewed-by: Pierre-Louis Bossart Signed-off-by: Fred Oh Signed-off-by: Ranjani Sridharan Signed-off-by: Dave Ertman --- sound/soc/sof/Kconfig| 8 -- sound/soc/sof/debug.c

[PATCH 1/6] Add ancillary bus support

2020-09-30 Thread Dave Ertman
Add support for the Ancillary Bus, ancillary_device and ancillary_driver. It enables drivers to create an ancillary_device and bind an ancillary_driver to it. The bus supports probe/remove shutdown and suspend/resume callbacks. Each ancillary_device has a unique string based id; driver binds to an

[PATCH 2/6] ASoC: SOF: Introduce descriptors for SOF client

2020-09-30 Thread Dave Ertman
From: Ranjani Sridharan A client in the SOF (Sound Open Firmware) context is a device that needs to communicate with the DSP via IPC messages. The SOF core is responsible for serializing the IPC messages to the DSP from the different clients. One example of an SOF client would be an IPC test clie

[PATCH 4/6] ASoC: SOF: ops: Add ops for client registration

2020-09-30 Thread Dave Ertman
From: Ranjani Sridharan Add new ops for registering/unregistering clients based on DSP capabilities and/or DT information. Reviewed-by: Pierre-Louis Bossart Signed-off-by: Ranjani Sridharan Signed-off-by: Dave Ertman --- sound/soc/sof/core.c | 10 ++ sound/soc/sof/ops.h | 14

[PATCH 5/6] ASoC: SOF: Intel: Define ops for client registration

2020-09-30 Thread Dave Ertman
From: Ranjani Sridharan Define client ops for Intel platforms. For now, we only add 2 IPC test clients that will be used for run tandem IPC flood tests for. For ACPI platforms, change the Kconfig to select SND_SOC_SOF_PROBE_WORK_QUEUE to allow the ancillary driver to probe when the client is reg

[net-next 07/15] net/mlx5: E-switch, Use PF num in metadata reg c0

2020-09-30 Thread saeed
From: sunils Currently only 256 vports can be supported as only 8 bits are reserved for them and 8 bits are reserved for vhca_ids in metadata reg c0. To support more than 256 vports, replace vhca_id with a unique shorter 4-bit PF number which covers upto 16 PF's. Use remaining 12 bits for vports

[net-next 09/15] net/mlx5: E-switch, Use helper function to load unload representor

2020-09-30 Thread saeed
From: Parav Pandit To register and unregister devlink ports when loading/unload representors, refactor the code to helper functions. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/eswitch_offloads.c | 29 +

[net-next 03/15] net/mlx5: DR, Remove unneeded vlan check from L2 builder

2020-09-30 Thread saeed
From: Yevgeny Kliteynik When we create a matcher we check that all fields are consumed. There is no need for this specific check. This keeps the STE builder functions simple and clean. Signed-off-by: Alex Vesker Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/

[net-next 05/15] net/mlx5: DR, Call ste_builder directly with tag pointer

2020-09-30 Thread saeed
From: Yevgeny Kliteynik Instead of getting the tag in each function, call the builder directly with the tag. This will allow to use the same function for building the tag and the bitmask. Signed-off-by: Alex Vesker Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellan

[net-next 06/15] net/mlx5: DR, Add support for rule creation with flow source hint

2020-09-30 Thread saeed
From: Hamdan Igbaria Skip the rule according to flow arrival source, in case of RX and the source is local port skip and in case of TX and the source is uplink skip, we get this info according to the flow source hint we get from upper layers when creating the rule. This is needed because for exam

[net-next 02/15] net/mlx5: DR, Remove unneeded check from source port builder

2020-09-30 Thread saeed
From: Yevgeny Kliteynik Mask validity for ste builders is checked by mlx5dr_ste_build_pre_check during matcher creation. It already checks the mask value of source_vport, so removing this duplicated check. Also, moving there the check of source_eswitch_owner_vhca_id mask. Signed-off-by: Alex Ves

[net-next 13/15] net/mlx5: Fix dereference on pointer attr after null check

2020-09-30 Thread saeed
From: Ariel Levkovich When removing a flow from the slow path fdb, a flow attr struct is allocated for the rule removal process. If the allocation fails the code prints a warning message but continues with the removal flow which include dereferencing a pointer which could be null. Fix this by exi

[net-next 08/15] net/mlx5: E-switch, Add helper to check egress ACL need

2020-09-30 Thread saeed
From: Parav Pandit Currently only VF vports need egress ACL table. Add a generic helper to check whether a vport need egress ACL table or not. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/esw/ac

[net-next 01/15] net/mlx5: DR, Replace the check for valid STE entry

2020-09-30 Thread saeed
From: Yevgeny Kliteynik Validity check is done by reading the next lu_type from the STE, this check can be replaced by checking the refcount. This will make the check independent on internal STE structure. Signed-off-by: Alex Vesker Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahamee

[net-next 04/15] net/mlx5: DR, Remove unneeded local variable

2020-09-30 Thread saeed
From: Yevgeny Kliteynik The misc3 variable is used only once and can be dropped. Signed-off-by: Alex Vesker Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_matcher.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

[net-next 10/15] net/mlx5: E-switch, Move devlink eswitch ports closer to eswitch

2020-09-30 Thread saeed
From: Parav Pandit Currently devlink eswitch ports are registered and unregistered by the representor layer. However it is better to register them at eswitch layer so that in future user initiated command port add and delete commands can also register/unregister devlink ports without depending on

[net-next 12/15] net/mlx5: Use dma device access helper

2020-09-30 Thread saeed
From: Parav Pandit Use the PCI device directly for dma accesses as non PCI device unlikely support IOMMU and dma mappings. Introduce and use helper routine to access DMA device. Signed-off-by: Parav Pandit Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/m

[pull request][net-next 00/15] mlx5 updates 2020-09-30

2020-09-30 Thread saeed
From: Saeed Mahameed Hi Dave, Jakub, While the other Software steering buddy allocator series is being debated, I thought it is fine to submit this series which provides misc and small updates to mlx5 driver. For more information please see tag log below. This series doesn't conflict with the

[net-next 15/15] net/mlx5e: Fix potential null pointer dereference

2020-09-30 Thread saeed
From: "Gustavo A. R. Silva" Calls to kzalloc() and kvzalloc() should be null-checked in order to avoid any potential failures. In this case, a potential null pointer dereference. Fix this by adding null checks for _parse_attr_ and _flow_ right after allocation. Addresses-Coverity-ID: 1497154 ("

[net-next 14/15] net/mlx5e: Fix a use after free on error in mlx5_tc_ct_shared_counter_get()

2020-09-30 Thread saeed
From: Dan Carpenter This code frees "shared_counter" and then dereferences on the next line to get the error code. Fixes: 1edae2335adf ("net/mlx5e: CT: Use the same counter for both directions") Signed-off-by: Dan Carpenter Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- drive

[net-next 11/15] net/mlx5: E-Switch, Support flow source for local vport

2020-09-30 Thread saeed
From: Hamdan Igbaria Set flow source as hint for local vport. Signed-off-by: Hamdan Igbaria Reviewed-by: Oz Shlomo Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/n

Re: [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id()

2020-09-30 Thread Calvin Johnson
On Wed, Sep 30, 2020 at 08:19:02PM +0200, Andrew Lunn wrote: > On Wed, Sep 30, 2020 at 07:07:25PM +0100, Russell King - ARM Linux admin > wrote: > > On Wed, Sep 30, 2020 at 06:34:40PM +0200, Andrew Lunn wrote: > > > > @@ -2866,7 +2888,15 @@ EXPORT_SYMBOL_GPL(device_phy_find_device); > > > > */ >

Re: [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode functions

2020-09-30 Thread Calvin Johnson
On Wed, Sep 30, 2020 at 03:03:49PM -0700, David Miller wrote: > From: Calvin Johnson > Date: Wed, 30 Sep 2020 21:34:25 +0530 > > > +struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode) > > +{ > > + struct device *d; > > + struct mdio_device *mdiodev; > > Please use rev

linux-next: manual merge of the net-next tree with the net tree

2020-09-30 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/mptcp/protocol.c between commit: 917944da3bfc ("mptcp: Consistently use READ_ONCE/WRITE_ONCE with msk->ack_seq") from the net tree and commit: 8268ed4c9d19 ("mptcp: introduce and use mptcp_try_coalesce()") a

linux-next: manual merge of the net-next tree with the net tree

2020-09-30 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/mptcp/protocol.h between commit: 1a49b2c2a501 ("mptcp: Handle incoming 32-bit DATA_FIN values") from the net tree and commit: 5c8c1640956e ("mptcp: add mptcp_destroy_common helper") from the net-next tree. I

[PATCH net-next v2] net: dsa: Support bridge 802.1Q while untagging

2020-09-30 Thread Florian Fainelli
The intent of 412a1526d067 ("net: dsa: untag the bridge pvid from rx skbs") is to transparently untag the bridge's default_pvid when the Ethernet switch can only support egress tagged of that default_pvid towards the CPU port. Prior to this commit, users would have to configure an 802.1Q upper on

Re: dsa: mv88e6xxx: serdes link without phy

2020-09-30 Thread Chris Packham
On 1/10/20 2:24 pm, Andrew Lunn wrote: >>     port@8 { >>     reg = <8>; >>     label = "internal8"; >>     phy-mode = "rgmii-id"; >>     fixed-link { >>

Re: ip rule iif oif and vrf

2020-09-30 Thread Stephen Suryaputra
On Thu, Sep 24, 2020 at 08:41:54AM -0600, David Ahern wrote: > > We have multiple options on the table right now. One that can be done > > without writing any code is to use an nft prerouting rule to mark > > the packet with iif equals the tunnel and use ip rule fwmark to lookup > > the right table

Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-09-30 Thread Shannon Nelson
On 9/30/20 4:40 PM, Jacob Keller wrote: For some devices, updating the flash can take significant time during operations where no status can meaningfully be reported. This can be somewhat confusing to a user who sees devlink appear to hang on the terminal waiting for the device to update. Recent

[net 04/15] net/mlx5: poll cmd EQ in case of command timeout

2020-09-30 Thread saeed
From: Eran Ben Elisha Once driver detects a command interface command timeout, it warns the user and returns timeout error to the caller. In such case, the entry of the command is not evacuated (because only real event interrupt is allowed to clear command interface entry). If the HW event interr

[net 05/15] net/mlx5: Add retry mechanism to the command entry index allocation

2020-09-30 Thread saeed
From: Eran Ben Elisha It is possible that new command entry index allocation will temporarily fail. The new command holds the semaphore, so it means that a free entry should be ready soon. Add one second retry mechanism before returning an error. Patch "net/mlx5: Avoid possible free of command e

[net 10/15] net/mlx5e: CT, Fix coverity issue

2020-09-30 Thread saeed
From: Maor Dickman The cited commit introduced the following coverity issue at function mlx5_tc_ct_rule_to_tuple_nat: - Memory - corruptions (OVERRUN) Overrunning array "tuple->ip.src_v6.in6_u.u6_addr32" of 4 4-byte elements at element index 7 (byte offset 31) using index "ip6_offset" (whic

[net 12/15] net/mlx5e: Fix return status when setting unsupported FEC mode

2020-09-30 Thread saeed
From: Aya Levin Verify the configured FEC mode is supported by at least a single link mode before applying the command. Otherwise fail the command and return "Operation not supported". Prior to this patch, the command was successful, yet it falsely set all link modes to FEC auto mode - like confi

[net 09/15] net/mlx5e: Add resiliency in Striding RQ mode for packets larger than MTU

2020-09-30 Thread saeed
From: Aya Levin Prior to this fix, in Striding RQ mode the driver was vulnerable when receiving packets in the range (stride size - headroom, stride size]. Where stride size is calculated by mtu+headroom+tailroom aligned to the closest power of 2. Usually, this filtering is performed by the HW, e

[net 11/15] net/mlx5e: Fix driver's declaration to support GRE offload

2020-09-30 Thread saeed
From: Aya Levin Declare GRE offload support with respect to the inner protocol. Add a list of supported inner protocols on which the driver can offload checksum and GSO. For other protocols, inform the stack to do the needed operations. There is no noticeable impact on GRE performance. Fixes: 27

[net 15/15] net/mlx5e: Fix race condition on nhe->n pointer in neigh update

2020-09-30 Thread saeed
From: Vlad Buslov Current neigh update event handler implementation takes reference to neighbour structure, assigns it to nhe->n, tries to schedule workqueue task and releases the reference if task was already enqueued. This results potentially overwriting existing nhe->n pointer with another nei

[net 14/15] net/mlx5e: Fix VLAN create flow

2020-09-30 Thread saeed
From: Aya Levin When interface is attached while in promiscuous mode and with VLAN filtering turned off, both configurations are not respected and VLAN filtering is performed. There are 2 flows which add the any-vid rules during interface attach: VLAN creation table and set rx mode. Each is relay

[net 03/15] net/mlx5: Avoid possible free of command entry while timeout comp handler

2020-09-30 Thread saeed
From: Eran Ben Elisha Upon command completion timeout, driver simulates a forced command completion. In a rare case where real interrupt for that command arrives simultaneously, it might release the command entry while the forced handler might still access it. Fix that by adding an entry refcoun

[net 07/15] net/mlx5: Fix request_irqs error flow

2020-09-30 Thread saeed
From: Maor Gottlieb Fix error flow handling in request_irqs which try to free irq that we failed to request. It fixes the below trace. WARNING: CPU: 1 PID: 7587 at kernel/irq/manage.c:1684 free_irq+0x4d/0x60 CPU: 1 PID: 7587 Comm: bash Tainted: GW OE 4.15.15-1.el7MELLANOXsmp-x86_64

[net 13/15] net/mlx5e: Fix VLAN cleanup flow

2020-09-30 Thread saeed
From: Aya Levin Prior to this patch unloading an interface in promiscuous mode with RX VLAN filtering feature turned off - resulted in a warning. This is due to a wrong condition in the VLAN rules cleanup flow, which left the any-vid rules in the VLAN steering table. These rules prevented destroy

[net 02/15] net/mlx5: Fix a race when moving command interface to polling mode

2020-09-30 Thread saeed
From: Eran Ben Elisha As part of driver unload, it destroys the commands EQ (via FW command). As the commands EQ is destroyed, FW will not generate EQEs for any command that driver sends afterwards. Driver should poll for later commands status. Driver commands mode metadata is updated before the

[net 08/15] net/mlx5e: Fix error path for RQ alloc

2020-09-30 Thread saeed
From: Aya Levin Increase granularity of the error path to avoid unneeded free/release. Fix the cleanup to be symmetric to the order of creation. Fixes: 0ddf543226ac ("xdp/mlx5: setup xdp_rxq_info") Fixes: 422d4c401edd ("net/mlx5e: RX, Split WQ objects for different RQ types") Signed-off-by: Aya

[net 06/15] net/mlx5: cmdif, Avoid skipping reclaim pages if FW is not accessible

2020-09-30 Thread saeed
From: Saeed Mahameed In case of pci is offline reclaim_pages_cmd() will still try to call the FW to release FW pages, cmd_exec() in this case will return a silent success without actually calling the FW. This is wrong and will cause page leaks, what we should do is to detect pci offline or comma

[PATCH bpf-next v7 2/2] selftests/bpf: Selftest for real time helper

2020-09-30 Thread bimmy . pujari
From: Bimmy Pujari Add test validating that bpf_ktime_get_real_ns works fine. Signed-off-by: Bimmy Pujari --- .../selftests/bpf/prog_tests/ktime_real.c | 42 +++ .../bpf/progs/test_ktime_get_real_ns.c| 36 2 files changed, 78 insertions(+) create m

[pull request][net 00/15] mlx5 fixes 2020-09-30

2020-09-30 Thread saeed
From: Saeed Mahameed Hi Dave, This series introduces some fixes to mlx5 driver. Please pull and let me know if there is any problem. For -stable v4.15 ('net/mlx5e: Fix VLAN cleanup flow') ('net/mlx5e: Fix VLAN create flow') For -stable v4.16 ('net/mlx5: Fix request_irqs error flow') For -

[net 01/15] net/mlx5: Don't allow health work when device is uninitialized

2020-09-30 Thread saeed
From: Shay Drory On error flow due to failure on driver load, driver can be un-initializing while a health work is running in the background, health work shouldn't be allowed at this point, as it needs resources to be initialized and there is no point to recover on driver load failures. Therefor

[PATCH bpf-next v7 1/2] bpf: Add bpf_ktime_get_real_ns

2020-09-30 Thread bimmy . pujari
From: Bimmy Pujari The existing bpf helper functions to get timestamp return the time elapsed since system boot. This timestamp is not particularly useful where epoch timestamp is required or more than one server is involved and time sync is required. Instead, you want to use CLOCK_REALTIME, whic

Re: [bpf-next PATCH 1/2] bpf, sockmap: add skb_adjust_room to pop bytes off ingress payload

2020-09-30 Thread John Fastabend
Jakub Sitnicki wrote: > On Sat, Sep 26, 2020 at 06:27 AM CEST, John Fastabend wrote: > > This implements a new helper skb_adjust_room() so users can push/pop > > extra bytes from a BPF_SK_SKB_STREAM_VERDICT program. > > > > Some protocols may include headers and other information that we may > > no

Re: Genetlink per cmd policies

2020-09-30 Thread Andrew Lunn
On Wed, Sep 30, 2020 at 05:23:17PM -0700, Jakub Kicinski wrote: > On Thu, 1 Oct 2020 01:38:17 +0200 Andrew Lunn wrote: > > > > > +static void genl_op_from_full(const struct genl_family *family, > > > > > + unsigned int i, struct genl_ops *op) > > > > > +{ > > > > > + m

Re: dsa: mv88e6xxx: serdes link without phy

2020-09-30 Thread Andrew Lunn
>     port@8 { >     reg = <8>; >     label = "internal8"; >     phy-mode = "rgmii-id"; >     fixed-link { >     speed = <100

[PATCH net-next v2 1/2] Makefile.extrawarn: Add symbol for W=1 warnings for today

2020-09-30 Thread Andrew Lunn
set of additional compile flags using the symbol KBUILD_CFLAGS_W1_20200930. Subdirectory Makefiles can then use: subdir-ccflags-y := $(KBUILD_CFLAGS_W1_20200930) To indicate they want to W=1 warnings as defined on 20200930. Additional warnings can be added to the W=1 definition. This will not

[PATCH net-next v2 2/2] driver/net/ethernet: Sign up for W=1 as defined on 20200930

2020-09-30 Thread Andrew Lunn
Make all Ethernet drivers be compiled with the equivalent of W=1 as defined today. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile index f8f38dcb5f8a..8162b2f6ec81 10

[RFC PATCH net-next v2 0/2] driver/net/ethernet W=1 by default

2020-09-30 Thread Andrew Lunn
e able to add new W=1 compiler flags without actually causing new warnings for builds which don't have W=1 Andrew Lunn (2): Makefile.extrawarn: Add symbol for W=1 warnings for today driver/net/ethernet: Sign up for W=1 as defined on 20200930 drivers/net/ethernet/Makefile

Re: INFO: task hung in tcf_action_init_1

2020-09-30 Thread Cong Wang
#syz test: https://github.com/congwang/linux.git net

[PATCH bpf v2] bpf: fix "unresolved symbol" build error with resolve_btfids

2020-09-30 Thread Yonghong Song
Michal reported a build failure likes below: BTFIDS vmlinux FAILED unresolved symbol tcp_timewait_sock make[1]: *** [/.../linux-5.9-rc7/Makefile:1176: vmlinux] Error 255 This error can be triggered when config has CONFIG_NET enabled but CONFIG_INET disabled. In this case, there is no use

Re: [PATCH net-next 0/7] drop_monitor: Convert to use devlink tracepoint

2020-09-30 Thread David Miller
From: Ido Schimmel Date: Tue, 29 Sep 2020 11:15:49 +0300 > From: Ido Schimmel > > Drop monitor is able to monitor both software and hardware originated > drops. Software drops are monitored by having drop monitor register its > probe on the 'kfree_skb' tracepoint. Hardware originated drops are

Re: [PATCH bpf] bpf: fix "unresolved symbol" build error with resolve_btfids

2020-09-30 Thread Yonghong Song
On 9/30/20 3:59 PM, Martin KaFai Lau wrote: On Wed, Sep 30, 2020 at 03:50:10PM -0700, Yonghong Song wrote: On 9/30/20 1:58 PM, Martin KaFai Lau wrote: On Wed, Sep 30, 2020 at 09:41:09AM -0700, Yonghong Song wrote: Michal reported a build failure likes below: BTFIDS vmlinux FAIL

Re: [PATCH bpf-next v6 1/2] bpf: Add bpf_ktime_get_real_ns

2020-09-30 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/bimmy-pujari-intel-com/bpf-Add-bpf_ktime_get_real_ns/20201001-063024 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master

dsa: mv88e6xxx: serdes link without phy

2020-09-30 Thread Chris Packham
Hi, We have a chassis platform that (ab)uses an Ethernet backplane consisting of MV88E6097 on the line cards connecting to a MV98DX160 on the chassis controller(s). I'm attempting to update the line cards to a modern kernel trying to do away with a lot of custom hackery from our older kernel.

Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink parser error drop traps

2020-09-30 Thread Jakub Kicinski
On Wed, 30 Sep 2020 22:16:45 +0300 Ioana Ciornei wrote: > Add support for the new group of devlink traps - PARSER_ERROR_DROPS. > This consists of registering the array of parser error drops supported, > controlling their action through the .trap_group_action_set() callback > and reporting an errone

Re: Genetlink per cmd policies

2020-09-30 Thread Jakub Kicinski
On Thu, 1 Oct 2020 01:38:17 +0200 Andrew Lunn wrote: > > > > +static void genl_op_from_full(const struct genl_family *family, > > > > + unsigned int i, struct genl_ops *op) > > > > +{ > > > > + memcpy(op, &family->ops[i], sizeof(*op)); > > > > > > What's wrong

Re: [PATCH net-next] net: dsa: Support bridge 802.1Q while untagging

2020-09-30 Thread Florian Fainelli
On 9/30/2020 4:29 PM, Florian Fainelli wrote: On 9/30/2020 1:43 PM, Vladimir Oltean wrote: On Wed, Sep 30, 2020 at 01:31:03PM -0700, Florian Fainelli wrote: While we are it, call __vlan_find_dev_deep_rcu() which makes use the VLAN group array which is faster. Not just "while at it", but

[RFC net-next 4/9] genetlink: move to smaller ops wherever possible

2020-09-30 Thread Jakub Kicinski
Bulk of the genetlink users can use smaller ops, move them. Signed-off-by: Jakub Kicinski --- drivers/block/nbd.c | 6 +++--- drivers/net/gtp.c| 6 +++--- drivers/net/ieee802154/mac802154_hwsim.c | 6 +++--- drivers/net/macsec.c

[RFC net-next 6/9] genetlink: use .start callback for dumppolicy

2020-09-30 Thread Jakub Kicinski
The structure of ctrl_dumppolicy() is clearly split into init and dumping. Move the init to a .start callback for clarity, it's a more idiomatic netlink dump code structure. Signed-off-by: Jakub Kicinski --- net/netlink/genetlink.c | 48 - 1 file changed,

[RFC net-next 8/9] genetlink: use per-op policy for CTRL_CMD_GETPOLICY

2020-09-30 Thread Jakub Kicinski
Wire up per-op policy for CTRL_CMD_GETPOLICY. This saves us a call to genlmsg_parse() and will soon allow dumping this policy. Create a new policy definition, since we don't want to pollute ctrl_policy with attributes which CTRL_CMD_GETFAMILY does not support. Signed-off-by: Jakub Kicinski ---

[RFC net-next 9/9] genetlink: allow dumping command-specific policy

2020-09-30 Thread Jakub Kicinski
Right now CTRL_CMD_GETPOLICY can only dump the family-wide policy. Support dumping policy of a specific op. Signed-off-by: Jakub Kicinski --- include/uapi/linux/genetlink.h | 1 + net/netlink/genetlink.c| 23 +-- 2 files changed, 22 insertions(+), 2 deletions(-) dif

[RFC net-next 5/9] genetlink: add a structure for dump state

2020-09-30 Thread Jakub Kicinski
Whenever netlink dump uses more than 2 cb->args[] entries code gets hard to read. We're about to add more state to ctrl_dumppolicy() so create a structure. Since the structure is typed and clearly named we can remove the local fam_id variable and use ctx->fam_id directly. Signed-off-by: Jakub Kic

[RFC net-next 1/9] genetlink: add missing kdoc for validation flags

2020-09-30 Thread Jakub Kicinski
Validation flags are missing kdoc, add it. Fixes: ef6243acb478 ("genetlink: optionally validate strictly/dumps") Signed-off-by: Jakub Kicinski --- include/net/genetlink.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net/genetlink.h b/include/net/genetlink.h index b9eb92f3fe86..a34

[RFC net-next 7/9] genetlink: bring back per op policy

2020-09-30 Thread Jakub Kicinski
Add policy to the struct genl_ops structure, this time with maxattr, so it can be used properly. Propagate .policy and .maxattr from the family in genl_get_cmd() if needed, this say the rest of the code does not have to worry if the policy is per op or global. Signed-off-by: Jakub Kicinski ---

[RFC net-next 0/9] genetlink: support per-command policy dump

2020-09-30 Thread Jakub Kicinski
Hi! The objective of this series is to dump ethtool policies to be able to tell which flags are supported by the kernel. Ethtool policies are per command. First patch here is included for completeness - it's already in net, but other patches won't apply cleanly without it. The series adds new se

[RFC net-next 2/9] genetlink: reorg struct genl_family

2020-09-30 Thread Jakub Kicinski
There are holes and oversized members in struct genl_family. Before: /* size: 104, cachelines: 2, members: 16 */ After: /* size: 88, cachelines: 2, members: 16 */ The command field in struct genlmsghdr is a u8, so no point in the operation count being 32 bit. Also operation 0 is usually undefin

[RFC net-next 3/9] genetlink: add small version of ops

2020-09-30 Thread Jakub Kicinski
We want to add maxattr and policy back to genl_ops, to enable dumping per command policy to user space. This, however, would cause bloat for all the families with global policies. Introduce smaller version of ops (half the size of genl_ops). Translate these smaller ops into a full blown struct befo

Re: Altera TSE driver not working in 100mbps mode

2020-09-30 Thread Andrew Lunn
> I now seem to be tantalisingly close to getting it working. I can see > network packets arriving if I do a "tcpdump -i eth0" using a copper > 10/100/1000Base-T SFP, but no packets seem to be transmitted. I'm guessing > I've maybe messed up on the device tree entries for either the SFP config or >

[iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-09-30 Thread Jacob Keller
For some devices, updating the flash can take significant time during operations where no status can meaningfully be reported. This can be somewhat confusing to a user who sees devlink appear to hang on the terminal waiting for the device to update. Recent changes to the kernel interface allow suc

Re: Genetlink per cmd policies

2020-09-30 Thread Andrew Lunn
> > > +static void genl_op_from_full(const struct genl_family *family, > > > + unsigned int i, struct genl_ops *op) > > > +{ > > > + memcpy(op, &family->ops[i], sizeof(*op)); > > > > What's wrong with struct assignment? :) > > > > *op = family->ops[i]; > > Code size :

Re: [PATCH net-next] net: dsa: Support bridge 802.1Q while untagging

2020-09-30 Thread Florian Fainelli
On 9/30/2020 1:43 PM, Vladimir Oltean wrote: On Wed, Sep 30, 2020 at 01:31:03PM -0700, Florian Fainelli wrote: While we are it, call __vlan_find_dev_deep_rcu() which makes use the VLAN group array which is faster. Not just "while at it", but I do wonder whether it isn't, in fact, called "de

Re: linux-next: build failure after merge of the net-next tree

2020-09-30 Thread Stephen Rothwell
Hi Vadym, On Thu, 1 Oct 2020 02:06:05 +0300 Vadym Kochan wrote: > > On Thu, Oct 01, 2020 at 08:09:16AM +1000, Stephen Rothwell wrote: > > Hi all, > > > [CUT] > > > > I am still getting this build failure ... > > > > -- > > I just 've checked linux-next/master and it builds fine at least

Re: linux-next: build failure after merge of the net-next tree

2020-09-30 Thread Vadym Kochan
Hi Stephen, On Thu, Oct 01, 2020 at 08:09:16AM +1000, Stephen Rothwell wrote: > Hi all, > [CUT] > > I am still getting this build failure ... > > -- I just 've checked linux-next/master and it builds fine at least with my custom config, do/how I need to handle this case ? I see the changes y

Re: [PATCH bpf] bpf: fix "unresolved symbol" build error with resolve_btfids

2020-09-30 Thread Martin KaFai Lau
On Wed, Sep 30, 2020 at 03:50:10PM -0700, Yonghong Song wrote: > > > On 9/30/20 1:58 PM, Martin KaFai Lau wrote: > > On Wed, Sep 30, 2020 at 09:41:09AM -0700, Yonghong Song wrote: > > > Michal reported a build failure likes below: > > > BTFIDS vmlinux > > > FAILED unresolved symbol tcp_t

[PATCH v5 bpf-next 2/2] selftests/bpf: add tests for BPF_F_PRESERVE_ELEMS

2020-09-30 Thread Song Liu
Add tests for perf event array with and without BPF_F_PRESERVE_ELEMS. Add a perf event to array via fd mfd. Without BPF_F_PRESERVE_ELEMS, the perf event is removed when mfd is closed. With BPF_F_PRESERVE_ELEMS, the perf event is removed when the map is freed. Signed-off-by: Song Liu --- .../bpf

Re: [PATCH bpf] bpf: fix "unresolved symbol" build error with resolve_btfids

2020-09-30 Thread Yonghong Song
On 9/30/20 1:58 PM, Martin KaFai Lau wrote: On Wed, Sep 30, 2020 at 09:41:09AM -0700, Yonghong Song wrote: Michal reported a build failure likes below: BTFIDS vmlinux FAILED unresolved symbol tcp_timewait_sock make[1]: *** [/.../linux-5.9-rc7/Makefile:1176: vmlinux] Error 255 Th

[PATCH v5 bpf-next 1/2] bpf: introduce BPF_F_PRESERVE_ELEMS for perf event array

2020-09-30 Thread Song Liu
Currently, perf event in perf event array is removed from the array when the map fd used to add the event is closed. This behavior makes it difficult to the share perf events with perf event array. Introduce perf event map that keeps the perf event open with a new flag BPF_F_PRESERVE_ELEMS. With t

[PATCH v5 bpf-next 0/2] introduce BPF_F_PRESERVE_ELEMS

2020-09-30 Thread Song Liu
This set introduces BPF_F_PRESERVE_ELEMS to perf event array for better sharing of perf event. By default, perf event array removes the perf event when the map fd used to add the event is closed. With BPF_F_PRESERVE_ELEMS set, however, the perf event will stay in the array until it is removed, or t

linux-next: Fixes tags need some work in the net tree

2020-09-30 Thread Stephen Rothwell
Hi all, In commit 66a5209b5341 ("octeontx2-pf: Fix synchnorization issue in mbox") Fixes tag Fixes: d424b6c02 ("octeontx2-pf: Enable SRIOV and added VF mbox handling") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more)

Re: [PATCH bpf-next 0/4] libbpf: add raw BTF type dumping

2020-09-30 Thread Andrii Nakryiko
On Wed, Sep 30, 2020 at 2:29 PM Alexei Starovoitov wrote: > > On Wed, Sep 30, 2020 at 11:22:50AM -0700, Andrii Nakryiko wrote: > > > > If you are saying it should emit it in Go format, Rust format, or > > other language-specific way, then sure, > > Yes. that's what I'm saying. cloudflare and ciliu

Re: [PATCH v4 bpf-next 2/2] selftests/bpf: add tests for BPF_F_PRESERVE_ELEMS

2020-09-30 Thread Song Liu
> On Sep 30, 2020, at 2:28 PM, Song Liu wrote: > > Add tests for perf event array with and without BPF_F_PRESERVE_ELEMS. > > Add a perf event to array via fd mfd. Without BPF_F_PRESERVE_ELEMS, the > perf event is removed when mfd is closed. With BPF_F_PRESERVE_ELEMS, the > perf event is remov

[PATCH bpf-next v6 2/2] selftests/bpf: Selftest for real time helper

2020-09-30 Thread bimmy . pujari
From: Bimmy Pujari Add test validating that bpf_ktime_get_real_ns works fine. Signed-off-by: Bimmy Pujari --- .../selftests/bpf/prog_tests/ktime_real.c | 42 +++ .../bpf/progs/test_ktime_get_real_ns.c| 36 2 files changed, 78 insertions(+) create m

[PATCH bpf-next v6 1/2] bpf: Add bpf_ktime_get_real_ns

2020-09-30 Thread bimmy . pujari
From: Bimmy Pujari The existing bpf helper functions to get timestamp return the time elapsed since system boot. This timestamp is not particularly useful where epoch timestamp is required or more than one server is involved and time sync is required. Instead, you want to use CLOCK_REALTIME, whic

  1   2   3   4   >