Re: [PATCH bpf-next 3/3] selftests/bpf: add raw_tp_test_run

2020-09-22 Thread Song Liu
Thanks for the quick review! > On Sep 22, 2020, at 9:49 PM, John Fastabend wrote: > > Song Liu wrote: >> This test runs test_run for raw_tracepoint program. The test covers ctx >> input, retval output, and proper handling of cpu_plus field. >> >> Signed-off-by: Song Liu >> --- > > [...] > >>

[net-next 06/15] net/mlx5e: Add tc chains offload support for nic flows

2020-09-22 Thread saeed
From: Ariel Levkovich Allow adding nic tc flow rules with goto chain action. Connecting the nic flows to the mlx5 chains infrastructure in previous patches allows us to support the creation of chained flow tables and rules that direct to another chain for further packet processing. This is a req

[net-next 04/15] net/mlx5e: Split nic tc flow allocation and creation

2020-09-22 Thread saeed
From: Ariel Levkovich For future support of CT offload with nic tc flows, where the flow rule is not created immediately but rather following a future event, the patch is splitting the nic rule creation and deletion into 2 parts: 1. Creating/Deleting and setting the rule attributes. 2. Creating/D

[pull request][net-next 00/15] mlx5 Connection Tracking in NIC mode

2020-09-22 Thread saeed
From: Saeed Mahameed Hi Dave, Jakub, This series adds the support for connection tracking in NIC mode, and attached to this series some trivial cleanup patches. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The followin

[net-next 09/15] net/mlx5e: CT: Use the same counter for both directions

2020-09-22 Thread saeed
From: Oz Shlomo A connection is represented by two 5-tuple entries, one for each direction. Currently, each direction allocates its own hw counter, which is inefficient as ct aging is managed per connection. Share the counter that was allocated for the original direction with the reverse directi

[net-next 10/15] net/mlx5e: TC: Remove unused parameter from mlx5_tc_ct_add_no_trk_match()

2020-09-22 Thread saeed
From: Saeed Mahameed priv is never used in this function Fixes: 7e36feeb0467 ("net/mlx5e: CT: Don't offload tuple rewrites for established tuples") Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 4 +--- drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.h

[net-next 01/15] net/mlx5: Refactor multi chains and prios support

2020-09-22 Thread saeed
From: Ariel Levkovich Decouple the chains infrastructure from eswitch and make it generic to support other steering namespaces. The change defines an agnostic data structure to keep all the relevant information for maintaining flow table chaining in any steering namespace. Each namespace that re

[net-next 08/15] net/mlx5e: Support CT offload for tc nic flows

2020-09-22 Thread saeed
From: Ariel Levkovich Adding support to perform CT related tc actions and matching on CT states for nic flows. The ct flows management and handling will be done using a new instance of the ct database that is declared in this patch to keep it separate from the eswitch ct flows database. Offloadi

[net-next 07/15] net/mlx5e: rework ct offload init messages

2020-09-22 Thread saeed
From: Ariel Levkovich The changes are: - Use mlx5_core print macros instead of netdev_warn since netdev is not always initialized at that stage. - Print a warning message in case the issue is with lack of support for CT offload without indicating an error. Signed-off-by: Ariel Levkovich Re

[net-next 03/15] net/mlx5e: Tc nic flows to use mlx5_chains flow tables

2020-09-22 Thread saeed
From: Ariel Levkovich Change nic tc flows offload path to use the chains and prios infrastructure for the flow table creation as a preparation to support tc multi chains and priorities for nic flows. Adding an instance of the table chaining database to the nic tc struct and perform the root tabl

[net-next 05/15] net/mlx5: Refactor tc flow attributes structure

2020-09-22 Thread saeed
From: Ariel Levkovich In order to support chains and connection tracking offload for nic flows, there's a need to introduce a common flow attributes struct so that these features can be agnostic and have access to a single attributes struct, regardless of the flow type. Therefore, a new tc flow

[net-next 02/15] net/mlx5: Allow ft level ignore for nic rx tables

2020-09-22 Thread saeed
From: Ariel Levkovich Allow setting a flow table with a lower level as a rule destination in nic rx tables. This is required in order to support table chaining of tc nic flows. Signed-off-by: Ariel Levkovich Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed Signed-off-by: Saeed Mahameed -

[net-next 11/15] net/mlx5e: Keep direct reference to mlx5_core_dev in tc ct

2020-09-22 Thread saeed
From: Ariel Levkovich Keep and use a direct reference to the mlx5 core device in all of tc_ct code instead of accessing it via a pointer to mlx5 eswitch in order to support nic mode ct offload for VF devices that don't have a valid eswitch pointer set. Signed-off-by: Ariel Levkovich Reviewed-by

[net-next 13/15] net/mlx5e: Use kfree() to free fd->g in accel_fs_tcp_create_groups()

2020-09-22 Thread saeed
From: Denis Efremov Memory ft->g in accel_fs_tcp_create_groups() is allocaed with kcalloc(). It's excessive to free ft->g with kvfree(). Use kfree() instead. Signed-off-by: Denis Efremov Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 2 +- 1 file

[net-next 15/15] net/mlx5: remove unreachable return

2020-09-22 Thread saeed
From: "Pavel Machek (CIP)" The last return statement is unreachable code. I'm not sure if it will provoke any warnings, but it looks ugly. Signed-off-by: Pavel Machek (CIP) Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 2 -- 1 file changed, 2 deletion

[net-next 12/15] net/mlx5e: IPsec: Use kvfree() for memory allocated with kvzalloc()

2020-09-22 Thread saeed
From: Denis Efremov Variables flow_group_in, spec in rx_fs_create() are allocated with kvzalloc(). It's incorrect to free them with kfree(). Use kvfree() instead. Fixes: 5e466345291a ("net/mlx5e: IPsec: Add IPsec steering in local NIC RX") Signed-off-by: Denis Efremov Signed-off-by: Saeed Maham

[net-next 14/15] net/mlx5: simplify the return expression of mlx5_ec_init()

2020-09-22 Thread saeed
From: Qinglang Miao Simplify the return expression. Signed-off-by: Qinglang Miao Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/ecpf.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ecpf.c b/driver

[PATCH] ipvs: adjust the debug order of src and dst

2020-09-22 Thread yue longguang
From: ylg adjust the debug order of src and dst when tcp state changes Signed-off-by: ylg --- net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_proto_tcp.c b/net/netfilter/ipvs/ip_vs_proto_tcp.c index dc2e7da27

let import_iovec deal with compat_iovecs as well v3

2020-09-22 Thread Christoph Hellwig
Hi Al, this series changes import_iovec to transparently deal with comat iovec structures, and then cleanups up a lot of code dupliation. Changes since v2: - revert the switch of the access process vm sysclls to iov_iter - refactor the import_iovec internals differently - switch aio to use __i

[PATCH 7/9] fs: remove compat_sys_vmsplice

2020-09-22 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs, the native vmsplice syscall can be used for the compat case as well. Signed-off-by: Christoph Hellwig --- arch/arm64/include/asm/unistd32.h | 2 +- arch/mips/kernel/syscalls/syscall_n32.tbl | 2 +- arch/mips/kernel/syscalls/syscall_o

[PATCH 4/9] iov_iter: transparently handle compat iovecs in import_iovec

2020-09-22 Thread Christoph Hellwig
Use in compat_syscall to import either native or the compat iovecs, and remove the now superflous compat_import_iovec. This removes the need for special compat logic in most callers, and the remaining ones can still be simplified by using __import_iovec with a bool compat parameter. Signed-off-by

[PATCH 9/9] security/keys: remove compat_keyctl_instantiate_key_iov

2020-09-22 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs, the native version of keyctl_instantiate_key_iov can be used for the compat case as well. Signed-off-by: Christoph Hellwig --- security/keys/compat.c | 36 ++-- security/keys/internal.h | 5 - security/keys/keyct

[PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c

2020-09-22 Thread Christoph Hellwig
From: David Laight This lets the compiler inline it into import_iovec() generating much better code. Signed-off-by: David Laight Signed-off-by: Christoph Hellwig --- fs/read_write.c | 179 lib/iov_iter.c | 176 +

[PATCH 3/9] iov_iter: refactor rw_copy_check_uvector and import_iovec

2020-09-22 Thread Christoph Hellwig
Split rw_copy_check_uvector into two new helpers with more sensible calling conventions: - iovec_from_user copies a iovec from userspace either into the provided stack buffer if it fits, or allocates a new buffer for it. Returns the actually used iovec. It also verifies that iov_len does

[PATCH 5/9] fs: remove various compat readv/writev helpers

2020-09-22 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs as well, all the duplicated code in the compat readv/writev helpers is not needed. Remove them and switch the compat syscall handlers to use the native helpers. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 179 ---

[PATCH] ipvs: adjust the debug order of src and dst

2020-09-22 Thread longguang.yue
From: ylg adjust the debug order of src and dst when tcp state changes Signed-off-by: ylg --- net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_proto_tcp.c b/net/netfilter/ipvs/ip_vs_proto_tcp.c index dc2e7da2

[PATCH 8/9] mm: remove compat_process_vm_{readv,writev}

2020-09-22 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs, the native syscalls can be used for the compat case as well. Signed-off-by: Christoph Hellwig --- arch/arm64/include/asm/unistd32.h | 4 +- arch/mips/kernel/syscalls/syscall_n32.tbl | 4 +- arch/mips/kernel/syscalls/syscall_o32.tbl

[PATCH 6/9] fs: remove the compat readv/writev syscalls

2020-09-22 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs, the native readv and writev syscalls can be used for the compat case as well. Signed-off-by: Christoph Hellwig --- arch/arm64/include/asm/unistd32.h | 4 ++-- arch/mips/kernel/syscalls/syscall_n32.tbl | 4 ++-- arch/mips/ke

[PATCH 1/9] compat.h: fix a spelling error in

2020-09-22 Thread Christoph Hellwig
There is no compat_sys_readv64v2 syscall, only a compat_sys_preadv64v2 one. Signed-off-by: Christoph Hellwig --- include/linux/compat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/compat.h b/include/linux/compat.h index b354ce58966e2d..654c1ec36671a4 100644

[PATCH 1/1] powerpc/vnic: Extend "failover pending" window

2020-09-22 Thread Sukadev Bhattiprolu
>From 547fa5627b63102f3ef80ed3a032d62c88c5 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Thu, 10 Sep 2020 11:18:41 -0700 Subject: [PATCH 1/1] powerpc/vnic: Extend "failover pending" window Commit 5a18e1e0c193b introduced the 'failover_pending' state to track the "failover pending

[PATCH v2] net/ipv4: always honour route mtu during forwarding

2020-09-22 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Documentation/networking/ip-sysctl.txt:46 says: ip_forward_use_pmtu - BOOLEAN By default we don't trust protocol path MTUs while forwarding because they could be easily forged and can lead to unwanted fragmentation by the router. You only need to enable

RE: [PATCH bpf-next 3/3] selftests/bpf: add raw_tp_test_run

2020-09-22 Thread John Fastabend
Song Liu wrote: > This test runs test_run for raw_tracepoint program. The test covers ctx > input, retval output, and proper handling of cpu_plus field. > > Signed-off-by: Song Liu > --- [...] > + > + test_attr.ctx_size_in = sizeof(args); > + err = bpf_prog_test_run_xattr(&test_attr); >

Re: [PATCH v3 bpf-next 01/11] bpf: Move the PTR_TO_BTF_ID check to check_reg_type()

2020-09-22 Thread Martin KaFai Lau
On Tue, Sep 22, 2020 at 10:56:55AM +0100, Lorenz Bauer wrote: > On Tue, 22 Sep 2020 at 08:04, Martin KaFai Lau wrote: > > > > check_reg_type() checks whether a reg can be used as an arg of a > > func_proto. For PTR_TO_BTF_ID, the check is actually not > > completely done until the reg->btf_id is

[PATCH] net/ipv4: always honour route mtu during forwarding

2020-09-22 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Documentation/networking/ip-sysctl.txt:46 says: ip_forward_use_pmtu - BOOLEAN By default we don't trust protocol path MTUs while forwarding because they could be easily forged and can lead to unwanted fragmentation by the router. You only need to enable

RE: [PATCH bpf-next 2/3] libbpf: introduce bpf_prog_test_run_xattr_opts

2020-09-22 Thread John Fastabend
Song Liu wrote: > This API supports new field cpu_plus in bpf_attr.test. > > Signed-off-by: Song Liu > --- Acked-by: John Fastabend

RE: [PATCH bpf-next 1/3] bpf: enable BPF_PROG_TEST_RUN for raw_tracepoint

2020-09-22 Thread John Fastabend
Song Liu wrote: > Add .test_run for raw_tracepoint. Also, introduce a new feature that runs > the target program on a specific CPU. This is achieved by a new flag in > bpf_attr.test, cpu_plus. For compatibility, cpu_plus == 0 means run the > program on current cpu, cpu_plus > 0 means run the progra

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread kernel test robot
Hi Jarod, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jarod-Wilson/bonding-rename-bond-components/20200922-214046 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

[RFC PATCH] bonding: linkdesc can be static

2020-09-22 Thread kernel test robot
Signed-off-by: kernel test robot --- bond_procfs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c index 91ece68607b23..9b1b37a682728 100644 --- a/drivers/net/bonding/bond_procfs.c +++ b/drivers/net/bo

[Patch net 1/2] net_sched: defer tcf_idr_insert() in tcf_action_init_1()

2020-09-22 Thread Cong Wang
All TC actions call tcf_idr_insert() for new action at the end of their ->init(), so we can actually move it to a central place in tcf_action_init_1(). And once the action is inserted into the global IDR, other parallel process could free it immediately as its refcnt is still 1, so we can not fail

[Patch net 0/2] net_sched: fix a UAF in tcf_action_init()

2020-09-22 Thread Cong Wang
This patchset fixes a use-after-free triggered by syzbot. Please find more details in each patch description. --- Cong Wang (2): net_sched: defer tcf_idr_insert() in tcf_action_init_1() net_sched: commit action insertions together include/net/act_api.h | 2 -- net/sched/act_api.c

[Patch net 2/2] net_sched: commit action insertions together

2020-09-22 Thread Cong Wang
syzbot is able to trigger a failure case inside the loop in tcf_action_init(), and when this happens we clean up with tcf_action_destroy(). But, as these actions are already inserted into the global IDR, other parallel process could free them before tcf_action_destroy(), then we will trigger a use-

Re: [PATCH] SUNRPC: Fix svc_flush_dcache()

2020-09-22 Thread He Zhe
On 9/22/20 10:14 PM, Chuck Lever wrote: > >> On Sep 22, 2020, at 3:13 AM, He Zhe wrote: >> >> >> >> On 9/21/20 3:51 AM, Chuck Lever wrote: >>> On platforms that implement flush_dcache_page(), a large NFS WRITE >>> triggers the WARN_ONCE in bvec_iter_advance(): >>> >>> Sep 20 14:01:05 klimt.1015

[PATCH -next v2] ath9k: Remove set but not used variable

2020-09-22 Thread Li Heng
This addresses the following gcc warning with "make W=1": drivers/net/wireless/ath/ath9k/ar9580_1p0_initvals.h:1331:18: warning: ‘ar9580_1p0_pcie_phy_clkreq_enable_L1’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/ath/ath9k/ar9580_1p0_initvals.h:1338:18: warning: ‘ar9580_1

[PATCH net-next v2] net: microchip: Make `lan743x_pm_suspend` function return right value

2020-09-22 Thread Zheng Yongjun
drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend: `ret` is set but not used. In fact, `pci_prepare_to_sleep` function value should be the right value of `lan743x_pm_suspend` function, therefore, fix it. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/microchip

[PATCH net-next 1/2] net: dsa: untag the bridge pvid from rx skbs

2020-09-22 Thread Florian Fainelli
From: Vladimir Oltean Currently the bridge untags VLANs present in its VLAN groups in __allowed_ingress() only when VLAN filtering is enabled. But when a skb is seen on the RX path as tagged with the bridge's pvid, and that bridge has vlan_filtering=0, and there isn't any 8021q upper with that V

[PATCH net-next 2/2] net: dsa: b53: Configure VLANs while not filtering

2020-09-22 Thread Florian Fainelli
Update the B53 driver to support VLANs while not filtering. This requires us to enable VLAN globally within the switch upon driver initial configuration (dev->vlan_enabled). We also need to remove the code that dealt with PVID re-configuration in b53_vlan_filtering() since that function worked und

[PATCH net-next 0/2] net: dsa: b53: Configure VLANs while not filtering

2020-09-22 Thread Florian Fainelli
Hi David, Jakub, These two patches allow the b53 driver which always configures its CPU port as egress tagged to behave correctly with VLANs being always configured whenever a port is added to a bridge. Vladimir provides a patch that aligns the bridge with vlan_filtering=0 receive path to behave

Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Chunxin Zang
On Wed, Sep 23, 2020 at 3:57 AM Shakeel Butt wrote: > > On Tue, Sep 22, 2020 at 5:37 AM Chunxin Zang > wrote: > > > > On Tue, Sep 22, 2020 at 6:42 PM Chris Down wrote: > > > > > > Chunxin Zang writes: > > > >On Tue, Sep 22, 2020 at 5:51 PM Chris Down wrote: > > > >> > > > >> Chunxin Zang write

Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Chunxin Zang
On Tue, Sep 22, 2020 at 8:43 PM Chris Down wrote: > > Chunxin Zang writes: > >Please forgive me for not being able to understand why setting > >memory.low for Type_A can solve the problem. > >In my scene, Type_A is the most important, so I will set 100G to memory.low. > >But 'memory.low' only take

Re: [PATCH iproute2-next] ip: promote missed packets to the -s row

2020-09-22 Thread David Ahern
On 9/16/20 1:42 PM, Jakub Kicinski wrote: > missed_packet_errors are much more commonly reported: > > linux$ git grep -c '[.>]rx_missed_errors ' -- drivers/ | wc -l > 64 > linux$ git grep -c '[.>]rx_over_errors ' -- drivers/ | wc -l > 37 > > Plus those drivers are generally more modern than those

Re: [PATCH iproute2-next RESEND 0/3] devlink show controller and external info

2020-09-22 Thread David Ahern
On 9/18/20 4:16 AM, Parav Pandit wrote: > For certain devlink port flavours controller number and optionally external > attributes are reported by the kernel. > > (a) controller number indicates that a given port belong to which local or > external controller. > (b) external port attribute indic

RE: [Intel-wired-lan] [RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e

2020-09-22 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Jesse Brandeburg > Sent: Thursday, September 10, 2020 6:23 PM > To: netdev@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [RFC PATCH net-next v1 02/11] i40e: clean up W=1 > warnings in i40e > > Inspired by Lee Jones, this

Re: [RFC PATCH v2 0/3] l3mdev icmp error route lookup fixes

2020-09-22 Thread David Ahern
On 9/22/20 7:52 AM, Michael Jeanson wrote: >>> >>> the test setup is bad. You have r1 dropping the MTU in VRF red, but not >>> telling VRF red how to send back the ICMP. e.g., for IPv4 add: >>> >>>ip -netns r1 ro add vrf red 172.16.1.0/24 dev blue >>> >>> do the same for v6. >>> >>> Also, I do

[PATCH v3] net: ice: Fix pointer cast warnings

2020-09-22 Thread Bixuan Cui
pointers should be casted to unsigned long to avoid -Wpointer-to-int-cast warnings: drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from pointer to integer of different size drivers/net/ethernet/intel/ice/ice_flow.h:198:32: warning: cast to pointer from integer of different

Re: [PATCH -next v2] net: ice: Fix pointer cast warnings

2020-09-22 Thread Bixuan Cui
ping~ On 2020/7/31 18:07, Bixuan Cui wrote: > pointers should be casted to unsigned long to avoid > -Wpointer-to-int-cast warnings: > > drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: > cast from pointer to integer of different size > drivers/net/ethernet/intel/ice/ice_flow.h:198:3

[PATCH bpf-next 2/3] libbpf: introduce bpf_prog_test_run_xattr_opts

2020-09-22 Thread Song Liu
This API supports new field cpu_plus in bpf_attr.test. Signed-off-by: Song Liu --- tools/lib/bpf/bpf.c | 13 - tools/lib/bpf/bpf.h | 11 +++ tools/lib/bpf/libbpf.map | 1 + 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/bpf.c b/tools/l

[PATCH bpf-next 1/3] bpf: enable BPF_PROG_TEST_RUN for raw_tracepoint

2020-09-22 Thread Song Liu
Add .test_run for raw_tracepoint. Also, introduce a new feature that runs the target program on a specific CPU. This is achieved by a new flag in bpf_attr.test, cpu_plus. For compatibility, cpu_plus == 0 means run the program on current cpu, cpu_plus > 0 means run the program on cpu with id (cpu_pl

[PATCH bpf-next 0/3] enable BPF_PROG_TEST_RUN for raw_tp

2020-09-22 Thread Song Liu
This set enables BPF_PROG_TEST_RUN for raw_tracepoint type programs. This set also enables running the raw_tp program on a specific CPU. This feature can be used by user space to trigger programs that access percpu resources, e.g. perf_event, percpu variables. Song Liu (3): bpf: enable BPF_PROG_

[PATCH bpf-next 3/3] selftests/bpf: add raw_tp_test_run

2020-09-22 Thread Song Liu
This test runs test_run for raw_tracepoint program. The test covers ctx input, retval output, and proper handling of cpu_plus field. Signed-off-by: Song Liu --- .../bpf/prog_tests/raw_tp_test_run.c | 68 +++ .../bpf/progs/test_raw_tp_test_run.c | 26 +++ 2 f

Re: [pull request][net-next V3 00/12] mlx5 Multi packet tx descriptors for SKBs

2020-09-22 Thread David Miller
From: sa...@kernel.org Date: Mon, 21 Sep 2020 19:46:52 -0700 > From: Saeed Mahameed > > Hi Dave & Jakub > > This series adds support for Multi packet tx descriptors for SKBs. > For more information please see tag log below. > > v1->v2: > - Move small irrelevant changes from the refactoring pa

Re: [PATCH net-next 0/3] octeontx2-af: add support for KPU profile customization

2020-09-22 Thread David Miller
Please create a proper abstraction for uploading configuration information from a file into a device. Otherwise every driver will have their own custom weird stuff, unique module parameter names (module parameters are absolutely rejected for networking drivers for this reason), etc. Therefore t

Re: [PATCH net-next 0/2] devlink: Use nla_policy to validate range

2020-09-22 Thread David Miller
From: Parav Pandit Date: Mon, 21 Sep 2020 19:41:28 +0300 > This two small patches uses nla_policy to validate user specified > fields are in valid range or not. > > Patch summary: > Patch-1 checks the range of eswitch mode field > Patch-2 checks for the port type field. It eliminates a check in

Re: [PATCH net-next 2/2] net: dsa: sja1105: expose static config as devlink region

2020-09-22 Thread David Miller
From: Vladimir Oltean Date: Mon, 21 Sep 2020 19:27:41 +0300 > @@ -110,10 +222,15 @@ int sja1105_devlink_setup(struct dsa_switch *ds) > if (rc) > return rc; > > + rc = sja1105_setup_devlink_regions(ds); > + if (rc < 0) > + return rc; > + > return 0;

Re: [PATCH iproute2] ip: do not exit if RTM_GETNSID failed

2020-09-22 Thread David Ahern
On 9/22/20 5:57 PM, Stephen Hemminger wrote: > On Tue, 22 Sep 2020 17:16:46 -0600 > David Ahern wrote: > >> On 9/22/20 12:28 AM, Jan Engelhardt wrote: >>> >>> On Tuesday 2020-09-22 02:22, Stephen Hemminger wrote: Jan Engelhardt wrote: > `ip addr` when run under qemu-user-riscv6

Re: [PATCH net-next 0/3] dpaa2-mac: add PCS support through the Lynx module

2020-09-22 Thread David Miller
From: Ioana Ciornei Date: Mon, 21 Sep 2020 19:20:28 +0300 > This patch set aims to add PCS support in the dpaa2-eth driver by > leveraging the Lynx PCS module. > > The first two patches are some missing pieces: the first one adding > support for 10GBASER in Lynx PCS while the second one adds a n

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Stephen Hemminger
On Tue, 22 Sep 2020 16:47:07 -0700 Jay Vosburgh wrote: > Stephen Hemminger wrote: > > >On Tue, 22 Sep 2020 09:37:30 -0400 > >Jarod Wilson wrote: > > > >> By default, enable retaining all user-facing API that includes the use of > >> master and slave, but add a Kconfig knob that allows those

Re: [PATCH iproute2] ip: do not exit if RTM_GETNSID failed

2020-09-22 Thread Stephen Hemminger
On Tue, 22 Sep 2020 17:16:46 -0600 David Ahern wrote: > On 9/22/20 12:28 AM, Jan Engelhardt wrote: > > > > On Tuesday 2020-09-22 02:22, Stephen Hemminger wrote: > >> Jan Engelhardt wrote: > >> > >>> `ip addr` when run under qemu-user-riscv64, fails. This likely is > >>> due to qemu-5.1 not

Re: [PATCH net-next] net: microchip: Make `lan743x_pm_suspend` function return right value

2020-09-22 Thread David Miller
From: Zheng Yongjun Date: Mon, 21 Sep 2020 20:08:18 +0800 > @@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev) > /* Host sets PME_En, put D3hot */ > ret = pci_prepare_to_sleep(pdev); > > - return 0; > + return ret; > } Instead please do: retur

Re: [PATCH net-next 2/5] bonding: rename slave to link where possible

2020-09-22 Thread David Miller
From: Michal Kubecek Date: Wed, 23 Sep 2020 01:23:17 +0200 > Even if the module parameters are deprecated and extremely inconvenient > as a mean of bonding configuration, I would say changing their names > would still count as "breaking the userspace". I totally agree. Anything user facing has

Re: [PATCH] kbuild: explicitly specify the build id style

2020-09-22 Thread David Miller
From: Bill Wendling Date: Tue, 22 Sep 2020 16:21:40 -0700 > ld's --build-id defaults to "sha1" style, while lld defaults to "fast". > The build IDs are very different between the two, which may confuse > programs that reference them. > > Signed-off-by: Bill Wendling Acked-by: David S. Miller

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Jay Vosburgh
Stephen Hemminger wrote: >On Tue, 22 Sep 2020 09:37:30 -0400 >Jarod Wilson wrote: > >> By default, enable retaining all user-facing API that includes the use of >> master and slave, but add a Kconfig knob that allows those that wish to >> remove it entirely do so in one shot. >> >> Cc: Jay Vosb

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Stephen Hemminger
On Tue, 22 Sep 2020 09:37:30 -0400 Jarod Wilson wrote: > By default, enable retaining all user-facing API that includes the use of > master and slave, but add a Kconfig knob that allows those that wish to > remove it entirely do so in one shot. > > Cc: Jay Vosburgh > Cc: Veaceslav Falico > Cc:

Re: [PATCH net-next 2/5] bonding: rename slave to link where possible

2020-09-22 Thread Michal Kubecek
On Tue, Sep 22, 2020 at 09:37:28AM -0400, Jarod Wilson wrote: > Getting rid of as much usage of "slave" as we can here, without breaking > any user-facing API. > > Cc: Jay Vosburgh > Cc: Veaceslav Falico > Cc: Andy Gospodarek > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Thomas Davis >

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2020-09-22 Thread Anchal Agarwal
On Tue, Sep 22, 2020 at 12:18:05PM -0400, boris.ostrov...@oracle.com wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 9/21/20 5:54 PM, Anchal Agarwal w

Re: [PATCH iproute2] ip: do not exit if RTM_GETNSID failed

2020-09-22 Thread David Ahern
On 9/22/20 12:28 AM, Jan Engelhardt wrote: > > On Tuesday 2020-09-22 02:22, Stephen Hemminger wrote: >> Jan Engelhardt wrote: >> >>> `ip addr` when run under qemu-user-riscv64, fails. This likely is >>> due to qemu-5.1 not doing translation of RTM_GETNSID calls. >>> >>> 2: host0@if5: mtu 1500 qd

Re: [net-next 1/3] ch_ktls: Issue if connection offload fails

2020-09-22 Thread Jakub Kicinski
On Tue, 22 Sep 2020 23:14:59 +0530 Rohit Maheshwari wrote: > Since driver first return success to tls_dev_add, if req to HW is > successful, but later if HW returns failure, that connection traffic > fails permanently and connection status remains unknown to stack. > > Fixes: 34aba2c45024 ("cxgb4/

[PATCH net-next v2 0/2] PHY subsystem kernel doc

2020-09-22 Thread Andrew Lunn
The first patches fix existing warnings in the kerneldoc for the PHY subsystem, and then the 2nd extend the kernel documentation for the major structures and functions in the PHY subsystem. v2: Drop the other fixes which have already been merged. s/phy/PHY/g TBI TypOs Andrew Lunn (2): net: phy:

[PATCH net-next v2 2/2] net: phy: Document core PHY structures

2020-09-22 Thread Andrew Lunn
Add kerneldoc for the core PHY data structures, a few inline functions and exported functions which are not already documented. v2 Typos g/phy/PHY/s Signed-off-by: Andrew Lunn --- Documentation/networking/kapi.rst | 9 + drivers/net/phy/phy-core.c| 32 ++- drivers/net/phy/phy.c

[PATCH net-next v2 1/2] net: phy: Fixup kernel doc

2020-09-22 Thread Andrew Lunn
Add missing parameter documentation, or fixup wrong parameter names. Reviewed-by: Florian Fainelli Signed-off-by: Andrew Lunn --- include/linux/mdio.h | 3 ++- include/linux/phy.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/mdio.h b/include/linux/mdio.

Re: [PATCH net] drivers/net/wan/x25_asy: Correct the ndo_open and ndo_stop functions

2020-09-22 Thread Xie He
Sorry. I wish to drop the 3rd part (the 3rd point in the commit message) and re-send this patch. I'll re-address the problem discussed in the 3rd point in future patches.

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-22 Thread Nitesh Narayan Lal
On 9/22/20 5:26 PM, Andrew Lunn wrote: >> Subject: Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of >> hosekeeping CPUs > Hosekeeping? Are these CPUs out gardening in the weeds? Bjorn has already highlighted the typo, so I will be fixing it in the next version. Do you find the commit m

Re: [PATCH net-next 0/5] bonding: rename bond components

2020-09-22 Thread Jay Vosburgh
Jarod Wilson wrote: >The bonding driver's use of master and slave, while largely understood >in technical circles, poses a barrier for inclusion to some potential >members of the development and user community, due to the historical >context of masters and slaves, particularly in the United State

Re: [GIT] Networking

2020-09-22 Thread Jakub Kicinski
On Tue, 22 Sep 2020 15:02:24 -0700 Linus Torvalds wrote: > Pulled. Thanks! > (a) please put "git pull" somewhere in the email (lots of people just > put it in the subject by prepending it with "[GIT PULL]" but all I > really look for is "git" and "pull" anywhere in the email. You had the > "git"

Re: [GIT] Networking

2020-09-22 Thread pr-tracker-bot
The pull request you sent on Mon, 21 Sep 2020 18:44:43 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d3017135c43373b06eef1eb70dfeb948b8ae159f Thank you! -- Deet-doot-dot, I am a

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Jarod Wilson
On Tue, Sep 22, 2020 at 9:38 AM Jarod Wilson wrote: > > By default, enable retaining all user-facing API that includes the use of > master and slave, but add a Kconfig knob that allows those that wish to > remove it entirely do so in one shot. > diff --git a/drivers/net/bonding/bond_procfs.c > b/

Re: [GIT] Networking

2020-09-22 Thread Linus Torvalds
On Mon, Sep 21, 2020 at 6:44 PM Jakub Kicinski wrote: > > Here are the latest updates from the networking tree: Pulled. But I'd ask for a couple of things for future pull requests: (a) please put "git pull" somewhere in the email (lots of people just put it in the subject by prepending it with

Re: [PATCH v4 1/4] Bluetooth: Interleave with allowlist scan

2020-09-22 Thread Luiz Augusto von Dentz
Hi Howard, On Sun, Sep 20, 2020 at 9:23 PM Howard Chung wrote: > > This patch implements the interleaving between allowlist scan and > no-filter scan. It'll be used to save power when at least one monitor is > registered and at least one pending connection or one device to be > scanned for. > > T

[PATCH v2] net: lantiq: Add locking for TX DMA channel

2020-09-22 Thread Hauke Mehrtens
The TX DMA channel data is accessed by the xrx200_start_xmit() and the xrx200_tx_housekeeping() function from different threads. Make sure the accesses are synchronized by acquiring the netif_tx_lock() in the xrx200_tx_housekeeping() function too. This lock is acquired by the kernel before calling

Re: [PATCH] net: lantiq: Add locking for TX DMA channel

2020-09-22 Thread Hauke Mehrtens
On 9/22/20 2:18 AM, David Miller wrote: > From: Hauke Mehrtens > Date: Tue, 22 Sep 2020 00:31:13 +0200 > >> The TX DMA channel data is accessed by the xrx200_start_xmit() and the >> xrx200_tx_housekeeping() function from different threads. Make sure the >> accesses are synchronized by using locki

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-22 Thread Andrew Lunn
> Subject: Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of > hosekeeping CPUs Hosekeeping? Are these CPUs out gardening in the weeds? Andrew

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-22 Thread Nitesh Narayan Lal
On 9/22/20 4:58 PM, Frederic Weisbecker wrote: > On Tue, Sep 22, 2020 at 09:50:55AM -0400, Nitesh Narayan Lal wrote: >> On 9/22/20 6:08 AM, Frederic Weisbecker wrote: >> TBH I don't have a very strong case here at the moment. >> But still, IMHO, this will force the user to have both managed irqs a

Re: [RFC][Patch v1 3/3] PCI: Limit pci_alloc_irq_vectors as per housekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Tue, Sep 22, 2020 at 09:54:58AM -0400, Nitesh Narayan Lal wrote: > >> If min_vecs > num_housekeeping, for example: > >> > >> /* PCI MSI/MSIx support */ > >> #define XGBE_MSI_BASE_COUNT 4 > >> #define XGBE_MSI_MIN_COUNT (XGBE_MSI_BASE_COUNT + 1) > >> > >> Then the protection fails. > > R

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-22 Thread Nitesh Narayan Lal
On 9/22/20 4:44 PM, Frederic Weisbecker wrote: > On Tue, Sep 22, 2020 at 09:34:02AM -0400, Nitesh Narayan Lal wrote: >> On 9/22/20 5:54 AM, Frederic Weisbecker wrote: >>> But I don't also want to push toward a complicated solution to handle CPU >>> hotplug >>> if there is no actual problem to sol

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Tue, Sep 22, 2020 at 09:50:55AM -0400, Nitesh Narayan Lal wrote: > On 9/22/20 6:08 AM, Frederic Weisbecker wrote: > TBH I don't have a very strong case here at the moment. > But still, IMHO, this will force the user to have both managed irqs and > nohz_full in their environments to avoid these k

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Tue, Sep 22, 2020 at 09:34:02AM -0400, Nitesh Narayan Lal wrote: > On 9/22/20 5:54 AM, Frederic Weisbecker wrote: > > But I don't also want to push toward a complicated solution to handle CPU > > hotplug > > if there is no actual problem to solve there. > > Sure, even I am not particularly sur

Re: [PATCH bpf-next 1/2] bpf: Use --no-fail option if CONFIG_BPF is not enabled

2020-09-22 Thread Andrii Nakryiko
On Tue, Sep 22, 2020 at 11:48 AM Jiri Olsa wrote: > > On Mon, Sep 21, 2020 at 02:55:27PM -0700, Andrii Nakryiko wrote: > > On Fri, Sep 18, 2020 at 5:30 AM Jiri Olsa wrote: > > > > > > Currently all the resolve_btfids 'users' are under CONFIG_BPF > > > code, so if we have CONFIG_BPF disabled, reso

Re: [PATCH v3 bpf-next 11/11] bpf: selftest: Use bpf_skc_to_tcp_sock() in the sock_fields test

2020-09-22 Thread Alexei Starovoitov
On Tue, Sep 22, 2020 at 12:05:18AM -0700, Martin KaFai Lau wrote: > > @@ -165,9 +168,13 @@ int egress_read_sock_fields(struct __sk_buff *skb) > tpcpy(tp_ret, tp); > > if (sk_ret == &srv_sk) { > + ktp = bpf_skc_to_tcp_sock(sk); > + if (!ktp) > +

Re: [PATCH bpf-next v4 11/11] bpf: use a table to drive helper arg type checks

2020-09-22 Thread Alexei Starovoitov
On Tue, Sep 22, 2020 at 09:20:27AM +0100, Lorenz Bauer wrote: > On Mon, 21 Sep 2020 at 23:23, Alexei Starovoitov > wrote: > > > > On Mon, Sep 21, 2020 at 01:12:27PM +0100, Lorenz Bauer wrote: > > > +struct bpf_reg_types { > > > + const enum bpf_reg_type types[10]; > > > +}; > > > > any idea on

Re: [PATCH] net/mlx5: remove unreachable return

2020-09-22 Thread Pavel Machek
On Tue 2020-09-22 12:54:20, Saeed Mahameed wrote: > On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote: > > On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > > > The last return statement is unreachable code. I'm not sure if it > > > will > > > provoke any warnings, but it looks ugly. >

[PATCH net-next 0/2] net: dsa: bcm_sf2: Additional DT changes

2020-09-22 Thread Florian Fainelli
Hi David, This patch series includes some additional changes to the bcm_sf2 in order to support the Device Tree firmwares provided on such platforms. Florian Fainelli (2): net: dsa: bcm_sf2: Disallow port 5 to be a DSA CPU port net: dsa: bcm_sf2: Include address 0 for MDIO diversion drivers

  1   2   3   >