RE: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-17 Thread 劉偉權
Hi Serge, Thanks for your reply. There is a confidential issue that realtek doesn't offer the detail of a full register layout for configuration register. The default setting for this configuration register should be 0x8148. Basically, no need to change it. If you need to enable RGMII RX Delay

[PATCH] net: hns: kerneldoc fixes

2020-09-17 Thread Lu Wei
Fix some parameter description mistakes. Signed-off-by: Lu Wei --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c i

Re: [PATCH] batman-adv: Fix orig node refcnt leak when creating neigh node

2020-09-17 Thread Sven Eckelmann
On Friday, 18 September 2020 05:03:19 CEST Xiyu Yang wrote: > batadv_neigh_node_create() is used to create a neigh node object, whose > fields will be initialized with the specific object. When a new > reference of the specific object is created during the initialization, > its refcount should be i

[PATCH v2] ptp: mark symbols static where possible

2020-09-17 Thread Herrington
We get 1 warning when building kernel with W=1: drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] u32 pch_ch_control_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmis

[PATCH] [PATCH v2]ptp: mark symbols static where possible

2020-09-17 Thread Herrington
We get 1 warning when building kernel with W=1: drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] u32 pch_ch_control_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmis

Re: [PATCH next] net: fix build without CONFIG_SYSCTL definition

2020-09-17 Thread Randy Dunlap
On 9/17/20 10:08 PM, Mahesh Bandewar wrote: > Earlier commit 316cdaa1158a ("net: add option to not create fall-back > tunnels in root-ns as well") removed the CONFIG_SYSCTL to enable the > kernel-commandline to work. However, this variable gets defined only > when CONFIG_SYSCTL option is selected.

RE: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Parav Pandit
> From: Samudrala, Sridhar > Sent: Friday, September 18, 2020 10:23 AM > > > On 9/17/2020 9:41 PM, Parav Pandit wrote: > > Hi David, > > > >> From: David Ahern > >> Sent: Friday, September 18, 2020 9:08 AM > >> > >> On 9/17/20 9:29 PM, Parav Pandit wrote: > > Examples: > > > > Cre

Re: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Samudrala, Sridhar
On 9/17/2020 9:41 PM, Parav Pandit wrote: Hi David, From: David Ahern Sent: Friday, September 18, 2020 9:08 AM On 9/17/20 9:29 PM, Parav Pandit wrote: Examples: Create a PCI PF and PCI SF port. $ devlink port add netdevsim/netdevsim10/10 flavour pcipf pfnum 0 $ devlink port add netdevsim

RE: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Parav Pandit
Hi David, > From: David Ahern > Sent: Friday, September 18, 2020 9:08 AM > > On 9/17/20 9:29 PM, Parav Pandit wrote: > >>> Examples: > >>> > >>> Create a PCI PF and PCI SF port. > >>> $ devlink port add netdevsim/netdevsim10/10 flavour pcipf pfnum 0 $ > >>> devlink port add netdevsim/netdevsim10

[PATCH 5/7 net-next] net: tipc: delete duplicated words

2020-09-17 Thread Randy Dunlap
deletions(-) --- linux-next-20200917.orig/net/tipc/msg.c +++ linux-next-20200917/net/tipc/msg.c @@ -582,7 +582,7 @@ bundle: * @pos: position in outer message of msg to be extracted. *Returns position of next msg * Consumes outer buffer when last packet extracted - * Returns true when when t

[PATCH 0/7 net-next] net: various: delete duplicated words

2020-09-17 Thread Randy Dunlap
[PATCH 1/7 net-next] net: core: delete duplicated words [PATCH 2/7 net-next] net: rds: delete duplicated words [PATCH 3/7 net-next] net: ipv6: delete duplicated words [PATCH 4/7 net-next] net: bluetooth: delete duplicated words [PATCH 5/7 net-next] net: tipc: delete duplicated words [PATCH 6/7 ne

[PATCH 3/7 net-next] net: ipv6: delete duplicated words

2020-09-17 Thread Randy Dunlap
Drop repeated words in net/ipv6/. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski --- net/ipv6/ip6_output.c |2 +- net/ipv6/tcp_ipv6.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200917.orig/net/ipv6/ip6_output.c +++

[PATCH 2/7 net-next] net: rds: delete duplicated words

2020-09-17 Thread Randy Dunlap
deletions(-) --- linux-next-20200917.orig/net/rds/cong.c +++ linux-next-20200917/net/rds/cong.c @@ -236,7 +236,7 @@ void rds_cong_queue_updates(struct rds_c *tcp_setsockopt and/or tcp_sendmsg will deadlock *when it tries to get the

[PATCH 4/7 net-next] net: bluetooth: delete duplicated words

2020-09-17 Thread Randy Dunlap
linux-next-20200917.orig/net/bluetooth/hci_conn.c +++ linux-next-20200917/net/bluetooth/hci_conn.c @@ -1388,7 +1388,7 @@ static int hci_conn_auth(struct hci_conn return 0; } -/* Encrypt the the link */ +/* Encrypt the link */ static void hci_conn_encrypt(struct hci_conn *conn) {

[PATCH 7/7 net-next] net: bridge: delete duplicated words

2020-09-17 Thread Randy Dunlap
ions(+), 2 deletions(-) --- linux-next-20200917.orig/net/bridge/br_ioctl.c +++ linux-next-20200917/net/bridge/br_ioctl.c @@ -103,7 +103,7 @@ static int add_del_if(struct net_bridge /* * Legacy ioctl's through SIOCDEVPRIVATE - * This interface is deprecated because it was too diffic

[PATCH 1/7 net-next] net: core: delete duplicated words

2020-09-17 Thread Randy Dunlap
Drop repeated words in net/core/. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski --- net/core/dev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200917.orig/net/core/dev.c +++ linux-next-20200917/net/core/dev.c @@ -1131

[PATCH 6/7 net-next] net: atm: delete duplicated words

2020-09-17 Thread Randy Dunlap
insertions(+), 2 deletions(-) --- linux-next-20200917.orig/net/atm/lec.c +++ linux-next-20200917/net/atm/lec.c @@ -1070,7 +1070,7 @@ module_exit(lane_module_cleanup); /* * LANE2: 3.1.3, LE_RESOLVE.request * Non force allocates memory and fills in *tlvs, fills in *sizeoftlvs. - * If sizeoftlvs == NULL

RE: [PATCH net-next v2 2/8] devlink: Support add and delete devlink port

2020-09-17 Thread Parav Pandit
> From: Jacob Keller > Sent: Friday, September 18, 2020 12:13 AM > > > On 9/17/2020 10:20 AM, Parav Pandit wrote: > > Extended devlink interface for the user to add and delete port. > > Extend devlink to connect user requests to driver to add/delete such > > port in the device. > > > > When driv

RE: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread Parav Pandit
> From: David Ahern > Sent: Friday, September 18, 2020 1:32 AM > > On 9/17/20 11:20 AM, Parav Pandit wrote: > > diff --git a/include/net/devlink.h b/include/net/devlink.h index > > 48b1c1ef1ebd..1edb558125b0 100644 > > --- a/include/net/devlink.h > > +++ b/include/net/devlink.h > > @@ -83,6 +83,

[PATCH net] hinic: fix sending pkts from core while self testing

2020-09-17 Thread Luo bin
Call netif_tx_disable firstly before starting doing self-test to avoid sending packet from networking core and self-test packet simultaneously which may cause self-test failure or hw abnormal. Fixes: 4aa218a4fe77 ("hinic: add self test support") Signed-off-by: Luo bin --- drivers/net/ethernet/hu

Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication

2020-09-17 Thread Jason Wang
On 2020/9/16 下午7:47, Kishon Vijay Abraham I wrote: Hi Jason, On 16/09/20 8:40 am, Jason Wang wrote: On 2020/9/15 下午11:47, Kishon Vijay Abraham I wrote: Hi Jason, On 15/09/20 1:48 pm, Jason Wang wrote: Hi Kishon: On 2020/9/14 下午3:23, Kishon Vijay Abraham I wrote: Then you need something t

RE: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread Parav Pandit
> From: Jacob Keller > Sent: Friday, September 18, 2020 12:00 AM > > > On 9/17/2020 10:20 AM, Parav Pandit wrote: > > A PCI sub-function (SF) represents a portion of the device similar to > > PCI VF. > > > > In an eswitch, PCI SF may have port which is normally represented > > using a represen

Re: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread David Ahern
On 9/17/20 9:29 PM, Parav Pandit wrote: >>> Examples: >>> >>> Create a PCI PF and PCI SF port. >>> $ devlink port add netdevsim/netdevsim10/10 flavour pcipf pfnum 0 $ >>> devlink port add netdevsim/netdevsim10/11 flavour pcisf pfnum 0 sfnum >>> 44 $ devlink port show netdevsim/netdevsim10/11 >>> ne

RE: [PATCH net-next v2 3/8] devlink: Prepare code to fill multiple port function attributes

2020-09-17 Thread Parav Pandit
Hi Jacob, > From: Jacob Keller > Sent: Friday, September 18, 2020 12:29 AM > > > On 9/17/2020 10:20 AM, Parav Pandit wrote: > > Prepare code to fill zero or more port function optional attributes. > > Subsequent patch makes use of this to fill more port function > > attributes. > > > > Signed-o

RE: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Parav Pandit
> From: David Ahern > Sent: Friday, September 18, 2020 2:01 AM > > On 9/17/20 11:20 AM, Parav Pandit wrote: > > Simulate PCI SF ports. Allow user to create one or more PCI SF ports. > > > > Examples: > > > > Create a PCI PF and PCI SF port. > > $ devlink port add netdevsim/netdevsim10/10 flavour

RE: [PATCH net-next v2 4/8] devlink: Support get and set state of port function

2020-09-17 Thread Parav Pandit
> From: David Ahern > Sent: Friday, September 18, 2020 1:54 AM > > On 9/17/20 11:20 AM, Parav Pandit wrote: > > diff --git a/net/core/devlink.c b/net/core/devlink.c index > > d152489e48da..c82098cb75da 100644 > > --- a/net/core/devlink.c > > +++ b/net/core/devlink.c > > @@ -595,6 +598,40 @@ dev

Re: [PATCH v8 bpf-next 0/7] bpf: tailcalls in BPF subprograms

2020-09-17 Thread Alexei Starovoitov
On Wed, Sep 16, 2020 at 2:16 PM Maciej Fijalkowski wrote: > > Changelog: > > v7->v8: > - teach bpf_patch_insn_data to adjust insn_idx of tailcall insn > - address case of clearing tail call counter when bpf2bpf with tailcalls > are mixed > - drop unnecessary checks against cbpf in JIT > - introd

[PATCH AUTOSEL 5.4 012/330] ath10k: fix memory leak for tpc_stats_final

2020-09-17 Thread Sasha Levin
From: Miaoqing Pan [ Upstream commit 486a8849843455298d49e694cca9968336ce2327 ] The memory of ar->debug.tpc_stats_final is reallocated every debugfs reading, it should be freed in ath10k_debug_destroy() for the last allocation. Tested HW: QCA9984 Tested FW: 10.4-3.9.0.2-00035 Signed-off-by: Mi

[PATCH AUTOSEL 5.4 011/330] ath10k: fix array out-of-bounds access

2020-09-17 Thread Sasha Levin
From: Miaoqing Pan [ Upstream commit c5329b2d5b8b4e41be14d31ee8505b4f5607bf9b ] If firmware reports rate_max > WMI_TPC_RATE_MAX(WMI_TPC_FINAL_RATE_MAX) or num_tx_chain > WMI_TPC_TX_N_CHAIN, it will cause array out-of-bounds access, so print a warning and reset to avoid memory corruption. Tested

[PATCH AUTOSEL 5.4 031/330] net: silence data-races on sk_backlog.tail

2020-09-17 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 9ed498c6280a2f2b51d02df96df53037272ede49 ] sk->sk_backlog.tail might be read without holding the socket spinlock, we need to add proper READ_ONCE()/WRITE_ONCE() to silence the warnings. KCSAN reported : BUG: KCSAN: data-race in tcp_add_backlog / tcp_recvmsg

[PATCH AUTOSEL 5.4 037/330] ice: Fix to change Rx/Tx ring descriptor size via ethtool with DCBx

2020-09-17 Thread Sasha Levin
From: Usha Ketineni [ Upstream commit c0a3665f71a2f086800abea4d9d14d28269089d6 ] This patch fixes the call trace caused by the kernel when the Rx/Tx descriptor size change request is initiated via ethtool when DCB is configured. ice_set_ringparam() should use vsi->num_txq instead of vsi->alloc_t

[PATCH AUTOSEL 5.4 058/330] mt76: do not use devm API for led classdev

2020-09-17 Thread Sasha Levin
From: Felix Fietkau [ Upstream commit 36f7e2b2bb1de86f0072cd49ca93d82b9e8fd894 ] With the devm API, the unregister happens after the device cleanup is done, after which the struct mt76_dev which contains the led_cdev has already been freed. This leads to a use-after-free bug that can crash the s

[PATCH AUTOSEL 5.4 080/330] neigh_stat_seq_next() should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit 1e3f9f073c47bee7c23e77316b07bc12338c5bba ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH AUTOSEL 5.4 079/330] vcc_seq_next should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit 8bf7092021f283944f0c5f4c364853201c45c611 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH AUTOSEL 5.4 059/330] mt76: add missing locking around ampdu action

2020-09-17 Thread Sasha Levin
From: Felix Fietkau [ Upstream commit 1a817fa73c3b27a593aadf0029de24db1bbc1a3e ] This is needed primarily to avoid races in dealing with rx aggregation related data structures Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/mt7603/main.c | 2 ++

[PATCH] batman-adv: Fix orig node refcnt leak when creating neigh node

2020-09-17 Thread Xiyu Yang
batadv_neigh_node_create() is used to create a neigh node object, whose fields will be initialized with the specific object. When a new reference of the specific object is created during the initialization, its refcount should be increased. However, when "neigh_node" object initializes its orig_no

[PATCH AUTOSEL 5.4 061/330] SUNRPC: Capture completion of all RPC tasks

2020-09-17 Thread Sasha Levin
From: Chuck Lever [ Upstream commit a264abad51d8ecb7954a2f6d9f1885b38daffc74 ] RPC tasks on the backchannel never invoke xprt_complete_rqst(), so there is no way to report their tk_status at completion. Also, any RPC task that exits via rpc_exit_task() before it is replied to will also disappear

[PATCH AUTOSEL 5.4 082/330] ipv6_route_seq_next should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit 4fc427e0515811250647d44de38d87d7b0e0790f ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH AUTOSEL 5.4 081/330] rt_cpu_seq_next should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit a3ea86739f1bc7e121d921842f0f4a8ab1af94d9 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH AUTOSEL 5.4 078/330] tipc: fix link overflow issue at socket shutdown

2020-09-17 Thread Sasha Levin
From: Tuong Lien [ Upstream commit 49afb806cb650dd1f06f191994f3aa657d264009 ] When a socket is suddenly shutdown or released, it will reject all the unreceived messages in its receive queue. This applies to a connected socket too, whereas there is only one 'FIN' message required to be sent back

[PATCH AUTOSEL 5.4 090/330] sctp: move trace_sctp_probe_path into sctp_outq_sack

2020-09-17 Thread Sasha Levin
From: Kevin Kou [ Upstream commit f643ee295c1c63bc117fb052d4da681354d6f732 ] The original patch bringed in the "SCTP ACK tracking trace event" feature was committed at Dec.20, 2017, it replaced jprobe usage with trace events, and bringed in two trace events, one is TRACE_EVENT(sctp_probe), anoth

[PATCH AUTOSEL 5.4 107/330] ar5523: Add USB ID of SMCWUSBT-G2 wireless adapter

2020-09-17 Thread Sasha Levin
From: Mert Dirik [ Upstream commit 5b362498a79631f283578b64bf6f4d15ed4cc19a ] Add the required USB ID for running SMCWUSBT-G2 wireless adapter (SMC "EZ Connect g"). This device uses ar5523 chipset and requires firmware to be loaded. Even though pid of the device is 4507, this patch adds it as 4

[PATCH AUTOSEL 5.4 114/330] Bluetooth: prefetch channel before killing sock

2020-09-17 Thread Sasha Levin
From: Hillf Danton [ Upstream commit 2a154903cec20fb64ff4d7d617ca53c16f8fd53a ] Prefetch channel before killing sock in order to fix UAF like BUG: KASAN: use-after-free in l2cap_sock_release+0x24c/0x290 net/bluetooth/l2cap_sock.c:1212 Read of size 8 at addr 8880944904a0 by task syz-fuzze

[PATCH AUTOSEL 5.4 117/330] skbuff: fix a data race in skb_queue_len()

2020-09-17 Thread Sasha Levin
From: Qian Cai [ Upstream commit 86b18aaa2b5b5bb48e609cd591b3d2d0fdbe0442 ] sk_buff.qlen can be accessed concurrently as noticed by KCSAN, BUG: KCSAN: data-race in __skb_try_recv_from_queue / unix_dgram_sendmsg read to 0x8a1b1d8a81c0 of 4 bytes by task 5371 on cpu 96: unix_dgram_sendms

[PATCH AUTOSEL 5.4 130/330] mt76: fix handling full tx queues in mt76_dma_tx_queue_skb_raw

2020-09-17 Thread Sasha Levin
From: Felix Fietkau [ Upstream commit 93eaec7625f13cffb593b471405b017c7e64d4ee ] Fixes a theoretical issue where it could potentially overwrite an existing descriptor entry (and leaking its skb) Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/dm

[PATCH AUTOSEL 5.4 129/330] mt76: clear skb pointers from rx aggregation reorder buffer during cleanup

2020-09-17 Thread Sasha Levin
From: Felix Fietkau [ Upstream commit 9379df2fd9234e3b67a23101c2370c99f6af6d77 ] During the cleanup of the aggregation session, a rx handler (or release timer) on another CPU might still hold a pointer to the reorder buffer and could attempt to release some packets. Clearing pointers during clea

[PATCH AUTOSEL 5.4 139/330] bpf: Remove recursion prevention from rcu free callback

2020-09-17 Thread Sasha Levin
From: Thomas Gleixner [ Upstream commit 8a37963c7ac9ecb7f86f8ebda020e3f8d6d7b8a0 ] If an element is freed via RCU then recursion into BPF instrumentation functions is not a concern. The element is already detached from the map and the RCU callback does not hold any locks on which a kprobe, perf

[PATCH AUTOSEL 5.4 145/330] iavf: use tc_cls_can_offload_and_chain0() instead of chain check

2020-09-17 Thread Sasha Levin
From: Jiri Pirko [ Upstream commit bb0858d8bc828ebc3eaa90be02a0f32bca3c2351 ] Looks like the iavf code actually experienced a race condition, when a developer took code before the check for chain 0 was put to helper. So use tc_cls_can_offload_and_chain0() helper instead of direct check and move

[PATCH AUTOSEL 5.4 151/330] Bluetooth: guard against controllers sending zero'd events

2020-09-17 Thread Sasha Levin
From: Alain Michaud [ Upstream commit 08bb4da90150e2a225f35e0f642cdc463958d696 ] Some controllers have been observed to send zero'd events under some conditions. This change guards against this condition as well as adding a trace to facilitate diagnosability of this condition. Signed-off-by: A

[PATCH AUTOSEL 5.4 168/330] Bluetooth: L2CAP: handle l2cap config request during open state

2020-09-17 Thread Sasha Levin
From: Howard Chung [ Upstream commit 96298f640104e4cd9a913a6e50b0b981829b94ff ] According to Core Spec Version 5.2 | Vol 3, Part A 6.1.5, the incoming L2CAP_ConfigReq should be handled during OPEN state. The section below shows the btmon trace when running L2CAP/COS/CFD/BV-12-C before and after

[PATCH AUTOSEL 5.4 194/330] net: axienet: Convert DMA error handler to a work queue

2020-09-17 Thread Sasha Levin
From: Andre Przywara [ Upstream commit 24201a64770afe2e17050b2ab9e8c0e24e9c23b2 ] The DMA error handler routine is currently a tasklet, scheduled to run after the DMA error IRQ was handled. However it needs to take the MDIO mutex, which is not allowed to do in a tasklet. A kernel (with debug opt

[PATCH AUTOSEL 5.4 189/330] r8169: improve RTL8168b FIFO overflow workaround

2020-09-17 Thread Sasha Levin
From: Heiner Kallweit [ Upstream commit 6b02e407cbf8d421477ebb7792cd6380affcd313 ] So far only the reset bit it set, but the handler executing the reset is not scheduled. Therefore nothing will happen until some other action schedules the handler. Improve this by ensuring that the handler is sch

[PATCH AUTOSEL 5.4 195/330] net: axienet: Propagate failure of DMA descriptor setup

2020-09-17 Thread Sasha Levin
From: Andre Przywara [ Upstream commit ee44d0b78839b21591501424fd3cb3648cc803b5 ] When we fail allocating the DMA buffers in axienet_dma_bd_init(), we report this error, but carry on with initialisation nevertheless. This leads to a kernel panic when the driver later wants to send a packet, as

[PATCH AUTOSEL 5.4 214/330] svcrdma: Fix leak of transport addresses

2020-09-17 Thread Sasha Levin
From: Chuck Lever [ Upstream commit 1a33d8a284b1e85e03b8c7b1ea8fb985fccd1d71 ] Kernel memory leak detected: unreferenced object 0x49cdf480 (size 8): comm "kworker/u8:3", pid 2086, jiffies 4297898756 (age 4269.856s) hex dump (first 8 bytes): 30 00 cd 49 88 88 ff ff

[PATCH AUTOSEL 5.4 208/330] brcmfmac: Fix double freeing in the fmac usb data path

2020-09-17 Thread Sasha Levin
From: Raveendran Somu [ Upstream commit 78179869dc3f5c0059bbf5d931a2717f1ad97ecd ] When the brcmf_fws_process_skb() fails to get hanger slot for queuing the skb, it tries to free the skb. But the caller brcmf_netdev_start_xmit() of that funciton frees the packet on error return value. This cause

[PATCH AUTOSEL 5.4 215/330] netfilter: nf_tables: silence a RCU-list warning in nft_table_lookup()

2020-09-17 Thread Sasha Levin
From: Qian Cai [ Upstream commit 0a6a9515fe390976cd762c52d8d4f446d7a14285 ] It is safe to traverse &net->nft.tables with &net->nft.commit_mutex held using list_for_each_entry_rcu(). Silence the PROVE_RCU_LIST false positive, WARNING: suspicious RCU usage net/netfilter/nf_tables_api.c:523 RCU-li

[PATCH AUTOSEL 5.4 213/330] SUNRPC: Fix a potential buffer overflow in 'svc_print_xprts()'

2020-09-17 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit b25b60d7bfb02a74bc3c2d998e09aab159df8059 ] 'maxlen' is the total size of the destination buffer. There is only one caller and this value is 256. When we compute the size already used and what we would like to add in the buffer, the trailling NULL chara

[PATCH AUTOSEL 5.4 229/330] SUNRPC: Don't start a timer on an already queued rpc task

2020-09-17 Thread Sasha Levin
From: Trond Myklebust [ Upstream commit 1fab7dc477241c12f977955aa6baea7938b6f08d ] Move the test for whether a task is already queued to prevent corruption of the timer list in __rpc_sleep_on_priority_timeout(). Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- net/sunrpc/sched.c

[PATCH AUTOSEL 5.4 250/330] dpaa2-eth: fix error return code in setup_dpni()

2020-09-17 Thread Sasha Levin
From: Wei Yongjun [ Upstream commit 97fff7c8de1e54e5326dfeb66085796864bceb64 ] Fix to return negative error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- dr

[PATCH AUTOSEL 5.4 252/330] devlink: Fix reporter's recovery condition

2020-09-17 Thread Sasha Levin
From: Aya Levin [ Upstream commit bea0c5c942d3b4e9fb6ed45f6a7de74c6b112437 ] Devlink health core conditions the reporter's recovery with the expiration of the grace period. This is not relevant for the first recovery. Explicitly demand that the grace period will only apply to recoveries other th

[PATCH AUTOSEL 5.4 253/330] atm: fix a memory leak of vcc->user_back

2020-09-17 Thread Sasha Levin
From: Cong Wang [ Upstream commit 8d9f73c0ad2f20e9fed5380de0a3097825859d03 ] In lec_arp_clear_vccs() only entry->vcc is freed, but vcc could be installed on entry->recv_vcc too in lec_vcc_added(). This fixes the following memory leak: unreferenced object 0x8880d9266b90 (size 16): comm "a

[PATCH AUTOSEL 5.4 261/330] Bluetooth: Handle Inquiry Cancel error after Inquiry Complete

2020-09-17 Thread Sasha Levin
From: Sonny Sasaka [ Upstream commit adf1d6926444029396861413aba8a0f2a805742a ] After sending Inquiry Cancel command to the controller, it is possible that Inquiry Complete event comes before Inquiry Cancel command complete event. In this case the Inquiry Cancel command will have status of Comma

[PATCH AUTOSEL 5.4 271/330] svcrdma: Fix backchannel return code

2020-09-17 Thread Sasha Levin
From: Chuck Lever [ Upstream commit ea740bd5f58e2912e74f401fd01a9d6aa985ca05 ] Way back when I was writing the RPC/RDMA server-side backchannel code, I misread the TCP backchannel reply handler logic. When svc_tcp_recvfrom() successfully receives a backchannel reply, it does not return -EAGAIN.

[PATCH AUTOSEL 5.4 280/330] e1000: Do not perform reset in reset_task if we are already down

2020-09-17 Thread Sasha Levin
From: Alexander Duyck [ Upstream commit 49ee3c2ab5234757bfb56a0b3a3cb422f427e3a3 ] We are seeing a deadlock in e1000 down when NAPI is being disabled. Looking over the kernel function trace of the system it appears that the interface is being closed and then a reset is hitting which deadlocks th

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-09-17 Thread Kehuan Feng
Sorry, guys, the experiment environment is no longer existing now. We finally use fq_codel for online product. Cong Wang 于2020年9月18日周五 上午3:52写道: > > On Sun, Sep 13, 2020 at 7:10 PM Yunsheng Lin wrote: > > > > On 2020/9/11 4:19, Cong Wang wrote: > > > On Thu, Sep 3, 2020 at 8:21 PM Kehuan Feng w

[PATCH AUTOSEL 5.4 296/330] perf metricgroup: Free metric_events on error

2020-09-17 Thread Sasha Levin
From: Ian Rogers [ Upstream commit a159e2fe89b4d1f9fb54b0ae418b961e239bf617 ] Avoid a simple memory leak. Signed-off-by: Ian Rogers Cc: Alexander Shishkin Cc: Alexei Starovoitov Cc: Andi Kleen Cc: Andrii Nakryiko Cc: Cong Wang Cc: Daniel Borkmann Cc: Jin Yao Cc: Jiri Olsa Cc: John Fast

[PATCH AUTOSEL 5.4 301/330] wlcore: fix runtime pm imbalance in wlcore_regdomain_config

2020-09-17 Thread Sasha Levin
From: Dinghao Liu [ Upstream commit 282a04bf1d8029eb98585cb5db3fd70fe8bc91f7 ] pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Li

[PATCH AUTOSEL 5.4 315/330] mac80211: skip mpath lookup also for control port tx

2020-09-17 Thread Sasha Levin
From: Markus Theil [ Upstream commit 5af7fef39d7952c0f5551afa7b821ee7b6c9dd3d ] When using 802.1X over mesh networks, at first an ordinary mesh peering is established, then the 802.1X EAPOL dialog happens, afterwards an authenticated mesh peering exchange (AMPE) happens, finally the peering is c

[PATCH AUTOSEL 5.4 324/330] mt76: fix LED link time failure

2020-09-17 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit d68f4e43a46ff1f772ff73085f96d44eb4163e9d ] The mt76_led_cleanup() function is called unconditionally, which leads to a link error when CONFIG_LEDS is a loadable module or disabled but mt76 is built-in: drivers/net/wireless/mediatek/mt76/mac80211.o: In funct

[PATCH AUTOSEL 4.19 005/206] ath10k: fix memory leak for tpc_stats_final

2020-09-17 Thread Sasha Levin
From: Miaoqing Pan [ Upstream commit 486a8849843455298d49e694cca9968336ce2327 ] The memory of ar->debug.tpc_stats_final is reallocated every debugfs reading, it should be freed in ath10k_debug_destroy() for the last allocation. Tested HW: QCA9984 Tested FW: 10.4-3.9.0.2-00035 Signed-off-by: Mi

[PATCH AUTOSEL 4.19 004/206] ath10k: fix array out-of-bounds access

2020-09-17 Thread Sasha Levin
From: Miaoqing Pan [ Upstream commit c5329b2d5b8b4e41be14d31ee8505b4f5607bf9b ] If firmware reports rate_max > WMI_TPC_RATE_MAX(WMI_TPC_FINAL_RATE_MAX) or num_tx_chain > WMI_TPC_TX_N_CHAIN, it will cause array out-of-bounds access, so print a warning and reset to avoid memory corruption. Tested

[PATCH AUTOSEL 4.19 017/206] net: silence data-races on sk_backlog.tail

2020-09-17 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 9ed498c6280a2f2b51d02df96df53037272ede49 ] sk->sk_backlog.tail might be read without holding the socket spinlock, we need to add proper READ_ONCE()/WRITE_ONCE() to silence the warnings. KCSAN reported : BUG: KCSAN: data-race in tcp_add_backlog / tcp_recvmsg

[PATCH AUTOSEL 4.19 044/206] rt_cpu_seq_next should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit a3ea86739f1bc7e121d921842f0f4a8ab1af94d9 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH AUTOSEL 4.19 048/206] sctp: move trace_sctp_probe_path into sctp_outq_sack

2020-09-17 Thread Sasha Levin
From: Kevin Kou [ Upstream commit f643ee295c1c63bc117fb052d4da681354d6f732 ] The original patch bringed in the "SCTP ACK tracking trace event" feature was committed at Dec.20, 2017, it replaced jprobe usage with trace events, and bringed in two trace events, one is TRACE_EVENT(sctp_probe), anoth

[PATCH net-next] net: phy: realtek: enable ALDPS to save power for RTL8211F

2020-09-17 Thread Jisheng Zhang
Enable ALDPS function to save power when link down. Signed-off-by: Jisheng Zhang --- drivers/net/phy/realtek.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index 95dbe5e8e1d8..961570186822 100644 --- a/drivers/net/phy/realtek.c

[PATCH AUTOSEL 4.19 061/206] ar5523: Add USB ID of SMCWUSBT-G2 wireless adapter

2020-09-17 Thread Sasha Levin
From: Mert Dirik [ Upstream commit 5b362498a79631f283578b64bf6f4d15ed4cc19a ] Add the required USB ID for running SMCWUSBT-G2 wireless adapter (SMC "EZ Connect g"). This device uses ar5523 chipset and requires firmware to be loaded. Even though pid of the device is 4507, this patch adds it as 4

[PATCH AUTOSEL 4.19 071/206] skbuff: fix a data race in skb_queue_len()

2020-09-17 Thread Sasha Levin
From: Qian Cai [ Upstream commit 86b18aaa2b5b5bb48e609cd591b3d2d0fdbe0442 ] sk_buff.qlen can be accessed concurrently as noticed by KCSAN, BUG: KCSAN: data-race in __skb_try_recv_from_queue / unix_dgram_sendmsg read to 0x8a1b1d8a81c0 of 4 bytes by task 5371 on cpu 96: unix_dgram_sendms

[PATCH AUTOSEL 4.19 065/206] Bluetooth: Fix refcount use-after-free issue

2020-09-17 Thread Sasha Levin
From: Manish Mandlik [ Upstream commit 6c08fc896b60893c5d673764b0668015d76df462 ] There is no lock preventing both l2cap_sock_release() and chan->ops->close() from running at the same time. If we consider Thread A running l2cap_chan_timeout() and Thread B running l2cap_sock_release(), expected

[PATCH AUTOSEL 4.19 068/206] Bluetooth: prefetch channel before killing sock

2020-09-17 Thread Sasha Levin
From: Hillf Danton [ Upstream commit 2a154903cec20fb64ff4d7d617ca53c16f8fd53a ] Prefetch channel before killing sock in order to fix UAF like BUG: KASAN: use-after-free in l2cap_sock_release+0x24c/0x290 net/bluetooth/l2cap_sock.c:1212 Read of size 8 at addr 8880944904a0 by task syz-fuzze

[PATCH AUTOSEL 4.19 079/206] mt76: clear skb pointers from rx aggregation reorder buffer during cleanup

2020-09-17 Thread Sasha Levin
From: Felix Fietkau [ Upstream commit 9379df2fd9234e3b67a23101c2370c99f6af6d77 ] During the cleanup of the aggregation session, a rx handler (or release timer) on another CPU might still hold a pointer to the reorder buffer and could attempt to release some packets. Clearing pointers during clea

[PATCH AUTOSEL 4.19 087/206] bpf: Remove recursion prevention from rcu free callback

2020-09-17 Thread Sasha Levin
From: Thomas Gleixner [ Upstream commit 8a37963c7ac9ecb7f86f8ebda020e3f8d6d7b8a0 ] If an element is freed via RCU then recursion into BPF instrumentation functions is not a concern. The element is already detached from the map and the RCU callback does not hold any locks on which a kprobe, perf

[PATCH AUTOSEL 4.19 102/206] ath10k: use kzalloc to read for ath10k_sdio_hif_diag_read

2020-09-17 Thread Sasha Levin
From: Wen Gong [ Upstream commit 402f2992b4d62760cce7c689ff216ea3bf4d6e8a ] When use command to read values, it crashed. command: dd if=/sys/kernel/debug/ieee80211/phy0/ath10k/mem_value count=1 bs=4 skip=$((0x100233)) It will call to ath10k_sdio_hif_diag_read with address = 0x4008cc and buf_l

[PATCH AUTOSEL 4.19 104/206] Bluetooth: L2CAP: handle l2cap config request during open state

2020-09-17 Thread Sasha Levin
From: Howard Chung [ Upstream commit 96298f640104e4cd9a913a6e50b0b981829b94ff ] According to Core Spec Version 5.2 | Vol 3, Part A 6.1.5, the incoming L2CAP_ConfigReq should be handled during OPEN state. The section below shows the btmon trace when running L2CAP/COS/CFD/BV-12-C before and after

[PATCH AUTOSEL 4.19 130/206] SUNRPC: Fix a potential buffer overflow in 'svc_print_xprts()'

2020-09-17 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit b25b60d7bfb02a74bc3c2d998e09aab159df8059 ] 'maxlen' is the total size of the destination buffer. There is only one caller and this value is 256. When we compute the size already used and what we would like to add in the buffer, the trailling NULL chara

[PATCH AUTOSEL 4.19 131/206] svcrdma: Fix leak of transport addresses

2020-09-17 Thread Sasha Levin
From: Chuck Lever [ Upstream commit 1a33d8a284b1e85e03b8c7b1ea8fb985fccd1d71 ] Kernel memory leak detected: unreferenced object 0x49cdf480 (size 8): comm "kworker/u8:3", pid 2086, jiffies 4297898756 (age 4269.856s) hex dump (first 8 bytes): 30 00 cd 49 88 88 ff ff

[PATCH AUTOSEL 4.19 149/206] net: openvswitch: use u64 for meter bucket

2020-09-17 Thread Sasha Levin
From: Tonghao Zhang [ Upstream commit e57358873bb5d6caa882b9684f59140912b37dde ] When setting the meter rate to 4+Gbps, there is an overflow, the meters don't work as expected. Cc: Pravin B Shelar Cc: Andy Zhou Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar Signed-off-by: David S. M

[PATCH AUTOSEL 4.19 155/206] atm: fix a memory leak of vcc->user_back

2020-09-17 Thread Sasha Levin
From: Cong Wang [ Upstream commit 8d9f73c0ad2f20e9fed5380de0a3097825859d03 ] In lec_arp_clear_vccs() only entry->vcc is freed, but vcc could be installed on entry->recv_vcc too in lec_vcc_added(). This fixes the following memory leak: unreferenced object 0x8880d9266b90 (size 16): comm "a

[PATCH AUTOSEL 4.19 170/206] e1000: Do not perform reset in reset_task if we are already down

2020-09-17 Thread Sasha Levin
From: Alexander Duyck [ Upstream commit 49ee3c2ab5234757bfb56a0b3a3cb422f427e3a3 ] We are seeing a deadlock in e1000 down when NAPI is being disabled. Looking over the kernel function trace of the system it appears that the interface is being closed and then a reset is hitting which deadlocks th

[PATCH AUTOSEL 4.19 162/206] tipc: fix memory leak in service subscripting

2020-09-17 Thread Sasha Levin
From: Tuong Lien [ Upstream commit 0771d7df819284d46cf5cfb57698621b503ec17f ] Upon receipt of a service subscription request from user via a topology connection, one 'sub' object will be allocated in kernel, so it will be able to send an event of the service if any to the user correspondingly th

[PATCH AUTOSEL 4.19 183/206] perf metricgroup: Free metric_events on error

2020-09-17 Thread Sasha Levin
From: Ian Rogers [ Upstream commit a159e2fe89b4d1f9fb54b0ae418b961e239bf617 ] Avoid a simple memory leak. Signed-off-by: Ian Rogers Cc: Alexander Shishkin Cc: Alexei Starovoitov Cc: Andi Kleen Cc: Andrii Nakryiko Cc: Cong Wang Cc: Daniel Borkmann Cc: Jin Yao Cc: Jiri Olsa Cc: John Fast

[PATCH AUTOSEL 4.19 186/206] wlcore: fix runtime pm imbalance in wl1271_tx_work

2020-09-17 Thread Sasha Levin
From: Dinghao Liu [ Upstream commit 9604617e998b49f7695fea1479ed82421ef8c9f0 ] There are two error handling paths in this functon. When wlcore_tx_work_locked() returns an error code, we should decrease the runtime PM usage counter the same way as the error handling path beginning from pm_runtime

[PATCH AUTOSEL 4.19 187/206] wlcore: fix runtime pm imbalance in wlcore_regdomain_config

2020-09-17 Thread Sasha Levin
From: Dinghao Liu [ Upstream commit 282a04bf1d8029eb98585cb5db3fd70fe8bc91f7 ] pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Li

[PATCH AUTOSEL 4.19 205/206] net: openvswitch: use div_u64() for 64-by-32 divisions

2020-09-17 Thread Sasha Levin
From: Tonghao Zhang [ Upstream commit 659d4587fe7233bfdff303744b20d6f41ad04362 ] Compile the kernel for arm 32 platform, the build warning found. To fix that, should use div_u64() for divisions. | net/openvswitch/meter.c:396: undefined reference to `__udivdi3' [add more commit msg, change repor

Re: [PATCH v2 net 3/8] net: dsa: seville: fix buffer size of the queue system

2020-09-17 Thread Florian Fainelli
On 9/17/2020 6:07 PM, Vladimir Oltean wrote: From: Vladimir Oltean The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. Signed-off-by: Vladimir Oltean Reviewed-by: Horatiu Vultur Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 net 2/8] net: mscc: ocelot: add locking for the port TX timestamp ID

2020-09-17 Thread Florian Fainelli
On 9/17/2020 6:07 PM, Vladimir Oltean wrote: From: Vladimir Oltean The ocelot_port->ts_id is used to: (a) populate skb->cb[0] for matching the TX timestamp in the PTP IRQ with an skb. (b) populate the REW_OP from the injection header of the ongoing skb. Only then is ocelot_port->ts_id i

[PATCH AUTOSEL 4.14 025/127] rt_cpu_seq_next should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit a3ea86739f1bc7e121d921842f0f4a8ab1af94d9 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH net-next] Revert "ibmvnic: remove never executed if statement"

2020-09-17 Thread Lijun Pan
This reverts commit 550f4d46aff6fe57c9b1c6719c3c9de2237d7ac2. adapter->from_passive_init may be changed in ibmvnic_handle_crq while ibmvnic_reset_init is waiting for the completion of adapter->init_done. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 6 ++ 1 file changed,

[PATCH AUTOSEL 4.14 024/127] neigh_stat_seq_next() should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit 1e3f9f073c47bee7c23e77316b07bc12338c5bba ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH AUTOSEL 4.14 034/127] ar5523: Add USB ID of SMCWUSBT-G2 wireless adapter

2020-09-17 Thread Sasha Levin
From: Mert Dirik [ Upstream commit 5b362498a79631f283578b64bf6f4d15ed4cc19a ] Add the required USB ID for running SMCWUSBT-G2 wireless adapter (SMC "EZ Connect g"). This device uses ar5523 chipset and requires firmware to be loaded. Even though pid of the device is 4507, this patch adds it as 4

Re: [PATCH v2 net 5/8] net: mscc: ocelot: error checking when calling ocelot_init()

2020-09-17 Thread Florian Fainelli
On 9/17/2020 6:07 PM, Vladimir Oltean wrote: From: Vladimir Oltean ocelot_init() allocates memory, resets the switch and polls for a status register, things which can fail. Stop probing the driver in that case, and propagate the error result. Signed-off-by: Vladimir Oltean Reviewed-by: Hor

  1   2   3   4   5   >