[PATCH] block: remove redundant empty check of mq_list

2020-09-08 Thread Xianting Tian
blk_mq_flush_plug_list() itself will do the empty check of mq_list, so remove such check in blk_flush_plug_list(). Actually normally mq_list is not empty when blk_flush_plug_list is called. Signed-off-by: Xianting Tian --- block/blk-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH] vhost_vdpa: remove unnecessary spin_lock in vhost_vring_call

2020-09-08 Thread Zhu Lingshan
This commit removed unnecessary spin_locks in vhost_vring_call and related operations. Because we manipulate irq offloading contents in vhost_vdpa ioctl code path which is already protected by dev mutex and vq mutex. Signed-off-by: Zhu Lingshan --- drivers/vhost/vdpa.c | 8 +--- drivers/vho

[PATCH V3 net-next 3/4] net: ena: ethtool: add stats printing to XDP queues

2020-09-08 Thread sameehj
From: Sameeh Jubran Added statistics for TX queues that are used for XDP TX. The statistics are the same as the ones printed for regular non-XDP TX queues. The XDP queue statistics can be queried using `ethtool -S ` Signed-off-by: Shay Agroskin Signed-off-by: Sameeh Jubran --- drivers/net/et

[PATCH V3 net-next 4/4] net: ena: xdp: add queue counters for xdp actions

2020-09-08 Thread sameehj
From: Sameeh Jubran When using XDP every ingress packet is passed to an eBPF (xdp) program which returns an action for this packet. This patch adds counters for the number of times each such action was received. It also counts all the invalid actions received from the eBPF program. Signed-off-b

[PATCH V3 net-next 1/4] net: ena: ethtool: convert stat_offset to 64 bit resolution

2020-09-08 Thread sameehj
From: Sameeh Jubran The type of all stat fields is u64, therefore when iterating over stat fields in a stats struct, it makes sense to use an offset in 64 bit resolution. Doing so allows us to drop some of the casting that is currently used when referencing stats. Signed-off-by: Sameeh Jubran -

[PATCH V3 net-next 0/4] Enhance current features in ena driver

2020-09-08 Thread sameehj
From: Sameeh Jubran This series adds the following: * Exposes new device stats using ethtool. * Adds and exposes the stats of xdp TX queues through ethtool. V2: Drop the need for casting stat_offset V1: Use unsigned long for pointer math instead of uintptr_t Sameeh Jubran (4): net: ena: ethto

[PATCH V3 net-next 2/4] net: ena: ethtool: Add new device statistics

2020-09-08 Thread sameehj
From: Sameeh Jubran The new metrics provide granular visibility along multiple network dimensions and enable troubleshooting and remediation of issues caused by instances exceeding network performance allowances. The new statistics can be queried using ethtool command. Signed-off-by: Guy Tzalik

[PATCH bpf-next v2] selftests/bpf: fix test_sysctl_loop{1,2} failure due to clang change

2020-09-08 Thread Yonghong Song
Andrii reported that with latest clang, when building selftests, we have error likes: error: progs/test_sysctl_loop1.c:23:16: in function sysctl_tcp_mem i32 (%struct.bpf_sysctl*): Looks like the BPF stack limit of 512 bytes is exceeded. Please move large on stack variables into BPF per-cpu a

Re: [PATCH v3 1/4] xfrm: clone XFRMA_SET_MARK in xfrm_do_migrate

2020-09-08 Thread Steffen Klassert
On Fri, Sep 04, 2020 at 08:49:38AM +0200, Antony Antony wrote: > XFRMA_SET_MARK and XFRMA_SET_MARK_MASK was not cloned from the old > to the new. Migrate these two attributes during XFRMA_MSG_MIGRATE > > Fixes: 9b42c1f179a6 ("xfrm: Extend the output_mark to support input direction > and masking."

[PATCH v2 RESEND] net: phy: call phy_disable_interrupts() in phy_attach_direct() instead

2020-09-08 Thread Yoshihiro Shimoda
Since the micrel phy driver calls phy_init_hw() as a workaround, the commit 9886a4dbd2aa ("net: phy: call phy_disable_interrupts() in phy_init_hw()") disables the interrupt unexpectedly. So, call phy_disable_interrupts() in phy_attach_direct() instead. Otherwise, the phy cannot link up after the et

Re: [PATCH v2] vdpa/mlx5: Setup driver only if VIRTIO_CONFIG_S_DRIVER_OK

2020-09-08 Thread Eli Cohen
On Tue, Sep 08, 2020 at 10:08:39PM -0400, Jason Wang wrote: > > > - Original Message - > > set_map() is used by mlx5 vdpa to create a memory region based on the > > address map passed by the iotlb argument. If we get successive calls, we > > will destroy the current memory region and buil

INFO: rcu detected stall in cleanup_net (4)

2020-09-08 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:59126901 Merge tag 'perf-tools-fixes-for-v5.9-2020-09-03' .. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12edb93590 kernel config: https://syzkaller.appspot.com/x/.config?x=3c5f6ce8d5b68299 das

Re: [PATCH bpf-next] selftests/bpf: fix test_sysctl_loop{1,2} failure due to clang change

2020-09-08 Thread Yonghong Song
On 9/8/20 9:04 PM, Alexei Starovoitov wrote: On Tue, Sep 8, 2020 at 8:12 PM Yonghong Song wrote: diff --git a/tools/testing/selftests/bpf/progs/test_sysctl_loop2.c b/tools/testing/selftests/bpf/progs/test_sysctl_loop2.c index b2e6f9b0894d..3c292c087395 100644 --- a/tools/testing/selftests/b

[PATCH net-next v3 1/6] net/mlx5: E-switch, Read controller number from device

2020-09-08 Thread Parav Pandit
From: Parav Pandit ECPF supports one external host controller. Read controller number from the device. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan --- Changelog: v1->v2: - Removed controller number setting invocation as it is part of different API --- .../net/ethernet/mellanox/mlx5

[PATCH net-next v3 5/6] devlink: Introduce controller number

2020-09-08 Thread Parav Pandit
From: Parav Pandit A devlink port may be for a controller consist of PCI device. A devlink instance holds ports of two types of controllers. (1) controller discovered on same system where eswitch resides This is the case where PCI PF/VF of a controller and devlink eswitch instance both are locate

[PATCH net-next v3 2/6] devlink: Add comment block for missing port attributes

2020-09-08 Thread Parav Pandit
From: Parav Pandit Add comment block for physical, PF and VF port attributes. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Roi Dayan --- include/net/devlink.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/net/devlink.h b/include/net/devlink.h index 8f3c8a

[PATCH net-next v3 3/6] devlink: Move structure comments outside of structure

2020-09-08 Thread Parav Pandit
From: Parav Pandit To add more fields to the PCI PF and VF port attributes, follow standard structure comment format. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- Changelog: v2->v3: - New patch --- include/net/devlink.h | 15 --- 1 file changed, 12 insertions(+), 3 del

[PATCH net-next v3 6/6] devlink: Use controller while building phys_port_name

2020-09-08 Thread Parav Pandit
From: Parav Pandit Now that controller number attribute is available, use it when building phsy_port_name for external controller ports. An example devlink port and representor netdev name consist of controller annotation for external controller with controller number = 1, for a VF 1 of PF 0: $

[PATCH net-next v3 0/6] devlink show controller number

2020-09-08 Thread Parav Pandit
From: Parav Pandit Hi Jakub, Dave, Currently a devlink instance that supports an eswitch handles eswitch ports of two type of controllers. (1) controller discovered on same system where eswitch resides. This is the case where PCI PF/VF of a controller and devlink eswitch instance both are locate

[PATCH net-next v3 4/6] devlink: Introduce external controller flag

2020-09-08 Thread Parav Pandit
From: Parav Pandit A devlink eswitch port may represent PCI PF/VF ports of a controller. A controller either located on same system or it can be an external controller located in host where such NIC is plugged in. Add the ability for driver to specify if a port is for external controller. Use

[PATCH net-next] net: dsa: b53: Report VLAN table occupancy via devlink

2020-09-08 Thread Florian Fainelli
We already maintain an array of VLANs used by the switch so we can simply iterate over it to report the occupancy via devlink. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 59 ++-- drivers/net/dsa/b53/b53_priv.h | 1 + drivers/net/dsa/bcm_

RE: [PATCH v2] net: phy: call phy_disable_interrupts() in phy_attach_direct() instead

2020-09-08 Thread Yoshihiro Shimoda
Hi David, > From: David Miller, Sent: Wednesday, September 9, 2020 12:25 PM > > From: Yoshihiro Shimoda > Date: Wed, 9 Sep 2020 08:55:38 +0900 > > > Changes from v1: > > - Fix build error. > > When such a fundamental build failure is fixed (it could never have > built for anyone, even you),

[PATCH net 2/2] hv_netvsc: Cache the current data path to avoid duplicate call and message

2020-09-08 Thread Dexuan Cui
The previous change "hv_netvsc: Switch the data path at the right time during hibernation" adds the call of netvsc_vf_changed() upon NETDEV_CHANGE, so it's necessary to avoid the duplicate call and message when the VF is brought UP or DOWN. Signed-off-by: Dexuan Cui --- drivers/net/hyperv/hyperv

[PATCH net 1/2] hv_netvsc: Switch the data path at the right time during hibernation

2020-09-08 Thread Dexuan Cui
When netvsc_resume() is called, the mlx5 VF NIC has not been resumed yet, so in the future the host might sliently fail the call netvsc_vf_changed() -> netvsc_switch_datapath() there, even if the call works now. Call netvsc_vf_changed() in the NETDEV_CHANGE event handler: at that time the mlx5 VF

Re: [PATCH bpf-next] selftests/bpf: fix test_sysctl_loop{1,2} failure due to clang change

2020-09-08 Thread Alexei Starovoitov
On Tue, Sep 8, 2020 at 8:12 PM Yonghong Song wrote: > diff --git a/tools/testing/selftests/bpf/progs/test_sysctl_loop2.c > b/tools/testing/selftests/bpf/progs/test_sysctl_loop2.c > index b2e6f9b0894d..3c292c087395 100644 > --- a/tools/testing/selftests/bpf/progs/test_sysctl_loop2.c > +++ b/tools/

Re: [PATCH bpf-next] selftests/bpf: fix test_sysctl_loop{1,2} failure due to clang change

2020-09-08 Thread Yonghong Song
On 9/8/20 8:20 PM, Andrii Nakryiko wrote: On Tue, Sep 8, 2020 at 8:13 PM Yonghong Song wrote: Andrii reported that with latest clang, when building selftests, we have error likes: error: progs/test_sysctl_loop1.c:23:16: in function sysctl_tcp_mem i32 (%struct.bpf_sysctl*): Looks like

Re: [PATCH bpf-next 0/2] bpf: detect build errors for man pages for bpftool and eBPF helpers

2020-09-08 Thread Andrii Nakryiko
On Mon, Sep 7, 2020 at 9:40 AM Quentin Monnet wrote: > > This set aims at improving the checks for building bpftool's documentation > (including the man page for eBPF helper functions). The first patch lowers > the log-level from rst2man and fix the reported informational messages. The > second on

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-08 Thread David Miller
From: David Miller Date: Tue, 08 Sep 2020 20:28:36 -0700 (PDT) > From: Saeed Mahameed > Date: Tue, 8 Sep 2020 18:27:48 -0700 > >> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c >> @@ -232,6 +232,29 @@ mlx5e_txwqe_build_dsegs(struct

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-08 Thread David Miller
From: Saeed Mahameed Date: Tue, 8 Sep 2020 18:27:48 -0700 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > @@ -232,6 +232,29 @@ mlx5e_txwqe_build_dsegs(struct mlx5e_txqsq *sq, struct > sk_buff *skb, > return -ENOMEM; > } >

Re: [PATCH net-next 1/5] net: ipa: use atomic exchange for suspend reference

2020-09-08 Thread David Miller
From: Alex Elder Date: Tue, 8 Sep 2020 19:21:23 -0500 > We take a single IPA clock reference to keep the clock running > until we get a system suspend operation. When a system suspend > request arrives, we drop that reference, and if that's the last > reference (likely) we'll proceed with suspe

Re: [PATCH trivial] nfc: pn533/usb.c: fix spelling of "functions"

2020-09-08 Thread David Miller
From: Randy Dunlap Date: Tue, 8 Sep 2020 17:13:25 -0700 > From: Randy Dunlap > > Fix typo/spello of "functions". > > Signed-off-by: Randy Dunlap Applied to net-next.

Re: [PATCH trivial] net: ethernet/neterion/vxge: fix spelling of "functionality"

2020-09-08 Thread David Miller
From: Randy Dunlap Date: Tue, 8 Sep 2020 17:14:44 -0700 > From: Randy Dunlap > > Fix typo/spello of "functionality". > > Signed-off-by: Randy Dunlap Applied to net-next.

Re: [PATCH v2] net: phy: call phy_disable_interrupts() in phy_attach_direct() instead

2020-09-08 Thread David Miller
From: Yoshihiro Shimoda Date: Wed, 9 Sep 2020 08:55:38 +0900 > Changes from v1: > - Fix build error. When such a fundamental build failure is fixed (it could never have built for anyone, even you), I want it explained why this happened and how this was functionally tested if it did not even c

Re: [PATCH bpf-next v2 1/2] tools: bpftool: clean up function to dump map entry

2020-09-08 Thread Andrii Nakryiko
On Mon, Sep 7, 2020 at 9:36 AM Quentin Monnet wrote: > > The function used to dump a map entry in bpftool is a bit difficult to > follow, as a consequence to earlier refactorings. There is a variable > ("num_elems") which does not appear to be necessary, and the error > handling would look cleaner

Re: [PATCH] net/sock: don't drop udp packets if udp_mem[2] not reached

2020-09-08 Thread dust.li
On Tue, Sep 08, 2020 at 10:46:13AM +0200, Paolo Abeni wrote: >Hi, > >On Tue, 2020-09-08 at 11:15 +0800, dust.li wrote: >> Actually, with more udp sockets, I can always make it large >> enough to exceed udp_mem[0], and drop packets before udp_mem[1] >> and udp_mem[2]. > >Sure, but with enough socket

Re: [PATCH net-next] ipv6: add tos reflection in TCP reset and ack

2020-09-08 Thread David Miller
From: Wei Wang Date: Tue, 8 Sep 2020 14:29:02 -0700 > Currently, ipv6 stack does not do any TOS reflection. To make the > behavior consistent with v4 stack, this commit adds TOS reflection in > tcp_v6_reqsk_send_ack() and tcp_v6_send_reset(). We clear the lower > 2-bit ECN value of the received

Re: [PATCH bpf-next] selftests/bpf: fix test_sysctl_loop{1,2} failure due to clang change

2020-09-08 Thread Andrii Nakryiko
On Tue, Sep 8, 2020 at 8:13 PM Yonghong Song wrote: > > Andrii reported that with latest clang, when building selftests, we have > error likes: > error: progs/test_sysctl_loop1.c:23:16: in function sysctl_tcp_mem i32 > (%struct.bpf_sysctl*): > Looks like the BPF stack limit of 512 bytes is ex

Re: [PATCH net] ip: fix tos reflection in ack and reset packets

2020-09-08 Thread David Miller
From: Wei Wang Date: Tue, 8 Sep 2020 14:09:34 -0700 > Currently, in tcp_v4_reqsk_send_ack() and tcp_v4_send_reset(), we > echo the TOS value of the received packets in the response. > However, we do not want to echo the lower 2 ECN bits in accordance > with RFC 3168 6.1.5 robustness principles.

Re: [PATCH net-next 0/3] rxrpc: Allow more calls to same peer

2020-09-08 Thread David Miller
pace rxrpc sockets are > accounted separately. > > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-next-20200908 Pulled, thanks David.

Re: [PATCH] net: tc35815: switch from 'pci_' to 'dma_' API

2020-09-08 Thread David Miller
From: Christophe JAILLET Date: Tue, 8 Sep 2020 22:27:47 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] hippi: switch from 'pci_' to 'dma_' API

2020-09-08 Thread David Miller
From: Christophe JAILLET Date: Tue, 8 Sep 2020 22:08:39 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH net-next] sfc: coding style cleanups in mcdi_port_common.c

2020-09-08 Thread David Miller
From: Edward Cree Date: Tue, 8 Sep 2020 20:22:19 +0100 > The code recently moved into this file contained a number of coding style > issues, about which checkpatch and xmastree complained. Fix them. > > Signed-off-by: Edward Cree Applied, thanks Edward.

Re: pull-request: ieee802154 for net 2020-09-08

2020-09-08 Thread David Miller
From: Stefan Schmidt Date: Tue, 8 Sep 2020 19:42:16 +0200 > An update from ieee802154 for your *net* tree. > > A potential memory leak fix for ca8210 from Liu Jian, > a check on the return for a register read in adf7242 > and finally a user after free fix in the softmac tx > function from Eric

Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

2020-09-08 Thread David Miller
From: Jakub Kicinski Date: Tue, 8 Sep 2020 10:36:24 -0700 > We run into a unused variable warning in bridge code when > variable is only used inside the condition of > rcu_dereference_protected(). > > #define mlock_dereference(X, br) \ > rcu_dereference_protected(X, lockdep_is_held(&br->

[PATCH bpf-next] selftests/bpf: fix test_sysctl_loop{1,2} failure due to clang change

2020-09-08 Thread Yonghong Song
Andrii reported that with latest clang, when building selftests, we have error likes: error: progs/test_sysctl_loop1.c:23:16: in function sysctl_tcp_mem i32 (%struct.bpf_sysctl*): Looks like the BPF stack limit of 512 bytes is exceeded. Please move large on stack variables into BPF per-cpu a

Re: [PATCH net] MAINTAINERS: remove John Allen from ibmvnic

2020-09-08 Thread David Miller
From: Jakub Kicinski Date: Tue, 8 Sep 2020 09:30:12 -0700 > John's email has bounced and Thomas confirms he no longer > works on ibmvnic. > > Signed-off-by: Jakub Kicinski Applied, thanks.

Re: [PATCH] fib: fix fib_rule_ops indirect call wrappers when CONFIG_IPV6=m

2020-09-08 Thread David Miller
From: Brian Vazquez Date: Tue, 8 Sep 2020 09:18:12 -0700 > If CONFIG_IPV6=m, the IPV6 functions won't be found by the linker: > > ld: net/core/fib_rules.o: in function `fib_rules_lookup': > fib_rules.c:(.text+0x606): undefined reference to `fib6_rule_match' > ld: fib_rules.c:(.text+0x611): unde

Re: [PATCH 0/5] Netfilter fixes for net

2020-09-08 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 8 Sep 2020 17:09:42 +0200 > The following patchset contains Netfilter fixes for net: > > 1) Allow conntrack entries with l3num == NFPROTO_IPV4 or == NFPROTO_IPV6 >only via ctnetlink, from Will McVicker. > > 2) Batch notifications to userspace to improve n

RE: [PATCH net-next v2 5/6] devlink: Introduce controller number

2020-09-08 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Wednesday, September 9, 2020 12:20 AM > > Humm? > > > A devlink instance holds ports of two types of controllers. > > (1) controller discovered on same system where eswitch resides This is > > the case where PCI PF/VF of a controller and devlink eswitch instance

Re: [PATCH net-next] net: wimax: i2400m: fix 'msg_skb' kernel-doc warning in i2400m_msg_to_dev()

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 22:03:33 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/wimax/i2400m/control.c:709: warning: Excess function parameter > 'msg_skb' description in 'i2400m_msg_to_dev' > > This parameter is not in use. Remove it. > > Reported-by: Hu

Re: [PATCH net-next] bnx2x: Fix some kernel-doc warnings

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 22:01:58 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:4238: warning: Excess > function parameter 'netdev' description in 'bnx2x_setup_tc' > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:4238:

Re: [PATCH net-next] netlabel: Fix some kernel-doc warnings

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 22:05:43 +0800 > Fixes the following W=1 kernel build warning(s): > > net/netlabel/netlabel_calipso.c:438: warning: Excess function parameter > 'audit_secid' description in 'calipso_doi_remove' > net/netlabel/netlabel_calipso.c:605: warning: Excess function

[MPTCP][PATCH net] mptcp: fix kmalloc flag in mptcp_pm_nl_get_local_id

2020-09-08 Thread Geliang Tang
mptcp_pm_nl_get_local_id may be called in interrupt context, so we need to use GFP_ATOMIC flag to allocate memory to avoid sleeping in atomic context. [ 280.209809] BUG: sleeping function called from invalid context at mm/slab.h:498 [ 280.209812] in_atomic(): 1, irqs_disabled(): 0, non_block: 0

Re: [PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 21:59:15 +0800 > Fixes the following W=1 kernel build warning(s): > > net/ipv4/cipso_ipv4.c:510: warning: Excess function parameter 'audit_secid' > description in 'cipso_v4_doi_remove' > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied.

Re: [PATCH] net: phy: call phy_disable_interrupts() in phy_attach_direct() instead

2020-09-08 Thread David Miller
From: Yoshihiro Shimoda Date: Tue, 8 Sep 2020 20:27:20 +0900 > @@ -1423,6 +1419,10 @@ int phy_attach_direct(struct net_device *dev, struct > phy_device *phydev, > if (err) > goto error; > > + ret = phy_disable_interrupts(phydev); > + if (ret) > + return

Re: [PATCH net] ipv6: avoid lockdep issue in fib6_del()

2020-09-08 Thread David Miller
From: Eric Dumazet Date: Tue, 8 Sep 2020 01:20:23 -0700 > syzbot reported twice a lockdep issue in fib6_del() [1] > which I think is caused by net->ipv6.fib6_null_entry > having a NULL fib6_table pointer. > > fib6_del() already checks for fib6_null_entry special > case, we only need to return e

Re: [net-next] net: smsc911x: Remove unused variables

2020-09-08 Thread David Miller
From: Wei Xu Date: Tue, 8 Sep 2020 11:49:25 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/smsc/smsc911x.c: In function ‘smsc911x_rx_fastforward’: > drivers/net/ethernet/smsc/smsc911x.c:1199:16: warning: variable ‘temp’ set > but not used [-Wunused-but-set-v

Re: [PATCH net-next 0/7] net: hns3: misc updates

2020-09-08 Thread David Miller
From: Jakub Kicinski Date: Tue, 8 Sep 2020 12:05:38 -0700 > On Tue, 8 Sep 2020 10:59:47 +0800 Huazhong Tan wrote: >> There are some misc updates for the HNS3 ethernet driver. >> >> #1 narrows two local variable range in hclgevf_reset_prepare_wait(). >> #2 adds reset failure check in periodic ser

Re: [PATCH v2] net: tracepoint: fix print wrong sysctl_mem value

2020-09-08 Thread David Miller
From: Dust Li Date: Tue, 8 Sep 2020 10:09:39 +0800 > @@ -98,7 +98,7 @@ TRACE_EVENT(sock_exceed_buf_limit, > > TP_STRUCT__entry( > __array(char, name, 32) > - __field(long *, sysctl_mem) > + __array(long, sysctl_mem, 3) > __field(long, a

Re: [PATCH v2 net] net: dsa: link interfaces with the DSA master to get rid of lockdep warnings

2020-09-08 Thread David Miller
From: Vladimir Oltean Date: Tue, 8 Sep 2020 02:48:42 +0300 > Since commit 845e0ebb4408 ("net: change addr_list_lock back to static > key"), cascaded DSA setups (DSA switch port as DSA master for another > DSA switch port) are emitting this lockdep warning: ... > Since DSA never made use of the

Re: [PATCH iproute2-next v3] iproute2: ss: add support to expose various inet sockopts

2020-09-08 Thread David Ahern
On 8/19/20 3:13 PM, Wei Wang wrote: > This commit adds support to expose the following inet socket options: > -- recverr > -- is_icsk > -- freebind > -- hdrincl > -- mc_loop > -- transparent > -- mc_all > -- nodefrag > -- bind_address_no_port > -- recverr_rfc4884 > -- defer_connect > with the optio

Re: [PATCH bpf-next] samples: bpf: refactor xdp_sample_pkts_kern with BTF-defined map

2020-09-08 Thread Daniel T. Lee
On Wed, Sep 9, 2020 at 8:24 AM Andrii Nakryiko wrote: > > On Sat, Sep 5, 2020 at 8:41 AM Daniel T. Lee wrote: > > > > Most of the samples were converted to use the new BTF-defined MAP as > > they moved to libbbpf, but some of the samples were missing. > > > > Instead of using the previous BPF MAP

Re: [PATCH] vhost: new vhost_vdpa SET/GET_BACKEND_FEATURES handlers

2020-09-08 Thread Jason Wang
- Original Message - > This commit introduced vhost_vdpa_set/get_backend_features() to > resolve these issues: > (1)In vhost_vdpa ioctl SET_BACKEND_FEATURES path, currect code > would try to acquire vhost dev mutex twice > (first shown in vhost_vdpa_unlocked_ioctl), which can lead > to a

Re: [PATCH] net: sched: skip an unnecessay check

2020-09-08 Thread David Miller
From: t...@redhat.com Date: Mon, 7 Sep 2020 11:04:38 -0700 > From: Tom Rix > > Reviewing the error handling in tcf_action_init_1() > most of the early handling uses > > err_out: > if (cookie) { > kfree(cookie->data); > kfree(cookie); > } > > before cook

Re: [PATCH net-next v2 2/9] net: ethernet: ti: ale: add static configuration

2020-09-08 Thread David Miller
From: Grygorii Strashko Date: Mon, 7 Sep 2020 17:31:36 +0300 > + ale_dev_id = cpsw_ale_match_id(cpsw_ale_id_match, params->dev_id); > + if (ale_dev_id) { > + params->ale_entries = ale_dev_id->tbl_entries; > + params->major_ver_mask = ale_dev_id->major_ver_mask; ...

[PATCH] vhost: new vhost_vdpa SET/GET_BACKEND_FEATURES handlers

2020-09-08 Thread Zhu Lingshan
This commit introduced vhost_vdpa_set/get_backend_features() to resolve these issues: (1)In vhost_vdpa ioctl SET_BACKEND_FEATURES path, currect code would try to acquire vhost dev mutex twice (first shown in vhost_vdpa_unlocked_ioctl), which can lead to a dead lock issue. (2)SET_BACKEND_FEATURES wa

Re: [PATCH 00/29] treewide: Convert comma separated statements

2020-09-08 Thread Martin K. Petersen
On Mon, 24 Aug 2020 21:55:57 -0700, Joe Perches wrote: > There are many comma separated statements in the kernel. > See:https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/ > > Convert the comma separated statements that are in if/do/while blocks > to use braces and semico

Re: [PATCH v2] vdpa/mlx5: Setup driver only if VIRTIO_CONFIG_S_DRIVER_OK

2020-09-08 Thread Jason Wang
- Original Message - > set_map() is used by mlx5 vdpa to create a memory region based on the > address map passed by the iotlb argument. If we get successive calls, we > will destroy the current memory region and build another one based on > the new address mapping. We also need to setup

Re: [PATCH] vdpa/mlx5: Setup driver only if VIRTIO_CONFIG_S_DRIVER_OK

2020-09-08 Thread Jason Wang
- Original Message - > On Mon, Sep 07, 2020 at 06:53:23AM -0400, Jason Wang wrote: > > > > > > - Original Message - > > > If the memory map changes before the driver status is > > > VIRTIO_CONFIG_S_DRIVER_OK, don't attempt to create resources because it > > > may fail. For exam

Re: [PATCH v2 4/5] net: phy: smsc: LAN8710/20: add phy refclk in support

2020-09-08 Thread Florian Fainelli
On 9/8/2020 4:25 AM, Marco Felsch wrote: Add support to specify the clock provider for the phy refclk and don't rely on 'magic' host clock setup. Commit [1] tried to address this by introducing a flag and fixing the corresponding host. But this commit breaks the IRQ support since the irq setup

Re: [PATCH v2 3/5] dt-bindings: net: phy: smsc: document reference clock

2020-09-08 Thread Florian Fainelli
On 9/8/2020 4:25 AM, Marco Felsch wrote: Add support to specify the reference clock for the phy. Signed-off-by: Marco Felsch Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 2/5] net: phy: smsc: simplify config_init callback

2020-09-08 Thread Florian Fainelli
On 9/8/2020 4:25 AM, Marco Felsch wrote: Exit the driver specific config_init hook early if energy detection is disabled. We can do this because we don't need to clear the interrupt status here. Clearing the status should be removed anyway since this is handled by the phy_enable_interrupts().

Re: [PATCH v2 1/5] net: phy: smsc: skip ENERGYON interrupt if disabled

2020-09-08 Thread Florian Fainelli
On 9/8/2020 4:25 AM, Marco Felsch wrote: Don't enable the interrupt if the platform disable the energy detection by "smsc,disable-energy-detect". Signed-off-by: Marco Felsch Reviewed-by: Andrew Lunn --- v2: - Add Andrew's tag drivers/net/phy/smsc.c | 15 +++ 1 file changed,

[net-next V2 08/12] net/mlx5e: Support multiple SKBs in a TX WQE

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy TX MPWQE support for SKBs is coming in one of the following patches, and a single MPWQE can send multiple SKBs. This commit prepares the TX path code to handle such cases: 1. An additional FIFO for SKBs is added, just like the FIFO for DMA chunks. 2. struct mlx5e_tx_wqe

[net-next V2 05/12] net/mlx5e: Small improvements for XDP TX MPWQE logic

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy Use MLX5E_XDP_MPW_MAX_WQEBBS to reserve space for a MPWQE, because it's actually the maximal size a MPWQE can take. Reorganize the logic that checks when to close the MPWQE session: 1. Put all checks into a single function. 2. When inline is on, make only one compariso

[net-next V2 06/12] net/mlx5e: Unify constants for WQE_EMPTY_DS_COUNT

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy A constant for the number of DS in an empty WQE (i.e. a WQE without data segments) is needed in multiple places (normal TX data path, MPWQE in XDP), but currently we have a constant for XDP and an inline formula in normal TX. This patch introduces a common constant. Addi

[net-next V2 10/12] net/mlx5e: Rename xmit-related structs to generalize them

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy As preparation for the upcoming TX MPWQE support for SKBs, rename struct mlx5e_xdp_mpwqe to mlx5e_tx_mpwqe and move it above struct mlx5e_txqsq. This structure will be reused in the regular SQ and in the regular TX data path. Also rename mlx5e_xdp_xmit_data to mlx5e_xmit_

[net-next V2 12/12] net/mlx5e: Enhanced TX MPWQE for SKBs

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy This commit adds support for Enhanced TX MPWQE feature in the regular (SKB) data path. A MPWQE (multi-packet work queue element) can serve multiple packets, reducing the PCI bandwidth on control traffic. Two new stats (tx*_mpwqe_blks and tx*_mpwqe_pkts) are added. The fe

[net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy Move mlx5e_tx_wqe_inline_mode from en/txrx.h to en_tx.c as it's only used there. Signed-off-by: Maxim Mikityanskiy Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 23 --- .../net/ethernet/mel

[net-next V2 01/12] net/mlx5e: Refactor inline header size calculation in the TX path

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy As preparation for the next patch, don't increase ihs to calculate ds_cnt and then decrease it, but rather calculate the intermediate value temporarily. This code has the same amount of arithmetic operations, but now allows to split out ds_cnt calculation, which will be p

[net-next V2 02/12] net/mlx5e: Use struct assignment to initialize mlx5e_tx_wqe_info

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy Struct assignment guarantees that all fields of the structure are initialized (those that are not mentioned are zeroed). It makes code mode robust and reduces chances for unpredictable behavior when one forgets to reset some field and it holds an old value from previous i

[net-next V2 11/12] net/mlx5e: Move TX code into functions to be used by MPWQE

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy mlx5e_txwqe_complete performs some actions that can be taken to separate functions: 1. Update the flags needed for hardware timestamping. 2. Stop the TX queue if it's full. Take these actions into separate functions to be reused by the MPWQE code in the following commi

[net-next V2 09/12] net/mlx5e: Generalize TX MPWQE checks for full session

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy As preparation for the upcoming TX MPWQE for SKBs, create a function (mlx5e_tx_mpwqe_is_full) to check whether an MPWQE session is full. This function will be shared by MPWQE code for XDP and for SKBs. Defines are renamed and moved to make them not XDP-specific. Signed-o

[net-next V2 07/12] net/mlx5e: Move the TLS resync check out of the function

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy Before this patch, mlx5e_ktls_tx_handle_resync_dump_comp checked for resync_dump_frag_page. It happened for all WQEs without an SKB, including padding WQEs, and required a function call. Normally, padding WQEs happen more often than TLS resyncs. Take this check out of the

[net-next V2 04/12] net/mlx5e: Refactor xmit functions

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy A huge function mlx5e_sq_xmit was split into several to achieve multiple goals: 1. Reuse the code in IPoIB. 2. Better intergrate with TLS, IPSEC, GENEVE and checksum offloads. Now it's possible to reserve space in the WQ before running eseg-based offloads, so: 2.1. It'

[pull request][net-next V2 00/12] mlx5 Multi packet tx descriptors for SKBs

2020-09-08 Thread Saeed Mahameed
Hi Dave & Jakub This series adds support for Multi packet tx descriptors for SKBs. For more information please see tag log below. v1->v2: - Move small irrelevant changes from the refactoring patch to separate patches. - Don't touch mlx5e_txwqe_build_eseg_csum without need. One note that is wo

Re: [PATCH bpf-next v3 2/2] selftests/bpf: add test for map_ptr arithmetic

2020-09-08 Thread Alexei Starovoitov
On Tue, Sep 08, 2020 at 04:11:21PM -0700, Andrii Nakryiko wrote: > On Tue, Sep 8, 2020 at 10:58 AM Yonghong Song wrote: > > > > Change selftest map_ptr_kern.c with disabling inlining for > > one of subtests, which will fail the test without previous > > verifier change. Also added to verifier test

Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

2020-09-08 Thread Jakub Kicinski
On Tue, 08 Sep 2020 21:15:56 +0300 niko...@cumulusnetworks.com wrote: > Ah, you want to solve it for all. :) > Looks and sounds good to me, > Reviewed-by: Nikolay Aleksandrov Actually, I give up, lockdep_is_held() is not defined without CONFIG_LOCKDEP, let's just go with your patch..

[PATCH net-next 2/5] net: ipa: manage endpoints separate from clock

2020-09-08 Thread Alex Elder
Currently, when (before) the last IPA clock reference is dropped, all endpoints are suspended. And whenever the first IPA clock reference is taken, all endpoints are resumed (or started). In most cases there's no need to start endpoints when the clock starts. So move the calls to ipa_endpoint_su

[PATCH net-next 0/5] net: ipa: wake up system on RX available

2020-09-08 Thread Alex Elder
This series arranges for the IPA driver to wake up a suspended system if the IPA hardware has a packet to deliver to the AP. Currently, the GSI interrupt is set up to be a waking interrupt. But the GSI interrupt won't actually fire for a stopped channel (or a channel that underlies a suspended end

[PATCH net-next 3/5] net: ipa: use device_init_wakeup()

2020-09-08 Thread Alex Elder
The call to wakeup_source_register() in ipa_probe() does not do what it was intended to do. Call device_init_wakeup() in ipa_setup() instead, to set the IPA device as wakeup-capable and to initially enable wakeup capability. When we receive a SUSPEND interrupt, call pm_wakeup_dev_event() with a z

[PATCH net-next 5/5] net: ipa: do not enable GSI interrupt for wakeup

2020-09-08 Thread Alex Elder
We now trigger a system resume when we receive an IPA SUSPEND interrupt. We should *not* wake up on GSI interrupts. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 17 - drivers/net/ipa/gsi.h | 1 - 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/n

[PATCH net-next 4/5] net: ipa: enable wakeup on IPA interrupt

2020-09-08 Thread Alex Elder
Now that we handle wakeup interrupts properly, arrange for the IPA interrupt to be treated as a wakeup interrupt. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_interrupt.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ip

[PATCH net-next 1/5] net: ipa: use atomic exchange for suspend reference

2020-09-08 Thread Alex Elder
We take a single IPA clock reference to keep the clock running until we get a system suspend operation. When a system suspend request arrives, we drop that reference, and if that's the last reference (likely) we'll proceed with suspending endpoints and disabling the IPA core clock and interconnect

[PATCH trivial] net: ethernet/neterion/vxge: fix spelling of "functionality"

2020-09-08 Thread Randy Dunlap
rtion(+), 1 deletion(-) --- linux-next-20200908.orig/drivers/net/ethernet/neterion/vxge/vxge-main.c +++ linux-next-20200908/drivers/net/ethernet/neterion/vxge/vxge-main.c @@ -4539,7 +4539,7 @@ vxge_probe(struct pci_dev *pdev, const s * due to the fact that HWTS is using the FCS as

[PATCH trivial] nfc: pn533/usb.c: fix spelling of "functions"

2020-09-08 Thread Randy Dunlap
n(-) --- linux-next-20200908.orig/drivers/nfc/pn533/usb.c +++ linux-next-20200908/drivers/nfc/pn533/usb.c @@ -210,7 +210,7 @@ static void pn533_usb_abort_cmd(struct p usb_kill_urb(phy->in_urb); } -/* ACR122 specific structs and fucntions */ +/* ACR122 specific structs and functions */

Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-09-08 Thread Florian Fainelli
On 9/8/2020 3:28 PM, Florian Fainelli wrote: On 9/7/2020 9:07 PM, Florian Fainelli wrote: On 9/7/2020 11:29 AM, Vladimir Oltean wrote: From: Vladimir Oltean As explained in commit 54a0ed0df496 ("net: dsa: provide an option for drivers to always receive bridge VLANs"), DSA has historica

[PATCH v2] net: phy: call phy_disable_interrupts() in phy_attach_direct() instead

2020-09-08 Thread Yoshihiro Shimoda
Since the micrel phy driver calls phy_init_hw() as a workaround, the commit 9886a4dbd2aa ("net: phy: call phy_disable_interrupts() in phy_init_hw()") disables the interrupt unexpectedly. So, call phy_disable_interrupts() in phy_attach_direct() instead. Otherwise, the phy cannot link up after the et

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-08 Thread Jakub Kicinski
On Tue, 8 Sep 2020 15:48:12 -0700 Shannon Nelson wrote: > + dl = priv_to_devlink(ionic); > + devlink_flash_update_status_notify(dl, label, NULL, 1, timeout); > + start_time = jiffies; > + end_time = start_time + (timeout * HZ); > + do { > + mutex_lock(&ionic->dev_cm

Re: [PATCH net-next v3 7/7] net: mvpp2: ptp: add support for transmit timestamping

2020-09-08 Thread Russell King - ARM Linux admin
On Tue, Sep 08, 2020 at 04:40:52PM -0700, Richard Cochran wrote: > On Tue, Sep 08, 2020 at 11:00:41PM +0100, Russell King wrote: > > > @@ -2984,13 +2985,19 @@ static irqreturn_t mvpp2_isr(int irq, void *dev_id) > > > > static void mvpp2_isr_handle_ptp_queue(struct mvpp2_port *port, int nq) > >

  1   2   3   4   >