Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-24 Thread Greg Kroah-Hartman
On Tue, Aug 25, 2020 at 08:51:35AM +0200, Greg Kroah-Hartman wrote: > On Mon, Aug 24, 2020 at 10:55:28AM +0200, Dmitry Vyukov wrote: > > On Sun, Aug 23, 2020 at 12:57 PM Greg Kroah-Hartman > > wrote: > > > > > > On Sun, Aug 23, 2020 at 12:31:03PM +0200, Dmitry Vyukov wrote: > > > > On Sun, Aug 23,

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-24 Thread Greg Kroah-Hartman
On Mon, Aug 24, 2020 at 10:55:28AM +0200, Dmitry Vyukov wrote: > On Sun, Aug 23, 2020 at 12:57 PM Greg Kroah-Hartman > wrote: > > > > On Sun, Aug 23, 2020 at 12:31:03PM +0200, Dmitry Vyukov wrote: > > > On Sun, Aug 23, 2020 at 12:19 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Sun, Aug 2

Re: linux-next: build failure after merge of the bpf-next tree

2020-08-24 Thread Stephen Rothwell
Hi Alexei, On Mon, 24 Aug 2020 20:27:28 -0700 Alexei Starovoitov wrote: > > I didn't receive the first email you've replied to. > The build error is: > " > No libelf found > make[5]: *** [Makefile:284: elfdep] Error 1 > " > and build process stops because libelf is not found, right? > That is ex

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-24 Thread Himadri Pandya
On Mon, Aug 24, 2020 at 11:16:55AM -0700, Jakub Kicinski wrote: > On Sun, 23 Aug 2020 13:50:42 +0530 Himadri Pandya wrote: > > Initialize the buffer before passing it to usb_read_cmd() function(s) to > > fix the uninit-was-stored issue in asix_read_cmd(). > > > > Fixes: KMSAN: kernel-infoleak in r

[PATCH net-next] net/sched: add act_ct_output support

2020-08-24 Thread wenxu
From: wenxu The fragment packets do defrag in act_ct module. If the reassembled packet should send out to another net device. This over mtu big packet should be fragmented to send out. This patch add the act ct_output to archive this. Signed-off-by: wenxu --- include/net/tc_act/tc_ct_output.h

KASAN: use-after-free Read in cgroup_path_ns

2020-08-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:da2968ff Merge tag 'pci-v5.9-fixes-1' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=159763ce90 kernel config: https://syzkaller.appspot.com/x/.config?x=bb68b9e8a8cc842f das

[PATCH v2] can: m_can: Set device to software init mode before closing

2020-08-24 Thread Faiz Abbas
There might be some requests pending in the buffer when the interface close sequence occurs. In some devices, these pending requests might lead to the module not shutting down properly when m_can_clk_stop() is called. Therefore, move the device to init state before potentially powering it down. S

[PATCH net backport 5.6.14-5.8.3 v1] net: openvswitch: introduce common code for flushing flows

2020-08-24 Thread xiangxia . m . yue
From: Tonghao Zhang [ Upstream commit 77b981c82c1df7c7ad32a046f17f007450b46954 ] Backport this commit to 5.6.14 - 5.8.3. To avoid some issues, for example RCU usage warning and double free, we should flush the flows under ovs_lock. This patch refactors table_instance_destroy and introduces tabl

[PATCH net-next v3 3/3] net: openvswitch: remove unnused keep_flows

2020-08-24 Thread xiangxia . m . yue
From: Tonghao Zhang keep_flows was introduced by [1], which used as flag to delete flows or not. When rehashing or expanding the table instance, we will not flush the flows. Now don't use it anymore, remove it. [1] - https://github.com/openvswitch/ovs/commit/acd051f1761569205827dc9b037e15568a8d

[PATCH net-next v3 2/3] net: openvswitch: refactor flow free function

2020-08-24 Thread xiangxia . m . yue
From: Tonghao Zhang Decrease table->count and ufid_count unconditionally, because we only don't use count or ufid_count to count when flushing the flows. To simplify the codes, we remove the "count" argument of table_instance_flow_free. To avoid a bug when deleting flows in the future, add WARN_

[PATCH net-next v3 1/3] net: openvswitch: improve coding style

2020-08-24 Thread xiangxia . m . yue
From: Tonghao Zhang Not change the logic, just improve coding style. Cc: Pravin B Shelar Signed-off-by: Tonghao Zhang --- net/openvswitch/actions.c| 5 ++-- net/openvswitch/datapath.c | 35 net/openvswitch/flow_table.c | 44 -

[PATCH net-next v3 0/3] net: openvswitch: improve codes

2020-08-24 Thread xiangxia . m . yue
From: Tonghao Zhang This series patches are not bug fix, just improve codes. Tonghao Zhang (3): net: openvswitch: improve coding style net: openvswitch: refactor flow free function net: openvswitch: remove unnused keep_flows net/openvswitch/actions.c| 5 +-- net/openvswitch/datapath

[PATCH 00/29] treewide: Convert comma separated statements

2020-08-24 Thread Joe Perches
There are many comma separated statements in the kernel. See:https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/ Convert the comma separated statements that are in if/do/while blocks to use braces and semicolons. Many comma separated statements still exist but those are c

[PATCH 27/29] ipv6: fib6: Avoid comma separated statements

2020-08-24 Thread Joe Perches
Use semicolons and braces. Signed-off-by: Joe Perches --- net/ipv6/ip6_fib.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index 25a90f3f705c..44d68ed70f24 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -1812

[PATCH 28/29] sunrpc: Avoid comma separated statements

2020-08-24 Thread Joe Perches
Use semicolons and braces. Signed-off-by: Joe Perches --- net/sunrpc/sysctl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c index 999eee1ed61c..6c86e2a7d942 100644 --- a/net/sunrpc/sysctl.c +++ b/net/sunrpc/sysctl.c @@ -108,8

[PATCH 18/29] wan: sbni: Avoid comma separated statements

2020-08-24 Thread Joe Perches
Use semicolons and braces. Signed-off-by: Joe Perches --- drivers/net/wan/sbni.c | 101 +++-- 1 file changed, 58 insertions(+), 43 deletions(-) diff --git a/drivers/net/wan/sbni.c b/drivers/net/wan/sbni.c index 40c04ea1200a..2fde439543fb 100644 --- a/drivers/

[PATCH 16/29] 8390: Avoid comma separated statements

2020-08-24 Thread Joe Perches
Use semicolons and braces. Signed-off-by: Joe Perches --- drivers/net/ethernet/8390/axnet_cs.c | 19 --- drivers/net/ethernet/8390/lib8390.c | 14 +- drivers/net/ethernet/8390/pcnet_cs.c | 6 -- 3 files changed, 25 insertions(+), 14 deletions(-) diff --git a/dr

[PATCH 17/29] fs_enet: Avoid comma separated statements

2020-08-24 Thread Joe Perches
Use semicolons and braces. Signed-off-by: Joe Perches --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-

Re: [PATCH bpf-next] selftests/bpf: enable tc verbose mode for test_sk_assign

2020-08-24 Thread Alexei Starovoitov
On Mon, Aug 24, 2020 at 3:28 PM Yonghong Song wrote: > > Currently test_sk_assign failed verifier with llvm11/llvm12. > During debugging, I found the default verifier output is > truncated like below > Verifier analysis: > > Skipped 2200 bytes, use 'verb' option for the full verbose log. > [

Re: [PATCH bpf] bpf, sysctl: let bpf_stats_handler take a kernel pointer buffer

2020-08-24 Thread Alexei Starovoitov
On Mon, Aug 24, 2020 at 7:20 AM Tobias Klauser wrote: > > Commit 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") > changed ctl_table.proc_handler to take a kernel pointer. Adjust the > signature of bpf_stats_handler to match ctl_table.proc_handler which > fixes the following sparse

Re: [PATCH bpf] bpf: fix a buffer out-of-bound access when filling raw_tp link_info

2020-08-24 Thread Alexei Starovoitov
On Fri, Aug 21, 2020 at 1:09 PM Andrii Nakryiko wrote: > > On Fri, Aug 21, 2020 at 12:11 PM Yonghong Song wrote: > > > > Commit f2e10bff16a0 ("bpf: Add support for BPF_OBJ_GET_INFO_BY_FD for > > bpf_link") > > added link query for raw_tp. One of fields in link_info is to > > fill a user buffer w

Re: [PATCH bpf-next 0/3] samples: bpf: Refactor tracing programs with libbpf

2020-08-24 Thread Alexei Starovoitov
On Sun, Aug 23, 2020 at 05:53:31PM +0900, Daniel T. Lee wrote: > For the problem of increasing fragmentation of the bpf loader programs, > instead of using bpf_loader.o, which is used in samples/bpf, this > patch refactors the existing kprobe, tracepoint tracing programs with > libbbpf bpf loader.

[PATCH net-next] cxgb4: add error handlers to LE intr_handler

2020-08-24 Thread Raju Rangoju
cxgb4 does not look for HASHTBLMEMCRCERR and CMDTIDERR bits in LE_DB_INT_CAUSE register, but these are enabled in LE_DB_INT_ENABLE. So, add error handlers to LE interrupt handler to emit a warning or alert message for hash table mem crc and cmd tid errors Signed-off-by: Raju Rangoju --- drivers/

Re: [PATCH 1/3] libnetlink: add rtattr_for_each_nested() iteration macro

2020-08-24 Thread David Ahern
On 8/24/20 11:51 AM, Johannes Berg wrote: > This is useful for iterating elements in a nested attribute, > if they're not parsed with a strict length limit or such. > > Signed-off-by: Johannes Berg > --- > include/libnetlink.h | 5 + > 1 file changed, 5 insertions(+) > applied to iproute2-

Re: linux-next: build failure after merge of the bpf-next tree

2020-08-24 Thread Alexei Starovoitov
On Mon, Aug 24, 2020 at 8:04 PM Stephen Rothwell wrote: > > Hi Alexei, > > On Mon, 24 Aug 2020 18:25:44 -0700 Alexei Starovoitov > wrote: > > > > On Mon, Aug 24, 2020 at 6:20 PM Stephen Rothwell > > wrote: > > > > > > On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell > > > wrote: > > > > >

[PATCH v2] netlink: remove duplicated nla_need_padding_for_64bit() check

2020-08-24 Thread Miaohe Lin
The need for padding 64bit is implicitly checked by nla_align_64bit(), so remove this explicit one. Signed-off-by: Miaohe Lin --- lib/nlattr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/nlattr.c b/lib/nlattr.c index bc5b5cf608c4..98f596bfbfd8 100644 --- a/lib/nlatt

[PATCH v2] net: gain ipv4 mtu when mtu is not locked

2020-08-24 Thread Miaohe Lin
When mtu is locked, we should not obtain ipv4 mtu as we return immediately in this case and leave acquired ipv4 mtu unused. Signed-off-by: Miaohe Lin --- net/ipv4/route.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 8ca6bcab7b03.

Re: linux-next: build failure after merge of the bpf-next tree

2020-08-24 Thread Stephen Rothwell
Hi Alexei, On Mon, 24 Aug 2020 18:25:44 -0700 Alexei Starovoitov wrote: > > On Mon, Aug 24, 2020 at 6:20 PM Stephen Rothwell > wrote: > > > > On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell > > wrote: > > > > > > After merging the bpf-next tree, today's linux-next build (x86_64 > > > a

Re: [PATCH 2/3] dt-bindings: can: rcar_can: Add r8a7742 support

2020-08-24 Thread Rob Herring
On Sun, 16 Aug 2020 20:07:31 +0100, Lad Prabhakar wrote: > Document RZ/G1H (r8a7742) SoC specific bindings. The R8A7742 CAN module > is identical to R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,rcar-gen2-can". > > Signed-off-by: Lad Prabhakar

Re: [PATCH v5 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core.

2020-08-24 Thread Rob Herring
On Sat, Aug 15, 2020 at 09:43:04PM +0200, Pavel Pisa wrote: > The device-tree bindings for open-source/open-hardware CAN FD IP core > designed at the Czech Technical University in Prague. > > CTU CAN FD IP core and other CTU CAN bus related projects > listing and documentation page > >http://

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-08-24 Thread Fengkehuan Feng
Hillf, With the latest version (attached what I have changed on my tree), the system failed to start up with cpu stalled. Hillf Danton 于2020年8月22日周六 上午11:30写道: > > > On Thu, 20 Aug 2020 20:43:17 +0800 Hillf Danton wrote: > > Hi Jike, > > > > On Thu, 20 Aug 2020 15:43:17 +0800 Jike Song wrote: >

Re: [PATCH v5 1/6] dt-bindings: vendor-prefix: add prefix for the Czech Technical University in Prague.

2020-08-24 Thread Rob Herring
On Sat, 15 Aug 2020 21:43:03 +0200, Pavel Pisa wrote: > The Czech Technical University in Prague (CTU) is one of > the biggest and oldest (founded 1707) technical universities > in Europe. The abbreviation in Czech language is ČVUT according > to official name in Czech language > > České vysoké

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread Florian Fainelli
On 8/24/2020 6:21 PM, David Miller wrote: From: Florian Fainelli Date: Mon, 24 Aug 2020 17:43:37 -0700 On 8/24/2020 4:19 PM, David Miller wrote: From: Florian Fainelli Date: Sat, 22 Aug 2020 13:11:20 -0700 Hi David, Heiner, Andrew, Russell, This patch series aims at allowing myself t

Re: linux-next: build failure after merge of the bpf-next tree

2020-08-24 Thread Alexei Starovoitov
On Mon, Aug 24, 2020 at 6:20 PM Stephen Rothwell wrote: > > Hi all, > > On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the bpf-next tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > Auto-detecting system feature

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread David Miller
From: Florian Fainelli Date: Mon, 24 Aug 2020 17:43:37 -0700 > > > On 8/24/2020 4:19 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Sat, 22 Aug 2020 13:11:20 -0700 >> >>> Hi David, Heiner, Andrew, Russell, >>> >>> This patch series aims at allowing myself to keep track of the >>>

Re: linux-next: build failure after merge of the bpf-next tree

2020-08-24 Thread Stephen Rothwell
Hi all, On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell wrote: > > Hi all, > > After merging the bpf-next tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > Auto-detecting system features: > ...libelf: [ OFF ] > ...

Re: [PATCH 0/5] pull request for net-next: batman-adv 2020-08-24

2020-08-24 Thread David Miller
From: Simon Wunderlich Date: Mon, 24 Aug 2020 18:27:36 +0200 > here is a small cleanup pull request of batman-adv to go into net-next. > > Please pull or let me know of any problem! Also pulled, thank you.

Re: [PATCH 0/3] pull request for net: batman-adv 2020-08-24

2020-08-24 Thread David Miller
From: Simon Wunderlich Date: Mon, 24 Aug 2020 18:21:08 +0200 > here are some bugfixes which we would like to have integrated into net. > > Please pull or let me know of any problem! Pulled, thanks.

Re: [PATCH v8 net-next 0/3] Add PTP support for Octeontx2

2020-08-24 Thread David Miller
From: sundeep.l...@gmail.com Date: Mon, 24 Aug 2020 21:19:59 +0530 > This patchset adds PTP support for Octeontx2 platform. > PTP is an independent coprocessor block from which > CGX block fetches timestamp and prepends it to the > packet before sending to NIX block. Patches are as > follows: > >

Re: [PATCH net] sfc: fix boolreturn.cocci warning and rename function

2020-08-24 Thread David Miller
From: Edward Cree Date: Mon, 24 Aug 2020 16:18:51 +0100 > check_fcs() was returning bool as 0/1, which was a sign that the sense > of the function was unclear: false was good, which doesn't really match > a name like 'check_$thing'. So rename it to ef100_has_fcs_error(), and > use proper bool

Re: [PATCH] net: Use helper macro RT_TOS() in __icmp_send()

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 07:44:37 -0400 > Use helper macro RT_TOS() to get tos in __icmp_send(). > > Signed-off-by: Miaohe Lin Applied to net-next, thanks.

Re: [PATCH] net: Avoid access icmp_err_convert when icmp code is ICMP_FRAG_NEEDED

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 07:15:04 -0400 > There is no need to fetch errno and fatal info from icmp_err_convert when > icmp code is ICMP_FRAG_NEEDED. > > Signed-off-by: Miaohe Lin Applied to net-next, thanks.

Re: [net-next v4] seg6: using DSCP of inner IPv4 packets

2020-08-24 Thread David Miller
From: Ahmed Abdelsalam Date: Mon, 24 Aug 2020 08:51:24 + > This patch allows copying the DSCP from inner IPv4 header to the > outer IPv6 header, when doing SRv6 Encapsulation. > > This allows forwarding packet across the SRv6 fabric based on their > original traffic class. > > Signed-off-by

Re: [PATCH] net: ocelot: Add of_node_put() before return statement

2020-08-24 Thread David Miller
From: Sumera Priyadarsini Date: Sun, 23 Aug 2020 19:22:45 +0530 > Every iteration of for_each_available_child_of_node() decrements > the reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there is

Re: [PATCH] firestream: Fix memleak in fs_open

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Sun, 23 Aug 2020 19:29:35 +0800 > When make_rate() fails, vcc should be freed just > like other error paths in fs_open(). > > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH] dt-bindings: net: dsa: Fix typo

2020-08-24 Thread David Miller
From: Kurt Kanzenbach Date: Sun, 23 Aug 2020 14:18:36 +0200 > Fix spelling mistake documenation -> documentation. > > Fixes: 5a18bb14c0f7 ("dt-bindings: net: dsa: Let dsa.txt refer to dsa.yaml") > Signed-off-by: Kurt Kanzenbach Applied, thanks.

Re: [PATCH v7 net-next 00/10] qed: introduce devlink health support

2020-08-24 Thread David Miller
From: Igor Russkikh Date: Sun, 23 Aug 2020 14:19:24 +0300 > This is a followup implementation after series > > https://patchwork.ozlabs.org/project/netdev/cover/20200514095727.1361-1-irussk...@marvell.com/ > > This is an implementation of devlink health infrastructure. > > With this we are now

Re: [PATCH] net: arc_emac: Fix memleak in arc_mdio_probe

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Sun, 23 Aug 2020 16:56:47 +0800 > When devm_gpiod_get_optional() fails, bus should be > freed just like when of_mdiobus_register() fails. > > Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver") > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH] chelsio: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 10:36:48 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH net-next 0/7] mlxsw: Misc updates

2020-08-24 Thread David Miller
From: Ido Schimmel Date: Sun, 23 Aug 2020 11:06:21 +0300 > From: Ido Schimmel > > This patch set includes various updates for mlxsw. > > Patches #1-#4 adjust the default burst size of packet trap policers to > conform to Spectrum-{2,3} requirements. The corresponding selftest is > also adjuste

Re: general protection fault in security_inode_getattr

2020-08-24 Thread Yonghong Song
On 8/24/20 5:32 PM, syzbot wrote: syzbot has bisected this issue to: commit 35697c12d7ffd31a56d3c9604066a166b75d0169 Author: Yonghong Song Date: Thu Jan 16 17:40:04 2020 + selftests/bpf: Fix test_progs send_signal flakiness with nmi mode The above patch changed file: tools/

Re: [PATCH bpf-next v1 1/8] bpf: Introduce pseudo_btf_id

2020-08-24 Thread Yonghong Song
On 8/24/20 5:05 PM, Hao Luo wrote: Yonghong, An update on this thread. I successfully reproduced this issue on a 8.2.0 gcc compiler, It looks like gcc 4.9 did not have this issue. I was also using clang which did not show this bug. It seems having a DW_AT_specification that refers to another

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread Florian Fainelli
On 8/24/2020 4:19 PM, David Miller wrote: From: Florian Fainelli Date: Sat, 22 Aug 2020 13:11:20 -0700 Hi David, Heiner, Andrew, Russell, This patch series aims at allowing myself to keep track of the Ethernet PHY and MDIO bus drivers that I authored or contributed to without being listed

Re: [PATCH] NFC: st95hf: Fix memleak in st95hf_in_send_cmd

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Sun, 23 Aug 2020 15:23:43 +0800 > When down_killable() fails, skb_resp should be freed > just like when st95hf_spi_send() fails. > > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH] net: atheros: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 10:03:53 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] starfire: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 08:26:41 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] typhoon: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 08:11:50 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: ipv4: delete repeated words

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 16:31:41 -0700 > Drop duplicate words in comments in net/ipv4/. > > Signed-off-by: Randy Dunlap Applied.

Re: [PATCH] net: dccp: delete repeated words

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 18:07:13 -0700 > Drop duplicated words in /net/dccp/. > > Signed-off-by: Randy Dunlap Applied.

Re: [PATCH] net: netlink: delete repeated words

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 16:40:15 -0700 > Drop duplicated words in net/netlink/. > > Signed-off-by: Randy Dunlap Applied.

Re: general protection fault in security_inode_getattr

2020-08-24 Thread syzbot
syzbot has bisected this issue to: commit 35697c12d7ffd31a56d3c9604066a166b75d0169 Author: Yonghong Song Date: Thu Jan 16 17:40:04 2020 + selftests/bpf: Fix test_progs send_signal flakiness with nmi mode bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1303213990 start

Behavior of pinned perf event array

2020-08-24 Thread Song Liu
Hi Daniel, We are looking at sharing perf events amount multiple processes via pinned perf event array. However, we found this doesn't really work as the perf event is removed from the map when the struct file is released from user space (in perf_event_fd_array_release). This means, the pinned

Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support

2020-08-24 Thread Vinicius Costa Gomes
Hi, Kurt Kanzenbach writes: > The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic > schedules may be configured individually on each front port. Each port has > eight > egress queues. The traffic is mapped to a traffic class respectively via the > PCP > field of a VLAN tag

[PATCH net] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-24 Thread Dany Madden
From: Mingming Cao At the time of do_reset, ibmvnic tries to re-initalize the tx_pools and rx_pools to avoid re-allocating the long term buffer. However there is a window inside do_reset that the tx_pools and rx_pools were freed before re-initialized making it possible to deference null pointers.

Re: [PATCH net v2] drivers/net/wan/lapbether: Added needed_tailroom

2020-08-24 Thread Xie He
On Mon, Aug 24, 2020 at 4:09 PM David Miller wrote: > > Applied, thank you. Thank you!

Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support

2020-08-24 Thread Vinicius Costa Gomes
Hi Kurt, Kurt Kanzenbach writes: >>> +static void hellcreek_setup_tc_mapping(struct hellcreek *hellcreek, >>> + struct net_device *netdev) >>> +{ >>> + int i, j; >>> + >>> + /* Setup mapping between traffic classes and port queues. */ >>> + for (i = 0; i <

Re: [PATCH 0/7] net: sctp: delete duplicated words + other fixes

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 16:15:54 -0700 > Drop or fix repeated words in net/sctp/. Series applied to net-next, thanks Randy.

Re: [PATCH 0/8] net: batman-adv: delete duplicated words + other fixes

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 16:13:27 -0700 > Drop repeated words in net/batman-adv/. I'll let the batman-adv folks integrate this series.

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread David Miller
From: Florian Fainelli Date: Sat, 22 Aug 2020 13:11:20 -0700 > Hi David, Heiner, Andrew, Russell, > > This patch series aims at allowing myself to keep track of the Ethernet > PHY and MDIO bus drivers that I authored or contributed to without > being listed as a maintainer in the PHY library any

Re: [PATCH net-next v3 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock()

2020-08-24 Thread David Miller
From: Luke Hsiao Date: Fri, 21 Aug 2020 21:41:04 -0700 > From: Luke Hsiao > > For TCP tx zero-copy, the kernel notifies the process of completions by > queuing completion notifications on the socket error queue. This patch > allows reading these notifications via recvmsg to support TCP tx > zer

Re: [PATCH net-next v3 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE

2020-08-24 Thread David Miller
From: Luke Hsiao Date: Fri, 21 Aug 2020 21:41:05 -0700 > From: Luke Hsiao > > Currently, io_uring's recvmsg subscribes to both POLLERR and POLLIN. In > the context of TCP tx zero-copy, this is inefficient since we are only > reading the error queue and not using recvmsg to read POLLIN responses

Re: [PATCH] net: dsa: sja1105: Do not use address of compatible member in sja1105_check_device_id

2020-08-24 Thread David Miller
From: Nathan Chancellor Date: Fri, 21 Aug 2020 15:25:16 -0700 > Clang warns: > > drivers/net/dsa/sja1105/sja1105_main.c:3418:38: warning: address of > array 'match->compatible' will always evaluate to 'true' > [-Wpointer-bool-conversion] > for (match = sja1105_dt_ids; match->compatible;

Re: [PATCH] net: Get rid of consume_skb when tracing is off

2020-08-24 Thread David Miller
From: Herbert Xu Date: Sat, 22 Aug 2020 08:23:29 +1000 > The function consume_skb is only meaningful when tracing is enabled. > This patch makes it conditional on CONFIG_TRACEPOINTS. > > Signed-off-by: Herbert Xu Fair enough, applied, thanks.

Re: [PATCH net v2] drivers/net/wan/lapbether: Added needed_tailroom

2020-08-24 Thread David Miller
From: Xie He Date: Fri, 21 Aug 2020 14:26:59 -0700 > The underlying Ethernet device may request necessary tailroom to be > allocated by setting needed_tailroom. This driver should also set > needed_tailroom to request the tailroom needed by the underlying > Ethernet device to be allocated. > > C

Re: [net PATCH] netlabel: fix problems with mapping removal

2020-08-24 Thread David Miller
From: Paul Moore Date: Fri, 21 Aug 2020 16:34:52 -0400 > This patch fixes two main problems seen when removing NetLabel > mappings: memory leaks and potentially extra audit noise. > > The memory leaks are caused by not properly free'ing the mapping's > address selector struct when free'ing the e

Re: [PATCH net-next 0/2] devlink fixes for port and reporter field access

2020-08-24 Thread David Miller
From: Parav Pandit Date: Fri, 21 Aug 2020 22:12:19 +0300 > These series contains two small fixes of devlink. > > Patch-1 initializes port reporter fields early enough to > avoid access before initialized error. > Patch-2 protects port list lock during traversal. Series applied, thank you.

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-24 Thread Vladimir Oltean
On Mon, Aug 24, 2020 at 03:35:18PM -0700, David Miller wrote: > From: Vladimir Oltean > Date: Tue, 25 Aug 2020 01:02:03 +0300 > > > Just my comment on patch 5/8 about netdev->tc_to_txq. There are 2 > > distinct things about that: > > - accessing struct net_device directly hurts the DSA model a li

Re: [PATCH net-next] ibmvnic: Fix use-after-free of VNIC login response buffer

2020-08-24 Thread David Miller
From: Thomas Falcon Date: Fri, 21 Aug 2020 13:39:01 -0500 > The login response buffer is freed after it is received > and parsed, but other functions in the driver still attempt > to read it, such as when the device is opened, causing the > Oops below. Store relevant information in the driver's >

Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support

2020-08-24 Thread Vladimir Oltean
On Thu, Aug 20, 2020 at 10:11:15AM +0200, Kurt Kanzenbach wrote: > The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic > schedules may be configured individually on each front port. Each port has > eight > egress queues. The traffic is mapped to a traffic class respectively vi

Re: [PATCH net-next] ipvlan: advertise link netns via netlink

2020-08-24 Thread David Miller
From: Taehee Yoo Date: Fri, 21 Aug 2020 17:47:32 + > Assign rtnl_link_ops->get_link_net() callback so that IFLA_LINK_NETNSID is > added to rtnetlink messages. > > Test commands: > ip netns add nst > ip link add dummy0 type dummy > ip link add ipvlan0 link dummy0 type ipvlan >

Re: [PATCH v3 8/8] dt-bindings: net: dsa: Add documentation for Hellcreek switches

2020-08-24 Thread Andrew Lunn
On Thu, Aug 20, 2020 at 10:11:18AM +0200, Kurt Kanzenbach wrote: > Add basic documentation and example. > > Signed-off-by: Kurt Kanzenbach Reviewed-by: Andrew Lunn Andrew

Re: [PATCHv2 net] sctp: not disable bh in the whole sctp_get_port_local()

2020-08-24 Thread David Miller
From: Xin Long Date: Fri, 21 Aug 2020 14:59:38 +0800 > With disabling bh in the whole sctp_get_port_local(), when > snum == 0 and too many ports have been used, the do-while > loop will take the cpu for a long time and cause cpu stuck: > > [ ] watchdog: BUG: soft lockup - CPU#11 stuck for 22s!

Re: [PATCH v3 6/8] net: dsa: hellcreek: Add PTP status LEDs

2020-08-24 Thread Andrew Lunn
On Thu, Aug 20, 2020 at 10:11:16AM +0200, Kurt Kanzenbach wrote: > The switch has two controllable I/Os which are usually connected to LEDs. This > is useful to immediately visually see the PTP status. > > These provide two signals: > > * is_gm > >This LED can be activated if the current de

Re: [PATCH] net: Check the expect of skb->data at mac header

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Thu, 20 Aug 2020 08:28:22 -0400 > skb_mpls_push() and skb_mpls_pop() expect skb->data at mac header. Check > this assumption or we would get wrong mac_header and network_header. > > Signed-off-by: Miaohe Lin Both openvswitch and act_mpls.c seem to adhere to this constrai

Re: [PATCH v3 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-08-24 Thread Andrew Lunn
On Thu, Aug 20, 2020 at 10:11:12AM +0200, Kurt Kanzenbach wrote: > Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are > implementing features needed for Time Sensitive Networking (TSN) such as > support > for the Time Precision Protocol and various shapers like the Time A

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-08-24 Thread David Miller
From: Yuusuke Ashizuka Date: Thu, 20 Aug 2020 18:43:07 +0900 > When this driver is built as a module, I cannot rmmod it after insmoding > it. > This is because that this driver calls ravb_mdio_init() at the time of > probe, and module->refcnt is incremented by alloc_mdio_bitbang() called > after

Re: [RESEND PATCH] net: dsa: microchip: look for phy-mode in port nodes

2020-08-24 Thread David Miller
From: Helmut Grohne Date: Thu, 20 Aug 2020 08:03:33 +0200 > diff --git a/drivers/net/dsa/microchip/ksz_common.c > b/drivers/net/dsa/microchip/ksz_common.c > index 8d53b12d40a8..d96b7ab6bb15 100644 > --- a/drivers/net/dsa/microchip/ksz_common.c > +++ b/drivers/net/dsa/microchip/ksz_common.c > @@

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-24 Thread David Miller
From: Vladimir Oltean Date: Tue, 25 Aug 2020 01:02:03 +0300 > Just my comment on patch 5/8 about netdev->tc_to_txq. There are 2 > distinct things about that: > - accessing struct net_device directly hurts the DSA model a little bit. > - I think there's some confusion regarding the use of netdev->

[PATCH bpf-next] selftests/bpf: enable tc verbose mode for test_sk_assign

2020-08-24 Thread Yonghong Song
Currently test_sk_assign failed verifier with llvm11/llvm12. During debugging, I found the default verifier output is truncated like below Verifier analysis: Skipped 2200 bytes, use 'verb' option for the full verbose log. [...] off=23,r=34,imm=0) R5=inv0 R6=ctx(id=0,off=0,imm=0) R7=pkt(id

[PATCH] net: caif: fix error code handling

2020-08-24 Thread Tong Zhang
cfpkt_peek_head return 0 and 1, caller is checking error using <0 Signed-off-by: Tong Zhang --- net/caif/cfrfml.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c index ce2767e9cec6..7b0af33bdb97 100644 --- a/net/caif/cfrfml.c +++ b/ne

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-24 Thread Vladimir Oltean
On Mon, Aug 24, 2020 at 02:31:10PM -0700, Jakub Kicinski wrote: > On Thu, 20 Aug 2020 10:11:10 +0200 Kurt Kanzenbach wrote: > > this series adds a DSA driver for the Hirschmann Hellcreek TSN switch > > IP. Characteristics of that IP: > > > > * Full duplex Ethernet interface at 100/1000 Mbps on th

Re: [PATCH bpf-next 0/3] bpf: add MPTCP subflow support

2020-08-24 Thread Alexei Starovoitov
On Fri, Aug 21, 2020 at 05:15:38PM +0200, Nicolas Rybowski wrote: > Previously it was not possible to make a distinction between plain TCP > sockets and MPTCP subflow sockets on the BPF_PROG_TYPE_SOCK_OPS hook. > > This patch series now enables a fine control of subflow sockets. In its > current s

Re: [PATCH bpf-next] libbpf: fix type compatibility check copy-paste error

2020-08-24 Thread Alexei Starovoitov
On Fri, Aug 21, 2020 at 4:00 PM Andrii Nakryiko wrote: > > Fix copy-paste error in types compatibility check. Local type is accidentally > used instead of target type for the very first type check strictness check. > This can result in potentially less strict candidate comparison. Fix the > error.

Opening /proc//net/dev prevents network namespace from expiring

2020-08-24 Thread Arne Welzel
Hello, [reposting from kernelnewbies as suggested by Greg] as an unprivileged user one is able to keep network namespaces from expiring by opening /proc//net/dev of other processes. I've previously put this on stackexchange [1] and then bugzilla [2]. That's been a while though, so posting here fo

Re: [PATCH bpf-next] libbpf: avoid false unuinitialized variable warning in bpf_core_apply_relo

2020-08-24 Thread Alexei Starovoitov
On Fri, Aug 21, 2020 at 3:56 PM Andrii Nakryiko wrote: > > Some versions of GCC report uninitialized targ_spec usage. GCC is wrong, but > let's avoid unnecessary warnings. > > Fixes: ddc7c3042614 ("libbpf: implement BPF CO-RE offset relocation > algorithm") > Signed-off-by: Andrii Nakryiko Appl

Re: [PATCH] bpf: sk_lookup: Add user documentation

2020-08-24 Thread Alexei Starovoitov
On Fri, Aug 21, 2020 at 3:02 AM Jakub Sitnicki wrote: > > Describe the purpose of BPF sk_lookup program, how it can be attached, when > it gets invoked, and what information gets passed to it. Point the reader > to examples and further documentation. > > Signed-off-by: Jakub Sitnicki Applied to

Re: [net-next v5 13/15] iecm: Add ethtool

2020-08-24 Thread Michal Kubecek
On Mon, Aug 24, 2020 at 10:33:04AM -0700, Tony Nguyen wrote: > From: Alice Michael > > Implement ethtool interface for the common module. > > Signed-off-by: Alice Michael > Signed-off-by: Alan Brady > Signed-off-by: Phani Burra > Signed-off-by: Joshua Hay > Signed-off-by: Madhu Chittim > Si

Re: [PATCH bpf-next] docs: correct subject prefix and update LLVM info

2020-08-24 Thread Alexei Starovoitov
On Thu, Aug 20, 2020 at 11:23 PM Yonghong Song wrote: > > > > On 8/20/20 10:28 PM, Jianlin Lv wrote: > > bpf_devel_QA.rst:152 The subject prefix information is not accurate, it > > should be 'PATCH bpf-next v2' > > > > Also update LLVM version info and add information about > > ‘-DLLVM_TARGETS_TO_

Re: [PATCH v5 bpf-next 00/12] BPF TCP header options

2020-08-24 Thread Alexei Starovoitov
On Thu, Aug 20, 2020 at 12:00 PM Martin KaFai Lau wrote: > > The earlier effort in BPF-TCP-CC allows the TCP Congestion Control > algorithm to be written in BPF. It opens up opportunities to allow > a faster turnaround time in testing/releasing new congestion control > ideas to production environ

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-24 Thread Jakub Kicinski
On Thu, 20 Aug 2020 10:11:10 +0200 Kurt Kanzenbach wrote: > this series adds a DSA driver for the Hirschmann Hellcreek TSN switch > IP. Characteristics of that IP: > > * Full duplex Ethernet interface at 100/1000 Mbps on three ports > * IEEE 802.1Q-compliant Ethernet Switch > * IEEE 802.1Qbv Ti

  1   2   3   >