Re: [PATCH 0/8] net: batman-adv: delete duplicated words + other fixes

On Sunday, 23 August 2020 08:05:10 CEST Randy Dunlap wrote: [...] > > Please rebase to only contain the changes not yet in > > https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next [...] > Is this git tree included in linux-next? No, Stephen Rothwell isn't including the ba

[PATCH] starfire: switch from 'pci_' to 'dma_' API

The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'netdev_open()', GFP_ATOMIC must be used because it

[PATCH] typhoon: switch from 'pci_' to 'dma_' API

The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'typhoon_init_one()' GFP_KERNEL can be used because

Re: [PATCH 0/8] net: batman-adv: delete duplicated words + other fixes

On 8/22/20 10:49 PM, Sven Eckelmann wrote: > On Sunday, 23 August 2020 01:13:27 CEST Randy Dunlap wrote: >> Drop repeated words in net/batman-adv/. > > Please rebase to only contain the changes not yet in > https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next > > Kind re

Re: [PATCH 0/8] net: batman-adv: delete duplicated words + other fixes

On Sunday, 23 August 2020 01:13:27 CEST Randy Dunlap wrote: > Drop repeated words in net/batman-adv/. Please rebase to only contain the changes not yet in https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next Kind regards, Sven signature.asc Description: This is

Re: [PATCH iproute2 v5 0/2] iplink: hsr: add support for creating PRP device

On Mon, 17 Aug 2020 17:17:35 -0400 Murali Karicheri wrote: > This series enhances the iproute2 iplink module to add support > for creating PRP device similar to HSR. The kernel part of this > is already merged to v5.9 master > > v4 - addressed comment from Stephen Hemminger >- Sending this w

[GIT] Networking

Nothing earth shattering here, lots of small fixes (f.e. missing RCU protection, bad ref counting, missing memset(), etc.) all over the place: 1) Use get_file_rcu() in task_file iterator, from Yonghong Song. 2) There are two ways to set remote source MAC addresses in macvlan driver, but only

Re: [PATCH] net: netfilter: delete repeated words

Randy Dunlap wrote: > Drop duplicated words in net/netfilter/ and net/ipv4/netfilter/. Reviewed-by: Florian Westphal

[PATCH] net: sunrpc: delete repeated words

Drop duplicate words in net/sunrpc/. Also fix "Anyone" to be "Any one". Signed-off-by: Randy Dunlap Cc: "J. Bruce Fields" Cc: Chuck Lever Cc: linux-...@vger.kernel.org --- net/sunrpc/backchannel_rqst.c |2 +- net/sunrpc/xdr.c |2 +- net/sunrpc/xprtrdma/svc_rdma_rw.

[PATCH] net: netfilter: delete repeated words

Drop duplicated words in net/netfilter/ and net/ipv4/netfilter/. Signed-off-by: Randy Dunlap Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc: netfilter-de...@vger.kernel.org Cc: coret...@netfilter.org --- net/ipv4/netfilter/nf_nat_pptp.c |2 +- net/netfilter/nf_co

[PATCH] net: dccp: delete repeated words

Drop duplicated words in /net/dccp/. Signed-off-by: Randy Dunlap Cc: Gerrit Renker Cc: d...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/dccp/ackvec.c |2 +- net/dccp/ipv4.c |2 +- net/dccp/timer.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) ---

[PATCH] Bluetooth: fix "list_add double add" in hci_conn_complete_evt

When two HCI_EV_CONN_COMPLETE event packets with status=0 of the same HCI connection are received, device_add would be called twice which leads to kobject_add being called twice. Thus duplicate (struct hci_conn *conn)->dev.kobj.entry would be inserted into (struct hci_conn *conn)->dev.kobj.kset->li

[PATCH] net: netlink: delete repeated words

Drop duplicated words in net/netlink/. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski --- net/netlink/af_netlink.c |8 net/netlink/genetlink.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) --- linux-next-20200821.orig/net/netlink/af_netlink.c

[PATCH] net: ipv4: delete repeated words

Drop duplicate words in comments in net/ipv4/. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski --- net/ipv4/fou.c |4 ++-- net/ipv4/raw.c |2 +- net/ipv4/tcp_ipv4.c |2 +- net/ipv4/tcp_scalable.c |2 +- net/ipv4/udp.c |2 +

[PATCH 3/7] net: wireless: delete duplicated word + fix grammar

Drop the repeated word "Return" + fix verb. Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Kalle Valo Cc: linux-wirel...@vger.kernel.org --- net/wireless/core.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200731.orig/net/wireless/core.h +++ linux-next-2020

[PATCH 0/7] net: wireless: delete duplicated words + other fixes

Drop or fix duplicated words in net/wireless/ and net/mac80211/. Cc: Johannes Berg Cc: Kalle Valo Cc: linux-wirel...@vger.kernel.org net/mac80211/agg-rx.c |2 +- net/mac80211/mesh.c|2 +- net/wireless/core.h|4 ++-- net/wireless/reg.c |4 ++-- net/

[PATCH 1/7] net: mac80211: agg-rx.c: fix duplicated words

Change "If if" to "If it". Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Kalle Valo Cc: linux-wirel...@vger.kernel.org --- net/mac80211/agg-rx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200731.orig/net/mac80211/agg-rx.c +++ linux-next-20200731/net/mac80211

[PATCH 7/7] net: wireless: wext_compat.c: delete duplicated word

Drop the repeated word "be". Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Kalle Valo Cc: linux-wirel...@vger.kernel.org --- net/wireless/wext-compat.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200731.orig/net/wireless/wext-compat.c +++ linux-next-20200731/

[PATCH 4/7] net: wireless: reg.c: delete duplicated words + fix punctuation

Drop duplicated words "was" and "does". Fix "let's" apostrophe. Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Kalle Valo Cc: linux-wirel...@vger.kernel.org --- net/wireless/reg.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200731.orig/net/wireless/reg.c +

[PATCH 5/7] net: wireless: scan.c: delete or fix duplicated words

Drop repeated word "stored". Change "is is" to "it is". Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Kalle Valo Cc: linux-wirel...@vger.kernel.org --- net/wireless/scan.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200731.orig/net/wireless/scan.c +++ lin

[PATCH 2/7] net: mac80211: mesh.h: delete duplicated word

Drop the repeated word "address". Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Kalle Valo Cc: linux-wirel...@vger.kernel.org --- net/mac80211/mesh.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200731.orig/net/mac80211/mesh.c +++ linux-next-20200731/net/mac80

[PATCH 6/7] net: wireless: sme.c: delete duplicated word

Drop the repeated word "is". Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Kalle Valo Cc: linux-wirel...@vger.kernel.org --- net/wireless/sme.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200731.orig/net/wireless/sme.c +++ linux-next-20200731/net/wireless/sme

[PATCH 1/7] net: sctp: associola.c: delete duplicated words

Drop the repeated word "the" in two places. Signed-off-by: Randy Dunlap Cc: Vlad Yasevich Cc: Neil Horman Cc: Marcelo Ricardo Leitner Cc: linux-s...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/sctp/associola.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 0/7] net: sctp: delete duplicated words + other fixes

Drop or fix repeated words in net/sctp/. Cc: Vlad Yasevich Cc: Neil Horman Cc: Marcelo Ricardo Leitner Cc: linux-s...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski net/sctp/associola.c |4 ++-- net/sctp/auth.c |4 ++-- net/sctp/bind_addr.c |2 +- net

[PATCH 2/7] net: sctp: auth.c: delete duplicated words

Drop the repeated word "the" and "now". Signed-off-by: Randy Dunlap Cc: Vlad Yasevich Cc: Neil Horman Cc: Marcelo Ricardo Leitner Cc: linux-s...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/sctp/auth.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- lin

[PATCH 6/7] net: sctp: sm_make_chunk.c: delete duplicated words + fix typo

Drop the repeated words "for", "that", and "a". Change "his" to "this". Signed-off-by: Randy Dunlap Cc: Vlad Yasevich Cc: Neil Horman Cc: Marcelo Ricardo Leitner Cc: linux-s...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/sctp/sm_make_chunk.c |6 +++--- 1 file change

[PATCH 4/7] net: sctp: chunk.c: delete duplicated word

Drop the repeated word "the". Signed-off-by: Randy Dunlap Cc: Vlad Yasevich Cc: Neil Horman Cc: Marcelo Ricardo Leitner Cc: linux-s...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/sctp/chunk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200

[PATCH 3/7] net: sctp: bind_addr.c: delete duplicated word

Drop the repeated word "of". Signed-off-by: Randy Dunlap Cc: Vlad Yasevich Cc: Neil Horman Cc: Marcelo Ricardo Leitner Cc: linux-s...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/sctp/bind_addr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20

[PATCH 5/7] net: sctp: protocol.c: delete duplicated words + punctuation

Drop the repeated words "of" and "that". Add some punctuation for readability. Signed-off-by: Randy Dunlap Cc: Vlad Yasevich Cc: Neil Horman Cc: Marcelo Ricardo Leitner Cc: linux-s...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/sctp/protocol.c |8 1 file ch

[PATCH 7/7] net: sctp: ulpqueue.c: delete duplicated word

Drop the repeated word "an". Signed-off-by: Randy Dunlap Cc: Vlad Yasevich Cc: Neil Horman Cc: Marcelo Ricardo Leitner Cc: linux-s...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/sctp/ulpqueue.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-202

[PATCH 6/8] net: batman-adv: send.c: fix duplicated word

Change "is is" to "it is". Signed-off-by: Randy Dunlap Cc: Marek Lindner Cc: Simon Wunderlich Cc: Antonio Quartulli Cc: Sven Eckelmann Cc: b.a.t.m@lists.open-mesh.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/batman-adv/send.c |2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 1/8] net: batman-adv: bridge_loop_avoidance.c: delete duplicated word

Drop the repeated word "function". Signed-off-by: Randy Dunlap Cc: Marek Lindner Cc: Simon Wunderlich Cc: Antonio Quartulli Cc: Sven Eckelmann Cc: b.a.t.m@lists.open-mesh.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/batman-adv/bridge_loop_avoidance.c |2 +- 1 file changed,

[PATCH 4/8] net: batman-adv: multicast.c: delete duplicated word

Drop the repeated word "multicast". Signed-off-by: Randy Dunlap Cc: Marek Lindner Cc: Simon Wunderlich Cc: Antonio Quartulli Cc: Sven Eckelmann Cc: b.a.t.m@lists.open-mesh.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/batman-adv/multicast.c |2 +- 1 file changed, 1 insertion

[PATCH 0/8] net: batman-adv: delete duplicated words + other fixes

Drop repeated words in net/batman-adv/. Cc: Marek Lindner Cc: Simon Wunderlich Cc: Antonio Quartulli Cc: Sven Eckelmann Cc: b.a.t.m@lists.open-mesh.org Cc: "David S. Miller" Cc: Jakub Kicinski net/batman-adv/bridge_loop_avoidance.c |2 +- net/batman-adv/fragmentation.c |

[PATCH 2/8] net: batman-adv: fragmentation.c: delete duplicated word

Drop the repeated word "not". Signed-off-by: Randy Dunlap Cc: Marek Lindner Cc: Simon Wunderlich Cc: Antonio Quartulli Cc: Sven Eckelmann Cc: b.a.t.m@lists.open-mesh.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/batman-adv/fragmentation.c |2 +- 1 file changed, 1 insertion(+

[PATCH 7/8] net: batman-adv: soft-interface.c: delete duplicated words

Drop the repeated word "the" in two places. Signed-off-by: Randy Dunlap Cc: Marek Lindner Cc: Simon Wunderlich Cc: Antonio Quartulli Cc: Sven Eckelmann Cc: b.a.t.m@lists.open-mesh.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/batman-adv/soft-interface.c |4 ++-- 1 file chang

[PATCH 5/8] net: batman-adv: network-coding.c: fix duplicated word

Change "is is" to "it is". Signed-off-by: Randy Dunlap Cc: Marek Lindner Cc: Simon Wunderlich Cc: Antonio Quartulli Cc: Sven Eckelmann Cc: b.a.t.m@lists.open-mesh.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/batman-adv/network-coding.c |2 +- 1 file changed, 1 insertion(+),

[PATCH 3/8] net: batman-adv: hard-interface.c: delete duplicated word + fix punctuation

Drop the repeated word "table". End a sentence with a period. Signed-off-by: Randy Dunlap Cc: Marek Lindner Cc: Simon Wunderlich Cc: Antonio Quartulli Cc: Sven Eckelmann Cc: b.a.t.m@lists.open-mesh.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/batman-adv/hard-interface.c |2

[PATCH 8/8] net: batman-adv: types.h: delete duplicated words

Drop the repeated words "time" and "address". Signed-off-by: Randy Dunlap Cc: Marek Lindner Cc: Simon Wunderlich Cc: Antonio Quartulli Cc: Sven Eckelmann Cc: b.a.t.m@lists.open-mesh.org Cc: "David S. Miller" Cc: Jakub Kicinski --- net/batman-adv/types.h |4 ++-- 1 file changed, 2 i

Re: [PATCH][next] carl9170: Use fallthrough pseudo-keyword

On 2020-08-21 08:52, Gustavo A. R. Silva wrote: Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-of

Re: [PATCH] net: Get rid of consume_skb when tracing is off

On Sat, Aug 22, 2020 at 01:54:19PM -0400, Neil Horman wrote: > > Wouldn't it be better to make this: > #define consume_skb(x) kfree_skb(x) Either way is fine but I prefer inline functions over macros. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://g

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

On Sat, 2020-08-22 at 14:07 -0700, David Miller wrote: > From: Joe Perches > Date: Sat, 22 Aug 2020 14:03:31 -0700 > > > The compiler didn't inline the code without it. > > Then the compiler had a good reason for doing so, The "good" word choice there is slightly dubious. Compilers make bad dec

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

From: Joe Perches Date: Sat, 22 Aug 2020 14:03:31 -0700 > The compiler didn't inline the code without it. Then the compiler had a good reason for doing so, or it's a compiler bug that should be reported. I would reject any patch that added inline to a foo.c file, so unless you want to make sugg

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

On Sat, 2020-08-22 at 13:59 -0700, David Miller wrote: > From: Joe Perches > Date: Sat, 22 Aug 2020 13:39:28 -0700 > > > It _might_ be slightly faster to use inlines > > We are not using the inline directive in foo.c files and are letting > the compiler decide. > > Please don't give out advice

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

From: Pascal Bouchareine Date: Sat, 22 Aug 2020 13:53:03 -0700 > On Sat, Aug 22, 2020 at 1:19 PM Pascal Bouchareine wrote: >> >> On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine wrote: >> >> > Would it make sense to also make UDIAG_SHOW_NAME use sk_description? >> > (And keep the existing ch

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

From: Joe Perches Date: Sat, 22 Aug 2020 13:39:28 -0700 > It _might_ be slightly faster to use inlines We are not using the inline directive in foo.c files and are letting the compiler decide. Please don't give out advice like this. Thank you.

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

On Sat, Aug 22, 2020 at 1:19 PM Pascal Bouchareine wrote: > > On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine wrote: > > > Would it make sense to also make UDIAG_SHOW_NAME use sk_description? > > (And keep the existing change - setsockopt + show_fd_info via > > /proc/.../fdinfo/..) > > > Ah,v

Re: [PATCH net-next v3 0/5] Move MDIO drivers into there own directory

> Why don't you submit a full v4 once you've resolved all of these items? O.K, will do. Andrew

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

On Sat, 2020-08-22 at 12:33 -0700, David Miller wrote: > From: Jianlin Lv > Date: Sat, 22 Aug 2020 10:04:31 +0800 > > > It is not necessary to use src/dst as an intermediate variable for > > assignment operation; Delete src/dst intermediate variables to avoid > > unnecessary variable declarations

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine wrote: > Would it make sense to also make UDIAG_SHOW_NAME use sk_description? > (And keep the existing change - setsockopt + show_fd_info via > /proc/.../fdinfo/..) Ah,very wrong example - to be more precise, I suppose that'd be adding a coupl

Re: [PATCH net-next v3 0/5] Move MDIO drivers into there own directory

From: Andrew Lunn Date: Sat, 22 Aug 2020 21:51:44 +0200 > I just got a 0-day warning. I will send a fixup soon. I also get this when I simply type make after your changes: WARNING: unmet direct dependencies detected for PCS_XPCS Depends on [n]: NETDEVICES [=y] && PCS_DEVICE [=n] Selected by

[PATCH net-next 1/6] MAINTAINERS: GENET: Add missing platform data file

When commit b0ba512e25d7 ("net: bcmgenet: enable driver to work without a device tree") added include/linux/platform_data/bcmgenet.h, the file was not added to the GENET MAINTAINERS file section, add it now. Signed-off-by: Florian Fainelli --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) d

[PATCH net-next 4/6] MAINTAINERS: GENET: Add UniMAC MDIO controller files

In preparation for removing myself from the PHYLIB entry, add the UniMAC MDIO controller files (DT binding, driver and platform_data header) to the GENET entry. The UniMAC MDIO controller is essential to the GENET operation, therefore it makes sense to group them together. Signed-off-by: Florian F

[PATCH net-next 5/6] MAINTAINERS: Add entry for Broadcom Ethernet PHY drivers

Add an entry for the Broadcom Ethernet PHY drivers covering the BCM63xx, BCM7xxx, BCM87xx, BCM54140, BCM84881, the venerable broadcom.c driver and the companion library files. Signed-off-by: Florian Fainelli --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAIN

[PATCH net-next 3/6] MAINTAINERS: GENET: Add DT binding file

When the DT binding was added in aab5127d94e6 ("Documentation: add Device tree bindings for Broadcom GENET"), the file was not explicitly listed under the GENET MAINTAINERS section, do that now. Signed-off-by: Florian Fainelli --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/M

[PATCH net-next 6/6] MAINTAINERS: Remove self from PHY LIBRARY

My last significant achievements to the PHY library was ensuring we would have small bus factor by having Andrew and Heiner added. The world has moved on past 1G, but I have not, so let more competent maintainers take over. Signed-off-by: Florian Fainelli --- MAINTAINERS | 1 - 1 file changed, 1

[PATCH net-next 2/6] MAINTAINERS: B53: Add DT binding file

When the binding was added with 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch"), it was not explicitly added to the B53 MAINTAINERS file section, add it now. Signed-off-by: Florian Fainelli --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAIN

[PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

Hi David, Heiner, Andrew, Russell, This patch series aims at allowing myself to keep track of the Ethernet PHY and MDIO bus drivers that I authored or contributed to without being listed as a maintainer in the PHY library anymore. Thank you for the fish, I will still be around. This builds on to

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

Thank you, On Sat, Aug 22, 2020 at 12:36 PM David Miller wrote: > > We ignore optlen and constrain the string to a static max size > > > > Signed-off-by: Pascal Bouchareine > > This change is really a non-starter unless the information gets > published somewhere where people actually look at dum

Re: [PATCH net-next v3 0/5] Move MDIO drivers into there own directory

Hi David I just got a 0-day warning. I will send a fixup soon. Andrew

Re: [PATCH net-next v3 0/5] Move MDIO drivers into there own directory

From: Andrew Lunn Date: Sat, 22 Aug 2020 20:06:06 +0200 > The phy subdirectory is getting cluttered. It has both PHY drivers and > MDIO drivers, plus a stray switch driver. Soon more PCS drivers are > likely to appear. > > Move MDIO and PCS drivers into new directories. This requires fixing > up

Re: [PATCH] net: Get rid of consume_skb when tracing is off

From: Neil Horman Neil, you might want to fix this so people can reply to you :-)

Re: [PATCH net-next v2 0/9] l2tp: replace custom logging code with tracepoints

From: Tom Parkin Date: Sat, 22 Aug 2020 15:59:00 +0100 > The l2tp subsystem implemented custom logging macros for debugging > purposes which were controlled using a set of debugging flags in each > tunnel and session structure. > > A more standard and easier-to-use approach is to use tracepoints

Re: [PATCH net v2] net: nexthop: don't allow empty NHA_GROUP

From: Nikolay Aleksandrov Date: Sat, 22 Aug 2020 15:06:36 +0300 > Currently the nexthop code will use an empty NHA_GROUP attribute, but it > requires at least 1 entry in order to function properly. Otherwise we > end up derefencing null or random pointers all over the place due to not > having an

Re: [PATCH] net: dccp: Convert to use the preferred fallthrough macro

From: Miaohe Lin Date: Sat, 22 Aug 2020 04:08:27 -0400 > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Miaohe Lin Applied.

Re: [PATCH v2 1/2] mm: add GFP mask param to strndup_user

Thanks for taking a look! On Fri, Aug 21, 2020 at 8:51 PM Andrew Morton wrote: > Why change all existing callsites so that one callsite can pass in a > different gfp_t? My initial thought was to change strndup_user to use GFP_KERNEL_ACCOUNT (or GFP_USER | __GFP_ACCOUNT ?) unconditionally. (Woul

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

From: Pascal Bouchareine Date: Fri, 21 Aug 2020 20:28:27 -0700 > This command attaches the zero terminated string in optval to the > socket for troubleshooting purposes. The free string is displayed in the > process fdinfo file for that fd (/proc//fdinfo/). > > One intended usage is to allow pro

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

From: Jianlin Lv Date: Sat, 22 Aug 2020 10:04:31 +0800 > It is not necessary to use src/dst as an intermediate variable for > assignment operation; Delete src/dst intermediate variables to avoid > unnecessary variable declarations. > > Signed-off-by: Jianlin Lv It keeps the line lengths within

Re: [PATCH net-next v3 2/5] net/phy/mdio-i2c: Move header file to include/linux/mdio

On 8/22/2020 11:06 AM, Andrew Lunn wrote: In preparation for moving all MDIO drivers into drivers/net/mdio, move the mdio-i2c header file into include/linux/mdio so it can be used by both the MDIO driver and the SFP code which instantiates I2C MDIO busses. v2: Add include/linux/mdio Signed-o

Re: [PATCH net-next v3 3/5] net: xgene: Move shared header file into include/linux

On 8/22/2020 11:06 AM, Andrew Lunn wrote: This header file is currently included into the ethernet driver via a relative path into the PHY subsystem. This is bad practice, and causes issues for the upcoming move of the MDIO driver. Move the header file into include/linux to clean this up. v2:

Re: [PATCH net-next v3 1/5] net: pcs: Move XPCS into new PCS subdirectory

On 8/22/2020 11:06 AM, Andrew Lunn wrote: Create drivers/net/pcs and move the Synopsys DesignWare XPCS into the new directory. Move the header file into a subdirectory include/linux/pcs Start a naming convention of all PCS files use the prefix pcs-, and rename the XPCS files to fit. v2: Add

Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: add support for 88E6393X from Amethyst family

On Sat, Aug 22, 2020 at 06:49:46PM +0200, Andrew Lunn wrote: > > --- a/drivers/net/dsa/mv88e6xxx/port.c > > +++ b/drivers/net/dsa/mv88e6xxx/port.c > > @@ -187,11 +187,16 @@ static int mv88e6xxx_port_set_speed_duplex(struct > > mv88e6xxx_chip *chip, > > ctrl = MV88E6XXX_PORT_MAC_CTL_SPE

Re: [PATCH 00/32] Set 2: Rid W=1 warnings in Wireless

On 2020-08-21 09:16, Lee Jones wrote: This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. I see that after our discussion about the carl9170 change in this thread following your patch:

[PATCH net-next v3 5/5] net: phy: Sort Kconfig and Makefile

Sort the Kconfig based on the text shown in make menuconfig and sort the Makefile by CONFIG symbol. Acked-by: Florian Fainelli Signed-off-by: Andrew Lunn --- drivers/net/phy/Kconfig | 164 +++ drivers/net/phy/Makefile | 10 +-- 2 files changed, 87 insertion

[PATCH net-next v3 4/5] net: mdio: Move MDIO drivers into a new subdirectory

Move all the MDIO drivers and multiplexers into drivers/net/mdio. The mdio core is however left in the phy directory, due to mutual dependencies between the MDIO core and the PHY core. Take this opportunity to sort the Kconfig based on the menuconfig strings, and move the multiplexers to the end

[PATCH net-next v3 1/5] net: pcs: Move XPCS into new PCS subdirectory

Create drivers/net/pcs and move the Synopsys DesignWare XPCS into the new directory. Move the header file into a subdirectory include/linux/pcs Start a naming convention of all PCS files use the prefix pcs-, and rename the XPCS files to fit. v2: Add include/linux/pcs Cc: Jose Abreu Signed-off-b

[PATCH net-next v3 2/5] net/phy/mdio-i2c: Move header file to include/linux/mdio

In preparation for moving all MDIO drivers into drivers/net/mdio, move the mdio-i2c header file into include/linux/mdio so it can be used by both the MDIO driver and the SFP code which instantiates I2C MDIO busses. v2: Add include/linux/mdio Signed-off-by: Andrew Lunn --- MAINTAINERS

[PATCH net-next v3 0/5] Move MDIO drivers into there own directory

The phy subdirectory is getting cluttered. It has both PHY drivers and MDIO drivers, plus a stray switch driver. Soon more PCS drivers are likely to appear. Move MDIO and PCS drivers into new directories. This requires fixing up the xgene driver which uses a relative include path. v2: Move the su

[PATCH net-next v3 3/5] net: xgene: Move shared header file into include/linux

This header file is currently included into the ethernet driver via a relative path into the PHY subsystem. This is bad practice, and causes issues for the upcoming move of the MDIO driver. Move the header file into include/linux to clean this up. v2: Move header to include/linux/mdio Signed-off-

Re: [PATCH] net: Get rid of consume_skb when tracing is off

On Sat, Aug 22, 2020 at 08:23:29AM +1000, Herbert Xu wrote: > The function consume_skb is only meaningful when tracing is enabled. > This patch makes it conditional on CONFIG_TRACEPOINTS. > > Signed-off-by: Herbert Xu > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index 46881

Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: add support for 88E6393X from Amethyst family

> --- a/drivers/net/dsa/mv88e6xxx/port.c > +++ b/drivers/net/dsa/mv88e6xxx/port.c > @@ -187,11 +187,16 @@ static int mv88e6xxx_port_set_speed_duplex(struct > mv88e6xxx_chip *chip, > ctrl = MV88E6XXX_PORT_MAC_CTL_SPEED_1000; > break; > case 2500: > - if

Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: add support for 88E6393X from Amethyst family

> /* Set power up/down for 10GBASE-R and 10GBASE-X4/X2 */ > static int mv88e6390_serdes_power_10g(struct mv88e6xxx_chip *chip, u8 lane, > bool up) > @@ -678,8 +699,8 @@ int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, > int port, u8 lane, > case M

Re: [EXT] Re: [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

On Thu, Aug 20, 2020 at 10:00:21AM +, Mickey Rachamim wrote: > > ASIC device specific handling is serviced by the firmware, current > > driver's logic does not have PP specific code and relies on the FW > > ABI which is PP-generic, and it looks like this how it should work > > for boards with

Re: [RFC PATCH net-next 0/6] devlink: Add device metric support

On Fri, 21 Aug 2020 19:18:37 -0600 David Ahern wrote: > On 8/21/20 6:37 PM, Jakub Kicinski wrote: > >>> # cat /proc/net/tls_stat > >> > >> I do not agree with adding files under /proc/net for this. > > > > Yeah it's not the best, with higher LoC a better solution should be > > within reach.

Re: [PATCH v3 1/2] net: add support for threaded NAPI polling

On 8/21/20 6:49 PM, Jakub Kicinski wrote: > On Fri, 21 Aug 2020 21:01:50 +0200 Felix Fietkau wrote: >> For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI >> poll function does not perform well. Since NAPI poll is bound to the CPU it >> was scheduled from, we can easily

Re: BUG: corrupted list in kobject_add_internal

On Thu, Aug 20, 2020 at 08:13:47AM +0200, Dmitry Vyukov wrote: On Thu, Aug 20, 2020 at 8:07 AM Coiby Xu wrote: On Fri, Aug 07, 2020 at 09:47:20AM -0700, syzbot wrote: >Hello, > >syzbot found the following issue on: > >HEAD commit:5a30a789 Merge tag 'x86-urgent-2020-08-02' of git://git.ke..

Re: [PATCH net-next 2/2] net: phy: dp83867: apply ti,led-function and ti,led-ctrl to registers

On Fri, Aug 21, 2020 at 09:21:46AM +0200, Matthias Schiffer wrote: > These DT bindings are already in use by the imx7-mba7 DTS, but they were > not supported by the PHY driver so far. > > Signed-off-by: Matthias Schiffer Sorry, but NACK. Please look at the work Marek Behún is doing https://lkm

Re: [PATCH net-next v3 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE

On 8/21/20 10:41 PM, Luke Hsiao wrote: > From: Luke Hsiao > > Currently, io_uring's recvmsg subscribes to both POLLERR and POLLIN. In > the context of TCP tx zero-copy, this is inefficient since we are only > reading the error queue and not using recvmsg to read POLLIN responses. > > This patch

Re: [PATCH net v2] net: nexthop: don't allow empty NHA_GROUP

On 8/22/20 6:06 AM, Nikolay Aleksandrov wrote: > Currently the nexthop code will use an empty NHA_GROUP attribute, but it > requires at least 1 entry in order to function properly. Otherwise we > end up derefencing null or random pointers all over the place due to not > having any nh_grp_entry memb

[PATCH net-next v2 8/9] l2tp: remove tunnel and session debug flags field

The l2tp subsystem now uses standard kernel logging APIs for informational and warning messages, and tracepoints for debug information. Now that the tunnel and session debug flags are unused, remove the field from the core structures. Various system calls (in the case of l2tp_ppp) and netlink mes

[PATCH net-next v2 9/9] docs: networking: add tracepoint info to l2tp.rst

Update l2tp.rst to: * remove information about the obsolete debug flags and their use * include information about tracepoints for l2tp Signed-off-by: Tom Parkin --- Documentation/networking/l2tp.rst | 37 --- 1 file changed, 14 insertions(+), 23 deletions(-) diff

[PATCH net-next v2 5/9] l2tp: add tracepoint definitions in trace.h

l2tp can provide a better debug experience using tracepoints rather than printk-style logging. Add tracepoint definitions in trace.h for use in the l2tp subsystem code. Add preprocessor definitions for the length of session and tunnel names in l2tp_core.h so we can reuse these in trace.h. Signed

[PATCH net-next v2 6/9] l2tp: add tracepoints to l2tp_core.c

Add lifetime event tracing for tunnel and session instances, tracking tunnel and session registration, deletion, and eventual freeing. Port the data path sequence number debug logging to use trace points rather than custom debug macros. Signed-off-by: Tom Parkin --- net/l2tp/l2tp_core.c | 83 ++

[PATCH net-next v2 1/9] l2tp: don't log data frames

l2tp had logging to trace data frame receipt and transmission, including code to dump packet contents. This was originally intended to aid debugging of core l2tp packet handling, but is of limited use now that code is stable. Signed-off-by: Tom Parkin --- net/l2tp/l2tp_core.c | 58 +

[PATCH net-next v2 3/9] l2tp: use standard API for warning log messages

The l2tp_* log wrappers only emit messages of a given category if the tunnel or session structure has the appropriate flag set in its debug field. Flags default to being unset. For warning messages, this doesn't make a lot of sense since an administrator is likely to want to know about datapath w

[PATCH net-next v2 0/9] l2tp: replace custom logging code with tracepoints

The l2tp subsystem implemented custom logging macros for debugging purposes which were controlled using a set of debugging flags in each tunnel and session structure. A more standard and easier-to-use approach is to use tracepoints. This patchset refactors l2tp to: * remove excessive logging *

[PATCH net-next v2 7/9] l2tp: remove custom logging macros

All l2tp's informational and warning logging is now carried out using standard kernel APIs. Debugging information is now handled using tracepoints. Now that no code is using the custom logging macros, remove them from l2tp_core.h. Signed-off-by: Tom Parkin --- net/l2tp/l2tp_core.h | 13 ---

[PATCH net-next v2 2/9] l2tp: remove noisy logging, use appropriate log levels

l2tp_ppp in particular had a lot of log messages for tracing [get|set]sockopt calls. These aren't especially useful, so remove these messages. Several log messages flagging error conditions were logged using l2tp_info: they're better off as l2tp_warn. Signed-off-by: Tom Parkin --- net/l2tp/l2t

[PATCH net-next v2 4/9] l2tp: add tracepoint infrastructure to core

The l2tp subsystem doesn't currently make use of tracepoints. As a starting point for adding tracepoints, add skeleton infrastructure for defining tracepoints for the subsystem, and for having them build appropriately whether compiled into the kernel or built as a module. Signed-off-by: Tom Parki

Re: missing support for certain realtek 8125-chip

On 22.08.2020 09:27, net...@dvl.sh-ks.net wrote: > hi. > > we've got a odroid h2+ from hardkernel with two realtek 8125 chips > onboard, but the r8169-driver doesn't work with them. > > on module-load we got "unknown chip XID 641" for both. > > the chips themselves are labled as: > > RTL 8125B

  1   2   >