Re: [PATCH 1/3] net: introduce helper sendpage_ok() in include/linux/net.h

Hi Coly, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on net/master net-next/master ipvs/master linus/master v5.8 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH 2/2] net: socket: implement SO_DESCRIPTION

Hi Pascal, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/perf/core] [also build test WARNING on linux/master v5.8] [cannot apply to security/next-testing linus/master next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. An

Re: [PATCH v2] bpf: Convert to use the preferred fallthrough macro

On 8/15/20 1:47 AM, Miaohe Lin wrote: Since commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use") introduce fallthrough pseudo keyword, then we should convert the uses of fallthrough comments to it. Signed-off-by: Miaohe Lin Acked-by: Yonghong

[PATCH 1/1] MAINTAINERS: SOFT-ROCE: Change Zhu Yanjun's email address

I prefer to use this email address for kernel related work. Signed-off-by: Zhu Yanjun --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e02479a..065225f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15833,7 +15833,7 @@ F:

Re: [RFC 3/3] staging: qlge: clean up code that dump info to dmesg

On 2020-08-15 00:06 +0800, Coiby Xu wrote: > The related code are not necessary because, > - Device status and general registers can be obtained by ethtool. > - Coredump can be done via devlink health reporter. > - Structure related to the hardware (struct ql_adapter) can be obtained > by crash o

Re: [RFC 1/3] Initialize devlink health dump framework for the dlge driver

On 2020-08-15 00:05 +0800, Coiby Xu wrote: > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/Makefile | 2 +- > drivers/staging/qlge/qlge.h| 9 +++ > drivers/stag

Re: [PATCH net] drivers/net/wan/lapbether: Added needed_tailroom

I took some time to look at the history of needed_tailroom. I found it was added in this commit: f5184d267c1a (net: Allow netdevices to specify needed head/tailroom) The author tried to make use of needed_tailroom at various places in the kernel by replacing the macro LL_RESERVED_SPACE with his ne

Re: [PATCH] net: add missing skb_uarg refcount increment in pskb_carve_inside_header()

Willem de Bruijn wrote: >On Fri, Aug 14, 2020 at 9:20 AM linmiaohe wrote: >> >> Willem de Bruijn wrote: >> >On Thu, Aug 13, 2020 at 2:16 PM Miaohe Lin wrote: >> >> >> >> If the skb is zcopied, we should increase the skb_uarg refcount >> >> before we involve skb_release_data(). See pskb_expand_

Re: [PATCH] net: correct zerocopy refcnt with newly allocated UDP or RAW uarg

Willem de Bruijn wrote: >On Fri, Aug 14, 2020 at 10:17 AM linmiaohe wrote: >> > >I don't think that can happen. > >The question is when this branch is false > >next = (u32)atomic_read(&sk->sk_zckey); >if ((u32)(uarg->id + uarg->len) == next) { > >I cannot come up w

Re: [GIT PULL] 9p update for 5.9-rc1

The pull request you sent on Sat, 15 Aug 2020 07:52:19 +0200: > https://github.com/martinetd/linux tags/9p-for-5.9-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/410520d07f5c66a6c1f3eb7ef2063d9bdd3d440b Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.

Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

Yonghong Song wrote: >On 8/14/20 2:16 AM, Miaohe Lin wrote: >> Convert the uses of fallthrough comments to fallthrough macro. >> >> Signed-off-by: Miaohe Lin > >This is not a bug fix but rather an enhancement so not sure whether this >should push to bpf tree or wait until bpf-next. > >It may be

Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

Andrii Nakryiko wrote: On Fri, Aug 14, 2020 at 2:58 AM Miaohe Lin wrote: >> >> Convert the uses of fallthrough comments to fallthrough macro. >> @@ -1794,7 +1794,7 @@ static bool cg_sockopt_is_valid_access(int off, int >> size, >> return prog->expected_attach_type == >>

[PATCH v2] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear()

The frags of skb_shared_info of the data is assigned in following loop. It is meaningless to do a memcpy of frags here. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index afbc1a79dc8a..

[PATCH] net: handle the return value of pskb_carve_frag_list() correctly

pskb_carve_frag_list() may return -ENOMEM in pskb_carve_inside_nonlinear(). we should handle this correctly or we would get wrong sk_buff. Fixes: 6fa01ccd8830 ("skbuff: Add pskb_extract() helper function") Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 10 +++--- 1 file changed, 7 inserti

[PATCH v2] bpf: Convert to use the preferred fallthrough macro

Since commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use") introduce fallthrough pseudo keyword, then we should convert the uses of fallthrough comments to it. Signed-off-by: Miaohe Lin --- kernel/bpf/cgroup.c | 1 - kernel/bpf/cpumap.c | 2 +-

[PATCH] net: Fix potential wrong skb->protocol in skb_vlan_untag()

We may access the two bytes after vlan_hdr in vlan_set_encap_proto(). So we should pull VLAN_HLEN + sizeof(unsigned short) in skb_vlan_untag() or we may access the wrong data. Fixes: 0d5501c1c828 ("net: Always untag vlan-tagged traffic on input.") Signed-off-by: Miaohe Lin --- net/core/skbuff.c

Re: [PATCH net v4] net: xdp: account for layer 3 packets in generic skb handler

On Fri, Aug 14, 2020 at 11:27 PM David Miller wrote: > > From: "Jason A. Donenfeld" > Date: Fri, 14 Aug 2020 23:04:56 +0200 > > > What? No. It comes up repeatedly because people want to reuse their > > XDP processing logic with layer 3 devices. > > XDP is a layer 2 packet processing technology.

[PATCH net v6] net: xdp: account for layer 3 packets in generic skb handler

A user reported that packets from wireguard were possibly ignored by XDP [1]. Another user reported that modifying packets from layer 3 interfaces results in impossible to diagnose drops. Apparently, the generic skb xdp handler path seems to assume that packets will always have an ethernet header,

[Patch net] tipc: fix uninit skb->data in tipc_nl_compat_dumpit()

__tipc_nl_compat_dumpit() has two callers, and it expects them to pass a valid nlmsghdr via arg->data. This header is artificial and crafted just for __tipc_nl_compat_dumpit(). tipc_nl_compat_publ_dump() does so by putting a genlmsghdr as well as some nested attribute, TIPC_NLA_SOCK. But the other

[PATCH net] net: xdp: pull ethernet header off packet after computing skb->protocol

When an XDP program changes the ethernet header protocol field, eth_type_trans is used to recalculate skb->protocol. In order for eth_type_trans to work correctly, the ethernet header must actually be part of the skb data segment, so the code first pushes that onto the head of the skb. However, it

Re: [PATCH v5 5/6] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.

On 8/15/20 12:43 PM, Pavel Pisa wrote: > diff --git a/drivers/net/can/ctucanfd/Kconfig > b/drivers/net/can/ctucanfd/Kconfig > index e1636373628a..a8c9cc38f216 100644 > --- a/drivers/net/can/ctucanfd/Kconfig > +++ b/drivers/net/can/ctucanfd/Kconfig > @@ -21,4 +21,15 @@ config CAN_CTUCANFD_PCI >

Re: [PATCH v5 3/6] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part.

On 8/15/20 12:43 PM, Pavel Pisa wrote: > diff --git a/drivers/net/can/ctucanfd/Kconfig > b/drivers/net/can/ctucanfd/Kconfig > new file mode 100644 > index ..d8da44d7f926 > --- /dev/null > +++ b/drivers/net/can/ctucanfd/Kconfig > @@ -0,0 +1,15 @@ > +config CAN_CTUCANFD > + tristate

Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error

Tong Zhang wrote: > ct_sip_parse_numerical_param can only return 0 or 1, but the caller is > checking parsing error using < 0 Reviewed-by: Florian Westphal

Re: [PATCH net-next v5] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

On Sat, Aug 15, 2020 at 10:53:40PM +0200, Clemens Gruber wrote: > Hi Andrew, > > On Sat, Aug 15, 2020 at 07:53:49PM +0200, Andrew Lunn wrote: > > On Sat, Aug 15, 2020 at 06:55:56PM +0200, Clemens Gruber wrote: > > > Hi, > > > > > > this patch / commit f166f890c8 ("net: ethernet: fec: Replace inte

[PATCH v5 1/6] dt-bindings: vendor-prefix: add prefix for the Czech Technical University in Prague.

The Czech Technical University in Prague (CTU) is one of the biggest and oldest (founded 1707) technical universities in Europe. The abbreviation in Czech language is ČVUT according to official name in Czech language České vysoké učení technické v Praze The English translation The Czech Tech

[PATCH v5 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core.

The device-tree bindings for open-source/open-hardware CAN FD IP core designed at the Czech Technical University in Prague. CTU CAN FD IP core and other CTU CAN bus related projects listing and documentation page http://canbus.pages.fel.cvut.cz/ Signed-off-by: Pavel Pisa --- .../bindings/ne

Re: [PATCH 1/2] mm: add GFP mask param to strndup_user

On Sat, Aug 15, 2020 at 11:23:43AM -0700, Pascal Bouchareine wrote: > Let caller specify allocation. > Preserve existing calls with GFP_USER. Bloody bad idea, unless you slap a BUG_ON(flags & GFP_ATOMIC) on it, to make sure nobody tries _that_. Note that copying from userland is an inherently blo

[PATCH v5 3/6] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part.

From: Martin Jerabek This driver adds support for the CTU CAN FD open-source IP core. More documentation and core sources at project page (https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core). The core integration to Xilinx Zynq system as platform driver is available (https://gitlab.fel.cvut.cz/ca

[PATCH v5 4/6] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support.

PCI bus adaptation for CTU CAN FD open-source IP core. The project providing FPGA design for Intel EP4CGX15 based DB4CGX15 PCIe board with PiKRON.com designed transceiver riser shield is available at https://gitlab.fel.cvut.cz/canbus/pcie-ctu_can_fd . Signed-off-by: Pavel Pisa Signed-off-by: Mar

[PATCH v5 5/6] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.

Platform bus adaptation for CTU CAN FD open-source IP core. The core has been tested together with OpenCores SJA1000 modified to be CAN FD frames tolerant on MicroZed Zynq based MZ_APO education kits designed by Petr Porazil from PiKRON.com company. FPGA design https://gitlab.fel.cvut.cz/canbus

[PATCH 3/3] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()

In _drbd_send_page() a page is checked by following code before sending it by kernel_sendpage(), (page_count(page) < 1) || PageSlab(page) If the check is true, this page won't be send by kernel_sendpage() and handled by sock_no_sendpage(). This kind of check is exactly what macro sendpage_

[PATCH 2/3] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()

Currently nvme_tcp_try_send_data() doesn't use kernel_sendpage() to send slab pages. But for pages allocated by __get_free_pages() without __GFP_COMP, which also have refcount as 0, they are still sent by kernel_sendpage() to remote end, this is problematic. The new introduced helper sendpage_ok()

[PATCH 1/3] net: introduce helper sendpage_ok() in include/linux/net.h

The original problem was from nvme-over-tcp code, who mistakenly uses kernel_sendpage() to send pages allocated by __get_free_pages() without __GFP_COMP flag. Such pages don't have refcount (page_count is 0) on tail pages, sending them by kernel_sendpage() may trigger a kernel panic from a corrupte

[PATCH 2/8] netfilter: nft_compat: remove flush counter optimization

From: Florian Westphal WARNING: CPU: 1 PID: 16059 at lib/refcount.c:31 refcount_warn_saturate+0xdf/0xf [..] __nft_mt_tg_destroy+0x42/0x50 [nft_compat] nft_target_destroy+0x63/0x80 [nft_compat] nf_tables_expr_destroy+0x1b/0x30 [nf_tables] nf_tables_rule_destroy+0x3a/0x70 [nf_tables] nf_tables

[PATCH 8/8] netfilter: ebtables: reject bogus getopt len value

From: Florian Westphal syzkaller reports splat: [ cut here ] Buffer overflow detected (80 < 137)! Call Trace: do_ebt_get_ctl+0x2b4/0x790 net/bridge/netfilter/ebtables.c:2317 nf_getsockopt+0x72/0xd0 net/netfilter/nf_sockopt.c:116 ip_getsockopt net/ipv4/ip_sockglue.c:1778

[PATCH 3/8] netfilter: avoid ipv6 -> nf_defrag_ipv6 module dependency

From: Florian Westphal nf_ct_frag6_gather is part of nf_defrag_ipv6.ko, not ipv6 core. The current use of the netfilter ipv6 stub indirections causes a module dependency between ipv6 and nf_defrag_ipv6. This prevents nf_defrag_ipv6 module from being removed because ipv6 can't be unloaded. Rem

[PATCH 4/8] netfilter: nf_tables: free chain context when BINDING flag is missing

From: Florian Westphal syzbot found a memory leak in nf_tables_addchain() because the chain object is not free'd correctly on error. Fixes: d0e2c7de92c7 ("netfilter: nf_tables: add NFT_CHAIN_BINDING") Reported-by: syzbot+c99868fde67014f7e...@syzkaller.appspotmail.com Signed-off-by: Florian Westp

[PATCH 5/8] selftests: netfilter: add checktool function

From: Fabian Frederick avoid repeating the same test for different toolcheck Signed-off-by: Fabian Frederick Signed-off-by: Pablo Neira Ayuso --- .../selftests/netfilter/nft_flowtable.sh | 33 +++ 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/tools/testi

[PATCH 7/8] selftests: netfilter: kill running process only

From: Fabian Frederick Avoid noise like the following: nft_flowtable.sh: line 250: kill: (4691) - No such process Signed-off-by: Fabian Frederick Signed-off-by: Pablo Neira Ayuso --- tools/testing/selftests/netfilter/nft_flowtable.sh | 10 -- 1 file changed, 8 insertions(+), 2 deletio

[PATCH 0/8] Netfilter fixes for net

Hi, The following patchset contains Netfilter fixes for net: 1) Endianness issue in IPv4 option support in nft_exthdr, from Stephen Suryaputra. 2) Removes the waitcount optimization in nft_compat, from Florian Westphal. 3) Remove ipv6 -> nf_defrag_ipv6 module dependency, from Florian W

[PATCH 1/8] netfilter: nf_tables: nft_exthdr: the presence return value should be little-endian

From: Stephen Suryaputra On big-endian machine, the returned register data when the exthdr is present is not being compared correctly because little-endian is assumed. The function nft_cmp_fast_mask(), called by nft_cmp_fast_eval() and nft_cmp_fast_init(), calls cpu_to_le32(). The following dump

[PATCH 6/8] selftests: netfilter: add MTU arguments to flowtables

From: Fabian Frederick Add some documentation, default values defined in original script and Originator/Link/Responder arguments using getopts like in tools/power/cpupower/bench/cpufreq-bench_plot.sh Signed-off-by: Fabian Frederick Signed-off-by: Pablo Neira Ayuso --- .../selftests/netfilter/

[PATCH v4 3/3] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()

From: Coly Li In _drbd_send_page() a page is checked by following code before sending it by kernel_sendpage(), (page_count(page) < 1) || PageSlab(page) If the check is true, this page won't be send by kernel_sendpage() and handled by sock_no_sendpage(). This kind of check is exactly what

[PATCH v4 1/3] net: introduce helper sendpage_ok() in include/linux/net.h

From: Coly Li The original problem was from nvme-over-tcp code, who mistakenly uses kernel_sendpage() to send pages allocated by __get_free_pages() without __GFP_COMP flag. Such pages don't have refcount (page_count is 0) on tail pages, sending them by kernel_sendpage() may trigger a kernel panic

[PATCH v2 2/3] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()

From: Coly Li Currently nvme_tcp_try_send_data() doesn't use kernel_sendpage() to send slab pages. But for pages allocated by __get_free_pages() without __GFP_COMP, which also have refcount as 0, they are still sent by kernel_sendpage() to remote end, this is problematic. The new introduced help

Re: [PATCH net-next v5] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

Hi Andrew, On Sat, Aug 15, 2020 at 07:53:49PM +0200, Andrew Lunn wrote: > On Sat, Aug 15, 2020 at 06:55:56PM +0200, Clemens Gruber wrote: > > Hi, > > > > this patch / commit f166f890c8 ("net: ethernet: fec: Replace interrupt > > driven MDIO with polled IO") broke networking on i.MX6Q boards with

Re: WARNING: refcount bug in p9_req_put

syzbot suspects this issue was fixed by commit: commit a39c46067c845a8a2d7144836e9468b7f072343e Author: Christoph Hellwig Date: Fri Jul 10 08:57:22 2020 + net/9p: validate fds in p9_fd_open bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1015f01290 start commit: 459

[PATCH 3/4] can: j1939: abort multipacket broadcast session when timeout occurs

From: Zhang Changzhong If timeout occurs, j1939_tp_rxtimer() first calls hrtimer_start() to restart rxtimer, and then calls __j1939_session_cancel() to set session->state = J1939_SESSION_WAITING_ABORT. At next timeout expiration, because of the J1939_SESSION_WAITING_ABORT session state j1939_tp_r

pull-request: can 2020-08-15

speed for broadcast mode (2020-08-14 20:39:33 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-5.9-20200815 for you to fetch changes up to 0ae18a82686f9b9965a8ce0dd81371871b306ffe: can: j1939: add rxtimer for

[PATCH 2/4] can: j1939: cancel rxtimer on multipacket broadcast session complete

From: Zhang Changzhong If j1939_xtp_rx_dat_one() receive last frame of multipacket broadcast message, j1939_session_timers_cancel() should be called to cancel rxtimer. Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") Signed-off-by: Zhang Changzhong Link: https://lore.kernel.org/r

[PATCH 1/4] can: j1939: fix support for multipacket broadcast message

From: Zhang Changzhong Currently j1939_tp_im_involved_anydir() in j1939_tp_recv() check the previously set flags J1939_ECU_LOCAL_DST and J1939_ECU_LOCAL_SRC of incoming skb, thus multipacket broadcast message was aborted by receive side because it may come from remote ECUs and have no exact dst a

[PATCH] netfilter: nf_conntrack_sip: fix parsing error

ct_sip_parse_numerical_param can only return 0 or 1, but the caller is checking parsing error using < 0 Signed-off-by: Tong Zhang --- net/netfilter/nf_conntrack_sip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_connt

Re: [PATCH net] drivers/net/wan/hdlc_x25: Added needed_headroom and a skb->len check

On Fri, Aug 14, 2020 at 8:41 PM David Miller wrote: > > Applied, thanks. Thank you, David!

[PATCH 4/4] can: j1939: add rxtimer for multipacket broadcast session

From: Zhang Changzhong According to SAE J1939/21 (Chapter 5.12.3 and APPENDIX C), for transmit side the required time interval between packets of a multipacket broadcast message is 50 to 200 ms, the responder shall use a timeout of 250ms (provides margin allowing for the maximumm spacing of 200ms

Re: [PATCH] seg6: using DSCP of inner IPv4 packets

Hi David, Sorry for the late reply. I'm on PTO with limited email access. I will revise the patch in the next weeks and make outer IPv6 header inherit Hop limit from Inner packet for the IPv6 case. Ahmed On 08/08/2020 02:43, David Miller wrote: From: Ahmed Abdelsalam Date: Thu, 6 Aug 2020

[GIT PULL] 9p update for 5.9-rc1

Hi Linus, the usual small stuff. Thanks! The following changes since commit 74d6a5d5662975aed7f25952f62efbb6f6dadd29: 9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work (2020-07-19 14:58:47 +0200) are available in the Git repository at: https://github.com/mar

KMSAN: uninit-value in hci_chan_lookup_handle

Hello, syzbot found the following issue on: HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=16c0e1e290 kernel config: https://syzkaller.appspot.com/x/.

memory leak in read_adv_mon_features

Hello, syzbot found the following issue on: HEAD commit:7fca4dee Merge tag 'powerpc-5.9-2' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15ea92a190 kernel config: https://syzkaller.appspot.com/x/.config?x=e320bbff976a5cdc das

[PATCH 1/3] net: lantiq: Wake TX queue again

The call to netif_wake_queue() when the TX descriptors were freed was missing. When there are no TX buffers available the TX queue will be stopped, but it was not started again when they are available again, this is fixed in this patch. Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200

Re: [PATCH v2] net: openvswitch: introduce common code for flushing flows

On Sat, Aug 15, 2020 at 3:28 AM Johan Knöös wrote: > > On Thu, Aug 13, 2020 at 3:53 PM David Miller wrote: > > > > From: xiangxia.m@gmail.com > > Date: Wed, 12 Aug 2020 17:56:39 +0800 > > > > > From: Tonghao Zhang > > > > > > To avoid some issues, for example RCU usage warning and double fre

Re: [PATCH net 0/3] ethtool-netlink bug fixes

From: Florian Fainelli Date: Fri, 14 Aug 2020 07:58:29 -0700 > > > On 8/14/2020 6:16 AM, Maxim Mikityanskiy wrote: >> This series contains a few bug fixes for ethtool-netlink. These bugs >> are >> specific for the netlink interface, and the legacy ioctl interface is >> not affected. These patch

[Patch net] bonding: fix a potential double-unregister

When we tear down a network namespace, we unregister all the netdevices within it. So we may queue a slave device and a bonding device together in the same unregister queue. If the only slave device is non-ethernet, it would automatically unregister the bonding device as well. Thus, we may end up

Re: [PATCH net] drivers/net/wan/hdlc_x25: Added needed_headroom and a skb->len check

From: Xie He Date: Thu, 13 Aug 2020 11:17:04 -0700 > 1. Added a skb->len check > > This driver expects upper layers to include a pseudo header of 1 byte > when passing down a skb for transmission. This driver will read this > 1-byte header. This patch added a skb->len check before reading the >

Re: [PATCH net v2] bonding: show saner speed for broadcast mode

From: Jarod Wilson Date: Thu, 13 Aug 2020 10:09:00 -0400 > Broadcast mode bonds transmit a copy of all traffic simultaneously out of > all interfaces, so the "speed" of the bond isn't really the aggregate of > all interfaces, but rather, the speed of the slowest active interface. > > Also, the t

[PATCH 2/3] net: lantiq: use netif_tx_napi_add() for TX NAPI

netif_tx_napi_add() should be used for NAPI in the TX direction instead of the netif_napi_add() function. Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver") Signed-off-by: Hauke Mehrtens --- drivers/net/ethernet/lantiq_xrx200.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 3/3] net: lantiq: Use napi_complete_done()

Use napi_complete_done() and activate the interrupts when this function returns true. This way the generic NAPI code can take care of activating the interrupts. Signed-off-by: Hauke Mehrtens --- drivers/net/ethernet/lantiq_xrx200.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) d

[PATCH] Bluetooth: Only mark socket zapped after unlocking

Since l2cap_sock_teardown_cb doesn't acquire the channel lock before setting the socket as zapped, it could potentially race with l2cap_sock_release which frees the socket. Thus, wait until the cleanup is complete before marking the socket as zapped. This race was reproduced on a JBL GO speaker af

RE: sctp: num_ostreams and max_instreams negotiation

From: David Laight > Sent: 14 August 2020 17:18 > > > > > At some point the negotiation of the number of SCTP streams > > > > seems to have got broken. > > > > I've definitely tested it in the past (probably 10 years ago!) > > > > but on a 5.8.0 kernel getsockopt(SCTP_INFO) seems to be > > > > ret

Re: [PATCH net-next v5] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

Hi, this patch / commit f166f890c8 ("net: ethernet: fec: Replace interrupt driven MDIO with polled IO") broke networking on i.MX6Q boards with Marvell 88E1510 PHYs (Copper / 1000Base-T). Reverting said commit fixes the problem. We also reverted 7cdaa4cc4b ("net: ethernet: fec: prevent tx starvat

[PATCH 2/2] net: socket: implement SO_DESCRIPTION

This command attaches the zero terminated string in optval to the socket for troubleshooting purposes. The free string is displayed in the process fdinfo file for that fd (/proc//fdinfo/). One intended usage is to allow processes to self-document sockets for netstat and friends to report We ignor

Hello

Hello My name is Jenifer Alex Please reply, so that we can know more better and share photos, Thank you.

[PATCH 1/2] mm: add GFP mask param to strndup_user

Let caller specify allocation. Preserve existing calls with GFP_USER. Signed-off-by: Pascal Bouchareine --- drivers/dma-buf/dma-buf.c | 2 +- drivers/gpu/drm/i915/i915_debugfs_params.c | 2 +- drivers/gpu/drm/vc4/vc4_bo.c | 3 +- drivers/input/misc/uinput.c

Alternate location for skb_shared_info other than the tail?

Hi all, We have an Ethernet controller that is capable of putting several Ethernet frames within a single 4KB buffer provided by Linux. The rationale for this design is to maximize the DRAM efficiency, especially for LPDDR4/5 architectures where the cost to keep a page open is higher than say

[RFC PATCH 0/2] proc,socket: attach description to sockets

Checking to see if this could fit in struct sock. This goes against v5.8 I tried to make it tl;dr in commit 2/2 but motivation is also described a bit in https://lore.kernel.org/linux-api/CAGbU3_nVvuzMn2wo4_ZKufWcGfmGsopVujzTWw-Bbeky=xs...@mail.gmail.com/

[PATCH v5 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

From: Pavel Pisa This driver adds support for the CTU CAN FD open-source IP core. More documentation and core sources at project page (https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core). The core integration to Xilinx Zynq system as platform driver is available (https://gitlab.fel.cvut.cz/canbus

Re: [PATCH net-next v5] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

On Sat, Aug 15, 2020 at 06:55:56PM +0200, Clemens Gruber wrote: > Hi, > > this patch / commit f166f890c8 ("net: ethernet: fec: Replace interrupt > driven MDIO with polled IO") broke networking on i.MX6Q boards with > Marvell 88E1510 PHYs (Copper / 1000Base-T). Hi Clemens Please could you try: h

[RFT] net: fec: Fix MDIO polled IO

Hi, this patch fixes the problem on our i.MX6Q boards with Marvell 88E1510 PHYs (1000Base-T). Tested-by: Clemens Gruber Thanks, Clemens