On Wed, 29 Jul 2020 08:14:49 +0200
Dominique Martinet wrote:
> Greg Kurz wrote on Tue, Jul 28, 2020:
> > > The "fd" transport layer uses 2 file descriptors passed externally
> > > and calls kernel_write()/kernel_read() on these. If files were opened
> > > without FMODE_WRITE/FMODE_READ, WARN_ON_O
On Tue, 2020-07-28 at 14:47 -0700, Jakub Kicinski wrote:
> Allocate nic_info dynamically - n_entries is not constant.
>
> Attach the tunnel offload info only to the uplink representor.
> We expect the "main" netdev to be unregistered in switchdev
> mode, and there to be only one uplink representor
On Tue, 2020-07-28 at 14:46 -0700, Jakub Kicinski wrote:
> Allocate nic_info dynamically - n_entries is not constant.
>
> Attach the tunnel offload info only to the uplink representor.
> We expect the "main" netdev to be unregistered in switchdev
> mode, and there to be only one uplink representor
On Tue, 2020-07-28 at 14:46 -0700, Jakub Kicinski wrote:
> This set converts mlx5 to the new infrastructure.
>
> We need a small amount of special handling as mlx5 expects IANA VXLAN
> port to always be programmed into the device. ethtool will show such
> ports in a separate, type-less, fake table
On Wed, 2020-07-29 at 09:17 +0300, Or Gerlitz wrote:
> On Tue, Jul 28, 2020 at 11:07 PM Saeed Mahameed
> wrote:
> > When setting the PF interface up/down, notify the firmware to
> > update
> > uplink state via MODIFY_VPORT_STATE, when E-Switch is enabled.
> > This behavior will prevent sending tra
Sorry for the late request, I took some time to fix my test setup and to
be convinced these two patches are worth sending now and not wait until
the next merge window.
(the "weird" -2 at the end of the tag is because I had already used
9p-for-5.8 for the original -rc1 pull)
The following changes
On 27 Jul 2020, at 16:53, Jiri Olsa wrote:
On Mon, Jul 27, 2020 at 09:59:14AM +0200, Eelco Chaudron wrote:
On 26 Jul 2020, at 14:24, Jiri Olsa wrote:
On Tue, Jun 09, 2020 at 10:52:34AM +0200, Eelco Chaudron wrote:
SNIP
libbpf: failed to load object 'test_xdp_bpf2bpf'
libbpf: fai
> -邮件原件-
> 发件人: Jakub Kicinski [mailto:k...@kernel.org]
> 发送时间: 2020年7月29日 4:14
> 收件人: Tony Nguyen
> 抄送: da...@davemloft.net; Li,Rongqing ;
> netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com;
> jeffrey.t.kirs...@intel.com; Andrew Bowers
> 主题: Re: [net-next 2/6] i40e: pref
On Tue, Jul 28, 2020 at 11:07 PM Saeed Mahameed wrote:
> When setting the PF interface up/down, notify the firmware to update
> uplink state via MODIFY_VPORT_STATE, when E-Switch is enabled.
> This behavior will prevent sending traffic out on uplink port when PF is
> down, such as sending traffic
Summary: 802.1Q-Header lost on KSZ9477-DSA ingress without bridge
Keywords: networking, dsa, microchip, 802.1q, vlan
Full description:
Hello,
we're trying to get 802.1Q-Tagged Ethernet Frames through an KSZ9477
DSA-enabled switch without creating a bridge on the kernel side.
Following setup:
Swit
On Tue, Jul 28, 2020 at 10:47 PM Song Liu wrote:
>
> On Tue, Jul 28, 2020 at 9:54 PM Andrii Nakryiko wrote:
> >
> > Check that link is NULL or proper pointer before invoking
> > bpf_link__destroy().
> > Not doing this causes crash in test_progs, when cg_storage_multi selftest
> > fails.
> >
> >
Greg Kurz wrote on Tue, Jul 28, 2020:
> > The "fd" transport layer uses 2 file descriptors passed externally
> > and calls kernel_write()/kernel_read() on these. If files were opened
> > without FMODE_WRITE/FMODE_READ, WARN_ON_ONCE() will fire.
There already is a fix in linux-next as a39c46067c84
On Tue, Jul 28, 2020 at 5:31 PM Stanislav Fomichev wrote:
>
> Augment udp_limit test to set and verify socket storage value.
> That should be enough to exercise the changes from the previous
> patch.
>
> Cc: Martin KaFai Lau
> Signed-off-by: Stanislav Fomichev
Acked-by: Song Liu
On Tue, Jul 28, 2020 at 5:31 PM Stanislav Fomichev wrote:
>
> This lets us use socket storage from the following hooks:
> * BPF_CGROUP_INET_SOCK_CREATE
> * BPF_CGROUP_INET_SOCK_RELEASE
> * BPF_CGROUP_INET4_POST_BIND
> * BPF_CGROUP_INET6_POST_BIND
>
> Using existing 'bpf_sk_storage_get_proto' doesn
>
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
>
On Tue, Jul 28, 2020 at 01:01:11PM -0700, David Miller wrote:
> From: Christoph Hellwig
> Date: Tue, 28 Jul 2020 08:36:43 +0200
>
> > if (get_user(len, optlen))
> > return -EFAULT;
> ^^
> > - err = init_user_sockptr(&optval, user_optval);
> > +
Hello,
syzbot found the following issue on:
HEAD commit:181964e6 fix a braino in cmsghdr_from_user_compat_to_kern()
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=12925e3890
kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267
dashboard
On Tue, Jul 28, 2020 at 9:54 PM Andrii Nakryiko wrote:
>
> Check that link is NULL or proper pointer before invoking bpf_link__destroy().
> Not doing this causes crash in test_progs, when cg_storage_multi selftest
> fails.
>
> Cc: YiFei Zhu
> Fixes: 3573f384014f ("selftests/bpf: Test CGROUP_STORA
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I includ
Hello,
I know that I should ask for reviews etc after a week but the change
is for my eudyptula task and until it doesn't get merged little
penguin will not pass the task for me so please look at it.
Thank You
Dhiraj Sharma
On Tue, Jul 28, 2020 at 11:56 PM Dhiraj Sharma
wrote:
>
> Inside func
On Tue, Jul 28, 2020 at 1:57 PM David Ahern wrote:
>
> On 7/28/20 12:28 PM, Andrii Nakryiko wrote:
> > In some, yes, which also means that in some other they can't. So I'm
> > still worried about misuses of REALCLOCK, within (internal daemons
> > within the company) our outside (BCC tools and alik
On Tue, Jul 28, 2020 at 1:00 PM Nikravesh, Ashkan
wrote:
>
>
>
>
> From: Andrii Nakryiko
> Sent: Tuesday, July 28, 2020 11:28 AM
> To: Maciej Żenczykowski
> Cc: Pujari, Bimmy ; bpf ;
> Networking ; mche...@kernel.org ;
> Alexei Starovoitov ; Daniel Borkmann ;
Check that link is NULL or proper pointer before invoking bpf_link__destroy().
Not doing this causes crash in test_progs, when cg_storage_multi selftest
fails.
Cc: YiFei Zhu
Fixes: 3573f384014f ("selftests/bpf: Test CGROUP_STORAGE behavior on shared
egress + ingress")
Signed-off-by: Andrii Nakry
Add test validating that all inner maps are released properly after skeleton
is destroyed. To ensure determinism, trigger kernel-side synchronize_rcu()
before checking map existence by their IDs.
Acked-by: Song Liu
Signed-off-by: Andrii Nakryiko
---
.../selftests/bpf/prog_tests/btf_map_in_map.c
Fix HASH_OF_MAPS bug of not putting inner map pointer on bpf_map_elem_update()
operation. This is due to per-cpu extra_elems optimization, which bypassed
free_htab_elem() logic doing proper clean ups. Make sure that inner map is put
properly in optimized case as well.
Fixes: 8c290e60fa2a ("bpf: fi
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
lib/Kconfig
between commit:
1a479f783857 ("lib: Add a generic version of devmem_is_allowed()")
from the risc-v tree and commit:
b8265621f488 ("Add pldmfw library for PLDM firmware update")
from the net-next tree.
On 7/28/2020 7:53 PM, Jeremy Linton wrote:
> Hi,
>
> On 7/28/20 7:39 PM, Florian Fainelli wrote:
>> On 7/28/2020 3:30 PM, Jeremy Linton wrote:
>>> Hi,
>>>
>>> On 7/28/20 3:06 AM, Dan Callaghan wrote:
Excerpts from Andrew Lunn's message of 2020-07-24 21:14:36 +02:00:
> Now i could be wr
If some processes in nixge_probe() fail, free_netdev(dev)
needs to be called to aviod a memory leak.
Fixes: 87ab207981ec ("net: nixge: Separate ctrl and dma resources")
Fixes: abcd3d6fc640 ("net: nixge: Fix error path for obtaining mac address")
Reported-by: Hulk Robot
Signed-off-by: Lu Wei
---
If some processes in gemini_ethernet_port_probe() fail,
free_netdev(dev) needs to be called to avoid a memory leak.
Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
Reported-by: Hulk Robot
Signed-off-by: Lu Wei
---
drivers/net/ethernet/cortina/gemini.c | 24 ++
Hi,
On 7/28/20 7:39 PM, Florian Fainelli wrote:
On 7/28/2020 3:30 PM, Jeremy Linton wrote:
Hi,
On 7/28/20 3:06 AM, Dan Callaghan wrote:
Excerpts from Andrew Lunn's message of 2020-07-24 21:14:36 +02:00:
Now i could be wrong, but are Ethernet switches something you expect
to see on ACPI/SBSA
Remove duplicated include.
Signed-off-by: YueHaibing
---
drivers/net/ethernet/sfc/ef100_netdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/ef100_netdev.c
b/drivers/net/ethernet/sfc/ef100_netdev.c
index 4c3caac2c8cc..ec9ca81fed85 100644
--- a/drivers/net/etherne
Add the controller suspend and resume events, which will signal when
Bluetooth has completed preparing for suspend and when it's ready for
resume.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
Reviewed-by: Sonny Sasaka
---
include/net/bluetooth/hci_core.h | 3 +++
include
Update device disconnect event with reason 0x5 to indicate that device
disconnected because the controller is suspending.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
Reviewed-by: Sonny Sasaka
---
include/net/bluetooth/mgmt.h | 1 +
net/bluetooth/mgmt.c | 4
Emit controller suspend and resume events when we are ready for suspend
and we've resumed from suspend.
The controller suspend event will report whatever suspend state was
successfully entered. The controller resume event will check the first
HCI event that was received after we finished preparing
Hi Marcel,
This series adds the suspend/resume events suggested in
https://patchwork.kernel.org/patch/11663455/.
I have tested it with some userspace changes that monitors the
controller resumed event to trigger audio device reconnection and
verified that the events are correctly emitted.
Plea
Thank you for your detailed review, Brian!
I guess we have the same understanding on the "hard_header_len vs
needed_headroom" part. I agree it is not well documented and is also
confusing to driver developers. I didn't understand it either until I
looked at af_packet.c.
On Tue, Jul 28, 2020 at 12
On Tue, Jul 28, 2020 at 05:44:19PM -0700, John Fastabend wrote:
> Martin KaFai Lau wrote:
> > On Tue, Jul 28, 2020 at 01:55:22PM -0700, John Fastabend wrote:
> > > Martin KaFai Lau wrote:
> > > > On Tue, Jul 28, 2020 at 08:43:46AM -0700, John Fastabend wrote:
> > > > > I had a sockmap program that
add support to generate mailbox random id for VF to ensure that
the mailbox message from VF is valid and PF should check whether
the cmd from VF is supported before passing it to hw.
Signed-off-by: Luo bin
---
.../net/ethernet/huawei/hinic/hinic_hw_cmdq.h | 8 +
.../net/ethernet/huawei/hinic/h
From: Martin Varghese
Date: Tue, 28 Jul 2020 22:35:52 +0530
> From: Martin Varghese
>
> Removed redundant words.
>
> Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling
> different protocols like MPLS, IP, NSH etc.")
> Signed-off-by: Martin Varghese
Applied, thank you.
Hello David and all,
I hope this is the correct way to report a bug.
I observed this problem with 256 v4 next-hops or 128 v6 next-hops (or
128 or so # of v4 next-hops with labels).
Here is an example -
root@a6be8c892bb7:/# ip route show 2.2.2.2
Error: Buffer too small for object.
Dump terminate
From: Jisheng Zhang
Date: Mon, 27 Jul 2020 19:53:14 +0800
> @@ -3651,7 +3651,8 @@ static void mvneta_stop_dev(struct mvneta_port *pp)
>
> set_bit(__MVNETA_DOWN, &pp->state);
>
> - if (device_may_wakeup(&pp->dev->dev))
> + if (device_may_wakeup(&pp->dev->dev) &&
> + pp->p
From: Jisheng Zhang
Date: Mon, 27 Jul 2020 19:01:07 +0800
> Currently, stmmac driver relies on the HW PMT to support WOL. We want
> to support phy based WOL.
>
> patch1 is a small improvement to disable WAKE_MAGIC for PMT case if
> no pmt_magic_frame.
> patch2 and patch3 are two prepation patche
From: Kurt Kanzenbach
Date: Mon, 27 Jul 2020 11:05:52 +0200
> in order to reduce code duplication in the ptp code of DSA, Ethernet and Phy
> drivers, move the header parsing function to ptp_classify. This way all
> drivers
> can share the same implementation. Implemented as discussed [1] [2] [3]
Martin KaFai Lau wrote:
> On Tue, Jul 28, 2020 at 01:55:22PM -0700, John Fastabend wrote:
> > Martin KaFai Lau wrote:
> > > On Tue, Jul 28, 2020 at 08:43:46AM -0700, John Fastabend wrote:
> > > > I had a sockmap program that after doing some refactoring started
> > > > spewing
> > > > this splat a
From: Linus Walleij
Date: Mon, 27 Jul 2020 01:34:38 +0200
> While we are pondering how to make the core set up the VLANs
> the right way, let's merge the uncontroversial fixes.
Series applied, thanks.
From: Brian Vazquez
Date: Sun, 26 Jul 2020 15:48:16 -0700
> This avoids another inderect call per RX packet which save us around
> 20-40 ns.
>
> Changelog:
>
> v1 -> v2:
> - Move declaraions to fib_rules.h to remove warnings
>
> Reported-by: kernel test robot
> Signed-off-by: Brian Vazquez
On 7/28/2020 5:39 PM, David Miller wrote:
> From: Calvin Johnson
> Date: Sat, 25 Jul 2020 19:53:58 +0530
>
>> This patch series provides ACPI support for dpaa2 MAC driver.
>> This also introduces ACPI mechanism to get PHYs registered on a
>> MDIO bus and provide them to be connected to MAC.
From: Cong Wang
Date: Sat, 25 Jul 2020 13:17:07 -0700
> When red_init() fails, red_destroy() is called to clean up.
> If the timer is not initialized yet, del_timer_sync() will
> complain. So we have to move timer_setup() before any failure.
>
> Reported-and-tested-by: syzbot+6e95a4fabf88dc217..
On 7/28/2020 3:30 PM, Jeremy Linton wrote:
> Hi,
>
> On 7/28/20 3:06 AM, Dan Callaghan wrote:
>> Excerpts from Andrew Lunn's message of 2020-07-24 21:14:36 +02:00:
>>> Now i could be wrong, but are Ethernet switches something you expect
>>> to see on ACPI/SBSA platforms? Or is this a legitimate us
From: Calvin Johnson
Date: Sat, 25 Jul 2020 19:53:58 +0530
> This patch series provides ACPI support for dpaa2 MAC driver.
> This also introduces ACPI mechanism to get PHYs registered on a
> MDIO bus and provide them to be connected to MAC.
>
> Previous discussions on this patchset is availa
From: B K Karthik
Date: Sun, 26 Jul 2020 08:38:55 +0530
> @@ -103,10 +103,10 @@ static int __xfrm6_tunnel_spi_check(struct net *net,
> u32 spi)
> {
> struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net);
> struct xfrm6_tunnel_spi *x6spi;
> - int index = xfrm6_tunnel_spi_
On 7/28/2020 5:28 PM, Doug Berger wrote:
> On 7/28/2020 9:28 AM, Ioana Ciornei wrote:
>>> Subject: Re: [PATCH RFC net-next 0/3] Restructure drivers/net/phy
>>>
I think that the MAINTAINERS file should also be updated to mention
the new path to the drivers. Just did a quick grep after '
From: B K Karthik
Date: Sat, 25 Jul 2020 19:00:31 +0530
> use spi_byaddr instead of spi_byspi
...
> diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c
> index 25b7ebda2fab..cab7693ccfe3 100644
> --- a/net/ipv6/xfrm6_tunnel.c
> +++ b/net/ipv6/xfrm6_tunnel.c
> @@ -103,10 +103,10 @@ sta
On 7/28/20 4:41 PM, Casey Schaufler wrote:
> On 7/28/2020 4:11 AM, John Johansen wrote:
>> On 7/24/20 1:32 PM, Casey Schaufler wrote:
>>> Change security_secctx_to_secid() to fill in a lsmblob instead
>>> of a u32 secid. Multiple LSMs may be able to interpret the
>>> string, and this allows for set
From: Guillaume Nault
Date: Sat, 25 Jul 2020 15:06:47 +0200
> In multiproto mode, bareudp_xmit() accepts sending multicast MPLS and
> IPv6 packets regardless of the bareudp ethertype. In practice, this
> let an IP tunnel send multicast MPLS packets, or an MPLS tunnel send
> IPv6 packets.
>
> We
From: B K Karthik
Date: Sat, 25 Jul 2020 18:15:53 +0530
> fix slab-out-of-bounds Read in xfrm6_tunnel_alloc_spi
> by checking for existance of head for the list spi_byspi
spi_byspi is an array, therefore as long as xfrm6_tn is not NULL
then spi_byspi will also not be NULL.
On 7/28/2020 9:28 AM, Ioana Ciornei wrote:
>> Subject: Re: [PATCH RFC net-next 0/3] Restructure drivers/net/phy
>>
>>> I think that the MAINTAINERS file should also be updated to mention
>>> the new path to the drivers. Just did a quick grep after 'drivers/net/phy':
>>> F: drivers/net/phy/adin
From: Xiyu Yang
Date: Sat, 25 Jul 2020 16:02:18 +0800
> ip6_route_info_create() invokes nexthop_get(), which increases the
> refcount of the "nh".
>
> When ip6_route_info_create() returns, local variable "nh" becomes
> invalid, so the refcount should be decreased to keep refcount balanced.
>
>
From: Luo bin
Date: Sat, 25 Jul 2020 15:11:17 +0800
> patch #1: support to handle hw abnormal event
> patch #2: improve the error messages when functions return failure and
> dump relevant registers in some exception handling processes
Series applied, thanks.
From: Herbert Xu
Date: Sat, 25 Jul 2020 16:20:34 +1000
> I think this patch belongs to the networking tree. The reason is
> that it's related to xfrm offload which has nothing to do with the
> Crypto API.
>
> Do xfrm offload drivers usually go through the networking tree or
> would it be better
From: sundeep.l...@gmail.com
Date: Sat, 25 Jul 2020 10:13:51 +0530
> From: Subbaraya Sundeep
>
> Hi,
>
> There are problems in the existing Octeontx2
> netdev drivers like missing cancel_work for the
> reset task, missing lock in reset task and
> missing unergister_netdev in driver remove.
> Th
From: Jakub Kicinski
Date: Fri, 24 Jul 2020 16:15:43 -0700
> It appears that not disabling a PCI device on .shutdown may lead to
> a Hardware Error with particular (perhaps buggy) BIOS versions:
...
> Fix the mlx4 driver.
>
> This is a very similar problem to what had been fixed in:
> commit 0d
From: Herbert Xu
Date: Fri, 24 Jul 2020 20:12:20 +1000
> This patch series fixes an unprotected dereference in __rht_ptr.
> The first patch is a minimal fix that does not use the correct
> RCU markings but is suitable for backport, and the second patch
> cleans up the RCU markings.
Series applie
From: Jacob Keller
Date: Thu, 23 Jul 2020 17:21:58 -0700
> This series goal is to enable support for updating the ice hardware flash
> using the devlink flash command.
>
> The ice firmware update files are distributed using the file format
> described by the "PLDM for Firmware Update" standard:
From: David Woodhouse
Date: Thu, 23 Jul 2020 20:07:10 +0100
> From: René van Dorst
>
> Modify mtk_gmac0_rgmii_adjust() so it can always be called.
> mtk_gmac0_rgmii_adjust() sets-up the TRGMII clocks.
>
> Signed-off-by: René van Dorst
> Signed-off-By: David Woodhouse
> Tested-by: Frank Wunde
From: we...@ucloud.cn
Date: Tue, 21 Jul 2020 11:09:52 +0800
> From: wenxu
>
> When openvswitch conntrack offload with act_ct action. Fragment packets
> defrag in the ingress tc act_ct action and miss the next chain. Then the
> packet pass to the openvswitch datapath without the mru. The defrag o
From: Mat Martineau
Date: Tue, 28 Jul 2020 15:11:58 -0700
> This series allows the MPTCP-level connection to be closed with the
> peers exchanging DATA_FIN and DATA_ACK according to the state machine in
> appendix D of RFC 8684. The process is very similar to the TCP
> disconnect state machine.
From: Saeed Mahameed
Date: Tue, 28 Jul 2020 12:59:24 -0700
> This series introduces some fixes to mlx5 driver.
> v1->v2:
> - Drop the "Hold reference on mirred devices" patch, until Or's
>comments are addressed.
> - Imporve "Modify uplink state" patch commit message per Or's request.
>
> P
From: David Howells
Date: Wed, 29 Jul 2020 00:21:47 +0100
> Should I just rebase the net-next patches on top of the one I sent you once
> you've picked it into net, or is there a better way?
Post the patch for 'net', wait for 'net' to merge into 'net-next' (usually
once a week or so), and then s
On 29/07/2020 03:42, Greg Kurz wrote:
> Hi Alexey,
>
> Working on 9p now ?!? ;-)
No, I am running syzkaller and seeing things :)
> Cc'ing Dominique Martinet who appears to be the person who takes care of 9p
> these days.
>
> On Tue, 28 Jul 2020 22:41:29 +1000
> Alexey Kardashevskiy wrote:
Hello Rob,
On Saturday 04 of January 2020 00:53:59 Rob Herring wrote:
> On Sat, Dec 21, 2019 at 03:07:31PM +0100, p...@cmp.felk.cvut.cz wrote:
> > From: Pavel Pisa
> >
> > Signed-off-by: Pavel Pisa
> > ---
> > .../devicetree/bindings/net/can/ctu,ctucanfd.txt | 61
> > ++ 1
On 7/28/2020 4:11 AM, John Johansen wrote:
> On 7/24/20 1:32 PM, Casey Schaufler wrote:
>> Change security_secctx_to_secid() to fill in a lsmblob instead
>> of a u32 secid. Multiple LSMs may be able to interpret the
>> string, and this allows for setting whichever secid is
>> appropriate. Change se
On Tue, Jul 28, 2020 at 02:01:16PM -0700, Jonathan Lemon wrote:
> On Tue, Jul 28, 2020 at 03:19:04PM -0300, Jason Gunthorpe wrote:
> > On Mon, Jul 27, 2020 at 06:48:12PM -0700, Jonathan Lemon wrote:
> >
> > > While the current GPU utilized is nvidia, there's nothing in the rest of
> > > the patche
On Wed, Jul 22, 2020 at 2:13 PM Jiri Olsa wrote:
>
> Adding btf_struct_ids_match function to check if given address provided
> by BTF object + offset is also address of another nested BTF object.
>
> This allows to pass an argument to helper, which is defined via parent
> BTF object + offset, like
On Wed, Jul 22, 2020 at 2:13 PM Jiri Olsa wrote:
>
> Adding btf_struct_walk function that walks through the
> struct type + given offset and returns following values:
>
> enum walk_return {
>/* < 0 error */
>walk_scalar = 0,
>walk_ptr,
>walk_struct,
> };
>
> wal
Hi Dave,
In the fix I just posted, subject:
[PATCH net] rxrpc: Fix race between recvmsg and sendmsg on immediate
call failure
there's a change I need to make as part of the patch:
- spin_lock_bh(&conn->params.peer->lock);
- hlist_del_rcu(&call
On 7/28/2020 4:15 PM, Jakub Kicinski wrote:
> Number of .dumpit functions try to ignore -EOPNOTSUPP errors.
> Recent change missed that, and started reporting all errors
> but -EMSGSIZE back from dumps. This leads to situation like
> this:
>
> $ devlink dev info
> devlink answers: Operation not
Number of .dumpit functions try to ignore -EOPNOTSUPP errors.
Recent change missed that, and started reporting all errors
but -EMSGSIZE back from dumps. This leads to situation like
this:
$ devlink dev info
devlink answers: Operation not supported
Dump should not report an error just because the
There's a race between rxrpc_sendmsg setting up a call, but then failing to
send anything on it due to an error, and recvmsg() seeing the call
completion occur and trying to return the state to the user.
An assertion fails in rxrpc_recvmsg() because the call has already been
released from the sock
On 7/28/2020 10:09 AM, Jakub Kicinski wrote:
> On Tue, 28 Jul 2020 09:58:44 -0700 Jacob Keller wrote:
>> On 7/28/2020 4:19 AM, Jiri Pirko wrote:
>>> Yes. Documentation is very easy to ignore unfortunatelly. The driver
>>> developer has to be tight up by the core code and api, I believe.
>>
>> So
For additional robustness in the face of Hyper-V errors or malicious
behavior, validate all values that originate from packets that Hyper-V
has sent to the guest in the host-to-guest ring buffer. Ensure that
invalid values cannot cause indexing off the end of an array, or
subvert an existing valida
On 7/28/20 9:05 PM, Andrii Nakryiko wrote:
Entire net/core subsystem is not built without CONFIG_NET. linux/netdevice.h
just assumes that it's always there, so the easiest way to fix this is to
conditionally compile out bpf_xdp_link_attach() use in bpf/syscall.c.
Reported-by: Randy Dunlap
Fixes
Hi,
On 7/28/20 3:06 AM, Dan Callaghan wrote:
Excerpts from Andrew Lunn's message of 2020-07-24 21:14:36 +02:00:
Now i could be wrong, but are Ethernet switches something you expect
to see on ACPI/SBSA platforms? Or is this a legitimate use of the
escape hatch?
As an extra data point: right no
On 7/28/20 4:39 PM, John Fastabend wrote:
Using localhost requires the host to have a /etc/hosts file with that
specific line in it. By default my dev box did not, they used
ip6-localhost, so the test was failing. To fix remove the need for any
/etc/hosts and use ::1.
I could just add the line,
mptcp_close() acquires the msk lock, so it clearly should not be held
before the function is called.
Signed-off-by: Mat Martineau
---
net/mptcp/protocol.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index b3c3dbc89b3f..7d7e0fa17219 100644
--- a/
The MPTCP socket's write_seq member should be read with READ_ONCE() when
the msk lock is not held.
Signed-off-by: Mat Martineau
---
net/mptcp/protocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index f264ea15e081..f2455a68d23
RFC 8684-compliant DATA_FIN needs to be sent and ack'd before subflows
are closed with TCP FIN, so write DATA_FIN DSS headers whenever their
transmission has been enabled by the MPTCP connection-level socket.
Signed-off-by: Mat Martineau
---
net/mptcp/options.c | 13 +++--
1 file changed
Bare TCP ack skbs are freed right after MPTCP sees them, so the work to
allocate, zero, and populate the MPTCP skb extension is wasted. Detect
these skbs and do not add skb extensions to them.
Signed-off-by: Mat Martineau
---
net/mptcp/options.c | 9 ++---
1 file changed, 6 insertions(+), 3
Since DATA_FIN information is the same for every subflow, store it only
in the mptcp_sock.
Signed-off-by: Mat Martineau
---
net/mptcp/options.c | 18 --
net/mptcp/protocol.c | 21 +
net/mptcp/protocol.h | 3 +--
3 files changed, 18 insertions(+), 24 deletion
RFC 8684 appendix D describes the connection state machine for
MPTCP. This patch implements the DATA_FIN / DATA_ACK exchanges and
MPTCP-level socket state changes described in that appendix, rather than
simply sending DATA_FIN along with TCP FIN when disconnecting subflows.
DATA_FIN is now sent an
The MPTCP socket's write_seq member can be read without the msk lock
held, so use WRITE_ONCE() to store it.
Signed-off-by: Mat Martineau
---
net/mptcp/protocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index f2455a68d231..68
After DATA_FIN has been sent, the peer will acknowledge it. An ack of
the relevant MPTCP-level sequence number will update the MPTCP
connection state appropriately.
Signed-off-by: Mat Martineau
---
net/mptcp/protocol.c | 54 +---
1 file changed, 46 inserti
Incoming DATA_FIN headers need to propagate the presence of the DATA_FIN
bit and the associated sequence number to the MPTCP layer, even when
arriving on a bare ACK that does not get added to the receive queue. Add
structure members to store the DATA_FIN information and helpers to set
and check tho
A MPTCP socket where sending has been shut down should not attempt to
send additional data, since DATA_FIN has already been sent.
Signed-off-by: Mat Martineau
---
net/mptcp/protocol.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 2891a
This series allows the MPTCP-level connection to be closed with the
peers exchanging DATA_FIN and DATA_ACK according to the state machine in
appendix D of RFC 8684. The process is very similar to the TCP
disconnect state machine.
The prior code sends DATA_FIN only when TCP FIN packets are sent, a
This will be used to transition to the appropriate state on close and
determine if a DATA_FIN needs to be sent for that state transition.
Signed-off-by: Mat Martineau
---
net/mptcp/protocol.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/net/mptcp/protocol.c b/
The MPTCP state machine handles disconnections on non-fallback connections,
but the mptcp_sock still needs to get notified when fallback subflows
disconnect.
Signed-off-by: Mat Martineau
---
net/mptcp/subflow.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/mptcp/subfl
On 7/24/20 7:35 PM, Maciej Fijalkowski wrote:
This commit serves two things:
1) it optimizes BPF prologue/epilogue generation
2) it makes possible to have tailcalls within BPF subprogram
Both points are related to each other since without 1), 2) could not be
achieved.
[...]
diff --git a/kerne
On Tue, 28 Jul 2020 14:46:04 -0700 Jakub Kicinski wrote:
> v2: - don't disable the offload on reprs in patch #2.
Oouf, I missed amending the commit, sending v3 with a missing include.
Sorry for the noise :(
This set converts mlx5 to the new infrastructure.
We need a small amount of special handling as mlx5 expects IANA VXLAN
port to always be programmed into the device. ethtool will show such
ports in a separate, type-less, fake table, at the end:
Tunnel information for eth0:
UDP port table 0:
1 - 100 of 443 matches
Mail list logo
