Re: [PATCH,v2] ipvs: fix the connection sync failed in some cases

2020-07-18 Thread Julian Anastasov
Hello, On Thu, 16 Jul 2020, guodeqing wrote: > The sync_thread_backup only checks sk_receive_queue is empty or not, > there is a situation which cannot sync the connection entries when > sk_receive_queue is empty and sk_rmem_alloc is larger than sk_rcvbuf, > the sync packets are dropped

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-18 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sriram-Krishnan/AF_PACKET-doesnt-strip-VLAN-information/20200718-172707 base: https://github.com/hnaz/linux-mm master config: s390-randconfig-s03

Re: [Intel-wired-lan] [PATCH] igc: Do not use link uninitialized in igc_check_for_copper_link

2020-07-18 Thread Neftin, Sasha
On 7/17/2020 05:12, Nathan Chancellor wrote: On Thu, Jul 16, 2020 at 07:29:03PM +0300, Neftin, Sasha wrote: On 7/16/2020 07:49, Nathan Chancellor wrote: Clang warns: Hello Nathan, Thanks for tracking our code.Please, look at https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200709

Re: [PATCH] libbpf bpf_helpers: Use __builtin_offsetof for offsetof if available

2020-07-18 Thread Andrii Nakryiko
On Fri, Jul 17, 2020 at 12:24 AM Ian Rogers wrote: > > The non-builtin route for offsetof has a dependency on size_t from > stdlib.h/stdint.h that is undeclared and may break targets. > The offsetof macro in bpf_helpers may disable the same macro in other > headers that have a #ifdef offsetof guar

Re: [PATCH] docs: core-api/printk-formats.rst: use literal block syntax

2020-07-18 Thread Sergey Senozhatsky
On (20/07/18 13:51), Daniel W. S. Almeida wrote: > Fix the following warning: > > WARNING: Definition list ends without a blank line; > unexpected unindent. > > By switching to the literal block syntax. > > Signed-off-by: Daniel W. S. Almeida Acked-by: Sergey Senozhatsky -ss

[PATCH 0/3] xtensa: add seccomp support

2020-07-18 Thread Max Filippov
Hello, this series adds support for seccomp filter on xtensa and updates selftests/seccomp. Max Filippov (3): xtensa: expose syscall through user_pt_regs xtensa: add seccomp support selftests/seccomp: add xtensa support .../seccomp/seccomp-filter/arch-support.txt | 2 +- arch/xtensa

[PATCH 3/3] selftests/seccomp: add xtensa support

2020-07-18 Thread Max Filippov
Xtensa returns syscall number can be obtained and changed through the struct user_pt_regs. Syscall return value register is fixed relatively to the current register window in the user_pt_regs, so it needs a bit of special treatment. Signed-off-by: Max Filippov --- tools/testing/selftests/seccomp

[PATCH 2/3] xtensa: add seccomp support

2020-07-18 Thread Max Filippov
Add SECCOMP to xtensa Kconfig, select HAVE_ARCH_SECCOMP_FILTER, add TIF_SECCOMP and call secure_computing from do_syscall_trace_enter. Signed-off-by: Max Filippov --- .../seccomp/seccomp-filter/arch-support.txt | 2 +- arch/xtensa/Kconfig | 15 +++

[PATCH 1/3] xtensa: expose syscall through user_pt_regs

2020-07-18 Thread Max Filippov
Use one of the reserved slots in struct user_pt_regs to return syscall number in the GPR regset. Update syscall number from the GPR regset only when it's non-zero. Signed-off-by: Max Filippov --- arch/xtensa/include/uapi/asm/ptrace.h | 3 ++- arch/xtensa/kernel/ptrace.c | 4 2 fil

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-18 Thread Boris Ostrovsky
(Roger, question for you at the very end) On 7/17/20 3:10 PM, Anchal Agarwal wrote: > On Wed, Jul 15, 2020 at 05:18:08PM -0400, Boris Ostrovsky wrote: >> CAUTION: This email originated from outside of the organization. Do not >> click links or open attachments unless you can confirm the sender an

[PATCH net v2] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag

2020-07-18 Thread wenxu
From: wenxu The fragment packets do defrag in tcf_ct_handle_fragments will clear the skb->cb which make the qdisc_skb_cb clear too. So the qdsic_skb_cb should be store before defrag and restore after that. It also update the pkt_len after all the fragments finish the defrag to one packet and make

Re: [PATCH net] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag

2020-07-18 Thread wenxu
在 2020/7/18 20:30, Florian Westphal 写道: > we...@ucloud.cn wrote: >> From: wenxu >> >> The fragment packets do defrag in tcf_ct_handle_fragments >> will clear the skb->cb which make the qdisc_skb_cb clear >> too. So the qdsic_skb_cb should be store before defrag and >> restore after that. >> It

Re: [PATCH net-next 3/4] net: Call into DSA netdevice_ops wrappers

2020-07-18 Thread Florian Fainelli
On 7/18/2020 2:18 PM, Vladimir Oltean wrote: > On Fri, Jul 17, 2020 at 08:05:32PM -0700, Florian Fainelli wrote: >> Make the core net_device code call into our ndo_do_ioctl() and >> ndo_get_phys_port_name() functions via the wrappers defined previously >> >> Signed-off-by: Florian Fainelli >> -

Re: [PATCH net-next 3/4] net: Call into DSA netdevice_ops wrappers

2020-07-18 Thread Vladimir Oltean
On Fri, Jul 17, 2020 at 08:05:32PM -0700, Florian Fainelli wrote: > Make the core net_device code call into our ndo_do_ioctl() and > ndo_get_phys_port_name() functions via the wrappers defined previously > > Signed-off-by: Florian Fainelli > --- > net/core/dev.c | 5 + > net/core/dev_i

Re: [PATCH net-next 1/4] net: Wrap ndo_do_ioctl() to prepare for DSA stacked ops

2020-07-18 Thread Vladimir Oltean
On Sat, Jul 18, 2020 at 01:36:25PM -0700, Florian Fainelli wrote: > > > On 7/18/2020 1:30 PM, Vladimir Oltean wrote: > > Hi Florian, > > > > On Fri, Jul 17, 2020 at 08:05:30PM -0700, Florian Fainelli wrote: > >> In preparation for adding another layer of call into a DSA stacked ops > >> singleto

Re: [PATCH net-next 1/4] net: Wrap ndo_do_ioctl() to prepare for DSA stacked ops

2020-07-18 Thread Florian Fainelli
On 7/18/2020 1:30 PM, Vladimir Oltean wrote: > Hi Florian, > > On Fri, Jul 17, 2020 at 08:05:30PM -0700, Florian Fainelli wrote: >> In preparation for adding another layer of call into a DSA stacked ops >> singleton, wrap the ndo_do_ioctl() call into dev_do_ioctl(). >> >> Signed-off-by: Florian

Re: [PATCH net-next 1/4] net: Wrap ndo_do_ioctl() to prepare for DSA stacked ops

2020-07-18 Thread Vladimir Oltean
Hi Florian, On Fri, Jul 17, 2020 at 08:05:30PM -0700, Florian Fainelli wrote: > In preparation for adding another layer of call into a DSA stacked ops > singleton, wrap the ndo_do_ioctl() call into dev_do_ioctl(). > > Signed-off-by: Florian Fainelli > --- I missed most of the context, but this

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-18 Thread Florian Fainelli
;>> >>> [auto build test WARNING on net-next/master] >>> >>> url: >>> https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-Setup-dsa_netdev_ops/20200718-110931 >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-nex

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-18 Thread Vladimir Oltean
> > url: > > https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-Setup-dsa_netdev_ops/20200718-110931 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > > dcc82bb0727c08f93a91fa7532b950bafa2598f2 > > config: i386-all

Re: [PATCH net] bonding: check error value of register_netdevice() immediately

2020-07-18 Thread Cong Wang
On Sat, Jul 18, 2020 at 12:14 AM Taehee Yoo wrote: > > If register_netdevice() is failed, net_device should not be used > because variables are uninitialized or freed. > So, the routine should be stopped immediately. > But, bond_create() doesn't check return value of register_netdevice() > immedia

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-18 Thread Florian Fainelli
On 7/17/2020 9:53 PM, kernel test robot wrote: > Hi Florian, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-Setup-dsa_netdev_op

Re: [PATCH net-next] net: dsa: use the ETH_MIN_MTU and ETH_DATA_LEN default values

2020-07-18 Thread Florian Fainelli
On 7/18/2020 11:04 AM, Vladimir Oltean wrote: > Now that DSA supports MTU configuration, undo the effects of commit > 8b1efc0f83f1 ("net: remove MTU limits on a few ether_setup callers") and > let DSA interfaces use the default min_mtu and max_mtu specified by > ether_setup(). This is more impor

Re: [PATCH v2] net: dsa: qca8k: implement the port MTU callbacks

2020-07-18 Thread Vladimir Oltean
On Sat, Jul 18, 2020 at 05:32:14PM +0100, Jonathan McDowell wrote: > This switch has a single max frame size configuration register, so we > track the requested MTU for each port and apply the largest. > > v2: > - Address review feedback from Vladimir Oltean > > Signed-off-by: Jonathan McDowell

Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-18 Thread Stefano Brivio
On Sat, 18 Jul 2020 19:58:50 +0200 Stefano Brivio wrote: > On Sat, 18 Jul 2020 11:02:46 -0600 > David Ahern wrote: > > > On 7/18/20 12:56 AM, Stefano Brivio wrote: > > > On Fri, 17 Jul 2020 09:04:51 -0600 > > > David Ahern wrote: > > > > > >> On 7/17/20 6:27 AM, Stefano Brivio wrote:

[PATCH net-next] net: dsa: use the ETH_MIN_MTU and ETH_DATA_LEN default values

2020-07-18 Thread Vladimir Oltean
Now that DSA supports MTU configuration, undo the effects of commit 8b1efc0f83f1 ("net: remove MTU limits on a few ether_setup callers") and let DSA interfaces use the default min_mtu and max_mtu specified by ether_setup(). This is more important for min_mtu: since DSA is Ethernet, the minimum MTU

Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-18 Thread Stefano Brivio
On Sat, 18 Jul 2020 11:02:46 -0600 David Ahern wrote: > On 7/18/20 12:56 AM, Stefano Brivio wrote: > > On Fri, 17 Jul 2020 09:04:51 -0600 > > David Ahern wrote: > > > >> On 7/17/20 6:27 AM, Stefano Brivio wrote: > > > Note that this doesn't work as it is because of a number of

Re: [PATCH] docs: core-api/printk-formats.rst: use literal block syntax

2020-07-18 Thread Andy Shevchenko
On Sat, Jul 18, 2020 at 01:51:02PM -0300, Daniel W. S. Almeida wrote: > From: Daniel W. S. Almeida > > Fix the following warning: > > WARNING: Definition list ends without a blank line; > unexpected unindent. > > By switching to the literal block syntax. Acked-by: Andy Shevchenko > > Signed

Re: [PATCH net-next v2 5/6] enetc: Add interrupt coalescing support

2020-07-18 Thread Claudiu Manoil
On 17.07.2020 22:32, Jakub Kicinski wrote: On Fri, 17 Jul 2020 18:37:03 +0300 Claudiu Manoil wrote: + if (ic->rx_max_coalesced_frames != ENETC_RXIC_PKTTHR) + netif_warn(priv, hw, ndev, "rx-frames fixed to %d\n", + ENETC_RXIC_PKTTHR); + + if (ic-

Re: [PATCH net-next v2 6/6] enetc: Add adaptive interrupt coalescing

2020-07-18 Thread Claudiu Manoil
On 17.07.2020 22:30, Jakub Kicinski wrote: On Fri, 17 Jul 2020 18:37:04 +0300 Claudiu Manoil wrote: + if (tx_ictt == ENETC_TXIC_TIMETHR) + ic_mode |= ENETC_IC_TX_OPTIMAL; Doesn't seem you ever read/check the ENETC_IC_TX_OPTIMAL flag? It's used implicitly though ;), as

Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-18 Thread David Ahern
On 7/18/20 12:56 AM, Stefano Brivio wrote: > On Fri, 17 Jul 2020 09:04:51 -0600 > David Ahern wrote: > >> On 7/17/20 6:27 AM, Stefano Brivio wrote: > Note that this doesn't work as it is because of a number of reasons > (skb doesn't have a dst, pkt_type is not PACKET_HOST), and per

[PATCH v2] net: dsa: qca8k: implement the port MTU callbacks

2020-07-18 Thread Jonathan McDowell
This switch has a single max frame size configuration register, so we track the requested MTU for each port and apply the largest. v2: - Address review feedback from Vladimir Oltean Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 31 +++ drivers/net/ds

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-18 Thread Willem de Bruijn
On Sat, Jul 18, 2020 at 5:25 AM Sriram Krishnan wrote: > > When an application sends with AF_PACKET and places a vlan header on > the raw packet; then the AF_PACKET needs to move the tag into the skb > so that it gets processed normally through the rest of the transmit > path. > > This is particul

Re: [Regression] "SUNRPC: Add "@len" parameter to gss_unwrap()" breaks NFS Kerberos on upstream stable 5.4.y

2020-07-18 Thread Chuck Lever
> On Jul 17, 2020, at 3:46 PM, Pierre Sauter wrote: > > Am Freitag, 17. Juli 2020, 19:56:09 CEST schrieb Kai-Heng Feng: >>> Pierre, thanks for confirming! >>> >>> Kai-Heng suspected an upstream stable commit that is missing in 5.4.0-40, >>> but I don't have any good suggestions. >> >> Well,

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-18 Thread Matthew Hagan
On 18/07/2020 14:20, Russell King - ARM Linux admin wrote: > On Fri, Jul 17, 2020 at 10:44:19PM +0200, John Crispin wrote: >> in regards to the sgmii clk skew. I never understood the electrics fully I >> am afraid, but without the patch it simply does not work. my eletcric foo is >> unfortunatel

Re: bug: net: dsa: mv88e6xxx: serdes Unable to communicate on fiber with vf610-zii-dev-rev-c

2020-07-18 Thread Marek Behun
On Sat, 18 Jul 2020 17:05:14 +0200 Andrew Lunn wrote: > > If the traces were broken between the fiber module and the SERDES, I > > should not see these counters incrementing. > > Plus it is reproducible on multiple boards, of different designs. > > This is somehow specific to the 6390X ports

Re: [PATCH] mt76: mt76u: add missing release on skb in __mt76x02u_mcu_send_msg

2020-07-18 Thread Markus Elfring
… > +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c … > @@ -111,6 +113,7 @@ __mt76x02u_mcu_send_msg(struct mt76_dev *dev, struct > sk_buff *skb, > if (wait_resp) > ret = mt76x02u_mcu_wait_resp(dev, seq); > > +out: > consume_skb(skb); … I suggest to use the lab

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-18 Thread Russell King - ARM Linux admin
On Sat, Jul 18, 2020 at 04:44:35PM +0200, Andrew Lunn wrote: > On Sat, Jul 18, 2020 at 02:20:11PM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jul 17, 2020 at 10:44:19PM +0200, John Crispin wrote: > > > in regards to the sgmii clk skew. I never understood the electrics fully I > > >

Re: [PATCH -next] net: ena: use NULL instead of zero

2020-07-18 Thread Joe Perches
On Sat, 2020-07-18 at 19:56 +0800, Wang Hai wrote: > Fix sparse build warning: > > drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: > Using plain integer as NULL pointer Better to remove the initialization altogether and move the declaration into the loop. > diff --git a/drivers/n

Re: bug: net: dsa: mv88e6xxx: serdes Unable to communicate on fiber with vf610-zii-dev-rev-c

2020-07-18 Thread Andrew Lunn
On Sat, Jul 18, 2020 at 07:49:26AM -0700, Chris Healy wrote: > On Sat, Jul 18, 2020 at 7:42 AM Marek Behun wrote: > > > > Hmm, nothing sticks out in the register dump. > > > > I encountered a similar problem 2 years ago on Topaz SERDES port when > > the cmode was set to 2500BASE-X but the speed re

Re: [PATCH] net: ethernet: et131x: Remove redundant register read

2020-07-18 Thread Andrew Lunn
On Fri, Jul 17, 2020 at 04:21:51PM +0100, Mark Einon wrote: > On Fri, 2020-07-17 at 15:40 +0200, Andrew Lunn wrote: > > On Fri, Jul 17, 2020 at 02:21:35PM +0100, Mark Einon wrote: > > > Following the removal of an unused variable assignment (remove > > > unused variable 'pm_csr') the associated reg

Re: bug: net: dsa: mv88e6xxx: serdes Unable to communicate on fiber with vf610-zii-dev-rev-c

2020-07-18 Thread Chris Healy
On Sat, Jul 18, 2020 at 7:42 AM Marek Behun wrote: > > Hmm, nothing sticks out in the register dump. > > I encountered a similar problem 2 years ago on Topaz SERDES port when > the cmode was set to 2500BASE-X but the speed register was set to speed > incompatible with 2500BASE-X (I don't remember

Re: [PATCH] mt7601u: add missing release on skb in mt7601u_mcu_msg_send

2020-07-18 Thread Markus Elfring
… > +++ b/drivers/net/wireless/mediatek/mt7601u/mcu.c > @@ -116,8 +116,10 @@ mt7601u_mcu_msg_send(struct mt7601u_dev *dev, struct > sk_buff *skb, > int sent, ret; > u8 seq = 0; > > - if (test_bit(MT7601U_STATE_REMOVED, &dev->state)) > + if (test_bit(MT7601U_STATE_REMOVED, &dev-

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-18 Thread Andrew Lunn
On Sat, Jul 18, 2020 at 02:20:11PM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jul 17, 2020 at 10:44:19PM +0200, John Crispin wrote: > > in regards to the sgmii clk skew. I never understood the electrics fully I > > am afraid, but without the patch it simply does not work. my eletcric fo

Re: bug: net: dsa: mv88e6xxx: serdes Unable to communicate on fiber with vf610-zii-dev-rev-c

2020-07-18 Thread Marek Behun
Hmm, nothing sticks out in the register dump. I encountered a similar problem 2 years ago on Topaz SERDES port when the cmode was set to 2500BASE-X but the speed register was set to speed incompatible with 2500BASE-X (I don't remember what, though). This issue was solved by a patch I sent to netde

bug: net: dsa: mv88e6xxx: serdes Unable to communicate on fiber with vf610-zii-dev-rev-c

2020-07-18 Thread Chris Healy
I've been trying to get the fiber interface of the vf610-zii-dev-rev-c board working with net-next to no avail. This platform utilizes a Cotsworks SFF attached to port 9 of a Marvell 88E6390X. I have fiber link up on port 9 and am able to send packets from the management CPU of the switch through

Re: [PATCH net-next 0/3] Document more PTP timestamping known quirks

2020-07-18 Thread Sergey Organov
Vladimir Oltean writes: > On Sat, Jul 18, 2020 at 01:54:11PM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> >> > On Sat, Jul 18, 2020 at 12:13:42AM +0300, Sergey Organov wrote: >> >> Vladimir Oltean writes: >> >> >> >> > I've tried to collect and summarize the conclusions of these >

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-18 Thread Russell King - ARM Linux admin
On Fri, Jul 17, 2020 at 10:44:19PM +0200, John Crispin wrote: > in regards to the sgmii clk skew. I never understood the electrics fully I > am afraid, but without the patch it simply does not work. my eletcric foo is > unfortunately is not sufficient to understand the "whys" I am afraid. Do you h

[PATCH net v2 02/10] net/smc: clear link during SMC client link down processing

2020-07-18 Thread Karsten Graul
In a link-down condition we notify the SMC server and expect that the server will finally trigger the link clear processing on the client side. This could fail when anything along this notification path goes wrong. Clear the link as part of SMC client link-down processing to prevent dangling links.

[PATCH net v2 07/10] net/smc: fix handling of delete link requests

2020-07-18 Thread Karsten Graul
As smc client the delete link requests are assigned to the flow when _any_ flow is active. This may break other flows that do not expect delete link requests during their handling. Fix that by assigning the request only when an add link flow is active. With that fix the code for smc client and smc

[PATCH net v2 06/10] net/smc: move add link processing for new device into llc layer

2020-07-18 Thread Karsten Graul
When a new ib device is up smc will send an add link invitation to the peer if needed. This is currently done with rudimentary flow control. Under high workload these add link invitations can disturb other llc flows because they arrive unexpected. Fix this by integrating the invitations into the no

[PATCH net v2 05/10] net/smc: drop out-of-flow llc response messages

2020-07-18 Thread Karsten Graul
To be save from unexpected or late llc response messages check if the arrived message fits to the current flow type and drop out-of-flow messages. And drop it when there is already a response assigned to the flow. Reviewed-by: Ursula Braun Fixes: ef79d439cd12 ("net/smc: process llc responses in t

[PATCH net v2 00/10] net/smc: fixes 2020-07-16

2020-07-18 Thread Karsten Graul
Please apply the following patch series for smc to netdev's net tree. The patches address problems caused by late or unexpected link layer control packets, dma sync calls for unmapped memory, freed buffers that are not removed from the buffer list and a possible null pointer access that results in

[PATCH net v2 04/10] net/smc: protect smc ib device initialization

2020-07-18 Thread Karsten Graul
Before an smc ib device is used the first time for an smc link it is lazily initialized. When there are 2 active link groups and a new ib device is brought online then it might happen that 2 link creations run in parallel and enter smc_ib_setup_per_ibdev(). Both allocate new send and receive comple

[PATCH net v2 09/10] net/smc: remove freed buffer from list

2020-07-18 Thread Karsten Graul
Two buffers are allocated for each SMC connection. Each buffer is added to a buffer list after creation. When the second buffer allocation fails, the first buffer is freed but not deleted from the list. This might result in crashes when another connection picks up the freed buffer later and starts

[PATCH net v2 03/10] net/smc: fix link lookup for new rdma connections

2020-07-18 Thread Karsten Graul
For new rdma connections the SMC server assigns the link and sends the link data in the clc accept message. To match the correct link use not only the qp_num but also the gid and the mac of the links. If there are equal qp_nums for different links the wrong link would be chosen. Reviewed-by: Ursul

[PATCH net v2 08/10] net/smc: do not call dma sync for unmapped memory

2020-07-18 Thread Karsten Graul
The dma related ...sync_sg... functions check the link state before the dma function is actually called. But the check in smc_link_usable() allows links in ACTIVATING state which are not yet mapped to dma memory. Under high load it may happen that the sync_sg functions are called for such a link wh

[PATCH net v2 10/10] net/smc: fix restoring of fallback changes

2020-07-18 Thread Karsten Graul
When a listen socket is closed then all non-accepted sockets in its accept queue are to be released. Inside __smc_release() the helper smc_restore_fallback_changes() restores the changes done to the socket without to check if the clcsocket has a file set. This can result in a crash. Fix this by che

[PATCH net v2 01/10] net/smc: handle unexpected response types for confirm link

2020-07-18 Thread Karsten Graul
A delete link could arrive during confirm link processing. Handle this situation directly in smc_llc_srv_conf_link() rather than using the logic in smc_llc_wait() to avoid the unexpected message handling there. Reviewed-by: Ursula Braun Fixes: 1551c95b6124 ("net/smc: final part of add link proces

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-18 Thread Vladimir Oltean
On Fri, Jul 17, 2020 at 08:26:02PM +0100, Matthew Hagan wrote: > > > On 16/07/2020 23:32, Andrew Lunn wrote: > > On Thu, Jul 16, 2020 at 03:09:25PM -0700, Jakub Kicinski wrote: > >> On Mon, 13 Jul 2020 21:50:26 +0100 Matthew Hagan wrote: > >>> Add names and decriptions of additional PORT0_PAD_CTR

[PATCH -next] net: hsr: remove redundant null check

2020-07-18 Thread Wang Hai
Because kfree_skb already checked NULL skb parameter, so the additional checks are unnecessary, just remove them. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/hsr/hsr_forward.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/hsr/hsr_forward.c b/net/hsr/h

Re: [PATCH v4 net-next 3/3] octeontx2-pf: Add support for PTP clock

2020-07-18 Thread sundeep subbaraya
Hi David, On Fri, Jul 17, 2020 at 11:33 PM David Miller wrote: > > From: Jakub Kicinski > Date: Fri, 17 Jul 2020 10:48:12 -0700 > > > On Fri, 17 Jul 2020 10:41:49 +0530 sundeep subbaraya wrote: > >> I can separate this out and put in another patch #4 if you insist. > > > > Does someone need to i

Re: [PATCH v4 net-next 3/3] octeontx2-pf: Add support for PTP clock

2020-07-18 Thread sundeep subbaraya
Hi Jakub, On Fri, Jul 17, 2020 at 11:18 PM Jakub Kicinski wrote: > > On Fri, 17 Jul 2020 10:41:49 +0530 sundeep subbaraya wrote: > > On Fri, Jul 17, 2020 at 5:41 AM Jakub Kicinski wrote: > > > On Wed, 15 Jul 2020 18:08:09 +0530 Subbaraya Sundeep wrote: > > > > @@ -1730,10 +1745,149 @@ static voi

Re: [PATCH net] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag

2020-07-18 Thread Florian Westphal
we...@ucloud.cn wrote: > From: wenxu > > The fragment packets do defrag in tcf_ct_handle_fragments > will clear the skb->cb which make the qdisc_skb_cb clear > too. So the qdsic_skb_cb should be store before defrag and > restore after that. > It also update the pkt_len after all the > fragments

Re: RTL8402 stops working after hibernate/resume

2020-07-18 Thread Heiner Kallweit
On 16.07.2020 10:58, Petr Tesarik wrote: > Hi Heiner, > > first, thank you for looking into this! > > On Wed, 15 Jul 2020 17:22:35 +0200 > Heiner Kallweit wrote: > >> On 15.07.2020 10:28, Petr Tesarik wrote: >>> Hi all, >>> >>> I've encountered some issues on an Asus laptop. The RTL8402 receive

[PATCH -next] net: ena: use NULL instead of zero

2020-07-18 Thread Wang Hai
Fix sparse build warning: drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: Using plain integer as NULL pointer Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH] e100: switch from 'pci_' to 'dma_' API

2020-07-18 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'e100_alloc()', GFP_KERNEL can be used because it is

[PATCH -next] bpf: Make some functions static

2020-07-18 Thread Wang Hai
Fix sparse build warning: net/bpf/test_run.c:120:14: warning: symbol 'bpf_fentry_test1' was not declared. Should it be static? net/bpf/test_run.c:125:14: warning: symbol 'bpf_fentry_test2' was not declared. Should it be static? net/bpf/test_run.c:130:14: warning: symbol 'bpf_fentry_test3' was n

memory leak in veth_dev_init

2020-07-18 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e9919e11 Merge branch 'for-linus' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17058f5710 kernel config: https://syzkaller.appspot.com/x/.config?x=175942c28d9b8dd0 das

[PATCH net] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag

2020-07-18 Thread wenxu
From: wenxu The fragment packets do defrag in tcf_ct_handle_fragments will clear the skb->cb which make the qdisc_skb_cb clear too. So the qdsic_skb_cb should be store before defrag and restore after that. It also update the pkt_len after all the fragments finish the defrag to one packet and make

Re: [PATCH net-next 2/3] docs: networking: timestamping: add one more known issue

2020-07-18 Thread Vladimir Oltean
On Fri, Jul 17, 2020 at 04:08:03PM -0700, Jacob Keller wrote: > > > On 7/17/2020 9:10 AM, Vladimir Oltean wrote: > > Document the fact that Ethernet PHY timestamping has a fundamentally > > flawed corner case (which in fact hits the majority of networking > > drivers): a PHY for which its host MA

Re: [PATCH net-next 3/3] docs: networking: timestamping: add a set of frequently asked questions

2020-07-18 Thread Vladimir Oltean
On Fri, Jul 17, 2020 at 04:12:07PM -0700, Jacob Keller wrote: > > > On 7/17/2020 9:10 AM, Vladimir Oltean wrote: > > These are some questions I had while trying to explain the behavior of > > some drivers with respect to software timestamping. Answered with the > > help of Richard Cochran. > > >

Re: [PATCH net-next 0/3] Document more PTP timestamping known quirks

2020-07-18 Thread Vladimir Oltean
On Sat, Jul 18, 2020 at 01:54:11PM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > On Sat, Jul 18, 2020 at 12:13:42AM +0300, Sergey Organov wrote: > >> Vladimir Oltean writes: > >> > >> > I've tried to collect and summarize the conclusions of these discussions: > >> > https://patchwo

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-18 Thread Russell King - ARM Linux admin
On Sat, Jul 18, 2020 at 11:21:26AM +, Martin Rowe wrote: > On Sat, 18 Jul 2020 at 10:13, Russell King - ARM Linux admin > wrote: > > Okay, on top of those changes, please also add this: > > "in-band-status" plus your chip.c patch works; I can now ping from the GT 8K. Great, and your kernel m

Re: [PATCH] net: dsa: qca8k: implement the port MTU callbacks

2020-07-18 Thread Jonathan McDowell
On Sat, Jul 18, 2020 at 01:38:08PM +0300, Vladimir Oltean wrote: > On Sat, Jul 18, 2020 at 10:35:55AM +0100, Jonathan McDowell wrote: > > This switch has a single max frame size configuration register, so we > > track the requested MTU for each port and apply the largest. > > > > Signed-off-by: Jo

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-18 Thread Martin Rowe
On Sat, 18 Jul 2020 at 10:13, Russell King - ARM Linux admin wrote: > Okay, on top of those changes, please also add this: "in-band-status" plus your chip.c patch works; I can now ping from the GT 8K. $ dmesg |grep f400 mvpp2 f400.ethernet: using 8 per-cpu buffers mvpp2 f400.ethernet

Re: [PATCH net-next 0/3] Document more PTP timestamping known quirks

2020-07-18 Thread Sergey Organov
Vladimir Oltean writes: > I've tried to collect and summarize the conclusions of these discussions: > https://patchwork.ozlabs.org/project/netdev/patch/20200711120842.2631-1-sorga...@gmail.com/ > https://patchwork.ozlabs.org/project/netdev/patch/20200710113611.3398-5-k...@linutronix.de/ > which w

[PATCH] net/fealnx: switch from 'pci_' to 'dma_' API

2020-07-18 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated, GFP_KERNEL can be used because it is called from the p

Re: [PATCH net-next 0/3] Document more PTP timestamping known quirks

2020-07-18 Thread Sergey Organov
Vladimir Oltean writes: > On Sat, Jul 18, 2020 at 12:13:42AM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> >> > I've tried to collect and summarize the conclusions of these discussions: >> > https://patchwork.ozlabs.org/project/netdev/patch/20200711120842.2631-1-sorga...@gmail.com/

Re: [PATCH] net: dsa: felix: Make some symbols static

2020-07-18 Thread wanghai (M)
Thanks for reminding me, I'll do it. 在 2020/7/18 18:40, Vladimir Oltean 写道: On Sat, Jul 18, 2020 at 06:01:58PM +0800, Wang Hai wrote: Fix sparse build warning: drivers/net/dsa/ocelot/felix_vsc9959.c:560:19: warning: symbol 'vsc9959_vcap_is2_keys' was not declared. Should it be static? driver

Re: [PATCH net-next] tcp: Optimize the recovery of tcp when lack of SACK

2020-07-18 Thread hujunwei
On 2020/7/17 22:44, Neal Cardwell wrote: > On Fri, Jul 17, 2020 at 7:43 AM hujunwei wrote: >> >> From: Junwei Hu >> >> In the document of RFC2582(https://tools.ietf.org/html/rfc2582) >> introduced two separate scenarios for tcp congestion control: > > Can you please elaborate on how the sender

Re: [PATCH] net: dsa: felix: Make some symbols static

2020-07-18 Thread Vladimir Oltean
On Sat, Jul 18, 2020 at 06:01:58PM +0800, Wang Hai wrote: > Fix sparse build warning: > > drivers/net/dsa/ocelot/felix_vsc9959.c:560:19: warning: > symbol 'vsc9959_vcap_is2_keys' was not declared. Should it be static? > drivers/net/dsa/ocelot/felix_vsc9959.c:640:19: warning: > symbol 'vsc9959_vc

Re: [PATCH] net: dsa: qca8k: implement the port MTU callbacks

2020-07-18 Thread Vladimir Oltean
On Sat, Jul 18, 2020 at 10:35:55AM +0100, Jonathan McDowell wrote: > This switch has a single max frame size configuration register, so we > track the requested MTU for each port and apply the largest. > > Signed-off-by: Jonathan McDowell > --- > drivers/net/dsa/qca8k.c | 38

[PATCH] mISDN: switch from 'pci_' to 'dma_' API

2020-07-18 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'setup_hw()' (hfcpci.c) GFP_KERNEL can be used becau

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-18 Thread Russell King - ARM Linux admin
On Sat, Jul 18, 2020 at 09:43:47AM +, Martin Rowe wrote: > On Sat, 18 Jul 2020 at 08:50, Russell King - ARM Linux admin > wrote: > > Sorry, it should have been ``managed = "in-band-status";'' rather than > > just "in-band". > > Below are the outputs with "in-band-status". It functions the sam

[PATCH] net: dsa: felix: Make some symbols static

2020-07-18 Thread Wang Hai
Fix sparse build warning: drivers/net/dsa/ocelot/felix_vsc9959.c:560:19: warning: symbol 'vsc9959_vcap_is2_keys' was not declared. Should it be static? drivers/net/dsa/ocelot/felix_vsc9959.c:640:19: warning: symbol 'vsc9959_vcap_is2_actions' was not declared. Should it be static? Reported-by: H

[PATCH] ipw2x00: Replace HTTP links with HTTPS ones

2020-07-18 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-18 Thread Martin Rowe
On Sat, 18 Jul 2020 at 08:50, Russell King - ARM Linux admin wrote: > Sorry, it should have been ``managed = "in-band-status";'' rather than > just "in-band". Below are the outputs with "in-band-status". It functions the same as not reverting the patch; interface comes up, when bridged the two ph

[PATCH] net: dsa: qca8k: implement the port MTU callbacks

2020-07-18 Thread Jonathan McDowell
This switch has a single max frame size configuration register, so we track the requested MTU for each port and apply the largest. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 38 ++ drivers/net/dsa/qca8k.h | 3 +++ 2 files changed, 41 inser

[PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-18 Thread Sriram Krishnan
When an application sends with AF_PACKET and places a vlan header on the raw packet; then the AF_PACKET needs to move the tag into the skb so that it gets processed normally through the rest of the transmit path. This is particularly a problem on Hyper-V where the host only allows vlan in the offl

[PATCH net-next v2 2/2] hinic: add log in exception handling processes

2020-07-18 Thread Luo bin
improve the error message when functions return failure and dump relevant registers in some exception handling processes Signed-off-by: Luo bin --- V0~V1: fix some warning reported by sparse .../ethernet/huawei/hinic/hinic_hw_api_cmd.c | 27 +++- .../ethernet/huawei/hinic/hinic_hw_api_cmd.

[PATCH net-next v2 0/2] hinic: add some error messages for debug

2020-07-18 Thread Luo bin
patch #1: support to handle hw abnormal event patch #2: improve the error messages when functions return failure and dump relevant registers in some exception handling processes Luo bin (2): hinic: add support to handle hw abnormal event hinic: add log in exception handling processes

[PATCH net-next v2 1/2] hinic: add support to handle hw abnormal event

2020-07-18 Thread Luo bin
add support to handle hw abnormal event such as hardware failure, cable unplugged,link error Signed-off-by: Luo bin --- V1~V2: add link extended state V0~V1: fix auto build test WARNING drivers/net/ethernet/huawei/hinic/hinic_dev.h | 2 + .../net/ethernet/huawei/hinic/hinic_ethtool.c | 20 ++

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-18 Thread Russell King - ARM Linux admin
On Sat, Jul 18, 2020 at 02:37:41AM +, Martin Rowe wrote: > On Fri, 17 Jul 2020 at 21:26, Russell King - ARM Linux admin > wrote: > > Both ends really need to agree, and I'd suggest cp1_eth2 needs to drop > > the fixed-link stanza and instead use ``managed = "in-band";'' to be > > in agreement

linux-next: Signed-off-by missing for commit in the net-next tree

2020-07-18 Thread Stephen Rothwell
Hi all, Commit 1315971fea66 ("net/mlx5e: Fix missing switch_id for representors") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpJgwTVB9G1d.pgp Description: OpenPGP digital signature

[RESEND] net: decnet: TODO Items

2020-07-18 Thread Suraj Upadhyay
Hi Maintainers and Developers, I am interested in the DECnet TODO list. I just need a quick response whether they are worth doing or not for the amount of development happening in this subsystem is extremely low and I can't help but question whether I should indulge in any of the listed wor

Re: [PATCH net-next v1 1/2] hinic: add support to handle hw abnormal event

2020-07-18 Thread luobin (L)
On 2020/7/18 3:11, Jakub Kicinski wrote: > On Fri, 17 Jul 2020 16:34:47 +0800 Luo bin wrote: >> add support to handle hw abnormal event such as hardware failure, >> cable unplugged,link error >> >> Signed-off-by: Luo bin >> Reported-by: kernel test robot > >> +static void hinic_comm_recv_mgmt_se

Re: [RFC PATCH 4/7] crypto: remove ARC4 support from the skcipher API

2020-07-18 Thread Ard Biesheuvel
On Fri, 3 Jul 2020 at 02:04, Ard Biesheuvel wrote: > > On Thu, 2 Jul 2020 at 20:21, Ard Biesheuvel wrote: > > > > On Thu, 2 Jul 2020 at 19:50, Eric Biggers wrote: > > > > > > [+linux-wireless, Marcel Holtmann, and Denis Kenzior] > > > > > > On Thu, Jul 02, 2020 at 12:19:44PM +0200, Ard Biesheuve

Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure

2020-07-18 Thread wanghai (M)
在 2020/7/18 9:39, David Miller 写道: From: Wang Hai Date: Fri, 17 Jul 2020 14:21:17 +0800 The driver forgets to call destroy_workqueue when cxgb3 probe fails. Add the missed calls to fix it. Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.") Reported-by: Hulk Robot

[PATCH net] bonding: check error value of register_netdevice() immediately

2020-07-18 Thread Taehee Yoo
If register_netdevice() is failed, net_device should not be used because variables are uninitialized or freed. So, the routine should be stopped immediately. But, bond_create() doesn't check return value of register_netdevice() immediately. That will result in a panic because of using uninitialized