Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-17 Thread Stefano Brivio
On Fri, 17 Jul 2020 09:04:51 -0600 David Ahern wrote: > On 7/17/20 6:27 AM, Stefano Brivio wrote: > >> > >>> Note that this doesn't work as it is because of a number of reasons > >>> (skb doesn't have a dst, pkt_type is not PACKET_HOST), and perhaps we > >>> shouldn't be using icmp_send(), but

[PATCH net] netdevsim: fix unbalaced locking in nsim_create()

2020-07-17 Thread Taehee Yoo
In the nsim_create(), rtnl_lock() is called before nsim_bpf_init(). If nsim_bpf_init() is failed, rtnl_unlock() should be called, but it isn't called. So, unbalanced locking would occur. Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe") Signed-off-by: Taehee Yoo ---

Re: [PATCH] libbpf bpf_helpers: Use __builtin_offsetof for offsetof if available

2020-07-17 Thread Yonghong Song
On 7/17/20 12:23 AM, Ian Rogers wrote: The non-builtin route for offsetof has a dependency on size_t from stdlib.h/stdint.h that is undeclared and may break targets. The offsetof macro in bpf_helpers may disable the same macro in other headers that have a #ifdef offsetof guard. Rather than add

[PATCH] mt76: mt76u: add missing release on skb in __mt76x02u_mcu_send_msg

2020-07-17 Thread Navid Emamdoost
In the implementation of __mt76x02u_mcu_send_msg() the skb is consumed all execution paths except one. Release skb before returning if test_bit() fails. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletio

[PATCH] nfc: s3fwrn5: add missing release on skb in s3fwrn5_recv_frame

2020-07-17 Thread Navid Emamdoost
The implementation of s3fwrn5_recv_frame() is supposed to consume skb on all execution paths. Release skb before returning -ENODEV. Signed-off-by: Navid Emamdoost --- drivers/nfc/s3fwrn5/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nfc/s3fwrn5/core.c b/drivers/nfc/s3fwrn5/c

[PATCH] mt7601u: add missing release on skb in mt7601u_mcu_msg_send

2020-07-17 Thread Navid Emamdoost
In the implementation of mt7601u_mcu_msg_send(), skb is supposed to be consumed on all execution paths. Release skb before returning if test_bit() fails. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/mediatek/mt7601u/mcu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH] cxgb4: add missing release on skb in uld_send()

2020-07-17 Thread Navid Emamdoost
In the implementation of uld_send(), the skb is consumed on all execution paths except one. Release skb when returning NET_XMIT_DROP. Signed-off-by: Navid Emamdoost --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4

Re: [PATCH bpf-next 1/2] bpf: change var type of BTF_ID_LIST to static

2020-07-17 Thread Yonghong Song
On 7/17/20 4:12 PM, kernel test robot wrote: Hi Yonghong, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Yonghong-Song/compute-bpf_skc_to_-helper-socket-btf-ids-at-build-time/20200718-025117 base: h

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-17 Thread kernel test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-Setup-dsa_netdev_ops/20200718-110931 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dc

Re: BPF logging infrastructure. Was: [PATCH bpf-next 4/6] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

2020-07-17 Thread Andrii Nakryiko
On Thu, Jul 16, 2020 at 8:09 PM Alexei Starovoitov wrote: > > On Thu, Jul 16, 2020 at 12:59:30PM -0700, Andrii Nakryiko wrote: > > On Wed, Jul 15, 2020 at 10:44 PM Alexei Starovoitov > > wrote: > > > > > > On Wed, Jul 15, 2020 at 06:11:39PM -0700, Andrii Nakryiko wrote: > > > > > > > > > > On Wed

Re: [PATCH bpf-next v5 00/15] Run a BPF program on socket lookup

2020-07-17 Thread Alexei Starovoitov
On Fri, Jul 17, 2020 at 9:40 AM Lorenz Bauer wrote: > > On Fri, 17 Jul 2020 at 11:35, Jakub Sitnicki wrote: > > > > Changelog > > = > > v4 -> v5: > > - Enforce BPF prog return value to be SK_DROP or SK_PASS. (Andrii) > > - Simplify prog runners now that only SK_DROP/PASS can be returned.

[PATCH net-next 1/4] net: Wrap ndo_do_ioctl() to prepare for DSA stacked ops

2020-07-17 Thread Florian Fainelli
In preparation for adding another layer of call into a DSA stacked ops singleton, wrap the ndo_do_ioctl() call into dev_do_ioctl(). Signed-off-by: Florian Fainelli --- net/core/dev_ioctl.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/net/core/dev_

[PATCH net-next 3/4] net: Call into DSA netdevice_ops wrappers

2020-07-17 Thread Florian Fainelli
Make the core net_device code call into our ndo_do_ioctl() and ndo_get_phys_port_name() functions via the wrappers defined previously Signed-off-by: Florian Fainelli --- net/core/dev.c | 5 + net/core/dev_ioctl.c | 5 + 2 files changed, 10 insertions(+) diff --git a/net/core/dev.c

[PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-17 Thread Florian Fainelli
Add definitions for the dsa_netdevice_ops structure which is a subset of the net_device_ops structure for the specific operations that we care about overlaying on top of the DSA CPU port net_device and provide inline stubs that take core managing whether DSA code is reachable. Signed-off-by: Flori

[PATCH net-next 0/4] net: dsa: Setup dsa_netdev_ops

2020-07-17 Thread Florian Fainelli
Hi David, Jakub, This patch series addresses the overloading of a DSA CPU/management interface's netdev_ops for the purpose of providing useful information from the switch side. Up until now we had duplicated the existing netdev_ops structure and added specific function pointers to return informa

[PATCH net-next 4/4] net: dsa: Setup dsa_netdev_ops

2020-07-17 Thread Florian Fainelli
Now that we hav all the infrastructure in place for calling into the dsa_ptr->netdev_ops function pointers, install them when we configure the DSA CPU/management interface and tear them down. The flow is unchanged from before, but now we preserve equality of tests when network device drivers do tes

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-17 Thread Martin Rowe
On Fri, 17 Jul 2020 at 21:26, Russell King - ARM Linux admin wrote: > Both ends really need to agree, and I'd suggest cp1_eth2 needs to drop > the fixed-link stanza and instead use ``managed = "in-band";'' to be > in agreement with the configuration at the switch. > > Martin, can you modify > arch

Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support

2020-07-17 Thread Richard Cochran
On Fri, Jul 17, 2020 at 09:54:07AM +0200, Kurt Kanzenbach wrote: > I'll post the next version of the hellcreek DSA driver probably next > week. I can include a generic ptp_header() function if you like in that > patch series. But, where to put it? ptp core or maybe ptp_classify? Either place is fi

Re: [PATCH net] mlxsw: core: Fix wrong SFP EEPROM reading for upper pages 1-3

2020-07-17 Thread David Miller
From: Ido Schimmel Date: Fri, 17 Jul 2020 22:01:43 +0300 > From: Vadim Pasternak > > Fix wrong reading of upper pages for SFP EEPROM. According to "Memory > Organization" figure in SFF-8472 spec: When reading upper pages 1, 2 and > 3 the offset should be set relative to zero and I2C high addres

Re: [PATCH net-next] ne2k-pci: Use netif_msg_init to initialize msg_enable bits

2020-07-17 Thread David Miller
From: Armin Wolf Date: Fri, 17 Jul 2020 20:21:48 +0200 > Use netif_msg_enable() to process param settings. > > Signed-off-by: Armin Wolf Applied.

Re: [PATCH net-next 0/2] net: atlantic: add support for FW 4.x

2020-07-17 Thread David Miller
From: Mark Starovoytov Date: Fri, 17 Jul 2020 21:01:45 +0300 > This patch set adds support for FW 4.x, which is about to get into the > production for some products. > 4.x is mostly compatible with 3.x, save for soft reset, which requires > the acquisition of 2 additional semaphores. > Other diff

Re: [net-next PATCH v3 2/7] net: hsr: introduce common code for skb initialization

2020-07-17 Thread David Miller
From: Murali Karicheri Date: Fri, 17 Jul 2020 11:15:06 -0400 > +static void send_hsr_supervision_frame(struct hsr_port *master, > +u8 type, u8 hsr_ver) > +{ > + struct sk_buff *skb; > + struct hsr_tag *hsr_tag; > + struct hsr_sup_tag *hsr_stag; > +

Re: [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP

2020-07-17 Thread David Miller
From: Murali Karicheri Date: Fri, 17 Jul 2020 11:15:05 -0400 > @@ -32,7 +33,9 @@ static int hsr_newlink(struct net *src_net, struct > net_device *dev, > struct netlink_ext_ack *extack) > { > struct net_device *link[2]; > - unsigned char multicast_spec, hsr_version

Re: [PATCH 2/2 v2] net: hsr: validate address B before copying to skb

2020-07-17 Thread David Miller
From: Murali Karicheri Date: Fri, 17 Jul 2020 10:55:10 -0400 > Validate MAC address before copying the same to outgoing frame > skb destination address. Since a node can have zero mac > address for Link B until a valid frame is received over > that link, this fix address the issue of a zero MAC a

Re: [PATCH 1/2 v2] net: hsr: fix incorrect lsdu size in the tag of HSR frames for small frames

2020-07-17 Thread David Miller
From: Murali Karicheri Date: Fri, 17 Jul 2020 10:55:09 -0400 > For small Ethernet frames with size less than minimum size 66 for HSR > vs 60 for regular Ethernet frames, hsr driver currently doesn't pad the > frame to make it minimum size. This results in incorrect LSDU size being > populated in

Re: [PATCH] net: ethernet: et131x: Remove redundant register read

2020-07-17 Thread David Miller
From: Mark Einon Date: Fri, 17 Jul 2020 14:21:35 +0100 > Following the removal of an unused variable assignment (remove > unused variable 'pm_csr') the associated register read can also go, > as the read also occurs in the subsequent et1310_in_phy_coma() > call. > > Signed-off-by: Mark Einon A

Re: [PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload

2020-07-17 Thread David Miller
From: Grygorii Strashko Date: Fri, 17 Jul 2020 15:19:32 +0300 > From: Murali Karicheri > > Currently drive supports taprio offload which is a tc feature offloaded > to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC > in the net device to be compliant. This patch adds the

Re: [PATCH net-next] net: ethernet: et131x: Remove unused variable 'pm_csr'

2020-07-17 Thread David Miller
From: Zhang Changzhong Date: Fri, 17 Jul 2020 18:33:30 +0800 > Gcc report warning as follows: > > drivers/net/ethernet/agere/et131x.c:953:6: warning: > variable 'pm_csr' set but not used [-Wunused-but-set-variable] > 953 | u32 pm_csr; > | ^~ > drivers/net/ethernet/agere/et131x

Re: [PATCH net-next] net: bna: Remove unused variable 't'

2020-07-17 Thread David Miller
From: Zhang Changzhong Date: Fri, 17 Jul 2020 18:23:04 +0800 > Gcc report warning as follows: > > drivers/net/ethernet/brocade/bna/bfa_ioc.c:1538:6: warning: > variable 't' set but not used [-Wunused-but-set-variable] > 1538 | u32 t; > | ^ > > After commit c107ba171f3d ("bna: Firm

Re: [PATCH net-next] dpaa_eth: Fix one possible memleak in dpaa_eth_probe

2020-07-17 Thread David Miller
From: Liu Jian Date: Fri, 17 Jul 2020 17:05:28 +0800 > When dma_coerce_mask_and_coherent() fails, the alloced netdev need to be > freed. > > Fixes: 060ad66f9795 ("dpaa_eth: change DMA device") > Signed-off-by: Liu Jian This is a bug fix introduced in v5.5, therefore it should be targetting 'n

Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure

2020-07-17 Thread David Miller
From: Wang Hai Date: Fri, 17 Jul 2020 14:21:17 +0800 > The driver forgets to call destroy_workqueue when cxgb3 probe fails. > Add the missed calls to fix it. > > Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai

Re: [PATCH net-next] efx: convert to new udp_tunnel infrastructure

2020-07-17 Thread David Miller
From: Jakub Kicinski Date: Fri, 17 Jul 2020 16:53:36 -0700 > Check MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_TRUSTED, before setting > the info, which will hopefully protect us from -EPERM errors > the previous code was gracefully ignoring. Shared code reports > the port information back to user space, so w

Re: [PATCH] rhashtable: drop duplicated word in

2020-07-17 Thread David Miller
From: Randy Dunlap Date: Fri, 17 Jul 2020 16:37:25 -0700 > From: Randy Dunlap > > Drop the doubled word "be" in a comment. > > Signed-off-by: Randy Dunlap Applied, thank you.

Re: Unexpected PACKET_TX_TIMESTAMP Messages

2020-07-17 Thread Matt Sandy
Got it, thanks! This makes a lot more sense. tl;dr: it's metadata about the corresponding SOL_SOCKET/SO_TIMESTAMPING cmsg. It also looks like passing OPT_ID as a socket option should auto-increment the ee_data field on send. This was the first message sent on the socket though so I'd expect zero an

Re: [PATCH net] net: macb: use phy_interface_mode_is_rgmii everywhere

2020-07-17 Thread David Miller
From: Alexandre Belloni Date: Sat, 18 Jul 2020 01:32:21 +0200 > There is one RGMII check not using the phy_interface_mode_is_rgmii() > helper. This prevents the driver from configuring the MAC properly when > using a phy-mode that is not just rgmii, e.g. rgmii-rxid. This became an > issue on sama

Re: mmotm 2020-07-16-22-52 uploaded (net: IPVS)

2020-07-17 Thread Stephen Rothwell
Hi all, On Fri, 17 Jul 2020 08:30:04 -0700 Randy Dunlap wrote: > > (also in linux-next) > > Many of these errors: > > In file included from ../net/netfilter/ipvs/ip_vs_conn.c:37:0: > ../include/net/ip_vs.h: In function ‘ip_vs_enqueue_expire_nodest_conns’: > ../include/net/ip_vs.h:1536:61: error

Re: [PATCH net-next] net: bnxt: don't complain if TC flower can't be supported

2020-07-17 Thread David Miller
From: Jakub Kicinski Date: Fri, 17 Jul 2020 13:59:58 -0700 > The fact that NETIF_F_HW_TC is not set should be a sufficient > indication to the user that TC offloads are not supported. > No need to bother users of older firmware versions with > pointless warnings on every boot. > > Also, since th

Re: [PATCH net] net: atlantic: disable PTP on AQC111, AQC112

2020-07-17 Thread David Miller
From: Mark Starovoytov Date: Fri, 17 Jul 2020 23:39:49 +0300 > From: Nikita Danilov > > This patch disables PTP on AQC111 and AQC112 due to a known HW issue, > which can cause datapath issues. > > Ideally PTP block should have been disabled via PHY provisioning, but > unfortunately many units

Re: [PATCH v3] folds tests from test_current_pid_tgid_new_ns into test_progs.

2020-07-17 Thread Carlos Antonio Neira Bustos
My last email was missing what changed from V2. Changes from V2: - Test that does not create a new namespace has been included in test_progs - Test creating a new pid namespace is a standalone test. - Skeleton is used in both tests. On Fri, Jul 17, 2020 at 08:41:22PM -0400, Carlos Neira wrote:

Re: [PATCH bpf-next 2/2] bpf: compute bpf_skc_to_*() helper socket btf ids at build time

2020-07-17 Thread kernel test robot
Hi Yonghong, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Yonghong-Song/compute-bpf_skc_to_-helper-socket-btf-ids-at-build-time/20200718-025117 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf

[PATCH v3] folds tests from test_current_pid_tgid_new_ns into test_progs.

2020-07-17 Thread Carlos Neira
Signed-off-by: Carlos Neira --- tools/testing/selftests/bpf/.gitignore| 2 +- tools/testing/selftests/bpf/Makefile | 3 +- .../bpf/prog_tests/ns_current_pid_tgid.c | 85 - .../bpf/prog_tests/ns_current_pidtgid.c | 59 .../bpf/progs/test_n

Re: [PATCH bpf-next 1/2] bpf: change var type of BTF_ID_LIST to static

2020-07-17 Thread kernel test robot
Hi Yonghong, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Yonghong-Song/compute-bpf_skc_to_-helper-socket-btf-ids-at-build-time/20200718-025117 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf

Re: [PATCH ghak90 V9 08/13] audit: add containerid support for user records

2020-07-17 Thread Richard Guy Briggs
On 2020-07-05 11:11, Paul Moore wrote: > On Sat, Jun 27, 2020 at 9:23 AM Richard Guy Briggs wrote: > > > > Add audit container identifier auxiliary record to user event standalone > > records. > > > > Signed-off-by: Richard Guy Briggs > > Acked-by: Neil Horman > > Reviewed-by: Ondrej Mosnacek >

[PATCH net-next] efx: convert to new udp_tunnel infrastructure

2020-07-17 Thread Jakub Kicinski
Check MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_TRUSTED, before setting the info, which will hopefully protect us from -EPERM errors the previous code was gracefully ignoring. Shared code reports the port information back to user space, so we really want to know what was added and what failed. The driver doe

[PATCH] rhashtable: drop duplicated word in

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "be" in a comment. Signed-off-by: Randy Dunlap Cc: Thomas Graf Cc: Herbert Xu Cc: netdev@vger.kernel.org --- include/linux/rhashtable.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/linux/rhashtable.h +

[PATCH net] net: macb: use phy_interface_mode_is_rgmii everywhere

2020-07-17 Thread Alexandre Belloni
There is one RGMII check not using the phy_interface_mode_is_rgmii() helper. This prevents the driver from configuring the MAC properly when using a phy-mode that is not just rgmii, e.g. rgmii-rxid. This became an issue on sama5d3 xplained since the ksz9031 driver is hadling phy-mode properly and t

Re: [PATCH bpf-next 1/2] bpf: change var type of BTF_ID_LIST to static

2020-07-17 Thread kernel test robot
Hi Yonghong, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Yonghong-Song/compute-bpf_skc_to_-helper-socket-btf-ids-at-build-time/20200718-025117 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf

Re: [PATCH net-next 0/3] Document more PTP timestamping known quirks

2020-07-17 Thread Jacob Keller
On 7/17/2020 2:57 PM, Vladimir Oltean wrote: > On Sat, Jul 18, 2020 at 12:13:42AM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> >>> I've tried to collect and summarize the conclusions of these discussions: >>> https://patchwork.ozlabs.org/project/netdev/patch/20200711120842.2631-1-

Re: [PATCH v7 bpf-next 0/9] introduce support for XDP programs in CPUMAP

2020-07-17 Thread Alexei Starovoitov
On Fri, Jul 17, 2020 at 12:13 PM Lorenzo Bianconi wrote: > > > On Fri, 17 Jul 2020 13:01:36 +0200 > > Lorenzo Bianconi wrote: > > > > [...] > > > > > HTH, > > -jkbs > > Hi Jakub, > > can you please test the patch below when you have some free cycles? It fixes > the issue in my setup. > > Regards,

Re: [PATCH net-next 3/3] docs: networking: timestamping: add a set of frequently asked questions

2020-07-17 Thread Jacob Keller
On 7/17/2020 9:10 AM, Vladimir Oltean wrote: > These are some questions I had while trying to explain the behavior of > some drivers with respect to software timestamping. Answered with the > help of Richard Cochran. > > Signed-off-by: Vladimir Oltean > --- > Documentation/networking/timestam

Re: [EXT] Re: [PATCH v2 net-next 03/10] net: mscc: ocelot: allocated rules to different hardware VCAP TCAMs by chain index

2020-07-17 Thread Allan W. Nielsen
On 17.07.2020 12:08, Vladimir Oltean wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Fri, Jul 17, 2020 at 09:34:11AM +0200, Joergen Andreasen wrote: The 07/16/2020 17:45, Vladimir Oltean wrote: > Hi Vladimir, > > On Thu, Jul 16, 2020 at 10:3

Re: general protection fault in khugepaged

2020-07-17 Thread Kirill A. Shutemov
On Fri, Jul 17, 2020 at 03:40:04PM -0700, syzbot wrote: > syzbot has bisected this issue to: > > commit ffe945e633b527d5a4577b42cbadec3c7cbcf096 > Author: Kirill A. Shutemov > Date: Wed Jun 3 23:00:09 2020 + > > khugepaged: do not stop collapse if less than half PTEs are referenced >

Re: [PATCH net-next 2/3] docs: networking: timestamping: add one more known issue

2020-07-17 Thread Jacob Keller
On 7/17/2020 9:10 AM, Vladimir Oltean wrote: > Document the fact that Ethernet PHY timestamping has a fundamentally > flawed corner case (which in fact hits the majority of networking > drivers): a PHY for which its host MAC driver doesn't forward the > phy_mii_ioctl for timestamping is still go

[PATCH bpf-next v3] bpftool: use only nftw for file tree parsing

2020-07-17 Thread Tony Ambardar
The bpftool sources include code to walk file trees, but use multiple frameworks to do so: nftw and fts. While nftw conforms to POSIX/SUSv3 and is widely available, fts is not conformant and less common, especially on non-glibc systems. The inconsistent framework usage hampers maintenance and porta

Re: Unexpected PACKET_TX_TIMESTAMP Messages

2020-07-17 Thread Willem de Bruijn
On Fri, Jul 17, 2020 at 1:52 PM Matt Sandy wrote: > > I've been playing around with raw sockets and timestamps, but seem to > be getting strange timestamp data back on the errqueue. Specifically, > if I am creating a socket(AF_PACKET, SOCK_RAW, htons(ETH_P_IP)) and > requesting SO_TIMESTAMPING_NEW

Re: [PATCH bpf-next v2] bpftool: use only nftw for file tree parsing

2020-07-17 Thread Tony Ambardar
On Thu, 16 Jul 2020 at 02:14, Quentin Monnet wrote: > > 2020-07-15 22:29 UTC-0700 ~ Tony Ambardar > > The bpftool sources include code to walk file trees, but use multiple > > frameworks to do so: nftw and fts. While nftw conforms to POSIX/SUSv3 and > > is widely available, fts is not conformant

Re: general protection fault in khugepaged

2020-07-17 Thread syzbot
syzbot has bisected this issue to: commit ffe945e633b527d5a4577b42cbadec3c7cbcf096 Author: Kirill A. Shutemov Date: Wed Jun 3 23:00:09 2020 + khugepaged: do not stop collapse if less than half PTEs are referenced bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17356c2f100

Re: [PATCH net-next] net: bnxt: don't complain if TC flower can't be supported

2020-07-17 Thread Michael Chan
On Fri, Jul 17, 2020 at 2:00 PM Jakub Kicinski wrote: > > The fact that NETIF_F_HW_TC is not set should be a sufficient > indication to the user that TC offloads are not supported. > No need to bother users of older firmware versions with > pointless warnings on every boot. > > Also, since the sup

Re: Assigning MAC addrs to PCI based NIC's

2020-07-17 Thread Tim Harvey
On Fri, Jul 17, 2020 at 10:08 AM Andrew Lunn wrote: > > On Fri, Jul 17, 2020 at 08:58:26AM -0700, Tim Harvey wrote: > > Greetings, > > > > We make embedded boards that often have on-board PCIe based NIC's that > > have MAC addresses stored in an EEPROM (not within NIC's NVRAM). I've > > struggled

Re: [PATCH net-next 1/3] docs: networking: timestamping: rename last section to "Known bugs".

2020-07-17 Thread Jacob Keller
On 7/17/2020 9:10 AM, Vladimir Oltean wrote: > One more quirk of the timestamping infrastructure will be documented > shortly. Rename the section from "Other caveats for MAC drivers" to > simply "Known bugs". This uncovers some bad phrasing at the beginning of > the section, which is now correct

Re: [PATCH net-next 0/3] Document more PTP timestamping known quirks

2020-07-17 Thread Vladimir Oltean
On Sat, Jul 18, 2020 at 12:13:42AM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > I've tried to collect and summarize the conclusions of these discussions: > > https://patchwork.ozlabs.org/project/netdev/patch/20200711120842.2631-1-sorga...@gmail.com/ > > https://patchwork.ozlabs.or

[PATCH ethtool v2 1/2] ethtool: add support for get/set ethtool_tunable

2020-07-17 Thread Govindarajulu Varadarajan
Add support for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE options. Tested rx-copybreak on enic driver. Tested ETHTOOL_TUNNABLE_STRING options with test/debug changes in kernel. Signed-off-by: Govindarajulu Varadarajan --- v2: * Fix alignments and braces. * Move union definition outside struct. * Mak

[PATCH net-next] tc-testing: Add tdc to kselftests

2020-07-17 Thread Briana Oursler
Add tdc to existing kselftest infrastructure so that it can be run with existing kselftests. TDC now generates objects in objdir/kselftest without cluttering main objdir, leaves source directory clean, and installs correctly in kselftest_install, properly adding itself to run_kselftest.sh script.

Re: [PATCH ethtool 1/2] ethtool: add support for get/set ethtool_tunable

2020-07-17 Thread Govindarajulu Varadarajan (gvaradar)
On Sun, 2020-07-05 at 00:50 +0200, Michal Kubecek wrote: > On Mon, Jun 08, 2020 at 10:52:54AM -0700, Govindarajulu Varadarajan wrote: > > Add support for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE options. > > > > Tested rx-copybreak on enic driver. Tested ETHTOOL_TUNNABLE_STRING >

[PATCH ethtool v2 2/2] man: add man page for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE

2020-07-17 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan --- v2: Add description ethtool.8.in | 40 1 file changed, 40 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 689822e..9a3e9a7 100644 --- a/ethtool.8.in +++ b/ethtool.8.in @@ -398,6 +398,18 @@ ethtool

Re: general protection fault in ath9k_hif_usb_rx_cb (2)

2020-07-17 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:313da01a usb: misc: sisusbvga: Move static const tables ou.. git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=15d1cde71

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-17 Thread Russell King - ARM Linux admin
On Fri, Jul 17, 2020 at 09:42:37PM +0200, Andrew Lunn wrote: > On Fri, Jul 17, 2020 at 07:51:19PM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jul 17, 2020 at 12:50:07PM +, Martin Rowe wrote: > > > On Fri, 17 Jul 2020 at 09:22, Russell King - ARM Linux admin > > > wrote: > > > >

Re: [PATCH] net: genetlink: Move initialization to core_initcall

2020-07-17 Thread Marek Szyprowski
Hi On 15.07.2020 09:41, Daniel Lezcano wrote: > The generic netlink is initialized far after the netlink protocol > itself at subsys_initcall. The devlink is initialized at the same > level, but after, as shown by a disassembly of the vmlinux: > > [ ... ] > 374 8000115f22c0 <__initcall_devlink

Re: [PATCH net-next 0/3] Document more PTP timestamping known quirks

2020-07-17 Thread Sergey Organov
Vladimir Oltean writes: > I've tried to collect and summarize the conclusions of these discussions: > https://patchwork.ozlabs.org/project/netdev/patch/20200711120842.2631-1-sorga...@gmail.com/ > https://patchwork.ozlabs.org/project/netdev/patch/20200710113611.3398-5-k...@linutronix.de/ > which w

RE: [RFC PATCH net-next v2 0/6] introduce PLDM firmware update library

2020-07-17 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Friday, July 17, 2020 12:58 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org; Jiri Pirko ; Tom Herbert > ; Jiri Pirko ; Jakub Kicinski > ; Jonathan Corbet ; Michael Chan > ; Bin Luo ; S

RE: [RFC PATCH net-next v2 0/6] introduce PLDM firmware update library

2020-07-17 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Friday, July 17, 2020 12:58 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org; Jiri Pirko ; Tom Herbert > ; Jiri Pirko ; Jakub Kicinski > ; Jonathan Corbet ; Michael Chan > ; Bin Luo ; Saee

[PATCH net-next] net: bnxt: don't complain if TC flower can't be supported

2020-07-17 Thread Jakub Kicinski
The fact that NETIF_F_HW_TC is not set should be a sufficient indication to the user that TC offloads are not supported. No need to bother users of older firmware versions with pointless warnings on every boot. Also, since the support is optional, bnxt_init_tc() should not return an error in case

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-17 Thread John Crispin
On 17.07.20 22:39, Florian Fainelli wrote: On 7/17/2020 1:29 PM, Matthew Hagan wrote: On 16/07/2020 23:09, Jakub Kicinski wrote: On Mon, 13 Jul 2020 21:50:26 +0100 Matthew Hagan wrote: Add names and decriptions of additional PORT0_PAD_CTRL properties. Signed-off-by: Matthew Hagan --- D

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-17 Thread John Crispin
On 17.07.20 22:29, Matthew Hagan wrote: On 16/07/2020 23:09, Jakub Kicinski wrote: On Mon, 13 Jul 2020 21:50:26 +0100 Matthew Hagan wrote: Add names and decriptions of additional PORT0_PAD_CTRL properties. Signed-off-by: Matthew Hagan --- Documentation/devicetree/bindings/net/dsa/qca8k.t

[PATCH net] net: atlantic: disable PTP on AQC111, AQC112

2020-07-17 Thread Mark Starovoytov
From: Nikita Danilov This patch disables PTP on AQC111 and AQC112 due to a known HW issue, which can cause datapath issues. Ideally PTP block should have been disabled via PHY provisioning, but unfortunately many units have been shipped with enabled PTP block. Thus, we have to work around this i

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-17 Thread Florian Fainelli
On 7/17/2020 1:29 PM, Matthew Hagan wrote: > > > On 16/07/2020 23:09, Jakub Kicinski wrote: >> On Mon, 13 Jul 2020 21:50:26 +0100 Matthew Hagan wrote: >>> Add names and decriptions of additional PORT0_PAD_CTRL properties. >>> >>> Signed-off-by: Matthew Hagan >>> --- >>> Documentation/devicet

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-17 Thread Matthew Hagan
On 16/07/2020 23:09, Jakub Kicinski wrote: > On Mon, 13 Jul 2020 21:50:26 +0100 Matthew Hagan wrote: >> Add names and decriptions of additional PORT0_PAD_CTRL properties. >> >> Signed-off-by: Matthew Hagan >> --- >> Documentation/devicetree/bindings/net/dsa/qca8k.txt | 8 >> 1 file ch

Re: [PATCH V3 net-next 1/8] net: ena: avoid unnecessary rearming of interrupt vector when busy-polling

2020-07-17 Thread Bshara, Nafea
On 7/17/20, 12:53 PM, "David Miller" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. From: Date: Thu, 16 Jul 2020 21:10:03 +0300 > To the best o

Re: [PATCH v2] nfc: nci: add missed destroy_workqueue in nci_register_device

2020-07-17 Thread David Miller
From: Wang Hai Date: Fri, 17 Jul 2020 15:10:16 +0800 > When nfc_register_device fails in nci_register_device, > destroy_workqueue() shouled be called to destroy ndev->tx_wq. > > Fixes: 3c1c0f5dc80b ("NFC: NCI: Fix nci_register_device init sequence") > Reported-by: Hulk Robot > Signed-off-by: Wa

Re: [pull request][net-next V2 00/15] mlx5 updates 2020-07-16

2020-07-17 Thread David Miller
From: Saeed Mahameed Date: Thu, 16 Jul 2020 17:03:55 -0700 > This patchset includes mlx5 RX XFRM ipsec offloads for ConnectX devices > and some other misc updates and fixes to net-next. > v1->v2: > - Fix "was not declared" build warning when RETPOLINE=y, reported by Jakub. > > For more informat

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-17 Thread Florian Fainelli
On 7/17/2020 12:26 PM, Matthew Hagan wrote: > > > On 16/07/2020 23:32, Andrew Lunn wrote: >> On Thu, Jul 16, 2020 at 03:09:25PM -0700, Jakub Kicinski wrote: >>> On Mon, 13 Jul 2020 21:50:26 +0100 Matthew Hagan wrote: Add names and decriptions of additional PORT0_PAD_CTRL properties.

Re: [PATCH net 0/3] net: bcmgenet: fix WAKE_FILTER resume from deep sleep

2020-07-17 Thread David Miller
From: Doug Berger Date: Thu, 16 Jul 2020 16:38:14 -0700 > The WAKE_FILTER logic can only wake the system from the standby > power state. However, some systems that include the GENET IP > support deeper power saving states and the driver should suspend > and resume correctly from those states as w

Re: [RFC PATCH net-next v2 0/6] introduce PLDM firmware update library

2020-07-17 Thread Jakub Kicinski
On Fri, 17 Jul 2020 11:35:35 -0700 Jacob Keller wrote: > This series goal is to enable support for updating the ice hardware flash > using the devlink flash command. Looks reasonable. You have some left over references to ignore_pending_flash_update in comments, and you should use NLA_POLICY_RANG

Re: [PATCH] net: alteon: Avoid some useless memset

2020-07-17 Thread David Miller
From: Christophe JAILLET Date: Thu, 16 Jul 2020 22:52:42 +0200 > Avoid a memset after a call to 'dma_alloc_coherent()'. > This is useless since > commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") > > Replace a kmalloc+memset with a corresponding kzalloc. > > Signed-off-

Re: [PATCH] net: alteon: switch from 'pci_' to 'dma_' API

2020-07-17 Thread David Miller
From: Christophe JAILLET Date: Thu, 16 Jul 2020 22:48:02 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: sungem: switch from 'pci_' to 'dma_' API

2020-07-17 Thread David Miller
From: Christophe JAILLET Date: Thu, 16 Jul 2020 21:28:21 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: decnet: af_decnet: Simplify goto loop.

2020-07-17 Thread David Miller
From: Suraj Upadhyay Date: Fri, 17 Jul 2020 00:46:45 +0530 > Replace goto loop with while loop. > > Signed-off-by: Suraj Upadhyay Applied to net-next.

Re: [PATCH net-next 0/2] tcp: improve handling of DSACK covering multiple segments

2020-07-17 Thread David Miller
From: Priyaranjan Jha Date: Thu, 16 Jul 2020 12:12:33 -0700 > Currently, while processing DSACK, we assume DSACK covers only one > segment. This leads to significant underestimation of no. of duplicate > segments with LRO/GRO. Also, the existing SNMP counters, TCPDSACKRecv > and TCPDSACKOfoRecv,

Re: [PATCH] net: sun: cassini: switch from 'pci_' to 'dma_' API

2020-07-17 Thread David Miller
From: Christophe JAILLET Date: Thu, 16 Jul 2020 21:03:58 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH V3 net-next 1/8] net: ena: avoid unnecessary rearming of interrupt vector when busy-polling

2020-07-17 Thread David Miller
From: Date: Thu, 16 Jul 2020 21:10:03 +0300 > To the best of my knowledge this assumption holds for ARM64 and x86_64 > architecture which use a MESI like cache coherency model. Use the well defined kernel memory model correctly please. This is no place for architectural assumptions. The memory

Re: [PATCH v2] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-17 Thread David Miller
From: Paolo Pisati Date: Thu, 16 Jul 2020 17:51:14 +0200 > Fix ip_defrag.sh when CONFIG_NF_DEFRAG_IPV6=m: > > $ sudo ./ip_defrag.sh > + set -e > + mktemp -u XX > + readonly NETNS=ns-rGlXcw > + trap cleanup EXIT > + setup > + ip netns add ns-rGlXcw > + ip -netns ns-rGlXcw link set lo up > + i

Re: [PATCH -next] dpaa2-eth: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-17 Thread David Miller
From: Qinglang Miao Date: Thu, 16 Jul 2020 16:58:59 +0800 > From: Yongqiang Liu > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yongqiang Liu This also does not apply cleanly to the net-next tree.

Re: [Regression] "SUNRPC: Add "@len" parameter to gss_unwrap()" breaks NFS Kerberos on upstream stable 5.4.y

2020-07-17 Thread Pierre Sauter
Am Freitag, 17. Juli 2020, 19:56:09 CEST schrieb Kai-Heng Feng: > > Pierre, thanks for confirming! > > > > Kai-Heng suspected an upstream stable commit that is missing in 5.4.0-40, > > but I don't have any good suggestions. > > Well, Ubuntu's 5.4 kernel is based on upstream stable v5.4, so I aske

Re: [PATCH -next] hsr: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-17 Thread David Miller
From: Qinglang Miao Date: Thu, 16 Jul 2020 16:47:28 +0800 > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao This does not apply to the net-next tree.

Re: [PATCH] net: smc91x: Fix possible memory leak in smc_drv_probe()

2020-07-17 Thread David Miller
From: Wang Hai Date: Thu, 16 Jul 2020 11:50:38 +0800 > If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev) > should be called to free the ndev created earlier. Otherwise, a memleak > will occur. > > Fixes: 7d2911c43815 ("net: smc91x: Fix gpios for device tree based booting"

Re: [PATCH v5 net-next 0/5] usbnet: multicast filter support for cdc ncm devices

2020-07-17 Thread David Miller
From: Bjørn Mork Date: Wed, 15 Jul 2020 20:40:55 +0200 > This revives a 2 year old patch set from Miguel Rodríguez > Pérez, which appears to have been lost somewhere along the > way. I've based it on the last version I found (v4), and > added one patch which I believe must have been missing in >

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-17 Thread Andrew Lunn
On Fri, Jul 17, 2020 at 07:51:19PM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jul 17, 2020 at 12:50:07PM +, Martin Rowe wrote: > > On Fri, 17 Jul 2020 at 09:22, Russell King - ARM Linux admin > > wrote: > > > The key file is /sys/kernel/debug/mv88e6xxx.0/regs - please send the > >

Re: [PATCH v5 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

2020-07-17 Thread David Miller
From: Weilong Chen Date: Wed, 15 Jul 2020 20:58:10 +0800 > When vlan_newlink call register_vlan_dev fails, it might return error > with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should > free the memory. But currently rtnl_newlink only free the memory which > state is NETREG_UNINITIA

Re: [PATCH net-next v2 5/6] enetc: Add interrupt coalescing support

2020-07-17 Thread Jakub Kicinski
On Fri, 17 Jul 2020 18:37:03 +0300 Claudiu Manoil wrote: > + if (ic->rx_max_coalesced_frames != ENETC_RXIC_PKTTHR) > + netif_warn(priv, hw, ndev, "rx-frames fixed to %d\n", > +ENETC_RXIC_PKTTHR); > + > + if (ic->tx_max_coalesced_frames != ENETC_TXIC_PKTTH

Re: [PATCH net 04/10] net/smc: protect smc ib device initialization

2020-07-17 Thread David Miller
From: Karsten Graul Date: Thu, 16 Jul 2020 17:37:40 +0200 > Fix that by protecting the critical code using a mutex. ... > @@ -52,6 +52,7 @@ struct smc_ib_device { /* > ib-device infos for smc */ > DECLARE_BITMAP(ports_going_away, SMC_MAX_PORTS); > atomic

  1   2   3   >