[PATCH] ipvs: fix the connection sync failed in some cases

2020-07-14 Thread guodeqing
The sync_thread_backup only checks sk_receive_queue is empty or not, there is a situation which cannot sync the connection entries when sk_receive_queue is empty and sk_rmem_alloc is larger than sk_rcvbuf, the sync packets are dropped in __udp_enqueue_schedule_skb, this is because the packets in re

Re: [PATCH bpf] bpf: Shift and mask loads narrower than context field size

2020-07-14 Thread Yonghong Song
On 7/10/20 10:31 AM, Jakub Sitnicki wrote: When size of load from context is the same as target field size, but less than context field size, the verifier does not emit the shift and mask instructions for loads at non-zero offset. This has the unexpected effect of loading the same data no mat

Re: [PATCH net-next v3 2/4] net/sched: Introduce action hash

2020-07-14 Thread Cong Wang
On Mon, Jul 13, 2020 at 8:17 PM Ariel Levkovich wrote: > > On 7/13/20 6:04 PM, Cong Wang wrote: > > On Sat, Jul 11, 2020 at 2:28 PM Ariel Levkovich wrote: > >> Allow user to set a packet's hash value using a bpf program. > >> > >> The user provided BPF program is required to compute and return >

回复: [PATCH v2] tipc: Don't using smp_processor_id() in preemptible code

2020-07-14 Thread Zhang, Qiang
发件人: Zhang, Qiang 发送时间: 2020年7月15日 13:27 收件人: Tuong Tong Lien; Eric Dumazet; jma...@redhat.com; da...@davemloft.net; k...@kernel.org; Xue, Ying 抄送: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux-ker...@vger.kernel.org 主题: 回复: [PATC

Re: [PATCH v4 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

2020-07-14 Thread Cong Wang
On Tue, Jul 14, 2020 at 6:27 PM Weilong Chen wrote: > > When vlan_newlink call register_vlan_dev fails, it might return error > with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should > free the memory. But currently rtnl_newlink only free the memory which > state is NETREG_UNINITIALIZE

Re: BUG: soft lockup in smp_call_function

2020-07-14 Thread syzbot
syzbot has bisected this issue to: commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22 Author: Vinicius Costa Gomes Date: Sat Sep 29 00:59:43 2018 + tc: Add support for configuring the taprio scheduler bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1196d06f10 start commi

INFO: rcu detected stall in __do_sys_clock_adjtime

2020-07-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a581387e Merge tag 'io_uring-5.8-2020-07-10' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1312c27710 kernel config: https://syzkaller.appspot.com/x/.config?x=66ad203c2bb6d8b dash

回复: [PATCH v2] tipc: Don't using smp_processor_id() in preemptible code

2020-07-14 Thread Zhang, Qiang
发件人: Tuong Tong Lien 发送时间: 2020年7月15日 11:53 收件人: Zhang, Qiang; Eric Dumazet; jma...@redhat.com; da...@davemloft.net; k...@kernel.org; Xue, Ying 抄送: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux-ker...@vger.kernel.org 主题: RE: [PATC

[PATCH bpf-next] bpftool: use only nftw for file tree parsing

2020-07-14 Thread Tony Ambardar
The bpftool sources include code to walk file trees, but use multiple frameworks to do so: nftw and fts. While nftw conforms to POSIX/SUSv3 and is widely available, fts is not conformant and less common, especially on non-glibc systems. The inconsistent framework usage hampers maintenance and porta

Re: [PATCH bpf-next v2 1/4] bpf: setup socket family and addresses in bpf_prog_test_run_skb

2020-07-14 Thread kernel test robot
/bpf-next.git master config: microblaze-randconfig-r001-20200714 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

[PATCH mlx5-next 4/4] net/mlx5: Enable count action for rules with allow action

2020-07-14 Thread Saeed Mahameed
From: Michael Guralnik Enable the creation of rules with allow and count actions. This enables using counters on egress flow tables. Signed-off-by: Michael Guralnik Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 1 + 1 file chang

[PATCH mlx5-next 2/4] net/mlx5: Add VDPA interface type to supported enumerations

2020-07-14 Thread Saeed Mahameed
From: Eli Cohen VDPA is a new interface that will be added in subsequent patches. It uses mlx5 core devices and resources. Add an interface type for it. Signed-off-by: Eli Cohen Reviewed-by: Parav Pandit Signed-off-by: Saeed Mahameed --- include/linux/mlx5/driver.h | 1 + 1 file changed, 1 i

[PATCH mlx5-next 1/4] net/mlx5: Support setting access rights of dma addresses

2020-07-14 Thread Saeed Mahameed
From: Eli Cohen mlx5_fill_page_frag_array() is used to populate dma addresses to resources that require it, such as QPs, RQs etc. When the resource is used, PA list permissions are ignored. For resources that use MTT list, the user is required to provide the access rights. Subsequent patches use

[PATCH mlx5-next 0/4] mlx5 next updates 2020-07-14

2020-07-14 Thread Saeed Mahameed
Hi, This patchset introduces some updates to mlx5 next shared branch. 1) Eli Cohen, Adds HW and mlx5_core driver definitions and bits for upcoming mlx5 VDPA driver support. 2) Michael Guralnik Enables count actions for simple allow steering rule. In case of no objections this patchset will be ap

[PATCH mlx5-next 3/4] net/mlx5: Add interface changes required for VDPA

2020-07-14 Thread Saeed Mahameed
From: Eli Cohen Rename mlx5_ifc_device_virtio_emulation_cap_bits to mlx5_ifc_virtio_emulation_cap_bits to match names produced by the tools producing these auto generated files. In addition missing capabilities that will be required by VDPA implementation. Signed-off-by: Eli Cohen Reviewed-by:

RE: [PATCH v2] tipc: Don't using smp_processor_id() in preemptible code

2020-07-14 Thread Tuong Tong Lien
> -Original Message- > From: Zhang, Qiang > Sent: Wednesday, July 15, 2020 9:13 AM > To: Eric Dumazet ; jma...@redhat.com; > da...@davemloft.net; k...@kernel.org; Tuong Tong Lien > ; Xue, Ying > Cc: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; > linux-ker...@vger.ker

RE: [PATCH v4 08/10] net: eth: altera: add support for ptp and timestamping

2020-07-14 Thread Ooi, Joyce
> -Original Message- > From: Richard Cochran > Sent: Thursday, July 9, 2020 7:31 PM > To: Ooi, Joyce > Cc: Thor Thayer ; David S . Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Dalon Westergreen > ; Tan, Ley Foon > ; See, Chin Liang ; > Nguyen, Dinh ;

Re: [PATCHv7 bpf-next 0/3] xdp: add a new helper for dev map multicast support

2020-07-14 Thread Hangbin Liu
On Tue, Jul 14, 2020 at 11:12:59AM -0600, David Ahern wrote: > >> with pktgen(pkt size 64) to compire with xdp_redirect_map(). Here is the > >> test result(the veth peer has a dummy xdp program with XDP_DROP directly): > >> > >> Version | Test | Native | Ge

Re: [PATCH bpf-next v2 1/4] bpf: setup socket family and addresses in bpf_prog_test_run_skb

2020-07-14 Thread kernel test robot
/bpf-next.git master config: arm64-randconfig-r005-20200714 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master

[PATCH] tools/bpftool: Fix error return code in do_skeleton()

2020-07-14 Thread YueHaibing
The error return code should be PTR_ERR(obj) other than PTR_ERR(NULL). Fixes: 5dc7a8b21144 ("bpftool, selftests/bpf: Embed object file inside skeleton") Signed-off-by: YueHaibing --- tools/bpf/bpftool/gen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/

[PATCH net-next] bareudp: Reverted support to enable & disable rx metadata collection

2020-07-14 Thread Martin Varghese
From: Martin Varghese The commit fe80536acf83 ("bareudp: Added attribute to enable & disable rx metadata collection") breaks the the original(5.7) default behavior of bareudp module to collect RX metadadata at the receive. It was added to avoid the crash at the kernel neighbour subsytem when pack

[PATCH 02/13 net-next] net: wireless.h: drop duplicate word in comments

2020-07-14 Thread Randy Dunlap
Drop doubled word "threshold" in a comment. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- include/uapi/linux/wireless.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/u

[PATCH 03/13 net-next] net: qed: drop duplicate words in comments

2020-07-14 Thread Randy Dunlap
s(-) --- linux-next-20200714.orig/include/linux/qed/qed_chain.h +++ linux-next-20200714/include/linux/qed/qed_chain.h @@ -130,7 +130,7 @@ struct qed_chain { } pbl_sp; /* Address of first page of the chain - the address is required -* for fastpath operation [consume/produce]

[PATCH 06/13 net-next] net: 9p: drop duplicate word in comment

2020-07-14 Thread Randy Dunlap
Drop doubled word "not" in a comment. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- include/net/9p/transport.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/net/9p/transp

[PATCH 01/13 net-next] net: nl80211.h: drop duplicate words in comments

2020-07-14 Thread Randy Dunlap
Drop doubled words in several comments. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- include/uapi/linux/nl80211.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) --- linux-next-20200714.orig/include/

[PATCH 12/13 net-next] net: regulatory.h: drop duplicate word in comment

2020-07-14 Thread Randy Dunlap
Drop doubled word "of" in a comment. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- include/net/regulatory.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/net/regulat

[PATCH 09/13 net-next] net: dsa.h: drop duplicate word in comment

2020-07-14 Thread Randy Dunlap
Drop doubled word "to" in a comment. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- include/net/dsa.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/net/dsa.h +++ linux-n

[PATCH 10/13 net-next] net: ip6_fib.h: drop duplicate word in comment

2020-07-14 Thread Randy Dunlap
Drop doubled word "the" in a comment. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- include/net/ip6_fib.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/net/ip6_fib.h +++

[PATCH 11/13 net-next] net: mac80211.h: drop duplicate words in comments

2020-07-14 Thread Randy Dunlap
Drop doubled words "are" and "by" in comments. Change doubled "to to" to "to the". Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- include/net/mac80211.h |6 +++--- 1 file changed, 3 inse

[PATCH 07/13 net-next] net: caif: drop duplicate words in comments

2020-07-14 Thread Randy Dunlap
es changed, 3 insertions(+), 3 deletions(-) --- linux-next-20200714.orig/include/net/caif/caif_layer.h +++ linux-next-20200714/include/net/caif/caif_layer.h @@ -156,7 +156,7 @@ struct cflayer { * CAIF packets upwards in the stack. * Packet handling rules: *

[PATCH 05/13 net-next] net: wimax: fix duplicate words in comments

2020-07-14 Thread Randy Dunlap
deletions(-) --- linux-next-20200714.orig/include/linux/wimax/debug.h +++ linux-next-20200714/include/linux/wimax/debug.h @@ -184,8 +184,8 @@ do { \ /* - * CPP sintatic sugar to generate A_B like symbol names when one of - * the argu

[PATCH 13/13 net-next] net: sctp: drop duplicate words in comments

2020-07-14 Thread Randy Dunlap
Drop doubled words in several comments. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- include/net/sctp/sctp.h|2 +- include/net/sctp/structs.h |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) --- linux-nex

[PATCH 08/13 net-next] net: cfg80211.h: drop duplicate words in comments

2020-07-14 Thread Randy Dunlap
insertions(+), 2 deletions(-) --- linux-next-20200714.orig/include/net/cfg80211.h +++ linux-next-20200714/include/net/cfg80211.h @@ -423,7 +423,7 @@ struct ieee80211_edmg { * This structure describes a frequency band a wiphy * is able to operate in. * - * @channels: Array of channels the hard

[PATCH 04/13 net-next] net: skbuff.h: drop duplicate words in comments

2020-07-14 Thread Randy Dunlap
Drop doubled words in several comments. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- include/linux/skbuff.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200714.orig/include/linux/skbuff.h +++

[PATCH net-next] netpoll: Remove unused inline function netpoll_netdev_init()

2020-07-14 Thread YueHaibing
commit d565b0a1a9b6 ("net: Add Generic Receive Offload infrastructure") left behind this, remove it. Signed-off-by: YueHaibing --- include/linux/netpoll.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h index f47af135bd56..e6a2d72e0dc7 1006

[PATCH net-next] mptcp: Remove unused inline function mptcp_rcv_synsent()

2020-07-14 Thread YueHaibing
commit 263e1201a2c3 ("mptcp: consolidate synack processing.") left behind this, remove it. Signed-off-by: YueHaibing --- include/net/mptcp.h | 4 1 file changed, 4 deletions(-) diff --git a/include/net/mptcp.h b/include/net/mptcp.h index 46d0487d2b22..02158c257bd4 100644 --- a/include/net/

[PATCH net-next] net: flow: Remove unused inline function

2020-07-14 Thread YueHaibing
It is not used since commit 09c7570480f7 ("xfrm: remove flow cache") Signed-off-by: YueHaibing --- include/net/flow.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/include/net/flow.h b/include/net/flow.h index a50fb77a0b27..929d3ca614d0 100644 --- a/include/net/flow.h ++

Re: [PATCH net-next] cipso: Remove unused inline functions

2020-07-14 Thread Paul Moore
On Tue, Jul 14, 2020 at 10:21 PM YueHaibing wrote: > > They are not used any more since commit b1edeb102397 ("netlabel: Replace > protocol/NetLabel linking with refrerence counts") > > Signed-off-by: YueHaibing > --- > include/net/cipso_ipv4.h | 12 > 1 file changed, 12 deletions(-)

[PATCH net-next] cipso: Remove unused inline functions

2020-07-14 Thread YueHaibing
They are not used any more since commit b1edeb102397 ("netlabel: Replace protocol/NetLabel linking with refrerence counts") Signed-off-by: YueHaibing --- include/net/cipso_ipv4.h | 12 1 file changed, 12 deletions(-) diff --git a/include/net/cipso_ipv4.h b/include/net/cipso_ipv4.h

回复: [PATCH v2] tipc: Don't using smp_processor_id() in preemptible code

2020-07-14 Thread Zhang, Qiang
发件人: Eric Dumazet 发送时间: 2020年7月14日 22:15 收件人: Zhang, Qiang; jma...@redhat.com; da...@davemloft.net; k...@kernel.org; tuong.t.l...@dektech.com.au; eric.duma...@gmail.com; Xue, Ying 抄送: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux-

[PATCH 2/4] cdc_ether: export usbnet_cdc_update_filter

2020-07-14 Thread Wxcafé
Fixed the title, sorry -- Wxcafé On Tue, 2020-07-14 at 21:25 -0400, Wxcafé wrote: > This makes the function available to other drivers, like cdn_ncm. > > Signed-off-by: Miguel Rodríguez Pérez > --- > drivers/net/usb/cdc_ether.c | 3 ++- > include/linux/usb/usbnet.h | 1 + > 2 files changed,

[PATCH 4/4] cdc_ncm: hook into set_rx_mode to admit multicast traffic

2020-07-14 Thread Wxcafé
We set set_rx_mode to usbnet_cdc_update_filter provided by cdc_ether that simply admits all multicast traffic if there is more than one multicast filter configured. Signed-off-by: Miguel Rodríguez Pérez --- drivers/net/usb/cdc_ncm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/

[PATCH 3/4] cdc_ncm: replace the way cdc_ncm hooks into usbnet_change_mtu

2020-07-14 Thread Wxcafé
Previously cdc_ncm overwrited netdev_ops used by usbnet thus preventing hooking into set_rx_mode. This patch preserves usbnet hooks into netdev_ops, and add an additional one for change_mtu needed by cdc_ncm. Signed-off-by: Miguel Rodríguez Pérez --- drivers/net/usb/cdc_ncm.c | 13 +++--

[PATCH 2/4] cdc_ether: use dev->intf to get interface information

2020-07-14 Thread Wxcafé
This makes the function available to other drivers, like cdn_ncm. Signed-off-by: Miguel Rodríguez Pérez --- drivers/net/usb/cdc_ether.c | 3 ++- include/linux/usb/usbnet.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ethe

[PATCH 1/4] cdc_ether: use dev->intf to get interface information

2020-07-14 Thread Wxcafé
usbnet_cdc_update_filter was getting the interface number from the usb_interface struct in cdc_state->control. However, cdc_ncm does not initialize that structure in its bind function, but uses cdc_ncm_cts instead. Getting intf directly from struct usbnet solves the problem. Signed-off-by: Miguel

[PATCH mlx5-next 0/4] mlx5 next updates 2020-07-14

2020-07-14 Thread Saeed Mahameed
Hi, This patchset introduces some updates to mlx5 next shared branch. 1) Eli Cohen, Adds HW and mlx5_core driver definitions and bits for upcoming mlx5 VDPA driver support. 2) Michael Guralnik Enables count actions for simple allow steering rule. In case of no objections this patchset will be ap

RE: [net-next 1/5] ice: add the virtchnl handler for AdminQ command

2020-07-14 Thread Wang, Haiyue
> -Original Message- > From: Jakub Kicinski > Sent: Wednesday, July 15, 2020 02:24 > To: Wang, Haiyue > Cc: Nguyen, Anthony L ; da...@davemloft.net; > netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com; Kirsher, Jeffrey T > ; Lu, Nannan > ; Bowers, AndrewX > Subject: Re:

Re: [PATCH net-next v3 1/4] net/sched: Add skb->hash field editing via act_skbedit

2020-07-14 Thread David Ahern
On 7/11/20 3:28 PM, Ariel Levkovich wrote: > @@ -156,6 +173,17 @@ static int tcf_skbedit_init(struct net *net, struct > nlattr *nla, > flags |= SKBEDIT_F_INHERITDSFIELD; > } > > + if (tb[TCA_SKBEDIT_HASH] != NULL) { > + hash_alg = nla_get_u32(tb[TCA_SK

[PATCH v4 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

2020-07-14 Thread Weilong Chen
When vlan_newlink call register_vlan_dev fails, it might return error with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should free the memory. But currently rtnl_newlink only free the memory which state is NETREG_UNINITIALIZED. BUG: memory leak unreferenced object 0x8881051de000 (si

Re: [PATCH net-next v2] hinic: add firmware update support

2020-07-14 Thread luobin (L)
On 2020/7/15 2:37, Jakub Kicinski wrote: > On Tue, 14 Jul 2020 20:54:33 +0800 Luo bin wrote: >> add support to update firmware by the devlink flashing API >> >> Signed-off-by: Luo bin > > Minor nits below, otherwise I think this looks good. > >> +static int hinic_firmware_update(struct hinic_dev

Re: [PATCH net-next v3 00/12] udp_tunnel: NIC RX port offload infrastructure

2020-07-14 Thread David Miller
From: Jakub Kicinski Date: Tue, 14 Jul 2020 12:18:18 -0700 > This set of patches converts further drivers to use the new > infrastructure to UDP tunnel port offload merged in > commit 0ea460474d70 ("Merge branch > 'udp_tunnel-add-NIC-RX-port-offload-infrastructure'"). > > v3: > - fix a W=1 bui

Re: pull-request: bpf-next 2020-07-14

2020-07-14 Thread David Miller
From: Alexei Starovoitov Date: Tue, 14 Jul 2020 15:58:07 -0700 > The following pull-request contains BPF updates for your *net-next* tree. > > We've added 21 non-merge commits during the last 1 day(s) which contain > a total of 20 files changed, 308 insertions(+), 279 deletions(-). > > The main

Re: [PATCH iproute2-next 2/2] ss: mptcp: add msk diag interface support

2020-07-14 Thread David Ahern
On 7/10/20 7:52 AM, Paolo Abeni wrote: > This implement support for MPTCP sockets type, comprising > extended socket info. Note that we need to add an extended > attribute carrying the actual protocol number to the diag > request. > > Signed-off-by: Paolo Abeni > --- > misc/ss.c | 115 ++

Re: mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c)

2020-07-14 Thread Saeed Mahameed
On Sun, 2020-07-12 at 21:17 -0700, Randy Dunlap wrote: > On 7/12/20 9:02 PM, Stephen Rothwell wrote: > > Hi Randy, > > > > On Fri, 10 Jul 2020 10:40:29 -0700 Randy Dunlap < > > rdun...@infradead.org> wrote: > > > on i386: > > > > > > In file included from > > > ../drivers/net/ethernet/mellanox/ml

Re: [PATCH iproute2-next master] bridge: fdb show: fix fdb entry state output for json context

2020-07-14 Thread Stephen Hemminger
On Wed, 15 Jul 2020 01:35:33 +0200 Julien Fortin wrote: > On Mon, Jul 13, 2020 at 4:54 PM Stephen Hemminger < > step...@networkplumber.org> wrote: > > > On Fri, 10 Jul 2020 02:50:55 +0200 > > Julien Fortin wrote: > > > > > From: Julien Fortin > > > > > > bridge json fdb show is printing an

Re: [PATCH RFC net-next 00/13] Phylink PCS updates

2020-07-14 Thread Vladimir Oltean
I'll preface my reply by stating that this is my opinion and that it is not representative of what you might be visualizing as "NXP". It's not that I am trying to evade responsibility by saying this, but rather that backplane Ethernet is simply not my responsibility, in fact I have no saying at all

Re: [PATCH iproute2-next master] bridge: fdb show: fix fdb entry state output for json context

2020-07-14 Thread Julien Fortin
On Mon, Jul 13, 2020 at 4:54 PM Stephen Hemminger wrote: > > On Fri, 10 Jul 2020 02:50:55 +0200 > Julien Fortin wrote: > > > From: Julien Fortin > > > > bridge json fdb show is printing an incorrect / non-machine readable > > value, when using -j (json output) we are expecting machine readable >

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Westergreen, Dalon
On Tue, 2020-07-14 at 13:23 -0700, David Miller wrote: > From: "Westergreen, Dalon" > Date: Tue, 14 Jul 2020 18:51:15 + > > > I don't think this is necessary, i think just having a module parameter > > meets our needs. I don't see a need for the value to change on a per > > interface basis

Re: WARNING in __kernel_write

2020-07-14 Thread syzbot
syzbot has bisected this issue to: commit 81238b2cff1469ff5b94390d026cd075105d6dcd Author: Christoph Hellwig Date: Thu May 7 17:33:03 2020 + fs: implement kernel_write using __kernel_write bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d829bf10 start commit: be97

Re: BPF logging infrastructure. Was: [PATCH bpf-next 4/6] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

2020-07-14 Thread Alexei Starovoitov
On Wed, Jul 15, 2020 at 12:19:03AM +0200, Toke Høiland-Jørgensen wrote: > Andrii Nakryiko writes: > > >> However, assuming it *is* possible, my larger point was that we > >> shouldn't add just a 'logging struct', but rather a 'common options > >> struct' which can be extended further as needed. A

pull-request: bpf-next 2020-07-14

2020-07-14 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net-next* tree. We've added 21 non-merge commits during the last 1 day(s) which contain a total of 20 files changed, 308 insertions(+), 279 deletions(-). The main changes are: 1) Fix selftests/bpf build, from Alexei. 2) Fix re

Re: [RFC PATCH bpf-next 4/5] bpf, x64: rework pro/epilogue and tailcall handling in JIT

2020-07-14 Thread Alexei Starovoitov
On Tue, Jul 14, 2020 at 1:55 PM Maciej Fijalkowski wrote: > > On Mon, Jul 13, 2020 at 08:36:30PM -0700, Alexei Starovoitov wrote: > > On Tue, Jul 14, 2020 at 03:00:45AM +0200, Maciej Fijalkowski wrote: > > > On Fri, Jul 10, 2020 at 08:25:20PM -0700, Alexei Starovoitov wrote: > > > > On Fri, Jul 10

Re: [PATCH] net: dsa: microchip: look for phy-mode in port nodes

2020-07-14 Thread Andrew Lunn
On Tue, Jul 14, 2020 at 02:08:28PM +0200, Helmut Grohne wrote: > Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode > property should be specified on port nodes. However, the microchip > drivers read it from the switch node. > > Let the driver use the per-port property and fa

Re: [PATCH bpf-next 2/7] bpf, xdp: add bpf_link-based XDP attachment API

2020-07-14 Thread Andrii Nakryiko
On Tue, Jul 14, 2020 at 2:41 PM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Tue, Jul 14, 2020 at 1:13 PM Toke Høiland-Jørgensen > > wrote: > >> > >> Andrii Nakryiko writes: > >> > >> > On Tue, Jul 14, 2020 at 6:57 AM Toke Høiland-Jørgensen > >> > wrote: > >> >> > >> >>

Re: BPF logging infrastructure. Was: [PATCH bpf-next 4/6] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

2020-07-14 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: >> However, assuming it *is* possible, my larger point was that we >> shouldn't add just a 'logging struct', but rather a 'common options >> struct' which can be extended further as needed. And if it is *not* >> possible to add new arguments to a syscall like you're propos

Re: [PATCH net] qed: Disable "MFW indication via attention" SPAM every 5 minutes

2020-07-14 Thread David Miller
From: Laurence Oberman Date: Tue, 14 Jul 2020 18:08:05 -0400 > This is likely firmware causing this but its starting to annoy customers. > Change the message level to verbose to prevent the spam. > Note that this seems to only show up with ISCSI enabled on the HBA via the > qedi driver. > > Sig

Re: [PATCH] ksz884x: switch from 'pci_' to 'dma_' API

2020-07-14 Thread David Miller
From: Christophe JAILLET Date: Tue, 14 Jul 2020 20:35:01 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH net-next 0/2] r8169: add support for RTL8125B

2020-07-14 Thread David Miller
From: Heiner Kallweit Date: Tue, 14 Jul 2020 17:43:20 +0200 > This series adds support for RTL8125B rev.b. > Tested with a Delock 89564 PCIe card. Series applied, thanks Heiner.

[PATCH net] qed: Disable "MFW indication via attention" SPAM every 5 minutes

2020-07-14 Thread Laurence Oberman
This is likely firmware causing this but its starting to annoy customers. Change the message level to verbose to prevent the spam. Note that this seems to only show up with ISCSI enabled on the HBA via the qedi driver. Signed-off-by: Laurence Oberman --- drivers/net/ethernet/qlogic/qed/qed_int.

Re: [PATCH] selftests: fib_nexthop_multiprefix: fix cleanup() netns deletion

2020-07-14 Thread David Miller
From: Paolo Pisati Date: Tue, 14 Jul 2020 17:40:55 +0200 > During setup(): > ... > for ns in h0 r1 h1 h2 h3 > do > create_ns ${ns} > done > ... > > while in cleanup(): > ... > for n in h1 r1 h2 h3 h4 > do > ip netns del ${n}

Re: BPF logging infrastructure. Was: [PATCH bpf-next 4/6] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

2020-07-14 Thread Andrii Nakryiko
On Tue, Jul 14, 2020 at 1:47 PM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Tue, Jul 14, 2020 at 5:12 AM Toke Høiland-Jørgensen > > wrote: > >> > >> Andrii Nakryiko writes: > >> > >> > On Mon, Jul 13, 2020 at 1:13 PM Toke Høiland-Jørgensen > >> > wrote: > >> >> > >> >>

Re: [PATCH net-next 00/10] s390/qeth: updates 2020-07-14

2020-07-14 Thread David Miller
From: Julian Wiedmann Date: Tue, 14 Jul 2020 16:22:55 +0200 > please apply the following patch series for qeth to netdev's net-next tree. > > This brings a mix of cleanups for various parts of the control code. Series applied, thanks Julian.

Re: [PATCHv7 bpf-next 0/3] xdp: add a new helper for dev map multicast support

2020-07-14 Thread Toke Høiland-Jørgensen
>David Ahern writes: > On 7/14/20 6:29 AM, Toke Høiland-Jørgensen wrote: >> Hangbin Liu writes: >> >>> This patch is for xdp multicast support. which has been discussed before[0], >>> The goal is to be able to implement an OVS-like data plane in XDP, i.e., >>> a software switch that can forward

Re: [PATCHv7 bpf-next 1/3] xdp: add a new helper for dev map multicast support

2020-07-14 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > This patch is for xdp multicast support. which has been discussed > before[0], The goal is to be able to implement an OVS-like data plane in XDP, > i.e., a software switch that can forward XDP frames to multiple ports. > > To achieve this, an application needs to specify a g

Hello,

2020-07-14 Thread Mrs. Daborah Raymond
Dear friend, I have a business container transaction what that some of( $13million dollars) I would like to discuss with you. If you are interested, please contact my email address (mrs.victoria.alexand...@gmail.com) My WhatsApp number but only message +19293737780 Please do not reply if you

Re: [PATCH net-next 00/13] mlxsw: Mirror to CPU preparations

2020-07-14 Thread David Miller
From: Ido Schimmel Date: Tue, 14 Jul 2020 17:20:53 +0300 > From: Ido Schimmel > > A future patch set will add the ability to trap packets that were > dropped due to buffer related reasons (e.g., early drop). Internally > this is implemented by mirroring these packets towards the CPU port. > Thi

Re: [PATCH] qed (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes

2020-07-14 Thread David Miller
From: Laurence Oberman Date: Tue, 14 Jul 2020 09:50:29 -0400 > This is likely firmware causing this but its starting to annoy customers. > Change the message level to verbose to prevent the spam. > Note that this seems to only show up with ISCSI enabled on the HBA via the > qedi driver. > > Sig

Re: [PATCH bpf-next 2/7] bpf, xdp: add bpf_link-based XDP attachment API

2020-07-14 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Jul 14, 2020 at 1:13 PM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> > On Tue, Jul 14, 2020 at 6:57 AM Toke Høiland-Jørgensen >> > wrote: >> >> >> >> Andrii Nakryiko writes: >> >> >> >> > Add bpf_link-based API (bpf_xdp_link) to attac

Re: [PATCH 1/1] ax88172a: fix ax88172a_unbind() failures

2020-07-14 Thread David Miller
From: George Kennedy Date: Tue, 14 Jul 2020 17:34:33 -0400 > For example, the failing case here has "ret" = 0 (#define ETH_ALEN 6): > >     172 static int ax88172a_bind(struct usbnet *dev, struct > usb_interface *intf) >     173 { > ... >     186 /* Get the MAC address */ >     187  

Re: [PATCH 1/1] ax88172a: fix ax88172a_unbind() failures

2020-07-14 Thread George Kennedy
On 7/14/2020 5:03 PM, David Miller wrote: From: Dan Carpenter Date: Tue, 14 Jul 2020 11:00:38 +0300 On Mon, Jul 13, 2020 at 05:08:59PM -0700, David Miller wrote: From: George Kennedy Date: Mon, 13 Jul 2020 07:58:57 -0400 @@ -237,6 +237,8 @@ static int ax88172a_bind(struct usbnet *dev, s

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Jarod Wilson
On Tue, Jul 14, 2020 at 4:39 PM Marcelo Ricardo Leitner wrote: > > On Tue, Jul 14, 2020 at 09:17:48PM +0200, Toke Høiland-Jørgensen wrote: > > Jarod Wilson writes: > > > > > As part of an effort to help enact social change, Red Hat is > > > committing to efforts to eliminate any problematic ter

Re: [PATCH RFC net-next 00/13] Phylink PCS updates

2020-07-14 Thread Florian Fainelli
On 7/14/2020 6:18 AM, Russell King - ARM Linux admin wrote: > On Tue, Jul 14, 2020 at 11:49:58AM +0300, Vladimir Oltean wrote: >> Are you going to post a non-RFC version? > > I'm waiting for the remaining patches to be reviewed; Florian reviewed > the first six patches (which are not the import

Re: [PATCH] gianfar: Use random MAC address when none is given

2020-07-14 Thread David Miller
From: Maxim Kochetkov Date: Tue, 14 Jul 2020 15:01:04 +0300 > If there is no valid MAC address in the device tree, > use a random MAC address. > > Signed-off-by: Maxim Kochetkov Looks good, patch applied, thanks.

Re: [PATCH] hippi: Fix a size used in a 'pci_free_consistent()' in an error handling path

2020-07-14 Thread David Miller
From: Christophe JAILLET Date: Tue, 14 Jul 2020 13:00:27 +0200 > The size used when calling 'pci_alloc_consistent()' and > 'pci_free_consistent()' should match. > > Fix it and have it consistent with the corresponding call in 'rr_close()'. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-o

Re: [PATCH] net: neterion: s2io: switch from 'pci_' to 'dma_' API

2020-07-14 Thread David Miller
From: Christophe JAILLET Date: Tue, 14 Jul 2020 11:06:20 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: neterion: vxge: switch from 'pci_' to 'dma_' API

2020-07-14 Thread David Miller
From: Christophe JAILLET Date: Tue, 14 Jul 2020 11:14:12 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below. No GFP_ > flag needs to be corrected. > It has been compile tested. ... > Signed-off-by: Christophe

[RFC net-next] tc-testing: Add tdc to kselftests

2020-07-14 Thread Briana Oursler
Add tdc to existing kselftest infrastructure so that it can be run with existing kselftests. TDC now generates objects in objdir/kselftest without cluttering main objdir, leaves source directory clean, and installs correctly in kselftest_install, properly adding itself to run_kselftest.sh script.

Re: [PATCH] net: phy: phy_remove_link_mode should not advertise new modes

2020-07-14 Thread David Miller
From: Helmut Grohne Date: Tue, 14 Jul 2020 10:25:42 +0200 > When doing "ip link set dev ... up" for a ksz9477 backed link, > ksz9477_phy_setup is called and it calls phy_remove_link_mode to remove > 1000baseT HDX. During phy_remove_link_mode, phy_advertise_supported is > called. > > If one wants

Re: [PATCH 1/1] ax88172a: fix ax88172a_unbind() failures

2020-07-14 Thread David Miller
From: Dan Carpenter Date: Tue, 14 Jul 2020 11:00:38 +0300 > On Mon, Jul 13, 2020 at 05:08:59PM -0700, David Miller wrote: >> From: George Kennedy >> Date: Mon, 13 Jul 2020 07:58:57 -0400 >> >> > @@ -237,6 +237,8 @@ static int ax88172a_bind(struct usbnet *dev, struct >> > usb_interface *intf) >

Re: [PATCH] tls: add zerocopy device sendpage

2020-07-14 Thread Boris Pismenny
On 14/07/2020 23:42, David Miller wrote: > From: Boris Pismenny > Date: Tue, 14 Jul 2020 10:27:11 +0300 > >> Why is it the kernel's role to protect against such an error? > Because the kernel should perform it's task correctly no matter what > in the world the user does. > >> Surely the user that

Re: [RFC PATCH bpf-next 4/5] bpf, x64: rework pro/epilogue and tailcall handling in JIT

2020-07-14 Thread Maciej Fijalkowski
On Mon, Jul 13, 2020 at 08:36:30PM -0700, Alexei Starovoitov wrote: > On Tue, Jul 14, 2020 at 03:00:45AM +0200, Maciej Fijalkowski wrote: > > On Fri, Jul 10, 2020 at 08:25:20PM -0700, Alexei Starovoitov wrote: > > > On Fri, Jul 10, 2020 at 8:20 PM Alexei Starovoitov > > > wrote: > > > > > > > > Of

Re: [PATCH] lan743x: switch from 'pci_' to 'dma_' API

2020-07-14 Thread David Miller
From: Christophe JAILLET Date: Tue, 14 Jul 2020 09:52:24 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

Re: BPF logging infrastructure. Was: [PATCH bpf-next 4/6] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

2020-07-14 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Jul 14, 2020 at 5:12 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> > On Mon, Jul 13, 2020 at 1:13 PM Toke Høiland-Jørgensen >> > wrote: >> >> >> >> From: Toke Høiland-Jørgensen >> >> >> >> Sync addition of new members from main kern

Re: [PATCH net-next v4 00/12] bridge: mrp: Add support for interconnect ring

2020-07-14 Thread David Miller
From: Horatiu Vultur Date: Tue, 14 Jul 2020 09:34:46 +0200 > This patch series extends existing MRP to add support for interconnect ring. ... Series applied, thank you.

Re: [PATCH] tls: add zerocopy device sendpage

2020-07-14 Thread David Miller
From: Boris Pismenny Date: Tue, 14 Jul 2020 10:27:11 +0300 > Why is it the kernel's role to protect against such an error? Because the kernel should perform it's task correctly no matter what in the world the user does. > Surely the user that modifies pagecache data while sending it over > send

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Marcelo Ricardo Leitner
On Tue, Jul 14, 2020 at 09:17:48PM +0200, Toke Høiland-Jørgensen wrote: > Jarod Wilson writes: > > > As part of an effort to help enact social change, Red Hat is > > committing to efforts to eliminate any problematic terminology from > > any of the software that it ships and supports. Front and c

Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-14 Thread Aaron Conole
Numan Siddique writes: > On Mon, Jul 13, 2020 at 3:34 PM Stefano Brivio wrote: >> >> On Mon, 13 Jul 2020 10:04:13 +0200 >> Florian Westphal wrote: >> >> > Stefano Brivio wrote: >> > > Hi, >> > > >> > > On Sun, 12 Jul 2020 22:07:03 +0200 >> > > Florian Westphal wrote: >> > > >> > > > vxlan and

Re: [PATCH] tls: add zerocopy device sendpage

2020-07-14 Thread David Miller
From: Boris Pismenny Date: Tue, 14 Jul 2020 10:31:25 +0300 > At the time, Dave objected when we presented this on the netdev conference, > and we didn't want to delay the entire series just to argue this point. It's > all a matter of timing and priorities. Now we have an ASIC that uses this API,

Re: [PATCH bpf-next 2/7] bpf, xdp: add bpf_link-based XDP attachment API

2020-07-14 Thread Andrii Nakryiko
On Tue, Jul 14, 2020 at 1:13 PM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Tue, Jul 14, 2020 at 6:57 AM Toke Høiland-Jørgensen > > wrote: > >> > >> Andrii Nakryiko writes: > >> > >> > Add bpf_link-based API (bpf_xdp_link) to attach BPF XDP program through > >> > BPF_LIN

Re: [PATCH v3 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

2020-07-14 Thread David Miller
From: Weilong Chen Date: Tue, 14 Jul 2020 15:48:14 +0800 > Fixes: e51fb152318ee6 (rtnetlink: fix a memory leak when ->newlink fails) This is still not correct. Read the feedback given to you carefully.

  1   2   3   4   >