[PATCH] Replace HTTP links with HTTPS ones: CEPH COMMON CODE (LIBCEPH)

2020-07-07 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH net] xsk: remove cheap_dma optimization

2020-07-07 Thread Christoph Hellwig
On Mon, Jun 29, 2020 at 04:41:16PM +0100, Robin Murphy wrote: > On 2020-06-28 18:16, Björn Töpel wrote: >> >> On 2020-06-27 09:04, Christoph Hellwig wrote: >>> On Sat, Jun 27, 2020 at 01:00:19AM +0200, Daniel Borkmann wrote: Given there is roughly a ~5 weeks window at max where this removal co

Re: [RFC PATCH] sch_htb: Hierarchical QoS hardware offload

2020-07-07 Thread Cong Wang
On Fri, Jun 26, 2020 at 3:46 AM Maxim Mikityanskiy wrote: > > HTB doesn't scale well because of contention on a single lock, and it > also consumes CPU. Mellanox hardware supports hierarchical rate limiting > that can be leveraged by offloading the functionality of HTB. True, essentially because

Re: [net-next 09/15] Revert "net/tls: Add force_resync for driver resync"

2020-07-07 Thread Tariq Toukan
On 6/28/2020 12:17 AM, Saeed Mahameed wrote: From: Boris Pismenny This reverts commit b3ae2459f89773adcbf16fef4b68deaaa3be1929. Revert the force resync API. Not in use. To be replaced by a better async resync API downstream. Signed-off-by: Boris Pismenny Signed-off-by: Tariq Toukan Review

Re: FSL P5020/P5040: DPAA Ethernet issue with the latest Git kernel

2020-07-07 Thread Christian Zigotzky
On 08 July 2020 at 08:03 am, Madalin Bucur (OSS) wrote: From: Christian Zigotzky Sent: Tuesday, July 7, 2020 9:26 PM To: Madalin Bucur (OSS) Cc: mad skateman ; Camelia Alexandra Groza ; linuxppc-...@ozlabs.org; netdev@vger.kernel.org; R.T.Dickinson ; Darren Stevens Subject: Re: FSL P5020/P50

Re: [PATCH bpf-next 2/2] selftests/bpf: add selftests verifying bpf_trace_printk() behaviour

2020-07-07 Thread Andrii Nakryiko
On Fri, Jul 3, 2020 at 7:45 AM Alan Maguire wrote: > > Simple selftest that verifies bpf_trace_printk() returns a sensible > value and tracing messages appear. > > Signed-off-by: Alan Maguire > --- > .../selftests/bpf/prog_tests/trace_printk.c| 71 > ++ > tools/testi

Re: [PATCH bpf-next 1/2] bpf: use dedicated bpf_trace_printk event instead of trace_printk()

2020-07-07 Thread Andrii Nakryiko
On Fri, Jul 3, 2020 at 7:47 AM Alan Maguire wrote: > > The bpf helper bpf_trace_printk() uses trace_printk() under the hood. > This leads to an alarming warning message originating from trace > buffer allocation which occurs the first time a program using > bpf_trace_printk() is loaded. > > We can

Re: [PATCH bpf 2/2] bpf: net: Avoid incorrect bpf_sk_reuseport_detach call

2020-07-07 Thread Andrii Nakryiko
On Tue, Jul 7, 2020 at 6:46 PM Martin KaFai Lau wrote: > > bpf_sk_reuseport_detach is currently called when sk->sk_user_data > is not NULL. It is incorrect because sk->sk_user_data may not be > managed by the bpf's reuseport_array. It has been report in [1] that, > the bpf_sk_reuseport_detach()

[PATCH net] tcp: Initialize ca_priv when inheriting from listener

2020-07-07 Thread Christoph Paasch
syzkaller found its way into setsockopt with TCP_CONGESTION "cdg". tcp_cdg_init() does a kcalloc to store the gradients. As sk_clone_lock just copies all the memory, the allocated pointer will be copied as well, if the app called setsockopt(..., TCP_CONGESTION) on the listener. If now the socket wi

Re: [RFC net-next 2/2] net: disable UDP GSO feature when CSUM is disabled

2020-07-07 Thread Eric Dumazet
On 7/7/20 8:48 PM, Huazhong Tan wrote: > Since UDP GSO feature is depended on checksum offload, so disable > UDP GSO feature when CSUM is disabled, then from user-space also > can see UDP GSO feature is disabled. > > Signed-off-by: Huazhong Tan > --- > net/core/dev.c | 6 ++ > 1 file chan

RE: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set()

2020-07-07 Thread Andy Duan
From: Sergey Organov Sent: Tuesday, July 7, 2020 10:43 PM > Andy Duan writes: > > > From: Sergey Organov Sent: Monday, July 6, 2020 > 10:26 PM > >> Code of the form "if(x) x = 0" replaced with "x = 0". > >> > >> Code of the form "if(x == a) x = a" removed. > >> > >> Signed-off-by: Sergey Organo

Re: [PATCH] rds: send: Replace sg++ with sg = sg_next(sg)

2020-07-07 Thread Leon Romanovsky
On Wed, Jul 08, 2020 at 03:42:52AM +, Xu Wang wrote: > Replace sg++ with sg = sg_next(sg). > > Signed-off-by: Xu Wang > --- > net/rds/send.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/rds/send.c b/net/rds/send.c > index 68e2bdb08fd0..57d03a6753de 100644 > ---

RE: [EXT] net: ethernet: freescale: fec: copybreak handling throughput, dma_sync_* optimisations allowed?

2020-07-07 Thread Andy Duan
From: Robin Murphy On 2020-07-07 04:44, Andy Duan wrote: > > Hi mm experts, > > > > From: Kegl Rohit Sent: Monday, July 6, 2020 > > 10:18 PM > >> So you would also say a single dma_sync_single_for_cpu is enough. > >> You are right it would be great if some mm expert could have a look > >> at it.

Re: [RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE_GSO

2020-07-07 Thread Eric Dumazet
On 7/7/20 8:48 PM, Huazhong Tan wrote: > Add NETIF_F_SOFTWARE_GSO to the the list of GSO features with s/NETIF_F_SOFTWARE_GSO/NETIF_F_GSO_UDP_L4/ > a software fallback. This allows UDP GSO to be used even if > the hardware does not support it, and for virtual device such > as VxLAN device, t

Re: [PATCH][next] Bluetooth: Use fallthrough pseudo-keyword

2020-07-07 Thread Marcel Holtmann
Hi Gustavo, > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough

[PATCH net-next] net: dsa: loop: Print when registration is successful

2020-07-07 Thread Florian Fainelli
We have a number of error conditions that can lead to the driver not probing successfully, move the print when we are sure dsa_register_switch() has suceeded. This avoids repeated prints in case of probe deferral for instance. Signed-off-by: Florian Fainelli --- drivers/net/dsa/dsa_loop.c | 11 +

[PATCH] drivers/net/wan/x25_asy: Fix to make it work

2020-07-07 Thread Xie He
This driver is not working because of problems of its receiving code. This patch fixes it to make it work. When the driver receives an LAPB frame, it should first pass the frame to the LAPB module to process. After processing, the LAPB module passes the data (the packet) back to the driver, the dr

[PATCH net v2 1/1] qed: Populate nvm-file attributes while reading nvm config partition.

2020-07-07 Thread Sudarsana Reddy Kalluru
NVM config file address will be modified when the MBI image is upgraded. Driver would return stale config values if user reads the nvm-config (via ethtool -d) in this state. The fix is to re-populate nvm attribute info while reading the nvm config values/partition. Changes from previous version: -

[RFC net-next 2/2] net: disable UDP GSO feature when CSUM is disabled

2020-07-07 Thread Huazhong Tan
Since UDP GSO feature is depended on checksum offload, so disable UDP GSO feature when CSUM is disabled, then from user-space also can see UDP GSO feature is disabled. Signed-off-by: Huazhong Tan --- net/core/dev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/core/dev.c b/net/co

[RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE_GSO

2020-07-07 Thread Huazhong Tan
Add NETIF_F_SOFTWARE_GSO to the the list of GSO features with a software fallback. This allows UDP GSO to be used even if the hardware does not support it, and for virtual device such as VxLAN device, this UDP segmentation will be postponed to physical device. Signed-off-by: Huazhong Tan --- in

[RFC net-next 0/2] net: two updates related to UDP GSO

2020-07-07 Thread Huazhong Tan
There are two updates related to UDP GSO. #1 adds NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE_GSO, then the virtual device can postpone its UDP GSO to physical device, as extention to commit 83aa025f535f ("udp: add gso support to virtual devices"). #2 disable UDP GSO feature when CSUM is disabled. Curre

[PATCH] rds: send: Replace sg++ with sg = sg_next(sg)

2020-07-07 Thread Xu Wang
Replace sg++ with sg = sg_next(sg). Signed-off-by: Xu Wang --- net/rds/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/send.c b/net/rds/send.c index 68e2bdb08fd0..57d03a6753de 100644 --- a/net/rds/send.c +++ b/net/rds/send.c @@ -387,7 +387,7 @@ int rds_send_xmi

RE: [kbuild-all] Re: [PATCH net-next 03/15] sfc_ef100: skeleton EF100 PF driver

2020-07-07 Thread Xia, Hui
>-Original Message- >From: Edward Cree >Sent: 2020年7月8日 2:35 >To: lkp ; linux-net-driv...@solarflare.com; >da...@davemloft.net >Cc: kbuild-...@lists.01.org; netdev@vger.kernel.org >Subject: [kbuild-all] Re: [PATCH net-next 03/15] sfc_ef100: skeleton EF100 PF >driver > >On 04/07/2020 05:

Re: [PATCH bpf-next v2 4/4] selftests: bpf: remove unused bpf_map_def_legacy struct

2020-07-07 Thread Daniel T. Lee
On Wed, Jul 8, 2020 at 4:00 AM Andrii Nakryiko wrote: > > On Tue, Jul 7, 2020 at 11:49 AM Daniel T. Lee wrote: > > > > samples/bpf no longer use bpf_map_def_legacy and instead use the > > libbpf's bpf_map_def or new BTF-defined MAP format. This commit removes > > unused bpf_map_def_legacy struct

[PATCH bpf-next 2/6] libbpf: add btf__set_fd() for more control over loaded BTF FD

2020-07-07 Thread Andrii Nakryiko
Add setter for BTF FD to allow application more fine-grained control in more advanced scenarios. Storing BTF FD inside `struct btf` provides little benefit and probably would be better done differently (e.g., btf__load() could just return FD on success), but we are stuck with this due to backwards

[PATCH bpf-next 0/6] Improve libbpf support of old kernels

2020-07-07 Thread Andrii Nakryiko
This patch set improves libbpf's support of old kernels, missing features like BTF support, global variables support, etc. Most critical one is a silent drop of CO-RE relocations if libbpf fails to load BTF (despite sanitization efforts). This is frequently the case for kernels that have no BTF su

[PATCH bpf-next 3/6] libbpf: improve BTF sanitization handling

2020-07-07 Thread Andrii Nakryiko
Change sanitization process to preserve original BTF, which might be used by libbpf itself for Kconfig externs, CO-RE relocs, etc, even if kernel is old and doesn't support BTF. To achieve that, if libbpf detects the need for BTF sanitization, it would clone original BTF, sanitize it in-place, atte

[PATCH bpf-next 5/6] libbpf: handle missing BPF_OBJ_GET_INFO_BY_FD gracefully in perf_buffer

2020-07-07 Thread Andrii Nakryiko
perf_buffer__new() is relying on BPF_OBJ_GET_INFO_BY_FD availability for few sanity checks. OBJ_GET_INFO for maps is actually much more recent feature than perf_buffer support itself, so this causes unnecessary problems on old kernels before BPF_OBJ_GET_INFO_BY_FD was added. This patch makes those

[PATCH bpf-next 1/6] libbpf: make BTF finalization strict

2020-07-07 Thread Andrii Nakryiko
With valid ELF and valid BTF, there is no reason (apart from bugs) why BTF finalization should fail. So make it strict and return error if it fails. This makes CO-RE relocation more reliable, as they are not going to be just silently skipped, if BTF finalization failed. Signed-off-by: Andrii Nakry

[PATCH bpf-next 6/6] selftests/bpf: switch perf_buffer test to tracepoint and skeleton

2020-07-07 Thread Andrii Nakryiko
Switch perf_buffer test to use skeleton to avoid use of bpf_prog_load() and make test a bit more succinct. Also switch BPF program to use tracepoint instead of kprobe, as that allows to support older kernels, which had tracepoint support before kprobe support in the form that libbpf expects (i.e.,

[PATCH bpf-next 4/6] selftests/bpf: add test relying only on CO-RE and no recent kernel features

2020-07-07 Thread Andrii Nakryiko
Add a test that relies on CO-RE, but doesn't expect any of the recent features, not available on old kernels. This is useful for Travis CI tests running against very old kernels (e.g., libbpf has 4.9 kernel testing now), to verify that CO-RE still works, even if kernel itself doesn't support BTF ye

[PATCH bpf 2/2] bpf: net: Avoid incorrect bpf_sk_reuseport_detach call

2020-07-07 Thread Martin KaFai Lau
bpf_sk_reuseport_detach is currently called when sk->sk_user_data is not NULL. It is incorrect because sk->sk_user_data may not be managed by the bpf's reuseport_array. It has been report in [1] that, the bpf_sk_reuseport_detach() which is called from udp_lib_unhash() has corrupted the sk_user_da

[PATCH bpf 0/2] bpf: net: Fixes in sk_user_data of reuseport_array

2020-07-07 Thread Martin KaFai Lau
This set fixes two issues on sk_user_data when a sk is added to a reuseport_array. The first patch is to avoid the sk_user_data being copied to a cloned sk. The second patch avoids doing bpf_sk_reuseport_detach() on sk_user_data that is not managed by reuseport_array. Since the changes are mostl

[PATCH bpf 1/2] bpf: net: Avoid copying sk_user_data of reuseport_array during sk_clone

2020-07-07 Thread Martin KaFai Lau
It makes little sense for copying sk_user_data of reuseport_array during sk_clone_lock(). This patch reuses the SK_USER_DATA_NOCOPY bit introduced in commit f1ff5ce2cd5e ("net, sk_msg: Clear sk_user_data pointer on clone if tagged"). It is used to mark the sk_user_data is not supposed to be copie

KASAN: slab-out-of-bounds Read in hci_extended_inquiry_result_evt

2020-07-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7cc2a8ea Merge tag 'block-5.8-2020-07-01' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10261e7b10 kernel config: https://syzkaller.appspot.com/x/.config?x=7be693511b29b338 das

Re: [PATCH ghak90 V9 01/13] audit: collect audit task parameters

2020-07-07 Thread Paul Moore
On Mon, Jul 6, 2020 at 10:50 PM Richard Guy Briggs wrote: > On 2020-07-05 11:09, Paul Moore wrote: > > On Sat, Jun 27, 2020 at 9:21 AM Richard Guy Briggs wrote: > > > > > > The audit-related parameters in struct task_struct should ideally be > > > collected together and accessed through a standar

Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-07 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/izabela-bakollari-gmail-com/dropwatch-Support-monitoring-of-dropped-frames/20200708-011806 base: https://git.kernel.org/pub/scm/linux/kernel/git/d

Re: [PATCH bpf-next v2 0/4] samples: bpf: refactor BPF map test with libbpf

2020-07-07 Thread Daniel Borkmann
On 7/7/20 9:01 PM, Andrii Nakryiko wrote: On Tue, Jul 7, 2020 at 11:49 AM Daniel T. Lee wrote: There have been many changes in how the current bpf program defines map. The development of libbbpf has led to the new method called BTF-defined map, which is a new way of defining BPF maps, and thus

Re: [PATCH bpf-next v4 1/4] bpf: add BPF_CGROUP_INET_SOCK_RELEASE hook

2020-07-07 Thread Daniel Borkmann
On 7/8/20 1:43 AM, Stanislav Fomichev wrote: On Tue, Jul 7, 2020 at 2:42 PM Daniel Borkmann wrote: On 7/7/20 1:42 AM, Andrii Nakryiko wrote: On Mon, Jul 6, 2020 at 4:02 PM Stanislav Fomichev wrote: Implement BPF_CGROUP_INET_SOCK_RELEASE hook that triggers on inet socket release. It trigger

[PATCH ethtool 2/4] igc: Parse RCTL register fields

2020-07-07 Thread Andre Guedes
This patch adds support for parsing the Receive Control (RCTL) register fields. Signed-off-by: Andre Guedes --- igc.c | 91 ++- 1 file changed, 90 insertions(+), 1 deletion(-) diff --git a/igc.c b/igc.c index 91ab64d..df3916c 100644 --- a/

[PATCH ethtool 1/4] Add IGC driver support

2020-07-07 Thread Andre Guedes
This patch adds the initial support for parsing registers dumped by the IGC driver. At this moment, only the Receive Address Low (RAL) and the Receive Address High (RAH) registers are parsed. More registers will be added on demand. Signed-off-by: Andre Guedes --- Makefile.am | 3 ++- ethtool.c

[PATCH ethtool 4/4] igc: Parse ETQF registers

2020-07-07 Thread Andre Guedes
This patch adds support for parsing the EType Queue Filter (ETQF) registers fields. Signed-off-by: Andre Guedes --- igc.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/igc.c b/igc.c index 6a2e06d..9c0a750 100644 --- a/igc.c +++ b/igc.c @@ -59,6 +59,14 @@

[PATCH ethtool 3/4] igc: Parse VLANPQF register fields

2020-07-07 Thread Andre Guedes
This patch adds support for parsing the VLAN Priority Queue Filter (VLANPQF) register fields. Signed-off-by: Andre Guedes --- igc.c | 98 +++ 1 file changed, 98 insertions(+) diff --git a/igc.c b/igc.c index df3916c..6a2e06d 100644 --- a/i

[PATCH ethtool 0/4] Add support for IGC driver

2020-07-07 Thread Andre Guedes
Hi all, This patch series adds support for parsing registers dumped by the IGC driver. For now, the following registers are parsed: * Receive Address Low (RAL) * Receive Address High (RAH) * Receive Control (RCTL) * VLAN Priority Queue Filter (VLANPQF) * ET

Re: [PATCH 2/3] Bluetooth: btrtl: add support for the RTL8723CS

2020-07-07 Thread kernel test robot
Hi Vasily, I love your patch! Yet something to improve: [auto build test ERROR on bluetooth-next/master] [also build test ERROR on sunxi/sunxi/for-next v5.8-rc4 next-20200707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as

[PATCH 13/13] PCI: Remove '*val = 0' from pcie_capability_read_*()

2020-07-07 Thread Saheed Olayemi Bolarinwa
From: Bolarinwa Olayemi Saheed There are several reasons why a PCI capability read may fail whether the device is present or not. If this happens, pcie_capability_read_*() will return -EINVAL/PCIBIOS_BAD_REGISTER_NUMBER or PCIBIOS_DEVICE_NOT_FOUND and *val is set to 0. This behaviour if further

[PATCH 0/13] PCI: Remove '*val = 0' from pcie_capability_read_*()

2020-07-07 Thread Saheed Olayemi Bolarinwa
From: Bolarinwa Olayemi Saheed MERGING: Only Patch 13/13 depend on all preceeding patchs. All other patches are independent of one another. Hence, please merge PATCH 13/13 only after other patches in this series have been merged. PATCH 6/13: Make the function set status to "Power On" by default

[PATCH] Bluetooth: Use whitelist for scan policy when suspending

2020-07-07 Thread Miao-chen Chou
Even with one advertisement monitor in place, the scan policy should use the whitelist while the system is going to suspend to prevent waking by random advertisement. The following test was performed. - With a paired device, register one advertisement monitor, suspend the system and verify that th

Re: [PATCH v2 net] ionic: centralize queue reset code

2020-07-07 Thread David Miller
From: Shannon Nelson Date: Tue, 7 Jul 2020 14:13:26 -0700 > The queue reset pattern is used in a couple different places, > only slightly different from each other, and could cause > issues if one gets changed and the other didn't. This puts > them together so that only one version is needed, y

Re: [PATCH net-next] net: sfp: add error checking with sfp_irq_name

2020-07-07 Thread David Miller
From: Chris Healy Date: Tue, 7 Jul 2020 13:32:05 -0700 > Add error checking with sfp_irq_name before use. > > Signed-off-by: Chris Healy Applied.

Re: [PATCH net v2] vlan: consolidate VLAN parsing code and limit max parsing depth

2020-07-07 Thread David Miller
From: Toke Høiland-Jørgensen Date: Tue, 7 Jul 2020 13:03:25 +0200 > Toshiaki pointed out that we now have two very similar functions to extract > the L3 protocol number in the presence of VLAN tags. And Daniel pointed out > that the unbounded parsing loop makes it possible for maliciously crafte

Re: [PATCH][next] net/sched: Use fallthrough pseudo-keyword

2020-07-07 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 7 Jul 2020 12:21:38 -0500 > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/htm

Re: [PATCH] Replace HTTP links with HTTPS ones: GRETH 10/100/1G Ethernet MAC device driver

2020-07-07 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 6 Jul 2020 22:50:18 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] Replace HTTP links with HTTPS ones: X.25 network layer

2020-07-07 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 6 Jul 2020 22:50:30 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] bitfield.h: don't compile-time validate _val in FIELD_FIT

2020-07-07 Thread Alex Elder
On 7/7/20 4:16 PM, Nick Desaulniers wrote: > From: Jakub Kicinski > > When ur_load_imm_any() is inlined into jeq_imm(), it's possible for the > compiler to deduce a case where _val can only have the value of -1 at > compile time. Specifically, > > /* struct bpf_insn: _s32 imm */ > u64 imm = insn

Re: [PATCH v2 net] net: qed: fix buffer overflow on ethtool -d

2020-07-07 Thread David Miller
From: Alexander Lobakin Date: Mon, 6 Jul 2020 12:25:53 +0300 > When generating debug dump, driver firstly collects all data in binary > form, and then performs per-feature formatting to human-readable if it > is supported. > > For ethtool -d, this is roughly incorrect for two reasons. First of a

Re: [PATCH][next] bnx2x: fix spelling mistake "occurd" -> "occurred"

2020-07-07 Thread David Miller
From: Colin King Date: Mon, 6 Jul 2020 13:12:40 +0100 > From: Colin Ian King > > There are spelling mistakes in various literal strings. Fix these. > > Signed-off-by: Colin Ian King Applied, thanks.

Re: [PATCH net-next v2 0/3] net: ethtool: Untangle PHYLIB dependency

2020-07-07 Thread David Miller
From: Florian Fainelli Date: Sun, 5 Jul 2020 21:27:55 -0700 > This patch series untangles the ethtool netlink dependency with PHYLIB > which exists because the cable test feature calls directly into PHY > library functions. The approach taken here is to introduce > ethtool_phy_ops function point

Re: [PATCH -next] Documentation: networking: fix ethtool-netlink table formats

2020-07-07 Thread David Miller
From: Randy Dunlap Date: Sun, 5 Jul 2020 19:55:44 -0700 > From: Randy Dunlap > > Fix table formatting to eliminate warnings. > > Documentation/networking/ethtool-netlink.rst:509: WARNING: Malformed table. > Documentation/networking/ethtool-netlink.rst:522: WARNING: Malformed table. > Documenta

Re: [PATCH net v2] bridge: mcast: Fix MLD2 Report IPv6 payload length check

2020-07-07 Thread David Miller
From: Linus Lüssing Date: Sun, 5 Jul 2020 21:10:17 +0200 > Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in > igmp3/mld2 report handling") introduced a bug in the IPv6 header payload > length check which would potentially lead to rejecting a valid MLD2 Report: > > The check

Re: [PATCH net-next] net: phy: add a Kconfig option for mdio_devres

2020-07-07 Thread David Miller
From: Bartosz Golaszewski Date: Sun, 5 Jul 2020 11:55:47 +0200 > From: Bartosz Golaszewski > > If phylib is built as a module and CONFIG_MDIO_DEVICE is 'y', the > mdio_device and mdio_bus code will be in the phylib module, not in the > kernel image. Meanwhile we build mdio_devres depending on

Re: [PATCH net] net: Added pointer check for dst->ops->neigh_lookup in dst_neigh_lookup_skb

2020-07-07 Thread David Miller
From: Martin Varghese Date: Sun, 5 Jul 2020 14:23:49 +0530 > From: Martin Varghese > > The packets from tunnel devices (eg bareudp) may have only > metadata in the dst pointer of skb. Hence a pointer check of > neigh_lookup is needed in dst_neigh_lookup_skb > > Kernel crashes when packets fro

Re: [PATCH v2 net] ionic: centralize queue reset code

2020-07-07 Thread Jakub Kicinski
On Tue, 7 Jul 2020 14:13:26 -0700 Shannon Nelson wrote: > The queue reset pattern is used in a couple different places, > only slightly different from each other, and could cause > issues if one gets changed and the other didn't. This puts > them together so that only one version is needed, yet e

Re: [PATCH net] net/sched: act_ct: add miss tcf_lastuse_update.

2020-07-07 Thread David Miller
From: we...@ucloud.cn Date: Sat, 4 Jul 2020 15:42:47 +0800 > From: wenxu > > When tcf_ct_act execute the tcf_lastuse_update should > be update or the used stats never update > > filter protocol ip pref 3 flower chain 0 > filter protocol ip pref 3 flower chain 0 handle 0x1 > eth_type ipv4 >

Re: [PATCH net] net/mlx5e: Do not include rwlock.h directly

2020-07-07 Thread David Miller
From: Sebastian Andrzej Siewior Date: Fri, 3 Jul 2020 18:44:32 +0200 > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. Including it directly will break the RT build. > > Fixes: 549c243e4e010 ("net/mlx5e: Extract neigh-specific code from en_rep.c > to re

Re: [PATCH net] mptcp: fix DSS map generation on fin retransmission

2020-07-07 Thread David Miller
From: Paolo Abeni Date: Fri, 3 Jul 2020 18:06:04 +0200 > The RFC 8684 mandates that no-data DATA FIN packets should carry > a DSS with 0 sequence number and data len equal to 1. Currently, > on FIN retransmission we re-use the existing mapping; if the previous > fin transmission was part of a pa

Re: [PATCH net] ipv4: fill fl4_icmp_{type,code} in ping_v4_sendmsg

2020-07-07 Thread David Miller
From: Sabrina Dubroca Date: Fri, 3 Jul 2020 17:00:32 +0200 > IPv4 ping sockets don't set fl4.fl4_icmp_{type,code}, which leads to > incomplete IPsec ACQUIRE messages being sent to userspace. Currently, > both raw sockets and IPv6 ping sockets set those fields. > > Expected output of "ip xfrm mo

Re: [PATCH v3 net] net: ethernet: fec: prevent tx starvation under high rx load

2020-07-07 Thread David Miller
From: Tobias Waldekranz Date: Fri, 3 Jul 2020 16:10:58 +0200 > In the ISR, we poll the event register for the queues in need of > service and then enter polled mode. After this point, the event > register will never be read again until we exit polled mode. > > In a scenario where a UDP flow is

Re: [PATCH] net: sky2: initialize return of gm_phy_read

2020-07-07 Thread David Miller
From: t...@redhat.com Date: Fri, 3 Jul 2020 06:33:59 -0700 > From: Tom Rix > > clang static analysis flags this garbage return > > drivers/net/ethernet/marvell/sky2.c:208:2: warning: Undefined or garbage > value returned to caller [core.uninitialized.UndefReturn] > return v; >

Re: [PATCH v2 0/2] smsc: use generic power management

2020-07-07 Thread David Miller
From: Vaibhav Gupta Date: Fri, 3 Jul 2020 08:31:36 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from smsc ethernet drivers. > > The callbacks performing suspend() and resume() operations ar

Re: [PATCH bpf-next v4 4/4] selftests/bpf: test BPF_CGROUP_INET_SOCK_RELEASE

2020-07-07 Thread Andrii Nakryiko
On Tue, Jul 7, 2020 at 2:45 PM Daniel Borkmann wrote: > > On 7/7/20 1:01 AM, Stanislav Fomichev wrote: > > Simple test that enforces a single SOCK_DGRAM socker per cgroup. > > > > Signed-off-by: Stanislav Fomichev > > --- > > .../selftests/bpf/prog_tests/udp_limit.c | 75 ++

Re: [net-next PATCH 2/2 v5] net: dsa: rtl8366rb: Support the CPU DSA tag

2020-07-07 Thread Florian Fainelli
On 7/7/2020 2:16 PM, Linus Walleij wrote: > This activates the support to use the CPU tag to properly > direct ingress traffic to the right port. > > Bit 15 in register RTL8368RB_CPU_CTRL_REG can be set to > 1 to disable the insertion of the CPU tag which is what > the code currently does. The

Re: [net-next PATCH 1/2 v5] net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag

2020-07-07 Thread Florian Fainelli
On 7/7/2020 2:16 PM, Linus Walleij wrote: > This implements the known parts of the Realtek 4 byte > tag protocol version 0xA, as found in the RTL8366RB > DSA switch. > > It is designated as protocol version 0xA as a > different Realtek 4 byte tag format with protocol > version 0x9 is known to e

Re: [net-next PATCH 0/2 v5] RTL8366RB tagging support

2020-07-07 Thread Florian Fainelli
On 7/7/2020 2:16 PM, Linus Walleij wrote: > This is essentially the two first patches of the previous > patch set: we split off the tagging support and deal > with the VLAN set-up in a separate patch set since it > seems we need some more discussion around that. Yes, good idea to split them tha

Re: [PATCH bpf-next v4 4/4] selftests/bpf: test BPF_CGROUP_INET_SOCK_RELEASE

2020-07-07 Thread Daniel Borkmann
On 7/7/20 1:01 AM, Stanislav Fomichev wrote: Simple test that enforces a single SOCK_DGRAM socker per cgroup. Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/udp_limit.c | 75 +++ tools/testing/selftests/bpf/progs/udp_limit.c | 42 +++ 2 files

Re: [PATCH bpf-next v4 1/4] bpf: add BPF_CGROUP_INET_SOCK_RELEASE hook

2020-07-07 Thread Daniel Borkmann
On 7/7/20 1:42 AM, Andrii Nakryiko wrote: On Mon, Jul 6, 2020 at 4:02 PM Stanislav Fomichev wrote: Implement BPF_CGROUP_INET_SOCK_RELEASE hook that triggers on inet socket release. It triggers only for userspace sockets, the same semantics as existing BPF_CGROUP_INET_SOCK_CREATE. The only que

[PATCH net-next 1/9] debugfs: make sure we can remove u32_array files cleanly

2020-07-07 Thread Jakub Kicinski
debugfs_create_u32_array() allocates a small structure to wrap the data and size information about the array. If users ever try to remove the file this leads to a leak since nothing ever frees this wrapper. That said there are no upstream users of debugfs_create_u32_array() that'd remove a u32 arr

[PATCH net-next 2/9] udp_tunnel: re-number the offload tunnel types

2020-07-07 Thread Jakub Kicinski
Make it possible to use tunnel types as flags more easily. There doesn't appear to be any user using the type as an array index, so this should make no difference. Signed-off-by: Jakub Kicinski --- include/net/udp_tunnel.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH net-next 5/9] netdevsim: add UDP tunnel port offload support

2020-07-07 Thread Jakub Kicinski
Add UDP tunnel port handlers to our fake driver so we can test the core infra. Signed-off-by: Jakub Kicinski --- drivers/net/netdevsim/Makefile | 2 +- drivers/net/netdevsim/dev.c | 1 + drivers/net/netdevsim/netdev.c | 12 +- drivers/net/netdevsim/netdevsim.h | 19 +++

[PATCH net-next 3/9] udp_tunnel: add central NIC RX port offload infrastructure

2020-07-07 Thread Jakub Kicinski
Cater to devices which: (a) may want to sleep in the callbacks; (b) only have IPv4 support; (c) need all the programming to happen while the netdev is up. Drivers attach UDP tunnel offload info struct to their netdevs, where they declare how many UDP ports of various tunnel types they support.

Re: [PATCH net-next 2/2] net: sched: Lockless Token Bucket (LTB) Qdisc

2020-07-07 Thread YU, Xiangning
On 7/7/20 1:06 PM, Cong Wang wrote: > On Mon, Jul 6, 2020 at 1:34 PM YU, Xiangning > wrote: >> >> >> >> On 7/6/20 1:10 PM, Cong Wang wrote: >>> On Mon, Jul 6, 2020 at 11:11 AM YU, Xiangning >>> wrote: +static int ltb_enqueue(struct sk_buff *skb, struct Qdisc *sch, spinlock_t *root_l

[PATCH net-next 7/9] ixgbe: convert to new udp_tunnel_nic infra

2020-07-07 Thread Jakub Kicinski
Make use of new common udp_tunnel_nic infra. ixgbe supports IPv4 only, and only single VxLAN and Geneve ports (one each). I'm dropping the confusing piece of code in ixgbe_set_features(). ndo_udp_tunnel_add and ndo_udp_tunnel_del did not check if RXCSUM is enabled, so this code was either unnecess

[PATCH net-next 9/9] mlx4: convert to new udp_tunnel_nic infra

2020-07-07 Thread Jakub Kicinski
Convert to new infra, make use of the ability to sleep in the callback. Signed-off-by: Jakub Kicinski --- .../net/ethernet/mellanox/mlx4/en_netdev.c| 107 -- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 2 - 2 files changed, 25 insertions(+), 84 deletions(-) diff --git

[PATCH net-next 8/9] bnxt: convert to new udp_tunnel_nic infra

2020-07-07 Thread Jakub Kicinski
Convert to new infra, taking advantage of sleeping in callbacks. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 133 ++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 6 - 2 files changed, 34 insertions(+), 105 deletions(-) diff --git a/drivers/

[PATCH net-next 4/9] ethtool: add tunnel info interface

2020-07-07 Thread Jakub Kicinski
Add an interface to report offloaded UDP ports via ethtool netlink. Now that core takes care of tracking which UDP tunnel ports the NICs are aware of we can quite easily export this information out to user space. The responsibility of writing the netlink dumps is split between ethtool code and ud

[PATCH net-next 0/9] udp_tunnel: add NIC RX port offload infrastructure

2020-07-07 Thread Jakub Kicinski
Kernel has a facility to notify drivers about the UDP tunnel ports so that devices can recognize tunneled packets. This is important mostly for RX - devices which don't support CHECKSUM_COMPLETE can report checksums of inner packets, and compute RSS over inner headers. Some drivers also match the U

Re: [PATCH net] l2tp: remove skb_dst_set() from l2tp_xmit_skb()

2020-07-07 Thread James Chapman
On Tue, Jul 07, 2020 at 02:02:32 +0800, Xin Long wrote: > In the tx path of l2tp, l2tp_xmit_skb() calls skb_dst_set() to set > skb's dst. However, it will eventually call inet6_csk_xmit() or > ip_queue_xmit() where skb's dst will be overwritten by: > >skb_dst_set_noref(skb, dst); > > without

[PATCH net-next 6/9] selftests: net: add a test for UDP tunnel info infra

2020-07-07 Thread Jakub Kicinski
Add validating the UDP tunnel infra works. $ ./udp_tunnel_nic.sh PASSED all 383 checks Signed-off-by: Jakub Kicinski --- .../drivers/net/netdevsim/udp_tunnel_nic.sh | 786 ++ 1 file changed, 786 insertions(+) create mode 100644 tools/testing/selftests/drivers/net/netdevsim/u

[PATCH net-next v5 2/4] net: dsa: felix: (re)use already existing constants

2020-07-07 Thread Michael Walle
Now that there are USXGMII constants available, drop the old definitions and reuse the generic ones. Signed-off-by: Michael Walle --- drivers/net/dsa/ocelot/felix_vsc9959.c | 45 +++--- 1 file changed, 12 insertions(+), 33 deletions(-) diff --git a/drivers/net/dsa/ocelot/fel

[PATCH net-next v5 0/4] net: enetc: remove bootloader dependency

2020-07-07 Thread Michael Walle
This is a resend [now a new v4] of the series because the conversion to the phylink interface will likely take longer: https://lore.kernel.org/netdev/CA+h21hpBodyY8CtNH2ktRdc2FqPi=Fjp94=vvzvzsvbnvnf...@mail.gmail.com/ Also the discussion in the v3 resend doesn't look like it will be resolved soon :

[PATCH net-next v5 3/4] net: enetc: Initialize SerDes for SGMII and USXGMII protocols

2020-07-07 Thread Michael Walle
ENETC has ethernet MACs capable of SGMII, 2500BaseX and USXGMII. But in order to use these protocols some SerDes configurations need to be performed. The SerDes is configurable via an internal PCS PHY which is connected to an internal MDIO bus at address 0. This patch basically removes the depende

[PATCH net-next v5 4/4] net: enetc: Use DT protocol information to set up the ports

2020-07-07 Thread Michael Walle
From: Alex Marginean Use DT information rather than in-band information from bootloader to set up MAC for XGMII. For RGMII use the DT indication in addition to RGMII defaults in hardware. However, this implies that PHY connection information needs to be extracted before netdevice creation, when t

[PATCH net-next v5 1/4] net: phy: add USXGMII link partner ability constants

2020-07-07 Thread Michael Walle
The constants are taken from the USXGMII Singleport Copper Interface specification. The naming are based on the SGMII ones, but with an MDIO_ prefix. Signed-off-by: Michael Walle --- include/uapi/linux/mdio.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include

Re: [PATCH] amd-xgbe: add module param for auto negotiation

2020-07-07 Thread Florian Fainelli
On 7/7/2020 12:01 PM, Shyam Sundar S K wrote: > > On 7/7/2020 11:25 PM, Andrew Lunn wrote: >> [CAUTION: External Email] >> >> On Tue, Jul 07, 2020 at 05:32:54PM +, Shyam Sundar S K wrote: >>> In embedded environments, ethtool may not be available to toggle between >>> auto negotiation on/of

[net-next PATCH 2/2 v5] net: dsa: rtl8366rb: Support the CPU DSA tag

2020-07-07 Thread Linus Walleij
This activates the support to use the CPU tag to properly direct ingress traffic to the right port. Bit 15 in register RTL8368RB_CPU_CTRL_REG can be set to 1 to disable the insertion of the CPU tag which is what the code currently does. The bit 15 define calls this setting RTL8368RB_CPU_INSTAG whi

[net-next PATCH 1/2 v5] net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag

2020-07-07 Thread Linus Walleij
This implements the known parts of the Realtek 4 byte tag protocol version 0xA, as found in the RTL8366RB DSA switch. It is designated as protocol version 0xA as a different Realtek 4 byte tag format with protocol version 0x9 is known to exist in the Realtek RTL8306 chips. The tag and switch chip

[net-next PATCH 0/2 v5] RTL8366RB tagging support

2020-07-07 Thread Linus Walleij
This is essentially the two first patches of the previous patch set: we split off the tagging support and deal with the VLAN set-up in a separate patch set since it seems we need some more discussion around that. Linus Walleij (2): net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag net: dsa:

Re: PHY reset handling during DT parsing

2020-07-07 Thread Florian Fainelli
On 7/7/2020 10:18 AM, Rob Herring wrote: > On Tue, Jul 7, 2020 at 10:39 AM Florian Fainelli wrote: >> >> >> >> On 7/7/2020 7:54 AM, Maxime Ripard wrote: >>> Hi Andrew, >>> >>> On Tue, Jul 07, 2020 at 04:19:18PM +0200, Andrew Lunn wrote: On Mon, Jul 06, 2020 at 08:13:31PM +0200, Maxime Ripa

[PATCH v2 net] ionic: centralize queue reset code

2020-07-07 Thread Shannon Nelson
The queue reset pattern is used in a couple different places, only slightly different from each other, and could cause issues if one gets changed and the other didn't. This puts them together so that only one version is needed, yet each can have slighty different effects by passing in a pointer to

Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-07 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/izabela-bakollari-gmail-com/dropwatch-Support-monitoring-of-dropped-frames/20200708-011806 base: https://git.kernel.org/pub/scm/linux/kernel/git/d

  1   2   3   >