On 06/25/2020 12:59 AM, Jakub Kicinski wrote:
On Wed, 24 Jun 2020 06:32:36 + Christian Benvenuti (benve) wrote:
We/Cisco will also look into it, hopefully a small code reorg will be
sufficient.
Hi, Christian:
I have seen some submissions and codes, and feel that spin_lock is unnecessar
On 03/07/2020 03:49, Zhang Rui wrote:
> On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote:
[ ... ]
>>> So the reason is that ->get_temp() is called while the mutex is
>>> held and
>>> thermal_zone_device_is_enabled() wants to take the same mutex.
>>
>> Yes, that's correct.
>>
>>> Is adding
Am 03.07.20 um 00:08 schrieb Alexei Starovoitov:
On Thu, Jul 2, 2020 at 1:05 PM Alexander A. Klimov
wrote:
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Deterministic algorithm:
For each file:
If not .svg:
This adds kernel TX timestamps to the xen-netfront driver. Tested with chrony
on an AWS EC2 instance.
Signed-off-by: Daniel Drown
---
drivers/net/xen-netfront.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 860a0cce346d..ed
On Thu, Jul 02, 2020 at 02:55:41PM -0300, Jason Gunthorpe wrote:
> On Tue, Jun 23, 2020 at 02:01:03PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky
> >
> > >From Michael,
> >
> > This series handles IPoIB child interface creation with setting
> > interface's HW address.
> >
> > In curren
+Alan, Haotian
On 7/2/2020 11:01 PM, Mathieu Poirier wrote:
> On Thu, 2 Jul 2020 at 03:51, Michael S. Tsirkin wrote:
>>
>> On Thu, Jul 02, 2020 at 01:51:21PM +0530, Kishon Vijay Abraham I wrote:
>>> This series enhances Linux Vhost support to enable SoC-to-SoC
>>> communication over MMIO. This se
On Thu, 2020-07-02 at 21:25 -0700, Jakub Kicinski wrote:
> On Fri, 3 Jul 2020 03:45:45 + Saeed Mahameed wrote:
> > On Thu, 2020-07-02 at 18:47 -0700, Jakub Kicinski wrote:
> > > On Thu, 2 Jul 2020 15:19:14 -0700 Saeed Mahameed wrote:
> > > > From: Ron Diskin
> > > >
> > > > Currently the F
On Thu, Jul 02, 2020 at 04:26:35PM -0700, Kees Cook wrote:
> In order to gain access to the open file's f_cred for kallsym visibility
> permission checks, refactor the module section attributes to use the
> bin_attribute instead of attribute interface. Additionally removes the
> redundant "name" st
The GENET driver interfaces with internal MoCA interface as well as
external MoCA chips like the BCM6802/6803 through a fixed link
interface. It is desirable for the mocad user-space daemon to be able to
control the carrier state based upon out of band messages that it
receives from the MoCA chip.
Fix segfault from bpftool by adding emit_obj_refs_plain when skeleton
code is disabled.
Tested by deleting BUILD_BPF_SKELS in Makefile. We found this doing
backports for Cilium when a testing image pulled in latest bpf-next
bpftool, but kept using an older clang-7.
# ./bpftool prog show
Error: bp
On Fri, 3 Jul 2020 03:45:45 + Saeed Mahameed wrote:
> On Thu, 2020-07-02 at 18:47 -0700, Jakub Kicinski wrote:
> > On Thu, 2 Jul 2020 15:19:14 -0700 Saeed Mahameed wrote:
> > > From: Ron Diskin
> > >
> > > Currently the FW does not generate events for counters other than
> > > error
> > >
From: Eran Ben Elisha
Creation of devlink health reporters is not fatal for mlx5e instance load.
In case of error in reporter's creation, the return value is ignored.
Change all reporters creation functions to return void.
In addition, with this change, a failure in creating a reporter, will not
From: Aya Levin
Add a helper which retrieves the RQ's WQE counter. Use this helper in
the RX reporter diagnose callback.
$ devlink health diagnose pci/:00:0b.0 reporter rx
Common config:
RQ:
type: 2 stride size: 2048 size: 8
CQ:
stride size: 64 size: 1024
RQs:
channel ix
From: Aya Levin
When received a CQE error, the driver inspect the syndrome given by the
firmware. RQ recovery is initiated only as a result of a fatal syndrome;
syndrome which set the RQ into an error state. Hence no need to query
the RQ state at the beginning of the recovery process. Add additio
From: Aya Levin
Upon a TX timeout handle, if the TX reporter was not able to recover
from the error, reopen the channels. If tried to reopen channels, do not
loop over TX queues for timeout.
With that, the reporters state and separation will better
expose the driver's state.
Signed-off-by: Aya
From: Aya Levin
Enhance TX/RX reporter's diagnose to include info about the
corresponding EQ.
$ devlink health diagnose pci/:00:0b.0 reporter rx
Common config:
RQ:
type: 2 stride size: 2048 size: 8
CQ:
stride size: 64 size: 1024
RQs:
channel ix: 0 rqn: 1713 HW sta
From: Aya Levin
Add helper which retrieves the RQ WQE's head. Use this helper in RX
reporter diagnose callback.
Signed-off-by: Aya Levin
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/en/reporter_rx.c | 5 +
drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h
From: Aya Levin
When the RQ is in striding RQ mode, it uses the ICOSQ as a helper queue.
In this mode, RX reporter dumps more info about the ICOSQ and its
related CQ.
$ devlink health diagnose pci/:00:0b.0 reporter rx
Common config:
RQ:
type: 2 stride size: 2048 size: 8
CQ:
From: Aya Levin
Change the hierarchy of the RX reporter 'Common config' in the diagnose
output to match the 'Common config' of the TX reporter which reflects
that CQ is a helper to the traffic queues.
Before:
$ devlink health diagnose pci/:00:0b.0 reporter rx
Common config:
RQ:
typ
From: Aya Levin
Add CQ's consumer index and size to the CQ's diagnose output retruved on
RX/TX reporter diadgnose.
$ devlink health diagnose pci/:00:0b.0 reporter rx
Common config:
RQ:
type: 2 stride size: 2048 size: 8
CQ:
stride size: 64 size: 1024
RQs:
channel i
Hi Dave, Jakub
This series adds misc updates.
For more information please see tag log below.
Please pull and let me know if there is any problem.
Thanks,
Saeed.
---
The following changes since commit 8c8278a5b1a81e099ba883d8a0f9e3df9bdb1a74:
Merge branch 'sfc-prerequisites-for-EF100-driver-p
From: Aya Levin
During queue's recovery, driver waits for flush. The flush timeout is
set to 2 seconds. Add a define for this value for the benefit of RX and
TX reporters.
Signed-off-by: Aya Levin
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en/health.h | 1 +
From: Aya Levin
Use txrx.h to contain helper function regarding TX/RX. In the coming
patches, I will add more RQ helpers.
Signed-off-by: Aya Levin
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 20 ---
.../mellanox/mlx5/core/en/reporter_rx.c
From: Aya Levin
Change prefix to match resident file:
%s/mlx5e_reporter_cq_diagnose/mlx5e_health_cq_diag_fmsg
%s/mlx5e_reporter_cq_common_diagnose/mlx5e_health_cq_common_diag_fmsg
%s/mlx5e_reporter_named_obj_nest_start/mlx5e_health_fmsg_named_obj_nest_start
%s/mlx5e_reporter_named_obj_nest_end/ml
On 2020-07-02 11:07, Taehee Yoo wrote:
There are two problems in rmnet module that they occur the leak of
a lower interface.
The symptom is the same, which is the leak of a lower interface.
But there are two different real problems.
This patchset is to fix these real problems.
1. Do not allow to
On Thu, 2020-07-02 at 18:47 -0700, Jakub Kicinski wrote:
> On Thu, 2 Jul 2020 15:19:14 -0700 Saeed Mahameed wrote:
> > From: Ron Diskin
> >
> > Currently the FW does not generate events for counters other than
> > error
> > counters. Unlike ".get_ethtool_stats", ".ndo_get_stats64" (which ip
> >
On Thu, Jul 2, 2020 at 7:35 PM Alexei Starovoitov
wrote:
>
> On Thu, Jul 02, 2020 at 06:05:29PM -0700, Linus Torvalds wrote:
> > On Thu, Jul 2, 2020 at 1:03 PM Alexei Starovoitov
> > wrote:
> > >
> > > The BPF program dump_bpf_prog() in iterators.bpf.c is printing this data
> > > about
> > > all
On Thu, Jul 2, 2020 at 7:45 PM Song Liu wrote:
>
> Without CONFIG_STACKTRACE stack_trace_save_tsk() is not defined. Let
> get_callchain_entry_for_task() to always return NULL in such cases.
>
> Fixes: fa28dcb82a38 ("bpf: Introduce helper bpf_get_task_stack()")
> Reported-by: kernel test robot
> S
From: Vladyslav Tarasiuk
Register devlink ports upon NIC init. TX and RX health reporters handle
errors which may occur early on at driver initialization. And because
these reporters are to be moved to port context, they require devlink
ports to be already registered.
Signed-off-by: Vladyslav Ta
From: Vladyslav Tarasiuk
Add devlink-health reporter support on per-port basis.
The main difference existing devlink-health is that port reporters are
stored in per-devlink_port lists. Upon creation of such health reporter the
reference to a port it belongs to is stored in reporter struct.
Fill
From: Vladyslav Tarasiuk
Add a generic __devlink_health_reporter_find_by_name() that can be used
with arbitrary devlink health reporter list.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
net/core/devlink.c | 18 ++
1 file changed, 1
From: Vladyslav Tarasiuk
In order to use new devlink port health reporters infrastructure, add
corresponding constructor and destructor functions.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
include/net/devlink.h | 9 +
net/core/devlink.c
From: Vladyslav Tarasiuk
Utilize new devlink-health port reporters API to move rx and tx
reporters from device to port.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c | 9 +++--
drivers/ne
From: Vladyslav Tarasiuk
Prepare a common routine in devlink_health_reporter_create() for usage
in similar functions for devlink port health reporters.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
net/core/devlink.c | 45 +++
From: Vladyslav Tarasiuk
Devlink keeps its own reference to every reporter in a list and inits
refcount to 1 upon reporter's creation. Existing destructor waits to
free the memory indefinitely using msleep() until all references except
devlink's own are put.
Rework this mechanism by moving memor
Implement support for devlink health reporters on per-port basis. First
part in the series prepares common functions parts for health reporter
implementation. Second introduces required API to devlink-health and
mlx5e ones demonstrate its usage and effectively implement the feature
for mlx5 driver.
On Thu, Jul 02, 2020 at 07:32:31PM +0200, Guillaume Nault wrote:
> On Thu, Jul 02, 2020 at 10:41:03PM +0530, Martin Varghese wrote:
> > On Thu, Jul 02, 2020 at 07:03:53PM +0200, Guillaume Nault wrote:
> > > On Thu, Jul 02, 2020 at 09:32:21PM +0530, Martin Varghese wrote:
> > > > On Wed, Jul 01, 202
On Thu, Jul 02, 2020 at 11:57:46AM +0200, Guillaume Nault wrote:
> On Thu, Jul 02, 2020 at 02:45:39PM +0530, Martin Varghese wrote:
> > On Wed, Jul 01, 2020 at 09:45:04PM +0200, Guillaume Nault wrote:
> > > + } else if (matches(*argv, "ethertype") == 0) {
> > > + NEXT_ARG()
On Fri, 3 Jul 2020 at 01:38, kernel test robot wrote:
>
> Hi Vaibhav,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v5.8-rc3 next-20200702]
> [If your patch is applied to the wrong gi
Drivers should not use legacy power management as they have to manage power
states and related operations, for the device, themselves. This driver was
handling them with the help of PCI helper functions.
With generic PM, all essentials will be handled by the PCI core. Driver
needs to do only devic
Drivers should not use legacy power management as they have to manage power
states and related operations, for the device, themselves.
With generic PM, all essentials will be handled by the PCI core. Driver
needs to do only device-specific operations.
Compile-tested only.
Signed-off-by: Vaibhav
Linux Kernel Mentee: Remove Legacy Power Management.
The purpose of this patch series is to remove legacy power management callbacks
from smsc ethernet drivers.
The callbacks performing suspend() and resume() operations are still calling
pci_save_state(), pci_set_power_state(), etc. and handling
Without CONFIG_STACKTRACE stack_trace_save_tsk() is not defined. Let
get_callchain_entry_for_task() to always return NULL in such cases.
Fixes: fa28dcb82a38 ("bpf: Introduce helper bpf_get_task_stack()")
Reported-by: kernel test robot
Signed-off-by: Song Liu
---
kernel/bpf/stackmap.c | 4
From: Tobias Waldekranz Sent: Friday, July 3, 2020 4:58
AM
> In the ISR, we poll the event register for the queues in need of service and
> then enter polled mode. After this point, the event register will never be
> read
> again until we exit polled mode.
>
> In a scenario where a UDP flow is
On Thu, Jul 02, 2020 at 06:05:29PM -0700, Linus Torvalds wrote:
> On Thu, Jul 2, 2020 at 1:03 PM Alexei Starovoitov
> wrote:
> >
> > The BPF program dump_bpf_prog() in iterators.bpf.c is printing this data
> > about
> > all BPF programs currently loaded in the system. This information is
> > uns
From: Sven Van Asbroeck Sent: Friday, July 3, 2020 8:51 AM
> Hi Fabio,
>
> On Thu, Jul 2, 2020 at 6:29 PM Fabio Estevam wrote:
> >
> > With the device tree approach, I think that a better place to touch
> > GPR5 would be inside the fec driver.
> >
>
> Cool idea. I notice that the latest FEC dri
On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote:
> On 02/07/2020 19:19, Andrzej Pietrasiewicz wrote:
> > Hi,
> >
> > W dniu 02.07.2020 o 19:01, Daniel Lezcano pisze:
> > > On 02/07/2020 15:53, Andrzej Pietrasiewicz wrote:
> > > > Hi Daniel,
> > > >
> > > >
> > > >
> > > > > > > > >
> >
On Thu, 2 Jul 2020 15:19:14 -0700 Saeed Mahameed wrote:
> From: Ron Diskin
>
> Currently the FW does not generate events for counters other than error
> counters. Unlike ".get_ethtool_stats", ".ndo_get_stats64" (which ip -s
> uses) might run in atomic context, while the FW interface is non atomi
On 2020/7/3 0:02, Roman Gushchin wrote:
> On Wed, Jul 01, 2020 at 09:48:48PM -0700, Cong Wang wrote:
>> On Tue, Jun 30, 2020 at 3:48 PM Roman Gushchin wrote:
>>>
>>> Btw if we want to backport the problem but can't blame a specific commit,
>>> we can always use something like "Cc: [3.1+]".
>>
On Thu, Jul 2, 2020 at 4:26 PM Kees Cook wrote:
>
> The kprobe show() functions were using "current"'s creds instead
> of the file opener's creds for kallsyms visibility. Fix to use
> seq_file->file->f_cred.
Side note: I have a distinct - but despite that possibly quite
incorrect - memory that I'
On Thu, Jul 2, 2020 at 1:03 PM Alexei Starovoitov
wrote:
>
> The BPF program dump_bpf_prog() in iterators.bpf.c is printing this data about
> all BPF programs currently loaded in the system. This information is unstable
> and will change from kernel to kernel.
If so, it should probably be in debu
> -Original Message-
> From: Jakub Kicinski
> Sent: Thursday, July 2, 2020 10:10 PM
> To: Sudarsana Reddy Kalluru
> Cc: da...@davemloft.net; netdev@vger.kernel.org; Ariel Elior
> ; Igor Russkikh ; Michal
> Kalderon
> Subject: [EXT] Re: [PATCH net 1/1] qed: Populate nvm-file attributes
On 2020/07/03 4:46, Luis Chamberlain wrote:
> On Thu, Jul 02, 2020 at 01:26:53PM +0900, Tetsuo Handa wrote:
>> On 2020/07/02 0:38, Luis Chamberlain wrote:
>>> @@ -156,6 +156,18 @@ static void call_usermodehelper_exec_sync(struct
>>> subprocess_info *sub_info)
>>> */
>>> if
Hi Fabio,
On Thu, Jul 2, 2020 at 6:29 PM Fabio Estevam wrote:
>
> With the device tree approach, I think that a better place to touch
> GPR5 would be inside the fec driver.
>
Cool idea. I notice that the latest FEC driver (v5.8-rc3) accesses individual
bits inside the gpr (via fsl,stop-mode). So
On Thu, Jul 02, 2020 at 02:39:07PM -0700, Cong Wang wrote:
> On Thu, Jul 2, 2020 at 10:32 AM Marcelo Ricardo Leitner
> wrote:
> >
> > On Thu, Jul 02, 2020 at 05:36:38PM +0800, wenxu wrote:
> > >
> > > On 7/2/2020 1:33 AM, Cong Wang wrote:
> > > > On Wed, Jul 1, 2020 at 1:21 AM wenxu wrote:
> > >
On Thu, Jul 02, 2020 at 03:13:49PM -0700, rentao.b...@gmail.com wrote:
> From: Tao Ren
>
> Fix a typo in SENSORS_IR35221 option: module name should be "ir35221"
> instead of "ir35521".
>
> Fixes: 8991ebd9c9a6 ("hwmon: (pmbus) Add client driver for IR35221")
>
> Cc: Samuel Mendoza-Jonas
> Signe
Hi Xin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on ipsec-next/master]
url:
https://github.com/0day-ci/linux/commits/Xin-Long/xfrm-support-ipip-and-ipv6-tunnels-in-vti-and-xfrmi/20200630-154042
base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/
Hi Xin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on ipsec-next/master]
url:
https://github.com/0day-ci/linux/commits/Xin-Long/xfrm-support-ipip-and-ipv6-tunnels-in-vti-and-xfrmi/20200630-154042
base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/
The queue reset pattern is used in a couple different places,
only slightly different from each other, and could cause
issues if one gets changed and the other didn't. This puts
them together so that only one version is needed, yet each
can have slighty different effects by passing in a pointer
to
The printing of section addresses in /sys/module/*/sections/* was not
using the correct credentials to evaluate visibility.
Before:
# cat /sys/module/*/sections/.*text
0xc0458000
...
# capsh --drop=CAP_SYSLOG -- -c "cat /sys/module/*/sections/.*text"
0xc0458000
...
After:
Hi,
I'm not sure who should carry this tree (me? Greg? akpm? Linus?), but
it fixes a kernel address exposure bug reported by Dominik Czarnota,
where /sys/modules/*/sections/* contents were visible to uid-0 without
CAP_SYSLOG (e.g. in containers):
This is correct, with CAP_SYSLOG:
# cat /sys/modu
When evaluating access control over kallsyms visibility, credentials at
open() time need to be used, not the "current" creds (though in BPF's
case, this has likely always been the same). Plumb access to associated
file->f_cred down through bpf_dump_raw_ok() and its callers now that
kallsysm_show_va
In order to gain access to the open file's f_cred for kallsym visibility
permission checks, refactor the module section attributes to use the
bin_attribute instead of attribute interface. Additionally removes the
redundant "name" struct member.
Cc: sta...@vger.kernel.org
Signed-off-by: Kees Cook
In order to perform future tests against the cred saved during open(),
switch kallsyms_show_value() to operate on a cred, and have all current
callers pass current_cred(). This makes it very obvious where callers
are checking the wrong credential in their "read" contexts. These will
be fixed in the
The kprobe show() functions were using "current"'s creds instead
of the file opener's creds for kallsyms visibility. Fix to use
seq_file->file->f_cred.
Cc: sta...@vger.kernel.org
Fixes: 81365a947de4 ("kprobes: Show address of kprobes if kallsyms does")
Fixes: ffb9bd68ebdb ("kprobes: Show blacklist
On Thu, 2 Jul 2020 at 20:21, Ard Biesheuvel wrote:
>
> On Thu, 2 Jul 2020 at 19:50, Eric Biggers wrote:
> >
> > [+linux-wireless, Marcel Holtmann, and Denis Kenzior]
> >
> > On Thu, Jul 02, 2020 at 12:19:44PM +0200, Ard Biesheuvel wrote:
> > > Remove the generic ecb(arc4) skcipher, which is sligh
Hi Alexei,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Alexei-Starovoitov/bpf-Populate-bpffs-with-map-and-prog-iterators/20200703-040602
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-n
On 2020-07-02, Christian Brauner wrote:
> On Thu, Jul 02, 2020 at 08:17:38AM -0500, Eric W. Biederman wrote:
> > Matt Bennett writes:
> >
> > > Previously the connector functionality could only be used by processes
> > > running in the
> > > default network namespace. This meant that any proces
We observed two panics involving races with igb_reset_task.
The first panic is caused by this race condition:
kworker reboot -f
igb_reset_task
igb_reinit_locked
igb_down
napi_synchronize
__igb_shutdown
Hi Sven,
On Thu, Jul 2, 2020 at 2:53 PM Sven Van Asbroeck wrote:
> + /*
> +* On imx6 plus, enet_ref from ANATOP/CCM can be internally routed to
> +* be the PTP clock source, instead of having to be routed through
> +* pads.
> +*/
> + if (of_machine_is_
Hi Xin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on ipsec-next/master]
url:
https://github.com/0day-ci/linux/commits/Xin-Long/xfrm-support-ipip-and-ipv6-tunnels-in-vti-and-xfrmi/20200630-154042
base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/
From: Eran Ben Elisha
Device unit for port buffers size, xoff_threshold and xon_threshold is
cells. Fix a bug in driver where cell unit size was hard-coded to
128 bytes. This hard-coded value is buggy, as it is wrong for some hardware
versions.
Driver to read cell size from SBCAM register and tr
From: Aya Levin
After function reload, CPU mapping used by aRFS RX is broken, leading to
a kernel panic. Fix by moving initialization of rx_cpu_rmap from
netdev_init to netdev_attach. IRQ table is re-allocated on mlx5_load,
but netdev is not re-initialize.
Trace of the panic:
[ 22.055672] genera
From: Eli Britstein
CT entries are deleted via a workqueue from netfilter. If removing the
module before that, the rules are cleaned by the driver itself, but the
memory entries for them are not freed. Fix that.
Fixes: ac991b48d43c ("net/mlx5e: CT: Offload established flows")
Signed-off-by: Eli
From: Aya Levin
Some released FW versions mistakenly don't set the capability that 50G
per lane link-modes are supported for VFs (ptys_extended_ethernet
capability bit). When the capability is unset, read
PTYS.ext_eth_proto_capability (always reliable).
If PTYS.ext_eth_proto_capability is valid (
From: Ron Diskin
Currently the FW does not generate events for counters other than error
counters. Unlike ".get_ethtool_stats", ".ndo_get_stats64" (which ip -s
uses) might run in atomic context, while the FW interface is non atomic.
Thus, 'ip' is not allowed to issue fw commands, so it will only
From: Vu Pham
Refactoring eswitch ingress acl codes accidentally inserts extra
memset zero that removes vlan and/or qos setting in legacy mode.
Fixes: 07bab9502641 ("net/mlx5: E-Switch, Refactor eswitch ingress acl codes")
Signed-off-by: Vu Pham
Signed-off-by: Saeed Mahameed
---
drivers/net/e
From: Vlad Buslov
In mlx5e_configure_flower() flow pointer is protected by rcu read lock.
However, after cited commit the pointer is being used outside of rcu read
block. Extend the block to protect all pointer accesses.
Fixes: 553f9328385d ("net/mlx5e: Support tc block sharing for representors"
From: Eli Cohen
Net devices might be removed. For example, a vxlan device could be
deleted and its ifnidex would become invalid. Use dev_get_by_index()
instead of __dev_get_by_index() to hold reference on the device while
accessing it and release after done.
Fixes: 3c37745ec614 ("net/mlx5e: Prop
From: Eran Ben Elisha
Fix eeprom SFP query support by setting i2c_addr, offset and page number
correctly. Unlike QSFP modules, SFP eeprom params are as follow:
- i2c_addr is 0x50 for offset 0 - 255 and 0x51 for offset 256 - 511.
- Page number is always zero.
- Page offset is always relative to ze
From: Vlad Buslov
In helper function is_flow_rule_duplicate_allowed() verify that rpviv
pointer is not NULL before dereferencing it. This can happen when device is
in NIC mode and leads to following crash:
[90444.046419] BUG: kernel NULL pointer dereference, address:
[90444.0481
Hi Dave,
This series introduces some fixes to mlx5 driver.
Please pull and let me know if there is any problem.
For -stable v5.1
('net/mlx5e: Hold reference on mirred devices while accessing them')
For -stable v5.2
('net/mlx5: Fix eeprom support for SFP module')
For -stable v5.4
('net/mlx5e
From: Aya Levin
When detaching netdev, remove vxlan port configuration using
udp_tunnel_drop_rx_info. During function reload, configuration will be
restored using udp_tunnel_get_rx_info. This ensures sync between
firmware and driver. Use udp_tunnel_get_rx_info even if its physical
interface is do
Hi Alexei,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Alexei-Starovoitov/bpf-Populate-bpffs-with-map-and-prog-iterators/20200703-040602
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-n
On 7/2/20 2:48 AM, Martin KaFai Lau wrote:
This set is separated out from the bpf tcp header option series [1] since
I think it is in general useful for other network related tests.
e.g. enforce socket-fd related timeout and restore netns after each test.
[1]: https://lore.kernel.org/netdev/2020
From: Tao Ren
Fix a typo in SENSORS_IR35221 option: module name should be "ir35221"
instead of "ir35521".
Fixes: 8991ebd9c9a6 ("hwmon: (pmbus) Add client driver for IR35221")
Cc: Samuel Mendoza-Jonas
Signed-off-by: Tao Ren
---
drivers/hwmon/pmbus/Kconfig | 2 +-
1 file changed, 1 insertion(+
On Thu, Jul 2, 2020 at 1:05 PM Alexander A. Klimov
wrote:
>
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contai
From: Jakub Kicinski
Date: Thu, 2 Jul 2020 14:06:48 -0700
> On Thu, 2 Jul 2020 17:25:17 +0100 Edward Cree wrote:
>> Changes in v2:
>> * Patch #1: use efx_mcdi_set_mtu() directly, instead of as a fallback,
>> in the mtu_only case (Jakub)
>> * Patch #3: fix symbol collision in non-modular builds
On Thu, Jul 2, 2020 at 10:32 AM Marcelo Ricardo Leitner
wrote:
>
> On Thu, Jul 02, 2020 at 05:36:38PM +0800, wenxu wrote:
> >
> > On 7/2/2020 1:33 AM, Cong Wang wrote:
> > > On Wed, Jul 1, 2020 at 1:21 AM wenxu wrote:
> > >>
> > >> On 7/1/2020 2:21 PM, wenxu wrote:
> > >>> On 7/1/2020 2:12 PM, Co
From: Colin King
Date: Thu, 2 Jul 2020 15:22:23 +0100
> From: Colin Ian King
>
> The variable act is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value
From:
Date: Thu, 2 Jul 2020 15:00:21 +0200
> From: Nicolas Ferre
>
> I would like that Claudiu becomes co-maintainer of the Cadence macb
> driver. He's already participating to lots of reviews and enhancements
> to this driver and knows the different versions of this controller.
>
> Signed-off
From: Alex Elder
Date: Thu, 2 Jul 2020 06:25:33 -0500
> Add tests to functions so they don't update undefined endpoint
> registers, rather than requiring the caller to avoid calling them.
>
> Move the call to a workaround function required when suspending
> inside the function that puts an endp
From: Codrin Ciubotariu
Date: Thu, 2 Jul 2020 12:44:50 +0300
> The number of ports is incorrectly set to the maximum available for a DSA
> switch. Even if the extra ports are not used, this causes some functions
> to be called later, like port_disable() and port_stp_state_set(). If the
> driver d
> -Original Message-
> From: Francesco Ruggeri
> Sent: Thursday, July 2, 2020 13:20
> To: Kirsher, Jeffrey T
> Cc: Nguyen, Anthony L ; Jakub Kicinski
> ; David Miller ; open list ker...@vger.kernel.org>; netdev ; intel-wired-
> l...@lists.osuosl.org
> Subject: Re: [PATCH] igb: reinit_loc
From: wenxu
Date: Thu, 2 Jul 2020 17:17:47 +0800
> On 7/2/2020 6:21 AM, David Miller wrote:
>> From: we...@ucloud.cn
>> Date: Mon, 29 Jun 2020 17:16:17 +0800
>>
>> Nothing can clobber the qdisc_skb_cb like this in these packet flows
>> otherwise we will have serious crashes and problems. Some pa
From: Wei Yongjun
Date: Thu, 2 Jul 2020 17:19:46 +0800
> In certain configurations without power management support, the
> following warnings happen:
>
> drivers/net/ethernet/mellanox/mlx4/main.c:4388:12:
> warning: 'mlx4_resume' defined but not used [-Wunused-function]
> 4388 | static int mlx
From: Wei Yongjun
Date: Thu, 2 Jul 2020 17:18:10 +0800
> In certain configurations without power management support, gcc report
> the following warning:
>
> drivers/net/ethernet/micrel/ksz884x.c:7182:12: warning:
> 'pcidev_suspend' defined but not used [-Wunused-function]
> 7182 | static int p
From: Claudiu Beznea
Date: Thu, 2 Jul 2020 12:05:57 +0300
> Patches in this series cleanup a bit macb code.
...
Series applied, thanks.
From: Horatiu Vultur
Date: Thu, 2 Jul 2020 10:13:04 +0200
> This patch series extends the MRP netlink interface to allow the userspace
> daemon to get the status of the MRP instances in the kernel.
>
> v3:
> - remove misleading comment
> - fix to use correctly the RCU
>
> v2:
> - fix spar
Hi Xin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on ipsec-next/master]
url:
https://github.com/0day-ci/linux/commits/Xin-Long/xfrm-support-ipip-and-ipv6-tunnels-in-vti-and-xfrmi/20200630-154042
base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/
1 - 100 of 400 matches
Mail list logo
