Re: [PATCH 5/5] connector: Create connector per namespace

2020-07-01 Thread kernel test robot
Hi Matt, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipvs/master] [also build test WARNING on dm/for-next linux/master linus/master v5.8-rc3 next-20200701] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH] Revert "ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb"

2020-07-01 Thread Kalle Valo
Viktor Jägersküpper writes: > Kalle Valo writes: >> Roman Mamedov writes: >> >>> On Sat, 4 Apr 2020 12:18:38 +0800 >>> Qiujun Huang wrote: >>> In ath9k_hif_usb_rx_cb interface number is assumed to be 0. usb_ifnum_to_if(urb->dev, 0) But it isn't always true. The case r

[PATCH][net-next] i40e: prefetch struct page of rx buffer conditionally

2020-07-01 Thread Li RongQing
page_address() accesses struct page only when WANT_PAGE_VIRTUAL or HASHED_PAGE_VIRTUAL is defined, otherwise it returns address based on offset, so we prefetch it conditionally Signed-off-by: Li RongQing --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 ++ 1 file changed, 2 insertions(+) dif

[PATCH v1 2/2] qlcninc: use generic power management

2020-07-01 Thread Vaibhav Gupta
With legacy PM, drivers themselves were responsible for managing the device's power states and takes care of register states. And they use PCI helper functions to do it. After upgrading to the generic structure, PCI core will take care of required tasks and drivers should do only device-specific o

[PATCH v1 1/2] netxen_nic: use generic power management

2020-07-01 Thread Vaibhav Gupta
With legacy PM, drivers themselves were responsible for managing the device's power states and takes care of register states. And they use PCI helper functions to do it. After upgrading to the generic structure, PCI core will take care of required tasks and drivers should do only device-specific o

[PATCH v1 0/2] qlogic: use generic power management

2020-07-01 Thread Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to remove legacy power management callbacks from qlogic ethernet drivers. The callbacks performing suspend() and resume() operations are still calling pci_save_state(), pci_set_power_state(), etc. and handlin

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-07-01 Thread Jonas Bonn
Hi Cong, On 01/07/2020 21:58, Cong Wang wrote: On Wed, Jul 1, 2020 at 9:05 AM Cong Wang wrote: On Tue, Jun 30, 2020 at 2:08 PM Josh Hunt wrote: Do either of you know if there's been any development on a fix for this issue? If not we can propose something. If you have a reproducer, I can l

Re: WARNING: suspicious RCU usage in qrtr_ns_worker

2020-07-01 Thread syzbot
syzbot has bisected this bug to: commit e42671084361302141a09284fde9bbc14fdd16bf Author: Manivannan Sadhasivam Date: Thu May 7 12:53:06 2020 + net: qrtr: Do not depend on ARCH_QCOM bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=105f775510 start commit: 7ae77150 Mer

Re: [PATCH 5/5] connector: Create connector per namespace

2020-07-01 Thread kernel test robot
Hi Matt, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipvs/master] [also build test WARNING on dm/for-next linux/master linus/master v5.8-rc3 next-20200701] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH bpf-next 04/10] bpf: tcp: Allow bpf prog to write and parse BPF TCP header option

2020-07-01 Thread Martin KaFai Lau
On Sun, Jun 28, 2020 at 05:34:48PM -0700, Martin KaFai Lau wrote: > On Sun, Jun 28, 2020 at 11:24:27AM -0700, Alexei Starovoitov wrote: > > On Fri, Jun 26, 2020 at 10:55:26AM -0700, Martin KaFai Lau wrote: > > > > > > Parsing BPF Header Option > > > ─ > > > > > > As mentio

Re: [PATCH bpf-next] bpf: Add bpf_prog iterator

2020-07-01 Thread Yonghong Song
On 7/1/20 6:40 PM, Alexei Starovoitov wrote: From: Alexei Starovoitov It's mostly a copy paste of commit 6086d29def80 ("bpf: Add bpf_map iterator") that is use to implement bpf_seq_file opreations to traverse all bpf programs. Thanks for implementing bpf iter for bpf_progs! Signed-off-b

Re: [PATCH bpf-next 1/4] samples: bpf: fix bpf programs with kprobe/sys_connect event

2020-07-01 Thread Yonghong Song
On 7/1/20 7:16 PM, Daniel T. Lee wrote: Currently, BPF programs with kprobe/sys_connect does not work properly. Commit 34745aed515c ("samples/bpf: fix kprobe attachment issue on x64") This commit modifies the bpf_load behavior of kprobe events in the x64 architecture. If the current kprobe ev

Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-07-01 Thread Cong Wang
On Tue, Jun 30, 2020 at 3:48 PM Roman Gushchin wrote: > > Btw if we want to backport the problem but can't blame a specific commit, > we can always use something like "Cc: [3.1+]". Sure, but if we don't know which is the right commit to blame, then how do we know which stable version should t

Re: [PATCH net-next 03/15] sfc: move modparam 'interrupt_mode' out of common channel code

2020-07-01 Thread kernel test robot
Hi Edward, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-prerequisites-for-EF100-driver-part-3/20200701-225818 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: [PATCH bpf-next 4/4] selftests: bpf: remove unused bpf_map_def_legacy struct

2020-07-01 Thread Andrii Nakryiko
On Wed, Jul 1, 2020 at 7:18 PM Daniel T. Lee wrote: > > samples/bpf no longer use bpf_map_def_legacy and instead use the > libbpf's bpf_map_def or new BTF-defined MAP format. This commit removes > unused bpf_map_def_legacy struct from selftests/bpf/bpf_legacy.h. > > Signed-off-by: Daniel T. Lee >

Re: [PATCH bpf-next 3/4] samples: bpf: refactor BPF map performance test with libbpf

2020-07-01 Thread Andrii Nakryiko
On Wed, Jul 1, 2020 at 7:17 PM Daniel T. Lee wrote: > > Previously, in order to set the numa_node attribute at the time of map > creation using "libbpf", it was necessary to call bpf_create_map_node() > directly (bpf_load approach), instead of calling bpf_object_load() > that handles everything on

[PATCH net-next 2/4] net: phy: Change cable test arguments to net_device

2020-07-01 Thread Florian Fainelli
In order to untangle the ethtool/cabletest feature with the PHY library, make the PHY library functions take a net_device argument and derive the phy_device reference from there. No functional changes introduced. Signed-off-by: Florian Fainelli --- drivers/net/phy/phy.c | 18 ++---

[PATCH net-next 0/4] net: ethtool: Untangle PHYLIB dependency

2020-07-01 Thread Florian Fainelli
Hi all, This patch series untangles the ethtool netlink dependency with PHYLIB which exists because the cable test feature calls directly into PHY library functions. The approach taken here is to utilize a new set of net_device_ops function pointers which are automatically set to the PHY library v

[PATCH net-next 1/4] net: Add cable test netdevice operations

2020-07-01 Thread Florian Fainelli
In preparation for decoupling the ethtool cable test from the PHY library, add definitions for two new network device operations: * ndo_cable_test_start * ndo_cable_test_tdr_start In a subsequent patch we will start making use of those. Signed-off-by: Florian Fainelli --- include/linux/netdevi

[PATCH net-next 4/4] net: ethtool: Remove PHYLIB dependency

2020-07-01 Thread Florian Fainelli
Now that we have converted the ethtool/cabletest code to use netdev_ops, we can remove the PHY library dependency since the function pointers will now be provided upon PHY attachment to the network device. Signed-off-by: Florian Fainelli --- net/Kconfig | 1 - net/ethtool/cabletest.

[PATCH net-next 3/4] net: phy: Automatically set-up cable test netdev_ops

2020-07-01 Thread Florian Fainelli
Upon attach, override the net_device operations with the PHY library cable test operations and conversely, upon detach, revert to the original net_device operations. This will allows us in a subsequent patch to finally decouple the ethtool/cabletest from the PHY library hard depenencies. Signed-o

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-01 Thread Tetsuo Handa
On 2020/07/02 0:38, Luis Chamberlain wrote: > @@ -156,6 +156,18 @@ static void call_usermodehelper_exec_sync(struct > subprocess_info *sub_info) >*/ > if (KWIFEXITED(ret)) > sub_info->retval = KWEXITSTATUS(ret); > + /* > +

Re: [PATCH bpf-next 2/4] samples: bpf: refactor BPF map in map test with libbpf

2020-07-01 Thread Andrii Nakryiko
On Wed, Jul 1, 2020 at 7:17 PM Daniel T. Lee wrote: > > From commit 646f02ffdd49 ("libbpf: Add BTF-defined map-in-map > support"), a way to define internal map in BTF-defined map has been > added. > > Instead of using previous 'inner_map_idx' definition, the structure to > be used for the inner ma

RE: [EXT] net: ethernet: freescale: fec: copybreak handling throughput, dma_sync_* optimisations allowed?

2020-07-01 Thread Andy Duan
From: Kegl Rohit Sent: Thursday, July 2, 2020 2:45 AM > fec_enet_copybreak(u32 length, ...) uses > > dma_sync_single_for_cpu(&fep->pdev->dev, > fec32_to_cpu(bdp->cbd_bufaddr), FEC_ENET_RX_FRSIZE - fep->rx_align, > DMA_FROM_DEVICE); if (!swap) >memcpy(new_skb->data, (*skb)->data, length); > >

Re: [PATCH RESEND net-next v3 2/3] net: enetc: Initialize SerDes for SGMII and USXGMII protocols

2020-07-01 Thread kernel test robot
Hi Michael, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Walle/net-enetc-remove-bootloader-dependency/20200702-053650 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2

[PATCH v1 1/2] atl1e: use generic power management

2020-07-01 Thread Vaibhav Gupta
Remove legacy PM callbacks and use generic operations. With legacy code, drivers were responsible for handling PCI PM operations like pci_save_state(). In generic code, all these hre andled by PCI core. The generic suspend() and resume() are called at the same point the legacy ones were called. Th

[PATCH v1 2/2] atl2: use generic power management

2020-07-01 Thread Vaibhav Gupta
Remove legacy PM callbacks and use generic operations. With legacy code, drivers were responsible for handling PCI PM operations like pci_save_state(). In generic code, all these hre andled by PCI core. The generic suspend() and resume() are called at the same point the legacy ones were called. Th

[PATCH v1 0/2] atheros: use generic power management

2020-07-01 Thread Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to remove legacy power management callbacks from atheros ethernet drivers. The callbacks performing suspend() and resume() operations are still calling pci_save_state(), pci_set_power_state(), etc. and handli

[PATCH bpf-next 2/4] samples: bpf: refactor BPF map in map test with libbpf

2020-07-01 Thread Daniel T. Lee
>From commit 646f02ffdd49 ("libbpf: Add BTF-defined map-in-map support"), a way to define internal map in BTF-defined map has been added. Instead of using previous 'inner_map_idx' definition, the structure to be used for the inner map can be directly defined using array directive. __array(val

[PATCH bpf-next 4/4] selftests: bpf: remove unused bpf_map_def_legacy struct

2020-07-01 Thread Daniel T. Lee
samples/bpf no longer use bpf_map_def_legacy and instead use the libbpf's bpf_map_def or new BTF-defined MAP format. This commit removes unused bpf_map_def_legacy struct from selftests/bpf/bpf_legacy.h. Signed-off-by: Daniel T. Lee --- tools/testing/selftests/bpf/bpf_legacy.h | 14 --

[PATCH bpf-next 0/4] samples: bpf: refactor BPF map test with libbpf

2020-07-01 Thread Daniel T. Lee
There have been many changes in how the current bpf program defines map. The development of libbbpf has led to the new method called BTF-defined map, which is a new way of defining BPF maps, and thus has a lot of differences from the existing MAP definition method. Although bpf_load was also inte

[PATCH bpf-next 1/4] samples: bpf: fix bpf programs with kprobe/sys_connect event

2020-07-01 Thread Daniel T. Lee
Currently, BPF programs with kprobe/sys_connect does not work properly. Commit 34745aed515c ("samples/bpf: fix kprobe attachment issue on x64") This commit modifies the bpf_load behavior of kprobe events in the x64 architecture. If the current kprobe event target starts with "sys_*", add the prefi

[PATCH bpf-next 3/4] samples: bpf: refactor BPF map performance test with libbpf

2020-07-01 Thread Daniel T. Lee
Previously, in order to set the numa_node attribute at the time of map creation using "libbpf", it was necessary to call bpf_create_map_node() directly (bpf_load approach), instead of calling bpf_object_load() that handles everything on its own, including map creation. And because of this problem,

[PATCH] net: cisco : use set_current_state macro

2020-07-01 Thread Xu Wang
Use set_current_state macro instead of current->state = TASK_RUNNING. Signed-off-by: Xu Wang --- drivers/net/wireless/cisco/airo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c index 827bb6d74815..f0bcb6

[PATCH bpf-next] bpf: Add bpf_prog iterator

2020-07-01 Thread Alexei Starovoitov
From: Alexei Starovoitov It's mostly a copy paste of commit 6086d29def80 ("bpf: Add bpf_map iterator") that is use to implement bpf_seq_file opreations to traverse all bpf programs. Signed-off-by: Alexei Starovoitov --- No selftests?! They're coming as part of "usermode_driver for iterators" se

[PATCH AUTOSEL 5.7 26/53] i40e: protect ring accesses with READ- and WRITE_ONCE

2020-07-01 Thread Sasha Levin
From: Ciara Loftus [ Upstream commit d59e267912cd90b0adf33b4659050d831e746317 ] READ_ONCE should be used when reading rings prior to accessing the statistics pointer. Introduce this as well as the corresponding WRITE_ONCE usage when allocating and freeing the rings, to ensure protected access.

[PATCH AUTOSEL 5.7 27/53] ice: protect ring accesses with WRITE_ONCE

2020-07-01 Thread Sasha Levin
From: Ciara Loftus [ Upstream commit b1d95cc2391ffac0c5b27256a4fb0d2cfb021a29 ] The READ_ONCE macro is used when reading rings prior to accessing the statistics pointer. The corresponding WRITE_ONCE usage when allocating and freeing the rings to ensure protected access was not in place. Introduc

[PATCH AUTOSEL 5.7 24/53] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-07-01 Thread Sasha Levin
From: David Christensen [ Upstream commit 3a2656a211caf35e56afc9425e6e518fa52f7fbc ] The driver function tg3_io_error_detected() calls napi_disable twice, without an intervening napi_enable, when the number of EEH errors exceeds eeh_max_freezes, resulting in an indefinite sleep while holding rtn

[PATCH AUTOSEL 5.7 22/53] net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy

2020-07-01 Thread Sasha Levin
From: Sascha Hauer [ Upstream commit b4748553f53f2971e07d2619f13d461daac0f3bb ] The MVNETA_SERDES_CFG register is only available on older SoCs like the Armada XP. On newer SoCs like the Armada 38x the fields are moved to comphy. This patch moves the writes to this register next to the comphy ini

[PATCH AUTOSEL 5.7 23/53] net: ethernet: mvneta: Add 2500BaseX support for SoCs without comphy

2020-07-01 Thread Sasha Levin
From: Sascha Hauer [ Upstream commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 ] The older SoCs like Armada XP support a 2500BaseX mode in the datasheets referred to as DR-SGMII (Double rated SGMII) or HS-SGMII (High Speed SGMII). This is an upclocked 1000BaseX mode, thus PHY_INTERFACE_MODE_2500B

[PATCH AUTOSEL 5.7 25/53] ixgbe: protect ring accesses with READ- and WRITE_ONCE

2020-07-01 Thread Sasha Levin
From: Ciara Loftus [ Upstream commit f140ad9fe2ae16f385f8fe4dc9cf67bb4c51d794 ] READ_ONCE should be used when reading rings prior to accessing the statistics pointer. Introduce this as well as the corresponding WRITE_ONCE usage when allocating and freeing the rings, to ensure protected access.

[PATCH AUTOSEL 5.7 30/53] xprtrdma: Prevent dereferencing r_xprt->rx_ep after it is freed

2020-07-01 Thread Sasha Levin
From: Chuck Lever [ Upstream commit 2acc5cae292355f5f18ad377a2a966e7f03c8fec ] r_xprt->rx_ep is known to be good while the transport's send lock is held. Otherwise additional references on rx_ep must be held when it is used outside of that lock's critical sections. For now, bump the rx_ep refe

[PATCH AUTOSEL 5.7 31/53] usbnet: smsc95xx: Fix use-after-free after removal

2020-07-01 Thread Sasha Levin
From: Tuomas Tynkkynen [ Upstream commit b835a71ef64a61383c414d6bf2896d2c0161deca ] Syzbot reports an use-after-free in workqueue context: BUG: KASAN: use-after-free in mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 __smsc95xx_mdio_read dri

[PATCH AUTOSEL 5.4 21/40] i40e: protect ring accesses with READ- and WRITE_ONCE

2020-07-01 Thread Sasha Levin
From: Ciara Loftus [ Upstream commit d59e267912cd90b0adf33b4659050d831e746317 ] READ_ONCE should be used when reading rings prior to accessing the statistics pointer. Introduce this as well as the corresponding WRITE_ONCE usage when allocating and freeing the rings, to ensure protected access.

[PATCH AUTOSEL 5.4 22/40] ibmvnic: continue to init in CRQ reset returns H_CLOSED

2020-07-01 Thread Sasha Levin
From: Dany Madden [ Upstream commit 8b40eb73509f5704a0e8cd25de0163876299f1a7 ] Continue the reset path when partner adapter is not ready or H_CLOSED is returned from reset crq. This patch allows the CRQ init to proceed to establish a valid CRQ for traffic to flow after reset. Signed-off-by: Dan

[PATCH AUTOSEL 5.4 24/40] usbnet: smsc95xx: Fix use-after-free after removal

2020-07-01 Thread Sasha Levin
From: Tuomas Tynkkynen [ Upstream commit b835a71ef64a61383c414d6bf2896d2c0161deca ] Syzbot reports an use-after-free in workqueue context: BUG: KASAN: use-after-free in mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 __smsc95xx_mdio_read dri

[PATCH AUTOSEL 5.4 12/40] net: usb: ax88179_178a: fix packet alignment padding

2020-07-01 Thread Sasha Levin
From: Jeremy Kerr [ Upstream commit e869e7a17798d85829fa7d4f9bbe1eebd4b2d3f6 ] Using a AX88179 device (0b95:1790), I see two bytes of appended data on every RX packet. For example, this 48-byte ping, using 0xff as a payload byte: 04:20:22.528472 IP 192.168.1.1 > 192.168.1.2: ICMP echo request

[PATCH AUTOSEL 5.4 20/40] ixgbe: protect ring accesses with READ- and WRITE_ONCE

2020-07-01 Thread Sasha Levin
From: Ciara Loftus [ Upstream commit f140ad9fe2ae16f385f8fe4dc9cf67bb4c51d794 ] READ_ONCE should be used when reading rings prior to accessing the statistics pointer. Introduce this as well as the corresponding WRITE_ONCE usage when allocating and freeing the rings, to ensure protected access.

[PATCH AUTOSEL 4.19 06/27] net: usb: ax88179_178a: fix packet alignment padding

2020-07-01 Thread Sasha Levin
From: Jeremy Kerr [ Upstream commit e869e7a17798d85829fa7d4f9bbe1eebd4b2d3f6 ] Using a AX88179 device (0b95:1790), I see two bytes of appended data on every RX packet. For example, this 48-byte ping, using 0xff as a payload byte: 04:20:22.528472 IP 192.168.1.1 > 192.168.1.2: ICMP echo request

[PATCH AUTOSEL 4.19 11/27] ixgbe: protect ring accesses with READ- and WRITE_ONCE

2020-07-01 Thread Sasha Levin
From: Ciara Loftus [ Upstream commit f140ad9fe2ae16f385f8fe4dc9cf67bb4c51d794 ] READ_ONCE should be used when reading rings prior to accessing the statistics pointer. Introduce this as well as the corresponding WRITE_ONCE usage when allocating and freeing the rings, to ensure protected access.

[PATCH AUTOSEL 4.19 13/27] usbnet: smsc95xx: Fix use-after-free after removal

2020-07-01 Thread Sasha Levin
From: Tuomas Tynkkynen [ Upstream commit b835a71ef64a61383c414d6bf2896d2c0161deca ] Syzbot reports an use-after-free in workqueue context: BUG: KASAN: use-after-free in mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 __smsc95xx_mdio_read dri

[PATCH AUTOSEL 4.19 10/27] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-07-01 Thread Sasha Levin
From: David Christensen [ Upstream commit 3a2656a211caf35e56afc9425e6e518fa52f7fbc ] The driver function tg3_io_error_detected() calls napi_disable twice, without an intervening napi_enable, when the number of EEH errors exceeds eeh_max_freezes, resulting in an indefinite sleep while holding rtn

[PATCH AUTOSEL 4.19 12/27] i40e: protect ring accesses with READ- and WRITE_ONCE

2020-07-01 Thread Sasha Levin
From: Ciara Loftus [ Upstream commit d59e267912cd90b0adf33b4659050d831e746317 ] READ_ONCE should be used when reading rings prior to accessing the statistics pointer. Introduce this as well as the corresponding WRITE_ONCE usage when allocating and freeing the rings, to ensure protected access.

[PATCH AUTOSEL 4.14 09/17] usbnet: smsc95xx: Fix use-after-free after removal

2020-07-01 Thread Sasha Levin
From: Tuomas Tynkkynen [ Upstream commit b835a71ef64a61383c414d6bf2896d2c0161deca ] Syzbot reports an use-after-free in workqueue context: BUG: KASAN: use-after-free in mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 __smsc95xx_mdio_read dri

[PATCH AUTOSEL 4.14 08/17] ixgbe: protect ring accesses with READ- and WRITE_ONCE

2020-07-01 Thread Sasha Levin
From: Ciara Loftus [ Upstream commit f140ad9fe2ae16f385f8fe4dc9cf67bb4c51d794 ] READ_ONCE should be used when reading rings prior to accessing the statistics pointer. Introduce this as well as the corresponding WRITE_ONCE usage when allocating and freeing the rings, to ensure protected access.

[PATCH AUTOSEL 4.14 07/17] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-07-01 Thread Sasha Levin
From: David Christensen [ Upstream commit 3a2656a211caf35e56afc9425e6e518fa52f7fbc ] The driver function tg3_io_error_detected() calls napi_disable twice, without an intervening napi_enable, when the number of EEH errors exceeds eeh_max_freezes, resulting in an indefinite sleep while holding rtn

[PATCH AUTOSEL 4.9 02/13] net: usb: ax88179_178a: fix packet alignment padding

2020-07-01 Thread Sasha Levin
From: Jeremy Kerr [ Upstream commit e869e7a17798d85829fa7d4f9bbe1eebd4b2d3f6 ] Using a AX88179 device (0b95:1790), I see two bytes of appended data on every RX packet. For example, this 48-byte ping, using 0xff as a payload byte: 04:20:22.528472 IP 192.168.1.1 > 192.168.1.2: ICMP echo request

[PATCH AUTOSEL 4.9 07/13] usbnet: smsc95xx: Fix use-after-free after removal

2020-07-01 Thread Sasha Levin
From: Tuomas Tynkkynen [ Upstream commit b835a71ef64a61383c414d6bf2896d2c0161deca ] Syzbot reports an use-after-free in workqueue context: BUG: KASAN: use-after-free in mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 __smsc95xx_mdio_read dri

[PATCH AUTOSEL 4.9 06/13] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-07-01 Thread Sasha Levin
From: David Christensen [ Upstream commit 3a2656a211caf35e56afc9425e6e518fa52f7fbc ] The driver function tg3_io_error_detected() calls napi_disable twice, without an intervening napi_enable, when the number of EEH errors exceeds eeh_max_freezes, resulting in an indefinite sleep while holding rtn

[PATCH AUTOSEL 4.4 5/7] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-07-01 Thread Sasha Levin
From: David Christensen [ Upstream commit 3a2656a211caf35e56afc9425e6e518fa52f7fbc ] The driver function tg3_io_error_detected() calls napi_disable twice, without an intervening napi_enable, when the number of EEH errors exceeds eeh_max_freezes, resulting in an indefinite sleep while holding rtn

[PATCH AUTOSEL 4.4 1/7] net: usb: ax88179_178a: fix packet alignment padding

2020-07-01 Thread Sasha Levin
From: Jeremy Kerr [ Upstream commit e869e7a17798d85829fa7d4f9bbe1eebd4b2d3f6 ] Using a AX88179 device (0b95:1790), I see two bytes of appended data on every RX packet. For example, this 48-byte ping, using 0xff as a payload byte: 04:20:22.528472 IP 192.168.1.1 > 192.168.1.2: ICMP echo request

[PATCH AUTOSEL 4.14 03/17] net: usb: ax88179_178a: fix packet alignment padding

2020-07-01 Thread Sasha Levin
From: Jeremy Kerr [ Upstream commit e869e7a17798d85829fa7d4f9bbe1eebd4b2d3f6 ] Using a AX88179 device (0b95:1790), I see two bytes of appended data on every RX packet. For example, this 48-byte ping, using 0xff as a payload byte: 04:20:22.528472 IP 192.168.1.1 > 192.168.1.2: ICMP echo request

[PATCH AUTOSEL 5.4 17/40] net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy

2020-07-01 Thread Sasha Levin
From: Sascha Hauer [ Upstream commit b4748553f53f2971e07d2619f13d461daac0f3bb ] The MVNETA_SERDES_CFG register is only available on older SoCs like the Armada XP. On newer SoCs like the Armada 38x the fields are moved to comphy. This patch moves the writes to this register next to the comphy ini

[PATCH AUTOSEL 5.4 18/40] net: ethernet: mvneta: Add 2500BaseX support for SoCs without comphy

2020-07-01 Thread Sasha Levin
From: Sascha Hauer [ Upstream commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 ] The older SoCs like Armada XP support a 2500BaseX mode in the datasheets referred to as DR-SGMII (Double rated SGMII) or HS-SGMII (High Speed SGMII). This is an upclocked 1000BaseX mode, thus PHY_INTERFACE_MODE_2500B

[PATCH AUTOSEL 5.4 19/40] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-07-01 Thread Sasha Levin
From: David Christensen [ Upstream commit 3a2656a211caf35e56afc9425e6e518fa52f7fbc ] The driver function tg3_io_error_detected() calls napi_disable twice, without an intervening napi_enable, when the number of EEH errors exceeds eeh_max_freezes, resulting in an indefinite sleep while holding rtn

[PATCH AUTOSEL 5.7 17/53] net: usb: ax88179_178a: fix packet alignment padding

2020-07-01 Thread Sasha Levin
From: Jeremy Kerr [ Upstream commit e869e7a17798d85829fa7d4f9bbe1eebd4b2d3f6 ] Using a AX88179 device (0b95:1790), I see two bytes of appended data on every RX packet. For example, this 48-byte ping, using 0xff as a payload byte: 04:20:22.528472 IP 192.168.1.1 > 192.168.1.2: ICMP echo request

[PATCH AUTOSEL 5.7 28/53] ibmvnic: continue to init in CRQ reset returns H_CLOSED

2020-07-01 Thread Sasha Levin
From: Dany Madden [ Upstream commit 8b40eb73509f5704a0e8cd25de0163876299f1a7 ] Continue the reset path when partner adapter is not ready or H_CLOSED is returned from reset crq. This patch allows the CRQ init to proceed to establish a valid CRQ for traffic to flow after reset. Signed-off-by: Dan

Re: [PATCH net-next v4 03/10] net: ethtool: netlink: Add support for triggering a cable test

2020-07-01 Thread David Miller
From: Florian Fainelli Date: Wed, 1 Jul 2020 17:26:23 -0700 > Yes this is annoying, I will have some patches posted tonight that > untangle the dependency. Thank you.

Re: [PATCH] net: dsa: microchip: enable ksz9893 via i2c in the ksz9477 driver

2020-07-01 Thread David Miller
From: Helmut Grohne Date: Wed, 1 Jul 2020 13:22:20 +0200 > The KSZ9893 3-Port Gigabit Ethernet Switch can be controlled via SPI, > I²C or MDIO (very limited and not supported by this driver). While there > is already a compatible entry for the SPI bus, it was missing for I²C. > > Signed-off-by:

[PATCH v2 bpf-next 1/2] bpf: selftests: A few improvements to network_helpers.c

2020-07-01 Thread Martin KaFai Lau
This patch makes a few changes to the network_helpers.c 1) Enforce SO_RCVTIMEO and SO_SNDTIMEO This patch enforces timeout to the network fds through setsockopt SO_RCVTIMEO and SO_SNDTIMEO. It will remove the need for SOCK_NONBLOCK that requires a more demanding timeout logic with epo

[PATCH v2 bpf-next 2/2] bpf: selftests: Restore netns after each test

2020-07-01 Thread Martin KaFai Lau
It is common for networking tests creating its netns and making its own setting under this new netns (e.g. changing tcp sysctl). If the test forgot to restore to the original netns, it would affect the result of other tests. This patch saves the original netns at the beginning and then restores i

[PATCH v2 bpf-next 0/2] bpf: selftests: A few changes to network_helpers and netns-reset

2020-07-01 Thread Martin KaFai Lau
This set is separated out from the bpf tcp header option series [1] since I think it is in general useful for other network related tests. e.g. enforce socket-fd related timeout and restore netns after each test. [1]: https://lore.kernel.org/netdev/20200626175501.1459961-1-ka...@fb.com/ v2: - Men

Re: [PATCH net-next 0/2] mptcp: add receive buffer auto-tuning

2020-07-01 Thread David Miller
From: Florian Westphal Date: Tue, 30 Jun 2020 21:24:43 +0200 > First patch extends the test script to allow for reproducible results. > Second patch adds receive auto-tuning. Its based on what TCP is doing, > only difference is that we use the largest RTT of any of the subflows > and that we wil

Re: [net-next 03/12] iavf: fix error return code in iavf_init_get_resources()

2020-07-01 Thread Jakub Kicinski
On Wed, 1 Jul 2020 15:34:03 -0700 Tony Nguyen wrote: > From: Wei Yongjun > > Fix to return negative error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine") This commit is in net.. > Signe

Re: [PATCH net] tcp: fix SO_RCVLOWAT possible hangs under high mem pressure

2020-07-01 Thread David Miller
From: Eric Dumazet Date: Tue, 30 Jun 2020 13:51:28 -0700 > Whenever tcp_try_rmem_schedule() returns an error, we are under > trouble and should make sure to wakeup readers so that they > can drain socket queues and eventually make room. > > Fixes: 03f45c883c6f ("tcp: avoid extra wakeups for SO_R

Re: [PATCH] net: sched: Allow changing default qdisc to FQ-PIE

2020-07-01 Thread David Miller
From: Danny Lin Date: Wed, 1 Jul 2020 16:01:52 -0700 > Similar to fq_codel and the other qdiscs that can set as default, > fq_pie is also suitable for general use without explicit configuration, > which makes it a valid choice for this. > > This is useful in situations where a painless out-of-t

Re: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2020-07-01

2020-07-01 Thread David Miller
From: Tony Nguyen Date: Wed, 1 Jul 2020 15:34:00 -0700 > This series contains updates to all Intel drivers, but a majority of the > changes are to the i40e driver. > > Jeff converts 'fall through' comments to the 'fallthrough;' keyword for > all Intel drivers. Removed unnecessary delay in the i

Re: [PATCH net] ip: Fix SO_MARK in RST, ACK and ICMP packets

2020-07-01 Thread David Miller
From: Willem de Bruijn Date: Wed, 1 Jul 2020 16:00:06 -0400 > From: Willem de Bruijn > > When no full socket is available, skbs are sent over a per-netns > control socket. Its sk_mark is temporarily adjusted to match that > of the real (request or timewait) socket or to reflect an incoming > s

Re: [PATCH RESEND net-next v3 2/3] net: enetc: Initialize SerDes for SGMII and USXGMII protocols

2020-07-01 Thread Jakub Kicinski
On Wed, 1 Jul 2020 23:34:32 +0200 Michael Walle wrote: > ENETC has ethernet MACs capable of SGMII, 2500BaseX and USXGMII. But in > order to use these protocols some SerDes configurations need to be > performed. The SerDes is configurable via an internal PCS PHY which is > connected to an internal

Re: [PATCH net] tcp: md5: do not send silly options in SYNCOOKIES

2020-07-01 Thread David Miller
From: Eric Dumazet Date: Wed, 1 Jul 2020 12:41:23 -0700 > Whenever cookie_init_timestamp() has been used to encode > ECN,SACK,WSCALE options, we can not remove the TS option in the SYNACK. > > Otherwise, tcp_synack_options() will still advertize options like WSCALE > that we can not deduce late

Re: [PATCH v1] rds: If one path needs re-connection, check all and re-connect

2020-07-01 Thread David Miller
From: rao.sho...@oracle.com Date: Wed, 1 Jul 2020 12:23:38 -0700 > From: Rao Shoaib > > In testing with mprds enabled, Oracle Cluster nodes after reboot were > not able to communicate with others nodes and so failed to rejoin > the cluster. Peers with lower IP address initiated connection but t

Re: [PATCH v2 net] tcp: md5: refine tcp_md5_do_add()/tcp_md5_hash_key() barriers

2020-07-01 Thread David Miller
From: Eric Dumazet Date: Wed, 1 Jul 2020 11:43:04 -0700 > My prior fix went a bit too far, according to Herbert and Mathieu. > > Since we accept that concurrent TCP MD5 lookups might see inconsistent > keys, we can use READ_ONCE()/WRITE_ONCE() instead of smp_rmb()/smp_wmb() > > Clearing all ke

[PATCH 3/5] connector: Ensure callback entry is released

2020-07-01 Thread Matt Bennett
Currently the entry itself appears to be being leaked. Signed-off-by: Matt Bennett --- drivers/connector/cn_queue.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/connector/cn_queue.c b/drivers/connector/cn_queue.c index 49295052ba8b..a82ceeb37f26 100644 --- a/dri

[PATCH 1/5] connector: Use task pid helpers

2020-07-01 Thread Matt Bennett
In preparation for supporting the connector outside of the default network namespace we switch to using these helpers now. As the connector is still only supported in the default namespace this change is a no-op. Signed-off-by: Matt Bennett --- drivers/connector/cn_proc.c | 48 ++

[PATCH 2/5] connector: Use 'current_user_ns' function

2020-07-01 Thread Matt Bennett
In preparation for supporting the connector outside of the default network namespace we switch to using this function now. As the connector is still only supported in the default namespace this change is a no-op. Signed-off-by: Matt Bennett --- drivers/connector/cn_proc.c | 10 +- 1 file

[PATCH 5/5] connector: Create connector per namespace

2020-07-01 Thread Matt Bennett
Move to storing the connector instance per network namespace. In doing so the ability to use the connector functionality outside the default namespace is now available. Signed-off-by: Matt Bennett --- drivers/connector/cn_proc.c | 49 ++ drivers/connector/connector.c | 171 +++

[PATCH 0/5] RFC: connector: Add network namespace awareness

2020-07-01 Thread Matt Bennett
Previously the connector functionality could only be used by processes running in the default network namespace. This meant that any process that uses the connector functionality could not operate correctly when run inside a container. This is a draft patch series that attempts to now allow this

[PATCH 4/5] connector: Prepare for supporting multiple namespaces

2020-07-01 Thread Matt Bennett
Extend the existing function definitions / call sites to start passing the network namespace. For now we still only pass the default namespace. Signed-off-by: Matt Bennett --- Documentation/driver-api/connector.rst | 6 +++--- drivers/connector/cn_proc.c| 5 +++-- drivers/connector

Re: [PATCH net-next v4 03/10] net: ethtool: netlink: Add support for triggering a cable test

2020-07-01 Thread Florian Fainelli
On 7/1/2020 4:00 PM, David Miller wrote: > From: Jakub Kicinski > Date: Wed, 1 Jul 2020 15:56:21 -0700 > >> On Sun, 10 May 2020 21:12:33 +0200 Andrew Lunn wrote: >>> diff --git a/net/Kconfig b/net/Kconfig >>> index c5ba2d180c43..5c524c6ee75d 100644 >>> --- a/net/Kconfig >>> +++ b/net/Kconfig >

Re: [net-next 0/3][pull request] 100GbE Intel Wired LAN Driver Updates 2020-07-01

2020-07-01 Thread David Miller
From: Tony Nguyen Date: Wed, 1 Jul 2020 16:53:23 -0700 > This series contains updates to the ice driver only. > > Jacob implements a devlink region for device capabilities. > > Bruce removes structs containing only one-element arrays that are either > unused or only used for indexing. Instead,

[net-next 3/3] ice: replace single-element array used for C struct hack

2020-07-01 Thread Tony Nguyen
From: Bruce Allan Convert the pre-C90-extension "C struct hack" method (using a single- element array at the end of a structure for implementing variable-length types) to the preferred use of C99 flexible array member. Additional code cleanups were done near areas affected by this change. Signe

[net-next 2/3] ice: avoid unnecessary single-member variable-length structs

2020-07-01 Thread Tony Nguyen
From: Bruce Allan There are a number of structures that consist of a one-element array as the only struct member. Some of those are unused so remove them. Others are used to index into a buffer/array consisting of a variable number of a different data or structure type. Those are unnecessary si

[net-next 0/3][pull request] 100GbE Intel Wired LAN Driver Updates 2020-07-01

2020-07-01 Thread Tony Nguyen
This series contains updates to the ice driver only. Jacob implements a devlink region for device capabilities. Bruce removes structs containing only one-element arrays that are either unused or only used for indexing. Instead, use pointer arithmetic or other indexing to access the elements. Conv

[net-next 1/3] ice: implement snapshot for device capabilities

2020-07-01 Thread Tony Nguyen
From: Jacob Keller Add a new devlink region used for capturing a snapshot of the device capabilities buffer which is reported by the firmware over the AdminQ. This information can useful in debugging driver and firmware interactions. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-

Re: [PATCH v5 bpf-next 5/9] bpf: cpumap: add the possibility to attach an eBPF program to cpumap

2020-07-01 Thread Daniel Borkmann
On 6/30/20 2:49 PM, Lorenzo Bianconi wrote: [...] +static int cpu_map_bpf_prog_run_xdp(struct bpf_cpu_map_entry *rcpu, + void **frames, int n, + struct xdp_cpumap_stats *stats) +{ + struct xdp_rxq_info rxq; + struct b

Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client

2020-07-01 Thread Jason Gunthorpe
On Wed, Jul 01, 2020 at 10:50:49AM +0100, Mark Brown wrote: > On Tue, Jun 30, 2020 at 02:27:10PM -0300, Jason Gunthorpe wrote: > > > I wonder if SW_MFD might me more apt though? Based on Mark's remarks > > current MFD is 'hw' MFD where the created platform_devices expect a > > MMIO pass through, w

Re: [PATCH net-next 01/15] sfc: support setting MTU even if not privileged to configure MAC fully

2020-07-01 Thread Jakub Kicinski
On Wed, 1 Jul 2020 23:13:13 +0100 Edward Cree wrote: > On 01/07/2020 20:03, Jakub Kicinski wrote: > > On Wed, 1 Jul 2020 15:51:25 +0100 Edward Cree wrote: > >> Unprivileged functions (such as VFs) may set their MTU by use of the > >> 'control' field of MC_CMD_SET_MAC_EXT, as used in efx_mcdi_set

Re: [PATCH net-next] sfc: remove udp_tnl_has_port

2020-07-01 Thread Jakub Kicinski
On Wed, 1 Jul 2020 23:02:09 +0100 Edward Cree wrote: > On 01/07/2020 19:43, Jakub Kicinski wrote: > > There's a number of drivers which try to match the UDP ports. That > > seems fragile to me. Is it actually required for HW to operate > > correctly? > For EF10 hardware, yes, because the hardwar

Re: [PATCH v5 bpf-next 5/9] bpf: cpumap: add the possibility to attach an eBPF program to cpumap

2020-07-01 Thread Daniel Borkmann
On 6/30/20 2:49 PM, Lorenzo Bianconi wrote: [...] diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 52d71525c2ff..0ac7b11302c2 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -226,6 +226,7 @@ enum bpf_attach_type { BPF_CGROUP_INET4_GETSOCKNAME,

[PATCH] net: sched: Allow changing default qdisc to FQ-PIE

2020-07-01 Thread Danny Lin
Similar to fq_codel and the other qdiscs that can set as default, fq_pie is also suitable for general use without explicit configuration, which makes it a valid choice for this. This is useful in situations where a painless out-of-the-box solution for reducing bufferbloat is desired but fq_codel i

  1   2   3   4   >