Re: [PATCH net-next] bareudp: Added attribute to enable & disable rx metadata collection

2020-06-28 Thread David Miller
From: Martin Varghese Date: Sun, 28 Jun 2020 23:18:23 +0530 > From: Martin > > Metadata need not be collected in receive if the packet from bareudp > device is not targeted to openvswitch. > > Signed-off-by: Martin Applied, thank you.

Re: [PATCH net] lib: packing: add documentation for pbuflen argument

2020-06-28 Thread David Miller
From: Vladimir Oltean Date: Sun, 28 Jun 2020 17:49:35 +0300 > Fixes sparse warning: > > Function parameter or member 'pbuflen' not described in 'packing' > > Fixes: 554aae35007e ("lib: Add support for generic packing operations") > Signed-off-by: Vladimir Oltean > --- > Hi David, since the ori

Re: [PATCH net] bridge: mrp: Fix endian conversion and some other warnings

2020-06-28 Thread David Miller
From: Horatiu Vultur Date: Sun, 28 Jun 2020 15:45:16 +0200 > The following sparse warnings are fixed: > net/bridge/br_mrp.c:106:18: warning: incorrect type in assignment (different > base types) > net/bridge/br_mrp.c:106:18:expected unsigned short [usertype] > net/bridge/br_mrp.c:106:18:

Re: [PATCH net-next v4 0/5] hinic: add some ethtool ops support

2020-06-28 Thread David Miller
From: Luo bin Date: Sun, 28 Jun 2020 20:36:19 +0800 > patch #1: support to set and get pause params with > "ethtool -A/a" cmd > patch #2: support to set and get irq coalesce params with > "ethtool -C/c" cmd > patch #3: support to do self test with "ethtool -t" cmd > patch #4:

Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

2020-06-28 Thread Pkshih
On Mon, 2020-06-29 at 11:12 +0800, Pkshih wrote: > On Sun, 2020-06-28 at 19:51 -0700, j...@perches.com wrote: > > On 2020-06-28 19:09, Pkshih wrote: > > > On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote: > > >  > > > Use 'rtlwifi:' as subject title prefix is enough, likes > > >   rtlwifi: Use

[PATCH v1 0/2] ipw2x00: use generic power management

2020-06-28 Thread Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to remove legacy power management callbacks from amd ethernet drivers. The callbacks performing suspend() and resume() operations are still calling pci_save_state(), pci_set_power_state(), etc. and handling t

[PATCH v1 1/2] ipw2100: use generic power management

2020-06-28 Thread Vaibhav Gupta
With legacy PM, drivers themselves were responsible for managing the device's power states and takes care of register states. After upgrading to the generic structure, PCI core will take care of required tasks and drivers should do only device-specific operations. The driver was invoking PCI help

[PATCH v1 2/2] ipw2200: use generic power management

2020-06-28 Thread Vaibhav Gupta
With legacy PM, drivers themselves were responsible for managing the device's power states and takes care of register states. After upgrading to the generic structure, PCI core will take care of required tasks and drivers should do only device-specific operations. The driver was invoking PCI help

Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

2020-06-28 Thread Pkshih
On Sun, 2020-06-28 at 19:51 -0700, j...@perches.com wrote: > On 2020-06-28 19:09, Pkshih wrote: > > On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote: > >  > > Use 'rtlwifi:' as subject title prefix is enough, likes > >   rtlwifi: Use const in swing_table declarations > > We disagree. > > I li

Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

2020-06-28 Thread joe
On 2020-06-28 19:09, Pkshih wrote: On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote: Use 'rtlwifi:' as subject title prefix is enough, likes   rtlwifi: Use const in swing_table declarations We disagree. I like knowing what content is changed via patch subject lines as there are 3 rtlwifi

[v1,net-next] net:qos: police action offloading parameter 'burst' change to the original value

2020-06-28 Thread Po Liu
Since 'tcfp_burst' with TICK factor, driver side always need to recover it to the original value, this patch moves the generic calculation and recover to the 'burst' original value before offloading to device driver. Signed-off-by: Po Liu Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelo

Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

2020-06-28 Thread Pkshih
On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote: Use 'rtlwifi:' as subject title prefix is enough, likes   rtlwifi: Use const in swing_table declarations > Reduce data usage about 1KB by using const. > > Signed-off-by: Joe Perches > --- >  .../net/wireless/realtek/rtlwifi/rtl8188ee/dm.c   

[v2,iproute2-next 2/2] action police: make 'mtu' could be set independently in police action

2020-06-28 Thread Po Liu
Current police action must set 'rate' and 'burst'. 'mtu' parameter set the max frame size and could be set alone without 'rate' and 'burst' in some situation. Offloading to hardware for example, 'mtu' could limit the flow max frame size. Signed-off-by: Po Liu --- v1->v2 changes: - fix the print m

[v2,iproute2-next 1/2] action police: change the print message quotes style

2020-06-28 Thread Po Liu
Change the double quotes to single quotes in fprintf message to make it more readable. Signed-off-by: Po Liu --- v1->v2 changes: - Patch new added tc/m_police.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tc/m_police.c b/tc/m_police.c index a5bc20c0..7eb47f8e 100

RE: Re: [iproute2-next] action police: make 'mtu' could be set independently in police action

2020-06-28 Thread Po Liu
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: 2020年6月29日 4:16 > To: Po Liu > Cc: dsah...@gmail.com; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; da...@davemloft.net; j...@mojatatu.com; > v...@buslov.dev; Claudiu Manoil ; Vladimir > Oltean ; Alexandru Marg

Re: [PATCH bpf-next 02/10] tcp: bpf: Parse BPF experimental header option

2020-06-28 Thread Martin KaFai Lau
On Sat, Jun 27, 2020 at 10:17:26AM -0700, Eric Dumazet wrote: [ ... ] > It seems strange that we want to add code in TCP stack only to cover a > limited use case (kind 254 and 0xEB9F magic) > > For something like the work Petar Penkov did (to be able to generate > SYNCOOKIES from XDP), we do not

[PATCH] devlint-health.8: use a single-font macro for a single argument

2020-06-28 Thread Bjarni Ingi Gislason
Use a single font macro for a single argument. Remove unnecessary quotes for a single-font macro. Join two lines into one. The output of "nroff" and "groff" is unchanged. Signed-off-by: Bjarni Ingi Gislason --- man/man8/devlink-health.8 | 22 ++ 1 file changed, 10

Re: [PATCH bpf-next 04/10] bpf: tcp: Allow bpf prog to write and parse BPF TCP header option

2020-06-28 Thread Martin KaFai Lau
On Sun, Jun 28, 2020 at 11:24:27AM -0700, Alexei Starovoitov wrote: > On Fri, Jun 26, 2020 at 10:55:26AM -0700, Martin KaFai Lau wrote: > > > > Parsing BPF Header Option > > ─ > > > > As mentioned earlier, the received SYN/SYNACK/ACK during the 3WHS > > will be available t

[PATCH] devlink-dev.8: use a single-font macro for one argument

2020-06-28 Thread Bjarni Ingi Gislason
Use a single-font macro for one argument. Remove unnecessary quotes for a single font macro. Join some lines into one. The output of "nroff" and "groff" is unchanged, except for a font change in two lines. Signed-off-by: Bjarni Ingi Gislason --- man/man8/devlink-dev.8 | 89 +++

Re: [PATCH bpf-next 02/10] tcp: bpf: Parse BPF experimental header option

2020-06-28 Thread Martin KaFai Lau
On Sat, Jun 27, 2020 at 10:17:26AM -0700, Eric Dumazet wrote: > On Fri, Jun 26, 2020 at 10:55 AM Martin KaFai Lau wrote: > > > > This patch adds logic to parse experimental kind 254 with 16 bit magic > > 0xeB9F. The latter patch will allow bpf prog to write and parse data > > under this experimen

[PATCH] devlink.8: Use a single-font macro for a single argument

2020-06-28 Thread Bjarni Ingi Gislason
Use a single-font macro for a single argument Signed-off-by: Bjarni Ingi Gislason --- man/man8/devlink.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/devlink.8 b/man/man8/devlink.8 index 7f4eda56..866fda51 100644 --- a/man/man8/devlink.8 +++ b/man/man8/devlink.8

[PATCH] man8/bridge.8: fix misuse of two-fonts macros

2020-06-28 Thread Bjarni Ingi Gislason
Use a single-font macro for a single argument. Signed-off-by: Bjarni Ingi Gislason --- man/man8/bridge.8 | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index fa8c0049..ad05cd7c 100644 --- a/man

Re: [PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

2020-06-28 Thread Russell King - ARM Linux admin
On Sun, Jun 28, 2020 at 09:36:35PM +, Colton Lewis wrote: > > We seem to be having a communication breakdown. In review to your > > version 2 patch set, I said: > > > >However, please drop all your changes for everything but the > >"struct phylink_config" documentation change; I'm int

[PATCH v4 2/2] net: core: correct trivial kernel-doc inconsistencies

2020-06-28 Thread Colton Lewis
Silence documentation build warnings by correcting kernel-doc comments. ./include/linux/netdevice.h:2138: warning: Function parameter or member 'napi_defer_hard_irqs' not described in 'net_device' Signed-off-by: Colton Lewis --- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+)

[PATCH v4 1/2] net: core: correct trivial kernel-doc inconsistencies

2020-06-28 Thread Colton Lewis
Silence documentation build warnings by correcting kernel-doc comments. ./net/core/dev.c:7913: warning: Function parameter or member 'dev' not described in 'netdev_get_xmit_slave' Signed-off-by: Colton Lewis --- net/core/dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/dev.c

Re: [PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

2020-06-28 Thread Colton Lewis
> We seem to be having a communication breakdown. In review to your > version 2 patch set, I said: > >However, please drop all your changes for everything but the >"struct phylink_config" documentation change; I'm intending to change >all these method signatures, which means your chan

Re: [PATCH v4 bpf-next 05/14] bpf: Remove btf_id helpers resolving

2020-06-28 Thread Jiri Olsa
On Sun, Jun 28, 2020 at 01:59:54PM -0700, Yonghong Song wrote: SNIP > > > > > > The corresponding BTF_ID definition here is: > > >BTF_ID_LIST(bpf_skb_output_btf_ids) > > >BTF_ID(struct, sk_buff) > > > > > > The bpf helper writer needs to ensure proper declarations > > > of BTF_IDs like

[PATCH net-next 1/2] r8169: merge handling of RTL8101e and RTL8100e

2020-06-28 Thread Heiner Kallweit
Chip versions 13, 14, 15 are treated the same by the driver, therefore let's merge them. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.h| 2 -- drivers/net/ethernet/realtek/r8169_main.c | 10 +++--- drivers/net/ethernet/realtek/r8169_phy_config.c |

[PATCH net-next 2/2] r8169: sync support for RTL8401 with vendor driver

2020-06-28 Thread Heiner Kallweit
So far RTL8401 was treated like a RTL8101e, means we relied on the BIOS to configure MAC and PHY properly. Make RTL8401 a separate chip version and copy MAC / PHY config from r8101 vendor driver. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.h | 1 + drivers/ne

[PATCH net-next 0/2] r8169: make RTL8401 a separate chip version

2020-06-28 Thread Heiner Kallweit
So far RTL8401 was treated like a RTL8101e, means we relied on the BIOS to configure MAC and PHY properly. Make RTL8401 a separate chip version and copy MAC / PHY config from r8101 vendor driver. Heiner Kallweit (2): r8169: merge handling of RTL8101e and RTL8100e r8169: sync support for RTL840

Re: [PATCH v4 bpf-next 05/14] bpf: Remove btf_id helpers resolving

2020-06-28 Thread Yonghong Song
On 6/28/20 1:16 PM, Jiri Olsa wrote: On Fri, Jun 26, 2020 at 02:36:37PM -0700, Yonghong Song wrote: SNIP - } - - t = btf_type_by_id(btf_vmlinux, t->type); - if (!btf_type_is_ptr(t)) - return -EFAULT; - t = btf_type_by_id(btf_vmlinux, t->type); - i

Re: [PATCH net-next 1/4] tcp: stamp SCM_TSTAMP_ACK later in tcp_clean_rtx_queue()

2020-06-28 Thread Willem de Bruijn
On Sat, Jun 27, 2020 at 12:06 AM Yousuk Seung wrote: > > Currently tp->delivered is updated with sacked packets but not > cumulatively acked when SCP_TSTAMP_ACK is timestamped. This patch moves > a tcp_ack_tstamp() call in tcp_clean_rtx_queue() to later in the loop so > that when a skb is fully ac

Re: [PATCH v4 bpf-next 01/14] bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object

2020-06-28 Thread Yonghong Song
On 6/28/20 12:35 PM, Jiri Olsa wrote: On Sun, Jun 28, 2020 at 12:09:27PM -0700, Alexei Starovoitov wrote: On Fri, Jun 26, 2020 at 02:09:53PM -0700, Yonghong Song wrote: After applying the whole patch set to my bpf-next tree locally, I cannot build: -bash-4.4$ make -j100 && make vmlinux

Re: [PATCH net 1/5] net: ip_tunnel: add header_ops for layer 3 devices

2020-06-28 Thread Willem de Bruijn
On Sat, Jun 27, 2020 at 4:07 AM Jason A. Donenfeld wrote: > > Some devices that take straight up layer 3 packets benefit from having a > shared header_ops so that AF_PACKET sockets can inject packets that are > recognized. This shared infrastructure will be used by other drivers > that currently c

Re: [iproute2-next] action police: make 'mtu' could be set independently in police action

2020-06-28 Thread Stephen Hemminger
On Sun, 28 Jun 2020 09:46:02 +0800 Po Liu wrote: > Current police action must set 'rate' and 'burst'. 'mtu' parameter > set the max frame size and could be set alone without 'rate' and 'burst' > in some situation. Offloading to hardware for example, 'mtu' could limit > the flow max frame size. >

Re: [PATCH v4 bpf-next 05/14] bpf: Remove btf_id helpers resolving

2020-06-28 Thread Jiri Olsa
On Fri, Jun 26, 2020 at 02:36:37PM -0700, Yonghong Song wrote: SNIP > > - } > > - > > - t = btf_type_by_id(btf_vmlinux, t->type); > > - if (!btf_type_is_ptr(t)) > > - return -EFAULT; > > - t = btf_type_by_id(btf_vmlinux, t->type); > > - if (!btf_type_is_func_proto(t)) > > -

Re: wireguard: problem sending via libpcap's packet socket

2020-06-28 Thread Willem de Bruijn
On Sat, Jun 27, 2020 at 1:58 AM Jason A. Donenfeld wrote: > > Hi again Hans, > > A few remarks: although gre implements header_ops, it looks like > various parts of the networking stack change behavior based on it. I'm > still analyzing that to understand the extent of the effects. > Something lik

Re: [PATCH v4 bpf-next 05/14] bpf: Remove btf_id helpers resolving

2020-06-28 Thread Andrii Nakryiko
On Sun, Jun 28, 2020 at 11:50 AM Alexei Starovoitov wrote: > > On Fri, Jun 26, 2020 at 04:29:23PM -0700, Yonghong Song wrote: > > > > > > > > > > -int btf_resolve_helper_id(struct bpf_verifier_log *log, > > > > > - const struct bpf_func_proto *fn, int arg) > > > > > -{ > > >

Re: [PATCH v4 bpf-next 13/14] selftests/bpf: Add test for d_path helper

2020-06-28 Thread Jiri Olsa
On Fri, Jun 26, 2020 at 02:55:34PM -0700, Andrii Nakryiko wrote: SNIP > > + if (cnt_stat >= MAX_EVENT_NUM) > > + return 0; > > + > > + bpf_d_path(path, paths_stat[cnt_stat], MAX_PATH_LEN); > > + cnt_stat++; > > + return 0; > > +} > > + > > +SEC("fentry/filp_c

[PATCH 06/15] net: arc_emac: fix arc_emac_tx()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/arc/emac_main.c |

[PATCH 04/15] caif: fix cfv_netdev_tx()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/caif/caif_virtio.c | 2 +-

[PATCH 02/15] caif: fix caif_xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/caif/caif_serial.c | 2 +-

[PATCH 09/15] net: pch_gbe: fix pch_gbe_xmit_frame()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/oki-semi/pch_gbe/

[PATCH 00/15] always use netdev_tx_t for xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The ndo_start_xmit() methods should return a 'netdev_tx_t', not an int, and so should return NETDEV_TX_OK, not 0. The patches in the series fix most of the remaning drivers and subsystems (those included in allyesconfig on x86). Luc Van Oostenryck (15): cail,hsi: fix cfhsi_xmit()'s return type

[PATCH 01/15] cail,hsi: fix cfhsi_xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too and returning NETDEV_TX_OK instead of 0 accordingly. Signed-off-by: Luc Van Oos

[PATCH 07/15] net: nb8800: fix nb8800_xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/aurora/nb8800.c |

[PATCH 03/15] caif: fix cfspi_xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too and returning NETDEV_TX_OK instead of 0 accordingly. Signed-off-by: Luc Van Oos

[PATCH 10/15] net: dwc-xlgmac: fix xlgmac_xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/synopsys/dwc-xlgm

[PATCH 08/15] net: nfp: fix nfp_net_tx()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/netronome/nfp/nfp

[PATCH 15/15] cxgb4vf: fix t4vf_eth_xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/chelsio/cxgb4vf/a

[PATCH 11/15] net: plip: fix plip_tx_packet()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/plip/plip.c | 4 ++-- 1 fi

[PATCH 14/15] l2tp: fix l2tp_eth_dev_xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- net/l2tp/l2tp_eth.c | 2 +- 1 file cha

[PATCH 13/15] net/hsr: fix hsr_dev_xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- net/hsr/hsr_device.c | 2 +- 1 file ch

[PATCH 12/15] usbnet: ipheth: fix ipheth_tx()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/usb/ipheth.c | 2 +- 1 fil

[PATCH 05/15] net: aquantia: fix aq_ndev_start_xmit()'s return type

2020-06-28 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/aquantia/atlantic

Re: [PATCH v4 bpf-next 06/14] bpf: Use BTF_ID to resolve bpf_ctx_convert struct

2020-06-28 Thread Jiri Olsa
On Fri, Jun 26, 2020 at 02:44:39PM -0700, Yonghong Song wrote: > > > On 6/25/20 3:12 PM, Jiri Olsa wrote: > > This way the ID is resolved during compile time, > > and we can remove the runtime name search. > > > > Signed-off-by: Jiri Olsa > > --- > > kernel/bpf/btf.c | 12 > > 1

Re: [PATCH v4 bpf-next 03/14] bpf: Add BTF_ID_LIST/BTF_ID macros

2020-06-28 Thread Jiri Olsa
On Fri, Jun 26, 2020 at 02:32:48PM -0700, Andrii Nakryiko wrote: SNIP > > [...] > > > diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h > > new file mode 100644 > > index ..f7f9dc4d9a9f > > --- /dev/null > > +++ b/include/linux/btf_ids.h > > @@ -0,0 +1,69 @@ > > +/* SPD

Re: [PATCH v4 bpf-next 02/14] bpf: Compile resolve_btfids tool at kernel compilation start

2020-06-28 Thread Jiri Olsa
On Fri, Jun 26, 2020 at 02:28:30PM -0700, Andrii Nakryiko wrote: > On Thu, Jun 25, 2020 at 4:47 PM Jiri Olsa wrote: > > > > The resolve_btfids tool will be used during the vmlinux linking, > > so it's necessary it's ready for it. > > > > Signed-off-by: Jiri Olsa > > --- > > Not sure about clean

Re: [PATCH v4 bpf-next 10/14] bpf: Add d_path helper

2020-06-28 Thread Jiri Olsa
On Fri, Jun 26, 2020 at 01:38:27PM -0700, Andrii Nakryiko wrote: > On Thu, Jun 25, 2020 at 4:49 PM Jiri Olsa wrote: > > > > Adding d_path helper function that returns full path > > for give 'struct path' object, which needs to be the > > kernel BTF 'path' object. > > > > The helper calls directly

Re: [PATCH v4 bpf-next 01/14] bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object

2020-06-28 Thread Jiri Olsa
On Sun, Jun 28, 2020 at 12:09:27PM -0700, Alexei Starovoitov wrote: > On Fri, Jun 26, 2020 at 02:09:53PM -0700, Yonghong Song wrote: > > > > After applying the whole patch set to my bpf-next tree locally, I cannot > > build: > > > > -bash-4.4$ make -j100 && make vmlinux > > GEN Makefile > >

Re: [PATCH v4 bpf-next 01/14] bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object

2020-06-28 Thread Alexei Starovoitov
On Fri, Jun 26, 2020 at 02:09:53PM -0700, Yonghong Song wrote: > > After applying the whole patch set to my bpf-next tree locally, I cannot > build: > > -bash-4.4$ make -j100 && make vmlinux > GEN Makefile > DESCEND objtool > DESCEND bpf/resolve_btfids > make[4]: *** No rule to make t

Re: [PATCH v4 bpf-next 05/14] bpf: Remove btf_id helpers resolving

2020-06-28 Thread Alexei Starovoitov
On Fri, Jun 26, 2020 at 04:29:23PM -0700, Yonghong Song wrote: > > > > > > > > -int btf_resolve_helper_id(struct bpf_verifier_log *log, > > > > - const struct bpf_func_proto *fn, int arg) > > > > -{ > > > > - int *btf_id = &fn->btf_id[arg]; > > > > - int ret; > > > >

Re: [PATCH bpf-next 04/10] bpf: tcp: Allow bpf prog to write and parse BPF TCP header option

2020-06-28 Thread Alexei Starovoitov
On Fri, Jun 26, 2020 at 10:55:26AM -0700, Martin KaFai Lau wrote: > > Parsing BPF Header Option > ─ > > As mentioned earlier, the received SYN/SYNACK/ACK during the 3WHS > will be available to some specific CB (e.g. the *_ESTABLISHED_CB) > > For established connection, if

Re: [PATCH] bridge-utils: Check parameters reasonable of path cost and port priority

2020-06-28 Thread Stephen Hemminger
On Sun, 28 Jun 2020 12:24:14 + zhangnaru wrote: > Subject: [PATCH] bugfix-bridge-not-check-parameters > brtctl_cmd.c: check parameters reasonable of path cost and port priority > In function br_cmd_setpathcost and br_cmd_setportprio, check the input > parameters are within a reasonable range

Your attention to this news update.

2020-06-28 Thread John Scott Younger
-- Your attention to this news update. The report / analysis received from our correspondence shows that you have NOT received your PAYMENT, due to administrative injustice from unpatriotic and uncivil payment officials. Following the resolution of the U.S Department of State, you are mandated to

[PATCH net-next] bareudp: Added attribute to enable & disable rx metadata collection

2020-06-28 Thread Martin Varghese
From: Martin Metadata need not be collected in receive if the packet from bareudp device is not targeted to openvswitch. Signed-off-by: Martin --- Documentation/networking/bareudp.rst | 6 -- drivers/net/bareudp.c| 23 +-- include/net/bareudp.h

[PATCH net] bridge: mrp: Fix endian conversion and some other warnings

2020-06-28 Thread Horatiu Vultur
The following sparse warnings are fixed: net/bridge/br_mrp.c:106:18: warning: incorrect type in assignment (different base types) net/bridge/br_mrp.c:106:18:expected unsigned short [usertype] net/bridge/br_mrp.c:106:18:got restricted __be16 [usertype] net/bridge/br_mrp.c:281:23: warning: i

Re: [PATCH bpf-next v2 2/4] libbpf: add support for BPF_CGROUP_INET_SOCK_RELEASE

2020-06-28 Thread Alexei Starovoitov
On Fri, Jun 26, 2020 at 05:59:41PM -0700, Andrii Nakryiko wrote: > > As for the cover letter, unless it's some trivial independent fixes, > cover letter ties everything together and is a good place to track > "what changed between versions". So I'd recommend adding it anyways. +1 For independent

Re: [PATCH net] xsk: remove cheap_dma optimization

2020-06-28 Thread Björn Töpel
On 2020-06-27 09:04, Christoph Hellwig wrote: On Sat, Jun 27, 2020 at 01:00:19AM +0200, Daniel Borkmann wrote: Given there is roughly a ~5 weeks window at max where this removal could still be applied in the worst case, could we come up with a fix / proposal first that moves this into the DMA

Re: [Potential Spoof] [PATCH bpf-next 0/2] Support disabling auto-loading of BPF programs

2020-06-28 Thread Alexei Starovoitov
On Fri, Jun 26, 2020 at 1:16 PM Martin KaFai Lau wrote: > > On Thu, Jun 25, 2020 at 04:26:27PM -0700, Andrii Nakryiko wrote: > > Add ability to turn off default auto-loading of each BPF program by libbpf > > on > > BPF object load. This is the feature that allows BPF applications to have > > opti

Re: [PATCH net-next v3 0/2] bridge: mrp: Extend MRP netlink interface with IFLA_BRIDGE_MRP_CLEAR

2020-06-28 Thread Horatiu Vultur
The 06/26/2020 13:00, David Miller wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > From: Horatiu Vultur > Date: Fri, 26 Jun 2020 09:33:47 +0200 > > > This patch series extends MRP netlink interface with IFLA_BRIDGE_MRP_CLEAR. > > To allo

[PATCH] libnetlink.3: display section numbers in roman font, not boldface

2020-06-28 Thread Bjarni Ingi Gislason
Typeset section numbers in roman font, see man-pages(7). ### Details: Output is from: test-groff -b -mandoc -T utf8 -rF0 -t -w w -z [ "test-groff" is a developmental version of "groff" ] <./man/man3/libnetlink.3>:53 (macro BR): only 1 argument, but more are expected <./man/man3/libnetlin

Re: [bpf PATCH v2 0/3] Sockmap RCU splat fix

2020-06-28 Thread Alexei Starovoitov
On Thu, Jun 25, 2020 at 4:12 PM John Fastabend wrote: > > Fix a splat introduced by recent changes to avoid skipping ingress policy > when kTLS is enabled. The RCU splat was introduced because in the non-TLS > case the caller is wrapped in an rcu_read_lock/unlock. But, in the TLS > case we have a

[PATCH net] lib: packing: add documentation for pbuflen argument

2020-06-28 Thread Vladimir Oltean
Fixes sparse warning: Function parameter or member 'pbuflen' not described in 'packing' Fixes: 554aae35007e ("lib: Add support for generic packing operations") Signed-off-by: Vladimir Oltean --- Hi David, since the original "packing" submission went in through your tree, could you please take th

Re: possible deadlock in dev_mc_unsync

2020-06-28 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+08e3d39f3eb864321...@syzkaller.appspotmail.com Tested on: commit: 152c6a4d genetlink: get rid of family->attrbuf git tree: https://github.com/congwang/linux.git net

Re: [PATCH net] bridge: mrp: Fix endian conversion and some other warnings

2020-06-28 Thread Nikolay Aleksandrov
On 28/06/2020 16:45, Horatiu Vultur wrote: > The following sparse warnings are fixed: > net/bridge/br_mrp.c:106:18: warning: incorrect type in assignment (different > base types) > net/bridge/br_mrp.c:106:18:expected unsigned short [usertype] > net/bridge/br_mrp.c:106:18:got restricted __b

[PATCH net-next v4 0/5] hinic: add some ethtool ops support

2020-06-28 Thread Luo bin
patch #1: support to set and get pause params with "ethtool -A/a" cmd patch #2: support to set and get irq coalesce params with "ethtool -C/c" cmd patch #3: support to do self test with "ethtool -t" cmd patch #4: support to identify physical device with "ethtool -p" cmd patch #5

[PATCH net-next v4 2/5] hinic: add support to set and get irq coalesce

2020-06-28 Thread Luo bin
add support to set TX/RX irq coalesce params with ethtool -C and get these params with ethtool -c. Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 8 + .../net/ethernet/huawei/hinic/hinic_ethtool.c | 234 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.

[PATCH net-next v4 3/5] hinic: add self test support

2020-06-28 Thread Luo bin
add support to excute internal and external loopback test with ethtool -t cmd. Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 6 + .../net/ethernet/huawei/hinic/hinic_ethtool.c | 177 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 3 + .../net/

[PATCH net-next v4 4/5] hinic: add support to identify physical device

2020-06-28 Thread Luo bin
add support to identify physical device by flashing an LED attached to it with ethtool -p cmd. Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 34 .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 2 + .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 1 + .

[PATCH net-next v4 5/5] hinic: add support to get eeprom information

2020-06-28 Thread Luo bin
add support to get eeprom information from the plug-in module with ethtool -m cmd. Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 69 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 4 ++ .../net/ethernet/huawei/hinic/hinic_port.c| 72 +

[PATCH net-next v4 1/5] hinic: add support to set and get pause params

2020-06-28 Thread Luo bin
add support to set pause params with ethtool -A and get pause params with ethtool -a. Also remove set_link_ksettings ops for VF and enable pause by default. Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 86 ++- .../net/ethernet/huawei/hinic/hinic_hw_d

Re: [PATCH net-next 1/2] mlxsw: core: Add ethtool support for QSFP-DD transceivers

2020-06-28 Thread Adrian Pop
Hi! Regarding multiple banks, I think that we can have a much more creative way of dealing with them (in the future). At page 76, we have "In particular, support of the Lower Memory and of Page 00h is required for all modules, including passive copper cables. These pages are therefore always imple

Re: [PATCH net-next 1/2] mlxsw: core: Add ethtool support for QSFP-DD transceivers

2020-06-28 Thread Ido Schimmel
On Sat, Jun 27, 2020 at 09:42:10PM +0100, Adrian Pop wrote: > > > > Hi Adrian, Andrew, > > > > Not sure I understand... You want the kernel to always pass page 03h to > > user space (potentially zeroed)? Page 03h is not mandatory according to > > the standard and page 01h contains information if pa

WARNING in tracepoint_add_func

2020-06-28 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7a64135f libbpf: Adjust SEC short cut for expected attach .. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=142782e310 kernel config: https://syzkaller.appspot.com/x/.config?x=dcc6334acae363d4 dashboar

Re: KASAN: slab-out-of-bounds Read in qrtr_endpoint_post

2020-06-28 Thread Manivannan Sadhasivam
Hi Bjorn, On Sat, Jun 27, 2020 at 01:57:13PM -0700, syzbot wrote: > syzbot has found a reproducer for the following crash on: > > HEAD commit:1590a2e1 Merge tag 'acpi-5.8-rc3' of git://git.kernel.org/.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=14b

[PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

2020-06-28 Thread Joe Perches
Reduce data usage about 1KB by using const. Signed-off-by: Joe Perches --- .../net/wireless/realtek/rtlwifi/rtl8188ee/dm.c| 4 +- .../net/wireless/realtek/rtlwifi/rtl8723be/dm.c| 4 +- .../net/wireless/realtek/rtlwifi/rtl8821ae/dm.c| 98 -- 3 files changed, 56 i

[PATCH net-next] liquidio: use list_empty_careful in lio_list_delete_head

2020-06-28 Thread Geliang Tang
Use list_empty_careful() instead of open-coding. Signed-off-by: Geliang Tang --- drivers/net/ethernet/cavium/liquidio/octeon_network.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_network.h b/drivers/net/ethernet/cavium/liquidio

Re: [PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

2020-06-28 Thread Russell King - ARM Linux admin
On Sat, Jun 27, 2020 at 11:58:09PM +, Colton Lewis wrote: > Silence documentation build warnings by correcting kernel-doc > comments. In the case of pcs_{config,an_restart,link_up}, change the > declaration to a normal function since these only there for > documentation anyway. > > ./include/l

[PATCH net-next] sctp: use list_is_singular in sctp_list_single_entry

2020-06-28 Thread Geliang Tang
Use list_is_singular() instead of open-coding. Signed-off-by: Geliang Tang --- include/net/sctp/sctp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h index f8bcb75bb044..e3bd198b00ae 100644 --- a/include/net/sctp/sctp.h +++ b

[PATCH v2] net: phy: marvell10g: support XFI rate matching mode

2020-06-28 Thread Baruch Siach
When the hardware MACTYPE hardware configuration pins are set to "XFI with Rate Matching" the PHY interface operate at fixed 10Gbps speed. The MAC buffer packets in both directions to match various wire speeds. Read the MAC Type field in the Port Control register, and set the MAC interface speed a