Hello,
syzbot found the following crash on:
HEAD commit:7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1630b4d110
kernel config: https://syzkaller.appspot.com/x/.config?x=d195fe572fb15312
das
Hi Steven,
> -Original Message-
> From: Steven Price
> Sent: Friday, June 19, 2020 6:45 PM
> To: Jianyong Wu ; netdev@vger.kernel.org;
> yangbo...@nxp.com; john.stu...@linaro.org; t...@linutronix.de;
> pbonz...@redhat.com; sean.j.christopher...@intel.com; m...@kernel.org;
> richardcoch...
arg cannot be NULL since its already being dereferenced
before. Remove the redundant NULL check.
Signed-off-by: Gaurav Singh
---
net/sched/cls_tcindex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
index 61e95029c18f..78bec
Function ep_rx_complete is being called without NULL checking
in ath10k_htc_rx_completion_handler. Without such check, mal-
formed packet is able to cause jump to NULL.
ep->service_id seems a good candidate for sanity check as it is
used in usb.c.
Signed-off-by: Zekun Shen
---
drivers/net/wirel
On 2020/6/21 0:00, Andrew Lunn wrote:
>> +static int hinic_get_module_eeprom(struct net_device *netdev,
>> + struct ethtool_eeprom *ee, u8 *data)
>> +{
>> +struct hinic_dev *nic_dev = netdev_priv(netdev);
>> +u8 sfp_data[STD_SFP_INFO_MAX_SIZE];
>
> sfp_data wi
Hi Christoph,
> -Original Message-
> From: Christoph Hellwig
> Sent: Friday, June 19, 2020 9:57 PM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> m...@kernel.org; ric
Hi Ido,
> -Original Message-
> From: Ido Schimmel
> Sent: 2020年6月21日 18:04
> To: Po Liu
> Cc: da...@davemloft.net; linux-ker...@vger.kernel.org;
> netdev@vger.kernel.org; vinicius.go...@intel.com; Claudiu Manoil
> ; Vladimir Oltean ;
> Alexandru Marginean ; Xiaoliang Yang
> ; Roy Zang ;
On Sun, Jun 21, 2020 at 11:02:30PM +, Colton Lewis wrote:
> On Sunday, June 21, 2020 10:53:45 AM CDT Russell King - ARM Linux admin wrote:
> > > ---
> > > */
> > > struct phylink_config {
> > > struct device *dev;
> > > @@ -331,7 +333,7 @@ void pcs_get_state(struct phylink_config *config,
Hi all,
While experimenting with FRRouting, I observed the following
behaviour. I'm not sure whether it's intended or not.
In a virtual machine set up as a multicast router, I added two
networks, created a VRF, and enslaved interfaces to both networks to
the VRF, like so:
ip link add blue type v
On Sunday, June 21, 2020 10:53:45 AM CDT Russell King - ARM Linux admin wrote:
> > ---
> > */
> > struct phylink_config {
> > struct device *dev;
> > @@ -331,7 +333,7 @@ void pcs_get_state(struct phylink_config *config,
> > *
> > * For most 10GBASE-R, there is no advertisement.
> > */
From: Russell King
Add helper for clause 22 PCS configuration via the MII bus.
Apart from applying the advertisements, the pcs_config helper also sets
up the BMCR_ANENABLE depending on the in-band AN state.
Signed-off-by: Russell King
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- none
Cha
The same link partner advertisement word is used for both QSGMII and
SGMII, thus treat both interface modes using the same
phylink_decode_sgmii_word() function.
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- none
Changes in v3:
- none
drivers/net/phy/phylink.c | 1 +
1 file changed, 1 inse
From: Vladimir Oltean
PHYLINK now requires that parameters established through
auto-negotiation be written into the MAC at the time of the
mac_link_up() callback. In the case of felix, that means taking the port
out of reset, setting the correct timers for PAUSE frames, and
enabling/disabling TX
From: Vladimir Oltean
state->speed holds a value of 10, 100, 1000 or 2500, but
SYS_MAC_FC_CFG_FC_LINK_SPEED expects a value in the range 0, 1, 2 or 3.
So set the correct speed encoding into this register.
Signed-off-by: Vladimir Oltean
Signed-off-by: Ioana Ciornei
---
Changes in v3:
* patch
Use the helper functions introduced by the newly added
Lynx PCS MDIO module.
Instead of representing the PCS as a phy_device, a mdio_device structure
will be passed to the Lynx module which is now actually implementing all
the PCS configuration and status reporting.
All code previously used for P
Add a Lynx PCS module which exposes the necessary operations to drive
the PCS using PHYLINK.
The majority of the code is extracted from the Felix DSA driver, which
will be also modified in a later patch, and exposed as a separate module
for code reusability purposes.
At the moment, USXGMII (only
From: Vladimir Oltean
In VSC9959, the PCS is the one who performs rate adaptation (symbol
duplication) to the speed negotiated by the PHY. The MAC is unaware of
that and must remain configured for gigabit. If it is configured at
OCELOT_SPEED_10 or OCELOT_SPEED_100, it'll start transmitting PAUSE
In order to support split PCS using PHYLINK properly, we need to add a
phylink_pcs_ops structure.
Note that a DSA driver that wants to use these needs to implement all 4
of them: the DSA core checks the presence of these 4 function pointers
in dsa_switch_ops and only then does it add a PCS to PHYL
Add the locked variant of the clause 45 mdiobus write accessor -
mdiobus_c45_write().
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- none
Changes in v3:
- none
include/linux/mdio.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/mdio.h b/include/linux/mdio.h
index 3
Add support for the Lynx PCS as a separate module in drivers/net/phy/.
The advantage of this structure is that multiple ethernet or switch
drivers used on NXP hardware (ENETC, Felix DSA switch etc) can share the
same implementation of PCS configuration and runtime management.
The PCS is represente
Hello,
I am Mrs. Patricia Edgar
My Sorrow Is Deep Bitter dying Woman here in Hospital Bed in United
State. I Lost my Husband and my only Daughter Angela for heartless
Covid-19 i am the only remaining in the Family dying here in the
Hospital slowly with Coronavirus disease High Blood. i and my late
Le 2020-06-21 à 13:02, Russell King - ARM Linux admin a écrit :
> On Sun, Jun 21, 2020 at 10:37:43PM +0300, Vladimir Oltean wrote:
>> Hi Russell,
>>
>> On Sun, 21 Jun 2020 at 17:34, Russell King - ARM Linux admin
>> wrote:
>>>
>>> All,
>>>
>>> This is now almost four months old, but I see that I d
Hi,
On Sun, 21 Jun 2020, Pablo Neira Ayuso wrote:
> I'll place in this in nf.git unless you have any objection.
No objection at all and thanks!
Acked-by: Jozsef Kadlecsik
Best regards,
Jozsef
> On Sun, Jun 21, 2020 at 08:45:14PM +0100, Russell King - ARM Linux admin
> wrote:
> > Gentle ping
Le 2020-06-21 à 13:24, ѽ҉ᶬḳ℠ a écrit :
> {"kernel":"5.4.46","hostname":"OpenWrt","system":"ARMv7 Processor rev 1
> (v7l)","model":"Turris
> Omnia","board_name":"cznic,turris-omnia","release":{"distribution":"OpenWrt","version":"SNAPSHOT","revision":"r13600-9a477b833a","target":"mvebu/cortexa9","des
> Hello, Lorenzo.
Hi Oleksandr,
>
> Thanks for the quick reply. Please see my observation below.
>
> On Thu, Jun 18, 2020 at 01:18:59PM +0200, Lorenzo Bianconi wrote:
> > I have not reproduced the issue myself yet, but I guess we can try:
> > 1- update to latest Felix's tree [1]
> > 2- could yo
Le 2020-06-21 à 00:59, Maxim Kochetkov a écrit :
> This patch series add new PHY id support.
> Russell King asked to use single style for referencing functions.
>
> Maxim Kochetkov (3):
> net: phy: marvell: use a single style for referencing functions
> net: phy: marvell: Add Marvell 88E1340S
> Sure, I will change the file to be named pcs-lynx.c and the Kconfig
> accordingly.
> Should I wait for you to send the patch moving xpcs to another folder?
Please send it whenever things are agreed with Russell.
It will be a few days before i move stuff around. I have another
patchset making a
Hi Jozsef,
I'll place in this in nf.git unless you have any objection.
Thanks.
On Sun, Jun 21, 2020 at 08:45:14PM +0100, Russell King - ARM Linux admin wrote:
> Gentle ping...
>
> This patch fixes a remotely triggerable kernel oops, and as such can
> be viewed as a remote denial of service atta
{"kernel":"5.4.46","hostname":"OpenWrt","system":"ARMv7 Processor rev 1
(v7l)","model":"Turris
Omnia","board_name":"cznic,turris-omnia","release":{"distribution":"OpenWrt","version":"SNAPSHOT","revision":"r13600-9a477b833a","target":"mvebu/cortexa9","description":"OpenWrt
SNAPSHOT r13600-9a477b8
On Thu, Jun 11, 2020 at 5:51 PM Saeed Mahameed wrote:
>
> On Wed, 2020-06-10 at 14:59 -0400, Jarod Wilson wrote:
> > I've been unable to get my hands on suitable supported hardware to
> > date,
> > but I believe this ought to be all that is needed to enable the mlx5
> > driver to also work with bo
On 17.06.2020 11:09, Jisheng Zhang wrote:
> On Fri, 15 May 2020 19:30:38 +0200 Heiner Kallweit wrote:
>
>
>>
>>
>> On 15.05.2020 18:18, Florian Fainelli wrote:
>>>
>>>
>>> On 5/15/2020 12:41 AM, Jisheng Zhang wrote:
On Thu, 14 May 2020 21:50:53 +0200 Heiner Kallweit wrote:
>
>>>
On Sun, Jun 21, 2020 at 10:37:43PM +0300, Vladimir Oltean wrote:
> Hi Russell,
>
> On Sun, 21 Jun 2020 at 17:34, Russell King - ARM Linux admin
> wrote:
> >
> > All,
> >
> > This is now almost four months old, but I see that I didn't copy the
> > message to everyone who should've been, especially
Gentle ping...
This patch fixes a remotely triggerable kernel oops, and as such can
be viewed as a remote denial of service attack depending on the
netfilter rule setup.
On Wed, Jun 10, 2020 at 09:51:11PM +0100, Russell King wrote:
> When using ip_set with counters and comment, traffic causes the
Hi Russell,
On Sun, 21 Jun 2020 at 17:34, Russell King - ARM Linux admin
wrote:
>
> All,
>
> This is now almost four months old, but I see that I didn't copy the
> message to everyone who should've been, especially for the five
> remaining drivers.
>
> I had asked for input from maintainers to he
> Subject: Re: [PATCH net-next v2 0/5] net: phy: add Lynx PCS MDIO module
>
> Hi Ioana
>
> I will be submitting a patchset soon which does as Russell requested, moving
> drivers into subdirectories.
>
> As part of that, i rename mdio-xpcs to pcs-xpcs, and change its Kconfig symbol
> to PCS_XPC
On Sun, Jun 21, 2020 at 12:03:14PM +0200, Kal Cutter Conley wrote:
> On Sat, Jun 20, 2020 at 8:42 PM Jonathan Lemon
> wrote:
> >
> > On Sat, Jun 20, 2020 at 12:42:36PM +0200, Kal Cutter Conley wrote:
> > > On Thu, Jun 18, 2020 at 5:23 PM Jonathan Lemon
> > > wrote:
> > > >
> > > > On Sun, Jun 1
Hi Antoine,
On 2020-06-19 14:22, Antoine Tenart wrote:
[...]
@@ -999,9 +1553,35 @@ int vsc8584_ptp_probe(struct phy_device *phydev)
if (!vsc8531->ptp)
return -ENOMEM;
+ mutex_init(&vsc8531->phc_lock);
mutex_init(&vsc8531->ts_lock);
+ /* Retrieve the
+Ido
On 6/21/20 1:58 AM, Jason A. Donenfeld wrote:
>
> Finally, it could be the solution is that modules that use the netdev
> notifier never really rely too heavily upon getting notifications, and
> if they need something reliable, then they rearchitect their code to
> not need that. I could ima
Hello,
I have a proposal of great benefit to discourse with you, kindly
respond back for more details.
Thanks
Mr. Albert
Hi Antoine,
Feels weird to review my own patches a year later having written them,
almost nostalgic :)
The review is mostly nitpicks.
On 2020-06-19 14:22, Antoine Tenart wrote:
[...]
@@ -373,6 +374,21 @@ struct vsc8531_private {
unsigned long ingr_flows;
unsigned long egr_flows
Remove the redundant null check for skb.
Signed-off-by: Gaurav Singh
---
net/dcb/dcbnl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index d2a4553bcf39..84dde5a2066e 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1736,7 +1736,7 @@
> Also, there is already a precedent of a PCS module (mdio-xpcs.c, the
> model of which I have followed) and without also changing that
> (which I am not comfortable doing) there is no point of changing
> this one.
I don't give this much value. You often need a couple of
implementation before you
On Sun, Jun 21, 2020 at 05:42:48PM +0200, Andrew Lunn wrote:
> FYI:
>
> Andrew
Thanks for forwarding - Colton, please copy me directly.
>
> - Forwarded message from Colton Lewis
> -
>
> Date: Sun, 21 Jun 2020 02:23:04 +
> From: Colton Lewis
> To: da...@davemloft.net
> Cc:
Hi Ioana
I will be submitting a patchset soon which does as Russell requested,
moving drivers into subdirectories.
As part of that, i rename mdio-xpcs to pcs-xpcs, and change its
Kconfig symbol to PCS_XPCS. It would be nice if you could follow this
new naming, so all i need to do is a move.
Than
Hi Antoine,
On 2020-06-19 14:22, Antoine Tenart wrote:
This patch takes in account the use of the 1588 block in the MACsec
initialization, as a conditional configuration has to be done (when the
1588 block is used).
Signed-off-by: Antoine Tenart
---
drivers/net/phy/mscc/mscc_macsec.c | 4 +++-
Keepalived can set global static ip routes or virtual ip routes dynamically
following VRRP protocol states. Using a dedicated rtm_protocol will help
keeping track of it.
Signed-off-by: Alexandre Cassen
---
include/uapi/linux/rtnetlink.h | 45 +-
1 file changed, 23
Fix check in ethtool_rx_flow_rule_create
Signed-off-by: Gaurav Singh
---
net/ethtool/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index b5df90c981c2..21d5fc0f6bb3 100644
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@
On Sat, 20 Jun 2020 00:57:18 +0200
Lorenzo Bianconi wrote:
> Do not update xdp_redirect_cpu maps running while option loop but
> defer it after all available options have been parsed. This is a
> preliminary patch to pass the program name we want to attach to the
> map entries as a user option
>
On Sun, Jun 21, 2020 at 05:12:49PM +0200, Felix Fietkau wrote:
> On 2020-06-21 16:44, Russell King - ARM Linux admin wrote:
> > On Thu, Feb 20, 2020 at 09:54:44AM +0100, Felix Fietkau wrote:
> >> On 2020-02-18 21:00, Jakub Kicinski wrote:
> >> > On Tue, 18 Feb 2020 10:40:01 + Russell King wrote
On Sat, 20 Jun 2020 00:57:17 +0200
Lorenzo Bianconi wrote:
> From: David Ahern
>
> Move the guts of xdp_convert_buff_to_frame to a new helper,
> xdp_update_frame_from_buff so it can be reused removing code duplication
>
> Suggested-by: Jesper Dangaard Brouer
> Co-developed-by: Lorenzo Biancon
On 2020-06-21 16:44, Russell King - ARM Linux admin wrote:
> On Thu, Feb 20, 2020 at 09:54:44AM +0100, Felix Fietkau wrote:
>> On 2020-02-18 21:00, Jakub Kicinski wrote:
>> > On Tue, 18 Feb 2020 10:40:01 + Russell King wrote:
>> >> Felix's address has been failing for a while now with the follo
The old address has been bouncing for a while now
Signed-off-by: Felix Fietkau
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 68f21d46614c..fc0c1bc24ba0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10808,7 +10808,7 @@ F:
On Thu, Feb 20, 2020 at 09:54:44AM +0100, Felix Fietkau wrote:
> On 2020-02-18 21:00, Jakub Kicinski wrote:
> > On Tue, 18 Feb 2020 10:40:01 + Russell King wrote:
> >> Felix's address has been failing for a while now with the following
> >> non-delivery report:
> >>
> >> This message was creat
Convert the mtk_eth_soc driver to use the finalised link parameters in
mac_link_up() rather than the parameters in mac_config().
Signed-off-by: Russell King
---
This is my untested stab at converting mtk_eth_soc.c to use the state
passed in via mac_link_up() rather than mac_config(). Please test
All,
This is now almost four months old, but I see that I didn't copy the
message to everyone who should've been, especially for the five
remaining drivers.
I had asked for input from maintainers to help me convert their
phylink-using drivers to the new style where mac_link_up() performs
the spee
sock_orphan() call to sk_set_socket() implies clearing the sock TX queue.
This might cause unexpected out-of-order transmit, as outstanding packets
can pick a different TX queue and bypass the ones already queued.
This is undesired in general. More specifically, it breaks the in-order
scheduling pr
On Sun, Jun 21, 2020 at 4:56 PM Dominique Martinet
wrote:
>
> Alexander Kapshuk wrote on Sun, Jun 21, 2020:
> > Fix rcu not being dereferenced cleanly by using the task
> > helpers (un)lock_task_sighand instead of spin_lock_irqsave and
> > spin_unlock_irqrestore to ensure current->sighand is a val
Alexander Kapshuk wrote on Sun, Jun 21, 2020:
> Fix rcu not being dereferenced cleanly by using the task
> helpers (un)lock_task_sighand instead of spin_lock_irqsave and
> spin_unlock_irqrestore to ensure current->sighand is a valid pointer as
> suggested in the email referenced below.
Ack.
I'll t
Fix rcu not being dereferenced cleanly by using the task
helpers (un)lock_task_sighand instead of spin_lock_irqsave and
spin_unlock_irqrestore to ensure current->sighand is a valid pointer as
suggested in the email referenced below.
Signed-off-by: Alexander Kapshuk
Link: https://lore.kernel.org/l
When an interface is being deleted, "/proc/net/dev_snmp6/"
is deleted.
The function for this is addrconf_ifdown() in the addrconf_notify() and
it is called by notification, which is NETDEV_UNREGISTER.
But, if NETDEV_CHANGEMTU is triggered after NETDEV_UNREGISTER,
this proc file will be created agai
On 2020-06-18 11:36 AM, xiangxia.m@gmail.com wrote:
> From: Tonghao Zhang
>
> The commit 0a7fcb78cc21 ("net/mlx5e: Support inner header rewrite with
> goto action"), will decapsulate the tunnel packets if there is a goto
> action in chain 0. But in some case, we don't want do that, for exa
On Sun, Jun 21, 2020 at 02:00:00PM +0300, Ioana Ciornei wrote:
> Add support for the Lynx PCS as a separate module in drivers/net/phy/.
> The advantage of this structure is that multiple ethernet or switch
> drivers used on NXP hardware (ENETC, Felix DSA switch etc) can share the
> same implementat
From: Vladimir Oltean
This series makes some basic multicast forwarding functionality work for
Felix DSA and for Ocelot switchdev. IGMP/MLD snooping in Felix is still
missing, and there are other improvements to be made in the general area
of multicast address filtering towards the CPU, but let's
From: Vladimir Oltean
This adds the mdb hooks in felix and exports the mdb functions from
ocelot.
Signed-off-by: Vladimir Oltean
---
drivers/net/dsa/ocelot/felix.c | 26 ++
drivers/net/ethernet/mscc/ocelot.c | 23 ---
drivers/net/ethernet
From: Vladimir Oltean
When used in DSA mode (as seen in Felix), the DEST_IDX in the MAC table
should point to the PGID for the CPU port (PGID_CPU) and not for the
Ethernet port where the CPU queues are redirected to (also known as Node
Processor Interface - NPI).
Because for Felix this distincti
From: Vladimir Oltean
The current iterators are impossible to understand at first glance
without switching back and forth between the definitions and their
actual use in the for loops.
So introduce some convenience names to help readability.
Signed-off-by: Vladimir Oltean
---
drivers/net/ethe
From: Vladimir Oltean
The ocelot hardware designers have made some hacks to support multicast
IPv4 and IPv6 addresses. Normally, the MAC table matches on MAC
addresses and the destination ports are selected through the DEST_IDX
field of the respective MAC table entry. The DEST_IDX points to a Por
From: Vladimir Oltean
The current procedure for installing a multicast address is hardcoded
for IPv4. But, in the ocelot hardware, there are 3 different procedures
for IPv4, IPv6 and for regular L2 multicast.
For IPv6 (33-33-xx-xx-xx-xx), it's the same as for IPv4
(01-00-5e-xx-xx-xx), except tha
On Sun, Jun 21, 2020 at 1:57 PM Dominique Martinet
wrote:
>
> Alexander Kapshuk wrote on Sun, Jun 21, 2020:
> > Thanks for your feedback.
> > Shall I simply resend the v2 patch with the commit message reworded as
> > you suggested, or should I make it a v3 patch instead?
>
> Yes please resend the
The same link partner advertisement word is used for both QSGMII and
SGMII, thus treat both interface modes using the same
phylink_decode_sgmii_word() function.
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- none
drivers/net/phy/phylink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
Use the helper functions introduced by the newly added
Lynx PCS MDIO module.
Instead of representing the PCS as a phy_device, a mdio_device structure
will be passed to the Lynx module which is now actually implementing all
the PCS configuration and status reporting.
All code previously used for P
Add support for the Lynx PCS as a separate module in drivers/net/phy/.
The advantage of this structure is that multiple ethernet or switch
drivers used on NXP hardware (ENETC, Felix DSA switch etc) can share the
same implementation of PCS configuration and runtime management.
The PCS is represente
From: Russell King
Add helper for clause 22 PCS configuration via the MII bus.
Apart from applying the advertisements, the pcs_config helper also sets
up the BMCR_ANENABLE depending on the in-band AN state.
Signed-off-by: Russell King
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- none
Add a Lynx PCS MDIO module which exposes the necessary operations to
drive the PCS using PHYLINK.
The majority of the code is extracted from the Felix DSA driver, which
will be also modified in a later patch, and exposed as a separate module
for code reusability purposes.
At the moment, USXGMII (
Add the locked variant of the clause 45 mdiobus write accessor -
mdiobus_c45_write().
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- none
include/linux/mdio.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/mdio.h b/include/linux/mdio.h
index 36d2e0673d03..323f1d1fa
Alexander Kapshuk wrote on Sun, Jun 21, 2020:
> Thanks for your feedback.
> Shall I simply resend the v2 patch with the commit message reworded as
> you suggested, or should I make it a v3 patch instead?
Yes please resend the same commit reworded. v2 or v3 doesn't matter
much, the [PATCH whatever]
Syzbot reports an use-after-free in workqueue context:
BUG: KASAN: use-after-free in mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737
mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737
__smsc95xx_mdio_read drivers/net/usb/smsc95xx.c:217 [inline]
smsc95xx_mdio_read+0x583/0x870 drivers/net/usb/sm
On Sun, Jun 21, 2020 at 11:45 AM Dominique Martinet
wrote:
>
> Alexander Kapshuk wrote on Sat, Jun 20, 2020:
> > Use (un)lock_task_sighand instead of spin_lock_irqsave and
> > spin_unlock_irqrestore to ensure current->sighand is a valid pointer as
> > suggested in the email referenced below.
>
> T
On Fri, Mar 06, 2020 at 08:56:06PM +0800, Po Liu wrote:
> Hardware may own many entries for police flow. So that make one(or
> multi) flow to be policed by one hardware entry. This patch add the
> police action index provide to the driver side make it mapping the
> driver hardware entry index.
>
On Sat, Jun 20, 2020 at 8:42 PM Jonathan Lemon wrote:
>
> On Sat, Jun 20, 2020 at 12:42:36PM +0200, Kal Cutter Conley wrote:
> > On Thu, Jun 18, 2020 at 5:23 PM Jonathan Lemon
> > wrote:
> > >
> > > On Sun, Jun 14, 2020 at 10:55:30AM +0200, Kal Cutter Conley wrote:
> > > > Hi Saeed,
> > > > Than
The ordering of netdev_features_strings[] makes no sense when it comes
to user interaction, as list of features in `ethtool -k` input is sorted
according to the corresponding bit's position.
Instead, it *does* make sense when it comes to adding new netdev_features
or modifying existing ones. We hav
The current indentation is an absolute mess of tabs, spaces and their
mixes in different proportions. Convert it all to plain tabs and move
assignment operation char to the right, which is the most commonly
used style in Linux code.
Signed-off-by: Alexander Lobakin
---
net/ethtool/common.c | 120
Commit e585f2363637 ("udp: Changes to udp_offload to support remote
checksum offload") added new GSO type and a corresponding netdev
feature, but missed Ethtool's 'netdev_features_strings' table.
Give it a name so it will be exposed to userspace and become available
for manual configuration.
Fixes
This little series adds the last forgotten feature string for
NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses
in future.
Patches 2-3 seem more like net-next candidates rather than net-fixes,
but for me it seems a bit more suitable to pull it during "quiet" RC
windows, so any new rel
Hi,
In register_netdevice, there's a call to
call_netdevice_notifiers(NETDEV_REGISTER), whose return value is
checked to determine whether or not to roll back the device
registration. The reason checking that return value is important is
because this represents an opportunity for the various notif
On Sat, Jun 20, 2020 at 03:56:39PM +0300, Vadym Kochan wrote:
> But it will look same as prestera_destroy_ports(), do you think
> this is not a problem to have a same logic doubled ?
No, error paths of init() usually share logic with fini(). The benefits
of being consistent, always having init() f
Alexander Kapshuk wrote on Sat, Jun 20, 2020:
> Use (un)lock_task_sighand instead of spin_lock_irqsave and
> spin_unlock_irqrestore to ensure current->sighand is a valid pointer as
> suggested in the email referenced below.
Thanks for v2! Patch itself looks good to me.
I always add another `Link:
From: Petr Machata
Add fields related to L4_PORT_ACTION, which is used for changing of TCP and
UDP port numbers.
Signed-off-by: Petr Machata
Reviewed-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
.../mellanox/mlxsw/core_acl_flex_actions.c| 26 +++
1 file changed, 26 inse
From: Petr Machata
Add a test that checks that pedit adjusts port numbers of tcp and udp
packets.
Signed-off-by: Petr Machata
Signed-off-by: Ido Schimmel
---
.../selftests/net/forwarding/pedit_l4port.sh | 198 ++
1 file changed, 198 insertions(+)
create mode 100755 tools/tes
From: Petr Machata
Certain ACL actions are only available on some Spectrum revisions. In
particular, L4_PORT_ACTION is not available on Spectrum-1. Introduce a
new ops struct intended to hold these differences, mlxsw_sp_rulei_ops.
Prime it with a sole member, act_mangle_field, meant for handling
From: Ido Schimmel
Petr says:
On Spectrum-2 and Spectrum-3, it is possible to overwrite L4 port number of
a TCP or UDP packet in the ACL engine. That corresponds to the pedit munges
of tcp and udp sport resp. dport fields. Offload these munges on the
systems where they are supported.
The curren
From: Petr Machata
Spectrum-2 supports an ACL action L4_PORT, which allows TCP and UDP source
and destination port number change. Offload suitable mangles to this
action.
Signed-off-by: Petr Machata
Reviewed-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
.../mellanox/mlxsw/core_acl_flex_acti
> out and this commit was modified to prints an error message. it is an
> inappropriate conversion by used phy_read_poll_timeout() to introduce
> this bug. so fix this issue by use read_poll_timeout() to replace
> phy_read_poll_timeout().
Will another wording variant be nicer (with less typos) for
From: Ido Schimmel
The second commit cited below performed a cast of 'u32 buffsize' to
'(u16 *)' when calling mlxsw_sp_port_headroom_8x_adjust():
mlxsw_sp_port_headroom_8x_adjust(mlxsw_sp_port, (u16 *) &buffsize);
Colin noted that this will behave differently on big endian
architectures compare
Hi Sergei,
On Sat, Jun 20, 2020 at 8:16 PM Sergei Shtylyov
wrote:
> On 06/19/2020 10:15 PM, Geert Uytterhoeven wrote:
> > Some EtherAVB variants support internal clock delay configuration, which
> > can add larger delays than the delays that are typically supported by
> > the PHY (using an "rgmii
Hi Oleksij,
On Sat, Jun 20, 2020 at 7:47 AM Oleksij Rempel wrote:
> Am 19.06.20 um 21:15 schrieb Geert Uytterhoeven:
> > Some EtherAVB variants support internal clock delay configuration, which
> > can add larger delays than the delays that are typically supported by
> > the PHY (using an "rgmii-
Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding
documentation to json-schema.
Add missing properties.
Update the example to match reality.
Signed-off-by: Geert Uytterhoeven
---
This includes the changes made in "[PATCH/RFC 1/5] dt-bindings: net:
renesas,ravb: Document inter
Add support for this new phy ID.
Signed-off-by: Maxim Kochetkov
---
drivers/net/phy/marvell.c | 23 +++
include/linux/marvell_phy.h | 1 +
2 files changed, 24 insertions(+)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 0842deb33085..bb86ac0bd092
The kernel in general does not use &func referencing format.
Signed-off-by: Maxim Kochetkov
---
drivers/net/phy/marvell.c | 222 +++---
1 file changed, 111 insertions(+), 111 deletions(-)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index c9
This patch series add new PHY id support.
Russell King asked to use single style for referencing functions.
Maxim Kochetkov (3):
net: phy: marvell: use a single style for referencing functions
net: phy: marvell: Add Marvell 88E1340S support
net: phy: marvell: Add Marvell 88E1548P support
d
1 - 100 of 101 matches
Mail list logo
