Hi David
My next hops are final real servers but not load balancers, say we sets maximum
number of servers to 64, but next hop entry is added or removed dynamically, we
are unlikely to know them beforehand. I can't understand how user space can
attain consistent distribution without in-kernel c
Some fields were moved from struct phylink into phylink_config.
Update the kernel-doc markups for the config struct accordingly
Fixes: 5c05c1dbb177 ("net: phylink, dsa: eliminate phylink_fixed_state_cb()")
Signed-off-by: Mauro Carvalho Chehab
---
include/linux/phylink.h | 4
1 file changed,
The __ETHTOOL_DECLARE_LINK_MODE_MASK macro is a variant of
DECLARE_BITMAP(), used by phylink.h. As we have already a
parser for DECLARE_BITMAP(), let's add one for this macro,
in order to avoid such warnings:
./include/linux/phylink.h:54: warning: Function parameter or member
'__ETHTOOL_D
Changeset 6f8b12d661d0 ("net: napi: add hard irqs deferral feature")
added a new element at struct net_device.
Add a description for it, based on what's described at the changeset
which added such feature.
Fixes: 6f8b12d661d0 ("net: napi: add hard irqs deferral feature")
Signed-off-by: Mauro Carv
The dev argument was not listed at kernel-doc markup:
./net/core/dev.c:7878: warning: Function parameter or member 'dev' not
described in 'netdev_get_xmit_slave'
Signed-off-by: Mauro Carvalho Chehab
---
net/core/dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/dev.c b
There are some function pointer prototypes inside the net
includes, like this one:
int (*pcs_config)(struct phylink_config *config, unsigned int mode,
phy_interface_t interface, const unsigned long
*advertising);
There's nothing wrong using it with kernel-doc, b
There are some new broken doc links due to yaml renames
at DT. Developers should really run:
./scripts/documentation-file-ref-check
in order to solve those issues while submitting patches.
This tool can even fix most of the issues with:
./scripts/documentation-file-ref-check --fi
Even if that's only a warning, not including asm/cacheflush.h
leads to svc_flush_bvec() being empty allthough powerpc defines
ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE.
CC net/sunrpc/svcsock.o
net/sunrpc/svcsock.c:227:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not
defined [-Wundef]
#if AR
On 15.06.2020 01:26, Michal Kubecek wrote:
> On Mon, Jun 15, 2020 at 12:35:30AM +0200, Heiner Kallweit wrote:
>> Seems that disabling ETHTOOL_NETLINK for PHYLIB=m has (at least) one
>> more side effect. I just saw that ifconfig doesn't report LOWER_UP
>> any longer. Reason seems to be that the ioct
Le 14/06/2020 à 20:57, Chuck Lever a écrit :
Hi Christophe -
On Jun 14, 2020, at 1:07 PM, Christophe Leroy
wrote:
Even if that's only a warning, not including asm/cacheflush.h
leads to svc_flush_bvec() being empty allthough powerpc defines
ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE.
CC net
Hi Sergei-san,
(add your private email address to CC.)
> From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
>
> According to the report of [1], this driver is possible to cause
> the following error in ravb_tx_timeout_work().
>
> ravb e680.ethernet ethernet: failed to switch device
From: Martin
Code to handle multiproto configuration is missing.
Fixes: 4b5f67232d95 ("net: Special handling for IP & MPLS")
Signed-off-by: Martin
---
drivers/net/bareudp.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c
index efd1a1d..3dd
Using a AX88179 device (0b95:1790), I see two bytes of appended data on
every RX packet. For example, this 48-byte ping, using 0xff as a
payload byte:
04:20:22.528472 IP 192.168.1.1 > 192.168.1.2: ICMP echo request, id 2447, seq
1, length 64
0x: 000a cd35 ea50 000a cd35 ea4f 0800 4
Hi Louis,
> Thanks for the correction.
> Indeed, the hardware adds two bytes dummy data at beginning of
> Ethernet packet to make IP header aligned.
> The original patch made by Freddy contains the length of dummy
> header.
OK, thanks for checking. I understand this to mean that the fix is
corr
-邮件原件-
发件人: David Ahern [mailto:dsah...@gmail.com]
发送时间: Saturday, June 13, 2020 22:32
收件人: Guodeqing (A) ; da...@davemloft.net
抄送: kuz...@ms2.inr.ac.ru; netdev@vger.kernel.org; d...@cumulusnetworks.com;
k...@kernel.org
主题: Re: [PATCH] net: Fix the arp error in some cases
On 6/13/20 12
On 2020/6/11 下午5:06, Michael S. Tsirkin wrote:
On Thu, Jun 11, 2020 at 11:02:57AM +0800, Jason Wang wrote:
On 2020/6/10 下午7:05, Michael S. Tsirkin wrote:
+EXPORT_SYMBOL_GPL(vhost_get_vq_desc);
/* Reverse the effect of vhost_get_vq_desc. Useful for error handling. */
void vhost_discard
socket malloced by sock_create_kern() should be release before return
in the error handling, otherwise it cause memory leak.
unreferenced object 0x88810910c000 (size 1216):
comm "0003_test_m", pid 12238, jiffies 4295050289 (age 54.237s)
hex dump (first 32 bytes):
01 00 00 00 01 00
On Sun, Jun 14, 2020 at 7:19 AM Sven Auhagen wrote:
>
> The ethtool rx and tx queue statistics are reporting wrong values.
> Fix reading out the correct ones.
>
> Signed-off-by: Sven Auhagen
Hi Sven,
seems to work as expected now:
# ethtool -S eth2 |grep rxq
rxq_0_desc_enqueue: 983
rxq
On Sun, Jun 14, 2020 at 7:20 AM Sven Auhagen wrote:
>
> The remove function does not destroy all
> BM Pools when per cpu pool is active.
>
> When reloading the mvpp2 as a module the BM Pools
> are still active in hardware and due to the bug
> have twice the size now old + new.
>
> This eventually
Four fixes related to the bnxt_en driver's resume path, AER reset, and
the timer function.
Michael Chan (3):
bnxt_en: Simplify bnxt_resume().
bnxt_en: Re-enable SRIOV during resume.
bnxt_en: Fix AER reset logic on 57500 chips.
Vasundhara Volam (1):
bnxt_en: Return from timer if interface
AER reset should follow the same steps as suspend/resume. We need to
free context memory during AER reset and allocate new context memory
during recovery by calling bnxt_hwrm_func_qcaps(). We also need
to call bnxt_reenable_sriov() to restore the VFs.
Fixes: bae361c54fb6 ("bnxt_en: Improve AER s
If VFs are enabled, we need to re-configure them during resume because
firmware has been reset while resuming. Otherwise, the VFs won't
work after resume.
Fixes: c16d4ee0e397 ("bnxt_en: Refactor logic to re-enable SRIOV after firmware
reset detected.")
Signed-off-by: Michael Chan
---
drivers/n
From: Vasundhara Volam
This will avoid many uneccessary error logs when driver or firmware is
in reset.
Fixes: 230d1f0de754 ("bnxt_en: Handle firmware reset.")
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
1 file changed, 1 i
The separate steps we do in bnxt_resume() can be done more simply by
calling bnxt_hwrm_func_qcaps(). This change will add an extra
__bnxt_hwrm_func_qcaps() call which is needed anyway on older
firmware.
Fixes: f9b69d7f6279 ("bnxt_en: Fix suspend/resume path on 57500 chips")
Signed-off-by: Michael
Am 14.06.20 um 23:08 schrieb Jan Engelhardt:
On Sunday 2020-06-14 22:19, David Howells wrote:
Alexander A. Klimov wrote:
*Is it a good idea to rename files in include/uapi/ ?*
Very likely not. If programs out there are going to be built on a
case-sensitive filesystem (which happens all
On Mon, Jun 15, 2020 at 12:35:30AM +0200, Heiner Kallweit wrote:
> Seems that disabling ETHTOOL_NETLINK for PHYLIB=m has (at least) one
> more side effect. I just saw that ifconfig doesn't report LOWER_UP
> any longer. Reason seems to be that the ioctl fallback supports
> 16 bits for the flags only
Am 14.06.20 um 22:34 schrieb Stefano Brivio:
On Sun, 14 Jun 2020 21:41:17 +0200
"Alexander A. Klimov" wrote:
Hello there!
At the moment one can't checkout a clean working directory w/o any
changed files on a case-insensitive FS as the following file names have
lower-case duplicates:
They
On Sun, Jun 14, 2020 at 09:41:17PM +0200, Alexander A. Klimov wrote:
> Hello there!
>
> At the moment one can't checkout a clean working directory w/o any changed
> files on a case-insensitive FS as the following file names have lower-case
> duplicates:
And if you use a filesystem that is limited
The 06/14/2020 01:07, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> From: Vladimir Oltean
>
> The ocelot switchdev driver also provides a set of library functions for
> the felix DSA driver, which in practice means that
On 10.06.2020 13:53, Michal Kubecek wrote:
> On Wed, Jun 10, 2020 at 12:50:30PM +0200, Heiner Kallweit wrote:
>> On 10.06.2020 11:13, Michal Kubecek wrote:
>>> Just to make sure you are hitting the same problem I'm just looking at,
>>> please check if
>>>
>>> - your kernel is built with ETHTOOL_NET
On Sun, Jun 14, 2020 at 11:08:08PM +0200, Jan Engelhardt wrote:
>
> On Sunday 2020-06-14 22:19, David Howells wrote:
> >Alexander A. Klimov wrote:
> >
> >> *Is it a good idea to rename files in include/uapi/ ?*
> >
> >Very likely not. If programs out there are going to be built on a
> >case-sens
On Sat, 13 Jun 2020 18:37:09 -0600
David Ahern wrote:
> On 6/12/20 10:49 AM, Andrea Mayer wrote:
> > @@ -37,6 +45,15 @@ struct l3mdev_ops {
> >
> > #ifdef CONFIG_NET_L3_MASTER_DEV
> >
> > +int l3mdev_table_lookup_register(enum l3mdev_type l3type,
> > +int (*fn)(st
Release the filter object in case of error.
Fixes: cb8aa9a3affb ("netfilter: ctnetlink: add kernel side filtering for dump")
Reported-by: syzbot+38b8b548a851a0179...@syzkaller.appspotmail.com
Signed-off-by: Pablo Neira Ayuso
---
net/netfilter/nf_conntrack_netlink.c | 32 +++--
From: Stefano Brivio
The lkp kernel test robot reports, with CONFIG_DEBUG_PREEMPT enabled:
[ 165.316525] BUG: using smp_processor_id() in preemptible [] code:
nft/6247
[ 165.319547] caller is nft_pipapo_insert+0x464/0x610 [nf_tables]
[ 165.321846] CPU: 1 PID: 6247 Comm: nft Not
After looking up for the flowtable hooks that need to be removed,
release the hook objects in the deletion list. The error path needs to
released these hook objects too.
Fixes: abadb2f865d7 ("netfilter: nf_tables: delete devices from flowtable")
Reported-by: syzbot+eb9d5924c51d6d59e...@syzkaller.a
From: Stefano Brivio
While checking the validity of insertion in __nft_rbtree_insert(),
we currently ignore conflicting elements and intervals only if they
are not active within the next generation.
However, if we consider expired elements and intervals as
potentially conflicting and overlapping
Hi,
The following patchset contains Netfilter fixes for net:
1) Fix bogus EEXIST on element insertions to the rbtree with timeouts,
from Stefano Brivio.
2) Preempt BUG splat in the pipapo element insertion path, also from
Stefano.
3) Release filter from the ctnetlink error path.
4) Relea
On Sat, 13 Jun 2020 18:34:25 -0600
David Ahern wrote:
> On 6/13/20 4:53 PM, Andrea Mayer wrote:
> > Hi Stephen,
> > thanks for your questions.
> >
> > On Sat, 13 Jun 2020 12:28:59 -0700
> > Stephen Hemminger wrote:
> >
> >>> +
> >>> + * Conversely, shared_table is decreased when a vrf is de-a
On Sunday 2020-06-14 22:19, David Howells wrote:
>Alexander A. Klimov wrote:
>
>> *Is it a good idea to rename files in include/uapi/ ?*
>
>Very likely not. If programs out there are going to be built on a
>case-sensitive filesystem (which happens all the time), they're going to break
>if you r
From: Vladimir Oltean
It isn't actually described clearly at all in UM10944.pdf, but on TX of
a management frame (such as PTP), this needs to happen:
- The destination MAC address (i.e. 01-80-c2-00-00-0e), along with the
desired destination port, need to be installed in one of the 4
manageme
Hello,
Op zo 14 jun. 2020 om 20:29 schreef Cong Wang :
>
> Hello,
>
> On Sun, Jun 14, 2020 at 5:39 AM Daniël Sonck wrote:
> >
> > Hello,
> >
> > I found on the archive that this bug I encountered also happened to
> > others. I too have a very similar stacktrace. The issue I'm
> > experiencing is:
On Sun, 14 Jun 2020 21:41:17 +0200
"Alexander A. Klimov" wrote:
> Hello there!
>
> At the moment one can't checkout a clean working directory w/o any
> changed files on a case-insensitive FS as the following file names have
> lower-case duplicates:
They are not duplicates: matching extensions
Alexander A. Klimov wrote:
> *Is it a good idea to rename files in include/uapi/ ?*
Very likely not. If programs out there are going to be built on a
case-sensitive filesystem (which happens all the time), they're going to break
if you rename the headers. We're kind of stuck with them.
David
Hello there!
At the moment one can't checkout a clean working directory w/o any
changed files on a case-insensitive FS as the following file names have
lower-case duplicates:
➜ linux git:(96144c58abe7) git ls-files |sort -f |uniq -id
include/uapi/linux/netfilter/xt_CONNMARK.h
include/uapi/li
Memset() on the pointer right after malloc() can cause
a null pointer dereference if it failed to allocate memory.
Fix this by replacing malloc/memset with a single calloc().
Signed-off-by: Gaurav Singh
---
samples/bpf/xdp_redirect_cpu_user.c | 11 +++
1 file changed, 3 insertions(+), 8
Hi Christophe -
> On Jun 14, 2020, at 1:07 PM, Christophe Leroy
> wrote:
>
> Even if that's only a warning, not including asm/cacheflush.h
> leads to svc_flush_bvec() being empty allthough powerpc defines
> ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE.
>
> CC net/sunrpc/svcsock.o
> net/sunrpc/svcso
Memset() on the pointer right after malloc() can cause
a null pointer dereference if it failed to allocate memory.
Fix this by replacing malloc/memset with a single calloc().
Signed-off-by: Gaurav Singh
---
samples/bpf/xdp_monitor_user.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions
Hello,
On Sun, Jun 14, 2020 at 5:39 AM Daniël Sonck wrote:
>
> Hello,
>
> I found on the archive that this bug I encountered also happened to
> others. I too have a very similar stacktrace. The issue I'm
> experiencing is:
>
> Whenever I fully boot my cluster, in some time, the host crashes with
On Sat, Jun 13, 2020 at 11:10:49PM +0300, Vladimir Oltean wrote:
> On Sat, 13 Jun 2020 at 14:32, Jonathan McDowell wrote:
> >
> > This patch improves the handling of the SGMII interface on the QCA8K
> > devices. Previously the driver did no configuration of the port, even if
> > it was selected. W
Even if that's only a warning, not including asm/cacheflush.h
leads to svc_flush_bvec() being empty allthough powerpc defines
ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE.
CC net/sunrpc/svcsock.o
net/sunrpc/svcsock.c:227:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not
defined [-Wundef]
#if AR
There is a race condition exist during termination. The path is
alx_stop and then alx_remove. An alx_schedule_link_check could be called
before alx_stop and invoke alx_link_check later. Alx_stop frees the
napis, and alx_remove cancels any pending works. If any of the work is
scheduled before termin
On 6/14/2020 9:14 AM, Heiner Kallweit wrote:
> On 10.06.2020 22:05, Andrew Lunn wrote:
>>> Not sure it makes sense to build ETHTOOL_NETLINK as a module, but at
>>> least ensuring that ETHTOOL_NETLINK is built into the kernel if PHYLIB=y
>>> or PHYLIB=m would make sense, or, better we find a way
On 10.06.2020 22:05, Andrew Lunn wrote:
>> Not sure it makes sense to build ETHTOOL_NETLINK as a module, but at
>> least ensuring that ETHTOOL_NETLINK is built into the kernel if PHYLIB=y
>> or PHYLIB=m would make sense, or, better we find a way to decouple the
>> two by using function pointers fro
On Sun, Jun 14, 2020 at 10:25:38AM +0200, Markus Elfring wrote:
> > in fec_enet_mdio_read, …
>
> I am curious under which circumstances you would like to improve
> such commit messages.
>
> * Will the tag “Fixes” become helpful?
>
> * Which source code analysis tools did trigger to send
> upda
Hello,
I found on the archive that this bug I encountered also happened to
others. I too have a very similar stacktrace. The issue I'm
experiencing is:
Whenever I fully boot my cluster, in some time, the host crashes with
the __cgroup_bpf_run_filter_skb NULL pointer dereference. This has
been spo
Hi,
Some exported functions from act_ct and nf_flow_table being used in mlx5_core.
This leads that mlx5 module always require act_ct and nf_flow_table modules.
Those small exported functions can be moved to the header files to
avoid this module dependency.
Thanks,
Roi
Alaa Hleihel (2):
net/sch
From: Alaa Hleihel
Currently, nf_flow_table_offload_add/del_cb are exported by nf_flow_table
module, therefore modules using them will have hard-dependency
on nf_flow_table and will require loading it all the time.
This can lead to an unnecessary overhead on systems that do not
use this API.
To
From: Alaa Hleihel
Currently, tcf_ct_flow_table_restore_skb is exported by act_ct
module, therefore modules using it will have hard-dependency
on act_ct and will require loading it all the time.
This can lead to an unnecessary overhead on systems that do not
use hardware connection tracking acti
> in macb_mdio_write, …
* Will a desire evolve to improve also this commit message?
* Will the tag “Fixes” become helpful?
…
> +++ b/drivers/net/ethernet/cadence/macb_main.c
…
> @@ -3840,11 +3842,14 @@ static int at91ether_open(struct net_device *dev)
>
> ret = macb_phylink_connect(lp);
Hi Saeed,
Thanks for explaining the reasoning behind the special mlx5 queue
numbering with XDP zerocopy.
We have a process using AF_XDP that also shares the network interface
with other processes on the system. ethtool rx flow classification
rules are used to route the traffic to the appropriate X
> in fec_enet_mdio_read, …
I am curious under which circumstances you would like to improve
such commit messages.
* Will the tag “Fixes” become helpful?
* Which source code analysis tools did trigger to send
update suggestions according to 16 similar issues for today?
…
> +++ b/drivers/net/e
On Sun, 14 Jun 2020 09:11:28 +0200
Sven Auhagen wrote:
> The packet header prefetch is at an offset
> now. Correct the prefetch address.
>
> Signed-off-by: Sven Auhagen
> ---
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drive
The remove function does not destroy all
BM Pools when per cpu pool is active.
When reloading the mvpp2 as a module the BM Pools
are still active in hardware and due to the bug
have twice the size now old + new.
This eventually leads to a kernel crash.
Signed-off-by: Sven Auhagen
---
drivers/n
The ethtool rx and tx queue statistics are reporting wrong values.
Fix reading out the correct ones.
Signed-off-by: Sven Auhagen
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_ma
On Sat, Jun 13, 2020 at 08:36:36AM +0200, Markus Elfring wrote:
> > … The patch fixes this issue.
>
> I propose to replace this information by the tag “Fixes”.
> Please choose another imperative wording for your change description.
>
> Regards,
> Markus
Hi,
This is the semi-friendly patch-bot o
On Sat, Jun 13, 2020 at 07:56:36AM +0200, Markus Elfring wrote:
> > … The patch fixes this issue.
>
> I suggest to replace this information by the tag “Fixes”.
> Please choose another imperative wording for your change description.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g
On Sat, Jun 13, 2020 at 08:26:12AM +0200, Markus Elfring wrote:
> > … The patch fixes this issue.
>
> I propose to replace this information by the tag “Fixes”.
> Please choose another imperative wording for your change description.
>
> Regards,
> Markus
Hi,
This is the semi-friendly patch-bot o
On Sat, Jun 13, 2020 at 08:14:13AM +0200, Markus Elfring wrote:
> > … The patch fixes the
> > order consistent with cleanup in rocker_dma_rings_fini().
>
> I suggest to choose another imperative wording for your change description.
> Will the tag “Fixes” become helpful for the commit message?
>
>
The packet header prefetch is at an offset
now. Correct the prefetch address.
Signed-off-by: Sven Auhagen
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c
b/drivers/net/ethernet/marvell/mvneta.c
i
On 14/06/2020 02:19, Gaurav Singh wrote:
The bpf_prog is being checked for !NULL after uml_kmalloc
but later its used directly for example:
bpf_prog->filter = bpf and is also later returned upon
success. Fix this, do a NULL check and return right away.
Signed-off-by: Gaurav Singh
---
arch/um/
70 matches
Mail list logo
