[v3 PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h

2020-06-11 Thread Herbert Xu
The header file linux/uio.h includes crypto/hash.h which pulls in most of the Crypto API. Since linux/uio.h is used throughout the kernel this means that every tiny bit of change to the Crypto API causes the entire kernel to get rebuilt. This patch fixes this by moving it into lib/iov_iter.c inst

Re: [PATCH] 9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work

2020-06-11 Thread Dominique Martinet
wanghai (M) wrote on Fri, Jun 12, 2020: > You are right, I got a syzkaller bug. > > "p9_read_work+0x7c3/0xd90" points to list_del(&m->rreq->req_list); > > [ 62.733598] kasan: CONFIG_KASAN_INLINE enabled > [ 62.734484] kasan: GPF could be caused by NULL-ptr deref or user memory > access > [

Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Jesper Dangaard Brouer
On Thu, 11 Jun 2020 20:36:40 -0400 Gaurav Singh wrote: > Replace malloc/memset with calloc > > Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to > xdp_rxq_info") > Signed-off-by: Gaurav Singh Above is the correct use of Fixes + Signed-off-by. Now you need to update/improve t

Re: [PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-11 Thread Miao-chen Chou
Hi Marcel, Thanks for reviewing. Please see v3 for the update. I am trying to settle down the name of Add Advertisement Pattern Monitor command with Luiz on the other thread. I will post the update here once it is sorted out. Regards, Miao On Wed, Jun 10, 2020 at 10:57 AM Marcel Holtmann wrote:

[PATCH v3 3/7] Bluetooth: Add handler of MGMT_OP_ADD_ADV_PATTERNS_MONITOR

2020-06-11 Thread Miao-chen Chou
This adds the request handler of MGMT_OP_ADD_ADV_PATTERNS_MONITOR command. Note that the controller-based monitoring is not yet in place. This tracks the content of the monitor without sending HCI traffic, so the request returns immediately. The following manual test was performed. - Issue btmgmt

[PATCH v3 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-11 Thread Miao-chen Chou
This adds support for Advertisement Monitor API. Here are the commands and events added. - Read Advertisement Monitor Feature command - Add Advertisement Pattern Monitor command - Remove Advertisement Monitor command - Advertisement Monitor Added event - Advertisement Monitor Removed event Signed-

[PATCH v3 4/7] Bluetooth: Add handler of MGMT_OP_REMOVE_ADV_MONITOR

2020-06-11 Thread Miao-chen Chou
This adds the request handler of MGMT_OP_REMOVE_ADV_MONITOR command. Note that the controller-based monitoring is not yet in place. This removes the internal monitor(s) without sending HCI traffic, so the request returns immediately. The following test was performed. - Issue btmgmt advmon-remove w

[PATCH v3 5/7] Bluetooth: Notify adv monitor added event

2020-06-11 Thread Miao-chen Chou
This notifies management sockets on MGMT_EV_ADV_MONITOR_ADDED event. The following test was performed. - Start two btmgmt consoles, issue a btmgmt advmon-add command on one console and observe a MGMT_EV_ADV_MONITOR_ADDED event on the other Signed-off-by: Miao-chen Chou --- Changes in v3: - Conv

[PATCH v3 7/7] Bluetooth: Update background scan and report device based on advertisement monitors

2020-06-11 Thread Miao-chen Chou
This calls hci_update_background_scan() when there is any update on the advertisement monitors. If there is at least one advertisement monitor, the filtering policy of scan parameters should be 0x00. This also reports device found mgmt events if there is at least one monitor. The following cases w

[PATCH v3 6/7] Bluetooth: Notify adv monitor removed event

2020-06-11 Thread Miao-chen Chou
This notifies management sockets on MGMT_EV_ADV_MONITOR_REMOVED event. The following test was performed. - Start two btmgmt consoles, issue a btmgmt advmon-remove command on one console and observe a MGMT_EV_ADV_MONITOR_REMOVED event on the other. Signed-off-by: Miao-chen Chou --- Changes in v3

[PATCH v3 2/7] Bluetooth: Add handler of MGMT_OP_READ_ADV_MONITOR_FEATURES

2020-06-11 Thread Miao-chen Chou
This adds the request handler of MGMT_OP_READ_ADV_MONITOR_FEATURES command. Since the controller-based monitoring is not yet in place, this report only the supported features but not the enabled features. The following test was performed. - Issuing btmgmt advmon-features. Signed-off-by: Miao-chen

[PATCH] mptcp: use list_first_entry_or_null

2020-06-11 Thread Geliang Tang
Use list_first_entry_or_null to simplify the code. Signed-off-by: Geliang Tang --- net/mptcp/protocol.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h index 86d265500cf6..55c65abcad64 100644 --- a/net/mptcp/protocol.h +++ b/net

[PATCH] mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX

2020-06-11 Thread Geliang Tang
Unify these two duplicate macros into 8. Signed-off-by: Geliang Tang --- net/mptcp/pm_netlink.c | 2 -- net/mptcp/protocol.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index b78edf237ba0..b694f13caba8 100644 --- a/net/m

RE: [RFC PATCH] net: usb: ax88179_178a: fix packet alignment padding

2020-06-11 Thread louis
Hi Jeremy, Thanks for the correction. Indeed, the hardware adds two bytes dummy data at beginning of Ethernet packet to make IP header aligned. The original patch made by Freddy contains the length of dummy header. Thanks for your concerning. Please let us know if you have any other question.

Re: 答复: [PATCH] can current ECMP implementation support consistent hashing for next hop?

2020-06-11 Thread David Ahern
On 6/11/20 6:32 PM, Yi Yang (杨燚)-云服务集团 wrote: > David, thank you so much for confirming it can't, I did read your cumulus > document before, resilient hashing is ok for next hop remove, but it still > has the same issue there if add new next hop. I know most of kernel code in > Cumulus Linux has

Re: [PATCH RFC v3 bpf-next 1/4] bpf: Introduce sleepable BPF programs

2020-06-11 Thread Paul E. McKenney
On Thu, Jun 11, 2020 at 07:13:01PM -0700, Alexei Starovoitov wrote: > On Thu, Jun 11, 2020 at 05:04:47PM -0700, Paul E. McKenney wrote: > > On Thu, Jun 11, 2020 at 03:29:09PM -0700, Alexei Starovoitov wrote: > > > On Thu, Jun 11, 2020 at 3:23 PM Alexei Starovoitov > > > wrote: > > > > > > > > /*

Re: [PATCH RFC v3 bpf-next 1/4] bpf: Introduce sleepable BPF programs

2020-06-11 Thread Alexei Starovoitov
On Thu, Jun 11, 2020 at 05:04:47PM -0700, Paul E. McKenney wrote: > On Thu, Jun 11, 2020 at 03:29:09PM -0700, Alexei Starovoitov wrote: > > On Thu, Jun 11, 2020 at 3:23 PM Alexei Starovoitov > > wrote: > > > > > > /* dummy _ops. The verifier will operate on target program's ops. */ > > > const s

Re: [PATCH net v2 0/4] net: ipa: endpoint configuration fixes

2020-06-11 Thread David Miller
From: Alex Elder Date: Thu, 11 Jun 2020 14:48:29 -0500 > This series fixes four bugs in the configuration of IPA endpoints. > See the description of each for more information. > > In this version I have dropped the last patch from the series, and > restored a "static" keyword that had inadverten

Re: [PATCH v2 1/2] net: phy: mscc: move shared probe code into a helper

2020-06-11 Thread David Miller
From: Heiko Stuebner Date: Tue, 9 Jun 2020 15:31:39 +0200 > From: Heiko Stuebner > > The different probe functions share a lot of code, so move the > common parts into a helper to reduce duplication. > > Signed-off-by: Heiko Stuebner > --- > changes in v2: > - new patch as suggested by Andre

Re: [PATCH net] ionic: add pcie_print_link_status

2020-06-11 Thread David Miller
From: Shannon Nelson Date: Thu, 11 Jun 2020 17:18:15 -0700 > Print the PCIe link information for our device. > > Fixes: 77f972a7077d ("ionic: remove support for mgmt device") > Signed-off-by: Shannon Nelson Applied, thank you.

Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2020-06-11

2020-06-11 Thread David Miller
From: Jeff Kirsher Date: Thu, 11 Jun 2020 15:50:56 -0700 > This series contains fixes to the iavf driver. > > Brett fixes the supported link speeds in the iavf driver, which was only > able to report speeds that the i40e driver supported and was missing the > speeds supported by the ice driver.

Re: [pull request][net 00/10] mlx5 fixes 2020-06-11

2020-06-11 Thread David Miller
From: Saeed Mahameed Date: Thu, 11 Jun 2020 15:46:58 -0700 > This series introduces some fixes to mlx5 driver. > For more information please see tag log below. Tag log is basically empty :-) > Please pull and let me know if there is any problem. Pulled. > For -stable v5.2 > ('net/mlx5: drai

Re: [PATCH net] rxrpc: Fix race between incoming ACK parser and retransmitter

2020-06-11 Thread David Miller
From: David Howells Date: Thu, 11 Jun 2020 21:57:00 +0100 > There's a race between the retransmission code and the received ACK parser. > The problem is that the retransmission loop has to drop the lock under > which it is iterating through the transmission buffer in order to transmit > a packet,

[PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Gaurav Singh
Replace malloc/memset with calloc Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info") Signed-off-by: Gaurav Singh --- samples/bpf/xdp_rxq_info_user.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/samples/bpf/xdp_rxq_info_user.c

答复: [PATCH] can current ECMP implementation support consistent hashing for next hop?

2020-06-11 Thread 杨燚
David, thank you so much for confirming it can't, I did read your cumulus document before, resilient hashing is ok for next hop remove, but it still has the same issue there if add new next hop. I know most of kernel code in Cumulus Linux has been in upstream kernel, I'm wondering why you didn't

[PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Gaurav Singh
Replace malloc/memset with calloc Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info") Signed-off-by: Gaurav Singh --- samples/bpf/xdp_rxq_info_user.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/samples/bpf/xdp_rxq_info_user.c

[PATCH net] ionic: add pcie_print_link_status

2020-06-11 Thread Shannon Nelson
Print the PCIe link information for our device. Fixes: 77f972a7077d ("ionic: remove support for mgmt device") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pc

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread jim . cromie
calling out some thinkos On Thu, Jun 11, 2020 at 3:19 PM wrote: > > heres what I have in mind. whats described here is working. > I'll send it out soon > > commit 20298ec88cc2ed64269c8be7b287a24e60a5347e > Author: Jim Cromie > Date: Wed Jun 10 12:55:08 2020 -0600 > > dyndbg: WIP towards m

Re: [PATCH RFC v3 bpf-next 1/4] bpf: Introduce sleepable BPF programs

2020-06-11 Thread Paul E. McKenney
On Thu, Jun 11, 2020 at 03:29:09PM -0700, Alexei Starovoitov wrote: > On Thu, Jun 11, 2020 at 3:23 PM Alexei Starovoitov > wrote: > > > > /* dummy _ops. The verifier will operate on target program's ops. */ > > const struct bpf_verifier_ops bpf_extension_verifier_ops = { > > @@ -205,14 +206,12 @

RE: [RFC 1/8] docs: networking: reorganize driver documentation again

2020-06-11 Thread Kirsher, Jeffrey T
> -Original Message- > From: Jakub Kicinski > Sent: Thursday, June 11, 2020 16:09 > To: Stephen Hemminger > Cc: Kirsher, Jeffrey T ; da...@davemloft.net; > netdev@vger.kernel.org; linux-...@vger.kernel.org; klass...@kernel.org; > akiy...@amazon.com; irussk...@marvell.com; ioana.cior...@nx

Re: [RFC 1/8] docs: networking: reorganize driver documentation again

2020-06-11 Thread Jakub Kicinski
On Thu, 11 Jun 2020 15:18:42 -0700 Stephen Hemminger wrote: > > > Organize driver documentation by device type. Most documents > > > have fairly verbose yet uninformative names, so let users > > > first select a well defined device type, and then search for > > > a particular driver. > > > > > > W

[net 2/4] iavf: use appropriate enum for comparison

2020-06-11 Thread Jeff Kirsher
From: Aleksandr Loktionov adapter->link_speed has type enum virtchnl_link_speed but our comparisons are against enum iavf_aq_link_speed. Though they are, currently, the same values, change the comparison to the matching enum virtchnl_link_speed since that may not always be the case. Signed-off-b

[net 3/4] iavf: Fix reporting 2.5 Gb and 5Gb speeds

2020-06-11 Thread Jeff Kirsher
From: Brett Creeley Commit 4ae4916b5643 ("i40e: fix 'Unknown bps' in dmesg for 2.5Gb/5Gb speeds") added the ability for the PF to report 2.5 and 5Gb speeds, however, the iavf driver does not recognize those speeds as the values were not added there. Add the proper enums and values so that iavf ca

[net 4/4] iavf: increase reset complete wait time

2020-06-11 Thread Jeff Kirsher
From: Paul Greenwalt With an increased number of VFs, it's possible to encounter the following issue during reset. iavf b8d4:00:02.0: Hardware reset detected iavf b8d4:00:02.0: Reset never finished (0) iavf b8d4:00:02.0: Reset task did not complete, VF disabled Increase the reset co

[net 1/4] iavf: fix speed reporting over virtchnl

2020-06-11 Thread Jeff Kirsher
From: Brett Creeley Link speeds are communicated over virtchnl using an enum virtchnl_link_speed. Currently, the highest link speed is 40Gbps which leaves us unable to reflect some speeds that an ice VF is capable of. This causes link speed to be misreported on the iavf driver. Allow for communi

[net 0/4][pull request] Intel Wired LAN Driver Updates 2020-06-11

2020-06-11 Thread Jeff Kirsher
This series contains fixes to the iavf driver. Brett fixes the supported link speeds in the iavf driver, which was only able to report speeds that the i40e driver supported and was missing the speeds supported by the ice driver. In addition, fix how 2.5 and 5.0 GbE speeds are reported. Alek fixe

[net 09/10] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-11 Thread Saeed Mahameed
From: Leon Romanovsky Clang warns: drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable 'err' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!priv->dbg_root) { ^~~ drivers/net/ethernet/mellanox/mlx5/core/m

[net 10/10] net/mlx5: E-Switch, Fix some error pointer dereferences

2020-06-11 Thread Saeed Mahameed
From: Dan Carpenter We can't leave "counter" set to an error pointer. Otherwise either it will lead to an error pointer dereference later in the function or it leads to an error pointer dereference when we call mlx5_fc_destroy(). Fixes: 07bab9502641d ("net/mlx5: E-Switch, Refactor eswitch ingre

[net 02/10] net/mlx5: Fix fatal error handling during device load

2020-06-11 Thread Saeed Mahameed
From: Shay Drory Currently, in case of fatal error during mlx5_load_one(), we cannot enter error state until mlx5_load_one() is finished, what can take several minutes until commands will get timeouts, because these commands can't be processed due to the fatal error. Fix it by setting dev->state

[net 06/10] net/mlx5: Disable reload while removing the device

2020-06-11 Thread Saeed Mahameed
From: Parav Pandit While unregistration is in progress, user might be reloading the interface. This can race with unregistration in below flow which uses the resources which are getting disabled by reload flow. Hence, disable the devlink reloading first when removing the device. CPU0

[pull request][net 00/10] mlx5 fixes 2020-06-11

2020-06-11 Thread Saeed Mahameed
Hi Dave, This series introduces some fixes to mlx5 driver. For more information please see tag log below. Please pull and let me know if there is any problem. For -stable v5.2 ('net/mlx5: drain health workqueue in case of driver load error') For -stable v5.3 ('net/mlx5e: Fix repeated XSK us

[net 03/10] net/mlx5: DR, Fix freeing in dr_create_rc_qp()

2020-06-11 Thread Saeed Mahameed
From: Denis Efremov Variable "in" in dr_create_rc_qp() is allocated with kvzalloc() and should be freed with kvfree(). Fixes: 297cccebdc5a ("net/mlx5: DR, Expose an internal API to issue RDMA operations") Signed-off-by: Denis Efremov Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mel

[net 01/10] net/mlx5: drain health workqueue in case of driver load error

2020-06-11 Thread Saeed Mahameed
From: Shay Drory In case there is a work in the health WQ when we teardown the driver, in driver load error flow, the health work will try to read dev->iseg, which was already unmap in mlx5_pci_close(). Fix it by draining the health workqueue first thing in mlx5_pci_close(). Trace of the error:

[net 08/10] net/mlx5e: CT: Fix ipv6 nat header rewrite actions

2020-06-11 Thread Saeed Mahameed
From: Oz Shlomo Set the ipv6 word fields according to the hardware definitions. Fixes: ac991b48d43c ("net/mlx5e: CT: Offload established flows") Signed-off-by: Oz Shlomo Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 16 ---

[net 04/10] net/mlx5e: Fix repeated XSK usage on one channel

2020-06-11 Thread Saeed Mahameed
From: Maxim Mikityanskiy After an XSK is closed, the relevant structures in the channel are not zeroed. If an XSK is opened the second time on the same channel without recreating channels, the stray values in the structures will lead to incorrect operation of queues, which causes CQE errors, and

[net 07/10] net/mlx5: Fix devlink objects and devlink device unregister sequence

2020-06-11 Thread Saeed Mahameed
From: Parav Pandit Current below problems exists. 1. devlink device is registered by mlx5_load_one(). But it is not unregistered by mlx5_unload_one(). This is incorrect. 2. Above issue leads to, When mlx5 PCI device is removed, currently devlink device is unregistered before devlink ports are u

[net 05/10] net/mlx5e: Fix ethtool hfunc configuration change

2020-06-11 Thread Saeed Mahameed
From: Aya Levin Changing RX hash function requires rearranging of RQT internal indexes, the user isn't exposed to such changes and these changes do not affect the user configured indirection table. Rebuild RQ table on hfunc change. Fixes: bdfc028de1b3 ("net/mlx5e: Fix ethtool RX hash func config

Re: [RFC] .BTF section data alignment issue on s390

2020-06-11 Thread Ilya Leoshkevich
On Thu, 2020-06-11 at 22:50 +0200, Jiri Olsa wrote: > hi, > we're hitting a problem on s390 with BTF data alignment. > > When running simple test, we're getting this message from > verifier and console: > > bpf_common.c:91: BROK: Failed verification: in-kernel BTF is > malformed > [ 41.5455

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Joe Perches
On Thu, 2020-06-11 at 17:59 -0400, Jason Baron wrote: > > On 6/11/20 5:19 PM, jim.cro...@gmail.com wrote: > > trimmed.. > > > > > > > Currently I think there not enough "levels" to map something like > > > > > drm.debug to the new dyn dbg feature. I don't think it is intrinsic > > > > > but I cou

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Jason Baron
On 6/11/20 5:19 PM, jim.cro...@gmail.com wrote: > trimmed.. > Currently I think there not enough "levels" to map something like drm.debug to the new dyn dbg feature. I don't think it is intrinsic but I couldn't find the bit of the code where the 5-bit level in struct _ddebug

Re: [PATCH RFC v3 bpf-next 1/4] bpf: Introduce sleepable BPF programs

2020-06-11 Thread Alexei Starovoitov
On Thu, Jun 11, 2020 at 3:23 PM Alexei Starovoitov wrote: > > /* dummy _ops. The verifier will operate on target program's ops. */ > const struct bpf_verifier_ops bpf_extension_verifier_ops = { > @@ -205,14 +206,12 @@ static int bpf_trampoline_update(struct bpf_trampoline > *tr) > t

[PATCH RFC v3 bpf-next 0/4] bpf: Introduce minimal support for sleepable progs

2020-06-11 Thread Alexei Starovoitov
From: Alexei Starovoitov v2->v3: - switched to rcu_trace - added bpf_copy_from_user Here is 'perf report' differences: sleepable with SRCU: 3.86% bench [k] __srcu_read_unlock 3.22% bench [k] __srcu_read_lock 0.92% bench [k] bpf_prog_740d4210cdcd99a3_bench_trigger_fentry_s

[PATCH RFC v3 bpf-next 3/4] libbpf: support sleepable progs

2020-06-11 Thread Alexei Starovoitov
From: Alexei Starovoitov Pass request to load program as sleepable via ".s" suffix in the section name. If it happens in the future that all map types and helpers are allowed with BPF_F_SLEEPABLE flag "fmod_ret/" and "lsm/" can be aliased to "fmod_ret.s/" and "lsm.s/" to make all lsm and fmod_ret

[PATCH RFC v3 bpf-next 1/4] bpf: Introduce sleepable BPF programs

2020-06-11 Thread Alexei Starovoitov
From: Alexei Starovoitov Introduce sleepable BPF programs that can request such property for themselves via BPF_F_SLEEPABLE flag at program load time. In such case they will be able to use helpers like bpf_copy_from_user() that might sleep. At present only fentry/fexit/fmod_ret and lsm programs c

[PATCH RFC v3 bpf-next 2/4] bpf: Add bpf_copy_from_user() helper.

2020-06-11 Thread Alexei Starovoitov
From: Alexei Starovoitov Sleepable BPF programs can now use copy_from_user() to access user memory. Signed-off-by: Alexei Starovoitov --- include/linux/bpf.h| 1 + include/uapi/linux/bpf.h | 11 ++- kernel/bpf/helpers.c | 22 ++ kernel/t

[PATCH RFC v3 bpf-next 4/4] selftests/bpf: basic sleepable tests

2020-06-11 Thread Alexei Starovoitov
From: Alexei Starovoitov Modify few tests to sanity test sleepable bpf functionality. Signed-off-by: Alexei Starovoitov Acked-by: KP Singh --- tools/testing/selftests/bpf/bench.c | 2 ++ .../selftests/bpf/benchs/bench_trigger.c| 17 + tools/testing/selftes

Re: [RFC 1/8] docs: networking: reorganize driver documentation again

2020-06-11 Thread Stephen Hemminger
On Thu, 11 Jun 2020 21:17:49 + "Kirsher, Jeffrey T" wrote: > > -Original Message- > > From: Jakub Kicinski > > Sent: Thursday, June 11, 2020 10:30 > > To: da...@davemloft.net > > Cc: netdev@vger.kernel.org; linux-...@vger.kernel.org; Jakub Kicinski > > ; klass...@kernel.org; akiy...@

Re: [PATCH] net/mlx5: Use kfree(ft->g) in arfs_create_groups()

2020-06-11 Thread Saeed Mahameed
On Fri, 2020-06-05 at 12:57 -0700, Eric Dumazet wrote: > > On 6/5/20 12:22 PM, Denis Efremov wrote: > > Use kfree() instead of kvfree() on ft->g in arfs_create_groups() > > because > > the memory is allocated with kcalloc(). > > > > Signed-off-by: Denis Efremov > > --- > > drivers/net/ethernet/

Re: [PATCH] net/mlx5: E-Switch, Fix some error pointer dereferences

2020-06-11 Thread Saeed Mahameed
On Mon, 2020-06-08 at 16:31 +0300, Dan Carpenter wrote: > On Sun, Jun 07, 2020 at 09:25:55AM +0300, Leon Romanovsky wrote: > > On Fri, Jun 05, 2020 at 01:52:03PM +0300, Dan Carpenter wrote: > > > On Thu, Jun 04, 2020 at 01:32:55PM +0300, Leon Romanovsky wrote: > > > > + netdev > > > > > > > > > >

Re: [PATCH iproute2] ip address: Fix loop initial declarations are only allowed in C99

2020-06-11 Thread Stephen Hemminger
On Thu, 11 Jun 2020 20:35:43 +0300 Roi Dayan wrote: > On some distros, i.e. rhel 7.6, compilation fails with the following: > > ipaddress.c: In function ‘lookup_flag_data_by_name’: > ipaddress.c:1260:2: error: ‘for’ loop initial declarations are only allowed > in C99 mode > for (int i = 0; i

Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-11 Thread Saeed Mahameed
On Mon, 2020-06-08 at 14:22 -0700, Nathan Chancellor wrote: > On Thu, Jun 04, 2020 at 04:44:00AM +, Saeed Mahameed wrote: > > On Wed, 2020-06-03 at 11:34 -0700, Nathan Chancellor wrote: > > > On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor > > > wrote: > > > > On Tue, Jun 02, 2020 a

Re: [PATCH net] ionic: remove support for mgmt device

2020-06-11 Thread Shannon Nelson
On 6/11/20 1:33 PM, Michal Schmidt wrote: Dne 11. 06. 20 v 6:07 Shannon Nelson napsal(a): We no longer support the mgmt device in the ionic driver, so remove the device id and related code. ...> @@ -252,8 +248,6 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)  

RE: [RFC 1/8] docs: networking: reorganize driver documentation again

2020-06-11 Thread Kirsher, Jeffrey T
> -Original Message- > From: Jakub Kicinski > Sent: Thursday, June 11, 2020 10:30 > To: da...@davemloft.net > Cc: netdev@vger.kernel.org; linux-...@vger.kernel.org; Jakub Kicinski > ; klass...@kernel.org; akiy...@amazon.com; > irussk...@marvell.com; ioana.cior...@nxp.com; k...@microsoft.co

Re: [PATCH net-next v2 3/4] mlx5: become aware of when running as a bonding slave

2020-06-11 Thread Saeed Mahameed
On Wed, 2020-06-10 at 14:59 -0400, Jarod Wilson wrote: > I've been unable to get my hands on suitable supported hardware to > date, > but I believe this ought to be all that is needed to enable the mlx5 > driver to also work with bonding active-backup crypto offload > passthru. > > CC: Boris Pisme

RE: liquidio vs smp_call_function_single_async()

2020-06-11 Thread Derek Chickles
> From: Peter Zijlstra > Sent: Monday, June 8, 2020 6:05 AM > To: Derek Chickles ; Satananda Burla > ; Felix Manlunas > Cc: frede...@kernel.org; linux-ker...@vger.kernel.org; > da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org > Subject: liquidio vs smp_call_function_single_async() >

Re: [RFC 1/8] docs: networking: reorganize driver documentation again

2020-06-11 Thread Jakub Kicinski
On Thu, 11 Jun 2020 21:17:49 + Kirsher, Jeffrey T wrote: > > @@ -8626,18 +8626,18 @@ W: http://e1000.sourceforge.net/ > > Q: http://patchwork.ozlabs.org/project/intel-wired-lan/list/ > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-queue.git > > T: git > > git://git.ke

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread jim . cromie
trimmed.. > > > Currently I think there not enough "levels" to map something like > > > drm.debug to the new dyn dbg feature. I don't think it is intrinsic > > > but I couldn't find the bit of the code where the 5-bit level in struct > > > _ddebug is converted from a mask to a bit number and vice-

Re: [PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling

2020-06-11 Thread Bartosz Golaszewski
czw., 11 cze 2020 o 21:51 David Miller napisał(a): > > From: Bartosz Golaszewski > Date: Thu, 11 Jun 2020 16:01:39 +0200 > > > Unfortunately after thorough testing of current mainline, we noticed the > > driver has become unstable under heavy load. While this is hard to > > reproduce, it's quite

[PATCH net] rxrpc: Fix race between incoming ACK parser and retransmitter

2020-06-11 Thread David Howells
There's a race between the retransmission code and the received ACK parser. The problem is that the retransmission loop has to drop the lock under which it is iterating through the transmission buffer in order to transmit a packet, but whilst the lock is dropped, the ACK parser can crank the Tx win

Re: [PATCH net 2/2] net/sched: act_gate: fix configuration of the periodic timer

2020-06-11 Thread Cong Wang
On Wed, Jun 10, 2020 at 2:43 PM Davide Caratti wrote: > +static void gate_setup_timer(struct tcf_gate *gact, u64 basetime, > +enum tk_offsets tko, s32 clockid, > +bool do_init) > +{ > + bool timer_change = basetime != gact->param.tcfg_b

[RFC] .BTF section data alignment issue on s390

2020-06-11 Thread Jiri Olsa
hi, we're hitting a problem on s390 with BTF data alignment. When running simple test, we're getting this message from verifier and console: bpf_common.c:91: BROK: Failed verification: in-kernel BTF is malformed [ 41.545572] BPF:Total section length too long AFAICS it happens when .BTF se

Re: [PATCH net] ionic: remove support for mgmt device

2020-06-11 Thread Michal Schmidt
Dne 11. 06. 20 v 6:07 Shannon Nelson napsal(a): We no longer support the mgmt device in the ionic driver, so remove the device id and related code. ...> @@ -252,8 +248,6 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) } pci_set_master(pdev); -

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-11 Thread Marc Kleine-Budde
On 6/11/20 6:26 PM, Marc Kleine-Budde wrote: > I initially started looking at Martin's driver and it was not using several > modern CAN driver infrastructures. I then posted some cleanup patches but > Martin > was not working on the driver any more. Then I decided to rewrite the driver, > that is

Re: [PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling

2020-06-11 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 11 Jun 2020 16:01:39 +0200 > Unfortunately after thorough testing of current mainline, we noticed the > driver has become unstable under heavy load. While this is hard to > reproduce, it's quite consistent in the driver's current form. Maybe you should work t

[PATCH net v2 1/4] net: ipa: program metadata mask differently

2020-06-11 Thread Alex Elder
The way the mask value is programmed for QMAP RX endpoints was based on some wrong assumptions about the way metadata containing the QMAP mux_id value is formatted. The metadata value supplied by the modem is *not* in QMAP format, and in fact contains the mux_id we want in its (big endian) low-ord

[PATCH net v2 3/4] net: ipa: program upper nibbles of sequencer type

2020-06-11 Thread Alex Elder
The upper two nibbles of the sequencer type were not used for SDM845, and were assumed to be 0. But for SC7180 they are used, and so they must be programmed by ipa_endpoint_init_seq(). Fix this bug. IPA_SEQ_PKT_PROCESS_NO_DEC_NO_UCP_DMAP doesn't have a descriptive comment, so add one. Signed-of

[PATCH net v2 4/4] net: ipa: header pad field only valid for AP->modem endpoint

2020-06-11 Thread Alex Elder
Only QMAP endpoints should be configured to find a pad size field within packet headers. They are found in the first byte of the QMAP header (and the hardware fills only the 6 bits in that byte that constitute the pad_len field). The RMNet driver assumes the pad_len field is valid for received pa

Re: [net] tipc: fix kernel WARNING in tipc_msg_append()

2020-06-11 Thread David Miller
From: Tuong Lien Date: Thu, 11 Jun 2020 17:07:35 +0700 > syzbot found the following issue: > > WARNING: CPU: 0 PID: 6808 at include/linux/thread_info.h:150 check_copy_size > include/linux/thread_info.h:150 [inline] > WARNING: CPU: 0 PID: 6808 at include/linux/thread_info.h:150 copy_from_iter >

Re: [net] tipc: fix NULL pointer dereference in tipc_disc_rcv()

2020-06-11 Thread David Miller
From: Tuong Lien Date: Thu, 11 Jun 2020 17:08:08 +0700 > When a bearer is enabled, we create a 'tipc_discoverer' object to store > the bearer related data along with a timer and a preformatted discovery > message buffer for later probing... However, this is only carried after > the bearer was set

[PATCH net v2 0/4] net: ipa: endpoint configuration fixes

2020-06-11 Thread Alex Elder
This series fixes four bugs in the configuration of IPA endpoints. See the description of each for more information. In this version I have dropped the last patch from the series, and restored a "static" keyword that had inadvertently gotten removed. -Alex

[PATCH net v2 2/4] net: ipa: fix modem LAN RX endpoint id

2020-06-11 Thread Alex Elder
The endpoint id assigned to the modem LAN RX endpoint for the SC7180 SoC is incorrect. The erroneous value might have been copied from SDM845 and never updated. The correct endpoint id to use for this SoC is 11. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_data-sc7180.c | 2 +- 1 file cha

Re: [PATCH] xdp: fix xsk_generic_xmit errno

2020-06-11 Thread David Miller
From: Li RongQing Date: Thu, 11 Jun 2020 13:11:06 +0800 > @@ -353,7 +353,6 @@ static int xsk_generic_xmit(struct sock *sk) > len = desc.len; > skb = sock_alloc_send_skb(sk, len, 1, &err); > if (unlikely(!skb)) { > - err = -EAGAIN; >

Re: [PATCH net] ionic: remove support for mgmt device

2020-06-11 Thread David Miller
From: Shannon Nelson Date: Wed, 10 Jun 2020 21:07:39 -0700 > We no longer support the mgmt device in the ionic driver, > so remove the device id and related code. > > Fixes: b3f064e9746d ("ionic: add support for device id 0x1004") > Signed-off-by: Shannon Nelson Applied, thank you.

Re: [PATCH] drivers: dpaa2: Use devm_kcalloc() in setup_dpni()

2020-06-11 Thread David Miller
From: Xu Wang Date: Thu, 11 Jun 2020 02:45:20 + > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". > > Signed-off-by: Xu Wang Applied, thanks.

Re: [PATCH net 1/5] net: ipa: program metadata mask differently

2020-06-11 Thread Alex Elder
-Alex > [auto build test WARNING on net/master] > > url: > https://github.com/0day-ci/linux/commits/Alex-Elder/net-ipa-endpoint-configuration-fixes/20200611-035600 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git > 89dc68533b190117e1a2fb4298d88b96

Re: [PATCH v2 2/2] perf tools: Improve exception handling in two functions of perf events parser

2020-06-11 Thread Markus Elfring
> Fix potential memory leak. Function new_term may return error, so > it is need to free memory when the return value is negative. How do you think about a wording variant like the following? Add jump targets so that a configuration object and a duplicated string are released after a call o

Re: [PATCH net-next 1/2] ethtool: Add support for 100Gbps per lane link modes

2020-06-11 Thread Meir Lichtinger
On 11-Jun-20 16:54, Andrew Lunn wrote: How do you know you have connected a 40baseLR4 to a 40baseER4 with a 40Km and it is not expected to work, when looking at ethtool? I assume the EEPROM contents tell you if the module is LR4, ER4, or FR4? Andrew Correct. Hi Meir Do you also

Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser

2020-06-11 Thread Markus Elfring
> Fix memory leak of in function parse_events_term__sym_hw() > and parse_events_term__clone() when error occur. How do you think about a wording variant like the following? Release a configuration object after a string duplication failed. Regards, Markus

Re: [PATCH] ipvs: avoid drop first packet to reuse conntrack

2020-06-11 Thread Julian Anastasov
Hello, On Thu, 11 Jun 2020, YangYuxi wrote: > Since commit f719e3754ee ("ipvs: drop first packet > to redirect conntrack"), when a new TCP connection > meet the conditions that need reschedule, the first > syn packet is dropped, this cause one second latency > for the new connection, mor

Re: [PATCH] can current ECMP implementation support consistent hashing for next hop?

2020-06-11 Thread David Ahern
On 6/11/20 8:56 AM, Yi Yang (杨燚)-云服务集团 wrote: > Hi, folks > > We need to use Linux ECMP to do active-active load balancer, but consistent > hash is necessary because load balance node may be added or removed > dynamically, so number of hash bucket is changeable, but we have to > distribute flow

PROBLEM: IPv4 route exception patch breaks BIRD2

2020-06-11 Thread Joseph Marsden
Hi all, While upgrading my kernel from 5.2 to 5.4.43, I noticed a very sharp increase in CPU usage - coming from BIRD, the routing daemon on my system. I ran a Netlink capture and saw that BIRD was attempting to insert routes twice into the kernel routing table. This was causing routes to be re-in

Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Jesper Dangaard Brouer
On Thu, 11 Jun 2020 11:02:21 -0400 Gaurav Singh wrote: > Replace malloc/memset with calloc Please also mention/describe that this also solves the bug you found. As this fix a potential bug, it will be appropriate to add a "Fixes:" line, just before "Signed-off-by" (meaning no newline between t

Re: [PATCH 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-11 Thread Jonathan McDowell
On Wed, Jun 10, 2020 at 08:31:11PM -0700, Florian Fainelli wrote: > On 6/10/2020 12:15 PM, Jonathan McDowell wrote: > > This patch improves the handling of the SGMII interface on the QCA8K > > devices. Previously the driver did no configuration of the port, even if > > it was selected. We now confi

[PATCH iproute2] ip address: Fix loop initial declarations are only allowed in C99

2020-06-11 Thread Roi Dayan
On some distros, i.e. rhel 7.6, compilation fails with the following: ipaddress.c: In function ‘lookup_flag_data_by_name’: ipaddress.c:1260:2: error: ‘for’ loop initial declarations are only allowed in C99 mode for (int i = 0; i < ARRAY_SIZE(ifa_flag_data); ++i) { ^ ipaddress.c:1260:2: note:

[RFC 3/8] docs: networking: move baycom to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move baycom to hamradio. Signed-off-by: Jakub Kicinski -- CC: t.sai...@alumni.ethz.ch --- .../networking/{ => device_drivers/hamradio}/baycom.rst | 0 .../networking/device_drivers/hamradio/index.rst | 1 + Documentation/networking/index.rst| 1 - drivers/net/h

[RFC 2/8] docs: networking: move z8530 to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move z8530 docs to hamradio and wan subdirectories. Signed-off-by: Jakub Kicinski -- CC: jreu...@yaina.de CC: linux-h...@vger.kernel.org --- .../device_drivers/hamradio/index.rst | 18 ++ .../{ => device_drivers/hamradio}/z8530drv.rst | 0 .../networking/device_drivers/

[RFC 0/8] net: organize driver docs by device type

2020-06-11 Thread Jakub Kicinski
Hi! This series finishes off what I started in commit b255e500c8dc ("net: documentation: build a directory structure for drivers"). The objective is to de-clutter our documentation folder so folks have a chance of finding relevant info. I _think_ I got all the driver docs from the main documentat

[RFC 6/8] docs: networking: move AppleTalk / LocalTalk drivers to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move docs for cops and ltpc under device_drivers/appletalk. Signed-off-by: Jakub Kicinski --- .../{ => device_drivers/appletalk}/cops.rst | 0 .../device_drivers/appletalk/index.rst| 19 +++ .../{ => device_drivers/appletalk}/ltpc.rst | 0 .../networking/device_driv

[RFC 7/8] docs: networking: move ATM drivers to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move docs for cxacru, fore200e and iphase under device_drivers/atm. Signed-off-by: Jakub Kicinski -- CC: accessrunner-gene...@lists.sourceforge.net CC: 3ch...@gmail.com CC: linux-atm-gene...@lists.sourceforge.net --- .../{ => device_drivers/atm}/cxacru-cf.py | 0 .../{ => device_drivers/atm

[RFC 5/8] docs: networking: move remaining Ethernet driver docs to the hw section

2020-06-11 Thread Jakub Kicinski
Move docs for hinic and altera_tse under device_drivers/ethernet. Signed-off-by: Jakub Kicinski -- CC: luob...@huawei.com --- .../{ => device_drivers/ethernet/altera}/altera_tse.rst | 0 .../networking/{ => device_drivers/ethernet/huawei}/hinic.rst | 0 Documentation/networking/device_

  1   2   >