Re: [PATCH RFC v5 13/13] vhost: drop head based APIs

2020-06-07 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 11:57:48AM +0800, Jason Wang wrote: > > On 2020/6/7 下午10:11, Michael S. Tsirkin wrote: > > Everyone's using buf APIs, no need for head based ones anymore. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > drivers/vhost/vhost.c | 36 ---

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-07 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 11:32:31AM +0800, Jason Wang wrote: > > On 2020/6/7 下午9:51, Michael S. Tsirkin wrote: > > On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: > > > On 2020/6/2 下午3:08, Jason Wang wrote: > > > > > > +static const struct pci_device_id vp_vdpa_id_table[] = { > > > > >

Re: [PATCH net v2] esp: select CRYPTO_SEQIV when useful

2020-06-07 Thread Herbert Xu
On Fri, Jun 05, 2020 at 11:00:23AM -0700, Eric Biggers wrote: > > Oops, this doesn't actually work: > > scripts/kconfig/conf --olddefconfig Kconfig > crypto/Kconfig:1799:error: recursive dependency detected! > crypto/Kconfig:1799: symbol CRYPTO_DRBG_MENU is selected by > CRYPTO_RNG_DEFAULT > cr

Re: [PATCH] Fix build failure of OCFS2 when TCP/IP is disabled

2020-06-07 Thread Christoph Hellwig
On Sat, Jun 06, 2020 at 02:08:26PM -0500, Tom Seewald wrote: > After commit 12abc5ee7873 ("tcp: add tcp_sock_set_nodelay") and > commit c488aeadcbd0 ("tcp: add tcp_sock_set_user_timeout"), building the > kernel with OCFS2_FS=y but without INET=y causes it to fail with: > > ld: fs/ocfs2/cluster/tcp

Re: [PATCH RFC 03/13] vhost: batching fetches

2020-06-07 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 11:35:40AM +0800, Jason Wang wrote: > > On 2020/6/7 下午9:57, Michael S. Tsirkin wrote: > > On Fri, Jun 05, 2020 at 11:40:17AM +0800, Jason Wang wrote: > > > On 2020/6/4 下午4:59, Michael S. Tsirkin wrote: > > > > On Wed, Jun 03, 2020 at 03:27:39PM +0800, Jason Wang wrote: > >

Re: [PATCH RFC v5 13/13] vhost: drop head based APIs

2020-06-07 Thread Jason Wang
On 2020/6/7 下午10:11, Michael S. Tsirkin wrote: Everyone's using buf APIs, no need for head based ones anymore. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 36 drivers/vhost/vhost.h | 12 2 files changed, 8 insertions(+), 4

Re: [PATCH RFC 03/13] vhost: batching fetches

2020-06-07 Thread Jason Wang
On 2020/6/7 下午9:57, Michael S. Tsirkin wrote: On Fri, Jun 05, 2020 at 11:40:17AM +0800, Jason Wang wrote: On 2020/6/4 下午4:59, Michael S. Tsirkin wrote: On Wed, Jun 03, 2020 at 03:27:39PM +0800, Jason Wang wrote: On 2020/6/2 下午9:06, Michael S. Tsirkin wrote: With this patch applied, new and

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-07 Thread Jason Wang
On 2020/6/7 下午9:51, Michael S. Tsirkin wrote: On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: On 2020/6/2 下午3:08, Jason Wang wrote: +static const struct pci_device_id vp_vdpa_id_table[] = { +    { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, +    { 0 } +}; This looks

[patch 1/1] net-zerocopy: use vm_insert_pages() for tcp rcv zerocopy

2020-06-07 Thread akpm
From: Arjun Roy Subject: net-zerocopy: use vm_insert_pages() for tcp rcv zerocopy Use vm_insert_pages() for tcp receive zerocopy. Spin lock cycles (as reported by perf) drop from a couple of percentage points to a fraction of a percent. This results in a roughly 6% increase in efficiency, measu

Re: [PATCH] Fix build failure of OCFS2 when TCP/IP is disabled

2020-06-07 Thread Joseph Qi
On 2020/6/7 03:08, Tom Seewald wrote: > After commit 12abc5ee7873 ("tcp: add tcp_sock_set_nodelay") and > commit c488aeadcbd0 ("tcp: add tcp_sock_set_user_timeout"), building the > kernel with OCFS2_FS=y but without INET=y causes it to fail with: > > ld: fs/ocfs2/cluster/tcp.o: in function `o2n

[vhost:vhost 18/52] drivers/virtio/virtio_mem.c:1391:5: warning: Variable 'rc' is reassigned a value before the old one has been used.

2020-06-07 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: f3861bc96a7e130943e1975e571ae62c0319b064 commit: 5f1f79bbc9e26fa9412fa9522f957bb8f030c442 [18/52] virtio-mem: Paravirtualized memory hotplug compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add

[PATCH 1/1] cxgb4: fix cxgb4_uld_in_use() not used error

2020-06-07 Thread Heinrich Schuchardt
When building without CONFIG_CHELSIO_TLS_DEVICE a build error occurs: drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: error: ‘cxgb4_uld_in_use’ defined but not used [-Werror=unused-function] 666 | static bool cxgb4_uld_in_use(struct adapter *adap) | ^~~~ Gua

[PATCH v2 10/18] xfrm: policy: Use sequence counters with associated lock

2020-06-07 Thread Ahmed S. Darwish
A sequence counter write side critical section must be protected by some form of locking to serialize writers. If the serialization primitive is not disabling preemption implicitly, preemption has to be explicitly disabled before entering the sequence counter write side critical section. A plain s

[PATCH v2 09/18] netfilter: nft_set_rbtree: Use sequence counter with associated rwlock

2020-06-07 Thread Ahmed S. Darwish
A sequence counter write side critical section must be protected by some form of locking to serialize writers. A plain seqcount_t does not contain the information of which lock must be held when entering a write side critical section. Use the new seqcount_rwlock_t data type, which allows to associ

[PATCH v2 08/18] netfilter: conntrack: Use sequence counter with associated spinlock

2020-06-07 Thread Ahmed S. Darwish
A sequence counter write side critical section must be protected by some form of locking to serialize writers. A plain seqcount_t does not contain the information of which lock must be held when entering a write side critical section. Use the new seqcount_spinlock_t data type, which allows to asso

[PATCH v2 00/18] seqlock: Extend seqcount API with associated locks

2020-06-07 Thread Ahmed S. Darwish
Hi, This is v2 of the seqlock patch series: [PATCH v1 00/25] seqlock: Extend seqcount API with associated locks https://lore.kernel.org/lkml/20200519214547.352050-1-a.darw...@linutronix.de Patches 1=>3 of this v2 series add documentation for the existing seqlock.h datatypes and APIs. Hopef

[PATCH bpf] selftests/bpf: fix ringbuf selftest sample counting undeterminism

2020-06-07 Thread Andrii Nakryiko
Fix test race, in which background poll can get either 5 or 6 samples, depending on timing of notification. Prevent this by open-coding sample triggering and forcing notification for the very last sample only. Also switch to using atomic increments and exchanges for more obviously reliable countin

Re: [GIT] Networking

2020-06-07 Thread pr-tracker-bot
The pull request you sent on Sun, 07 Jun 2020 17:21:43 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/af7b4801030c07637840191c69eb666917e4135d Thank you! -- Deet-doot-dot, I am

[GIT] Networking

2020-06-07 Thread David Miller
I still haven't received from Johannes Berg a fix for the wireless shutdown issues you reported, but I will send that to you as soon as I have it. Meanwhile: 1) Fix the build with certain Kconfig combinations for the Chelsio inline TLS device, from Rohit Maheshwar and Vinay Kumar Yadavi. 2)

Re: [PATCH net v1] net: dsa: lantiq_gswip: fix and improve the unsupported interface error

2020-06-07 Thread David Miller
From: Martin Blumenstingl Date: Sun, 7 Jun 2020 15:02:58 +0200 > While trying to use the lantiq_gswip driver on one of my boards I made > a mistake when specifying the phy-mode (because the out-of-tree driver > wants phy-mode "gmii" or "mii" for the internal PHYs). In this case the > following e

Re: [PATCH net] mlxsw: core: Use different get_trend() callbacks for different thermal zones

2020-06-07 Thread David Miller
From: Ido Schimmel Date: Sun, 7 Jun 2020 11:10:27 +0300 > From: Vadim Pasternak > > The driver registers three different types of thermal zones: For the > ASIC itself, for port modules and for gearboxes. > > Currently, all three types use the same get_trend() callback which does > not work co

Re: [net-next] tipc: update a binding service via broadcast

2020-06-07 Thread David Miller
net-next is CLOSED, thank you

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-07 Thread David Miller
From: Stephen Hemminger Date: Sun, 7 Jun 2020 15:30:19 -0700 > Open source projects have been working hard to remove the terms master and > slave > in API's and documentation. Apparently, Linux hasn't gotten the message. > It would make sense not to introduce new instances. Would you also be ag

Re: [PATCH] net/mlx5: Add a missing macro undefinition

2020-06-07 Thread David Miller
From: Hu Haowen Date: Sun, 7 Jun 2020 14:55:33 +0800 > > On 2020/6/7 2:36 PM, Leon Romanovsky wrote: >> On Sun, Jun 07, 2020 at 01:12:40PM +0800, Hu Haowen wrote: >>> The macro ODP_CAP_SET_MAX is only used in function >>> handle_hca_cap_odp() >>> in file main.c, so it should be undefined when th

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-07 Thread Stephen Hemminger
On Tue, 26 May 2020 11:10:25 +0200 Oleksij Rempel wrote: > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > auto-negotiation support, we needed to be able to configure the > MASTER-SLAVE role of the port manually or from an application in user > space. > > The same UAPI

How are you

2020-06-07 Thread Poan Saman
Good Day, I am Miss.Poan and It's my pleasure to come across your contact today,if you don't mind can we chat on Skype or googlehangout/whatsapp to know each other as I have something important to discuss with you. Miss.Poan Saman

[PATCH bpf 1/2] bpf, sockhash: Fix memory leak when unlinking sockets in sock_hash_free

2020-06-07 Thread Jakub Sitnicki
When sockhash gets destroyed while sockets are still linked to it, we will walk the bucket lists and delete the links. However, we are not freeing the list elements after processing them, leaking the memory. The leak can be triggered by close()'ing a sockhash map when it still contains sockets, an

[PATCH bpf 2/2] bpf, sockhash: Synchronize delete from bucket list on map free

2020-06-07 Thread Jakub Sitnicki
We can end up modifying the sockhash bucket list from two CPUs when a sockhash is being destroyed (sock_hash_free) on one CPU, while a socket that is in the sockhash is unlinking itself from it on another CPU it (sock_hash_delete_from_link). This results in accessing a list element that is in an u

[PATCH bpf 0/2] Fixes for sock_hash_free

2020-06-07 Thread Jakub Sitnicki
This series is an attempt to fix a race in sock_hash_free recently reported by Eric [0]. The race, and a mem leak I found on the way, can be triggered by the crude reproducer posted below. [0] https://lore.kernel.org/bpf/6f8bb6d8-bb70-4533-f15b-310db595d...@gmail.com/ Cc: Eric Dumazet Cc: John F

Re: [PATCH v2 2/3] netlink: add master/slave configuration support

2020-06-07 Thread Michal Kubecek
On Thu, May 28, 2020 at 01:54:13PM +0200, Oleksij Rempel wrote: > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > auto-negotiation support, we needed to be able to configure the > MASTER-SLAVE role of the port manually or from an application in user > space. > > The same

iMX 6SX FEC: broken hardware timestamping using external PTP PHY

2020-06-07 Thread Sergey Organov
Hello, I'm using DP83640 PTP PHY connected to builtin fec1 (that has its own PTP support) of the iMX 6SX microcontroller. Almost everything works fine out of the box, except hardware timestamping. The problems are that I apparently get timestamps from fec built-in PTP instead of external PHY, and

Re: [PATCH v2 3/3] netlink: add LINKSTATE SQI support

2020-06-07 Thread Michal Kubecek
On Thu, May 28, 2020 at 01:54:14PM +0200, Oleksij Rempel wrote: > Some PHYs provide Signal Quality Index (SQI) if the link is in active > state. This information can help to diagnose cable and system design > related issues. > > Signed-off-by: Oleksij Rempel > Reviewed-by: Florian Fainelli Revi

Re: TCP_DEFER_ACCEPT wakes up without data

2020-06-07 Thread Leif Hedstrom
> On Jun 7, 2020, at 04:01, Florian Westphal wrote: > > Eric Dumazet wrote: >>> Sure! TCP_DEFER_ACCEPT delays the creation of the socket until data >>> has been sent by the client *or* the specified time has expired upon >>> which a last SYN/ACK is sent and if the client replies with an ACK

Re: [RFC PATCH net-next 03/10] mlxsw: spectrum_ethtool: Move mlxsw_sp_port_type_speed_ops structs

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Move mlxsw_sp1_port_type_speed_ops and mlxsw_sp2_port_type_speed_ops > with the relevant code from spectrum.c to spectrum_ethtool.c. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Jiri Pirko Reviewed-by: Florian Fainelli --

Re: [RFC PATCH net-next 02/10] mlxsw: Move ethtool_ops to spectrum_ethtool.c

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Add spectrum_ethtool.c file for ethtool code. > Move ethtool_ops and the relevant code from spectrum.c to > spectrum_ethtool.c. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Jiri Pirko Reviewed-by: Florian Fainelli -- Flo

Re: [RFC PATCH net-next 01/10] mlxsw: spectrum_dcb: Rename mlxsw_sp_port_headroom_set()

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > mlxsw_sp_port_headroom_set() is defined twice - in spectrum.c and in > spectrum_dcb.c, with different arguments and different implementation > but the name is same. > > Rename mlxsw_sp_port_headroom_set() to mlxsw_sp_port_headroom_ets_set() > in order to

Re: [RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Add link extended state attributes. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Jiri Pirko If you need to resubmit, I would swap the order of patches #4 and #5 such that the documentation comes first. [snip] > > +Link

Re: [net-next] tipc: update a binding service via broadcast

2020-06-07 Thread Jon Maloy
On 6/7/20 12:24 AM, Hoang Huu Le wrote: Currently, updating binding table (add service binding to name table/withdraw a service binding) is being sent over replicast. However, if we are scaling up clusters to > 100 nodes/containers this method is less affection because of looping through nodes

Re: [RFC PATCH net-next 07/10] mlxsw: spectrum_ethtool: Add link extended state

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Implement .get_down_ext_state() as part of ethtool_ops. > Query link down reason from PDDR register and convert it to ethtool > ext_state. > > In case that more information than common ext_state is provided, > fill ext_substate also with the appropriate

Re: [RFC PATCH net-next 10/10] selftests: forwarding: Add tests for ethtool extended state

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Add tests to check ethtool report about extended state. > The tests configure several states and verify that the correct extended > state is reported by ethtool. > > Check extended state with substate (Autoneg) and extended state without > substate (No c

Re: [RFC PATCH net-next 09/10] selftests: forwarding: forwarding.config.sample: Add port with no cable connected

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Add NETIF_NO_CABLE port to tests topology. > > The port can also be declared as an environment variable and tests can be > run like that: > NETIF_NO_CABLE=eth9 ./test.sh eth{1..8} > > The NETIF_NO_CABLE port will be used by ethtool_extended_state test.

Re: [RFC PATCH net-next 08/10] selftests: forwarding: ethtool: Move different_speeds_get() to ethtool_lib

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Currently different_speeds_get() is used only by ethtool.sh tests. > The function can be useful for another tests that check ethtool > configurations. > > Move the function to ethtool_lib in order to allow other tests to use > it. > > Signed-off-by: Ami

Re: [RFC PATCH net-next 04/10] ethtool: Add link extended state

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Currently, drivers can only tell whether the link is up/down using > LINKSTATE_GET, but no additional information is given. > > Add attributes to LINKSTATE_GET command in order to allow drivers > to expose the user more information in addition to link st

Re: [RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-07 Thread Andrew Lunn
> +Link extended states: > + > + > = > + ``Autoneg failure`` Failure during auto negotiation mechanism I think you need to define 'failure' here. Linux PHYs don't have this state. auto-neg is either ongoing

Re: [RFC PATCH net-next 04/10] ethtool: Add link extended state

2020-06-07 Thread Andrew Lunn
On Sun, Jun 07, 2020 at 05:59:39PM +0300, Amit Cohen wrote: > Currently, drivers can only tell whether the link is up/down using > LINKSTATE_GET, but no additional information is given. > > Add attributes to LINKSTATE_GET command in order to allow drivers > to expose the user more information in a

Re: [RFC PATCH net-next 04/10] ethtool: Add link extended state

2020-06-07 Thread Andrew Lunn
> +static void linkstate_get_ext_state(struct net_device *dev, > + struct linkstate_reply_data *data) > +{ > + int err; > + > + if (!dev->ethtool_ops->get_ext_state) > + return; > + > + err = dev->ethtool_ops->get_ext_state(dev, > &data->etht

Re: [RFC PATCH net-next 04/10] ethtool: Add link extended state

2020-06-07 Thread Andrew Lunn
> @@ -108,6 +131,12 @@ static int linkstate_reply_size(const struct > ethnl_req_info *req_base, > if (data->sqi_max != -EOPNOTSUPP) > len += nla_total_size(sizeof(u32)); > > + if (data->ext_state_provided) > + len += sizeof(u8); /* LINKSTATE_EXT_STATE */ > + >

Re: [RFC PATCH net-next 04/10] ethtool: Add link extended state

2020-06-07 Thread Andrew Lunn
> +/** > + * enum ethtool_ext_substate_cable_issue - more information in > + * addition to ETHTOOL_EXT_STATE_CABLE_ISSUE. > + */ > +enum ethtool_ext_substate_cable_issue { > + ETHTOOL_EXT_SUBSTATE_UNSUPPORTED_CABLE = 1, > + ETHTOOL_EXT_SUBSTATE_SHORTED_CABLE, > +}; I'm not too happy about

[RFC PATCH net-next 03/10] mlxsw: spectrum_ethtool: Move mlxsw_sp_port_type_speed_ops structs

2020-06-07 Thread Amit Cohen
Move mlxsw_sp1_port_type_speed_ops and mlxsw_sp2_port_type_speed_ops with the relevant code from spectrum.c to spectrum_ethtool.c. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata Reviewed-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum.c| 660 -- .../net/eth

[RFC PATCH net-next 08/10] selftests: forwarding: ethtool: Move different_speeds_get() to ethtool_lib

2020-06-07 Thread Amit Cohen
Currently different_speeds_get() is used only by ethtool.sh tests. The function can be useful for another tests that check ethtool configurations. Move the function to ethtool_lib in order to allow other tests to use it. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata --- .../testing/selft

[RFC PATCH net-next 06/10] mlxsw: reg: Port Diagnostics Database Register

2020-06-07 Thread Amit Cohen
The PDDR register enables to read the Phy debug database. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 51 +++ 1 file changed, 51 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/r

[RFC PATCH net-next 10/10] selftests: forwarding: Add tests for ethtool extended state

2020-06-07 Thread Amit Cohen
Add tests to check ethtool report about extended state. The tests configure several states and verify that the correct extended state is reported by ethtool. Check extended state with substate (Autoneg) and extended state without substate (No cable). Signed-off-by: Amit Cohen Reviewed-by: Petr M

[RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-07 Thread Amit Cohen
Add link extended state attributes. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata Reviewed-by: Jiri Pirko --- Documentation/networking/ethtool-netlink.rst | 56 ++-- 1 file changed, 52 insertions(+), 4 deletions(-) diff --git a/Documentation/networking/ethtool-netlink.rs

[RFC PATCH net-next 09/10] selftests: forwarding: forwarding.config.sample: Add port with no cable connected

2020-06-07 Thread Amit Cohen
Add NETIF_NO_CABLE port to tests topology. The port can also be declared as an environment variable and tests can be run like that: NETIF_NO_CABLE=eth9 ./test.sh eth{1..8} The NETIF_NO_CABLE port will be used by ethtool_extended_state test. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata -

[RFC PATCH net-next 04/10] ethtool: Add link extended state

2020-06-07 Thread Amit Cohen
Currently, drivers can only tell whether the link is up/down using LINKSTATE_GET, but no additional information is given. Add attributes to LINKSTATE_GET command in order to allow drivers to expose the user more information in addition to link state to ease the debug process, for example, reason f

[RFC PATCH net-next 07/10] mlxsw: spectrum_ethtool: Add link extended state

2020-06-07 Thread Amit Cohen
Implement .get_down_ext_state() as part of ethtool_ops. Query link down reason from PDDR register and convert it to ethtool ext_state. In case that more information than common ext_state is provided, fill ext_substate also with the appropriate value. Signed-off-by: Amit Cohen Reviewed-by: Petr M

[RFC PATCH net-next 02/10] mlxsw: Move ethtool_ops to spectrum_ethtool.c

2020-06-07 Thread Amit Cohen
Add spectrum_ethtool.c file for ethtool code. Move ethtool_ops and the relevant code from spectrum.c to spectrum_ethtool.c. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/Makefile | 3 +- .../net/ethernet/mellanox/mlxsw/sp

[RFC PATCH net-next 01/10] mlxsw: spectrum_dcb: Rename mlxsw_sp_port_headroom_set()

2020-06-07 Thread Amit Cohen
mlxsw_sp_port_headroom_set() is defined twice - in spectrum.c and in spectrum_dcb.c, with different arguments and different implementation but the name is same. Rename mlxsw_sp_port_headroom_set() to mlxsw_sp_port_headroom_ets_set() in order to allow using the second function in several files, and

[RFC PATCH net-next 00/10] Add extended state

2020-06-07 Thread Amit Cohen
Currently, drivers can only tell whether the link is up/down, but no additional information is given. This patch set provides an infrastructure that allows drivers to expose to the user more information in addition to the link state. This information can save users time which will not be wasted t

[PATCH RFC v5 03/13] vhost: batching fetches

2020-06-07 Thread Michael S. Tsirkin
With this patch applied, new and old code perform identically. Lots of extra optimizations are now possible, e.g. we can fetch multiple heads with copy_from/to_user now. We can get rid of maintaining the log array. Etc etc. Signed-off-by: Michael S. Tsirkin Signed-off-by: Eugenio Pérez Link: h

[PATCH RFC v5 00/13] vhost: ring format independence

2020-06-07 Thread Michael S. Tsirkin
This adds infrastructure required for supporting multiple ring formats. The idea is as follows: we convert descriptors to an independent format first, and process that converting to iov later. Used ring is similar: we fetch into an independent struct first, convert that to IOV later. The point

[PATCH RFC v5 01/13] vhost: option to fetch descriptors through an independent struct

2020-06-07 Thread Michael S. Tsirkin
The idea is to support multiple ring formats by converting to a format-independent array of descriptors. This costs extra cycles, but we gain in ability to fetch a batch of descriptors in one go, which is good for code cache locality. When used, this causes a minor performance degradation, it's b

[PATCH RFC v5 02/13] vhost: use batched version by default

2020-06-07 Thread Michael S. Tsirkin
As testing shows no performance change, switch to that now. Signed-off-by: Michael S. Tsirkin Signed-off-by: Eugenio Pérez Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 251 +--

[PATCH RFC v5 05/13] vhost/net: pass net specific struct pointer

2020-06-07 Thread Michael S. Tsirkin
In preparation for further cleanup, pass net specific pointer to ubuf callbacks so we can move net specific fields out to net structures. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/vhost/net

[PATCH RFC v5 11/13] vhost/scsi: switch to buf APIs

2020-06-07 Thread Michael S. Tsirkin
Switch to buf APIs. Doing this exposes a spec violation in vhost scsi: all used bufs are marked with length 0. Fix that is left for another day. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/scsi.c | 73 ++-- 1 file changed, 44 insertions(+), 29 dele

[PATCH RFC v5 12/13] vhost/vsock: switch to the buf API

2020-06-07 Thread Michael S. Tsirkin
A straight-forward conversion. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vsock.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index a483cec31d5c..61c6d3dd2ae3 100644 --- a/drivers/vhos

[PATCH RFC v5 13/13] vhost: drop head based APIs

2020-06-07 Thread Michael S. Tsirkin
Everyone's using buf APIs, no need for head based ones anymore. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 36 drivers/vhost/vhost.h | 12 2 files changed, 8 insertions(+), 40 deletions(-) diff --git a/drivers/vhost/vhost.c b/

[PATCH RFC v5 08/13] vhost/net: convert to new API: heads->bufs

2020-06-07 Thread Michael S. Tsirkin
Convert vhost net to use the new format-agnostic API. In particular, don't poke at vq internals such as the heads array. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 154 +++- 1 file changed, 82 insertions(+), 72 deletions(-) diff --git a/d

[PATCH RFC v5 07/13] vhost: format-independent API for used buffers

2020-06-07 Thread Michael S. Tsirkin
Add a new API that doesn't assume used ring, heads, etc. For now, we keep the old APIs around to make it easier to convert drivers. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 52 ++- drivers/vhost/vhost.h | 17 +- 2 files cha

[PATCH RFC v5 09/13] vhost/net: avoid iov length math

2020-06-07 Thread Michael S. Tsirkin
Now that API exposes buffer length, we no longer need to scan IOVs to figure it out. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 830fe84912a5..0b509be8d7b1 10

[PATCH RFC v5 10/13] vhost/test: convert to the buf API

2020-06-07 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c index 02806d6f84ef..251fd2bf74a3 100644 --- a/drivers/vhost/test.c +++ b/drivers/vhost/test.c @@ -44,9 +

[PATCH RFC v5 06/13] vhost: reorder functions

2020-06-07 Thread Michael S. Tsirkin
Reorder functions in the file to not rely on forward declarations, in preparation to making them static down the road. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/driver

[PATCH RFC v5 04/13] vhost: cleanup fetch_buf return code handling

2020-06-07 Thread Michael S. Tsirkin
Return code of fetch_buf is confusing, so callers resort to tricks to get to sane values. Let's switch to something standard: 0 empty, >0 non-empty, <0 error. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 24 1 file changed, 16 insertions(+), 8 deletions(

Re: [PATCH RFC 01/13] vhost: option to fetch descriptors through an independent struct

2020-06-07 Thread Michael S. Tsirkin
On Wed, Jun 03, 2020 at 08:04:45PM +0800, Jason Wang wrote: > > On 2020/6/3 下午5:48, Michael S. Tsirkin wrote: > > On Wed, Jun 03, 2020 at 03:13:56PM +0800, Jason Wang wrote: > > > On 2020/6/2 下午9:05, Michael S. Tsirkin wrote: > > > [...] > > > > > > + > > > > +static int fetch_indirect_descs(s

Re: [PATCH RFC 03/13] vhost: batching fetches

2020-06-07 Thread Michael S. Tsirkin
On Fri, Jun 05, 2020 at 11:40:17AM +0800, Jason Wang wrote: > > On 2020/6/4 下午4:59, Michael S. Tsirkin wrote: > > On Wed, Jun 03, 2020 at 03:27:39PM +0800, Jason Wang wrote: > > > On 2020/6/2 下午9:06, Michael S. Tsirkin wrote: > > > > With this patch applied, new and old code perform identically. >

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-07 Thread Michael S. Tsirkin
On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: > > On 2020/6/2 下午3:08, Jason Wang wrote: > > > > > > > +static const struct pci_device_id vp_vdpa_id_table[] = { > > > > +    { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, > > > > +    { 0 } > > > > +}; > > > This looks lik

RE: [PATCH bpf v2] bpf: increase {get,set}sockopt optval size limit

2020-06-07 Thread David Laight
From: Stanislav Fomichev > Sent: 05 June 2020 01:22 > Attaching to these hooks can break iptables because its optval is > usually quite big, or at least bigger than the current PAGE_SIZE limit. > > There are two possible ways to fix it: > 1. Increase the limit to match iptables max optval. > 2. Im

Re: [PATCH] virtio_net: Unregister and re-register xdp_rxq across freeze/restore

2020-06-07 Thread Michael S. Tsirkin
On Fri, Jun 05, 2020 at 02:46:24PM -0700, Sean Christopherson wrote: > Unregister each queue's xdp_rxq during freeze, and re-register the new > instance during restore. All queues are released during free and > recreated during restore, i.e. the pre-freeze xdp_rxq will be lost. > > The bug is det

Re: [PATCH net v1] net: dsa: lantiq_gswip: fix and improve the unsupported interface error

2020-06-07 Thread Hauke Mehrtens
On 6/7/20 3:02 PM, Martin Blumenstingl wrote: > While trying to use the lantiq_gswip driver on one of my boards I made > a mistake when specifying the phy-mode (because the out-of-tree driver > wants phy-mode "gmii" or "mii" for the internal PHYs). In this case the > following error is printed mult

[PATCH net v1] net: dsa: lantiq_gswip: fix and improve the unsupported interface error

2020-06-07 Thread Martin Blumenstingl
While trying to use the lantiq_gswip driver on one of my boards I made a mistake when specifying the phy-mode (because the out-of-tree driver wants phy-mode "gmii" or "mii" for the internal PHYs). In this case the following error is printed multiple times: Unsupported interface: 3 While it gives

Re: TCP_DEFER_ACCEPT wakes up without data

2020-06-07 Thread Florian Westphal
Eric Dumazet wrote: > > Sure! TCP_DEFER_ACCEPT delays the creation of the socket until data > > has been sent by the client *or* the specified time has expired upon > > which a last SYN/ACK is sent and if the client replies with an ACK the > > socket will be created and presented to the accept()-c

[PATCH iproute2 0/2] Two devlink-trap enhancements

2020-06-07 Thread Ido Schimmel
From: Ido Schimmel This patch set contains two small devlink-trap enhancements for code that is already present in mainline. Patch #1 adds 'control' trap type. Patch #2 adds 'mirror' trap action. The 'devlink' bash completion and 'devlink-trap' man page are extended accordingly. Ido Schimmel

[PATCH iproute2 1/2] devlink: Add 'control' trap type

2020-06-07 Thread Ido Schimmel
From: Ido Schimmel This type is used for traps that trap control packets such as ARP request and IGMP query to the CPU. Example: # devlink -jp trap show netdevsim/netdevsim10 trap igmp_v1_report { "trap": { "netdevsim/netdevsim10": [ { "name": "igmp_v1_report",

[PATCH iproute2 2/2] devlink: Add 'mirror' trap action

2020-06-07 Thread Ido Schimmel
From: Ido Schimmel Allow setting 'mirror' trap action for traps that support it. Extend the devlink-trap man page and bash completion accordingly. Example: # devlink -jp trap show netdevsim/netdevsim10 trap igmp_query { "trap": { "netdevsim/netdevsim10": [ { "name":

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-07 Thread Nikolay Aleksandrov
On 03/06/2020 00:01, David Miller wrote: > From: Nikolay Aleksandrov > Date: Tue, 2 Jun 2020 10:23:09 +0300 > >> On 01/06/2020 21:06, David Miller wrote: >>> From: patrickeigens...@gmail.com >>> Date: Mon, 1 Jun 2020 13:12:01 +0200 >>> From: Patrick Eigensatz After allocating the

[RFC PATCH] tipc: tipc_named_dequeue() can be static

2020-06-07 Thread kernel test robot
Signed-off-by: kernel test robot --- name_distr.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/tipc/name_distr.c b/net/tipc/name_distr.c index 481d480609f0a..b4f2351259333 100644 --- a/net/tipc/name_distr.c +++ b/net/tipc/name_distr.c @@ -320,8 +320,8 @@ static

Re: [net-next] tipc: update a binding service via broadcast

2020-06-07 Thread kernel test robot
also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Hoang-Huu-Le/tipc-update-a-binding-service-via-broadcast/20200607-122712 base: https://git.kernel.org/pub

[PATCH net] mlxsw: core: Use different get_trend() callbacks for different thermal zones

2020-06-07 Thread Ido Schimmel
From: Vadim Pasternak The driver registers three different types of thermal zones: For the ASIC itself, for port modules and for gearboxes. Currently, all three types use the same get_trend() callback which does not work correctly for the ASIC thermal zone. The callback assumes that the device d