[PATCH] seg6: Fix slab-out-of-bounds in fl6_update_dst()

2020-06-01 Thread YueHaibing
When update flowi6 daddr in fl6_update_dst() for srcrt, the used index of segments should be segments_left minus one per RFC8754 (section 4.3.1.1) S15 S16. Otherwise it may results in an out-of-bounds read. Reported-by: syzbot+e8c028b62439eac42...@syzkaller.appspotmail.com Fixes: 0cb7498f234e ("se

Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-01 Thread Jason Wang
ll-mapping/20200531-070834 base:https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: m68k-randconfig-r011-20200601 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wgethttps://raw.githubusercontent.com/intel/lkp-tests/m

[PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()

2020-06-01 Thread YueHaibing
dumpit info is freed by cb->done now (genl_lock_done()/ genl_parallel_done()), however if any error occurs before cb->done is called, info and attrs will leak. unreferenced object 0x888119904840 (size 32): comm "syz-executor.0", pid 857, jiffies 4295306979 (age 18.692s) hex dump (first 32 byte

[PATCH net] crypto/chcr: error seen if CONFIG_CHELSIO_TLS_DEVICE isn't set

2020-06-01 Thread Rohit Maheshwari
cxgb4_uld_in_use() is used only by cxgb4_ktls_det_feature() which is under CONFIG_CHELSIO_TLS_DEVICE macro. Signed-off-by: Rohit Maheshwari --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cx

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jiri Pirko
Tue, Jun 02, 2020 at 01:24:16AM CEST, k...@kernel.org wrote: >On Mon, 1 Jun 2020 21:01:42 +0530 Vasundhara Volam wrote: >> > I think that the legacy ethtool should stick with the "ordinary fw reset", >> > becase that is what user expects. You should add an attribute to >> > "devlink dev reload" to

RE: [RFC PATCH] net: usb: ax88179_178a: fix packet alignment padding

2020-06-01 Thread ASIX_Allan [Office]
Hi Louis, Please help to take care of this problem. Thanks a lot. --- Best regards, Allan Chou ASIX Electronics Corporation TEL: 886-3-5799500 ext.228 FAX: 886-3-5799558 E-mail: al...@asix.com.tw https://www.asix.com.tw/ -Original Message- From: Jeremy Kerr Sent: Tuesday, June 2,

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 11:44:36PM CEST, k...@kernel.org wrote: >On Mon, 1 Jun 2020 08:39:18 +0200 Jiri Pirko wrote: >> > If the permanent (NVRAM) parameter is true, all loaded new drivers >> > will indicate support for this feature and set the runtime value to >> > true by default. The runtime value

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-06-01 Thread Leon Romanovsky
On Mon, Jun 01, 2020 at 10:08:44AM -0700, Rao Shoaib wrote: > > On 5/31/20 3:08 AM, Leon Romanovsky wrote: > > On Wed, May 27, 2020 at 01:17:42AM -0700, rao.sho...@oracle.com wrote: > > > From: Rao Shoaib > > > > > > This enhancement auto loads transport module when the transport > > > is set via

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-06-01 Thread Leon Romanovsky
On Mon, Jun 01, 2020 at 09:59:30AM -0700, Rao Shoaib wrote: > > On 5/29/20 4:41 PM, David Miller wrote: > > From: rao.sho...@oracle.com > > Date: Wed, 27 May 2020 01:17:42 -0700 > > > > > diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h > > > index cba368e55863..7273c681e6c1 100644

Re: [PATCH v2 2/2] vhost: convert get_user_pages() --> pin_user_pages()

2020-06-01 Thread Pankaj Gupta
> This code was using get_user_pages*(), in approximately a "Case 5" > scenario (accessing the data within a page), using the categorization > from [1]. That means that it's time to convert the get_user_pages*() + > put_page() calls to pin_user_pages*() + unpin_user_pages() calls. > > There is some

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 09:50:23PM CEST, xiyou.wangc...@gmail.com wrote: >On Mon, Jun 1, 2020 at 6:40 AM Jiri Pirko wrote: >> The first command just says "early drop position should be processed by >> block 10" >> >> The second command just adds a filter to the block 10. > >This is exactly why it loo

Re: netif_device_present() and Runtime PM / PCI D3

2020-06-01 Thread Heiner Kallweit
On 31.05.2020 17:05, Andrew Lunn wrote: > On Sun, May 31, 2020 at 02:07:46PM +0200, Heiner Kallweit wrote: >> I just wonder about the semantics of netif_device_present(). >> If a device is in PCI D3 (e.g. being runtime-suspended), then it's >> not accessible. So is it present or not? >> The descrip

Re: [net 1/2] Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv"

2020-06-01 Thread hoang.h.le
On Tue, Jun 02, 2020 at 11:46:40AM +0700, Tuong Lien wrote: Tested-by: Hoang Le > This reverts commit de058420767df21e2b6b0f3bb36d1616fb962032. > > There is no actual tipc_node refcnt leak as stated in the above commit. > The refcnt is hold carefully for the case of an asynchronous decryption >

Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums

2020-06-01 Thread Michael Forney
Hi, On 2020-03-04, Daniel Borkmann wrote: > I was about to push the series out, but agree that there may be a risk for > #ifndefs > in the BPF C code. If we want to be on safe side, #define FOO FOO would be > needed. I did indeed hit some breakage due to this change, but not for the anticipated

[PATCH v2 net-next 04/10] net: mscc: ocelot: change vcap to be compatible with full and quad entry

2020-06-01 Thread Xiaoliang Yang
When calculating vcap data offset, the function only supports half key entry. This patch modify vcap_data_offset_get function to calculate a correct data offset when setting VCAP Type-Group to VCAP_TG_FULL or VCAP_TG_QUARTER. Signed-off-by: Xiaoliang Yang --- drivers/net/ethernet/mscc/ocelot_ace

[PATCH v2 net-next 00/10] net: ocelot: VCAP IS1 and ES0 support

2020-06-01 Thread Xiaoliang Yang
This series patches adds support for VCAP IS1 and ES0 module, each VCAP correspond to a flow chain to offload. VCAP IS1 supports FLOW_ACTION_VLAN_MANGLE action to filter MAC, IP, VLAN, protocol, and TCP/UDP ports keys and retag vlian tag, FLOW_ACTION_PRIORITY action to classify packages to differe

[PATCH v2 net-next 10/10] net: dsa: tag_ocelot: use VLAN information from tagging header when available

2020-06-01 Thread Xiaoliang Yang
From: Vladimir Oltean When the Extraction Frame Header contains a valid classified VLAN, use that instead of the VLAN header present in the packet. Signed-off-by: Vladimir Oltean --- net/dsa/tag_ocelot.c | 29 + 1 file changed, 29 insertions(+) diff --git a/net/dsa

[PATCH v2 net-next 09/10] net: dsa: felix: correct VCAP IS2 keys offset

2020-06-01 Thread Xiaoliang Yang
Some of IS2 IP4_TCP_UDP keys are not correct, like L4_DPORT, L4_SPORT and other L4 keys. It causes the issue that VCAP IS2 could not filter a right dst/src port for TCP/UDP packages. Signed-off-by: Xiaoliang Yang --- drivers/net/dsa/ocelot/felix_vsc9959.c | 16 1 file changed, 8

[PATCH v2 net-next 08/10] net: ocelot: return error if rule is not found

2020-06-01 Thread Xiaoliang Yang
Return error if rule is not found in rule list to avoid Kernel panic. Signed-off-by: Xiaoliang Yang --- drivers/net/ethernet/mscc/ocelot_ace.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c b/drivers/net/ethernet/mscc/ocelot_a

[PATCH v2 net-next 03/10] net: mscc: ocelot: allocated rules to different hardware VCAP TCAMs by chain index

2020-06-01 Thread Xiaoliang Yang
There are three hardware TCAMs for ocelot chips: IS1, IS2 and ES0. Each one supports different actions. The hardware flow order is: IS1->IS2->ES0. This patch add three blocks to store rules according to chain index. chain 0 is offloaded to IS1, chain 1 is offloaded to IS2, and egress chain 0 is of

[PATCH v2 net-next 02/10] net: mscc: ocelot: generalize existing code for VCAP

2020-06-01 Thread Xiaoliang Yang
From: Vladimir Oltean The Ocelot driver only supports VCAP IS2, the security enforcement block which implements Access Control List actions (trap, drop, police). In preparation of VCAP IS1 support, generalize the existing code to work with any VCAP. In that direction, move all VCAP instantiation

[PATCH v2 net-next 05/10] net: mscc: ocelot: VCAP IS1 support

2020-06-01 Thread Xiaoliang Yang
VCAP IS1 is a VCAP module which can filter MAC, IP, VLAN, protocol, and TCP/UDP ports keys, and do Qos classified and VLAN retag actions. This patch added VCAP IS1 support in ocelot ace driver, which can supports vlan modify and skbedit priority action of tc filter. Usage: tc qdisc add dev

[PATCH v2 net-next 06/10] net: mscc: ocelot: VCAP ES0 support

2020-06-01 Thread Xiaoliang Yang
VCAP ES0 is an egress VCAP working on all outgoing frames. This patch added ES0 driver to support vlan push action of tc filter. Usage: tc filter add dev swp1 egress protocol 802.1Q flower skip_sw vlan_id 1 vlan_prio 1 action vlan push id 2 priority 2 Signed-off-by: Xiaoliang Yang

[PATCH v2 net-next 07/10] net: mscc: ocelot: multiple actions support

2020-06-01 Thread Xiaoliang Yang
Support multiple actions for each flower rule, multiple actions can only set on the same VCAP, and all actions can mix with action goto chain. Action drop, trap, and police on VCAP IS2 could not be mixed. Signed-off-by: Xiaoliang Yang --- drivers/net/ethernet/mscc/ocelot_ace.c| 15 +-

[PATCH v2 net-next 01/10] net: mscc: ocelot: introduce a new ocelot_target_{read,write} API

2020-06-01 Thread Xiaoliang Yang
From: Vladimir Oltean There are some targets (register blocks) in the Ocelot switch that are instantiated more than once. For example, the VCAP IS1, IS2 and ES0 blocks all share the same register layout for interacting with the cache for the TCAM and the action RAM. For the VCAPs, the procedure

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-01 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 04:03:02PM +0800, Jason Wang wrote: > Note that since virtio specification does not support get/restore > virtqueue state. So we can not use this driver for VM. This can be > addressed by extending the virtio specification. Looks like exactly the kind of hardware limitation

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-01 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 04:03:02PM +0800, Jason Wang wrote: > +static void vp_vdpa_set_vq_ready(struct vdpa_device *vdpa, > + u16 qid, bool ready) > +{ > + struct vp_vdpa *vp_vdpa = vdpa_to_vp(vdpa); > + > + vp_iowrite16(qid, &vp_vdpa->common->queue_select); > +

[PATCH bpf-next] selftests/bpf: fix sample_cnt shared between two threads

2020-06-01 Thread Andrii Nakryiko
Make sample_cnt volatile to fix possible selftests failure due to compiler optimization preventing latest sample_cnt value to be visible to main thread. sample_cnt is incremented in background thread, which is then joined into main thread. So in terms of visibility sample_cnt update is ok. But beca

Re: [PATCH 1/6] vhost: allow device that does not depend on vhost worker

2020-06-01 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 04:02:58PM +0800, Jason Wang wrote: > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index d450e16c5c25..70105e045768 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -166,11 +166,16 @@ static int vhost_poll_wakeup(wait_queue_entry_t *wai

Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-01 Thread Michael S. Tsirkin
Wang/vDPA-doorbell-mapping/20200531-070834 > base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git > linux-next > config: m68k-randconfig-r011-20200601 (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wg

[net 2/2] Revert "tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv"

2020-06-01 Thread Tuong Lien
This reverts commit 441870ee4240cf67b5d3ab8e16216a9ff42eb5d6. Like the previous patch in this series, we revert the above commit that causes similar issues with the 'aead' object. Acked-by: Jon Maloy Signed-off-by: Tuong Lien --- net/tipc/crypto.c | 1 - 1 file changed, 1 deletion(-) diff --g

[net 1/2] Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv"

2020-06-01 Thread Tuong Lien
This reverts commit de058420767df21e2b6b0f3bb36d1616fb962032. There is no actual tipc_node refcnt leak as stated in the above commit. The refcnt is hold carefully for the case of an asynchronous decryption (i.e. -EINPROGRESS/-EBUSY and skb = NULL is returned), so that the node object cannot be fre

[net 0/2] tipc: revert two patches

2020-06-01 Thread Tuong Lien
We revert two patches: tipc: Fix potential tipc_node refcnt leak in tipc_rcv tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv which prevented TIPC encryption from working properly and caused kernel panic. Tuong Lien (2): Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv

Re: [net-next 10/11] net/mlx5e: kTLS, Add kTLS RX resync support

2020-06-01 Thread Boris Pismenny
On 02/06/2020 1:12, Jakub Kicinski wrote: > On Sun, 31 May 2020 15:06:28 +0300 Boris Pismenny wrote: >> On 30/05/2020 0:50, Jakub Kicinski wrote: >> >>> IIUC every ooo packet causes a resync request in your >>> implementation - is that true? >>> >> No, only header loss. We never required a resyn

Re: [PATCH net-next] af-packet: new flag to indicate all csums are good

2020-06-01 Thread Victor Julien
On 01-06-2020 23:45, David Miller wrote: > From: Victor Julien > Date: Mon, 1 Jun 2020 22:49:37 +0200 > >> @@ -472,6 +472,12 @@ TP_STATUS_CSUM_VALIDThis flag indicates that at >> least the transport >> validated on the kernel side. If the flag is not set >>

Re: [PATCH 2/2] vhost: convert get_user_pages() --> pin_user_pages()

2020-06-01 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 04:43:09PM -0700, John Hubbard wrote: > This code was using get_user_pages*(), in approximately a "Case 5" > scenario (accessing the data within a page), using the categorization > from [1]. That means that it's time to convert the get_user_pages*() + > put_page() calls to p

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-06-01 Thread Nathan Chancellor
On Sun, May 31, 2020 at 12:58:10PM +0300, Leon Romanovsky wrote: > On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > > 'err' is used uninitialized whenever 'if' condition is true > >

linux-next: build failure after merge of the mmc tree

2020-06-01 Thread Stephen Rothwell
Hi all, After merging the mmc tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: In function 'brcmf_sdiod_probe': drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:915:7: error: 'SDIO_DEVICE_ID_CYPRESS_437

Re: [RFC PATCH] net: usb: ax88179_178a: fix packet alignment padding

2020-06-01 Thread Jeremy Kerr
Hi Freddy and Allan, Just following up on the RFC patch below: Can you confirm whether the packet len (in the hardware-provided packet RX metadata) includes the two-byte padding field? Is this the same for all ax88179 devices? Cheers, Jeremy > Using a AX88179 device (0b95:1790), I see two byte

[PATCH net-next] vmxnet3: allow rx flow hash ops only when rss is enabled

2020-06-01 Thread Ronak Doshi
It makes sense to allow changes to get/set rx flow hash callback only when rss is enabled. This patch restricts get_rss_hash_opts and set_rss_hash_opts methods to allow querying and configuring different Rx flow hash configurations only when rss is enabled Signed-off-by: Ronak Doshi --- drivers/

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread David Ahern
On 6/1/20 4:52 PM, Andrii Nakryiko wrote: > Do you have specific examples of inconsistencies? Seems like duration is: nope, just a quick grep trying to understand why it compiled cleanly for me and looking at similar tests. > 1. either static variable, and thus zero-initialized; > 2. is initializ

linux-next: build warning after merge of the net-next tree

2020-06-01 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: warning: 'cxgb4_uld_in_use' defined but not used [-Wunused-function] 666 | static bool cxgb4_uld_in_use(struct adapter *adap

linux-next: manual merge of the net-next tree with the clk tree

2020-06-01 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.txt between commit: 7b9e111a5216 ("dt-bindings: clock: mediatek: document clk bindings for Mediatek MT6765 SoC") from the clk tree and commit: 9f9d1e

Re: [virtio-dev] Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-01 Thread Jason Wang
On 2020/5/30 上午2:30, Rob Miller wrote: Given the need for 4K doorbell such that QEMU can easily map, ect, and assuming that I have a HW device which exposes 2 VQ's, with a notification area off of BAR3, offset=whatever, notifier_multiplier=4, we don't need to have 2 x 4K pages mapped into the

Re: [PATCH] Bluetooth: Check scan state before disabling during suspend

2020-06-01 Thread Abhishek Pandit-Subedi
Hey linux-bluetooth, We found this bug when reverting some Chromium maintained patches in our repository that was conditionally dropping LE scan enable commands if it wasn't toggling between true/false. On some Intel controllers, disabling LE scan when it's already disabled resulted in a "Command

Re: [PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto offload

2020-06-01 Thread Huy Nguyen
PSB On 5/22/2020 7:25 PM, Saeed Mahameed wrote: On Thu, 2020-05-21 at 16:49 -0500, Huy Nguyen wrote: During IPsec performance testing, we see bad ICMP checksum. The issue is that the error packet that has duplicated ESP trailer. For example, this below ping reply skb is collected at mlx5e_xmit.

[PATCH net-next v6] hinic: add set_channels ethtool_ops support

2020-06-01 Thread Luo bin
add support to change TX/RX queue number with "ethtool -L combined". V5 -> V6: remove check for carrier in hinic_xmit_frame V4 -> V5: change time zone in patch header V3 -> V4: update date in patch header V2 -> V3: remove check for zero channels->combined_count V1 -> V2: update commit message("eth

Re: [PATCH net-next v5] hinic: add set_channels ethtool_ops support

2020-06-01 Thread luobin (L)
On 2020/6/2 1:53, David Miller wrote: From: Luo bin Date: Mon, 1 Jun 2020 18:57:48 +0800 @@ -470,6 +470,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct net_device *netdev) struct hinic_txq *txq; struct hinic_qp *qp; + if (unlikely(!netif_carrier_ok(netdev)))

Re: [PATCH 02/12] xenbus: add freeze/thaw/restore callbacks support

2020-06-01 Thread Agarwal, Anchal
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 5/19/20 7:25 PM, Anchal Agarwal wrote: > > int xenbus_dev_resume(struct device *dev) > { > -

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jakub Kicinski
On Mon, 1 Jun 2020 21:01:42 +0530 Vasundhara Volam wrote: > > I think that the legacy ethtool should stick with the "ordinary fw reset", > > becase that is what user expects. You should add an attribute to > > "devlink dev reload" to trigger the "live fw reset" > > Okay. > > I am planning to ad

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jakub Kicinski
On Mon, 1 Jun 2020 11:58:38 +0200 Jiri Pirko wrote: > > Documentation/networking/devlink/bnxt.rst | 4 ++ > > .../networking/devlink/devlink-params.rst | 28 ++ > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +- > > drivers/net/ethernet/broadcom/bnxt/bnx

linux-next: Fixes tag needs some work in the net-next tree

2020-06-01 Thread Stephen Rothwell
Hi all, In commit 055be6865dea ("Crypto/chcr: Fixes a coccinile check error") Fixes tag Fixes: 567be3a5d227 ("crypto: has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading but no trailing quotes Please do not split Fixes tags over more than one

Re: pull-request: bpf-next 2020-06-01

2020-06-01 Thread David Miller
From: Alexei Starovoitov Date: Mon, 1 Jun 2020 15:50:24 -0700 > The following pull-request contains BPF updates for your *net-next* tree. Pulled, thanks Alexei.

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread Andrii Nakryiko
On Mon, Jun 1, 2020 at 3:28 PM David Ahern wrote: > > On 6/1/20 3:12 PM, Alexei Starovoitov wrote: > > In patch 5 I had to fix: > > /data/users/ast/net-next/tools/testing/selftests/bpf/prog_tests/xdp_devmap_attach.c: > > In function ‘test_neg_xdp_devmap_helpers’: > > /data/users/ast/net-next/tools

Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-01 Thread Song Liu
On Mon, Jun 1, 2020 at 3:12 PM Alexei Starovoitov wrote: > > On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > > > Currenty lsm uses bpf_tracing_func_proto helpers which do > > > not include stack trace or perf event output. It's use

Re: [PATCH 5/5] sfc: add missing annotation for efx_ef10_try_update_nic_stats_vf()

2020-06-01 Thread David Miller
From: Jules Irenge Date: Mon, 1 Jun 2020 19:45:52 +0100 > Sparse reports a warning at efx_ef10_try_update_nic_stats_vf() > warning: context imbalance in efx_ef10_try_update_nic_stats_vf() > - unexpected unlock > The root cause is the missing annotation at > efx_ef10_try_update_nic_stats_vf

Re: [PATCH] pch_gbe: free skb on octal, nibble, and crc errors

2020-06-01 Thread David Miller
From: David Franck Date: Mon, 1 Jun 2020 11:49:07 -0400 > This patch prevents memory leak when octal, nibble, and crc errors are > encountered. > Typical user is not impacted with the issue because frequent octal, nibble, > or crc errors are unlikely. > > Signed-off-by: David G Franck Applied.

pull-request: bpf-next 2020-06-01

2020-06-01 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net-next* tree. We've added 55 non-merge commits during the last 1 day(s) which contain a total of 91 files changed, 4986 insertions(+), 463 deletions(-). The main changes are: 1) Add rx_queue_mapping to bpf_sock from Amritha.

Re: [PATCH net-next V2 0/2] Fixing compilation warnings and errors

2020-06-01 Thread David Miller
From: Ayush Sawal Date: Mon, 1 Jun 2020 23:11:57 +0530 > Patch 1: Fixes the warnings seen when compiling using sparse tool. > > Patch 2: Fixes a cocci check error introduced after commit > 567be3a5d227 ("crypto: chelsio - > Use multiple txq/rxq per tfm to process the requests"). > > V1->V2 >

Re: [PATCH net] crypto/chcr: IPV6 code needs to be in CONFIG_IPV6

2020-06-01 Thread David Miller
From: Rohit Maheshwari Date: Mon, 1 Jun 2020 19:33:32 +0530 > Error messages seen while building kernel with CONFIG_IPV6 > disabled. > > Signed-off-by: Rohit Maheshwari Applied.

Re: [PATCH net v4] cxgb4/chcr: Enable ktls settings at run time

2020-06-01 Thread David Miller
From: Rohit Maheshwari Date: Mon, 1 Jun 2020 13:08:29 +0530 > Current design enables ktls setting from start, which is not > efficient. Now the feature will be enabled when user demands > TLS offload on any interface. > > v1->v2: > - taking ULD module refcount till any single connection exists.

Re: [PATCH net] ipv6: fix IPV6_ADDRFORM operation logic

2020-06-01 Thread David Miller
From: Hangbin Liu Date: Mon, 1 Jun 2020 11:55:03 +0800 > Socket option IPV6_ADDRFORM supports UDP/UDPLITE and TCP at present. > Previously the checking logic looks like: > if (sk->sk_protocol == IPPROTO_UDP || sk->sk_protocol == IPPROTO_UDPLITE) > do_some_check; > else if (sk->sk_protocol

Re: [PATCH 01/12] xen/manage: keep track of the on-going suspend mode

2020-06-01 Thread Boris Ostrovsky
On 6/1/20 5:00 PM, Agarwal, Anchal wrote: >  > > I don't see these last two used anywhere. Are you, in fact, > distinguishing between PM suspend and hibernation? > > Yes, I am. Unless there is a better way to distinguish at runtime which I > haven't figured out yet. > The initial desig

Re: [PATCH bpf-next v2 11/12] selftests/bpf: Convert test_flow_dissector to use BPF skeleton

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:29 AM Jakub Sitnicki wrote: > > Switch flow dissector test setup from custom BPF object loader to BPF > skeleton to save boilerplate and prepare for testing higher-level API for > attaching flow dissector with bpf_link. > > To avoid depending on program order in the BPF o

Re: [PATCH bpf-next v2 08/12] bpftool: Support link show for netns-attached links

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:31 AM Jakub Sitnicki wrote: > > Make `bpf link show` aware of new link type, that is links attached to > netns. When listing netns-attached links, display netns inode number as its > identifier and link attach type. > > Sample session: > > # readlink /proc/self/ns/net >

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

2020-06-01 Thread Petr Machata
Cong Wang writes: > On Mon, Jun 1, 2020 at 6:40 AM Jiri Pirko wrote: >> The first command just says "early drop position should be processed by >> block 10" >> >> The second command just adds a filter to the block 10. > This is exactly why it looks odd to me, because it _reads_ like > 'tc qdi

Re: [PATCH bpf-next 4/6] bpf: cpumap: add the possibility to attach an eBPF program to cpumap

2020-06-01 Thread Alexei Starovoitov
On Sun, May 31, 2020 at 11:46:49PM +0200, Lorenzo Bianconi wrote: > + > + prog = READ_ONCE(rcpu->prog); > for (i = 0; i < n; i++) { > - void *f = frames[i]; > + void *f = xdp_frames[i]; > struct page *page = vir

Re: [PATCH bpf-next v2 07/12] bpftool: Extract helpers for showing link attach type

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:32 AM Jakub Sitnicki wrote: > > Code for printing link attach_type is duplicated in a couple of places, and > likely will be duplicated for future link types as well. Create helpers to > prevent duplication. > > Suggested-by: Andrii Nakryiko > Signed-off-by: Jakub Sitnic

Re: [PATCH net-next] tipc: Fix NULL pointer dereference in __tipc_sendstream()

2020-06-01 Thread David Miller
From: YueHaibing Date: Thu, 28 May 2020 22:34:07 +0800 > tipc_sendstream() may send zero length packet, then tipc_msg_append() > do not alloc skb, skb_peek_tail() will get NULL, msg_set_ack_required > will trigger NULL pointer dereference. > > Reported-by: syzbot+8eac6d030e7807c21...@syzkaller.a

Re: [PATCH bpf-next v2 06/12] libbpf: Add support for bpf_link-based netns attachment

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:29 AM Jakub Sitnicki wrote: > > Add bpf_program__attach_nets(), which uses LINK_CREATE subcommand to create typo: nets -> netns > an FD-based kernel bpf_link, for attach types tied to network namespace, > that is BPF_FLOW_DISSECTOR for the moment. > > Signed-off-by: Jak

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 01, 2020 at 04:28:02PM -0600, David Ahern wrote: > On 6/1/20 3:12 PM, Alexei Starovoitov wrote: > > In patch 5 I had to fix: > > /data/users/ast/net-next/tools/testing/selftests/bpf/prog_tests/xdp_devmap_attach.c: > > In function ‘test_neg_xdp_devmap_helpers’: > > /data/users/ast/net-ne

Re: [PATCH bpf-next v2 05/12] bpf, cgroup: Return ENOLINK for auto-detached links on update

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:29 AM Jakub Sitnicki wrote: > > Failure to update a bpf_link because it has been auto-detached by a dying > cgroup currently results in EINVAL error, even though the arguments passed > to bpf() syscall are not wrong. > > bpf_links attaching to netns in this case will retu

Re: [PATCH bpf-next v2 04/12] bpf: Add link-based BPF program attachment to network namespace

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:29 AM Jakub Sitnicki wrote: > > Extend bpf() syscall subcommands that operate on bpf_link, that is > LINK_CREATE, LINK_UPDATE, OBJ_GET_INFO, to accept attach types tied to > network namespaces (only flow dissector at the moment). > > Link-based and prog-based attachment c

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread David Ahern
On 6/1/20 3:12 PM, Alexei Starovoitov wrote: > In patch 5 I had to fix: > /data/users/ast/net-next/tools/testing/selftests/bpf/prog_tests/xdp_devmap_attach.c: > In function ‘test_neg_xdp_devmap_helpers’: > /data/users/ast/net-next/tools/testing/selftests/bpf/test_progs.h:106:3: > warning: ‘duration

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Jason A. Donenfeld
On Mon, Jun 1, 2020 at 3:40 PM David Miller wrote: > > From: Michal Kubecek > Date: Mon, 1 Jun 2020 23:13:07 +0200 > > > On Mon, Jun 01, 2020 at 01:33:46PM -0600, Jason A. Donenfeld wrote: > >> This possibility had occurred to me too, which is why I mentioned the > >> project being sufficiently y

Re: [PATCH bpf-next v2 00/12] Link-based program attachment to network namespaces

2020-06-01 Thread Alexei Starovoitov
On Sun, May 31, 2020 at 1:28 AM Jakub Sitnicki wrote: > > One of the pieces of feedback from recent review of BPF hooks for socket > lookup [0] was that new program types should use bpf_link-based > attachment. > > This series introduces new bpf_link type for attaching to network > namespace. All

Re: [PATCH bpf-next] libbpf: add _GNU_SOURCE for reallocarray to ringbuf.c

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 1, 2020 at 1:36 PM Song Liu wrote: > > On Mon, Jun 1, 2020 at 1:26 PM Andrii Nakryiko wrote: > > > > On systems with recent enough glibc, reallocarray compat won't kick in, so > > reallocarray() itself has to come from stdlib.h include. But _GNU_SOURCE is > > necessary to enable it. S

Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > Currenty lsm uses bpf_tracing_func_proto helpers which do > > not include stack trace or perf event output. It's useful > > to have those for bpftrace lsm support [1]. > > > > Using tracin

Re: [net-next 10/11] net/mlx5e: kTLS, Add kTLS RX resync support

2020-06-01 Thread Jakub Kicinski
On Sun, 31 May 2020 15:06:28 +0300 Boris Pismenny wrote: > On 30/05/2020 0:50, Jakub Kicinski wrote: > > On Fri, 29 May 2020 20:44:29 + Saeed Mahameed wrote: > >>> I thought you said that resync requests are guaranteed to never fail? > >> > >> I didn't say that :), maybe tariq did say this

Re: [PATCH v3 bpf-next 2/2] xdp: rename convert_to_xdp_frame in xdp_convert_buff_to_frame

2020-06-01 Thread Alexei Starovoitov
On Thu, May 28, 2020 at 2:12 PM Jesper Dangaard Brouer wrote: > > On Thu, 28 May 2020 22:47:29 +0200 > Lorenzo Bianconi wrote: > > > In order to use standard 'xdp' prefix, rename convert_to_xdp_frame > > utility routine in xdp_convert_buff_to_frame and replace all the > > occurrences > > > > Sign

Re: [PATCH v2 net-next 0/3] Extending bpf_setsockopt with SO_BINDTODEVICE sockopt

2020-06-01 Thread Alexei Starovoitov
On Sat, May 30, 2020 at 2:11 PM Ferenc Fejes wrote: > > This option makes it possible to programatically bind sockets > to netdevices. With the help of this option sockets > of VRF unaware applications could be distributed between > multiple VRFs with an eBPF program. This lets the applications >

Re: [PATCH bpf-next v2 1/3] sock: move sock_valbool_flag to header

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 1, 2020 at 1:32 PM Alexei Starovoitov wrote: > > On Wed, May 27, 2020 at 1:00 PM Dmitry Yakunin wrote: > > > > This is preparation for usage in bpf_setsockopt. > > > > Signed-off-by: Dmitry Yakunin > > Acked-by: Martin KaFai Lau > > Applied the set. Thanks I had to drop it due to n

net-next is CLOSED

2020-06-01 Thread David Miller
The net-next tree is CLOSED, submit bug fixes only at this time. Alexei has told me that the bpf-next pull request is pending and I will take that in when I get it from him. Thanks.

Re: [PATCH net-next] af-packet: new flag to indicate all csums are good

2020-06-01 Thread David Miller
From: Victor Julien Date: Mon, 1 Jun 2020 22:49:37 +0200 > @@ -472,6 +472,12 @@ TP_STATUS_CSUM_VALID This flag indicates that at > least the transport > validated on the kernel side. If the flag is not set > then we are free to check the checksum

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Jakub Kicinski
On Mon, 1 Jun 2020 08:39:18 +0200 Jiri Pirko wrote: > > If the permanent (NVRAM) parameter is true, all loaded new drivers > > will indicate support for this feature and set the runtime value to > > true by default. The runtime value would not be true if any loaded > > driver is too old or has set

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread David Miller
From: Michal Kubecek Date: Mon, 1 Jun 2020 23:13:07 +0200 > On Mon, Jun 01, 2020 at 01:33:46PM -0600, Jason A. Donenfeld wrote: >> This possibility had occurred to me too, which is why I mentioned the >> project being sufficiently young that this can work out. It's not >> actually in any LTS yet,

[PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto offload.

2020-06-01 Thread Huy Nguyen
During IPsec performance testing, we see bad ICMP checksum. The error packet has duplicated ESP trailer due to double validate_xmit_xfrm calls. The first call is from ip_output, but the packet cannot be sent because netif_xmit_frozen_or_stopped is true and the packet gets dev_requeue_skb. The sec

Re: [PATCH stable-4.19.y] net: phy: reschedule state machine if AN has not completed in PHY_AN state

2020-06-01 Thread Vladimir Oltean
On Tue, 2 Jun 2020 at 00:21, Russell King - ARM Linux admin wrote: > > On Mon, Jun 01, 2020 at 11:57:30PM +0300, Vladimir Oltean wrote: > > On Mon, 1 Jun 2020 at 03:28, Russell King - ARM Linux admin > > wrote: > > > And yes, I do have some copper SFP modules that have an (inaccessible) > > > AR8

Re: [PATCH bpf-next RFC 2/3] bpf: devmap dynamic map-value storage area based on BTF

2020-06-01 Thread Alexei Starovoitov
On Fri, May 29, 2020 at 05:59:45PM +0200, Jesper Dangaard Brouer wrote: > + > +/* Expected BTF layout that match struct bpf_devmap_val */ > +static const struct expect layout[] = { > + {BTF_KIND_INT, true,0, 4, "ifindex"}, > + {BTF_KIND_UNION,false, 32, 4

Re: [bpf-next PATCH 2/3] bpf: fix running sk_skb program types with ktls

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 1, 2020 at 8:20 AM John Fastabend wrote: > > > @@ -1793,11 +1795,12 @@ int tls_sw_recvmsg(struct sock *sk, > > > > > > if (to_decrypt <= len && !is_kvec && !is_peek && > > > ctx->control == TLS_RECORD_TYPE_DATA && > > > - prot->version != TLS_1

Re: [PATCH stable-4.19.y] net: phy: reschedule state machine if AN has not completed in PHY_AN state

2020-06-01 Thread Russell King - ARM Linux admin
On Mon, Jun 01, 2020 at 11:57:30PM +0300, Vladimir Oltean wrote: > On Mon, 1 Jun 2020 at 03:28, Russell King - ARM Linux admin > wrote: > > And yes, I do have some copper SFP modules that have an (inaccessible) > > AR803x PHY on them - Microtik S-RJ01 to be exact. I forget exactly > > which varia

Re: [PATCH v3 net-next 12/13] net: dsa: felix: move probing to felix_vsc9959.c

2020-06-01 Thread Jakub Kicinski
On Sun, 31 May 2020 15:26:39 +0300 Vladimir Oltean wrote: > From: Vladimir Oltean > > Felix is not actually meant to be a DSA driver only for the switch > inside NXP LS1028A, but an umbrella for all Vitesse / Microsemi / > Microchip switches that are register-compatible with Ocelot and that are >

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Jason A. Donenfeld
On Mon, Jun 1, 2020 at 3:13 PM Michal Kubecek wrote: > It's not only about stable. The code has been backported e.g. into SLE15 > SP2 and openSUSE Leap 15.2 kernels which which are deep in RC phase so > that we would face the choice between backporting this huge patch in > a maintenance update and

Re: [PATCH v3 net-next 13/13] net: dsa: felix: introduce support for Seville VSC9953 switch

2020-06-01 Thread Jakub Kicinski
On Sun, 31 May 2020 15:26:40 +0300 Vladimir Oltean wrote: > From: Maxim Kochetkov > > This is another switch from Vitesse / Microsemi / Microchip, that has > 10 port (8 external, 2 internal) and is integrated into the Freescale / > NXP T1040 PowerPC SoC. It is very similar to Felix from NXP LS102

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Jason A. Donenfeld
Hi Dave, On Mon, Jun 1, 2020 at 2:56 PM David Miller wrote: > Jason, I'm not discussing this. > > I have to backport these fixes and it makes more work for me, as well > as others. As I said earlier, no problem, and I understand. > I'm also quite sad that the most important thing you could find

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Michal Kubecek
On Mon, Jun 01, 2020 at 01:33:46PM -0600, Jason A. Donenfeld wrote: > Hi Dave, > > On Mon, Jun 1, 2020 at 12:00 PM David Miller wrote: > > This is going to make nearly every -stable backport not apply cleanly, > > which is a severe burdon for everyone having to maintain stable trees. > > This po

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread Alexei Starovoitov
On Fri, May 29, 2020 at 3:07 PM David Ahern wrote: > > Implementation of Daniel's proposal for allowing DEVMAP entries to be > a device index, program fd pair. > > Programs are run after XDP_REDIRECT and have access to both Rx device > and Tx device. > > v4 > - moved struct bpf_devmap_val from uap

Re: [PATCH 01/12] xen/manage: keep track of the on-going suspend mode

2020-06-01 Thread Agarwal, Anchal
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 5/19/20 7:24 PM, Anchal Agarwal wrote: > > +enum suspend_modes { > + NO_SUSPEND = 0, > +

Re: [PATCH stable-4.19.y] net: phy: reschedule state machine if AN has not completed in PHY_AN state

2020-06-01 Thread Vladimir Oltean
On Mon, 1 Jun 2020 at 03:28, Russell King - ARM Linux admin wrote: > > On Mon, Jun 01, 2020 at 12:00:16AM +0300, Vladimir Oltean wrote: > > This is all relevant because our options for the stable trees boil > > down to 2 choices: > > - Revert f62265b53ef34a372b657c99e23d32e95b464316, fix an API m

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread David Miller
Jason, I'm not discussing this. I have to backport these fixes and it makes more work for me, as well as others. I'm also quite sad that the most important thing you could find to work on was figuring out how many columns should be in a line.

  1   2   3   >