Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

Mon, Jun 01, 2020 at 08:18:19AM CEST, j...@resnulli.us wrote: >Sun, May 31, 2020 at 09:03:39AM CEST, vasundhara-v.vo...@broadcom.com wrote: >>Live device reset capability allows the users to reset the device in real >>time. For example, after flashing a new firmware image, this feature allows >>a u

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

Wed, May 27, 2020 at 11:16:08PM CEST, k...@kernel.org wrote: >On Wed, 27 May 2020 13:57:11 -0700 Michael Chan wrote: >> On Wed, May 27, 2020 at 1:14 PM Jakub Kicinski wrote: >> > On Wed, 27 May 2020 09:07:09 +0530 Vasundhara Volam wrote: >> > > Here is a sample sequence of commands to do a "live

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

Wed, May 27, 2020 at 10:57:11PM CEST, michael.c...@broadcom.com wrote: >On Wed, May 27, 2020 at 1:14 PM Jakub Kicinski wrote: >> >> On Wed, 27 May 2020 09:07:09 +0530 Vasundhara Volam wrote: >> > Here is a sample sequence of commands to do a "live reset" to get some >> > clear idea. >> > Note that

[PATCH net-next 0/1] wireguard column reformatting for end of cycle

Hey Dave, This is a series of 1, and the sole patch inside of it has justification regarding that patch itself. But I thought I'd mention in the cover letter that this is being sent right at the tail end of the net-next cycle, before you close it tomorrow afternoon, so that when net-next subsequen

Re: [net-next 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x)

Sat, May 30, 2020 at 05:54:29PM CEST, ido...@idosch.org wrote: >On Sat, May 30, 2020 at 05:52:31PM +0300, Vadym Kochan wrote: [...] >> > WARNING: do not add new typedefs >> > #1064: FILE: drivers/net/ethernet/marvell/prestera/prestera_hw.h:32: >> > +typedef void (*prestera_event_cb_t) >> I may b

Re: [PATCH v3 net-next 1/6] devlink: Add 'enable_live_dev_reset' generic parameter.

Sun, May 31, 2020 at 09:03:40AM CEST, vasundhara-v.vo...@broadcom.com wrote: >This parameter controls the device's live reset capability. When >enabled, a user can issue a separate command like 'ethtool --reset' >or 'devlink dev reload' to reset the entire device in real time. > >This parameter can

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

Sun, May 31, 2020 at 09:03:39AM CEST, vasundhara-v.vo...@broadcom.com wrote: >Live device reset capability allows the users to reset the device in real >time. For example, after flashing a new firmware image, this feature allows >a user to initiate the reset immediately from a separate command, to

[PATCH v2 2/2] vhost: convert get_user_pages() --> pin_user_pages()

This code was using get_user_pages*(), in approximately a "Case 5" scenario (accessing the data within a page), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful ba

[PATCH v2 0/2] vhost, docs: convert to pin_user_pages(), new "case 5"

This is based on Linux 5.7, plus one prerequisite patch: "mm/gup: update pin_user_pages.rst for "case 3" (mmu notifiers)" [1] Changes since v1: removed references to set_page_dirty*(), in response to Souptick Joarder's review (thanks!). Cover letter for v1, edited/updated slightly: It recentl

[PATCH v2 1/2] docs: mm/gup: pin_user_pages.rst: add a "case 5"

There are four cases listed in pin_user_pages.rst. These are intended to help developers figure out whether to use get_user_pages*(), or pin_user_pages*(). However, the four cases do not cover all the situations. For example, drivers/vhost/vhost.c has a "pin, write to page, set page dirty, unpin" c

Re: [PATCH] staging: qlge: qlge_main.c: fixed spaces coding style issues

On 2020-05-29 17:17 +0200, Jil Rouceau wrote: > Fixed the missing spaces before and after binary operators. > > Signed-off-by: Jil Rouceau This patch does not apply cleanly. I think your base tree is missing commit ec269f1250c6 ("staging: qlge: Remove unnecessary spaces in qlge_main.c").

Re: [PATCH 1/2] docs: mm/gup: pin_user_pages.rst: add a "case 5"

On 2020-05-31 00:11, Souptick Joarder wrote: ... diff --git a/Documentation/core-api/pin_user_pages.rst b/Documentation/core-api/pin_user_pages.rst index 4675b04e8829..b9f2688a2c67 100644 --- a/Documentation/core-api/pin_user_pages.rst +++ b/Documentation/core-api/pin_user_pages.rst @@ -171,6 +1

Re: [PATCH net-next v4] hinic: add set_channels ethtool_ops support

On Mon, Jun 01, 2020 at 09:42:06AM +, Luo bin wrote: > add support to change TX/RX queue number with ethtool -L ethx combined > > Signed-off-by: Luo bin > --- [...] The patch looks correct but I'm not sure how is this change > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_tx.c > b/d

Re: [net-next 0/2] net: sched: cls-flower: add support for port-based fragment filtering

On 5/29/20 7:52 PM, David Miller wrote: > From: Jason Baron > Date: Wed, 27 May 2020 16:25:28 -0400 > >> Port based allow rules must currently allow all fragments since the >> port number is not included in the 1rst fragment. We want to restrict >> allowing all fragments by inclucding the port

Re: [PATCH net] ipv6: fix IPV6_ADDRFORM operation logic

cc Frantisek On Mon, 1 Jun 2020 at 12:00, Hangbin Liu wrote: > > Socket option IPV6_ADDRFORM supports UDP/UDPLITE and TCP at present. > Previously the checking logic looks like: > if (sk->sk_protocol == IPPROTO_UDP || sk->sk_protocol == IPPROTO_UDPLITE) > do_some_check; > else if (sk->sk_

[PATCH net] ipv6: fix IPV6_ADDRFORM operation logic

Socket option IPV6_ADDRFORM supports UDP/UDPLITE and TCP at present. Previously the checking logic looks like: if (sk->sk_protocol == IPPROTO_UDP || sk->sk_protocol == IPPROTO_UDPLITE) do_some_check; else if (sk->sk_protocol != IPPROTO_TCP) break; After commit b6f6118901d1 ("ipv6:

Re: [PATCH net-next 2/2] net/mlx5e: add ct_metadata.nat support in ct offload

On 5/31/2020 4:01 PM, Oz Shlomo wrote: > Hi Wenxu, > > On 5/28/2020 10:15 AM, we...@ucloud.cn wrote: >> From: wenxu >> >> In the ct offload all the conntrack entry offload  rules >> will be add to both ct ft and ct_nat ft twice. >> It is not makesense. The ct_metadat.nat will tell driver > > Add

Re: [PATCH net v3] cxgb4/chcr: Enable ktls settings at run time

Hi Rohit, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20200529] [cannot apply to net/master cryptodev/master crypto/master linus/master ipvs/master v5.7-rc7 v5.7-rc6 v5.7-rc5 v5.7] [if your patch is applied to the wrong git tree, please drop us a note to hel

[PATCH net-next v4] hinic: add set_channels ethtool_ops support

add support to change TX/RX queue number with ethtool -L ethx combined Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 40 +++ .../net/ethernet/huawei/hinic/hinic_main.c| 2 +- drivers/net/ethernet/huawei/hinic/hinic_tx.c | 5 +++ 3 files changed

bpf-next is CLOSED

please fixes only for the next ~two weeks.

Re: [PATCH stable-4.19.y] net: phy: reschedule state machine if AN has not completed in PHY_AN state

On Mon, Jun 01, 2020 at 12:00:16AM +0300, Vladimir Oltean wrote: > On Sun, 31 May 2020 at 03:19, Russell King - ARM Linux admin > wrote: > > > > On Sun, May 31, 2020 at 12:43:15AM +0300, Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > > > In kernel 4.19 (and probably earlier too) there

[no subject]

-- Entre em contato comigo para obter a herança de sua família avaliada em sete milhões de os estados contatam meu email confidencial aqui para mais detalhes: coulibalyk...@yahoo.com Muito obrigado antecipadamente. Barrister.Coulibaly Kone

Re: [PATCH v2 1/2] iproute2: ip addr: Organize flag properties structurally

On 5/27/20 12:03 PM, Ian K. Coolidge wrote: > This creates a nice systematic way to check that the various flags are > mutable from userspace and that the address family is valid. > > Mutability properties are preserved to avoid introducing any behavioral > change in this CL. However, previously,

Re: [PATCH v2 iproute2-next 1/1] tc: report time an action was first used

On 5/27/20 7:22 PM, Roman Mashak wrote: > Have print_tm() dump firstuse value along with install, lastuse > and expires. > > v2: Resubmit after 'master' merged into next > > Signed-off-by: Roman Mashak > --- > tc/tc_util.c | 4 > 1 file changed, 4 insertions(+) > applied to iproute2-next

[PATCH bpf-next 6/6] samples/bpf: xdp_redirect_cpu: load an eBPF program on cpumap

Extend xdp_redirect_cpu_{usr,kern}.c adding the possibility to load a XDP program on cpumap entries Signed-off-by: Lorenzo Bianconi --- samples/bpf/xdp_redirect_cpu_kern.c | 34 ++--- samples/bpf/xdp_redirect_cpu_user.c | 106 2 files changed, 119 insertions(+),

[PATCH bpf-next 2/6] samples/bpf: xdp_redirect_cpu_user: do not update bpf maps in option loop

Do not update xdp_redirect_cpu maps running while option loop but defer it after all available options have been parsed. This is a preliminary patch to pass the program name we want to attach to the map entries as a user option Signed-off-by: Lorenzo Bianconi --- samples/bpf/xdp_redirect_cpu_use

[PATCH bpf-next 3/6] cpumap: formalize map value as a named struct

As it has been already done for devmap, introduce 'struct bpf_cpumap_val' to formalize the expected values that can be passed in for a CPUMAP. Update cpumap code to use the struct. Signed-off-by: Lorenzo Bianconi --- kernel/bpf/cpumap.c | 30 ++ 1 file changed, 18 ins

[PATCH bpf-next 4/6] bpf: cpumap: add the possibility to attach an eBPF program to cpumap

Introduce the capability to attach an eBPF program to cpumap entries. The idea behind this feature is to add the possibility to define on which CPU run the eBPF program if the underlying hw does not support RSS. Current supported verdicts are XDP_DROP and XDP_PASS Signed-off-by: Lorenzo Bianconi

[PATCH bpf-next 5/6] bpf: cpumap: implement XDP_REDIRECT for eBPF programs attached to map entries

Add XDP_REDIRECT support for eBPF programs attached to cpumap entries Signed-off-by: Lorenzo Bianconi --- include/trace/events/xdp.h | 12 kernel/bpf/cpumap.c| 21 + 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/include/trace/events/xdp.

[PATCH bpf-next 0/6] introduce support for XDP programs in CPUMAP

Similar to what David Ahern proposed in [1] for DEVMAPs, introduce the capability to attach and run a XDP program to CPUMAP entries. The idea behind this feature is to add the possibility to define on which CPU run the eBPF program if the underlying hw does not support RSS. I respin patch 1/6 from

[PATCH bpf-next 1/6] net: Refactor xdp_convert_buff_to_frame

From: David Ahern Move the guts of xdp_convert_buff_to_frame to a new helper, xdp_update_frame_from_buff so it can be reused removing code duplication Suggested-by: Jesper Dangaard Brouer Co-developed-by: Lorenzo Bianconi Signed-off-by: Lorenzo Bianconi Signed-off-by: David Ahern --- includ

Re: pull-request: mac80211-next 2020-05-31

From: Johannes Berg Date: Sun, 31 May 2020 11:53:20 +0200 > My apologies that this comes so late, it took me much longer than > I had anticipated to pull together the 6 GHz changes between the > overlaps that Qualcomm and we at Intel had, since we both had much > of this implemented, though with

Re: [PATCH AUTOSEL 5.4 07/26] net sched: fix reporting the first-time use timestamp

Hi! > From: Roman Mashak > > [ Upstream commit b15e62631c5f19fea9895f7632dae9c1b27fe0cd ] > > When a new action is installed, firstuse field of 'tcf_t' is explicitly set > to 0. Value of zero means "new action, not yet used"; as a packet hits the > action, 'firstuse' is stamped with the current

Re: [PATCH v2] devres: keep both device name and resource name in pretty name

On Mon, 1 Jun 2020 at 00:05, Andy Shevchenko wrote: > > > > On Sunday, May 31, 2020, Vladimir Oltean wrote: >> >> From: Vladimir Oltean >> >> Sometimes debugging a device is easiest using devmem on its register >> map, and that can be seen with /proc/iomem. But some device drivers have >> many m

Re: [PATCH stable-4.19.y] net: phy: reschedule state machine if AN has not completed in PHY_AN state

On Sun, 31 May 2020 at 03:19, Russell King - ARM Linux admin wrote: > > On Sun, May 31, 2020 at 12:43:15AM +0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > In kernel 4.19 (and probably earlier too) there are issues surrounding > > the PHY_AN state. > > > > For example, if a PHY is

[PATCH v2 net-next] net: dsa: sja1105: suppress -Wmissing-prototypes in sja1105_vl.c

From: Vladimir Oltean Newer C compilers are complaining about the fact that there are no function prototypes in sja1105_vl.c for the non-static functions. Give them what they want. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli --- drivers/net/dsa/sja1105/sja1105_vl.c | 2 +- dr

[PATCH v2] devres: keep both device name and resource name in pretty name

From: Vladimir Oltean Sometimes debugging a device is easiest using devmem on its register map, and that can be seen with /proc/iomem. But some device drivers have many memory regions. Take for example a networking switch. Its memory map used to look like this in /proc/iomem: 1fc00-1fc3f

Re: [GIT] Networking

The pull request you sent on Sat, 30 May 2020 22:13:09 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/19835b1ba6b1f2d3fb5aefffa01ebd626513ff4a Thank you! -- Deet-doot-dot,

linux-next: Signed-off-by missing for commit in the net tree

Hi all, Commit 02c71b144c81 ("l2tp: do not use inet_hash()/inet_unhash()") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpbmEwZaF2Vp.pgp Description: OpenPGP digital signature

[PATCH net v3] cxgb4/chcr: Enable ktls settings at run time

Current design enables ktls setting from start, which is not efficient. Now the feature will be enabled when user demands TLS offload on any interface. v1->v2: - taking ULD module refcount till any single connection exists. - taking rtnl_lock() before clearing tls_devops. v2->v3: - cxgb4 is now r

Re: [PATCH RFT] ravb: Mask PHY mode to avoid inserting delays twice

Hello! On 31.05.2020 7:51, David Miller wrote: Until recently, the Micrel KSZ9031 PHY driver ignored any PHY mode ("RGMII-*ID") settings, but used the hardware defaults, augmented by explicit configuration of individual skew values using the "*-skew-ps" DT properties. The lack of PHY mode supp

Re: new seccomp mode aims to improve performance

On Fri, May 29, 2020 at 12:27:03PM -0700, Kees Cook wrote: > On Fri, May 29, 2020 at 09:09:28AM -0700, Kees Cook wrote: > > On Fri, May 29, 2020 at 08:43:56AM -0700, Alexei Starovoitov wrote: > > > I don't think your hunch at where cpu is spending cycles is correct. > > > Could you please do two ex

[PATCH] bpf: Use tracing helpers for lsm programs

Currenty lsm uses bpf_tracing_func_proto helpers which do not include stack trace or perf event output. It's useful to have those for bpftrace lsm support [1]. Using tracing_prog_func_proto helpers for lsm programs. [1] https://github.com/iovisor/bpftrace/pull/1347 Cc: KP Singh Signed-off-by: J

Re: [PATCH 7/9] bpf: Compile the BTF id whitelist data in vmlinux

On Fri, May 29, 2020 at 01:48:58PM -0700, Andrii Nakryiko wrote: > On Thu, May 28, 2020 at 10:24 AM Jiri Olsa wrote: > > > > On Thu, May 14, 2020 at 03:46:26PM -0700, Andrii Nakryiko wrote: > > > > SNIP > > > > > > I was thinking of putting the names in __init section and generate the > > > > BTF

Re: [PATCH] conn_client: Add check for rxpc channel

Hi, Note that "conn_client:" isn't a suitable tag for the subject. You should use "rxrpc:" instead. How did you find this by the way? You shouldn't get a NULL pointer there. Either the call is waiting for a channel to be assigned (in which case the condition on: if (!list_empty(&call->

Re: netif_device_present() and Runtime PM / PCI D3

On Sun, May 31, 2020 at 02:07:46PM +0200, Heiner Kallweit wrote: > I just wonder about the semantics of netif_device_present(). > If a device is in PCI D3 (e.g. being runtime-suspended), then it's > not accessible. So is it present or not? > The description of the function just mentions the obvious

RE: [net-next 00/14][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-31

> -Original Message- > From: Kirsher, Jeffrey T > Sent: Sunday, May 31, 2020 05:36 > To: da...@davemloft.net > Cc: Kirsher, Jeffrey T ; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com > Subject: [net-next 00/14][pull request] 100GbE Intel Wired LAN Driver Updates > 2020-0

[net-next 02/14] ice: support adding 16 unicast/multicast filter on untrusted VF

From: Paul Greenwalt Allow untrusted VF to add 16 unicast/multicast filters. VF uses 1 filter for the default/perm_addr/LAA MAC, 1 for broadcast, and 16 additional unicast/multicast filters. Signed-off-by: Paul Greenwalt Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/et

[net-next 09/14] ice: Allow VF to request reset as soon as it's initialized

From: Brett Creeley A VF driver has the ability to request reset via VIRTCHNL_OP_RESET_VF. This is a required step in VF driver load. Currently, the PF is only allowing a VF to request reset using this method after the VF has already communicated resources via VIRTCHNL_OP_GET_VF_RESOURCES. Howeve

[net-next 04/14] ice: Increase timeout after PFR

From: Dan Nowlin To allow for resets during package download, increase the timeout period after performing a PFR. The time waited is the global config lock timeout plus the normal PFSWR timeout. Signed-off-by: Dan Nowlin Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/et

[net-next 13/14] ice: fix aRFS after flow director delete

From: Henry Tieman The logic was missing for adding back perfect flows after flow director filter delete. The code now adds perfect flows into the HW tables after filter delete. Signed-off-by: Henry Tieman Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/ice/ic

[net-next 12/14] ice: Use coalesce values from q_vector 0 when increasing q_vectors

From: Brett Creeley Currently when a VSI is built (i.e. reset, set channels, etc.) the coalesce settings will be preserved in most cases. However, when the number of q_vectors are increased the settings for the new q_vectors will be set to the driver defaults of AIM on, Rx/Tx ITR 50, and INTRL 0.

[net-next 03/14] ice: Fix transmit for all software offloaded VLANs

From: Brett Creeley Currently the driver does not recognize when there is an 802.1AD VLAN tag right after the dmac/smac (outermost VLAN tag). If any DCB map is applied and/or DCB is enabled this is causing the hardware to insert a VLAN 0 tag after the 802.1AD VLAN tag that is already in the packe

[net-next 00/14][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-31

This series contains updates to the ice driver only. Brett modifies the driver to allow users to clear a VF's administratively set MAC address on the PF. Fixes the driver to recognize an existing VLAN tag when DMAC/SMAC is enabled in a packet. Fixes an issue, so that VF's are reset after any VF p

[net-next 10/14] ice: fix function signature style format

From: Bruce Allan Where possible, cuddle multiple lines of function signatures to be consistent throughout the code. Signed-off-by: Bruce Allan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_controlq.c | 3 +-- drivers/net/ethernet/intel/ice/ice_

[net-next 11/14] ice: fix PCI device serial number to be lowercase values

From: Paul M Stillwell Jr Commit ceb2f00707f9 ("ice: Use pci_get_dsn()") changed the code to use a new function to get the Device Serial Number. It also changed the case of the filename for loading a package on a specific NIC from lowercase to uppercase. Change the filename back to lowercase sinc

[net-next 14/14] ice: Ignore EMODE when setting PHY config

From: Chinh T Cao When setting the PHY cfg (CQ cmd 0x0601), if the firmware responds with an EMODE error, software will ignore the error as it simply means that manageability (ex: BMC) is in control of the link and that the new setting may not be applied. Signed-off-by: Chinh T Cao Signed-off-b

[net-next 08/14] ice: Fix inability to set channels when down

From: Jesse Brandeburg Currently the driver prevents a user from doing modprobe ice ethtool -L eth0 combined 5 ip link set eth0 up The ethtool command fails, because the driver is checking to see if the interface is down before allowing the get_channels to proceed (even for a set_channels). Rem

[net-next 05/14] ice: Update ICE_PHY_TYPE_HIGH_MAX_INDEX value

From: Chinh T Cao As currently, we are supporting only 5 PHY_SPEEDs for phy_type_high. Thus, we should adjust the value of ICE_PHY_TYPE_HIGH_MAX_INDEX to 5. Signed-off-by: Chinh T Cao Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 2

[net-next 01/14] ice: allow host to clear administratively set VF MAC

From: Brett Creeley Currently a user is not allowed to clear a VF's administratively set MAC on the PF. Fix this by allowing an all zero MAC address via "ip link set ${pf_eth} vf ${vf_id} mac 00:00:00:00:00:00". An example use case for this would be issuing a "virsh shutdown" command on a VM. Th

[net-next 06/14] ice: Reset VF for all port VLAN changes from host

From: Brett Creeley Currently the PF is modifying the VF's port VLAN on the fly when configured via iproute. This is okay for most cases, but if the VF already has guest VLANs configured the PF has to remove all of those filters so only VLAN tagged traffic that matches the port VLAN will pass. In

[net-next 07/14] ice: Always clear QRXFLXP_CNTXT before writing new value

From: Brett Creeley Always clear the previous value in QRXFLXP_CNTXT before writing a new value. This will make it so re-used queues will not accidentally take the previously configured settings. Signed-off-by: Brett Creeley Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: J

[PATCH v3 net-next 05/13] net: mscc: ocelot: convert QSYS_SWITCH_PORT_MODE and SYS_PORT_MODE to regfields

From: Vladimir Oltean Currently Felix and Ocelot share the same bit layout in these per-port registers, but Seville does not. So we need reg_fields for that. Actually since these are per-port registers, we need to also specify the number of ports, and register size per port, and use the regmap A

[PATCH v3 net-next 10/13] net: mscc: ocelot: extend watermark encoding function

From: Maxim Kochetkov The ocelot_wm_encode function deals with setting thresholds for pause frame start and stop. In Ocelot and Felix the register layout is the same, but for Seville, it isn't. The easiest way to accommodate Seville hardware configuration is to introduce a function pointer for se

[PATCH v3 net-next 12/13] net: dsa: felix: move probing to felix_vsc9959.c

From: Vladimir Oltean Felix is not actually meant to be a DSA driver only for the switch inside NXP LS1028A, but an umbrella for all Vitesse / Microsemi / Microchip switches that are register-compatible with Ocelot and that are using in DSA mode (with an NPI Ethernet port). For the dsa_switch_op

[PATCH v3 net-next 06/13] net: dsa: felix: create a template for the DSA tags on xmit

From: Vladimir Oltean With this patch we try to kill 2 birds with 1 stone. First of all, some switches that use tag_ocelot.c don't have the exact same bitfield layout for the DSA tags. The destination ports field is different for Seville VSC9953 for example. So the choices are to either duplicat

[PATCH v3 net-next 09/13] net: mscc: ocelot: convert SYS_PAUSE_CFG register access to regfield

From: Maxim Kochetkov Seville has a different bitwise layout than Ocelot and Felix. Signed-off-by: Maxim Kochetkov Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli --- Changes in v3: None. Changes in v2: None. drivers/net/dsa/ocelot/felix_vsc9959.c | 3 +++ drivers/net/ethern

[PATCH v3 net-next 03/13] net: mscc: ocelot: convert port registers to regmap

From: Vladimir Oltean At the moment, there are some minimal register differences between VSC7514 Ocelot and VSC9959 Felix. To be precise, the PCS1G registers are missing from Felix because it was integrated with an NXP PCS. But with VSC9953 Seville (not yet introduced), the register differences

[PATCH v3 net-next 01/13] regmap: add helper for per-port regfield initialization

From: Vladimir Oltean Similar to the standalone regfields, add an initializer for the users who need to set .id_size and .id_offset in order to use the regmap_fields_update_bits_base API. Signed-off-by: Vladimir Oltean Link: https://lore.kernel.org/r/20200527234113.2491988-2-olte...@gmail.com S

[PATCH v3 net-next 00/13] New DSA driver for VSC9953 Seville switch

From: Vladimir Oltean Looking at the Felix and Ocelot drivers, Maxim asked if it would be possible to use them as a base for a new driver for the Seville switch inside NXP T1040. Turns out, it is! The result is that the mscc_felix driver was extended to probe on Seville. The biggest challenge se

[PATCH v3 net-next 04/13] soc/mscc: ocelot: add MII registers description

From: Maxim Kochetkov Add the register definitions for the MSCC MIIM MDIO controller in preparation for seville_vsc9959.c to create its accessors for the internal MDIO bus. Since we've introduced elements to ocelot_regfields that are not instantiated by felix and ocelot, we need to define the si

[PATCH v3 net-next 02/13] net: dsa: felix: set proper link speed in felix_phylink_mac_config

From: Vladimir Oltean state->speed holds a value of 10, 100, 1000 or 2500, but SYS_MAC_FC_CFG_FC_LINK_SPEE and DEV_CLOCK_CFG_LINK_SPEED expect a value in the range 0, 1, 2 or 3. Even truncated to 2 bits, we are still writing incorrect values to the registers, but for some reason Felix still work

[PATCH v3 net-next 08/13] net: mscc: ocelot: disable flow control on NPI interface

From: Vladimir Oltean The Ocelot switches do not support flow control on Ethernet interfaces where a DSA tag must be added. If pause frames are enabled, they will be encapsulated in the DSA tag just like regular frames, and the DSA master will not recognize them. Signed-off-by: Vladimir Oltean

[PATCH v3 net-next 11/13] net: dsa: felix: support half-duplex link modes

From: Vladimir Oltean Ping tested: [ 11.808455] mscc_felix :00:00.5 swp0: Link is Up - 1Gbps/Full - flow control rx/tx [ 11.816497] IPv6: ADDRCONF(NETDEV_CHANGE): swp0: link becomes ready [root@LS1028ARDB ~] # ethtool -s swp0 advertise 0x4 [ 18.844591] mscc_felix :00:00.5

[PATCH v3 net-next 07/13] net: mscc: ocelot: split writes to pause frame enable bit and to thresholds

From: Vladimir Oltean We don't want ocelot_port_set_maxlen to enable pause frame TX, just to adjust the pause thresholds. Move the unconditional enabling of pause TX to ocelot_init_port. There is no good place to put such setting because it shouldn't be unconditional. But at the moment it is, we

[PATCH v3 net-next 13/13] net: dsa: felix: introduce support for Seville VSC9953 switch

From: Maxim Kochetkov This is another switch from Vitesse / Microsemi / Microchip, that has 10 port (8 external, 2 internal) and is integrated into the Freescale / NXP T1040 PowerPC SoC. It is very similar to Felix from NXP LS1028A, except that this is a platform device and Felix is a PCI device,

netif_device_present() and Runtime PM / PCI D3

I just wonder about the semantics of netif_device_present(). If a device is in PCI D3 (e.g. being runtime-suspended), then it's not accessible. So is it present or not? The description of the function just mentions the obvious case that the device has been removed from the system. Related is the f

Re: [net-next 10/11] net/mlx5e: kTLS, Add kTLS RX resync support

On 30/05/2020 0:50, Jakub Kicinski wrote: > On Fri, 29 May 2020 20:44:29 + Saeed Mahameed wrote: >>> I thought you said that resync requests are guaranteed to never fail? >> >> I didn't say that :), maybe tariq did say this before my review, > > Boris ;) > I didn't say we are perfect, just

Re: [PATCH net] net/tls: Fix driver request resync

>> >> Yes, although I would phrase it differently: the kernel would indicate to >> the driver, >> that the resync request is wrong, and that it can go back to searching for a >> header. >> If there are any drivers that need an extra check, then we can add it in the >> driver itself. > > I'd rat

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

On Wed, May 27, 2020 at 01:17:42AM -0700, rao.sho...@oracle.com wrote: > From: Rao Shoaib > > This enhancement auto loads transport module when the transport > is set via SO_RDS_TRANSPORT socket option. > > Orabug: 31032127 I think that it is internal to Oracle and should not be in the commit mes

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > 'err' is used uninitialized whenever 'if' condition is true > [-Wsometimes-uninitialized] > if (!priv->dbg_root) { > ^

pull-request: mac80211-next 2020-05-31

Hi Dave, My apologies that this comes so late, it took me much longer than I had anticipated to pull together the 6 GHz changes between the overlaps that Qualcomm and we at Intel had, since we both had much of this implemented, though with a bit different focus (AP/mesh vs. client). But I think it

[PATCH bpf-next v2 00/12] Link-based program attachment to network namespaces

One of the pieces of feedback from recent review of BPF hooks for socket lookup [0] was that new program types should use bpf_link-based attachment. This series introduces new bpf_link type for attaching to network namespace. All link operations are supported. Errors returned from ops follow cgrou

[PATCH bpf-next v2 05/12] bpf, cgroup: Return ENOLINK for auto-detached links on update

Failure to update a bpf_link because it has been auto-detached by a dying cgroup currently results in EINVAL error, even though the arguments passed to bpf() syscall are not wrong. bpf_links attaching to netns in this case will return ENOLINK, which carries the message that the link is no longer a

[PATCH bpf-next v2 04/12] bpf: Add link-based BPF program attachment to network namespace

Extend bpf() syscall subcommands that operate on bpf_link, that is LINK_CREATE, LINK_UPDATE, OBJ_GET_INFO, to accept attach types tied to network namespaces (only flow dissector at the moment). Link-based and prog-based attachment can be used interchangeably, but only one can exist at a time. Atte

[PATCH bpf-next v2 03/12] flow_dissector: Move out netns_bpf prog callbacks

Move functions to manage BPF programs attached to netns that are not specific to flow dissector to a dedicated module named bpf/net_namespace.c. The set of functions will grow with the addition of bpf_link support for netns attached programs. This patch prepares ground by creating a place for it.

[PATCH bpf-next v2 07/12] bpftool: Extract helpers for showing link attach type

Code for printing link attach_type is duplicated in a couple of places, and likely will be duplicated for future link types as well. Create helpers to prevent duplication. Suggested-by: Andrii Nakryiko Signed-off-by: Jakub Sitnicki --- tools/bpf/bpftool/link.c | 44 -

[PATCH bpf-next v2 01/12] flow_dissector: Pull locking up from prog attach callback

Split out the part of attach callback that happens with attach/detach lock acquired. This structures the prog attach callback in a way that opens up doors for moving the locking out of flow_dissector and into generic callbacks for attaching/detaching progs to netns in subsequent patches. Reviewed-

[PATCH bpf-next v2 06/12] libbpf: Add support for bpf_link-based netns attachment

Add bpf_program__attach_nets(), which uses LINK_CREATE subcommand to create an FD-based kernel bpf_link, for attach types tied to network namespace, that is BPF_FLOW_DISSECTOR for the moment. Signed-off-by: Jakub Sitnicki --- tools/lib/bpf/libbpf.c | 23 ++- tools/lib/bpf/l

[PATCH bpf-next v2 02/12] net: Introduce netns_bpf for BPF programs attached to netns

In order to: (1) attach more than one BPF program type to netns, or (2) support attaching BPF programs to netns with bpf_link, or (3) support multi-prog attach points for netns we will need to keep more state per netns than a single pointer like we have now for BPF flow dissector program. Pre

[PATCH bpf-next v2 10/12] selftests/bpf, flow_dissector: Close TAP device FD after the test

test_flow_dissector leaves a TAP device after it's finished, potentially interfering with other tests that will run after it. Fix it by closing the TAP descriptor on cleanup. Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less mode") Signed-off-by: Jakub Sitnicki --- tools/

[PATCH bpf-next v2 11/12] selftests/bpf: Convert test_flow_dissector to use BPF skeleton

Switch flow dissector test setup from custom BPF object loader to BPF skeleton to save boilerplate and prepare for testing higher-level API for attaching flow dissector with bpf_link. To avoid depending on program order in the BPF object when populating the flow dissector PROG_ARRAY map, change th

[PATCH bpf-next v2 08/12] bpftool: Support link show for netns-attached links

Make `bpf link show` aware of new link type, that is links attached to netns. When listing netns-attached links, display netns inode number as its identifier and link attach type. Sample session: # readlink /proc/self/ns/net net:[4026532251] # bpftool prog show 357: flow_dissector tag a0

[PATCH bpf-next v2 12/12] selftests/bpf: Extend test_flow_dissector to cover link creation

Extend the existing flow_dissector test case to run tests once using direct prog attachments, and then for the second time using indirect attachment via link. The intention is to exercises the newly added high-level API for attaching programs to network namespace with links (bpf_program__attach_ne

[PATCH bpf-next v2 09/12] selftests/bpf: Add tests for attaching bpf_link to netns

Extend the existing test case for flow dissector attaching to cover: - link creation, - link updates, - link info querying, - mixing links with direct prog attachment. Signed-off-by: Jakub Sitnicki --- .../bpf/prog_tests/flow_dissector_reattach.c | 588 -- 1 file changed, 5

Re: [PATCH net-next v2] net/mlx5e: add conntrack offload rules only in ct or ct_nat flow table

Hi Wenxu, Just saw v2. Please see my comment in v1. On 5/30/2020 9:27 AM, we...@ucloud.cn wrote: From: wenxu In the ct offload all the conntrack entry offload rules will be add to both ct ft and ct_nat ft twice. It is not make sense. The driver can distinguish NAT from non-NAT conntrack throu

Re: [PATCH net-next 2/2] net/mlx5e: add ct_metadata.nat support in ct offload

Hi Wenxu, On 5/28/2020 10:15 AM, we...@ucloud.cn wrote: From: wenxu In the ct offload all the conntrack entry offload rules will be add to both ct ft and ct_nat ft twice. It is not makesense. The ct_metadat.nat will tell driver Adding the connection to both tables is required because the us

Re: [PATCH net-next 1/6] r8169: change driver data type

On 31.05.2020 07:17, Stephen Hemminger wrote: > On Sat, 30 May 2020 23:54:36 +0200 > Heiner Kallweit wrote: > >> Change driver private data type to struct rtl8169_private * to avoid >> some overhead. >> >> Signed-off-by: Heiner Kallweit >> --- > > Are you sure about this. Using netdev_priv() is

[PATCH v3 net-next 6/6] bnxt_en: Check if fw_live_reset is allowed before doing ETHTOOL_RESET

If device does not allow fw_live_reset, issue FW_RESET command without graceful flag, which requires a driver reload to reset the firmware. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan Reviewed-by: Edwin Peer --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 17 +--

[PATCH v3 net-next 5/6] bnxt_en: Use 'allow_live_dev_reset' devlink parameter.

This parameter allows the user to prevent live reset of the device temporarily by setting it to false. For example, if the host is running a mission critical application, user can set this parameter to false until the application has completed, to avoid a potential device reset disrupting it. Sign

  1   2   >