RE: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-24 Thread Jianyong Wu
Hi Richard, > -Original Message- > From: Richard Cochran > Sent: Monday, May 25, 2020 2:16 PM > To: Jianyong Wu > Cc: m...@kernel.org; netdev@vger.kernel.org; yangbo...@nxp.com; > john.stu...@linaro.org; t...@linutronix.de; pbonz...@redhat.com; > sean.j.christopher...@intel.com; Mark Rut

[PATCH] drivers: ipa: print dev_err info accurately

2020-05-24 Thread Wang Wenhu
Print certain name string instead of hard-coded "memory" for dev_err output, which would be more accurate and helpful for debugging. Signed-off-by: Wang Wenhu Cc: Alex Elder --- drivers/net/ipa/ipa_clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/i

Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-24 Thread Richard Cochran
On Mon, May 25, 2020 at 04:50:28AM +, Jianyong Wu wrote: > How about adding an extra argument in struct ptp_clock_info to serve as a > flag, then we can control this flag using IOCTL to determine the counter type. no, No, NO! > > From your description, this "flag" really should be a module p

Re: 8111F issue

2020-05-24 Thread Heiner Kallweit
On 24.05.2020 21:54, Łukasz Kalisz wrote: > Hello > > > > I have been using several boards with reraltek ethernet > > and everyone was just working > > now I got board wirh 8111F (previous working was 8111E) and I'm loosing > connection once a week or even earlier > > I tried using 8169 and

[PATCHv2 ipsec] xfrm: fix a warning in xfrm_policy_insert_list

2020-05-24 Thread Xin Long
This waring can be triggered simply by: # ip xfrm policy update src 192.168.1.1/24 dst 192.168.1.2/24 dir in \ priority 1 mark 0 mask 0x10 #[1] # ip xfrm policy update src 192.168.1.1/24 dst 192.168.1.2/24 dir in \ priority 2 mark 0 mask 0x1 #[2] # ip xfrm policy update src 192.16

[PATCH net-next] net: Avoid spurious rx_dropped increases with tap and rx_handler

2020-05-24 Thread Benjamin Poirier
Consider an skb which doesn't match a ptype_base/ptype_specific handler. If this skb is delivered to a ptype_all handler, it does not count as a drop. However, if the skb is also processed by an rx_handler which returns RX_HANDLER_PASS, the frame is now counted as a drop because pt_prev was reset.

RE: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-24 Thread Jianyong Wu
Hi Richard, > -Original Message- > From: Richard Cochran > Sent: Sunday, May 24, 2020 10:11 AM > To: Jianyong Wu > Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; > t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com; > m...@kernel.org; Mark Ru

Re: [RFC 08/11] net: phy: Allow mdio buses to auto-probe c45 devices

2020-05-24 Thread Jeremy Linton
Hi, On 5/24/20 9:44 AM, Andrew Lunn wrote: +++ b/include/linux/phy.h @@ -275,6 +275,11 @@ struct mii_bus { int reset_delay_us; /* RESET GPIO descriptor pointer */ struct gpio_desc *reset_gpiod; + /* bus capabilities, used for probing */ + enum { +

Re: [RFC 07/11] net: phy: reset invalid phy reads of 0 back to 0xffffffff

2020-05-24 Thread Jeremy Linton
Hi, On 5/23/20 1:44 PM, Russell King - ARM Linux admin wrote: On Fri, May 22, 2020 at 04:30:55PM -0500, Jeremy Linton wrote: MMD's in the device list sometimes return 0 for their id. When that happens lets reset the id back to 0xfff so that we don't get a stub device created for it. This i

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-24 Thread Jeremy Linton
Hi, On 5/23/20 1:37 PM, Russell King - ARM Linux admin wrote: On Fri, May 22, 2020 at 04:30:52PM -0500, Jeremy Linton wrote: Until this point, we have been sanitizing the c22 regs presence bit out of all the MMD device lists. This is incorrect as it causes the 0x checks to incorrectly f

RE: [EXT] Re: [PATCH net 2/4] dt-bindings: fec: update the gpr property

2020-05-24 Thread Andy Duan
From: Fuzzey, Martin Sent: Saturday, May 23, 2020 6:16 PM > > - gpr: phandle of SoC general purpose register mode. Required for > > wake on LAN > > - on some SoCs > > + on some SoCs. Register bits of stop mode control, the format is > > + <&gpr req_gpr req_bit>. > > +gpr is the p

general protection fault in sock_recvmsg

2020-05-24 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:caffb99b Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15a7444110 kernel config: https://syzkaller.appspot.com/x/.config?x=c33c7f7c5471fd39 das

Re: [PATCH v2] xfrm: policy: Fix xfrm policy match

2020-05-24 Thread Yuehaibing
On 2020/5/23 17:02, Xin Long wrote: > On Fri, May 22, 2020 at 8:39 PM Yuehaibing wrote: >> >> On 2020/5/22 13:49, Xin Long wrote: >>> On Fri, May 22, 2020 at 9:45 AM Yuehaibing wrote: On 2020/5/21 14:49, Xin Long wrote: > On Tue, May 19, 2020 at 4:53 PM Steffen Klassert > wrote

Re: [RFC 02/11] net: phy: Simplify MMD device list termination

2020-05-24 Thread Jeremy Linton
Hi, On 5/23/20 1:36 PM, Russell King - ARM Linux admin wrote: On Fri, May 22, 2020 at 04:30:50PM -0500, Jeremy Linton wrote: Since we are already checking for *devs == 0 after the loop terminates, we can add a mostly F's check as well. With that change we can simplify the return/break sequence

Re: [RFC 01/11] net: phy: Don't report success if devices weren't found

2020-05-24 Thread Jeremy Linton
Hi, Thanks for taking a look at this. On 5/23/20 1:20 PM, Russell King - ARM Linux admin wrote: On Fri, May 22, 2020 at 04:30:49PM -0500, Jeremy Linton wrote: C45 devices are to return 0 for registers they haven't implemented. This means in theory we can terminate the device search loop withou

Re: [RFC 03/11] net: phy: refactor c45 phy identification sequence

2020-05-24 Thread Jeremy Linton
Hi, On 5/23/20 3:01 PM, Russell King - ARM Linux admin wrote: On Sat, May 23, 2020 at 09:51:31PM +0200, Andrew Lunn wrote: static int get_phy_c45_ids(struct mii_bus *bus, int addr, u32 *phy_id, struct phy_c45_device_ids *c45_ids) { - int phy_reg; - int i

RE: [EXT] Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

2020-05-24 Thread Andy Duan
From: Fuzzey, Martin Sent: Saturday, May 23, 2020 5:56 PM > Hi Andy, > > > Fixes: da722186f654(net: fec: set GPR bit on suspend by DT > > configuration) > > Just a nitpick maybe but I don't really think this need as Fixes: tag. > That commit didn't actually *break* anything AFAIK. > It added Wo

Re: [PATCH net-next] vxlan: Do not assume RTNL is held in vxlan_fdb_info()

2020-05-24 Thread David Miller
From: Ido Schimmel Date: Mon, 25 May 2020 00:38:56 +0300 > From: Ido Schimmel > > vxlan_fdb_info() is not always called with RTNL held or from an RCU > read-side critical section. For example, in the following call path: > > vxlan_cleanup() > vxlan_fdb_destroy() > vxlan_fdb_notify() >

Re: [PATCH v2] Fix various coding-style issues and improve printk() usage

2020-05-24 Thread David Miller
From: David Miller Date: Sun, 24 May 2020 18:15:12 -0700 (PDT) > > Please repost this with a proper subsystem/driver prefix in your Subject line > and the appropriate target GIT tree inside the [] brackets. > > F.e. Subject: [PATCH v3 net] ne2k-pci: Fix various coding-style ... Actually in thi

Re: [PATCH net-next 00/11] mlxsw: Various trap changes - part 1

2020-05-24 Thread David Miller
From: Ido Schimmel Date: Mon, 25 May 2020 00:50:56 +0300 > From: Ido Schimmel > > This patch set contains various changes in mlxsw trap configuration. > Another set will perform similar changes before exposing control traps > (e.g., IGMP query, ARP request) via devlink-trap. > > Tested with ex

RE: [EXT] Re: [PATCH net 3/4] ARM: dts: imx6: update fec gpr property to match new format

2020-05-24 Thread Andy Duan
From: Andrew Lunn Sent: Saturday, May 23, 2020 7:50 AM > > Yes, I don't think anyone is saying otherwise. > > Correct. > > > > > The problem is just that there are already .dtsi files for i.MX chips > > having multiple ethernet interfaces in the mainline kernel (at least > > imx6ui.dtsi, imx6sx.

RE: [EXT] Re: [PATCH net 3/4] ARM: dts: imx6: update fec gpr property to match new format

2020-05-24 Thread Andy Duan
From: Fuzzey, Martin Sent: Saturday, May 23, 2020 2:03 AM > Hi Andy, > > On Fri, 22 May 2020, 03:01 Andy Duan, wrote: > > > > Andrew, many customers require the wol feature, NXP NPI release always > > support the wol feature to match customers requirement. > > > > And some customers' board only

RE: [RFC PATCH v12 07/11] psci: Add hypercall service for kvm ptp.

2020-05-24 Thread Jianyong Wu
Hi Steven, > -Original Message- > From: Steven Price > Sent: Friday, May 22, 2020 10:18 PM > To: Jianyong Wu ; netdev@vger.kernel.org; > yangbo...@nxp.com; john.stu...@linaro.org; t...@linutronix.de; > pbonz...@redhat.com; sean.j.christopher...@intel.com; m...@kernel.org; > richardcoch...

RE: [RFC PATCH v12 03/11] psci: export smccc conduit get helper.

2020-05-24 Thread Jianyong Wu
Hi Sudeep, > -Original Message- > From: Sudeep Holla > Sent: Friday, May 22, 2020 9:12 PM > To: Jianyong Wu > Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; > t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com; > m...@kernel.org; richardcoch.

RE: [PATCH] can: flexcan: Fix runtime PM imbalance on error

2020-05-24 Thread Joakim Zhang
> -Original Message- > From: linux-can-ow...@vger.kernel.org > On Behalf Of Dinghao Liu > Sent: 2020年5月22日 17:44 > To: dinghao@zju.edu.cn; k...@umn.edu > Cc: Wolfgang Grandegger ; Marc Kleine-Budde > ; David S. Miller ; Jakub > Kicinski ; linux-...@vger.kernel.org; > netdev@vger.kerne

Re: [PATCH v2] Fix various coding-style issues and improve printk() usage

2020-05-24 Thread David Miller
Please repost this with a proper subsystem/driver prefix in your Subject line and the appropriate target GIT tree inside the [] brackets. F.e. Subject: [PATCH v3 net] ne2k-pci: Fix various coding-style ...

Re: signal quality and cable diagnostic

2020-05-24 Thread Russell King - ARM Linux admin
On Sun, May 24, 2020 at 11:27:57PM +0200, Pavel Machek wrote: > > > The SNR seems to be most universal value, when it comes to comparing > > > different situations (different links and different PHYs). The > > > resolution of BER is not that detailed, for the NXP PHY is says only > > > "BER below 1

[PATCH v2] Fix various coding-style issues and improve printk() usage

2020-05-24 Thread Armin Wolf
Fixed a ton of minor checkpatch errors/warnings and remove version printing at module init/when device is found and use MODULE_VERSION instead. Also modifying the RTL8029 PCI string to include the compatible RTL8029AS nic. The only mayor issue remaining is the missing SPDX tag, but since the exact

Re: [PATCH v3 1/8] dt-bindings: net: meson-dwmac: Add the amlogic,rx-delay-ns property

2020-05-24 Thread Florian Fainelli
On 5/24/2020 2:28 PM, Pavel Machek wrote: > On Tue 2020-05-12 23:10:56, Martin Blumenstingl wrote: >> The PRG_ETHERNET registers on Meson8b and newer SoCs can add an RX >> delay. Add a property with the known supported values so it can be >> configured according to the board layout. >> >> Review

Re: [PATCH net-next] vxlan: Do not assume RTNL is held in vxlan_fdb_info()

2020-05-24 Thread Roopa Prabhu
On Sun, May 24, 2020 at 2:39 PM Ido Schimmel wrote: > > From: Ido Schimmel > > vxlan_fdb_info() is not always called with RTNL held or from an RCU > read-side critical section. For example, in the following call path: > > vxlan_cleanup() > vxlan_fdb_destroy() > vxlan_fdb_notify() > __

[PATCH v2 5/7] connector/cn_proc: Protect send_msg() with a local lock

2020-05-24 Thread Sebastian Andrzej Siewior
From: Mike Galbraith send_msg() disables preemption to avoid out-of-order messages. As the code inside the preempt disabled section acquires regular spinlocks, which are converted to 'sleeping' spinlocks on a PREEMPT_RT kernel and eventually calls into a memory allocator, this conflicts with the

[PATCH net-next 02/11] mlxsw: spectrum: Use same trap group for MLD and IGMP packets

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel Both packet types are needed for the same reason (multicast snooping), so associate them with the same trap group. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 1 - drivers/net/ethernet/mellanox/mlxsw/spectrum.c |

[PATCH net-next 01/11] mlxsw: spectrum: Rename IGMP trap group

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel The IGMP trap group will be used for MLD traps in the next patch, so rename it to "MC_SNOOPING" which is more appropriate. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 2 +- drivers/net/ethernet/mellanox/mlxsw/spe

[PATCH net-next 09/11] mlxsw: spectrum: Use same trap group for IPv6 ND and ARP packets

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel Both packet types are needed for the same reason (neighbour discovery), so associate them with the same trap group. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 8 1 file changed, 4 insertions(+), 4 deleti

[PATCH net-next 04/11] mlxsw: spectrum: Change default rate and priority of DHCP packets

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel Reduce the default acceptable rate of DHCP packets to 128 packets per second and reduce their priority. This is reasonable given the Spectrum ASICs are limited to 128 ports at the moment. These are only the default values. Users will be able to modify them via devlink-trap. S

[PATCH net-next 03/11] mlxsw: spectrum: Trap IPv4 DHCP packets in router

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel Currently, IPv4 DHCP packets are trapped during L2 forwarding, which means that packets might be trapped unnecessarily. Instead, only trap the DHCP packets that reach the router. Either because they were flooded to the router port or forwarded to it by the FDB. This is consiste

[PATCH net-next 11/11] mlxsw: spectrum: Fix spelling mistake in trap's name

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel Fix incorrect spelling of "advertisement". Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 ++-- drivers/net/ethernet/mellanox/mlxsw/trap.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH net-next 07/11] mlxsw: spectrum_trap: Remove unnecessary field

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel Now that traffic class (TC) and priority are set to the same value, there is no need to store both. Remove the first. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_trap.c | 7 +-- 1 file changed, 1 insertion(+), 6 d

[PATCH net-next 08/11] mlxsw: spectrum: Rename ARP trap group

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel The ARP trap group will be used for IPv6 ND traps in the next patch, so rename it to "NEIGH_DISCOVERY" which is more appropriate. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 2 +- drivers/net/ethernet/mellanox/ml

[PATCH net-next 00/11] mlxsw: Various trap changes - part 1

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel This patch set contains various changes in mlxsw trap configuration. Another set will perform similar changes before exposing control traps (e.g., IGMP query, ARP request) via devlink-trap. Tested with existing devlink-trap selftests. Please see individual patches for a detail

[PATCH net-next 06/11] mlxsw: spectrum: Align TC and trap priority

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel The traffic class (TC) attribute of packet traps determines through which TC a packet trap will be scheduled through the CPU port. The priority attribute determines which trap will be triggered in case several packet traps match a packet. We try to configure these attributes

[PATCH net-next 05/11] mlxsw: spectrum_buffers: Assign non-zero quotas to TC 0 of the CPU port

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel As explained in commit 9ffcc3725f09 ("mlxsw: spectrum: Allow packets to be trapped from any PG"), incoming packets can be admitted to the shared buffer and forwarded / trapped, if: (Ingress{Port}.Usage < Thres && Ingress{Port,PG}.Usage < Thres && Egress{Port}.Usage < Thres &&

[PATCH net-next 10/11] mlxsw: spectrum: Use dedicated trap group for sampled packets

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel The rate with which packets are sampled is determined by user space, so there is no need to associate such packets with a policer. Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 1 + drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 3 ++- 2

[PATCH net-next] vxlan: Do not assume RTNL is held in vxlan_fdb_info()

2020-05-24 Thread Ido Schimmel
From: Ido Schimmel vxlan_fdb_info() is not always called with RTNL held or from an RCU read-side critical section. For example, in the following call path: vxlan_cleanup() vxlan_fdb_destroy() vxlan_fdb_notify() __vxlan_fdb_notify() vxlan_fdb_info() The use of rtnl_dereferenc

[PATCH] netfilter/ipvs: immediately expire no destination connections in kthread if expire_nodest_conn=1

2020-05-24 Thread Andrew Sy Kim
If expire_nodest_conn=1 and a destination is deleted, IPVS should also expire all matching connections immiediately instead of waiting for the next matching packet. This is particulary useful when there are a lot of packets coming from a few number of clients. Those clients are likely to match agai

Re: [PATCH v3 1/8] dt-bindings: net: meson-dwmac: Add the amlogic,rx-delay-ns property

2020-05-24 Thread Pavel Machek
On Tue 2020-05-12 23:10:56, Martin Blumenstingl wrote: > The PRG_ETHERNET registers on Meson8b and newer SoCs can add an RX > delay. Add a property with the known supported values so it can be > configured according to the board layout. > > Reviewed-by: Andrew Lunn > Signed-off-by: Martin Blumens

Re: signal quality and cable diagnostic

2020-05-24 Thread Pavel Machek
On Tue 2020-05-12 15:04:18, Andrew Lunn wrote: > > > As for getting / setting the threshold, perhaps ETHTOOL_MSG_LINKINFO_GET > > > and ETHTOOL_MSG_LINKINFO_SET. Unless you expect more configurable > > > parameters like this in which case we may want to consider adding new > > > request type (e.g.

Re: signal quality and cable diagnostic

2020-05-24 Thread Pavel Machek
> > The SNR seems to be most universal value, when it comes to comparing > > different situations (different links and different PHYs). The > > resolution of BER is not that detailed, for the NXP PHY is says only > > "BER below 1e-10" or not. > > The point I was trying to make is that SQI is inten

[PATCH] dpaa_eth: fix usage as DSA master, try 3

2020-05-24 Thread Vladimir Oltean
From: Vladimir Oltean The dpaa-eth driver probes on compatible string for the MAC node, and the fman/mac.c driver allocates a dpaa-ethernet platform device that triggers the probing of the dpaa-eth net device driver. All of this is fine, but the problem is that the struct device of the dpaa_eth

Re: [PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-24 Thread Michal Kubecek
On Sat, May 23, 2020 at 05:09:50PM +0800, Chen Yu wrote: > Hi Michal, > Thanks for reviewing, > and sorry for late reply. > On Thu, May 21, 2020 at 09:23:42PM +0200, Michal Kubecek wrote: > > On Fri, May 22, 2020 at 01:59:13AM +0800, Chen Yu wrote: > > > Currently the ethtool shows that WOL(Wake On

Re: [PATCH v2 net-next 5/6] net: ethtool: Allow PHY cable test TDR data to configured

2020-05-24 Thread Michal Kubecek
On Sun, May 24, 2020 at 05:27:45PM +0200, Andrew Lunn wrote: > Allow the user to configure where on the cable the TDR data should be > retrieved, in terms of first and last sample, and the step between > samples. Also add the ability to ask for TDR data for just one pair. > > If this configuration

8111F issue

2020-05-24 Thread Łukasz Kalisz
Hello I have been using several boards with reraltek ethernet and everyone was just working now I got board wirh 8111F (previous working was 8111E) and I'm loosing connection once a week or even earlier I tried using 8169 and 8168 modules (gentoo, 4.9.120 kernel atm) Is there something I

Re: [PATCH net-next V2] Let the ADJ_OFFSET interface respect the ADJ_NANO flag for PHC devices.

2020-05-24 Thread Vincent Cheng
On Sun, May 24, 2020 at 02:27:10PM EDT, Richard Cochran wrote: >In commit 184ecc9eb260d5a3bcdddc5bebd18f285ac004e9 ("ptp: Add adjphase >function to support phase offset control.") the PTP Hardware Clock >interface expanded to support the ADJ_OFFSET offset mode. However, >the implementation did not

Re: [PATCH] iproute2: ip addr: Accept 'optimistic' flag

2020-05-24 Thread Stephen Hemminger
On Sat, 23 May 2020 18:51:44 -0700 "Ian K. Coolidge" wrote: > This allows addresses added to use IPv6 optimistic DAD. > --- > ip/ipaddress.c | 7 ++- > man/man8/ip-address.8.in | 7 ++- > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/ip/ipaddress.c b/ip/ip

[PATCH net-next V2] Let the ADJ_OFFSET interface respect the ADJ_NANO flag for PHC devices.

2020-05-24 Thread Richard Cochran
In commit 184ecc9eb260d5a3bcdddc5bebd18f285ac004e9 ("ptp: Add adjphase function to support phase offset control.") the PTP Hardware Clock interface expanded to support the ADJ_OFFSET offset mode. However, the implementation did not respect the traditional yet pedantic distinction between units of

Re: [PATCH net-next] tcp: allow traceroute -Mtcp for unpriv users

2020-05-24 Thread Maciej Żenczykowski
On Sun, May 24, 2020 at 11:00 AM Eric Dumazet wrote: > > Unpriv users can use traceroute over plain UDP sockets, but not TCP ones. > > $ traceroute -Mtcp 8.8.8.8 > You do not have enough privileges to use this traceroute method. > > $ traceroute -n -Mudp 8.8.8.8 > traceroute to 8.8.8.8 (8.8.8.8),

Re: general protection fault in selinux_socket_recvmsg

2020-05-24 Thread syzbot
syzbot has bisected this bug to: commit 263e1201a2c324b60b15ecda5de9ebf1e7293e31 Author: Paolo Abeni Date: Thu Apr 30 13:01:51 2020 + mptcp: consolidate synack processing. bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12a5254a10 start commit: 051143e1 Merge tag 'a

Re: [PATCH net-next] Let the ADJ_OFFSET interface respect the STA_NANO flag for PHC devices.

2020-05-24 Thread Richard Cochran
On Sun, May 24, 2020 at 06:28:00AM -0700, Richard Cochran wrote: > @@ -147,8 +147,13 @@ static int ptp_clock_adjtime(struct posix_clock *pc, > struct __kernel_timex *tx) > err = ops->adjfreq(ops, ppb); > ptp->dialed_frequency = tx->freq; > } else if (tx->m

Re: [RFC bpf-next 1/2] bpf: cpumap: add the possibility to attach a eBPF program to cpumap

2020-05-24 Thread David Ahern
On 5/22/20 10:11 AM, Lorenzo Bianconi wrote: > @@ -307,8 +354,23 @@ static int cpu_map_kthread_run(void *data) > return 0; > } > > -static struct bpf_cpu_map_entry *__cpu_map_entry_alloc(u32 qsize, u32 cpu, > -int map_id) > +static int __

Re: [PATCH v2 net-next 6/6] net : phy: marvell: Speedup TDR data retrieval by only changing page once

2020-05-24 Thread Andrew Lunn
On Sun, May 24, 2020 at 05:27:46PM +0200, Andrew Lunn wrote: > Getting the TDR data requires a large number of MDIO bus > transactions. The number can however be reduced if the page is only > changed once. Add the needed locking to allow this, and make use of > unlocked read/write methods where nee

[bpf-next PATCH v5 5/5] bpf, selftests: test probe_* helpers from SCHED_CLS

2020-05-24 Thread John Fastabend
Lets test using probe* in SCHED_CLS network programs as well just to be sure these keep working. Its cheap to add the extra test and provides a second context to test outside of sk_msg after we generalized probe* helpers to all networking types. Acked-by: Yonghong Song Signed-off-by: John Fastabe

[bpf-next PATCH v5 4/5] bpf, selftests: add sk_msg helpers load and attach test

2020-05-24 Thread John Fastabend
The test itself is not particularly useful but it encodes a common pattern we have. Namely do a sk storage lookup then depending on data here decide if we need to do more work or alternatively allow packet to PASS. Then if we need to do more work consult task_struct for more information about the

[bpf-next PATCH v5 3/5] bpf, sk_msg: add get socket storage helpers

2020-05-24 Thread John Fastabend
Add helpers to use local socket storage. Signed-off-by: John Fastabend Acked-by: Yonghong Song --- include/uapi/linux/bpf.h |2 ++ net/core/filter.c | 15 +++ tools/include/uapi/linux/bpf.h |2 ++ 3 files changed, 19 insertions(+) diff --git a/include/u

[bpf-next PATCH v5 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task*

2020-05-24 Thread John Fastabend
Often it is useful when applying policy to know something about the task. If the administrator has CAP_SYS_ADMIN rights then they can use kprobe + networking hook and link the two programs together to accomplish this. However, this is a bit clunky and also means we have to call both the network pro

[bpf-next PATCH v5 1/5] bpf, sk_msg: add some generic helpers that may be useful from sk_msg

2020-05-24 Thread John Fastabend
Add these generic helpers that may be useful to use from sk_msg programs. The helpers do not depend on ctx so we can simply add them here, BPF_FUNC_perf_event_output BPF_FUNC_get_current_uid_gid BPF_FUNC_get_current_pid_tgid BPF_FUNC_get_current_comm BPF_FUNC_get_current_cgroup_id BPF_FUNC_g

[bpf-next PATCH v5 0/5] bpf: Add sk_msg and networking helpers

2020-05-24 Thread John Fastabend
This series adds helpers for sk_msg program type and based on feedback from v1 adds *_task_* helpers and probe_* helpers to all networking programs with perfmon_capable() capabilities. The list of helpers breaks down as follows, Networking with perfmon_capable() guard (patch2): BPF_FUNC_get_cur

Re: [PATCH RFC net-next 00/13] RX filtering for DSA switches

2020-05-24 Thread Vladimir Oltean
Hi Florian, On Sun, 24 May 2020 at 19:13, Florian Fainelli wrote: > > Hi Vladimir, > > On 5/21/2020 2:10 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > This is a WIP series whose stated goal is to allow DSA and switchdev > > drivers to flood less traffic to the CPU while keeping th

Re: [PATCH RFC net-next 00/13] RX filtering for DSA switches

2020-05-24 Thread Vladimir Oltean
On Sun, 24 May 2020 at 17:07, Ido Schimmel wrote: > > On Fri, May 22, 2020 at 12:10:23AM +0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > This is a WIP series whose stated goal is to allow DSA and switchdev > > drivers to flood less traffic to the CPU while keeping the same level o

Re: [PATCH RFC net-next 10/13] net: bridge: add port flags for host flooding

2020-05-24 Thread Vladimir Oltean
Hi Ido, On Sun, 24 May 2020 at 17:26, Ido Schimmel wrote: > > On Fri, May 22, 2020 at 12:10:33AM +0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > In cases where the bridge is offloaded by a switchdev, there are > > situations where we can optimize RX filtering towards the host. To

Re: [PATCH RFC net-next 00/13] RX filtering for DSA switches

2020-05-24 Thread Florian Fainelli
Hi Vladimir, On 5/21/2020 2:10 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This is a WIP series whose stated goal is to allow DSA and switchdev > drivers to flood less traffic to the CPU while keeping the same level of > functionality. > > The strategy is to whitelist towards the CPU

[PATCH v2 net-next 2/6] net: ethtool: Add generic parts of cable test TDR

2020-05-24 Thread Andrew Lunn
Add the generic parts of the code used to trigger a cable test and return raw TDR data. Any PHY driver which support this must implement the new driver op. Signed-off-by: Andrew Lunn v2 Update nxp-tja11xx for API change. --- drivers/net/phy/nxp-tja11xx.c | 2 +- drivers/net/phy/phy.c

[PATCH v2 net-next 5/6] net: ethtool: Allow PHY cable test TDR data to configured

2020-05-24 Thread Andrew Lunn
Allow the user to configure where on the cable the TDR data should be retrieved, in terms of first and last sample, and the step between samples. Also add the ability to ask for TDR data for just one pair. If this configuration is not provided, it defaults to 1-150m at 1m intervals for all pairs.

[PATCH v2 net-next 0/6] Raw PHY TDR data

2020-05-24 Thread Andrew Lunn
Some ethernet PHYs allow access to raw TDR data in addition to summary diagnostics information. Add support for retrieving this data via netlink ethtool. The basic structure in the core is the same as for normal phy diagnostics, the PHY driver simply uses different helpers to fill the netlink messa

[PATCH net-next 7/7] net: phy: marvell: Configure TDR pulse based on measurement length

2020-05-24 Thread Andrew Lunn
When performing a TDR measurement for a short distance, the pulse width should be low, to help differentiate between the outgoing pulse and any reflection. For longer distances, the pulse should be wider, to help with attenuation. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 25 +++

[PATCH v2 net-next 4/6] net: phy: marvell: Add support for amplitude graph

2020-05-24 Thread Andrew Lunn
The Marvell PHYs can measure the amplitude of the returned signal for a given distance. Implement this option of the cable test infrastructure. When reporting the step, convert the distance into cm. Signed-off-by: Andrew Lunn v2: Step based on the measurement resolution, and convert this to cm.

[PATCH v2 net-next 6/6] net : phy: marvell: Speedup TDR data retrieval by only changing page once

2020-05-24 Thread Andrew Lunn
Getting the TDR data requires a large number of MDIO bus transactions. The number can however be reduced if the page is only changed once. Add the needed locking to allow this, and make use of unlocked read/write methods where needed. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 56

[PATCH v2 net-next 3/6] net: ethtool: Add helpers for cable test TDR data

2020-05-24 Thread Andrew Lunn
Add helpers for returning raw TDR helpers in netlink messages. Signed-off-by: Andrew Lunn --- include/linux/ethtool_netlink.h | 21 + net/ethtool/cabletest.c | 79 - 2 files changed, 99 insertions(+), 1 deletion(-) diff --git a/include/linux/ethto

[PATCH v2 net-next 1/6] net: ethtool: Add attributes for cable test TDR data

2020-05-24 Thread Andrew Lunn
Some Ethernet PHYs can return the raw time domain reflectromatry data. Add the attributes to allow this data to be requested and returned via netlink ethtool. Signed-off-by: Andrew Lunn v2: m -> cm Report what the PHY actually used for start/stop/step. --- Documentation/networking/ethtool-netli

Re: [RFC 08/11] net: phy: Allow mdio buses to auto-probe c45 devices

2020-05-24 Thread Andrew Lunn
> +++ b/include/linux/phy.h > @@ -275,6 +275,11 @@ struct mii_bus { > int reset_delay_us; > /* RESET GPIO descriptor pointer */ > struct gpio_desc *reset_gpiod; > + /* bus capabilities, used for probing */ > + enum { > + MDIOBUS_C22_ONLY = 0, > + MD

Re: [PATCH RFC net-next 10/13] net: bridge: add port flags for host flooding

2020-05-24 Thread Ido Schimmel
On Fri, May 22, 2020 at 12:10:33AM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > In cases where the bridge is offloaded by a switchdev, there are > situations where we can optimize RX filtering towards the host. To be > precise, the host only needs to do termination, which it can do b

Re: [PATCH RFC net-next 00/13] RX filtering for DSA switches

2020-05-24 Thread Ido Schimmel
On Fri, May 22, 2020 at 12:10:23AM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > This is a WIP series whose stated goal is to allow DSA and switchdev > drivers to flood less traffic to the CPU while keeping the same level of > functionality. > > The strategy is to whitelist towards t

[PATCH net-next] Let the ADJ_OFFSET interface respect the STA_NANO flag for PHC devices.

2020-05-24 Thread Richard Cochran
In commit 184ecc9eb260d5a3bcdddc5bebd18f285ac004e9 ("ptp: Add adjphase function to support phase offset control.") the PTP Hardware Clock interface expanded to support the ADJ_OFFSET offset mode. However, the implementation did not respect the traditional yet pedantic distinction between units of

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-24 Thread Roman Mashak
David Ahern writes: > On 5/17/20 7:28 AM, Roman Mashak wrote: >> Have print_tm() dump firstuse value along with install, lastuse >> and expires. >> >> Signed-off-by: Roman Mashak >> --- >> tc/tc_util.c | 5 + >> 1 file changed, 5 insertions(+) >> > > I can merge master once Stephen commit

Re: iproute2: tc deletion freezes whole server

2020-05-24 Thread Václav Zindulka
On Tue, May 19, 2020 at 7:57 PM Cong Wang wrote: > > On Tue, May 19, 2020 at 1:04 AM Václav Zindulka > wrote: > > > > > > Let me think how to fix this properly, I have some ideas and will provide > > > you some patch(es) to test soon. > > > > Sure, I'll wait. I have plenty of time now with the ma