Re: signal quality and cable diagnostic

2020-05-11 Thread Oleksij Rempel
On Mon, May 11, 2020 at 04:59:26PM +0200, Michal Kubecek wrote: > On Mon, May 11, 2020 at 04:13:10PM +0200, Oleksij Rempel wrote: > > > > I continue to work on TJA11xx PHY and need to export some additional > > cable diagnostic/link stability information: Signal Quality Index (SQI). > > The PHY da

Re: net/sonic: Fix some resource leaks in error handling paths

2020-05-11 Thread Markus Elfring
> Markus, if you were to write a patch to improve upon coding-style.rst, > who should review it? All involved contributors have got chances to provide constructive comments. I would be curious who will actually dare to contribute further ideas for this area. > If you are unable to write or revi

Re: [PATCH v2 09/14] net: ethernet: mtk-eth-mac: new driver

2020-05-11 Thread Bartosz Golaszewski
pon., 11 maj 2020 o 21:24 Florian Fainelli napisał(a): > > > > On 5/11/2020 8:07 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC > > family. For now we only support full-duplex. > > > > Signed-off-by: Bar

RE: [EXT] Re: [PATCH v1 net-next 3/3] net: dsa: felix: add support Credit Based Shaper(CBS) for hardware offload

2020-05-11 Thread Xiaoliang Yang
Hi Jakub, On Mon, 11 May 2020 22:34:32 Jakub Kicinski wrote: > > +int vsc9959_qos_port_cbs_set(struct dsa_switch *ds, int port, > > + struct tc_cbs_qopt_offload *cbs_qopt) > > static I will update this in v2, thanks. Regards, Xiaoliang Yang

RE: [EXT] Re: [PATCH v1 net-next 1/3] net: dsa: felix: qos classified based on pcp

2020-05-11 Thread Xiaoliang Yang
Hi Vladimir, On Mon, 11 May 2020 at 08:19, Vladimir Oltean wrote: > > The new skbedit priority offload action looks interesting to me. > But it also raises the question of what to do in the default case where such > rules are not installed. I think it is ok to support a > 1-to-1 VLAN PCP to TC

Re: [PATCH v2 05/14] net: core: provide priv_to_netdev()

2020-05-11 Thread Bartosz Golaszewski
pon., 11 maj 2020 o 22:41 David Miller napisał(a): > > From: Bartosz Golaszewski > Date: Mon, 11 May 2020 17:07:50 +0200 > > > From: Bartosz Golaszewski > > > > Appropriate amount of extra memory for private data is allocated at > > the end of struct net_device. We have a helper - netdev_priv()

Re: [PATCH net] net: broadcom: Imply BROADCOM_PHY for BCMGENET

2020-05-11 Thread Marek Szyprowski
Hi Florian, On 11.05.2020 20:19, Florian Fainelli wrote: > On 5/11/2020 12:21 AM, Marek Szyprowski wrote: >> On 09.05.2020 00:32, Florian Fainelli wrote: >>> The GENET controller on the Raspberry Pi 4 (2711) is typically >>> interfaced with an external Broadcom PHY via a RGMII electrical >>> inter

[PATCH v2 bpf-next 2/7] bpf: move to generic BTF show support, apply it to seq files/strings

2020-05-11 Thread Alan Maguire
generalize the "seq_show" seq file support in btf.c to support a generic show callback of which we support two instances; the current seq file show, and a show with snprintf() behaviour which instead writes the type data to a supplied string. Both classes of show function call btf_type_show() with

[PATCH v2 bpf-next 0/7] bpf, printk: add BTF-based type printing

2020-05-11 Thread Alan Maguire
The printk family of functions support printing specific pointer types using %p format specifiers (MAC addresses, IP addresses, etc). For full details see Documentation/core-api/printk-formats.rst. This patchset proposes introducing a "print typed pointer" format specifier "%pT"; the argument ass

[PATCH v2 bpf-next 3/7] checkpatch: add new BTF pointer format specifier

2020-05-11 Thread Alan Maguire
checkpatch complains about unknown format specifiers, so add the BTF format specifier we will implement in a subsequent patch to avoid errors. Signed-off-by: Alan Maguire --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts

[PATCH v2 bpf-next 5/7] printk: extend test_printf to test %pT BTF-based format specifier

2020-05-11 Thread Alan Maguire
Add tests to verify basic type display and to iterate through all enums, structs, unions and typedefs ensuring expected behaviour occurs. Since test_printf can be built as a module we need to export a BTF kind iterator function to allow us to iterate over all names of a particular BTF kind. These

[PATCH v2 bpf-next 7/7] bpf: add tests for %pT format specifier

2020-05-11 Thread Alan Maguire
tests verify we get > 0 return value from bpf_trace_print() using %pT format specifier with various modifiers/pointer values. Signed-off-by: Alan Maguire --- .../selftests/bpf/prog_tests/trace_printk_btf.c| 83 ++ .../selftests/bpf/progs/netif_receive_skb.c| 81 ++

[PATCH v2 bpf-next 4/7] printk: add type-printing %pT format specifier which uses BTF

2020-05-11 Thread Alan Maguire
printk supports multiple pointer object type specifiers (printing netdev features etc). Extend this support using BTF to cover arbitrary types. "%pT" specifies the typed format, and the pointer argument is a "struct btf_ptr *" where struct btf_ptr is as follows: struct btf_ptr { void *pt

[PATCH v2 bpf-next 1/7] bpf: provide function to get vmlinux BTF information

2020-05-11 Thread Alan Maguire
It will be used later for BTF printk() support Signed-off-by: Alan Maguire --- include/linux/bpf.h | 2 ++ kernel/bpf/verifier.c | 18 -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index cf4b6e4..de19a35 100644 ---

[PATCH v2 bpf-next 6/7] bpf: add support for %pT format specifier for bpf_trace_printk() helper

2020-05-11 Thread Alan Maguire
Allow %pT[cNx0] format specifier for BTF-based display of data associated with pointer. Signed-off-by: Alan Maguire --- include/uapi/linux/bpf.h | 27 ++- kernel/trace/bpf_trace.c | 21 ++--- tools/include/uapi/linux/bpf.h | 27

Re: [RFC next-next v2 1/5] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-05-11 Thread Jiri Pirko
Mon, May 11, 2020 at 09:24:22PM CEST, vadym.koc...@plvision.eu wrote: >On Mon, May 11, 2020 at 02:57:23PM +0200, Jiri Pirko wrote: >> [...] >> >> >diff --git a/drivers/net/ethernet/marvell/prestera/prestera_dsa.c >> >b/drivers/net/ethernet/marvell/prestera/prestera_dsa.c >> >new file mode 100644

Re: stable/linux-4.4.y bisection: baseline.login on at91-sama5d4_xplained

2020-05-11 Thread Guillaume Tucker
Please see the bisection report below about a boot failure. Reports aren't automatically sent to the public while we're trialing new bisection features on kernelci.org but this one looks valid. It appears to be due to the fact that the network interface is failing to get brought up: [ 114.38500

Re: [PATCH] ifcvf: move IRQ request/free to status change handlers

2020-05-11 Thread Jason Wang
On 2020/5/12 上午11:38, Jason Wang wrote:   static int ifcvf_start_datapath(void *private)   {   struct ifcvf_hw *vf = ifcvf_private_to_vf(private); @@ -118,9 +172,12 @@ static void ifcvf_vdpa_set_status(struct vdpa_device *vdpa_dev, u8 status)   {   struct ifcvf_adapter *adapter;

ICMPV6 param problem with new error code 3 for first fragment not having valid upper layer header

2020-05-11 Thread Preethi Ramachandra
As per is_ineligible implementation in net/ipv6/icmp.c. If the incoming icmp is an error or is truncated, responses will not be sent out. RFC8200 and RFC 7112 states the following: “If the first fragment does not include all headers through an Upper-Layer header, then that fragme

Re: [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-11 Thread Madhuparna Bhowmik
On Sat, May 09, 2020 at 02:19:38PM -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 12:52:44 +0530 Amol Grover wrote: > > ipmr_for_each_table() uses list_for_each_entry_rcu() for > > traversing outside of an RCU read-side critical section but > > under the protection of pernet_ops_rwsem. Hence ad

Re: Re: signal quality and cable diagnostic

2020-05-11 Thread Oleksij Rempel
On Mon, May 11, 2020 at 09:54:35PM +0200, Andrew Lunn wrote: > On Mon, May 11, 2020 at 07:32:05PM +, Christian Herber wrote: > > On May 11, 2020 4:33:53 PM Andrew Lunn wrote: > > > > > > Are the classes part of the Open Alliance specification? Ideally we > > > want to report something standard

Re: linux-next boot error: WARNING: suspicious RCU usage in ip6mr_get_table

2020-05-11 Thread Madhuparna Bhowmik
On Tue, May 12, 2020 at 11:28:47AM +1000, Stephen Rothwell wrote: > Hi all, > > On Fri, 8 May 2020 04:54:02 +0530 Madhuparna Bhowmik > wrote: > > > > On Thu, May 07, 2020 at 08:50:55AM -0400, Qian Cai wrote: > > > > > > > > > > On May 7, 2020, at 5:32 AM, Dmitry Vyukov wrote: > > > > > > >

[RFC] e1000e: Relax condition to trigger reset for ME workaround

2020-05-11 Thread Punit Agrawal
It's an error if the value of the RX/TX tail descriptor does not match what was written. The error condition is true regardless the duration of the interference from ME. But the code only performs the reset if E1000_ICH_FWSM_PCIM2PCI_COUNT (2000) iterations of 50us delay have transpired. The extra

Re: [PATCH] bpfilter: check if $(CC) can static link in Kconfig

2020-05-11 Thread Masahiro Yamada
On Sun, May 10, 2020 at 10:04 AM Alexei Starovoitov wrote: > > On Sat, May 9, 2020 at 12:40 AM Masahiro Yamada wrote: > > > > On Fedora, linking static libraries requires the glibc-static RPM > > package, which is not part of the glibc-devel package. > > > > CONFIG_CC_CAN_LINK does not check the

Re: [PATCH v2 bpf-next 2/3] selftest/bpf: fmod_ret prog and implement test_overhead as part of bench

2020-05-11 Thread Andrii Nakryiko
On Sat, May 9, 2020 at 10:24 AM Yonghong Song wrote: > > > > On 5/8/20 4:20 PM, Andrii Nakryiko wrote: > > Add fmod_ret BPF program to existing test_overhead selftest. Also > > re-implement > > user-space benchmarking part into benchmark runner to compare results. > > Results > > with ./bench a

Re: [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-11 Thread Jürgen Groß
On 11.05.20 19:27, Denis Kirjanov wrote: On 5/11/20, Jürgen Groß wrote: On 11.05.20 12:22, Denis Kirjanov wrote: The patch adds a basic XDP processing to xen-netfront driver. We ran an XDP program for an RX response received from netback driver. Also we request xen-netback to adjust data offs

Re: [PATCH v2 net-next 15/15] docs: net: dsa: sja1105: document the best_effort_vlan_filtering option

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] ifcvf: move IRQ request/free to status change handlers

2020-05-11 Thread Jason Wang
On 2020/5/11 下午6:18, Francesco Lavra wrote: On 5/11/20 11:26 AM, Jason Wang wrote: On 2020/5/11 下午3:19, Zhu Lingshan wrote: This commit move IRQ request and free operations from probe() to VIRTIO status change handler to comply with VIRTIO spec. VIRTIO spec 1.1, section 2.1.2 Device Require

Re: [PATCH v2 net-next 14/15] net: dsa: sja1105: implement VLAN retagging for dsa_8021q sub-VLANs

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Expand the delta commit procedure for VLANs with additional logic for > treating bridge_vlans in the newly introduced operating mode, > SJA1105_VLAN_BEST_EFFORT. > > For every bridge VLAN on every user port, a sub-VLAN i

Re: [PATCH v2 net-next 13/15] net: dsa: sja1105: implement a common frame memory partitioning function

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > There are 2 different features that require some reserved frame memory > space: VLAN retagging and virtual links. Create a central function that > modifies the static config and ensures frame memory is never > overcommitt

Re: [PATCH v2 net-next 12/15] net: dsa: sja1105: add packing ops for the Retagging Table

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The Retagging Table is an optional feature that allows the switch to > match frames against a {ingress port, egress port, vid} rule and change > their VLAN ID. The retagged frames are by default clones of the original > o

Re: [PATCH] ifcvf: move IRQ request/free to status change handlers

2020-05-11 Thread Jason Wang
On 2020/5/11 下午6:11, Zhu, Lingshan wrote: On 5/11/2020 5:26 PM, Jason Wang wrote: On 2020/5/11 下午3:19, Zhu Lingshan wrote: This commit move IRQ request and free operations from probe() to VIRTIO status change handler to comply with VIRTIO spec. VIRTIO spec 1.1, section 2.1.2 Device Requir

Re: [PATCH v2 net-next 11/15] net: dsa: sja1105: add a new best_effort_vlan_filtering devlink parameter

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This devlink parameter enables the handling of DSA tags when enslaved to > a bridge with vlan_filtering=1. There are very good reasons to want > this, but there are also very good reasons for not enabling it by > default.

Re: [PATCH v2 net-next 10/15] net: dsa: tag_sja1105: implement sub-VLAN decoding

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Create a subvlan_map as part of each port's tagger private structure. > This keeps reverse mappings of bridge-to-dsa_8021q VLAN retagging rules. > > Note that as of this patch, this piece of code is never engaged, due to

Re: [PATCH v2 net-next 09/15] net: dsa: tag_8021q: support up to 8 VLANs per port using sub-VLANs

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > For switches that support VLAN retagging, such as sja1105, we extend > dsa_8021q by encoding a "sub-VLAN" into the remaining 3 free bits in the > dsa_8021q tag. > > A sub-VLAN is nothing more than a number in the range 0

Re: [PATCH v2 net-next 08/15] net: dsa: sja1105: prepare tagger for handling DSA tags and VLAN simultaneously

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > In VLAN-unaware mode, sja1105 uses VLAN tags with a custom TPID of > 0xdadb. While in the yet-to-be introduced best_effort_vlan_filtering > mode, it needs to work with normal VLAN TPID values. > > A complication arises w

Re: [PATCH v2 net-next 07/15] net: dsa: sja1105: exit sja1105_vlan_filtering when called multiple times

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > VLAN filtering is a global property for sja1105, and that means that we > rely on the DSA core to not call us more than once. > > But we need to introduce some per-port state for the tagger, namely the > xmit_tpid, and t

linux-next: manual merge of the net-next tree with the net tree

2020-05-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got conflicts in: drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c drivers/net/ethernet/huawei/hinic/hinic_main.c between commit: e8a1b0efd632 ("hinic: fix a bug of ndo_stop") from the net tree and commit: 7dd29ee12865 ("hinic: ad

Re: [PATCH v2 net-next 05/15] net: dsa: sja1105: save/restore VLANs using a delta commit method

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Managing the VLAN table that is present in hardware will become very > difficult once we add a third operating state > (best_effort_vlan_filtering). That is because correct cleanup (not too > little, not too much) becomes

Re: [PATCH v2 bpf-next 1/3] selftests/bpf: add benchmark runner infrastructure

2020-05-11 Thread Andrii Nakryiko
On Sat, May 9, 2020 at 10:10 AM Yonghong Song wrote: > > > > On 5/8/20 4:20 PM, Andrii Nakryiko wrote: > > While working on BPF ringbuf implementation, testing, and benchmarking, I've > > developed a pretty generic and modular benchmark runner, which seems to be > > generically useful, as I've alr

Re: [PATCH v2 net-next 04/15] net: dsa: sja1105: deny alterations of dsa_8021q VLANs from the bridge

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > At the moment, this can never happen. The 2 modes that we operate in do > not permit that: > > - SJA1105_VLAN_UNAWARE: we are guarded from bridge VLANs added by the >user by the DSA core. We will later lift this res

Re: [PATCH v2 net-next 03/15] net: dsa: sja1105: keep the VLAN awareness state in a driver variable

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Soon we'll add a third operating mode to the driver. Introduce a > vlan_state to make things more easy to manage, and use it where > applicable. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Flo

Re: [PATCH v2 net-next 06/15] net: dsa: sja1105: allow VLAN configuration from the bridge in all states

2020-05-11 Thread Florian Fainelli
On 5/11/2020 6:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Let the DSA core call our .port_vlan_add methods every time the bridge > layer requests so. We will deal internally with saving/restoring VLANs > depending on our VLAN awareness state. > > Signed-off-by: Vladimir Oltean

Re: [PATCH net-next 4/4] net: bcmgenet: add support for ethtool flow control

2020-05-11 Thread Florian Fainelli
On 5/11/2020 5:24 PM, Doug Berger wrote: > This commit extends the supported ethtool operations to allow MAC > level flow control to be configured for the bcmgenet driver. It > provides an example of how the new phy_set_pause function and the > phy_validate_pause function can be used to configur

Re: [PATCH net-next 3/4] net: ethernet: introduce phy_set_pause

2020-05-11 Thread Florian Fainelli
On 5/11/2020 5:24 PM, Doug Berger wrote: > This commit introduces the phy_set_pause function to the phylib as > a helper to support the set_pauseparam ethtool method. > > It is hoped that the new behavior introduced by this function will > be widely embraced and the phy_set_sym_pause and phy_se

Re: [PATCH bpf-next v3 08/21] bpf: implement common macros/helpers for target iterators

2020-05-11 Thread Andrii Nakryiko
On Fri, May 8, 2020 at 8:18 PM Yonghong Song wrote: > > > > On 5/8/20 12:07 PM, Andrii Nakryiko wrote: > > On Wed, May 6, 2020 at 10:40 PM Yonghong Song wrote: > >> > >> Macro DEFINE_BPF_ITER_FUNC is implemented so target > >> can define an init function to capture the BTF type > >> which represe

Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting

2020-05-11 Thread Florian Fainelli
On 5/11/2020 5:24 PM, Doug Berger wrote: > A comment in uapi/linux/ethtool.h states "Drivers should reject a > non-zero setting of @autoneg when autoneogotiation is disabled (or > not supported) for the link". > > That check should be added to phy_validate_pause() to consolidate > the code wher

Re: [PATCH bpf-next v3 03/21] bpf: support bpf tracing/iter programs for BPF_LINK_CREATE

2020-05-11 Thread Andrii Nakryiko
On Fri, May 8, 2020 at 6:36 PM Yonghong Song wrote: > > > > On 5/8/20 11:24 AM, Andrii Nakryiko wrote: > > On Wed, May 6, 2020 at 10:41 PM Yonghong Song wrote: > >> > >> Given a bpf program, the step to create an anonymous bpf iterator is: > >>- create a bpf_iter_link, which combines bpf prog

Re: [bpf-next PATCH 00/10] bpf: selftests, test_sockmap improvements

2020-05-11 Thread Andrii Nakryiko
On Sat, May 9, 2020 at 7:55 AM John Fastabend wrote: > > Andrii Nakryiko wrote: > > On Tue, May 5, 2020 at 1:50 PM John Fastabend > > wrote: > > > > > > Update test_sockmap to add ktls tests and in the process make output > > > easier to understand and reduce overall runtime significantly. Befor

Re: [PATCH net] ptp: fix struct member comment for do_aux_work

2020-05-11 Thread Richard Cochran
On Mon, May 11, 2020 at 02:02:15PM -0700, Jacob Keller wrote: > The do_aux_work callback had documentation in the structure comment > which referred to it as "do_work". > > Signed-off-by: Jacob Keller > Cc: Richard Cochran Thanks, Jacob, for cleaning this up! Acked-by: Richard Cochran

Re: [PATCH v5 bpf-next 2/3] bpf: implement CAP_BPF

2020-05-11 Thread Alexei Starovoitov
On Mon, May 11, 2020 at 05:12:10PM -0700, s...@google.com wrote: > On 05/08, Alexei Starovoitov wrote: > > From: Alexei Starovoitov > [..] > > @@ -3932,7 +3977,7 @@ SYSCALL_DEFINE3(bpf, int, cmd, union bpf_attr > > __user *, uattr, unsigned int, siz > > union bpf_attr attr; > > int err; >

Re: [PATCH net] dt-bindings: net: Convert UniPhier AVE4 controller to json-schema

2020-05-11 Thread Kunihiko Hayashi
Hi Rob, On 2020/05/12 11:01, Rob Herring wrote: On Tue, Apr 28, 2020 at 03:31:22PM +0900, Kunihiko Hayashi wrote: Convert the UniPhier AVE4 controller binding to DT schema format. This changes phy-handle property to required. Signed-off-by: Kunihiko Hayashi --- (snip) + phy-mode: +$r

Re: [PATCH net] dt-bindings: net: Convert UniPhier AVE4 controller to json-schema

2020-05-11 Thread Rob Herring
On Tue, Apr 28, 2020 at 03:31:22PM +0900, Kunihiko Hayashi wrote: > Convert the UniPhier AVE4 controller binding to DT schema format. > This changes phy-handle property to required. > > Signed-off-by: Kunihiko Hayashi > --- > .../bindings/net/socionext,uniphier-ave4.txt | 64

Re: [PATCH v1 net-next 3/3] net: dsa: felix: add support Credit Based Shaper(CBS) for hardware offload

2020-05-11 Thread Vinicius Costa Gomes
Xiaoliang Yang writes: > VSC9959 hardware support the Credit Based Shaper(CBS) which part > of the IEEE-802.1Qav. This patch support sch_cbs set for VSC9959. > > Signed-off-by: Xiaoliang Yang > --- > drivers/net/dsa/ocelot/felix_vsc9959.c | 52 +- > 1 file changed, 51 in

Re: linux-next boot error: WARNING: suspicious RCU usage in ip6mr_get_table

2020-05-11 Thread Stephen Rothwell
Hi all, On Fri, 8 May 2020 04:54:02 +0530 Madhuparna Bhowmik wrote: > > On Thu, May 07, 2020 at 08:50:55AM -0400, Qian Cai wrote: > > > > > > > On May 7, 2020, at 5:32 AM, Dmitry Vyukov wrote: > > > > > > On Thu, May 7, 2020 at 11:26 AM syzbot > > > wrote: > > >> > > >> Hello, > > >>

Re: [PATCH net-next 4/4] net: dsa: implement and use a generic procedure for the flow dissector

2020-05-11 Thread Vladimir Oltean
On Tue, 12 May 2020 at 02:15, Florian Fainelli wrote: > > > > On 5/11/2020 1:20 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > For all DSA formats that don't use tail tags, it looks like behind the > > obscure number crunching they're all doing the same thing: locating the > > real

[PATCH net] mptcp: Initialize map_seq upon subflow establishment

2020-05-11 Thread Christoph Paasch
When the other MPTCP-peer uses 32-bit data-sequence numbers, we rely on map_seq to indicate how to expand to a 64-bit data-sequence number in expand_seq() when receiving data. For new subflows, this field is not initialized, thus results in an "invalid" mapping being discarded. Fix this by initia

[RFC PATCH] sfc: siena_check_caps() can be static

2020-05-11 Thread kbuild test robot
Signed-off-by: kbuild test robot --- siena.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/siena.c b/drivers/net/ethernet/sfc/siena.c index ed1cb6caa69d9..4b4afe81be2a3 100644 --- a/drivers/net/ethernet/sfc/siena.c +++ b/drivers/net/ethernet

Re: [PATCH net-next 2/8] sfc: make capability checking a nic_type function

2020-05-11 Thread kbuild test robot
Hi Edward, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on linus/master v5.7-rc5 next-20200511] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest

[PATCH net-next 03/10] ionic: protect vf calls from fw reset

2020-05-11 Thread Shannon Nelson
When going into a firmware upgrade cycle, we set the device as not present to keep some user commands from trying to change the driver while we're only half there. Unfortunately, the ndo_vf_* calls don't check netif_device_present() so we need to add a check in the callbacks. Signed-off-by: Shann

[PATCH net-next 05/10] ionic: shorter dev cmd wait time

2020-05-11 Thread Shannon Nelson
Shorten our msleep time while polling for the dev command request to finish. Yes, checkpatch.pl complains that the msleep might actually go longer - that won't hurt, but we'll take the shorter time if we can get it. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_mai

[PATCH net-next 01/10] ionic: support longer tx sg lists

2020-05-11 Thread Shannon Nelson
The version 1 Tx queues can use longer SG lists than the original version 0 queues, but we need to check to see if the firmware supports the v1 Tx queues. This implements the queue type query for all queue types, and uses the information to set up for using the longer Tx SG lists. Because the Tx

[PATCH net-next 06/10] ionic: reset device at probe

2020-05-11 Thread Shannon Nelson
Once we're talking to the device, tell it to reset to be sure we've got a fresh, clean environment. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_main.c b/drivers/n

[PATCH net-next 10/10] ionic: update doc files

2020-05-11 Thread Shannon Nelson
Update the basic doc file with some configuration hints and a little bit of stats information. Signed-off-by: Shannon Nelson --- .../device_drivers/pensando/ionic.rst | 231 +- 1 file changed, 230 insertions(+), 1 deletion(-) diff --git a/Documentation/networking/device_

[PATCH net-next 07/10] ionic: ionic_intr_free parameter change

2020-05-11 Thread Shannon Nelson
Change the ionic_intr_free parameter from struct ionic_lif to struct ionic since that's what it actually cares about. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/eth

[PATCH net-next 04/10] ionic: add support for more xcvr types

2020-05-11 Thread Shannon Nelson
Add a couple more SFP and QSFP transceiver types to our ethtool get link ksettings. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethe

[PATCH net-next 08/10] ionic: more ionic name tweaks

2020-05-11 Thread Shannon Nelson
Fix up a few more local names that need an "ionic" prefix. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_dev.h | 10 +- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 13 +++-- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 4 ++--

[PATCH net-next 09/10] ionic: add more ethtool stats

2020-05-11 Thread Shannon Nelson
Add hardware port stats and a few more driver collected statistics to the ethtool stats output. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_lif.c | 4 +- .../net/ethernet/pensando/ionic/ionic_lif.h | 15 +- .../net/ethernet/pensando/ionic/ionic_stats.c | 136 ++

[PATCH net-next 02/10] ionic: updates to ionic FW api description

2020-05-11 Thread Shannon Nelson
Lots of comment cleanup for better documentation, a few new fields added, and a few minor mistakes fixed up. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_if.h| 979 +++--- 1 file changed, 576 insertions(+), 403 deletions(-) diff --git a/drivers/net/eth

[PATCH net-next 00/10] ionic updates

2020-05-11 Thread Shannon Nelson
This set of patches is a bunch of code cleanup, a little documentation, longer tx sg lists, more ethtool stats, and a couple more transceiver types. Shannon Nelson (10): ionic: support longer tx sg lists ionic: updates to ionic FW api description ionic: protect vf calls from fw reset ionic

Re: [PATCH net-next 3/4] net: ethernet: introduce phy_set_pause

2020-05-11 Thread Andrew Lunn
On Mon, May 11, 2020 at 05:24:09PM -0700, Doug Berger wrote: > This commit introduces the phy_set_pause function to the phylib as > a helper to support the set_pauseparam ethtool method. > > It is hoped that the new behavior introduced by this function will > be widely embraced and the phy_set_sym

Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting

2020-05-11 Thread Andrew Lunn
On Mon, May 11, 2020 at 05:24:07PM -0700, Doug Berger wrote: > A comment in uapi/linux/ethtool.h states "Drivers should reject a > non-zero setting of @autoneg when autoneogotiation is disabled (or > not supported) for the link". > > That check should be added to phy_validate_pause() to consolidat

Re: [PATCH bpf-next] samples/bpf: xdp_redirect_cpu: set MAX_CPUS according to NR_CPUS

2020-05-11 Thread Yonghong Song
On 5/11/20 1:24 PM, Lorenzo Bianconi wrote: xdp_redirect_cpu is currently failing in bpf_prog_load_xattr() allocating cpu_map map if CONFIG_NR_CPUS is less than 64 since cpu_map_alloc() requires max_entries to be less than NR_CPUS. Set cpu_map max_entries according to NR_CPUS in xdp_redirect_c

[PATCH net-next 1/4] net: ethernet: validate pause autoneg setting

2020-05-11 Thread Doug Berger
A comment in uapi/linux/ethtool.h states "Drivers should reject a non-zero setting of @autoneg when autoneogotiation is disabled (or not supported) for the link". That check should be added to phy_validate_pause() to consolidate the code where possible. Fixes: 22b7d29926b5 ("net: ethernet: Add he

[PATCH net-next 2/4] net: add autoneg parameter to linkmode_set_pause

2020-05-11 Thread Doug Berger
This commit introduces a new parameter to linkmode_set_pause to provide a mechanism to specify two alternative mappings of the pause parameters for advertisement by the PHY. An argument is made that the advertisement through Pause and AsymPause of the desired Rx and Tx pause frame use should be di

[PATCH net-next 3/4] net: ethernet: introduce phy_set_pause

2020-05-11 Thread Doug Berger
This commit introduces the phy_set_pause function to the phylib as a helper to support the set_pauseparam ethtool method. It is hoped that the new behavior introduced by this function will be widely embraced and the phy_set_sym_pause and phy_set_asym_pause functions can be deprecated. Those functi

[PATCH net-next 4/4] net: bcmgenet: add support for ethtool flow control

2020-05-11 Thread Doug Berger
This commit extends the supported ethtool operations to allow MAC level flow control to be configured for the bcmgenet driver. It provides an example of how the new phy_set_pause function and the phy_validate_pause function can be used to configure the desired PHY advertising as well as how the phy

[PATCH net-next 0/4] Extend phylib implementation of pause support

2020-05-11 Thread Doug Berger
This commit set extends the implementation introduced by commit 5652b46e4e80 ("Merge branch 'Pause-updates-for-phylib-and-phylink'") to support the less problematic behavior alluded to by Russell King's comment in commit f904f15ea9b5 ("net: phylink: allow ethtool -A to change flow control advertise

Re: [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' by sysfs

2020-05-11 Thread J. Bruce Fields
On Fri, May 08, 2020 at 09:32:59AM +0800, Xiongfeng Wang wrote: > When I cat parameter '/sys/module/sunrpc/parameters/pool_mode', it > displays as follows. It is better to add a newline for easy reading. Applying for 5.8. I assume Trond's getting the other patch. --b. > > [root@hulk-202 ~]# ca

Re: [PATCH v1 net-next 2/3] net: dsa: felix: Configure Time-Aware Scheduler via taprio offload

2020-05-11 Thread Vladimir Oltean
On Tue, 12 May 2020 at 02:54, David Miller wrote: > > From: Xiaoliang Yang > Date: Mon, 11 May 2020 13:43:31 +0800 > > > @@ -710,7 +714,7 @@ static void felix_port_policer_del(struct dsa_switch > > *ds, int port) > > ocelot_port_policer_del(ocelot, port); > > } > > > > -static const struc

Re: net/sonic: Fix some resource leaks in error handling paths

2020-05-11 Thread Finn Thain
On Mon, 11 May 2020, Markus Elfring wrote: > > If you can't determine when the bug was introduced, > > I might be able to determine also this information. > This is tantamount to an admission of duplicity. > > > how can you criticise a patch for the lack of a Fixes tag? > > I dared to point

Re: [PATCH net-next 0/4] DSA: promisc on master, generic flow dissector code

2020-05-11 Thread Florian Fainelli
On 5/11/2020 4:52 PM, Vladimir Oltean wrote: > On Tue, 12 May 2020 at 02:28, Florian Fainelli wrote: >> >> >> >> On 5/11/2020 1:20 PM, Vladimir Oltean wrote: >>> From: Vladimir Oltean >>> >>> The initial purpose of this series was to implement the .flow_dissect >>> method for sja1105 and for o

Re: [RFC][PATCHES] uaccess-related stuff in net/*

2020-05-11 Thread David Miller
From: Al Viro Date: Mon, 11 May 2020 05:43:28 +0100 > Assorted uaccess-related work in net/*. First, there's > getting rid of compat_alloc_user_space() mess in MCAST_... > [gs]etsockopt() - no need to play with copying to/from temporary > object on userland stack, etc., when ->compat_[sg]e

Re: [RFC PATCH bpf-next 0/1] bpf, x64: optimize JIT prologue/epilogue generation

2020-05-11 Thread Alexei Starovoitov
On Mon, May 11, 2020 at 10:05:25PM +0200, Daniel Borkmann wrote: > Hey Maciej, > > On 5/11/20 4:39 PM, Maciej Fijalkowski wrote: > > Hi! > > > > Today, BPF x86-64 JIT is preserving all of the callee-saved registers > > for each BPF program being JITed, even when none of the R6-R9 registers > > ar

Re: [PATCH net-next v3] checkpatch: warn about uses of ENOTSUPP

2020-05-11 Thread David Miller
From: Jakub Kicinski Date: Mon, 11 May 2020 10:08:07 -0700 > ENOTSUPP often feels like the right error code to use, but it's > in fact not a standard Unix error. E.g.: > > $ python import errno errno.errorcode[errno.ENOTSUPP] > Traceback (most recent call last): > File "", line 1, in

Re: improve msg_control kernel vs user pointer handling

2020-05-11 Thread David Miller
From: Christoph Hellwig Date: Mon, 11 May 2020 13:59:10 +0200 > this series replace the msg_control in the kernel msghdr structure > with an anonymous union and separate fields for kernel vs user > pointers. In addition to helping a bit with type safety and reducing > sparse warnings, this also

Re: [PATCH v2 net-next 03/15] net: dsa: sja1105: keep the VLAN awareness state in a driver variable

2020-05-11 Thread Vladimir Oltean
port-for-dsa_8021q-in-vlan_filtering-1-mode/20200512-024329 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > a6f0b26d6a5dcf27980e65f965779a929039f11d > config: xtensa-randconfig-r021-20200511 (attached as .config) > compiler: xtensa-linux-gcc (GCC) 9.3.0 > r

Re: [PATCH v1 net-next 2/3] net: dsa: felix: Configure Time-Aware Scheduler via taprio offload

2020-05-11 Thread David Miller
From: Xiaoliang Yang Date: Mon, 11 May 2020 13:43:31 +0800 > @@ -710,7 +714,7 @@ static void felix_port_policer_del(struct dsa_switch *ds, > int port) > ocelot_port_policer_del(ocelot, port); > } > > -static const struct dsa_switch_ops felix_switch_ops = { > +static struct dsa_switch_op

Re: [PATCH net-next 0/4] DSA: promisc on master, generic flow dissector code

2020-05-11 Thread Vladimir Oltean
On Tue, 12 May 2020 at 02:28, Florian Fainelli wrote: > > > > On 5/11/2020 1:20 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > The initial purpose of this series was to implement the .flow_dissect > > method for sja1105 and for ocelot/felix. But on Felix this posed a > > problem, as

Re: [PATCH net-next 0/2] net: dsa: Constify two tagger ops

2020-05-11 Thread David Miller
From: Florian Fainelli Date: Mon, 11 May 2020 16:47:13 -0700 > This patch series constifies the dsa_device_ops for ocelot and sja1105 Series applied, thanks Florian.

[PATCH net-next 1/2] net: dsa: ocelot: Constify dsa_device_ops

2020-05-11 Thread Florian Fainelli
ocelot_netdev_ops should be const since that is what the DSA layer expects. Signed-off-by: Florian Fainelli --- net/dsa/tag_ocelot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/tag_ocelot.c b/net/dsa/tag_ocelot.c index 59de1315100f..b0c98ee4e13b 100644 --- a/net/d

[PATCH net-next 2/2] net: dsa: tag_sja1105: Constify dsa_device_ops

2020-05-11 Thread Florian Fainelli
sja1105_netdev_ops should be const since that is what the DSA layer expects. Signed-off-by: Florian Fainelli --- net/dsa/tag_sja1105.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c index d553bf36bd41..5ecac5921a7d 100644 --- a/n

[PATCH net-next 0/2] net: dsa: Constify two tagger ops

2020-05-11 Thread Florian Fainelli
This patch series constifies the dsa_device_ops for ocelot and sja1105 Florian Fainelli (2): net: dsa: ocelot: Constify dsa_device_ops net: dsa: tag_sja1105: Constify dsa_device_ops net/dsa/tag_ocelot.c | 2 +- net/dsa/tag_sja1105.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH net-next 0/4] DSA: promisc on master, generic flow dissector code

2020-05-11 Thread Florian Fainelli
On 5/11/2020 1:20 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The initial purpose of this series was to implement the .flow_dissect > method for sja1105 and for ocelot/felix. But on Felix this posed a > problem, as the DSA headers were of different lengths on RX and on TX. > A bette

Re: [PATCH net-next 3/4] net: dsa: tag_ocelot: use a short prefix on both ingress and egress

2020-05-11 Thread Florian Fainelli
On 5/11/2020 1:20 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > There are 2 goals that we follow: > > - Reduce the header size > - Make the header size equal between RX and TX > > The issue that required long prefix on RX was the fact that the ocelot > DSA tag, being put before Ethe

Re: [PATCH net-next 1/4] net: dsa: allow drivers to request promiscuous mode on master

2020-05-11 Thread Florian Fainelli
On 5/11/2020 1:20 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently DSA assumes that taggers don't mess with the destination MAC > address of the frames on RX. That is not always the case. Some DSA > headers are placed before the Ethernet header (ocelot), and others > simply man

Re: [PATCH net-next 2/4] net: dsa: sja1105: request promiscuous mode for master

2020-05-11 Thread Florian Fainelli
On 5/11/2020 1:20 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently PTP is broken when ports are in standalone mode (the tagger > keeps printing this message): > > sja1105 spi0.1: Expected meta frame, is 180c20e in the DSA master > multicast filter? > > Sure, one might s

Re: [PATCH net-next 3/4] net: dsa: tag_ocelot: use a short prefix on both ingress and egress

2020-05-11 Thread Vladimir Oltean
On Tue, 12 May 2020 at 02:11, David Miller wrote: > > From: Vladimir Oltean > Date: Tue, 12 May 2020 01:44:53 +0300 > > > On Tue, 12 May 2020 at 01:40, Jakub Kicinski wrote: > >> > >> On Mon, 11 May 2020 23:20:45 +0300 Vladimir Oltean wrote: > >> > From: Vladimir Oltean > >> > > >> > There are

Re: [PATCH net-next 4/4] net: dsa: implement and use a generic procedure for the flow dissector

2020-05-11 Thread Florian Fainelli
On 5/11/2020 1:20 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > For all DSA formats that don't use tail tags, it looks like behind the > obscure number crunching they're all doing the same thing: locating the > real EtherType behind the DSA tag. Nonetheless, this is not immediately >

RE: [PATCH v2] igb: Report speed and duplex as unknown when device is runtime suspended

2020-05-11 Thread Brown, Aaron F
> From: Kai-Heng Feng > Sent: Monday, May 4, 2020 9:02 PM > To: Kirsher, Jeffrey T > Cc: Kai-Heng Feng ; Brown, Aaron F > ; David S. Miller ; > moderated list:INTEL ETHERNET DRIVERS ; > open list:NETWORKING DRIVERS ; open list ker...@vger.kernel.org> > Subject: [PATCH v2] igb: Report speed and d

  1   2   3   4   >