Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Vlad Buslov
On Tue 22 Oct 2019 at 20:09, Marcelo Ricardo Leitner wrote: > On Tue, Oct 22, 2019 at 03:52:31PM +, Vlad Buslov wrote: >> >> On Tue 22 Oct 2019 at 18:15, Marcelo Ricardo Leitner >> wrote: >> > On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: >> >> - Extend actions that are use

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Vlad Buslov
On Tue 22 Oct 2019 at 21:17, Roman Mashak wrote: > Vlad Buslov writes: > >> On Tue 22 Oct 2019 at 17:35, Marcelo Ricardo Leitner >> wrote: >>> On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: Currently, significant fraction of CPU time during TC filter allocation is spen

RE: [PATCH net-next v2 5/6] dpaa_eth: change DMA device

2019-10-22 Thread Madalin-cristian Bucur
> -Original Message- > From: Jakub Kicinski > Sent: Wednesday, October 23, 2019 12:15 AM > To: Madalin-cristian Bucur > Cc: da...@davemloft.net; netdev@vger.kernel.org; Roy Pledge > ; Laurentiu Tudor > Subject: Re: [PATCH net-next v2 5/6] dpaa_eth: change DMA device > > On Tue, 22 Oct 2

Re: [libbpf] 651b775f02: kernel_selftests.bpf.test_section_names.fail

2019-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2019 at 9:25 PM kernel test robot wrote: > > FYI, we noticed the following commit (built with gcc-7): > > commit: 651b775f027f9758740d748cc08c5a0661f13bb7 ("[PATCH bpf-next 4/7] > libbpf: teach bpf_object__open to guess program types") > url: > https://github.com/0day-ci/linux/co

[PATCH bpf-next] selftests/bpf: move test_section_names into test_progs and fix it

2019-10-22 Thread Andrii Nakryiko
Make test_section_names into test_progs test. Also fix ESRCH expected results. Add uprobe/uretprobe and tp/raw_tp test cases. Fixes: dd4436bb8383 ("libbpf: Teach bpf_object__open to guess program types") Reported-by: kernel test robot Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/b

[PATCH net-next 2/2] mlxsw: spectrum_buffers: Calculate the size of the main pool

2019-10-22 Thread Ido Schimmel
From: Petr Machata Instead of hard-coding the size of the largest pool, calculate it from the reported guaranteed shared buffer size and sizes of other pools (currently only the CPU port pool). Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- .../mellanox/mlxsw/spectrum_buffers.c

[PATCH net-next 0/2] mlxsw: Update main pool computation and pool size limits

2019-10-22 Thread Ido Schimmel
From: Ido Schimmel Petr says: In Spectrum ASICs, the shared buffer is an area of memory where packets are kept until they can be transmitted. There are two resources associated with shared buffer size: cap_total_buffer_size and cap_guaranteed_shared_buffer. So far, mlxsw has been using the forme

[PATCH net-next 1/2] mlxsw: spectrum: Use guaranteed buffer size as pool size limit

2019-10-22 Thread Ido Schimmel
From: Petr Machata There are two resources associated with shared buffer size: cap_total_buffer_size, and cap_guaranteed_shared_buffer. So far, mlxsw has been using the former as a limit to determine how large a pool size is allowed to be. However, the total size also includes headrooms and reser

Re: [PATCH v2] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-22 Thread Martin Varghese
On Tue, Oct 22, 2019 at 08:59:46PM -0700, Pravin Shelar wrote: > On Tue, Oct 22, 2019 at 8:29 AM Martin Varghese > wrote: > > > > On Tue, Oct 22, 2019 at 12:03:49AM -0700, Pravin Shelar wrote: > > > On Sun, Oct 20, 2019 at 7:12 AM Martin Varghese > > > wrote: > > > > > > > > From: Martin Varghese

Re: [PATCH bpf] bpf: Fix use after free in bpf_get_prog_name

2019-10-22 Thread Alexei Starovoitov
On Tue, Oct 22, 2019 at 2:30 PM Daniel Borkmann wrote: > > There is one more problematic case I noticed while recently fixing BPF > kallsyms > handling in cd7455f1013e ("bpf: Fix use after free in subprog's jited symbol > removal") and that is bpf_get_prog_name(). > > If BTF has been attached to

Re: [PATCH iproute2-next] Add tc-BPF example for a TCP pure ack recognizer

2019-10-22 Thread Dave Taht
On Mon, Oct 21, 2019 at 4:48 PM Stephen Hemminger wrote: > > On Tue, 1 May 2018 11:32:41 -0700 > Dave Taht wrote: > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright 2017 Google Inc. > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify

Re: [PATCH bpf-next 3/3] libbpf: Add pin option to automount BPF filesystem before pinning

2019-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2019 at 12:04 PM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen > > wrote: > >> > >> From: Toke Høiland-Jørgensen > >> > >> While the current map pinning functions will check whether the pin path is > >> co

Re: [PATCH bpf-next 2/3] libbpf: Support configurable pinning of maps from BTF annotations

2019-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2019 at 11:57 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen > > wrote: > >> > >> From: Toke Høiland-Jørgensen > >> > >> This adds support to libbpf for setting map pinning information as part of > >> th

Re: [PATCH bpf-next 1/3] libbpf: Store map pin path in struct bpf_map

2019-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2019 at 12:06 PM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Tue, Oct 22, 2019 at 11:45 AM Toke Høiland-Jørgensen > > wrote: > >> > >> Andrii Nakryiko writes: > >> > >> > On Tue, Oct 22, 2019 at 11:13 AM Toke Høiland-Jørgensen > >> > wrote: > >> >> > >>

Re: Linux-5.4: bpf: test_core_reloc_arrays.o: Segmentation fault with llc -march=bpf

2019-10-22 Thread Yonghong Song
On 10/22/19 8:29 PM, Prabhakar Kushwaha wrote: > Thanks Yonghong for replying. > > > > On Wed, Oct 23, 2019 at 8:04 AM Yonghong Song wrote: >> >> >> >> On 10/22/19 6:35 PM, Prabhakar Kushwaha wrote: >>> >>>Adding other mailing list, folks... >>> >>> Hi All, >>> >>> I am trying to build ks

Re: [PATCH v2] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-22 Thread Pravin Shelar
On Tue, Oct 22, 2019 at 8:29 AM Martin Varghese wrote: > > On Tue, Oct 22, 2019 at 12:03:49AM -0700, Pravin Shelar wrote: > > On Sun, Oct 20, 2019 at 7:12 AM Martin Varghese > > wrote: > > > > > > From: Martin Varghese > > > > > > The openvswitch was supporting a MPLS label depth of 1 in the ing

[PATCH firmware] rtl_nic: add firmware files for RTL8153

2019-10-22 Thread Hayes Wang
This adds the firmware for Realtek RTL8153 Based USB Ethernet Adapters. 1. Fix compatible issue for Asmedia hub. 2. Fix compatible issue for Compal platform. 3. Fix sometimes the device is lost after rebooting. 4. Improve the compatibility for EEE. Signed-off-by: Hayes Wang --- WHENCE

Re: Linux-5.4: bpf: test_core_reloc_arrays.o: Segmentation fault with llc -march=bpf

2019-10-22 Thread Prabhakar Kushwaha
Thanks Yonghong for replying. On Wed, Oct 23, 2019 at 8:04 AM Yonghong Song wrote: > > > > On 10/22/19 6:35 PM, Prabhakar Kushwaha wrote: > > > > Adding other mailing list, folks... > > > > Hi All, > > > > I am trying to build kselftest on Linux-5.4 on ubuntu 18.04. I installed > > LLVM-9.0.0

Re: [PATCH v15 1/5] fs/nsfs.c: added ns_match

2019-10-22 Thread Yonghong Song
Hi, Eric, Could you take a look at this patch the series as well? If it looks good, could you ack the patch #1? Thanks! On 10/22/19 12:17 PM, Carlos Neira wrote: > ns_match returns true if the namespace inode and dev_t matches the ones > provided by the caller. > > Signed-off-by: Carlos Neira

Re: [PATCH v15 5/5] bpf_helpers_doc.py: Add struct bpf_pidns_info to known types

2019-10-22 Thread Yonghong Song
On 10/22/19 12:17 PM, Carlos Neira wrote: > Add struct bpf_pidns_info to known types > > Signed-off-by: Carlos Neira Acked-by: Yonghong Song > --- > scripts/bpf_helpers_doc.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/bpf_helpers_doc.py b/scripts/bpf_helpers_doc.py

Re: [PATCH v15 4/5] tools/testing/selftests/bpf: Add self-tests for new helper.

2019-10-22 Thread Yonghong Song
On 10/22/19 12:17 PM, Carlos Neira wrote: > Self tests added for new helper Please mention the name of the new helper in the commit message. > > Signed-off-by: Carlos Neira LGTM Ack with a few nits below. Acked-by: Yonghong Song > --- > .../bpf/prog_tests/ns_current_pid_tgid.c | 87

Re: [PATCH v15 3/5] tools: Added bpf_get_ns_current_pid_tgid helper

2019-10-22 Thread Yonghong Song
On 10/22/19 12:17 PM, Carlos Neira wrote: > sync tools/include/uapi/linux/bpf.h to include new helper. > > Signed-off-by: Carlos Neira Acked-by: Yonghong Song > --- > tools/include/uapi/linux/bpf.h | 20 +++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --gi

Re: [PATCH v15 2/5] bpf: added new helper bpf_get_ns_current_pid_tgid

2019-10-22 Thread Yonghong Song
On 10/22/19 12:17 PM, Carlos Neira wrote: > New bpf helper bpf_get_ns_current_pid_tgid, > This helper will return pid and tgid from current task > which namespace matches dev_t and inode number provided, > this will allows us to instrument a process inside a container. > > Signed-off-by: Carlos

Re: [PATCH net-next 2/6] ionic: reverse an interrupt coalesce calculation

2019-10-22 Thread Jakub Kicinski
On Tue, 22 Oct 2019 19:09:40 -0700, Shannon Nelson wrote: > On 10/22/19 6:22 PM, Andrew Lunn wrote: > > On Tue, Oct 22, 2019 at 01:31:09PM -0700, Shannon Nelson wrote: > >> Fix the initial interrupt coalesce usec-to-hw setting > >> to actually be usec-to-hw. > >> > >> Fixes: 780eded34ccc ("ionic:

Re: [PATCH net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.

2019-10-22 Thread Martin Varghese
On Fri, Oct 18, 2019 at 10:59:47AM -0400, Willem de Bruijn wrote: > On Fri, Oct 18, 2019 at 4:20 AM Martin Varghese > wrote: > > > > On Thu, Oct 17, 2019 at 04:48:26PM -0400, Willem de Bruijn wrote: > > > On Thu, Oct 17, 2019 at 9:20 AM Martin Varghese > > > wrote: > > > > > > > > On Tue, Oct 08,

Re: [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-10-22 Thread Tonghao Zhang
On Tue, Oct 22, 2019 at 2:58 PM Pravin Shelar wrote: > > On Sun, Oct 20, 2019 at 10:02 PM Tonghao Zhang > wrote: > > > > On Sat, Oct 19, 2019 at 2:12 AM Pravin Shelar wrote: > > > > > > On Thu, Oct 17, 2019 at 8:16 PM Tonghao Zhang > > > wrote: > > > > > > > > On Fri, Oct 18, 2019 at 6:38 AM

Re: Linux-5.4: bpf: test_core_reloc_arrays.o: Segmentation fault with llc -march=bpf

2019-10-22 Thread Yonghong Song
On 10/22/19 6:35 PM, Prabhakar Kushwaha wrote: > > Adding other mailing list, folks... > > Hi All, > > I am trying to build kselftest on Linux-5.4 on ubuntu 18.04. I installed > LLVM-9.0.0 and Clang-9.0.0 from below links after following steps from > [1] because of discussion [2] Could you

Re: [Patch net-next 3/3] tcp: decouple TLP timer from RTO timer

2019-10-22 Thread Eric Dumazet
On Tue, Oct 22, 2019 at 6:10 PM Cong Wang wrote: > > On Tue, Oct 22, 2019 at 4:24 PM Eric Dumazet wrote: > > > > On Tue, Oct 22, 2019 at 4:11 PM Cong Wang wrote: > > > > > > Currently RTO, TLP and PROBE0 all share a same timer instance > > > in kernel and use icsk->icsk_pending to dispatch the w

Re: [PATCH net-next 2/6] ionic: reverse an interrupt coalesce calculation

2019-10-22 Thread Shannon Nelson
On 10/22/19 6:22 PM, Andrew Lunn wrote: On Tue, Oct 22, 2019 at 01:31:09PM -0700, Shannon Nelson wrote: Fix the initial interrupt coalesce usec-to-hw setting to actually be usec-to-hw. Fixes: 780eded34ccc ("ionic: report users coalesce request") Signed-off-by: Shannon Nelson Hi Shannon How b

RE: [Intel-wired-lan] [next-queue PATCH v2 2/2] e1000e: Drop unnecessary __E1000_DOWN bit twiddling

2019-10-22 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Alexander Duyck > Sent: Friday, October 11, 2019 8:35 AM > To: alexander.h.du...@linux.intel.com; intel-wired-...@lists.osuosl.org; > Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; z...@us.ibm.com; z...@linux.vnet.ibm.com > Subject: [Intel-wired-lan] [next

RE: [next-queue PATCH v2 1/2] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-22 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org > On Behalf Of Alexander Duyck > Sent: Friday, October 11, 2019 8:35 AM > To: alexander.h.du...@linux.intel.com; intel-wired-...@lists.osuosl.org; > Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; z...@us.ibm.com; z...@linux.vnet.ibm.com > Subject: [next-queu

Linux-5.4: bpf: test_core_reloc_arrays.o: Segmentation fault with llc -march=bpf

2019-10-22 Thread Prabhakar Kushwaha
Adding other mailing list, folks... Hi All, I am trying to build kselftest on Linux-5.4 on ubuntu 18.04. I installed LLVM-9.0.0 and Clang-9.0.0 from below links after following steps from [1] because of discussion [2] https://releases.llvm.org/9.0.0/llvm-9.0.0.src.tar.xz https://releases.ll

Re: [PATCH net-next 2/6] ionic: reverse an interrupt coalesce calculation

2019-10-22 Thread Andrew Lunn
On Tue, Oct 22, 2019 at 01:31:09PM -0700, Shannon Nelson wrote: > Fix the initial interrupt coalesce usec-to-hw setting > to actually be usec-to-hw. > > Fixes: 780eded34ccc ("ionic: report users coalesce request") > Signed-off-by: Shannon Nelson Hi Shannon How bad is this? Should it be backport

Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Add support for port mirroring

2019-10-22 Thread Andrew Lunn
On Mon, Oct 21, 2019 at 11:01:43PM +0200, Iwan R Timmer wrote: > Add support for configuring port mirroring through the cls_matchall > classifier. We do a full ingress and/or egress capture towards a > capture port. It allows setting a different capture port for ingress > and egress traffic. > > I

Re: [Patch net-next 3/3] tcp: decouple TLP timer from RTO timer

2019-10-22 Thread Cong Wang
On Tue, Oct 22, 2019 at 4:24 PM Eric Dumazet wrote: > > On Tue, Oct 22, 2019 at 4:11 PM Cong Wang wrote: > > > > Currently RTO, TLP and PROBE0 all share a same timer instance > > in kernel and use icsk->icsk_pending to dispatch the work. > > This causes spinlock contention when resetting the time

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Split monitor port configuration

2019-10-22 Thread Andrew Lunn
On Mon, Oct 21, 2019 at 11:01:42PM +0200, Iwan R Timmer wrote: > Separate the configuration of the egress and ingress monitor port. > This allows the port mirror functionality to do ingress and egress > port mirroring to separate ports. > > Signed-off-by: Iwan R Timmer > --- > drivers/net/dsa/mv

Re: [PATCH] net: forcedeth: add xmit_more support

2019-10-22 Thread Zhu Yanjun
On 2019/10/22 23:40, Jakub Kicinski wrote: On Tue, 22 Oct 2019 13:32:35 +0800, Zhu Yanjun wrote: On 2019/10/21 23:33, Jakub Kicinski wrote: On Mon, 21 Oct 2019 17:56:06 +0800, Zhu Yanjun wrote: On 2019/10/19 6:48, Jakub Kicinski wrote: On Fri, 18 Oct 2019 06:01:25 -0400, Zhu Yanjun wrote:

Re: [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

2019-10-22 Thread Stefano Brivio
Hi Jakub, On Tue, 22 Oct 2019 14:53:16 -0700 Jakub Kicinski wrote: > On Mon, 21 Oct 2019 12:01:57 +0200, Stefano Brivio wrote: > > From: Hillf Danton > > > > syzbot found the following crash on: > > > The function in net core, register_netdevice(), may fail with vport's > > destruction cal

Re: [PATCH net-next 5/6] ionic: implement support for rx sgl

2019-10-22 Thread Shannon Nelson
On 10/22/19 4:37 PM, Jakub Kicinski wrote: On Tue, 22 Oct 2019 13:31:12 -0700, Shannon Nelson wrote: diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c index ab6663d94f42..8c96f5fe43a2 100644 --- a/drivers/net/ethernet/pensando/ionic

[PATCH net-next] xsk: Enable AF_XDP by default.

2019-10-22 Thread William Tu
The patch enables XDP_SOCKETS and XDP_SOCKETS_DIAG used by AF_XDP, and its dependency on BPF_SYSCALL. Signed-off-by: William Tu --- init/Kconfig| 2 +- net/xdp/Kconfig | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index b4daad2bac23..229

Re: [PATCH net-next 5/6] ionic: implement support for rx sgl

2019-10-22 Thread Jakub Kicinski
On Tue, 22 Oct 2019 13:31:12 -0700, Shannon Nelson wrote: > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c > b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c > index ab6663d94f42..8c96f5fe43a2 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c > +++ b/drivers/net/ethe

Re: [Patch net-next 3/3] tcp: decouple TLP timer from RTO timer

2019-10-22 Thread Eric Dumazet
On Tue, Oct 22, 2019 at 4:11 PM Cong Wang wrote: > > Currently RTO, TLP and PROBE0 all share a same timer instance > in kernel and use icsk->icsk_pending to dispatch the work. > This causes spinlock contention when resetting the timer is > too frequent, as clearly shown in the perf report: > >

[Patch net-next 2/3] tcp: make tcp_send_loss_probe() boolean

2019-10-22 Thread Cong Wang
Let tcp_send_loss_probe() return whether a TLP has been sent or not. This is needed by the folllowing patch. Cc: Eric Dumazet Signed-off-by: Cong Wang --- include/net/tcp.h | 2 +- net/ipv4/tcp_output.c | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/include/net/

[Patch net-next 1/3] tcp: get rid of ICSK_TIME_EARLY_RETRANS

2019-10-22 Thread Cong Wang
After commit bec41a11dd3d ("tcp: remove early retransmit") ICSK_TIME_EARLY_RETRANS is no longer effective, so we can remove its definition too. Cc: Yuchung Cheng Cc: Eric Dumazet Signed-off-by: Cong Wang --- include/net/inet_connection_sock.h | 8 +++- 1 file changed, 3 insertions(+), 5 de

[Patch net-next 0/3] tcp: decouple TLP timer from RTO timer

2019-10-22 Thread Cong Wang
This patchset contains 3 patches: patch 1 is a cleanup, patch 2 is a small change preparing for patch 3, patch 3 is the one does the actual change. Please find details in each of them. --- Cong Wang (3): tcp: get rid of ICSK_TIME_EARLY_RETRANS tcp: make tcp_send_loss_probe() boolean tcp: dec

[Patch net-next 3/3] tcp: decouple TLP timer from RTO timer

2019-10-22 Thread Cong Wang
Currently RTO, TLP and PROBE0 all share a same timer instance in kernel and use icsk->icsk_pending to dispatch the work. This causes spinlock contention when resetting the timer is too frequent, as clearly shown in the perf report: 61.72%61.71% swapper [kernel.kallsyms]

Re: [PATCH net-next 2/6] sfc: perform XDP processing on received packets.

2019-10-22 Thread Jesper Dangaard Brouer
On Tue, 22 Oct 2019 16:38:27 +0100 Charles McLachlan wrote: > +/** efx_do_xdp: perform XDP processing on a received packet > + * > + * Returns true if packet should still be delivered. > + */ > +static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel, > +struct

Re: [PATCH net-next] fq_codel: do not include

2019-10-22 Thread Jakub Kicinski
On Tue, 22 Oct 2019 09:39:36 -0700, Eric Dumazet wrote: > Since commit 342db221829f ("sched: Call skb_get_hash_perturb > in sch_fq_codel") we no longer need anything from this file. > > Signed-off-by: Eric Dumazet Applied, thanks!

Re: [PATCH net-next 1/6] sfc: support encapsulation of xdp_frames in efx_tx_buffer.

2019-10-22 Thread Jesper Dangaard Brouer
On Tue, 22 Oct 2019 16:37:53 +0100 Charles McLachlan wrote: > Add a field to efx_tx_buffer so that we can track xdp_frames. Add a > flag so that buffers that contain xdp_frames can be identified and > passed to xdp_return_frame. > > Signed-off-by: Charles McLachlan > --- > drivers/net/ethernet

Re: [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

2019-10-22 Thread Jakub Kicinski
On Mon, 21 Oct 2019 12:01:57 +0200, Stefano Brivio wrote: > From: Hillf Danton > > syzbot found the following crash on: > The function in net core, register_netdevice(), may fail with vport's > destruction callback either invoked or not. After commit 309b66970ee2, I've added the correct commit

[PATCH bpf] bpf: Fix use after free in bpf_get_prog_name

2019-10-22 Thread Daniel Borkmann
There is one more problematic case I noticed while recently fixing BPF kallsyms handling in cd7455f1013e ("bpf: Fix use after free in subprog's jited symbol removal") and that is bpf_get_prog_name(). If BTF has been attached to the prog, then we may be able to fetch the function signature type id

Re: [PATCH net-next v2 5/6] dpaa_eth: change DMA device

2019-10-22 Thread Jakub Kicinski
On Tue, 22 Oct 2019 14:15:00 +0300, Madalin Bucur wrote: > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > index 8d5686d88d30..639cafaa59b8 100644 > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > +++ b/drivers/net/ethernet/fr

Re: [PATCH net] selftests: Make l2tp.sh executable

2019-10-22 Thread Jakub Kicinski
On Mon, 21 Oct 2019 19:02:43 -0600, David Ahern wrote: > From: David Ahern > > Kernel test robot reported that the l2tp.sh test script failed: > # selftests: net: l2tp.sh > # Warning: file l2tp.sh is not executable, correct this. > > Set executable bits. > > Fixes: e858ef1cd4bc ("selfte

[PATCH iproute2] ipnetns: do not check netns NAME when -all is specified

2019-10-22 Thread Michał Łyszczek
When `-all' argument is specified netns runs cmd on all namespaces and NAME is not used, but netns nevertheless checks if argv[1] is a valid namespace name ignoring the fact that argv[1] contains cmd and not NAME. This results in bug where user cannot specify absolute path to command. # ip -al

[PATCH net-next 0/6] ionic updates

2019-10-22 Thread Shannon Nelson
These are a few of the driver updates we've been working on internally. These clean up a few mismatched struct comments, add checking for dead firmware, fix an initialization bug, and change the Rx buffer management. These are based on net-next v5.4-rc3-709-g985fd98ab5cc. Shannon Nelson (6): io

[PATCH net-next 3/6] ionic: add heartbeat check

2019-10-22 Thread Shannon Nelson
Most of our firmware has a heartbeat feature that the driver can watch for to see if the FW is still alive and likely to answer a dev_cmd or AdminQ request. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_dev.c | 43 +++ .../net/ethernet/pensando/ionic/i

[PATCH net-next 1/6] ionic: fix up struct name comments

2019-10-22 Thread Shannon Nelson
Fix up struct names in the ionic_if.h comments Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_if.h| 196 +- 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_if.h b/drivers/net/ethernet/pensando

[PATCH net-next 5/6] ionic: implement support for rx sgl

2019-10-22 Thread Shannon Nelson
Even out Rx performance across MTU sizes by changing from full skb allocations to page-based frag allocations. The device supports a form of scatter-gather in the Rx path, so we can set up a number of pages for each descriptor, all of which are easier to alloc and pass around than the standard kza

[PATCH net-next 2/6] ionic: reverse an interrupt coalesce calculation

2019-10-22 Thread Shannon Nelson
Fix the initial interrupt coalesce usec-to-hw setting to actually be usec-to-hw. Fixes: 780eded34ccc ("ionic: report users coalesce request") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH net-next 4/6] ionic: add a watchdog timer to monitor heartbeat

2019-10-22 Thread Shannon Nelson
Add a watchdog to periodically monitor the NIC heartbeat. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic.h | 2 ++ .../net/ethernet/pensando/ionic/ionic_dev.c | 19 +-- .../net/ethernet/pensando/ionic/ionic_dev.h | 1 + 3 files changed, 20 ins

[PATCH net-next 6/6] ionic: update driver version

2019-10-22 Thread Shannon Nelson
Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic.h b/drivers/net/ethernet/pensando/ionic/ionic.h index 5b013250f8c3..98e102af7756 100644 --- a/drivers/net/et

Re: [PATCH net 0/5] bnxt_en: Bug fixes.

2019-10-22 Thread Jakub Kicinski
On Mon, 21 Oct 2019 01:34:24 -0400, Michael Chan wrote: > Devlink and error recovery bug fix patches. Most of the work is by > Vasundhara Volam. Thanks, applied. > Please queue patch 1 and 2 for -stable also. Thanks. FWIW these will likely only reach 5.3 since it looks like the bug dates to

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-22 Thread Yuchung Cheng
On Tue, Oct 22, 2019 at 12:34 PM Jason Baron wrote: > > > > On 10/22/19 2:17 PM, Yuchung Cheng wrote: > > On Mon, Oct 21, 2019 at 7:14 PM Neal Cardwell wrote: > >> > >> On Mon, Oct 21, 2019 at 5:11 PM Jason Baron wrote: > >>> > >>> > >>> > >>> On 10/21/19 4:36 PM, Eric Dumazet wrote: > On M

Re: [PATCH v2 bpf-next] libbpf: make DECLARE_LIBBPF_OPTS macro strictly a variable declaration

2019-10-22 Thread Daniel Borkmann
On Tue, Oct 22, 2019 at 10:21:00AM -0700, Andrii Nakryiko wrote: > LIBBPF_OPTS is implemented as a mix of field declaration and memset > + assignment. This makes it neither variable declaration nor purely > statements, which is a problem, because you can't mix it with either > other variable declar

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-22 Thread Jason Baron
On 10/22/19 2:17 PM, Yuchung Cheng wrote: > On Mon, Oct 21, 2019 at 7:14 PM Neal Cardwell wrote: >> >> On Mon, Oct 21, 2019 at 5:11 PM Jason Baron wrote: >>> >>> >>> >>> On 10/21/19 4:36 PM, Eric Dumazet wrote: On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch wrote: > >>>

[PATCH net-next] r8169: never set PCI_EXP_DEVCTL_NOSNOOP_EN

2019-10-22 Thread Heiner Kallweit
Setting PCI_EXP_DEVCTL_NOSNOOP_EN for certain chip versions had been added to the vendor driver more than 10 years ago, and copied from there to r8169. It has been removed from the vendor driver meanwhile and I think we can safely remove this too. Signed-off-by: Heiner Kallweit --- drivers/net/e

[PATCH v15 3/5] tools: Added bpf_get_ns_current_pid_tgid helper

2019-10-22 Thread Carlos Neira
sync tools/include/uapi/linux/bpf.h to include new helper. Signed-off-by: Carlos Neira --- tools/include/uapi/linux/bpf.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 4af8b0819a32..4

[PATCH v15 1/5] fs/nsfs.c: added ns_match

2019-10-22 Thread Carlos Neira
ns_match returns true if the namespace inode and dev_t matches the ones provided by the caller. Signed-off-by: Carlos Neira --- fs/nsfs.c | 14 ++ include/linux/proc_ns.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/fs/nsfs.c b/fs/nsfs.c index a0431642c6b5..

[PATCH v15 0/5] BPF: New helper to obtain namespace data from current task

2019-10-22 Thread Carlos Neira
Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's scripts but this helper returns the pid as seen by the root namespace which is fine when a bcc script is not executed inside a container. When the process of interest is inside a container, pid filtering will not work if bpf

[PATCH v15 2/5] bpf: added new helper bpf_get_ns_current_pid_tgid

2019-10-22 Thread Carlos Neira
New bpf helper bpf_get_ns_current_pid_tgid, This helper will return pid and tgid from current task which namespace matches dev_t and inode number provided, this will allows us to instrument a process inside a container. Signed-off-by: Carlos Neira --- include/linux/bpf.h | 1 + include/uap

[PATCH v15 4/5] tools/testing/selftests/bpf: Add self-tests for new helper.

2019-10-22 Thread Carlos Neira
Self tests added for new helper Signed-off-by: Carlos Neira --- .../bpf/prog_tests/ns_current_pid_tgid.c | 87 +++ .../bpf/progs/test_ns_current_pid_tgid.c | 37 2 files changed, 124 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/ns_cu

[PATCH v15 5/5] bpf_helpers_doc.py: Add struct bpf_pidns_info to known types

2019-10-22 Thread Carlos Neira
Add struct bpf_pidns_info to known types Signed-off-by: Carlos Neira --- scripts/bpf_helpers_doc.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/bpf_helpers_doc.py b/scripts/bpf_helpers_doc.py index 7548569e8076..021cc387d414 100755 --- a/scripts/bpf_helpers_doc.py +++ b/scripts/b

Re: [PATCH v2] net: phy: dp83867: support Wake on LAN

2019-10-22 Thread Andrew Lunn
> > +static int dp83867_set_wol(struct phy_device *phydev, > > + struct ethtool_wolinfo *wol) > > +{ > > + struct net_device *ndev = phydev->attached_dev; > > + u16 val_rxcfg, val_micr; > > + const u8 *mac; > > + > > + val_rxcfg = phy_read_mmd(phydev, DP83867_DEVADDR, D

Re: [PATCH bpf-next 1/3] libbpf: Store map pin path in struct bpf_map

2019-10-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Oct 22, 2019 at 11:45 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> > On Tue, Oct 22, 2019 at 11:13 AM Toke Høiland-Jørgensen >> > wrote: >> >> >> >> Andrii Nakryiko writes: >> >> >> >> > On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland

Re: [Intel-wired-lan] FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-22 Thread Samudrala, Sridhar
On 10/21/2019 3:34 PM, Alexei Starovoitov wrote: On Mon, Oct 21, 2019 at 1:10 PM Samudrala, Sridhar wrote: On 10/20/2019 10:12 AM, Björn Töpel wrote: On Sun, 20 Oct 2019 at 12:15, Toke Høiland-Jørgensen wrote: Alexei Starovoitov writes: On Fri, Oct 18, 2019 at 05:45:26PM -0700, Samudral

Re: [PATCH bpf-next 3/3] libbpf: Add pin option to automount BPF filesystem before pinning

2019-10-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> While the current map pinning functions will check whether the pin path is >> contained on a BPF filesystem, it does not offer any options to mount the >> file sys

Re: [PATCH bpf-next 2/3] libbpf: Support configurable pinning of maps from BTF annotations

2019-10-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> This adds support to libbpf for setting map pinning information as part of >> the BTF map declaration. We introduce a new pair of functions to pin and >> unpin map

Re: [net 12/15] net/mlx5e: kTLS, Enhance TX resync flow

2019-10-22 Thread Saeed Mahameed
On Tue, 2019-10-22 at 11:42 -0700, Jakub Kicinski wrote: > On Tue, 22 Oct 2019 18:10:11 +, Saeed Mahameed wrote: > > On Fri, 2019-10-18 at 18:51 -0700, Jakub Kicinski wrote: > > > On Fri, 18 Oct 2019 19:38:24 +, Saeed Mahameed wrote: > > > > From: Tariq Toukan > > > > > > > > Once the k

Re: [PATCH bpf-next 1/3] libbpf: Store map pin path in struct bpf_map

2019-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2019 at 11:45 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Tue, Oct 22, 2019 at 11:13 AM Toke Høiland-Jørgensen > > wrote: > >> > >> Andrii Nakryiko writes: > >> > >> > On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen > >> > wrote: > >> >> > >>

Re: [PATCH bpf-next 1/3] libbpf: Store map pin path in struct bpf_map

2019-10-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Oct 22, 2019 at 11:13 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> > On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen >> > wrote: >> >> >> >> From: Toke Høiland-Jørgensen >> >> >> >> When pinning a map, store the pin path in

Re: [net 12/15] net/mlx5e: kTLS, Enhance TX resync flow

2019-10-22 Thread Jakub Kicinski
On Tue, 22 Oct 2019 18:10:11 +, Saeed Mahameed wrote: > On Fri, 2019-10-18 at 18:51 -0700, Jakub Kicinski wrote: > > On Fri, 18 Oct 2019 19:38:24 +, Saeed Mahameed wrote: > > > From: Tariq Toukan > > > > > > Once the kTLS TX resync function is called, it used to return > > > a binary va

Re: [PATCH v2] net: phy: dp83867: support Wake on LAN

2019-10-22 Thread Heiner Kallweit
On 22.10.2019 15:06, Thomas Hämmerle wrote: > From: Thomas Haemmerle > > This adds WoL support on TI DP83867 for magic, magic secure, unicast and > broadcast. > > Signed-off-by: Thomas Haemmerle > --- > drivers/net/phy/dp83867.c | 131 > +- > 1 file

Re: [PATCH net-next 0/4] r8169: remove fiddling with the PCIe max read request size

2019-10-22 Thread Jakub Kicinski
On Mon, 21 Oct 2019 21:21:23 +0200, Heiner Kallweit wrote: > The attempt to improve performance by changing the PCIe max read request > size was added in the vendor driver more than 10 years back and copied > to r8169 driver. In the vendor driver this has been removed long ago. > Obviously it had n

Re: [PATCH net-next 0/8] net/smc: improve termination handling (part 2)

2019-10-22 Thread Jakub Kicinski
On Mon, 21 Oct 2019 16:13:07 +0200, Karsten Graul wrote: > More patches to address abnormal termination processing of > sockets and link groups. Applied, thanks!

Re: [PATCH net-next 0/2] mlxsw: core: Extend QSFP EEPROM size

2019-10-22 Thread Jakub Kicinski
On Mon, 21 Oct 2019 13:30:29 +0300, Ido Schimmel wrote: > From: Ido Schimmel > > Vadim says: > > This patch set extends the size of QSFP EEPROM for the cable types > SSF-8436 and SFF-8636 from 256 bytes to 640 bytes. This allows ethtool > to show correct information for these cable types (more d

Hello

2019-10-22 Thread janet rossana
Please dear, I know this contact will be so strange to you, but i summon courage to reach you because i desperately need your friendly assistance there in your country. I am making preparations to relocate with my children there, and i have some capital which i wanted to invest there to be able to

Re: [PATCH v2] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-22 Thread Oliver Hartkopp
On 22/10/2019 19.28, Eric Dumazet wrote On 10/22/19 9:42 AM, Stephen Hemminger wrote: Why not fix fq_codel to return the same errors as other qdisc? I believe the same problem would happen with any qdisc not doing tail drops. Do we really want to enforce all qdisc to have a common drop st

Re: [PATCH bpf] bpf: Fix use after free in subprog's jited symbol removal

2019-10-22 Thread Alexei Starovoitov
On Tue, Oct 22, 2019 at 6:57 AM Daniel Borkmann wrote: > > syzkaller managed to trigger the following crash: > > [...] > BUG: unable to handle page fault for address: c90001923030 > #PF: supervisor read access in kernel mode > #PF: error_code(0x) - not-present page > PGD aa551067

Re: [PATCH bpf-next 3/3] libbpf: Add pin option to automount BPF filesystem before pinning

2019-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > While the current map pinning functions will check whether the pin path is > contained on a BPF filesystem, it does not offer any options to mount the > file system if it doesn't exist. Since we now

Re: [PATCH bpf-next 1/3] libbpf: Store map pin path in struct bpf_map

2019-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2019 at 11:13 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen > > wrote: > >> > >> From: Toke Høiland-Jørgensen > >> > >> When pinning a map, store the pin path in struct bpf_map so it can be > >> re-used

Re: [PATCH bpf-next 2/3] libbpf: Support configurable pinning of maps from BTF annotations

2019-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > This adds support to libbpf for setting map pinning information as part of > the BTF map declaration. We introduce a new pair of functions to pin and > unpin maps based on this setting, as well as a

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-22 Thread Yuchung Cheng
On Mon, Oct 21, 2019 at 7:14 PM Neal Cardwell wrote: > > On Mon, Oct 21, 2019 at 5:11 PM Jason Baron wrote: > > > > > > > > On 10/21/19 4:36 PM, Eric Dumazet wrote: > > > On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch > > > wrote: > > >> > > > > > >> Actually, longterm I hope we would be abl

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Roman Mashak
Vlad Buslov writes: > On Tue 22 Oct 2019 at 17:35, Marcelo Ricardo Leitner > wrote: >> On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: >>> Currently, significant fraction of CPU time during TC filter allocation >>> is spent in percpu allocator. Moreover, percpu allocator is protect

Re: [PATCH bpf-next 1/3] libbpf: Store map pin path in struct bpf_map

2019-10-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Oct 22, 2019 at 9:08 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> When pinning a map, store the pin path in struct bpf_map so it can be >> re-used later for un-pinning. This simplifies the later addition of per-map >> pin paths.

Re: [net 12/15] net/mlx5e: kTLS, Enhance TX resync flow

2019-10-22 Thread Saeed Mahameed
On Fri, 2019-10-18 at 18:51 -0700, Jakub Kicinski wrote: > On Fri, 18 Oct 2019 19:38:24 +, Saeed Mahameed wrote: > > From: Tariq Toukan > > > > Once the kTLS TX resync function is called, it used to return > > a binary value, for success or failure. > > > > However, in case the TLS SKB is a

Re: [PATCH bpf-next v3 1/5] bpf: Support chain calling multiple BPF programs after each other

2019-10-22 Thread Toke Høiland-Jørgensen
Edward Cree writes: > On 17/10/2019 13:11, Toke Høiland-Jørgensen wrote: >> I think there's a conceptual disconnect here in how we view what an XDP >> program is. In my mind, an XDP program is a stand-alone entity tied to a >> particular application; not a library function that can just be insert

Re: [net 04/15] net/mlx5e: kTLS, Size of a Dump WQE is fixed

2019-10-22 Thread Saeed Mahameed
On Fri, 2019-10-18 at 16:13 -0700, Jakub Kicinski wrote: > On Fri, 18 Oct 2019 19:38:09 +, Saeed Mahameed wrote: > > From: Tariq Toukan > > > > No Eth segment, so no dynamic inline headers. > > The size of a Dump WQE is fixed, use constants and remove > > unnecessary checks. > > > > Fixes: d

Re: [RFC PATCH v2 bpf-next 00/15] xdp_flow: Flow offload to XDP

2019-10-22 Thread Toke Høiland-Jørgensen
John Fastabend writes: > I think for sysadmins in general (not OVS) use case I would work > with Jesper and Toke. They seem to be working on this specific > problem. We're definitely thinking about how we can make "XDP magically speeds up my network stack" a reality, if that's what you mean. Not

[PATCH net-next 2/9] devlink: Add PCI attributes support for vdev

2019-10-22 Thread Yuval Avnery
When vdev represents a PCI device it should reflect the PCI device type (PF/VF) and it's index. Example: $ devlink vdev show pci/:03:00.0/1 -jp { "vdev": { "pci/:03:00.0/1": { "flavour": "pcivf", "pf": 0, "vf": 0 } } } $ devlink

[PATCH net-next 7/9] netdevsim: Add devlink vdev creation

2019-10-22 Thread Yuval Avnery
Add devlink vdev creation to represent VFs, and implement hw_addr get/set. Signed-off-by: Yuval Avnery Acked-by: Jiri Pirko --- drivers/net/netdevsim/Makefile| 2 +- drivers/net/netdevsim/dev.c | 9 ++- drivers/net/netdevsim/netdevsim.h | 10 drivers/net/netdevsim/vdev.c |

  1   2   3   >