On Thu, Oct 17, 2019 at 11:20:50AM -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
> This fixes:
> external/ethtool/ethtool.c:473:43: error: unused parameter 'ctx'
> [-Werror,-Wunused-parameter]
> static int do_version(struct cmd_context *ctx)
>
> external/ethtool/ethtool.
On Thu, Oct 17, 2019 at 11:20:49AM -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
> This fixes:
> external/ethtool/marvell.c:127:22: error: arithmetic on a pointer to void
> is a GNU extension [-Werror,-Wpointer-arith]
> dump_timer("LED", p + 0x20);
>
> (and remove some spa
From: Vasundhara Volam
When firmware indicates that driver needs to invoke firmware reset
which is common for both error recovery and live firmware reset path,
driver needs a different time to wait before polling for firmware
readiness.
Modify the wait time to fw_reset_min_dsecs, which is initia
From: Vasundhara Volam
With the recently added error recovery logic, the device may already
be disabled if the firmware recovery is unsuccessful. In
bnxt_remove_one(), check that the device is still enabled first
before calling pci_disable_device().
Fixes: 3bc7d4a352ef ("bnxt_en: Add BNXT_STATE
From: Vasundhara Volam
Minor formatting changes to diagnose cb for FW devlink health
reporter.
Suggested-by: Jiri Pirko
Cc: Jiri Pirko
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 17 ++---
1 file changed, 6
The current code does not do endian swapping between the devlink
parameter and the internal NVRAM representation. Define a union to
represent the little endian NVRAM data and add 2 helper functions to
copy to and from the NVRAM data with the proper byte swapping.
Fixes: 782a624d00fa ("bnxt_en: Ad
Devlink and error recovery bug fix patches. Most of the work is by
Vasundhara Volam. Please queue patch 1 and 2 for -stable also. Thanks.
Michael Chan (1):
bnxt_en: Fix devlink NVRAM related byte order related issues.
Vasundhara Volam (4):
bnxt_en: Fix the size of devlink MSIX parameters.
From: Vasundhara Volam
The current code that rounds up the NVRAM parameter bit size to the next
byte size for the devlink parameter is not always correct. The MSIX
devlink parameters are 4 bytes and we don't get the correct size
using this method.
Fix it by adding a new dl_num_bytes member to t
On Sun, 20 Oct 2019 at 21:53, Toke Høiland-Jørgensen wrote:
>
> Björn Töpel writes:
>
> > From: Björn Töpel
> >
> > In commit 43e74c0267a3 ("bpf_xdp_redirect_map: Perform map lookup in
> > eBPF helper") the bpf_redirect_map() helper learned to do map lookup,
> > which means that the explicit loo
On Sat, Oct 19, 2019 at 2:12 AM Pravin Shelar wrote:
>
> On Thu, Oct 17, 2019 at 8:16 PM Tonghao Zhang
> wrote:
> >
> > On Fri, Oct 18, 2019 at 6:38 AM Pravin Shelar wrote:
> > >
> > > On Wed, Oct 16, 2019 at 5:50 AM wrote:
> > > >
> > > > From: Tonghao Zhang
> > > >
> > > > When we destroy t
On Sat, Oct 19, 2019 at 7:27 AM William Tu wrote:
>
> On Wed, Oct 16, 2019 at 5:54 AM wrote:
> >
> > From: Tonghao Zhang
> >
> > The full looking up on flow table traverses all mask array.
> > If mask-array is too large, the number of invalid flow-mask
> > increase, performance will be drop.
> >
On Sun, Oct 20, 2019 at 12:07:06PM -0700, Ben Pfaff wrote:
> On Sun, Oct 20, 2019 at 07:55:32PM +0530, Martin Varghese wrote:
> > From: Martin Varghese
> >
> > The openvswitch kernel module was supporting a MPLS label depth of 1
> > in the ingress direction though the userspace OVS supports a max
reference_tracking is actually a set of 9 sub-tests. Make it explicitly so.
Also, add explicit "classifier/" prefix to BPF program section names to
let libbpf correctly guess program type. Thus, also remove explicit
bpf_prog__set_type() call.
Cc: Stanislav Fomichev
Signed-off-by: Andrii Nakryiko
This patch set's main goal is to teach bpf_object__open() (and its variants)
to automatically derive BPF program type/expected attach type from section
names, similarly to how bpf_prog_load() was doing it. This significantly
improves user experience by eliminating yet another
obvious-only-in-the-hi
Now that libbpf can correctly guess BPF program types from section
names, remove a bunch of explicit bpf_program__set_type() calls
throughout tests.
Signed-off-by: Andrii Nakryiko
---
tools/testing/selftests/bpf/prog_tests/attach_probe.c | 5 -
tools/testing/selftests/bpf/prog_tests/core_rel
There are bpf_program__set_type() and
bpf_program__set_expected_attach_type(), but no corresponding getters,
which seems rather incomplete. Fix this.
Signed-off-by: Andrii Nakryiko
---
tools/lib/bpf/libbpf.c | 11 +++
tools/lib/bpf/libbpf.h | 5 +
tools/lib/bpf/libbpf.map | 2 +
test_progs never created a copy of subtest name, rather just stored
pointer to whatever string test provided. This is bad as that string
might be freed or modified by the end of subtest. Fix this by creating
a copy of given subtest name when subtest starts.
Signed-off-by: Andrii Nakryiko
---
too
Sync if_link.h into tools/ and get rid of annoying libbpf Makefile warning.
Signed-off-by: Andrii Nakryiko
---
tools/include/uapi/linux/if_link.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/include/uapi/linux/if_link.h
b/tools/include/uapi/linux/if_link.h
index 4a8c02cafa9a..8ae
Teach bpf_object__open how to guess program type and expected attach
type from section names, similar to what bpf_prog_load() does. This
seems like a really useful features and an oversight to not have this
done during bpf_object_open(). To preserver backwards compatible
behavior of bpf_prog_load()
Map uprobe/uretprobe into KPROBE program type. tp/raw_tp are just an
alias for more verbose tracepoint/raw_tracepoint, respectively.
Signed-off-by: Andrii Nakryiko
---
tools/lib/bpf/libbpf.c | 4
1 file changed, 4 insertions(+)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
i
FIN-WAIT1 just means the local application has called close() or
shutdown() to shut down the sending direction of the socket, and the
local TCP stack has sent a FIN, and is waiting to receive a FIN and an
ACK from the other side (in either order, or simultaneously). The
ASCII art state transition
On Sun, Oct 20, 2019 at 5:52 PM Andrii Nakryiko
wrote:
>
> On Sun, Oct 20, 2019 at 4:24 AM Jakub Sitnicki wrote:
> >
> > Don't generate a broken bpf_helper_defs.h header if the helper script needs
> > updating because it doesn't recognize a newly added type. Instead print an
> > error that explai
On Sun, Oct 20, 2019 at 7:15 PM Subash Abhinov Kasiviswanathan
wrote:
>
> > Hmm. Random related thought while searching for a possible cause: I
> > wonder if tcp_write_queue_purge() should clear tp->highest_sack (and
> > possibly tp->sacked_out)? The tcp_write_queue_purge() code is careful
> > to
On Sun, Oct 20, 2019 at 4:24 AM Jakub Sitnicki wrote:
>
> Don't generate a broken bpf_helper_defs.h header if the helper script needs
> updating because it doesn't recognize a newly added type. Instead print an
> error that explains why the build is failing, clean up the partially
> generated head
On 10/20/19 4:23 AM, Jakub Sitnicki wrote:
> Don't generate a broken bpf_helper_defs.h header if the helper script needs
> updating because it doesn't recognize a newly added type. Instead print an
> error that explains why the build is failing, clean up the partially
> generated header and stop.
Using the devm_alloc_etherdev() function simplifies the error
path. I also patch the message to use dev_info().
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/xscale/ixp4xx_eth.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/x
In order to probe this ethernet interface from the device tree
all physical MMIO regions must be passed as resources. Begin
this rewrite by first passing the port base address as a
resource for all platforms using this driver, remap it in
the driver and avoid using any reference of the statically
m
Use the netdevice struct device .parent field when calling
dma_pool_create(): the .dma_coherent_mask and .dma_mask
pertains to the bus device on the hardware (platform)
bus in this case, not the struct device inside the network
device. This makes the pool allocation work.
Signed-off-by: Linus Wall
The port->id was picked from the platform device .id field,
but this is not supposed to be used for passing around
random numbers in hardware. Identify the port ID number
from the base address instead.
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/xscale/ixp4xx_eth.c | 12 +++-
1
The IXP4xx driver was initializing the MDIO bus before even
probing, in the callbacks supposed to be used for setting up
the module itself, and with the side effect of trying to
register the MDIO bus as soon as this module was loaded or
compiled into the kernel whether the device was discovered
or
Use "ndev" for the struct net_device and "dev" for the
struct device in probe() and remove(). Add the local
"dev" pointer for later use in refactoring.
Take this opportunity to fix inverse christmas tree
coding style.
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/xscale/ixp4xx_eth.c | 5
From: Arnd Bergmann
The platform data is needed to compile the driver as standalone,
so move it to a global location along with similar files.
Signed-off-by: Arnd Bergmann
Signed-off-by: Linus Walleij
---
arch/arm/mach-ixp4xx/include/mach/platform.h | 13 +
.../xscale/{ptp_ixp46x
From: Arnd Bergmann
The ixp46x ptp driver has a somewhat unusual setup, where the ptp
driver and the ethernet driver are in different directories but
access the same registers that are defined a platform specific
header file.
Moving everything into drivers/net/ makes it look more like most
other
From: Arnd Bergmann
Change the driver to use portable integer types to avoid
warnings during compile testing:
drivers/net/wan/ixp4xx_hss.c:863:21: error: cast to 'u32 *' (aka 'unsigned int
*') from smaller integer type 'int' [-Werror,-Wint-to-pointer-cast]
memcpy_swab32(mem, (u32 *)((in
From: Arnd Bergmann
The ixp4xx_hss driver needs the platform data definition and the
system clock rate to be compiled. Move both into a new platform_data
header file and enable compile testing.
Signed-off-by: Arnd Bergmann
Signed-off-by: Linus Walleij
---
arch/arm/mach-ixp4xx/goramo_mlr.c
This is a patch series which jams together Arnds and mine
cleanups for the IXP4xx networking.
I also have patches for device tree support but that
requires more elaborate work, this series is some of
mine and some of Arnds patches that is a good foundation
for his multiplatform work and my device
Hmm. Random related thought while searching for a possible cause: I
wonder if tcp_write_queue_purge() should clear tp->highest_sack (and
possibly tp->sacked_out)? The tcp_write_queue_purge() code is careful
to call tcp_clear_all_retrans_hints(tcp_sk(sk)) and I would imagine
that similar considera
tcp_write_queue_purgeOn Sun, Oct 20, 2019 at 4:25 PM Subash Abhinov
Kasiviswanathan wrote:
>
> We are seeing a crash in the TCP ACK codepath often in our regression
> racks with an ARM64 device with 4.19 based kernel.
>
> It appears that the tp->highest_ack is invalid when being accessed when
> a
Good day , my name is Fabio Verde, i sent you a mail and there was no
response , please confirm that you did get this mail for more details.
Regards.
Fabio Verde
We are seeing a crash in the TCP ACK codepath often in our regression
racks with an ARM64 device with 4.19 based kernel.
It appears that the tp->highest_ack is invalid when being accessed when
a
FIN-ACK is received. In all the instances of the crash, the tcp socket
is in TCP_FIN_WAIT1 state.
[
On Sun, Oct 20, 2019 at 07:55:32PM +0530, Martin Varghese wrote:
> From: Martin Varghese
>
> The openvswitch kernel module was supporting a MPLS label depth of 1
> in the ingress direction though the userspace OVS supports a max depth
> of 3 labels. This change enables openvswitch module to suppo
Björn Töpel writes:
> From: Björn Töpel
>
> In commit 43e74c0267a3 ("bpf_xdp_redirect_map: Perform map lookup in
> eBPF helper") the bpf_redirect_map() helper learned to do map lookup,
> which means that the explicit lookup in the XDP program for AF_XDP is
> not needed.
>
> This commit removes t
On Sat, 19 Oct 2019 10:13:20 +0200, Lorenzo Bianconi wrote:
> Add XDP support to mvneta driver for devices that rely on software
> buffer management. Supported verdicts are:
> - XDP_DROP
> - XDP_PASS
> - XDP_REDIRECT
> - XDP_TX
> Moreover set ndo_xdp_xmit net_device_ops function pointer in order
>
On Sun, Oct 20, 2019 at 08:02:46AM +0200, Jiri Pirko wrote:
> Sun, Oct 20, 2019 at 07:54:59AM CEST, j...@resnulli.us wrote:
> >Sat, Oct 19, 2019 at 11:12:34PM CEST, and...@lunn.ch wrote:
> >>> Could you please follow the rest of the existing params?
> >>
> >>Why are params special? Devlink resource
On Sun, 20 Oct 2019 at 12:15, Toke Høiland-Jørgensen wrote:
>
> Alexei Starovoitov writes:
>
> > On Fri, Oct 18, 2019 at 05:45:26PM -0700, Samudrala, Sridhar wrote:
> >> On 10/18/2019 5:14 PM, Alexei Starovoitov wrote:
> >> > On Fri, Oct 18, 2019 at 11:40:07AM -0700, Samudrala, Sridhar wrote:
> >
On Sun, 20 Oct 2019 07:46:00 +, Tariq Toukan wrote:
> On 10/19/2019 2:16 AM, Jakub Kicinski wrote:
> > On Fri, 18 Oct 2019 19:38:22 +, Saeed Mahameed wrote:
> >> From: Tariq Toukan
> >>
> >> Do not assume the crypto info is accessible during the
> >> connection lifetime. Save a copy of i
From: Björn Töpel
In commit 43e74c0267a3 ("bpf_xdp_redirect_map: Perform map lookup in
eBPF helper") the bpf_redirect_map() helper learned to do map lookup,
which means that the explicit lookup in the XDP program for AF_XDP is
not needed.
This commit removes the map lookup, which simplifies the
Hi,
I recently noticed that its not possible to set ipv6 lladdr for ip6gre
tunnels using iproute2.
That is because the parser (int ll_addr_a2n()) treats ipv6 addresses as
mac addresses because of the ":".
I dont know iproute2 good enough to say if the patch below breaks
anything so please
From: Martin Varghese
The openvswitch kernel module was supporting a MPLS label depth of 1
in the ingress direction though the userspace OVS supports a max depth
of 3 labels. This change enables openvswitch module to support a max
depth of 3 labels in the ingress.
Signed-off-by: Martin Varghese
From: Martin Varghese
The openvswitch was supporting a MPLS label depth of 1 in the ingress
direction though the userspace OVS supports a max depth of 3 labels.
This change enables openvswitch module to support a max depth of
3 labels in the ingress.
Signed-off-by: Martin Varghese
---
Changes i
Don't generate a broken bpf_helper_defs.h header if the helper script needs
updating because it doesn't recognize a newly added type. Instead print an
error that explains why the build is failing, clean up the partially
generated header and stop.
v1->v2:
- Switched from temporary file to .DELETE_O
Alexei Starovoitov writes:
> On Wed, Oct 16, 2019 at 03:51:52PM +0200, Toke Høiland-Jørgensen wrote:
>> Alexei Starovoitov writes:
>>
>> > On Mon, Oct 14, 2019 at 02:35:45PM +0200, Toke Høiland-Jørgensen wrote:
>> >> Alexei Starovoitov writes:
>> >>
>> >> > On Wed, Oct 09, 2019 at 10:03:43AM
Alexei Starovoitov writes:
> On Fri, Oct 18, 2019 at 05:45:26PM -0700, Samudrala, Sridhar wrote:
>> On 10/18/2019 5:14 PM, Alexei Starovoitov wrote:
>> > On Fri, Oct 18, 2019 at 11:40:07AM -0700, Samudrala, Sridhar wrote:
>> > >
>> > > Perf report for "AF_XDP default rxdrop" with patched kernel
On 10/19/2019 2:16 AM, Jakub Kicinski wrote:
> On Fri, 18 Oct 2019 19:38:22 +, Saeed Mahameed wrote:
>> From: Tariq Toukan
>>
>> Do not assume the crypto info is accessible during the
>> connection lifetime. Save a copy of it in the private
>> TX context.
>
> It should be around as long as
On 10/19/2019 3:10 AM, Jonathan Lemon wrote:
> I was running the updated patches on machines with various workloads, and
> have a bunch of different results.
>
> For the following numbers,
>Effective = hit / (hit + empty + stall) * 100
>
> In other words, show the hit rate for for every tri
55 matches
Mail list logo
