Re: [PATCH v2 net] devlink: Fix error handling in param and info_get dumpit cb

Mon, Sep 30, 2019 at 08:22:21AM CEST, vasundhara-v.vo...@broadcom.com wrote: >If any of the param or info_get op returns error, dumpit cb is >skipping to dump remaining params or info_get ops for all the >drivers. > >Fix to not return if any of the param/info_get op returns error >as not supported

Re: [PATCH RFC 5/5] udp: Support UDP fraglist GRO/GSO.

On Mon, Sep 23, 2019 at 09:01:13AM -0400, Willem de Bruijn wrote: > On Fri, Sep 20, 2019 at 12:49 AM Steffen Klassert > wrote: > > > > This patch extends UDP GRO to support fraglist GRO/GSO > > by using the previously introduced infrastructure. > > All UDP packets that are not targeted to a GRO ca

Re: [PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

On Mon, Sep 23, 2019 at 08:38:56AM -0400, Willem de Bruijn wrote: > On Fri, Sep 20, 2019 at 12:49 AM Steffen Klassert > wrote: > > > > diff --git a/include/linux/netdev_features.h > > b/include/linux/netdev_features.h > > index b239507da2a0..34d050bb1ae6 100644 > > --- a/include/linux/netdev_feat

[PATCH v2 net] devlink: Fix error handling in param and info_get dumpit cb

If any of the param or info_get op returns error, dumpit cb is skipping to dump remaining params or info_get ops for all the drivers. Fix to not return if any of the param/info_get op returns error as not supported and continue to dump remaining information. v2: Modify the patch to return error,

Re: [PATCH bpf] libbpf: count present CPUs, not theoretically possible

> On Sep 27, 2019, at 11:30 PM, Andrii Nakryiko wrote: > > This patch switches libbpf_num_possible_cpus() from using possible CPU > set to present CPU set. This fixes issues with incorrect auto-sizing of > PERF_EVENT_ARRAY map on HOTPLUG-enabled systems. > > On HOTPLUG enabled systems, /sys/d

Re: [PATCH bpf v2] libbpf: handle symbol versioning properly for libbpf.a

On Sat, Sep 28, 2019 at 4:23 PM Yonghong Song wrote: > > bcc uses libbpf repo as a submodule. It brings in libbpf source > code and builds everything together to produce shared libraries. > With latest libbpf, I got the following errors: > /bin/ld: libbcc_bpf.so.0.10.0: version node not found fo

Re: [PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code

On 29/09/2019 10.32, Joakim Zhang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together to simplify the code. Signed-off-by: Joakim Zhang Reviewed-by: Sean Nyekjaer --- drivers/net/can/flexcan.c | 4 +---

Re: DSA driver kernel extension for dsa mv88e6190 switch

> The very last line is wrong. > ifconfig eth0 192.168.1.4 up Typo. It was fixed after few hours I created the gist. > You should put the IP address on the bridge, not the master > device eth0. > ip addr add 192.168.1.4/24 dev br0 Noted. Thank you. > FYI: ifconfig has been deprecated for maybe

[PATCH] ipvs: no need to update skb route entry for local destination packets.

In the end of function __ip_vs_get_out_rt/__ip_vs_get_out_rt_v6,the 'local' variable is always zero. Signed-off-by: zhang kai --- net/netfilter/ipvs/ip_vs_xmit.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilte

[PATCH net-next 7/9] net: openvswitch: add likely in flow_lookup

From: Tonghao Zhang The most case *index < ma->max, we add likely for performance. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c index c8e79c1..c21fd5

[PATCH net-next 8/9] net: openvswitch: fix possible memleak on destroy flow table

From: Tonghao Zhang When we destroy the flow tables which may contain the flow_mask, so release the flow mask struct. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow_table.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/flow_table.c b/

[PATCH net-next 6/9] net: openvswitch: simplify the flow_hash

From: Tonghao Zhang Simplify the code and remove the unnecessary BUILD_BUG_ON. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow_table.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c index 5257e4a..c8

[PATCH net-next 3/9] net: openvswitch: shrink the mask array if necessary

From: Tonghao Zhang When creating and inserting flow-mask, if there is no available flow-mask, we realloc the mask array. When removing flow-mask, if necessary, we shrink mask array. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow_table.c | 33 +++-- 1 file ch

[PATCH net-next 0/9] optimize openvswitch flow looking up

From: Tonghao Zhang This series patch optimize openvswitch. Patch 1, 2, 4: Port Pravin B Shelar patches to linux upstream with little changes. Patch 5, 6, 7: Optimize the flow looking up and simplify the flow hash. Patch 8: is a bugfix. The performance test is on Intel Xeon E5-2630 v4. The te

[PATCH net-next 9/9] net: openvswitch: simplify the ovs_dp_cmd_new

From: Tonghao Zhang use the specified functions to init resource. Signed-off-by: Tonghao Zhang --- net/openvswitch/datapath.c | 60 +- 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapa

[PATCH net-next 4/9] net: openvswitch: optimize flow mask cache hash collision

From: Tonghao Zhang Port the codes to linux upstream and with little changes. Pravin B Shelar, says: | In case hash collision on mask cache, OVS does extra flow | lookup. Following patch avoid it. Link: https://github.com/openvswitch/ovs/commit/0e6efbe2712da03522532dc5e84806a96f6a0dd1 Signed-o

[PATCH net-next 5/9] net: openvswitch: optimize flow-mask looking up

From: Tonghao Zhang The full looking up on flow table traverses all mask array. If mask-array is too large, the number of invalid flow-mask increase, performance will be drop. This patch optimizes mask-array operation: * Inserting, insert it [ma->count- 1] directly. * Removing, only change last

[PATCH net-next 1/9] net: openvswitch: add flow-mask cache for performance

From: Tonghao Zhang The idea of this optimization comes from a patch which is committed in 2014, openvswitch community. The author is Pravin B Shelar. In order to get high performance, I implement it again. Later patches will use it. Pravin B Shelar, says: | On every packet OVS needs to lookup f

[PATCH net-next 2/9] net: openvswitch: convert mask list in mask array

From: Tonghao Zhang Port the codes to linux upstream and with little changes. Pravin B Shelar, says: | mask caches index of mask in mask_list. On packet recv OVS | need to traverse mask-list to get cached mask. Therefore array | is better for retrieving cached mask. This also allows better | cac

Re: DSA driver kernel extension for dsa mv88e6190 switch

> I wrote my (very first) public GIST about that. Please, could you > review it, and point to the any logical bugs in there? > https://gist.github.com/ZoranStojsavljevic/423b96e2ca3bd581f7ce417cb410c465 The very last line is wrong. ifconfig eth0 192.168.1.4 up You should put the IP address on th

Re: Regression: Network link not coming up after suspend/resume cycle

Hi Jan, On Sun, 29 Sep 2019 at 22:25, Jan Janssen wrote: > > Hi, > > I've been noticing lately that my network link sometimes does not go up > after a suspend resume cycle (roughly 1 or 2 out of 10 times). This also > sometimes happens with a fresh boot too. Doing a manual > "ip link set down/up"

RE: Attn: Service Desk

Dear Employees/Staff, Take note of this important update that our new web-mail has been improved with a new messaging system from Owa/outlook which also includes faster usage on email, shared calendar, web-documents and the new 2019 anti-spam version. Kindly CLICK Outlook Web Access

Regression: Network link not coming up after suspend/resume cycle

Hi, I've been noticing lately that my network link sometimes does not go up after a suspend resume cycle (roughly 1 or 2 out of 10 times). This also sometimes happens with a fresh boot too. Doing a manual "ip link set down/up" cycle resolves this issue. I was able to bisect it to the commit below

[PATCH net] netfilter: drop bridge nf reset from nf_reset

commit 174e23810cd31 ("sk_buff: drop all skb extensions on free and skb scrubbing") made napi recycle always drop skb extensions. The additional skb_ext_del() that is performed via nf_reset on napi skb recycle is not needed anymore. Most nf_reset() calls in the stack are there so queued skb won't

net-next is OPEN...

Ok, I'm back home from Europe, let's do this.

Re: [question] About triggering a region snapshot through the devlink cmd

On 2019/9/27 16:13, Jiri Pirko wrote: > Fri, Sep 27, 2019 at 09:40:47AM CEST, linyunsh...@huawei.com wrote: >> Hi, Jiri & Alex >> >>It seems that a region' snapshot is only created through the >> driver when some error is detected, for example: >> mlx4_crdump_collect_fw_health() -> devlink_regi

[RFC PATCH] net: hns3: add devlink health dump support for hw mac tbl

This patch adds the devlink health dump support for hw mac tbl, which helps to debug some hardware packet switching problem or misconfiguation of the hardware mac table. And diagnose and recover support has not been added because RAS and misc error handling has done the recover process, we may als

[RFC PATCH 1/2] net: tap: Fix incorrect memory access

KASAN reported incorrect memory access when sock_init_data() was called. This happens due to the fact that if sock_init_data() is called with sock argument being not NULL, it goes into path using SOCK_INODE macro. SOCK_INODE itself is just a wrapper around container_of(socket, struct socket_alloc,

[RFC PATCH 2/2] net: tun: Fix incorrect memory access

This is equivalent commit to tap one, where we fix incorrect memory access caused by sock_init_data being passed improper socket. This happens due to the fact that if sock_init_data() is called with sock argument being not NULL, it goes into path using SOCK_INODE macro. SOCK_INODE itself is just a

[RFC PATCH 0/2] Incorrect memory access when using TAP

Hi, I've recently started using virt-manager to setup my virtual machines, along with macvtap bridge. When I start VM I noticed that following appears in dmesg: [ 125.256517] == [ 125.256524] BUG: KASAN: slab-out-of-bounds in sock

Re: [RFC 00/20] Intel RDMA/IDC Driver series

On Thu, Sep 26, 2019 at 7:46 PM Jeff Kirsher wrote: > This series is sent out as an RFC to verify that our implementation of > the MFD subsystem is correct to facilitate inner driver communication > (IDC) between the new "irdma" driver to support Intel's ice and i40e > drivers. > > The changes con

[PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code

Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together to simplify the code. Signed-off-by: Joakim Zhang --- drivers/net/can/flexcan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/can/

Re: [PATCH net v4 00/12] net: fix nested device bugs

On Sun, 29 Sep 2019 at 04:20, Johannes Berg wrote: > > > > VLAN, BONDING, TEAM, MACSEC, MACVLAN, IPVLAN, VIRT_WIFI and VXLAN. > > But I couldn't test all interface types so there could be more device > > types which have similar problems. > > Did you test virt_wifi? I don't see how it *doesn't* ha