From: Eric Dumazet
Date: Mon, 23 Sep 2019 15:18:57 -0700
> If the allocation done in tcf_exts_init() failed,
> we end up with a NULL pointer in exts->actions.
...
> Fixes: 90b73b77d08e ("net: sched: change action API to use array of pointers
> to actions")
> Signed-off-by: Eric Dumazet
> Repor
Hi Dan,
Thank you for pointing out.
I've confirmed that this error handling works well with your patch.
Reviewed-by: Kunihiko Hayashi
Thank you,
On Wed, 25 Sep 2019 13:57:50 +0300 wrote:
> The "phy_mode" variable is an enum and in this context GCC treats it as
> an unsigned int so the error
On 24.09.2019 13:27, Michal Vokáč wrote:
> Hi,
>
> just tried booting latest next-20190920 on our imx6dl-yapp4-hydra platform
> with QCA8334 switch and got this:
>
> [ 6.957822] 8<--- cut here ---
> [ 6.963550] Unable to handle kernel NULL pointer dereference at virtual
> address 0264
Aleksei Zakharov wrote:
>ср, 25 сент. 2019 г. в 03:31, Jay Vosburgh :
>>
>> Алексей Захаров wrote:
>> [...]
>> >Right after reboot one of the slaves hangs with actor port state 71
>> >and partner port state 1.
>> >It doesn't send lacpdu and seems to be broken.
>> >Setting link down and up again f
On Wed, Sep 25, 2019 at 07:28:20PM -0700, Jacob Keller wrote:
> This patch may not be correct for individual drivers, especially
> regarding the rising vs falling edge flags. I interpreted the default
> behavior to be to timestamp the rising edge of a pin transition.
So I think this patch goes too
On Wed, Sep 25, 2019 at 07:28:19PM -0700, Jacob Keller wrote:
> diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
> index 9c18476d8d10..67d0199840fd 100644
> --- a/drivers/ptp/ptp_chardev.c
> +++ b/drivers/ptp/ptp_chardev.c
> @@ -155,7 +155,7 @@ long ptp_ioctl(struct posix_clock *p
On 9/25/2019 3:56 AM, Dan Carpenter wrote:
> The "priv->phy_interface" variable is an enum and in this context GCC
> will treat it as unsigned so the error handling will never be
> triggered.
>
> Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC
> driver")
> Signed-of
Carlos Neira writes:
> Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's
> scripts but this helper returns the pid as seen by the root namespace which is
> fine when a bcc script is not executed inside a container.
> When the process of interest is inside a container, pid
I noticed recently that Filip added new versions of the PTP ioctls which
correctly honor the reserved fields (making it so that we can safely extend
them in the future).
Unfortunately, this breaks the old ioctls for a couple of reasons. First,
the flags for the old ioctls get cleared. This means t
Fix all of the drivers which implement support for the periodic output
or external timestamp requests to reject unsupported flags.
This is important for forward compatibility: if a new flag is
introduced, the driver should reject requests to enable the flag until
it has been modified to actually s
Commit 415606588c61 ("PTP: introduce new versions of IOCTLs",
2019-09-13) introduced new versions of the PTP ioctls which actually
validate that the flags are acceptable values.
As part of this, it cleared the flags value using a bitwise
and+negation, in an attempt to prevent the old ioctl from ac
Hi Jacob,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
[cannot apply to v5.3 next-20190924]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
bas
> -邮件原件-
> 发件人: Pravin Shelar [mailto:pshe...@ovn.org]
> 发送时间: 2019年9月26日 5:03
> 收件人: Li,Rongqing
> 抄送: Linux Kernel Network Developers
> 主题: Re: [PATCH] openvswitch: change type of UPCALL_PID attribute to
> NLA_UNSPEC
>
> On Tue, Sep 24, 2019 at 4:11 AM Li RongQing wrote:
> >
> > use
From: Randy Dunlap
Fix help text typos for DIMLIB.
Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files")
Signed-off-by: Randy Dunlap
Cc: Uwe Kleine-König
Cc: Tal Gilboa
Cc: Saeed Mahameed
---
Applies after Uwe's patch v2: dimlib: make DIMLIB a hidden symbol
lib/Kconfig |2
On 9/24/19 9:02 AM, Uwe Kleine-König wrote:
> According to Tal Gilboa the only benefit from DIM comes from a driver
> that uses it. So it doesn't make sense to make this symbol user visible,
> instead all drivers that use it should select it (as is already the case
> AFAICT).
>
> Signed-off-by: Uw
Fix all of the drivers which implement support for the periodic output
or external timestamp requests to reject unsupported flags.
This is important for forward compatibility: if a new flag is
introduced, the driver should reject requests to enable the flag until
it has been modified to actually s
I noticed recently that Filip added new versions of the PTP ioctls which
correctly honor the reserved fields (making it so that we can safely extend
them in the future).
Unfortunately, this breaks the old ioctls for a couple of reasons. First,
the flags for the old ioctls get cleared. This means t
Commit 415606588c61 ("PTP: introduce new versions of IOCTLs",
2019-09-13) introduced new versions of the PTP ioctls which actually
validate that the flags are acceptable values.
As part of this, it cleared the flags value using a bitwise
and+negation, in an attempt to prevent the old ioctl from ac
On Wed, Sep 25, 2019 at 10:31:13AM -0700, Florian Fainelli wrote:
> On 9/25/19 4:46 AM, Jose Abreu wrote:
> > From: Jose Abreu
> > Date: Sep/25/2019, 12:41:04 (UTC+00:00)
> >
> >> From: David Miller
> >> Date: Sep/25/2019, 12:33:53 (UTC+00:00)
> >>
> >>> From: Jose Abreu
> >>> Date: Wed, 25 Sep
On 9/25/19 1:44 PM, David Miller wrote:
> From: Marek Vasut
> Date: Sat, 21 Sep 2019 19:53:09 +0200
>
>> The regmap stride is set to 1 for regmap describing 8bit registers already.
>> However, for 16/32/64bit registers, the stride is 2/4/8 respectively. This
>> is not correct, as the switch proto
The regmap stride is set to 1 for regmap describing 8bit registers already.
However, for 16/32/64bit registers, the stride is 2/4/8 respectively. This
is not correct, as the switch protocol supports unaligned register reads
and writes and the KSZ87xx even uses such unaligned register accesses to
re
On Tue, Sep 24, 2019 at 4:11 AM Li RongQing wrote:
>
> userspace openvswitch patch "(dpif-linux: Implement the API
> functions to allow multiple handler threads read upcall)"
> changes its type from U32 to UNSPEC, but leave the kernel
> unchanged
>
> and after kernel 6e237d099fac "(netlink: Relax
BTF-to-C converter previously skipped anonymous enums in an assumption
that those are embedded in struct's field definitions. This is not
always the case and a lot of kernel constants are defined as part of
anonymous enums. This change fixes the logic by eagerly marking all
types as either referenc
On Wed, Sep 25, 2019 at 1:33 PM Daniel Borkmann wrote:
>
> On Wed, Sep 25, 2019 at 11:52:05AM -0700, Andrii Nakryiko wrote:
> > Some recent changes in latest Clang started causing the following
> > warning when unrolling strobemeta test case main loop:
> >
> > progs/strobemeta.h:416:2: warning:
On Wed, Sep 25, 2019 at 04:07:09PM +, Yonghong Song wrote:
>
>
> On 9/24/19 8:20 AM, Carlos Neira wrote:
> > Self tests added for new helper
> >
> > Signed-off-by: Carlos Neira
> > ---
> > tools/testing/selftests/bpf/Makefile | 2 +-
> > tools/testing/selftests/bpf/bpf_helpers
On Wed, Sep 25, 2019 at 11:52:05AM -0700, Andrii Nakryiko wrote:
> Some recent changes in latest Clang started causing the following
> warning when unrolling strobemeta test case main loop:
>
> progs/strobemeta.h:416:2: warning: loop not unrolled: the optimizer was
> unable to perform the requ
From: Masahiro Yamada
When CONFIG_UAPI_HEADER_TEST=y, exported headers are compile-tested to
make sure they can be included from user-space.
Currently, linux/netfilter_bridge/ebtables.h is excluded from the test
coverage. To make it join the compile-test, we need to fix the build
errors attached
New smatch warnings:
net/netfilter/nf_tables_offload.c:316 nft_flow_offload_chain() warn: always
true condition '(policy != -1) => (0-255 != (-1))'
Reported-by: kbuild test robot
Fixes: c9626a2cbdb2 ("netfilter: nf_tables: add hardware offload support")
Signed-off-by: Pablo Neira Ayuso
---
net
From: Florian Westphal
This un-breaks lookups in sets that have the 'dynamic' flag set.
Given this active example configuration:
table filter {
set set1 {
type ipv4_addr
size 64
flags dynamic,timeout
timeout 1m
}
chain input {
type filter hook input priority 0; policy
On Wed, Sep 25, 2019 at 11:36:14AM -0700, Andrii Nakryiko wrote:
> Remove no longer used variables and avoid compiler warnings.
>
> Signed-off-by: Andrii Nakryiko
Applied, thanks!
From: Laura Garcia Liebana
The deletion of a flowtable after a flush in the same transaction
results in EBUSY. This patch adds an activation and deactivation of
flowtables in order to update the _use_ counter.
Signed-off-by: Laura Garcia Liebana
Signed-off-by: Pablo Neira Ayuso
---
include/ne
Default policy is defined as a unsigned 8-bit field, do not use a
negative value to leave it unset, use this new NFT_CHAIN_POLICY_UNSET
instead.
Signed-off-by: Pablo Neira Ayuso
---
include/net/netfilter/nf_tables.h | 2 ++
net/netfilter/nf_tables_api.c | 2 +-
2 files changed, 3 insertions(
Hi,
The following patchset contains Netfilter fixes for net:
1) Add NFT_CHAIN_POLICY_UNSET to replace hardcoded -1 to
specify that the chain policy is unset. The chain policy
field is actually defined as an 8-bit unsigned integer.
2) Remove always true condition reported by smatch in
ch
On Wed, Sep 25, 2019 at 11:30:38AM -0700, Andrii Nakryiko wrote:
> Some compilers emit warning for potential uninitialized next_id usage.
> The code is correct, but control flow is too complicated for some
> compilers to figure this out. Re-initialize next_id to satisfy
> compiler.
>
> Signed-off-
On Tue, Sep 24, 2019 at 09:30:44PM +0200, Björn Töpel wrote:
> On 2019-09-24 18:25, Jonathan Lemon wrote:
> > When kzalloc() failed, NULL was returned to the caller, which
> > tested the pointer with IS_ERR(), which didn't match, so the
> > pointer was used later, resulting in a NULL dereference.
>
On Mon, Sep 23, 2019 at 11:41:12AM -0700, Stanislav Fomichev wrote:
> This is the same problem I found earlier in test_sockopt_inherit:
> there is a race between server thread doing accept() and client
> thread doing connect(). Let's explicitly synchronize them via
> pthread conditional variable.
>
Some recent changes in latest Clang started causing the following
warning when unrolling strobemeta test case main loop:
progs/strobemeta.h:416:2: warning: loop not unrolled: the optimizer was
unable to perform the requested transformation; the transformation might
be disabled or specified a
Remove no longer used variables and avoid compiler warnings.
Signed-off-by: Andrii Nakryiko
---
tools/testing/selftests/bpf/test_sysctl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_sysctl.c
b/tools/testing/selftests/bpf/test_sysctl.c
index 4f8ec1f10a80..
Some compilers emit warning for potential uninitialized next_id usage.
The code is correct, but control flow is too complicated for some
compilers to figure this out. Re-initialize next_id to satisfy
compiler.
Signed-off-by: Andrii Nakryiko
---
tools/lib/bpf/btf_dump.c | 1 +
1 file changed, 1 i
Hi Andre,
"Guedes, Andre" writes:
> Hi Vinicius,
>
>> On Sep 23, 2019, at 10:04 PM, Vinicius Costa Gomes
>> wrote:
>>
>> The problem happens because that when offloading is enabled, the cbs
>> instance is not added to the list.
>>
>> Also, the current code doesn't handle correctly the case w
On 9/25/19 4:46 AM, Jose Abreu wrote:
> From: Jose Abreu
> Date: Sep/25/2019, 12:41:04 (UTC+00:00)
>
>> From: David Miller
>> Date: Sep/25/2019, 12:33:53 (UTC+00:00)
>>
>>> From: Jose Abreu
>>> Date: Wed, 25 Sep 2019 10:44:53 +
>>>
From: David Miller
Date: Sep/24/2019, 20:45:08 (
Hi Dan,
> -Original Message-
> From: Dan Carpenter
> Sent: Tuesday, September 24, 2019 4:21 AM
> To: Parav Pandit
> Cc: netdev@vger.kernel.org; Leon Romanovsky ; Eli Cohen
> ; Doug Ledford ; Jason Gunthorpe
> ; linux-r...@vger.kernel.org; kernel-janit...@vger.kernel.org
> Subject: Re: [P
On 24/09/2019 12:48, Paul Blakey wrote:
> The 'miss' for all or nothing is easy, but the hard part is combining
> all the paths a packet can take in software to a single 'all or nothing'
> rule in hardware.
But you don't combine them to a single rule in hardware, because you
have multiple sequen
Hi,
2019年9月26日(木) 0:25 Levente :
>
> Dear all,
>
>
> I don't know if this is the right place to ask, so please be gentle.
>
> I have a router running OpenWRT, and it fails the some test cases
> defined by the IPv6 forum.
>
> https://www.ipv6ready.org/docs/Core_Conformance_Latest.pdf
>
> It fails
On 9/24/19 8:20 AM, Carlos Neira wrote:
> Self tests added for new helper
>
> Signed-off-by: Carlos Neira
> ---
> tools/testing/selftests/bpf/Makefile | 2 +-
> tools/testing/selftests/bpf/bpf_helpers.h | 3 +
> .../selftests/bpf/progs/test_pidns_kern.c | 71
>
Dear all,
I don't know if this is the right place to ask, so please be gentle.
I have a router running OpenWRT, and it fails the some test cases
defined by the IPv6 forum.
https://www.ipv6ready.org/docs/Core_Conformance_Latest.pdf
It fails 1.2.3 / 1.2.4 / 1.2.5 / 1.2.8 test cases.
My question
This a new feature, it is preferred that it defaults to N.
We will probe the feature support from userspace before actually using it.
Fixes: 95a7233c452a ('net: openvswitch: Set OvS recirc_id from tc chain index')
Signed-off-by: Paul Blakey
---
Changelog:
v1->v2: Changed target to net.
From: David Ahern
A user reported that vrf create fails when IPv6 is disabled at boot using
'ipv6.disable=1':
https://bugzilla.kernel.org/show_bug.cgi?id=204903
The failure is adding fib rules at create time. Add RTNL_FAMILY_IP6MR to
the check in vrf_fib_rule if ipv6_mod_enabled is disabled.
On 9/25/19 12:01 AM, Michal Kubecek wrote:
> Not sure if it's the only problem but vrf_fib_rule() checks
> ipv6_mod_enabled() for AF_INET6 but not for RTNL_FAMILY_IP6MR.
yes, that's the problem. sending a patch soon.
From: Paul Blakey
Date: Wed, 25 Sep 2019 15:28:29 +0300
> This a new feature, it is preferred that it defaults to N.
> We will probe the feature support from userspace before actually using it.
>
> Fixes: 95a7233c452a ('net: openvswitch: Set OvS recirc_id from tc chain
> index')
> Signed-off-by
Здравствуйте! Вас интересуют клиентские базы данных?
This a new feature, it is preferred that it defaults to N.
We will probe the feature support from userspace before actually using it.
Fixes: 95a7233c452a ('net: openvswitch: Set OvS recirc_id from tc chain index')
Signed-off-by: Paul Blakey
---
net/sched/Kconfig | 1 -
1 file changed, 1 deletion
On Wed, Sep 25, 2019 at 10:40:43AM +0800, xiaolinkui wrote:
> This is an unlikely case, use unlikely() on it seems logical.
>
> Signed-off-by: xiaolinkui
It's already here [0], but should probably rather get reverted instead
due to lack of a more elaborate reasoning on why it needs to be done
th
On Wed, Sep 25, 2019 at 01:35:07PM +0200, David Miller wrote:
> From: "Alvaro G. M"
> Date: Wed, 25 Sep 2019 13:05:43 +0200
>
> > Hi, Dan
> >
> > On Wed, Sep 25, 2019 at 01:59:11PM +0300, Dan Carpenter wrote:
> >> The "lp->phy_mode" is an enum but in this context GCC treats it as an
> >> unsigne
On 2019/9/25 下午4:28, Tian, Kevin wrote:
>> From: Jason Wang
>> Sent: Tuesday, September 24, 2019 9:53 PM
>>
>> Mdev bus only supports vfio driver right now, so it doesn't implement
>> match method. But in the future, we may add drivers other than vfio,
>> the first driver could be virtio-mdev. Th
> -Original Message-
> From: Dan Carpenter
> Sent: Wednesday, September 25, 2019 4:29 PM
> To: Radhey Shyam Pandey ; Alvaro G. M
>
> Cc: David S. Miller ; Michal Simek
> ; Russell King ;
> netdev@vger.kernel.org; kernel-janit...@vger.kernel.org
> Subject: [PATCH net] net: axienet: fix a s
From: Jose Abreu
Date: Wed, 25 Sep 2019 11:41:04 +
> From: David Miller
> Date: Sep/25/2019, 12:33:53 (UTC+00:00)
>
>> From: Jose Abreu
>> Date: Wed, 25 Sep 2019 10:44:53 +
>>
>> > From: David Miller
>> > Date: Sep/24/2019, 20:45:08 (UTC+00:00)
>> >
>> >> From: Thierry Reding
>> >>
From: Shubhrajyoti Datta
Date: Mon, 23 Sep 2019 13:49:42 +0530
> macb_64b_desc is always called when HW_DMA_CAP_64B is defined.
> So the return NULL can never be reached. Remove the dead code.
>
> Signed-off-by: Shubhrajyoti Datta
Applied.
On 25.09.2019 13:54, Dan Carpenter wrote:
> The irqreturn_t type is an enum or an unsigned int in GCC. That
> creates to problems because it can't detect if the
> self->aq_hw_ops->hw_irq_read() call fails and at the end the function
> always returns IRQ_HANDLED.
Thanks for noticing this, Dan!
From: jcfara...@gmail.com
Date: Sun, 22 Sep 2019 22:57:29 -0300
> From: Julio Faracco
>
> Function netif_schedule_queue() has a hardcoded comparison between queue
> state and any xoff flag. This comparison does the same thing as method
> netif_xmit_stopped(). In terms of code clarity, it is bett
From: Russell King - ARM Linux admin
Date: Sun, 22 Sep 2019 11:59:32 +0100
> tinywrkb, please can you test this series to ensure that it fixes
> your problem - the previous version has turned out to be a non-starter
> as it introduces more problems, thanks!
>
> The following series attempts to a
According to the CAN Specification (see ISO 11898-1:2015, 8.3.4
Recovery Management), the M_CAN provides means for automatic
retransmission of frames that have lost arbitration or that
have been disturbed by errors during transmission. By default
automatic retransmission is enabled.
The Bosch MCAN
From: Takeshi Misawa
Date: Sun, 22 Sep 2019 16:45:31 +0900
> When ppp is closing, __ppp_xmit_process() failed to enqueue skb
> and skb allocated in ppp_write() is leaked.
>
> syzbot reported :
...
> Fix this by freeing skb, if ppp is closing.
>
> Fixes: 6d066734e9f0 ("ppp: avoid loop in xmit r
From: Jose Abreu
Date: Sep/25/2019, 12:41:04 (UTC+00:00)
> From: David Miller
> Date: Sep/25/2019, 12:33:53 (UTC+00:00)
>
> > From: Jose Abreu
> > Date: Wed, 25 Sep 2019 10:44:53 +
> >
> > > From: David Miller
> > > Date: Sep/24/2019, 20:45:08 (UTC+00:00)
> > >
> > >> From: Thierry Redi
From: Marek Vasut
Date: Sat, 21 Sep 2019 19:53:09 +0200
> The regmap stride is set to 1 for regmap describing 8bit registers already.
> However, for 16/32/64bit registers, the stride is 2/4/8 respectively. This
> is not correct, as the switch protocol supports unaligned register reads
> and write
From: David Miller
Date: Sep/25/2019, 12:33:53 (UTC+00:00)
> From: Jose Abreu
> Date: Wed, 25 Sep 2019 10:44:53 +
>
> > From: David Miller
> > Date: Sep/24/2019, 20:45:08 (UTC+00:00)
> >
> >> From: Thierry Reding
> >> Date: Fri, 20 Sep 2019 19:00:34 +0200
> >>
> >> Also, you're now writ
From: "Alvaro G. M"
Date: Wed, 25 Sep 2019 13:05:43 +0200
> Hi, Dan
>
> On Wed, Sep 25, 2019 at 01:59:11PM +0300, Dan Carpenter wrote:
>> The "lp->phy_mode" is an enum but in this context GCC treats it as an
>> unsigned int so the error handling is never triggered.
>>
>> lp->phy_mo
From: Jose Abreu
Date: Wed, 25 Sep 2019 10:44:53 +
> From: David Miller
> Date: Sep/24/2019, 20:45:08 (UTC+00:00)
>
>> From: Thierry Reding
>> Date: Fri, 20 Sep 2019 19:00:34 +0200
>>
>> Also, you're now writing to the high 32-bits unconditionally, even when
>> it will always be zero beca
On Tue, Sep 24, 2019 at 09:45:08PM +0200, David Miller wrote:
> From: Thierry Reding
> Date: Fri, 20 Sep 2019 19:00:34 +0200
>
> > From: Thierry Reding
> >
> > The DWMAC 4.10 supports the same enhanced addressing mode as later
> > generations. Parse this capability from the hardware feature reg
Hi, Dan
On Wed, Sep 25, 2019 at 01:59:11PM +0300, Dan Carpenter wrote:
> The "lp->phy_mode" is an enum but in this context GCC treats it as an
> unsigned int so the error handling is never triggered.
>
> lp->phy_mode = of_get_phy_mode(pdev->dev.of_node);
> - if (lp->phy_
The "gmac->phy_mode" variable is an enum and in this context GCC will
treat it as an unsigned int so the error handling will never be
triggered.
Fixes: b1c17215d718 ("stmmac: add ipq806x glue layer")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +-
1 f
The "priv->phy_mode" is an enum and in this context GCC will treat it
as an unsigned int so it can never be less than zero.
Fixes: 492caffa8a1a ("net: ethernet: nixge: Add support for National
Instruments XGE netdev")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/ni/nixge.c | 2 +-
1 fi
ср, 25 сент. 2019 г. в 03:31, Jay Vosburgh :
>
> Алексей Захаров wrote:
> [...]
> >Right after reboot one of the slaves hangs with actor port state 71
> >and partner port state 1.
> >It doesn't send lacpdu and seems to be broken.
> >Setting link down and up again fixes slave state.
> [...]
>
>
The "dwmac->phy_mode" is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.
Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b /
GXBB DWMAC")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/stmicro/stmmac/dwmac
The "phy_mode" variable is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.
Fixes: 4c270b55a5af ("net: ethernet: socionext: add AVE ethernet driver")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/socionext/sni_ave.c | 2 +-
1 file cha
The "lp->phy_mode" is an enum but in this context GCC treats it as an
unsigned int so the error handling is never triggered.
Fixes: ee06b1728b95 ("net: axienet: add support for standard phy-mode binding")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
The "priv->phy_interface" variable is an enum and in this context GCC
will treat it as unsigned so the error handling will never be
triggered.
Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC
driver")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/broadcom/bcms
The "priv->phy_interface" variable is an enum and in this context GCC
will treat it as an unsigned int so the error handling is never
triggered.
Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/socionext/netsec.c | 2 +-
1
The "priv->if_mode" is type phy_interface_t which is an enum. In this
context GCC will treat the enum as an unsigned int so this error
handling is never triggered.
Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers")
Signed-off-by: Dan Carpenter
---
drivers/net/ethern
The "priv->phy_mode" variable is an enum and in this context GCC will
treat it as unsigned to the error handling will never trigger.
Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +-
1 file change
The "chip" variable is an enum, and it's treated as unsigned int by GCC
in this context so the error handling isn't triggered.
Fixes: e8d452923ae6 ("cxgb4: clean up init_one")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +-
1 file changed, 1 insertion(+),
The irqreturn_t type is an enum or an unsigned int in GCC. That
creates to problems because it can't detect if the
self->aq_hw_ops->hw_irq_read() call fails and at the end the function
always returns IRQ_HANDLED.
drivers/net/ethernet/aquantia/atlantic/aq_vec.c:316 aq_vec_isr_legacy() warn:
unsig
From: David Miller
Date: Sep/24/2019, 20:45:08 (UTC+00:00)
> From: Thierry Reding
> Date: Fri, 20 Sep 2019 19:00:34 +0200
>
> > From: Thierry Reding
> >
> > The DWMAC 4.10 supports the same enhanced addressing mode as later
> > generations. Parse this capability from the hardware feature regi
The man page of ip-macsec and the existance of the tool makes it seem like
the user could just configure static keys once, and be done with it. That is
not the case. Some form or key management must be done in user space.
Add a note about that.
Signed-off-by: Thomas Haller
---
man/man8/ip-macse
Hi Andreas,
On Mon, Sep 16, 2019 at 4:25 PM wrote:
>
>
>
> On 16.09.2019 13:14, Andreas Schwab wrote:
> > External E-Mail
> >
> >
> > On Sep 16 2019, wrote:
> >
> >> I will have a look on it. It would be good if you could give me some
> >> details about the steps to reproduce it.
> >
> > You nee
Hi Shuah, Tim
On 9/24/19 7:23 PM, Shuah Khan wrote:
On 9/24/19 12:07 PM, tim.b...@sony.com wrote:
-Original Message-
From: Cristian Marussi on Tuesday, September 24, 2019 7:30 AM
Hi Shuah
On 24/09/2019 17:39, Shuah Khan wrote:
On 9/24/19 10:03 AM, Shuah Khan wrote:
On 9/24/19 9:5
Hello my favorite mailing list!
Recently I've been looking into TCP_USER_TIMEOUT and noticed some
strange behaviour on fresh sockets in SYN-SENT state. Full writeup:
https://blog.cloudflare.com/when-tcp-sockets-refuse-to-die/
Here's a reproducer. It does a simple thing: sets TCP_USER_TIMEOUT and
On 25. 09. 19 2:47, Andrew Lunn wrote:
The CPU port does not have a PHY connected to it. So calling
phy_support_asym_pause() results in an Opps. As with other DSA
drivers, add a guard that the port is a user port.
Reported-by: Michal Vokáč
Thank you for the prompt fix Andrew!
Tested-by: Mich
On 25. 09. 19 2:44, Andrew Lunn wrote:
On Tue, Sep 24, 2019 at 03:10:44PM +0200, Michal Vokáč wrote:
On 24. 09. 19 14:31, Andrew Lunn wrote:
I added the printk and the above fix and can confirm that it is the CPU
port and the phy is NULL pointer:
[6.976366] qca8k 2188000.ethernet-1:0a: Usin
89 matches
Mail list logo
