Re: [PATCH net] net: openvswitch: fix possible memleak on createvport fails

2019-09-21 Thread Pravin Shelar
On Sat, Sep 21, 2019 at 8:48 PM Hillf Danton wrote: > > On Sun, 9 Sep 2019 11:14 from Pravin Shelar > > > > > > There is already patch a patch to fix this memory leak. > > > https://patchwork.ozlabs.org/patch/1144316/ > > > Can you or Hillf post it on netdev list? > > > > Was that posted without

Re: CONFIG_NET_TC_SKB_EXT

2019-09-21 Thread Alexei Starovoitov
On Sat, Sep 21, 2019 at 8:15 PM Pravin Shelar wrote: > > > Any suggestions on the way forward? :( since there is no clear and agreed by everyone path forward the simple revert is the best option. Next release cycle you can come up with something that works for everyone.

Re: [PATCH V2 net 1/1] net/tls(TLS_SW): Fix list_del double free caused by a race condition in tls_tx_records

2019-09-21 Thread Pooja Trivedi
On Wed, Sep 18, 2019 at 5:45 PM Jakub Kicinski wrote: > > On Wed, 18 Sep 2019 17:37:44 -0400, Pooja Trivedi wrote: > > Hi Jakub, > > > > I have explained one potential way for the race to happen in my > > original message to the netdev mailing list here: > > https://marc.info/?l=linux-netdev&m=156

Re: CONFIG_NET_TC_SKB_EXT

2019-09-21 Thread Pravin Shelar
On Fri, Sep 20, 2019 at 5:06 PM Daniel Borkmann wrote: > > On 9/21/19 12:56 AM, Jakub Kicinski wrote: > [...] > >> I thought idea of stuffing things into skb extensions are only justified if > >> it's not enabled by default for everyone. :( > >> > >> [0] > >> https://lore.kernel.org/netdev/ca

Re: [PATCH net] net: openvswitch: fix possible memleak on create vport fails

2019-09-21 Thread Pravin Shelar
On Sat, Sep 21, 2019 at 8:07 AM wrote: > > From: Tonghao Zhang > > If we register a net device which name is not valid > (dev_get_valid_name), register_netdevice will return err > codes and will not run dev->priv_destructor. The memory > will leak. This patch adds check in ovs_vport_free and > se

Re: [Patch net] net_sched: add policy validation for action attributes

2019-09-21 Thread Jakub Kicinski
On Wed, 18 Sep 2019 18:44:43 -0700, Cong Wang wrote: > Similar to commit 8b4c3cdd9dd8 > ("net: sched: Add policy validation for tc attributes"), we need > to add proper policy validation for TC action attributes too. > > Cc: David Ahern > Cc: Jamal Hadi Salim > Cc: Jiri Pirko > Signed-off-by: C

Re: [Patch net] net_sched: add max len check for TCA_KIND

2019-09-21 Thread Jakub Kicinski
On Wed, 18 Sep 2019 22:15:24 -0700, Cong Wang wrote: > On Wed, Sep 18, 2019 at 7:41 PM David Ahern wrote: > > On 9/18/19 5:24 PM, Cong Wang wrote: > > > The TCA_KIND attribute is of NLA_STRING which does not check > > > the NUL char. KMSAN reported an uninit-value of TCA_KIND which > > > is like

Re: [PATCH net] net: sched: fix possible crash in tcf_action_destroy()

2019-09-21 Thread Jakub Kicinski
On Wed, 18 Sep 2019 14:37:21 -0700, Cong Wang wrote: > On Wed, Sep 18, 2019 at 12:57 PM 'Eric Dumazet' via syzkaller > wrote: > > > > If the allocation done in tcf_exts_init() failed, > > we end up with a NULL pointer in exts->actions. > ... > > diff --git a/net/sched/cls_api.c b/net/sched/cls_a

Re: [PATCH net] net: openvswitch: fix possible memleak on create vport fails

2019-09-21 Thread Jakub Kicinski
On Tue, 17 Sep 2019 23:40:08 +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > If we register a net device which name is not valid > (dev_get_valid_name), register_netdevice will return err > codes and will not run dev->priv_destructor. The memory > will leak. This patch adds check

[PATCH] net: dsa: microchip: Always set regmap stride to 1

2019-09-21 Thread Marek Vasut
The regmap stride is set to 1 for regmap describing 8bit registers already. However, for 16/32/64bit registers, the stride is 2/4/8 respectively. This is not correct, as the switch protocol supports unaligned register reads and writes and the KSZ87xx even uses such unaligned register accesses to re

[PATCH net] net: openvswitch: fix possible memleak on create vport fails

2019-09-21 Thread xiangxia . m . yue
From: Tonghao Zhang If we register a net device which name is not valid (dev_get_valid_name), register_netdevice will return err codes and will not run dev->priv_destructor. The memory will leak. This patch adds check in ovs_vport_free and set the vport NULL. Fixes: 309b66970ee2 ("net: openvswit

Re: [PATCH 4/5] ieee802154: enforce CAP_NET_RAW for raw sockets

2019-09-21 Thread Greg Kroah-Hartman
On Sat, Sep 21, 2019 at 01:58:55PM +0200, Stefan Schmidt wrote: > Hello. > > On 20.09.19 09:35, Greg Kroah-Hartman wrote: > > From: Ori Nimron > > > > When creating a raw AF_IEEE802154 socket, CAP_NET_RAW needs to be > > checked first. > > > > Signed-off-by: Ori Nimron > > Signed-off-by: Greg

Re: [PATCH 4/5] ieee802154: enforce CAP_NET_RAW for raw sockets

2019-09-21 Thread Stefan Schmidt
Hello. On 20.09.19 09:35, Greg Kroah-Hartman wrote: > From: Ori Nimron > > When creating a raw AF_IEEE802154 socket, CAP_NET_RAW needs to be > checked first. > > Signed-off-by: Ori Nimron > Signed-off-by: Greg Kroah-Hartman > --- > net/ieee802154/socket.c | 3 +++ > 1 file changed, 3 inserti

Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-21 Thread Алексей Захаров
сб, 21 сент. 2019 г. в 10:06, Jay Vosburgh : > > Алексей Захаров wrote: > > >> > >> Jay Vosburgh wrote: > >> [...] > >> > In any event, I think I see what the failure is, I'm working up > >> >a patch to test and will post it when I have it ready. > >> > >> Aleksei, > >> > >>

Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-21 Thread Jay Vosburgh
Алексей Захаров wrote: >> >> Jay Vosburgh wrote: >> [...] >> > In any event, I think I see what the failure is, I'm working up >> >a patch to test and will post it when I have it ready. >> >> Aleksei, >> >> Would you be able to test the following patch and see if it >> resol