Re: VRF Issue Since kernel 5

2019-09-11 Thread Gowen
currently: vmAdmin@NETM06:~$ uname -r 5.0.0-1018-azure vmAdmin@NETM06:~$ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=18.04 DISTRIB_CODENAME=bionic DISTRIB_DESCRIPTION="Ubuntu 18.04.3 LTS" I don't keep a history of kernel versions on test but I noticed it had gone to kernel 5 and st

Re: VRF Issue Since kernel 5

2019-09-11 Thread Gowen
Hi David -thanks for getting back to me The DNS servers are 10.24.65.203 or 10.24.64.203 which you want to go out mgmt-vrf. correct? No - 10.24.65.203 10.25.65.203, so should hit the route leak rule as below (if I've put the 10.24.64.0/24 subnet anywhere it is a typo) vmAdmin@NETM06:~$ ip ro

Re: [PATCH bpf-next v10 2/4] bpf: new helper to obtain namespace data from current task New bpf helper bpf_get_current_pidns_info.

2019-09-11 Thread Yonghong Song
On 9/11/19 9:16 AM, Eric W. Biederman wrote: > Al Viro writes: > >> On Tue, Sep 10, 2019 at 10:35:09PM +, Yonghong Song wrote: >>> >>> Carlos, >>> >>> Discussed with Eric today for what is the best way to get >>> the device number for a namespace. The following patch seems >>> a reasonable

Re: [PATCH net v2 01/11] net: core: limit nested device depth

2019-09-11 Thread Taehee Yoo
On Thu, 12 Sep 2019 at 07:32, David Miller wrote: > Hi David Thank you for the review! > From: Taehee Yoo > Date: Sat, 7 Sep 2019 22:45:32 +0900 > > > Current code doesn't limit the number of nested devices. > > Nested devices would be handled recursively and this needs huge stack > > memory.

Re: [PATCH v1 net-next 12/15] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload

2019-09-11 Thread Vladimir Oltean
Hi Vinicius, On 11/09/2019, Vinicius Costa Gomes wrote: > Hi, > > Vladimir Oltean writes: > >> This qdisc offload is the closest thing to what the SJA1105 supports in >> hardware for time-based egress shaping. The switch core really is built >> around SAE AS6802/TTEthernet (a TTTech standard) bu

Re: [Patch net] sch_sfb: fix a crash in sfb_destroy()

2019-09-11 Thread Cong Wang
On Wed, Sep 11, 2019 at 2:36 PM Eric Dumazet wrote: > > It seems a similar fix would be needed in net/sched/sch_dsmark.c ? > Yeah, or just add a NULL check in dsmark_destroy(). Anyway, I will send a separate patch for it. Thanks.

Re: [PATCH v3 2/2] tcp: Add rcv_wnd to TCP_INFO

2019-09-11 Thread Neal Cardwell
On Wed, Sep 11, 2019 at 6:32 PM Thomas Higdon wrote: > > Neal Cardwell mentioned that rcv_wnd would be useful for helping > diagnose whether a flow is receive-window-limited at a given instant. > > This serves the purpose of adding an additional __u32 to avoid the > would-be hole caused by the add

Re: [net 0/2][pull request] Intel Wired LAN Driver Updates 2019-09-11

2019-09-11 Thread David Miller
From: Jeff Kirsher Date: Wed, 11 Sep 2019 09:49:53 -0700 > This series contains fixes to ixgbe. > > Alex fixes up the adaptive ITR scheme for ixgbe which could result in a > value that was either 0 or something less than 10 which was causing > issues with hardware features, like RSC, that do not

Re: [PATCH net-next] nfp: read chip model from the PluDevice register

2019-09-11 Thread David Miller
From: Simon Horman Date: Wed, 11 Sep 2019 16:21:18 +0100 > From: Dirk van der Merwe > > The PluDevice register provides the authoritative chip model/revision. > > Since the model number is purely used for reporting purposes, follow > the hardware team convention of subtracting 0x10 from the Pl

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Andrew Lunn
> > Feature series targeting netdev must be prefixed "PATCH net-next". As > > Thanks for the info. Out of curiosity, where should I have gleaned this > info from? This is my first contribution to netdev, so I wasnt familiar > with the etiquette. It is also a good idea to 'lurk' in a mailing list

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Andrew Lunn
> We have a setup as follows: > > Marvell 88E6240 switch chip, accepting traffic from 4 ports. Port 1 > (P1) is critical priority, no dropped packets allowed, all others can > be best effort. > > CPU port of swtich chip is connected via phy to phy of intel i210 (igb > driver). > > i210 is connec

Re: [PATCH net] tcp: fix tcp_ecn_withdraw_cwr() to clear TCP_ECN_QUEUE_CWR

2019-09-11 Thread David Miller
From: Neal Cardwell Date: Mon, 9 Sep 2019 16:56:02 -0400 > Fix tcp_ecn_withdraw_cwr() to clear the correct bit: > TCP_ECN_QUEUE_CWR. > > Rationale: basically, TCP_ECN_DEMAND_CWR is a bit that is purely about > the behavior of data receivers, and deciding whether to reflect > incoming IP ECN CE

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread Andrew Lunn
> It is not just for broadcast storm protection. The original issue that > made me look in to all of this turned out to be rx descritor ring > buffer exhaustion due to the CPU not being able to keep up with packet > reception. Pause frames does not really solve this problem. The switch will at som

Re: [PATCH net-next] ipv6: Don't use dst gateway directly in ip6_confirm_neigh()

2019-09-11 Thread David Miller
From: Stefano Brivio Date: Mon, 9 Sep 2019 22:44:06 +0200 > This is the equivalent of commit 2c6b55f45d53 ("ipv6: fix neighbour > resolution with raw socket") for ip6_confirm_neigh(): we can send a > packet with MSG_CONFIRM on a raw socket for a connected route, so the > gateway would be :: here

[PATCH v3 1/2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-11 Thread Thomas Higdon
For receive-heavy cases on the server-side, we want to track the connection quality for individual client IPs. This counter, similar to the existing system-wide TCPOFOQueue counter in /proc/net/netstat, tracks out-of-order packet reception. By providing this counter in TCP_INFO, it will allow under

[PATCH v3 2/2] tcp: Add rcv_wnd to TCP_INFO

2019-09-11 Thread Thomas Higdon
Neal Cardwell mentioned that rcv_wnd would be useful for helping diagnose whether a flow is receive-window-limited at a given instant. This serves the purpose of adding an additional __u32 to avoid the would-be hole caused by the addition of the tcpi_rcvi_ooopack field. Signed-off-by: Thomas Higd

Re: [PATCH net v2 01/11] net: core: limit nested device depth

2019-09-11 Thread David Miller
From: Taehee Yoo Date: Sat, 7 Sep 2019 22:45:32 +0900 > Current code doesn't limit the number of nested devices. > Nested devices would be handled recursively and this needs huge stack > memory. So, unlimited nested devices could make stack overflow. ... > Splat looks like: > [ 140.483124] BUG

Re: [Patch net] sch_sfb: fix a crash in sfb_destroy()

2019-09-11 Thread Eric Dumazet
On 9/11/19 8:34 PM, Cong Wang wrote: > When tcf_block_get() fails in sfb_init(), q->qdisc is still a NULL > pointer which leads to a crash in sfb_destroy(). > > Linus suggested three solutions for this problem, the simplest fix > is just moving the noop_qdisc assignment before tcf_block_get() >

Re: [PATCH net] tcp: remove empty skb from write queue in error cases

2019-09-11 Thread Eric Dumazet
On Wed, Sep 11, 2019 at 7:36 PM Christoph Paasch wrote: > > Hello, > > On Mon, Aug 26, 2019 at 11:04 AM Eric Dumazet wrote: > > > > Vladimir Rutsky reported stuck TCP sessions after memory pressure > > events. Edge Trigger epoll() user would never receive an EPOLLOUT > > notification allowing the

[PATCH net-next] ip: support SO_MARK cmsg

2019-09-11 Thread Willem de Bruijn
From: Willem de Bruijn Enable setting skb->mark for UDP and RAW sockets using cmsg. This is analogous to existing support for TOS, TTL, txtime, etc. Packet sockets already support this as of commit c7d39e32632e ("packet: support per-packet fwmark for af_packet sendmsg"). Similar to other field

Re: [PATCH v1 net-next 12/15] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload

2019-09-11 Thread Vinicius Costa Gomes
Hi, Vladimir Oltean writes: > This qdisc offload is the closest thing to what the SJA1105 supports in > hardware for time-based egress shaping. The switch core really is built > around SAE AS6802/TTEthernet (a TTTech standard) but can be made to > operate similarly to IEEE 802.1Qbv with some con

Re: [PATCH v1 net-next 15/15] net: dsa: sja1105: Implement state machine for TAS with PTP clock source

2019-09-11 Thread Vinicius Costa Gomes
Hi Vladimir, Vladimir Oltean writes: > Tested using the following bash script and the tc from iproute2-next: > > #!/bin/bash > > set -e -u -o pipefail > > NSEC_PER_SEC="10" > > gatemask() { > local tc_list="$1" > local mask=0 > >

[bpf-next,v3] samples: bpf: add max_pckt_size option at xdp_adjust_tail

2019-09-11 Thread Daniel T. Lee
Currently, at xdp_adjust_tail_kern.c, MAX_PCKT_SIZE is limited to 600. To make this size flexible, a new map 'pcktsz' is added. By updating new packet size to this map from the userland, xdp_adjust_tail_kern.o will use this value as a new max_pckt_size. If no '-P ' option is used, the size of max

[v2 1/3] samples: pktgen: make variable consistent with option

2019-09-11 Thread Daniel T. Lee
This commit changes variable names that can cause confusion. For example, variable DST_MIN is quite confusing since the keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl. On the following commit, 'dst_min' will be used to set destination IP, and the existing variable name DST_MIN s

[v2 2/3] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing

2019-09-11 Thread Daniel T. Lee
This commit adds CIDR parsing and IP validate helper function to parse single IP or range of IP with CIDR. (e.g. 198.18.0.0/15) Helpers will be used in prior to set target address in samples/pktgen. Signed-off-by: Daniel T. Lee --- samples/pktgen/functions.sh | 122 +

[v2 3/3] samples: pktgen: allow to specify destination IP range (CIDR)

2019-09-11 Thread Daniel T. Lee
Currently, kernel pktgen has the feature to specify destination address range for sending packet. (e.g. pgset "dst_min/dst_max") But on samples, each of the scripts doesn't have any option to achieve this. This commit adds the feature to specify the destination address range with CIDR. -d :

Re: ixgbe: driver drops packets routed from an IPSec interface with a "bad sa_idx" error

2019-09-11 Thread Jeff Kirsher
On Wed, 2019-09-11 at 10:50 -0400, Michael Marley wrote: > On 2019-09-11 02:15, Steffen Klassert wrote: > > On Tue, Sep 10, 2019 at 06:53:30PM -0400, Michael Marley wrote: > > > StrongSwan has hardware offload disabled by default, and I > > > didn't > > > enable > > > it explicitly. I also alread

[Patch net] sch_sfb: fix a crash in sfb_destroy()

2019-09-11 Thread Cong Wang
When tcf_block_get() fails in sfb_init(), q->qdisc is still a NULL pointer which leads to a crash in sfb_destroy(). Linus suggested three solutions for this problem, the simplest fix is just moving the noop_qdisc assignment before tcf_block_get() so that qdisc_put() would become a nop. Fixes: 652

[PATCH bpf] bpf: respect CAP_IPC_LOCK in RLIMIT_MEMLOCK check

2019-09-11 Thread Christian Barcenas
A process can lock memory addresses into physical RAM explicitly (via mlock, mlockall, shmctl, etc.) or implicitly (via VFIO, perf ring-buffers, bpf maps, etc.), subject to RLIMIT_MEMLOCK limits. CAP_IPC_LOCK allows a process to exceed these limits, and throughout the kernel this capability is che

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Xin Long
On Wed, Sep 11, 2019 at 8:56 PM Marcelo Ricardo Leitner wrote: > > On Wed, Sep 11, 2019 at 05:38:33PM +0800, Xin Long wrote: > > On Wed, Sep 11, 2019 at 5:21 PM Xin Long wrote: > > > > > > On Wed, Sep 11, 2019 at 5:03 PM David Laight > > > wrote: > > > > > > > > From: Xin Long [mailto:lucien...

Re: [PATCH net] tcp: remove empty skb from write queue in error cases

2019-09-11 Thread Christoph Paasch
Hello, On Mon, Aug 26, 2019 at 11:04 AM Eric Dumazet wrote: > > Vladimir Rutsky reported stuck TCP sessions after memory pressure > events. Edge Trigger epoll() user would never receive an EPOLLOUT > notification allowing them to retry a sendmsg(). > > Jason tested the case of sk_stream_alloc_skb

[PATCH bpf-next 3/3] samples/bpf: fix xdpsock l2fwd tx for unaligned mode

2019-09-11 Thread Ciara Loftus
Preserve the offset of the address of the received descriptor, and include it in the address set for the tx descriptor, so the kernel can correctly locate the start of the packet data. Fixes: 03895e63ff97 ("samples/bpf: add buffer recycling for unaligned chunks to xdpsock") Signed-off-by: Ciara L

[PATCH bpf-next 1/3] i40e: fix xdp handle calculations

2019-09-11 Thread Ciara Loftus
Commit 4c5d9a7fa149 ("i40e: fix xdp handle calculations") reintroduced the addition of the umem headroom to the xdp handle in the i40e_zca_free, i40e_alloc_buffer_slow_zc and i40e_alloc_buffer_zc functions. However, the headroom is already added to the handle in the function i40_run_xdp_zc. This co

[PATCH bpf-next 2/3] ixgbe: fix xdp handle calculations

2019-09-11 Thread Ciara Loftus
Commit 7cbbf9f1fa23 ("ixgbe: fix xdp handle calculations") reintroduced the addition of the umem headroom to the xdp handle in the ixgbe_zca_free, ixgbe_alloc_buffer_slow_zc and ixgbe_alloc_buffer_zc functions. However, the headroom is already added to the handle in the function ixgbe_run_xdp_zc. T

Re: VRF Issue Since kernel 5

2019-09-11 Thread David Ahern
At LPC this week and just now getting a chance to process the data you sent. On 9/9/19 8:46 AM, Gowen wrote: > the production traffic is all in the 10.0.0.0/8 network (eth1 global VRF) > except for a few subnets (DNS) which are routed out eth0 (mgmt-vrf) > > > Admin@NETM06:~$ ip route show > de

Re: VRF Issue Since kernel 5

2019-09-11 Thread David Ahern
On 9/9/19 10:28 AM, Alexis Bauvin wrote: > Also, your `unreachable default metric 4278198272` route looks odd to me. > New recommendation from FRR group. See https://www.kernel.org/doc/Documentation/networking/vrf.txt and search for 4278198272

[net-next v2 09/13] i40e: use BIT macro to specify the cloud filter field flags

2019-09-11 Thread Jeff Kirsher
From: Jacob Keller The macros used to specify the cloud filter fields are intended to be individual bits. Declare them using the BIT() macro to make their intention a little more clear. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/

[net-next v2 04/13] i40e: use ktime_get_real_ts64 instead of ktime_to_timespec64

2019-09-11 Thread Jeff Kirsher
From: Jacob Keller Remove a call to ktime_to_timespec64 by calling ktime_get_real_ts64 directly. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[net-next v2 10/13] i40e: clear __I40E_VIRTCHNL_OP_PENDING on invalid min Tx rate

2019-09-11 Thread Jeff Kirsher
From: Stefan Assmann In the case of an invalid min Tx rate being requested i40e_ndo_set_vf_bw() immediately returns -EINVAL instead of releasing __I40E_VIRTCHNL_OP_PENDING first. Signed-off-by: Stefan Assmann Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel

[net-next v2 05/13] i40e: remove I40E_AQC_ADD_CLOUD_FILTER_OIP

2019-09-11 Thread Jeff Kirsher
From: Jacob Keller The bit 0x0001 used in the cloud filters adminq command is reserved, and is not actually a valid type. The Linux driver has never used this type, and it's not clear if any driver ever has. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next v2 00/13][pull request] Intel Wired LAN Driver Updates 2019-09-11

2019-09-11 Thread Jeff Kirsher
This series contains updates to i40e, ixgbe/vf and iavf. Wenwen Wang fixes a potential memory leak where 3 allocated variables are not properly cleaned up on failure for ixgbe. Stefan Assmann fixes a potential kernel panic found when repeatedly spawning and destroying VFs in i40e when a NULL poin

[net-next v2 02/13] i40e: check __I40E_VF_DISABLE bit in i40e_sync_filters_subtask

2019-09-11 Thread Jeff Kirsher
From: Stefan Assmann While testing VF spawn/destroy the following panic occurred. BUG: unable to handle kernel NULL pointer dereference at 0029 [...] Workqueue: i40e i40e_service_task [i40e] RIP: 0010:i40e_sync_vsi_filters+0x6fd/0xc60 [i40e] [...] Call Trace: ? __switch_to_asm+0x35/

[net-next v2 06/13] i40e: mark additional missing bits as reserved

2019-09-11 Thread Jeff Kirsher
From: Jacob Keller Mark bits 0xD through 0xF for the command flags of a cloud filter as reserved. These bits are not yet defined and are considered as reserved in the data sheet. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i

[net-next v2 12/13] net/ixgbevf: make array api static const, makes object smaller

2019-09-11 Thread Jeff Kirsher
From: Colin Ian King Don't populate the array API on the stack but instead make it static const. Makes the object code smaller by 58 bytes. Before: textdata bss dec hex filename 829699763 256 92988 16b3c ixgbevf/ixgbevf_main.o After: textdata bss

[net-next v2 08/13] i40e: Fix message for other card without FEC.

2019-09-11 Thread Jeff Kirsher
From: Czeslaw Zagorski When variable "req_fec, fec, an" are empty, dmesg shows log with "Requested FEC: , Negotiated FEC: , Autoneg:". Add link dmesg log for cards without FEC. Signed-off-by: Czeslaw Zagorski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel

[net-next v2 11/13] iavf: fix MAC address setting for VFs when filter is rejected

2019-09-11 Thread Jeff Kirsher
From: Stefan Assmann Currently iavf unconditionally applies MAC address change requests. This brings the VF in a state where it is no longer able to pass traffic if the PF rejects a MAC filter change for the VF. A typical scenario for a rejected MAC filter is for an untrusted VF to request to cha

[net-next v2 07/13] i40e: fix missed "Negotiated" string in i40e_print_link_message()

2019-09-11 Thread Jeff Kirsher
From: Aleksandr Loktionov The "Negotiated" string in i40e_print_link_message() function was missed. This string has been added to the dmesg and small refactoring done removing common substrings and unifying link status message format. Without this patch it was not clear that FEC is related to neg

[net-next v2 13/13] i40e: fix potential RX buffer starvation for AF_XDP

2019-09-11 Thread Jeff Kirsher
From: Magnus Karlsson When the RX rings are created they are also populated with buffers so that packets can be received. Usually these are kernel buffers, but for AF_XDP in zero-copy mode, these are user-space buffers and in this case the application might not have sent down any buffers to the d

[net 2/2] ixgbe: fix double clean of Tx descriptors with xdp

2019-09-11 Thread Jeff Kirsher
From: Ilya Maximets Tx code doesn't clear the descriptors' status after cleaning. So, if the budget is larger than number of used elems in a ring, some descriptors will be accounted twice and xsk_umem_complete_tx will move prod_tail far beyond the prod_head breaking the completion queue ring. Fi

[net 1/2] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us

2019-09-11 Thread Jeff Kirsher
From: Alexander Duyck There were a couple cases where the ITR value generated via the adaptive ITR scheme could exceed 126. This resulted in the value becoming either 0 or something less than 10. Switching back and forth between a value less than 10 and a value greater than 10 can cause issues as

[net 0/2][pull request] Intel Wired LAN Driver Updates 2019-09-11

2019-09-11 Thread Jeff Kirsher
This series contains fixes to ixgbe. Alex fixes up the adaptive ITR scheme for ixgbe which could result in a value that was either 0 or something less than 10 which was causing issues with hardware features, like RSC, that do not function well with ITR values that low. Ilya Maximets fixes the ixg

[net-next v2 03/13] ixgbe: use skb_get_queue_mapping in tx path

2019-09-11 Thread Jeff Kirsher
From: Tonghao Zhang Use the common api, and don't access queue_mapping directly. Signed-off-by: Tonghao Zhang Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[net-next v2 01/13] ixgbe: fix memory leaks

2019-09-11 Thread Jeff Kirsher
From: Wenwen Wang In ixgbe_configure_clsu32(), 'jump', 'input', and 'mask' are allocated through kzalloc() respectively in a for loop body. Then, ixgbe_clsu32_build_input() is invoked to build the input. If this process fails, next iteration of the for loop will be executed. However, the allocate

Re: VRF Issue Since kernel 5

2019-09-11 Thread David Ahern
On 9/11/19 3:01 PM, Gowen wrote: > Hi all, > > It looks like ip vrf exec checks /etc/resolv.conf (found with strace -e > trace=file sudo ip vrf exec mgmt-vrf host www.google.co.uk &> > ~/straceFileOfVrfHost.txt) , but as I'm on an Azure machine using > netplan, this file isn't updated with DNS ser

RE: [PATCH net-next 1/5] enetc: Fix if_mode extraction

2019-09-11 Thread Claudiu Manoil
>-Original Message- >From: Andrew Lunn >Sent: Tuesday, September 10, 2019 10:44 AM >To: Claudiu Manoil >Cc: David S . Miller ; Alexandru Marginean >; netdev@vger.kernel.org >Subject: Re: [PATCH net-next 1/5] enetc: Fix if_mode extraction > >On Mon, Sep 09, 2019 at 04:24:01PM +, Claudi

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Vivien Didelot
Hi Robert, On Wed, 11 Sep 2019 10:46:05 +0100, Robert Beckett wrote: > > Feature series targeting netdev must be prefixed "PATCH net-next". As > > Thanks for the info. Out of curiosity, where should I have gleaned this > info from? This is my first contribution to netdev, so I wasnt familiar >

[PATCH net-next] nfp: read chip model from the PluDevice register

2019-09-11 Thread Simon Horman
From: Dirk van der Merwe The PluDevice register provides the authoritative chip model/revision. Since the model number is purely used for reporting purposes, follow the hardware team convention of subtracting 0x10 from the PluDevice register to obtain the chip model/revision number. Suggested-b

Re: VRF Issue Since kernel 5

2019-09-11 Thread Mike Manning
Hi Gareth, Could you please also check that all the following are set to 1, I appreciate you've confirmed that the one for tcp is set to 1, and by default the one for raw is also set to 1: sudo sysctl -a | grep l3mdev If not, sudo sysctl net.ipv4.raw_l3mdev_accept=1 sudo sysctl net.ipv4.udp_l3mde

[PATCH iproute2-next] devlink: unknown 'fw_load_policy' string validation

2019-09-11 Thread Simon Horman
From: Dirk van der Merwe The 'fw_load_policy' devlink parameter now supports an unknown value. Suggested-by: Jakub Kicinski Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- Sorry about these depenendencies, some related changes came through in separate patch-sets. 1. Depend

Re: ixgbe: driver drops packets routed from an IPSec interface with a "bad sa_idx" error

2019-09-11 Thread Michael Marley
On 2019-09-11 02:15, Steffen Klassert wrote: On Tue, Sep 10, 2019 at 06:53:30PM -0400, Michael Marley wrote: StrongSwan has hardware offload disabled by default, and I didn't enable it explicitly.  I also already tried turning off all those switches with ethtool and it has no effect.  This do

Re: [PATCH net-next 0/2] qed* Fix series.

2019-09-11 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Wed, 11 Sep 2019 04:42:49 -0700 > The patch series addresses couple of issues in the recent commits. > Patch (1) populates the actual dump-size of config attribute instead of > providing a fixed size value. > Patch(2) updates frame format of flash config buffer

[PATCH ipsec-next v2 5/6] esp4: split esp_output_udp_encap and introduce esp_output_encap

2019-09-11 Thread Sabrina Dubroca
Co-developed-by: Herbert Xu Signed-off-by: Herbert Xu Signed-off-by: Sabrina Dubroca --- net/ipv4/esp4.c | 57 - 1 file changed, 37 insertions(+), 20 deletions(-) diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index c5d826642229..033c61d27148 100

[PATCH ipsec-next v2 0/6] ipsec: add TCP encapsulation support (RFC 8229)

2019-09-11 Thread Sabrina Dubroca
This patchset introduces support for TCP encapsulation of IKE and ESP messages, as defined by RFC 8229 [0]. It is an evolution of what Herbert Xu proposed in January 2018 [1] that addresses the main criticism against it, by not interfering with the TCP implementation at all. The networking stack no

[PATCH ipsec-next v2 2/6] xfrm: introduce xfrm_trans_queue_net

2019-09-11 Thread Sabrina Dubroca
This will be used by TCP encapsulation to write packets to the encap socket without holding the user socket's lock. Without this reinjection, we're already holding the lock of the user socket, and then try to lock the encap socket as well when we enqueue the encrypted packet. While at it, add a BU

[PATCH ipsec-next v2 1/6] net: add queue argument to __skb_wait_for_more_packets and __skb_{,try_}recv_datagram

2019-09-11 Thread Sabrina Dubroca
This will be used by ESP over TCP to handle the queue of IKE messages. Signed-off-by: Sabrina Dubroca --- v2: document the new argument to __skb_try_recv_datagram include/linux/skbuff.h | 11 --- net/core/datagram.c| 27 +-- net/ipv4/udp.c | 3 ++- n

[PATCH ipsec-next v2 6/6] xfrm: add espintcp (RFC 8229)

2019-09-11 Thread Sabrina Dubroca
TCP encapsulation of IKE and IPsec messages (RFC 8229) is implemented as a TCP ULP, overriding in particular the sendmsg and recvmsg operations. A Stream Parser is used to extract messages out of the TCP stream using the first 2 bytes as length marker. Received IKE messages are put on "ike_queue",

[PATCH ipsec-next v2 3/6] xfrm: add route lookup to xfrm4_rcv_encap

2019-09-11 Thread Sabrina Dubroca
At this point, with TCP encapsulation, the dst may be gone, but xfrm_input needs one. Signed-off-by: Sabrina Dubroca --- net/ipv4/xfrm4_protocol.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/ipv4/xfrm4_protocol.c b/net/ipv4/xfrm4_protocol.c index 8a4285712808..ea595c8549c7 1

[PATCH ipsec-next v2 4/6] esp4: prepare esp_input_done2 for non-UDP encapsulation

2019-09-11 Thread Sabrina Dubroca
For espintcp encapsulation, we will need to get the source port from the TCP header instead of UDP. Introduce a variable to hold the port. Co-developed-by: Herbert Xu Signed-off-by: Herbert Xu Signed-off-by: Sabrina Dubroca --- net/ipv4/esp4.c | 16 ++-- 1 file changed, 14 insertio

Re: [PATCH net-next 0/2] devlink: add unknown 'fw_load_policy' value

2019-09-11 Thread David Miller
From: Simon Horman Date: Wed, 11 Sep 2019 12:08:31 +0100 > Dirk says: > > Recently we added an unknown value for the 'reset_dev_on_drv_probe' devlink > parameter. Extend the 'fw_load_policy' parameter in the same way. > > The only driver that uses this right now is the nfp driver. Series appli

Re: [PATCH net] net/rds: An rds_sock is added too early to the hash table

2019-09-11 Thread David Miller
From: Ka-Cheong Poon Date: Wed, 11 Sep 2019 02:58:05 -0700 > In rds_bind(), an rds_sock is added to the RDS bind hash table before > rs_transport is set. This means that the socket can be found by the > receive code path when rs_transport is NULL. And the receive code > path de-references rs_tr

[PATCH iproute2-next] devlink: add 'reset_dev_on_drv_probe' devlink param

2019-09-11 Thread Simon Horman
From: Dirk van der Merwe Add support for the new devlink parameter along with string to uint conversion. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- Depends on devlink.h changes present in net-next commit 5bbd21df5a07 ("devlink: add 'reset_dev_on_drv_probe' param") --- d

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Marcelo Ricardo Leitner
On Wed, Sep 11, 2019 at 05:38:33PM +0800, Xin Long wrote: > On Wed, Sep 11, 2019 at 5:21 PM Xin Long wrote: > > > > On Wed, Sep 11, 2019 at 5:03 PM David Laight > > wrote: > > > > > > From: Xin Long [mailto:lucien@gmail.com] > > > > Sent: 11 September 2019 09:52 > > > > On Tue, Sep 10, 2019

Re: [PATCH 6/7] net: dsa: mv88e6xxx: add egress rate limiting

2019-09-11 Thread kbuild test robot
/Robert-Beckett/net-dsa-mv88e6xxx-features-to-handle-network-storms/20190911-142233 config: x86_64-fedora-25 (attached as .config) compiler: gcc-7 (Debian 7.4.0-11) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add

Re: VRF Issue Since kernel 5

2019-09-11 Thread Gowen
previously mentioned attchements From: Gowen Sent: 11 September 2019 12:19 To: David Ahern ; Alexis Bauvin Cc: netdev@vger.kernel.org Subject: Re: VRF Issue Since kernel 5   Hi there, Your perf command:   isc-worker 20261 [000]  2215.013849: fib:fib_table_lookup: table 10 o

Re: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-11 Thread Vladimir Oltean
Hi Vinicius, On 11/09/2019, Gomes, Vinicius wrote: > Hi Vladimir, > > [...] > >> >> I'll make sure this subtlety is more clearly formulated in the next >> version of the >> patch. >> > > Ack. > >> Actually let me ask you a few questions as well: >> >> - I'm trying to understand what is the correc

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Robert Beckett
On Wed, 2019-09-11 at 11:21 +, Ido Schimmel wrote: > On Tue, Sep 10, 2019 at 09:49:46AM -0700, Florian Fainelli wrote: > > +Ido, Jiri, > > > > On 9/10/19 8:41 AM, Robert Beckett wrote: > > > This patch-set adds support for some features of the Marvell > > > switch > > > chips that can be used

Re: [PATCH net-next] ipv6: Don't use dst gateway directly in ip6_confirm_neigh()

2019-09-11 Thread Nicolas Dichtel
Le 09/09/2019 à 22:44, Stefano Brivio a écrit : > This is the equivalent of commit 2c6b55f45d53 ("ipv6: fix neighbour > resolution with raw socket") for ip6_confirm_neigh(): we can send a > packet with MSG_CONFIRM on a raw socket for a connected route, so the > gateway would be :: here, and we shou

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread kbuild test robot
/Robert-Beckett/net-dsa-mv88e6xxx-features-to-handle-network-storms/20190911-142233 config: mips-allmodconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod

[PATCH net-next 0/2] qed* Fix series.

2019-09-11 Thread Sudarsana Reddy Kalluru
The patch series addresses couple of issues in the recent commits. Patch (1) populates the actual dump-size of config attribute instead of providing a fixed size value. Patch(2) updates frame format of flash config buffer as required by management FW (MFW). Please consider applying it to net-next.

[PATCH net-next 1/2] qed*: Fix size of config attribute dump.

2019-09-11 Thread Sudarsana Reddy Kalluru
Driver currently returns max-buf-size as size of the config attribute. This patch incorporates changes to read this value from MFW (if available) and provide it to the user. Also did a trivial clean up in this path. Fixes: d44a3ced7023 ("qede: Add support for reading the config id attributes.") Si

[PATCH net-next 2/2] qed: Fix Config attribute frame format.

2019-09-11 Thread Sudarsana Reddy Kalluru
MFW associates the entity id to a config attribute instead of assigning one entity id for all the config attributes. This patch incorporates driver changes to link entity id to a config id attribute. Fixes: 0dabbe1bb3a4 ("qed: Add driver API for flashing the config attributes.") Signed-off-by: Sud

Re: [PATCH net-next 01/11] net: aquantia: PTP skeleton declarations and callbacks

2019-09-11 Thread Igor Russkikh
Hi Andrew, >> +struct ptp_clock *clock; >> +struct aq_ptp_s *self; > > I find the use of self in this code quite confusing. It does not > appear to have a clear meaning. It can be a aq_ring_s, aq_nic_c, > aq_hw_s, aq_vec_s. > > Looking at this code i always have to figure out what self

[vhost:linux-next 8/9] drivers/vhost/vhost.c:2076:5: note: in expansion of macro 'array_index_nospec'

2019-09-11 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: f2c4b499aecc0c5a1ec67f3a2a7310cb7168a8ab commit: 4c145987a955269da79312a79ec26638712644bb [8/9] vhost: block speculation of translated descriptors config: mips-malta_kvm_defconfig (attached as .confi

[vhost:linux-next 16/17] include/linux/page_reporting.h:9:34: note: in expansion of macro 'pageblock_order'

2019-09-11 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: 39c226b6b576b23d6d558331e6895f02b0892555 commit: 990055c63121520ad29deca72b1167b392563ddd [16/17] virtio-balloon: Add support for providing unused page reports to host config: riscv-allmodconfig (att

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Ido Schimmel
On Tue, Sep 10, 2019 at 09:49:46AM -0700, Florian Fainelli wrote: > +Ido, Jiri, > > On 9/10/19 8:41 AM, Robert Beckett wrote: > > This patch-set adds support for some features of the Marvell switch > > chips that can be used to handle packet storms. > > > > The rationale for this was a setup that

Re: VRF Issue Since kernel 5

2019-09-11 Thread Gowen
Hi there, Your perf command: isc-worker 20261 [000] 2215.013849: fib:fib_table_lookup: table 10 oif 0 iif 0 proto 0 0.0.0.0/0 -> 127.0.0.1/0 tos 0 scope 0 flags 0 ==> dev eth0 gw 10.24.12.1 src 10.24.12.10 err 0 isc-worker 20261 [000] 2215.013915: fib:fib_table_lookup: table 10 oi

[PATCH net-next 2/2] nfp: devlink: set unknown fw_load_policy

2019-09-11 Thread Simon Horman
From: Dirk van der Merwe If the 'app_fw_from_flash' HWinfo key is invalid, set the 'fw_load_policy' devlink parameter value to unknown. Suggested-by: Jakub Kicinski Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/devlink_param.c | 3 ++- 1

[PATCH net-next 1/2] devlink: add unknown 'fw_load_policy' value

2019-09-11 Thread Simon Horman
From: Dirk van der Merwe Similar to the 'reset_dev_on_drv_probe' devlink parameter, it is useful to have an unknown value which can be used by drivers to report that the hardware value isn't recognized or is otherwise invalid instead of failing the operation. This is especially useful for u8/enu

[PATCH net-next 0/2] devlink: add unknown 'fw_load_policy' value

2019-09-11 Thread Simon Horman
Dirk says: Recently we added an unknown value for the 'reset_dev_on_drv_probe' devlink parameter. Extend the 'fw_load_policy' parameter in the same way. The only driver that uses this right now is the nfp driver. Dirk van der Merwe (2): devlink: add unknown 'fw_load_policy' value nfp: devlin

[PATCH iproute2-next] man: ss.8: add documentation for drop counter

2019-09-11 Thread Andrea Claudi
After commit 6df9c7a06a845 ("ss: add SK_MEMINFO_DROPS display") ss -m displays also a drop counter for each socket. This commit properly document it into the man page. Signed-off-by: Andrea Claudi --- man/man8/ss.8 | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/man/

[PATCH net] net/rds: An rds_sock is added too early to the hash table

2019-09-11 Thread Ka-Cheong Poon
In rds_bind(), an rds_sock is added to the RDS bind hash table before rs_transport is set. This means that the socket can be found by the receive code path when rs_transport is NULL. And the receive code path de-references rs_transport for congestion update check. This can cause a panic. An rds

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread Robert Beckett
On Wed, 2019-09-11 at 10:16 +0100, Robert Beckett wrote: > On Tue, 2019-09-10 at 11:29 -0700, Florian Fainelli wrote: > > On 9/10/19 11:26 AM, Andrew Lunn wrote: > > > On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: > > > > This enables us to negoatiate pause frame transmission to >

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Robert Beckett
On Tue, 2019-09-10 at 13:19 -0400, Vivien Didelot wrote: > Hi Robert, > > On Tue, 10 Sep 2019 16:41:46 +0100, Robert Beckett < > bob.beck...@collabora.com> wrote: > > This patch-set adds support for some features of the Marvell switch > > chips that can be used to handle packet storms. > > > > Th

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Robert Beckett
On Tue, 2019-09-10 at 09:49 -0700, Florian Fainelli wrote: > +Ido, Jiri, > > On 9/10/19 8:41 AM, Robert Beckett wrote: > > This patch-set adds support for some features of the Marvell switch > > chips that can be used to handle packet storms. > > > > The rationale for this was a setup that requir

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Xin Long
On Wed, Sep 11, 2019 at 5:21 PM Xin Long wrote: > > On Wed, Sep 11, 2019 at 5:03 PM David Laight wrote: > > > > From: Xin Long [mailto:lucien@gmail.com] > > > Sent: 11 September 2019 09:52 > > > On Tue, Sep 10, 2019 at 9:19 PM David Laight > > > wrote: > > > > > > > > From: Xin Long > > > >

[vhost:linux-next 14/17] include/linux/mmzone.h:815:3: error: implicit declaration of function 'move_page_to_reported_list'; did you mean 'move_to_free_list'?

2019-09-11 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: 39c226b6b576b23d6d558331e6895f02b0892555 commit: 50ed0c2ecb2e254a50e4ad775840f29d42cf6c00 [14/17] mm: Introduce Reported pages config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Xin Long
On Wed, Sep 11, 2019 at 5:03 PM David Laight wrote: > > From: Xin Long [mailto:lucien@gmail.com] > > Sent: 11 September 2019 09:52 > > On Tue, Sep 10, 2019 at 9:19 PM David Laight > > wrote: > > > > > > From: Xin Long > > > > Sent: 09 September 2019 08:57 > > > > Section 7.2 of rfc7829: "Pee

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread Robert Beckett
On Tue, 2019-09-10 at 11:29 -0700, Florian Fainelli wrote: > On 9/10/19 11:26 AM, Andrew Lunn wrote: > > On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: > > > This enables us to negoatiate pause frame transmission to > > > prioritise > > > packet delivery over throughput. > > > > I

RE: [PATCH net-next v2 2/2] net: stmmac: Support enhanced addressing mode for DWMAC 4.10

2019-09-11 Thread Jose Abreu
From: Florian Fainelli Date: Sep/10/2019, 20:01:01 (UTC+00:00) > On 9/10/19 1:35 AM, Jose Abreu wrote: > > From: Thierry Reding > > Date: Sep/09/2019, 20:13:29 (UTC+00:00) > > > >> On Mon, Sep 09, 2019 at 04:05:52PM +, Jose Abreu wrote: > >>> From: Thierry Reding > >>> Date: Sep/09/2019, 1

RE: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread David Laight
From: Xin Long [mailto:lucien@gmail.com] > Sent: 11 September 2019 09:52 > On Tue, Sep 10, 2019 at 9:19 PM David Laight wrote: > > > > From: Xin Long > > > Sent: 09 September 2019 08:57 > > > Section 7.2 of rfc7829: "Peer Address Thresholds (SCTP_PEER_ADDR_THLDS) > > > Socket Option" extends '

  1   2   >