Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-22 Thread Ido Schimmel
On Thu, Jun 20, 2019 at 07:24:47PM -0700, Florian Fainelli wrote: > On 6/20/2019 4:56 PM, Vivien Didelot wrote: > > This patch adds support for enabling or disabling the flooding of > > unknown multicast traffic on the CPU ports, depending on the value > > of the switchdev SWITCHDEV_ATTR_ID_BRIDGE_

RE: [EXT] [PATCH] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-22 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: Guilherme G. Piccoli > Sent: Saturday, June 22, 2019 2:57 AM > To: GR-everest-linux-l2 ; > netdev@vger.kernel.org > Cc: Ariel Elior ; Sudarsana Reddy Kalluru > ; gpicc...@canonical.com; > jay.vosbu...@canonical.com > Subject: [EXT] [PATCH] bnx2x: Prevent ptp_

Re: [PATCH net-next v5 5/7] taprio: Add support for txtime-assist mode

2019-06-22 Thread kbuild test robot
Hi Vedang, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vedang-Patel/net-sched-Add-txtime-assist-support-for-taprio/20190622-192248 config: i386-randconfig-h1-06230338 (attached as .config

Re: [RFC PATCH 0/2] enable broadcom tagging for bcm531x5 switches

2019-06-22 Thread Florian Fainelli
On 6/19/2019 2:18 AM, Benedikt Spranger wrote: > On Tue, 18 Jun 2019 11:16:23 -0700 > Florian Fainelli wrote: > >> How is that a problem for other machines? Does that lead to some kind >> of broadcast storm because there are machines that keep trying to >> respond to ARP solicitations? > Mirror

Re: [PATCH v2 net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-22 Thread Willem de Bruijn
> > -static void __packet_set_status(struct packet_sock *po, void *frame, int > > status) > > +static void __packet_set_status(struct packet_sock *po, void *frame, int > > status, > > + bool call_complete) > > { > > union tpacket_uhdr h; > > > > @@ -381,6 +3

[PATCH bpf-next v5 3/3] devmap: Allow map lookups from eBPF

2019-06-22 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen We don't currently allow lookups into a devmap from eBPF, because the map lookup returns a pointer directly to the dev->ifindex, which shouldn't be modifiable from eBPF. However, being able to do lookups in devmaps is useful to know (e.g.) whether forwarding to a spe

[PATCH bpf-next v5 2/3] bpf_xdp_redirect_map: Perform map lookup in eBPF helper

2019-06-22 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The bpf_redirect_map() helper used by XDP programs doesn't return any indication of whether it can successfully redirect to the map index it was given. Instead, BPF programs have to track this themselves, leading to programs using duplicate maps to track which entries

[PATCH bpf-next v5 0/3] xdp: Allow lookup into devmaps before redirect

2019-06-22 Thread Toke Høiland-Jørgensen
When using the bpf_redirect_map() helper to redirect packets from XDP, the eBPF program cannot currently know whether the redirect will succeed, which makes it impossible to gracefully handle errors. To properly fix this will probably require deeper changes to the way TX resources are allocated, bu

[PATCH bpf-next v5 1/3] devmap/cpumap: Use flush list instead of bitmap

2019-06-22 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The socket map uses a linked list instead of a bitmap to keep track of which entries to flush. Do the same for devmap and cpumap, as this means we don't have to care about the map index when enqueueing things into the map (and so we can cache the map lookup). Signed-

Re: [PATCH v2 net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-22 Thread Willem de Bruijn
On Sat, Jun 22, 2019 at 1:42 PM Neil Horman wrote: > > When an application is run that: > a) Sets its scheduler to be SCHED_FIFO > and > b) Opens a memory mapped AF_PACKET socket, and sends frames with the > MSG_DONTWAIT flag cleared, its possible for the application to hang > forever in the kerne

Re: [PATCH net] ipv6: fix neighbour resolution with raw socket

2019-06-22 Thread David Miller
From: David Miller Date: Sat, 22 Jun 2019 17:07:12 -0700 (PDT) > Applied and queued up for -stable, thanks. Actually, this needs a warning fix in bluetooth and netfilter. Please fix this up, do a proper allmodconfig build, and resubmit. net/bluetooth/6lowpan.c: In function ‘peer_lookup_dst’: n

Re: [PATCH net] ipv6: fix neighbour resolution with raw socket

2019-06-22 Thread David Miller
From: Nicolas Dichtel Date: Thu, 20 Jun 2019 14:34:34 +0200 > The scenario is the following: the user uses a raw socket to send an ipv6 > packet, destinated to a not-connected network, and specify a connected nh. > Here is the corresponding python script to reproduce this scenario: ... > fd00:17

Re: [PATCH v2 net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-22 Thread David Miller
From: René van Dorst Date: Thu, 20 Jun 2019 14:21:53 +0200 > Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 > switch both supports TRGMII mode. MT7621 TRGMII speed is fix 1200MBit. > > v1->v2: > - Fix breakage on non MT7621 SOC > - Support 25MHz and 40MHz XTAL as MT7530

Re: [PATCH][net-next] netns: restore ops before calling ops_exit_list

2019-06-22 Thread David Miller
From: Li RongQing Date: Thu, 20 Jun 2019 19:24:40 +0800 > ops has been iterated to first element when call pre_exit, and > it needs to restore from save_ops, not save ops to save_ops > > Fixes: d7d99872c144 ("netns: add pre_exit method to struct pernet_operations") > Signed-off-by: Li RongQing

Re: [PATCH net] tipc: add dst_cache support for udp media

2019-06-22 Thread David Miller
From: Xin Long Date: Thu, 20 Jun 2019 19:03:41 +0800 > As other udp/ip tunnels do, tipc udp media should also have a > lockless dst_cache supported on its tx path. > > Here we add dst_cache into udp_replicast to support dst cache > for both rmcast and rcast, and rmcast uses ub->rcast and each >

Re: [PATCH net] tipc: change to use register_pernet_device

2019-06-22 Thread David Miller
From: Xin Long Date: Thu, 20 Jun 2019 18:39:28 +0800 > This patch is to fix a dst defcnt leak, which can be reproduced by doing: > > # ip net a c; ip net a s; modprobe tipc > # ip net e s ip l a n eth1 type veth peer n eth1 netns c > # ip net e c ip l s lo up; ip net e c ip l s eth1 up >

Re: [PATCH net-next v2] ipv6: Error when route does not have any valid nexthops

2019-06-22 Thread David Miller
From: Ido Schimmel Date: Thu, 20 Jun 2019 12:10:21 +0300 > From: Ido Schimmel > > When user space sends invalid information in RTA_MULTIPATH, the nexthop > list in ip6_route_multipath_add() is empty and 'rt_notif' is set to > NULL. > > The code that emits the in-kernel notifications does not c

Re: [PATCH] sis900: fix TX completion

2019-06-22 Thread David Miller
From: Sergej Benilov Date: Thu, 20 Jun 2019 11:02:18 +0200 > Since commit 605ad7f184b60cfaacbc038aa6c55ee68dee3c89 "tcp: refine TSO > autosizing", > outbound throughput is dramatically reduced for some connections, as sis900 > is doing TX completion within idle states only. > > Make TX completi

Re: [PATCH] fjes: no need to check return value of debugfs_create functions

2019-06-22 Thread David Miller
From: Greg Kroah-Hartman Date: Thu, 20 Jun 2019 09:31:06 +0200 > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: "David S. Miller" > Cc: Yangtao Li

[PATCH iproute2-next v3 2/2] uapi: update if_link.h

2019-06-22 Thread Denis Kirjanov
update if_link.h to commit 75345f888f700c4ab2448287e35d48c760b202e6 ("ipoib: show VF broadcast address") Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index bfe7f

[PATCH iproute2-next v3 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-22 Thread Denis Kirjanov
Current code assumes that we print ethernet mac and that doesn't work in the IPoIB case with SRIOV-enabled hardware Before: 11: ib1: mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256 link/infiniband 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff

[PATCH v2 net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-22 Thread Neil Horman
When an application is run that: a) Sets its scheduler to be SCHED_FIFO and b) Opens a memory mapped AF_PACKET socket, and sends frames with the MSG_DONTWAIT flag cleared, its possible for the application to hang forever in the kernel. This occurs because when waiting, the code in tpacket_snd call

[net-next 0/1] Allow 0.0.0.0/8 as a valid address range

2019-06-22 Thread Dave Taht
My talk's slides and video at netdev 0x13 about "Potential IPv4 Unicast expansions" is up, here: https://netdevconf.org/0x13/session.html?talk-ipv4-unicast-expansions There are roughly 419 million IPv4 addresses that are unallocated and unused in the 0, localhost, reserved future multicast, and

[PATCH net-next 1/1] Allow 0.0.0.0/8 as a valid address range

2019-06-22 Thread Dave Taht
The longstanding prohibition against using 0.0.0.0/8 dates back to two issues with the early internet. There was an interoperability problem with BSD 4.2 in 1984, fixed in BSD 4.3 in 1986. BSD 4.2 has long since been retired. Secondly, addresses of the form 0.x.y.z were initially defined only as

Re: [PATCH next 0/3] blackhole device to invalidate dst

2019-06-22 Thread David Ahern
On 6/21/19 6:45 PM, Mahesh Bandewar wrote: > When we invalidate dst or mark it "dead", we assign 'lo' to > dst->dev. First of all this assignment is racy and more over, > it has MTU implications. > > The standard dev MTU is 1500 while the Loopback MTU is 64k. TCP > code when dereferencing the dst

Re: [PATCH net-next 3/7] maintainers: declare aquantia atlantic driver maintenance

2019-06-22 Thread Andrew Lunn
On Sat, Jun 22, 2019 at 01:45:17PM +, Igor Russkikh wrote: > Aquantia is resposible now for all new features and bugfixes. > Reflect that in MAINTAINERS. > > Signed-off-by: Igor Russkikh > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINT

Re: [PATCH net-next 2/7] net: aquantia: add documentation for the atlantic driver

2019-06-22 Thread Andrew Lunn
> + Jumbo Frames > + > + The driver supports Jumbo Frames for all adapters. Jumbo Frames support is > + enabled by changing the MTU to a value larger than the default of 1500. > + The maximum value for the MTU is 16000. Use the ifconfig command to > + increase the MTU size. For

Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

2019-06-22 Thread Andrew Lunn
On Sat, Jun 22, 2019 at 01:45:12PM +, Igor Russkikh wrote: > As it was discussed some time previously, driver is better to > report kernel version string, as it in a best way identifies > the codebase. > > Signed-off-by: Igor Russkikh Nice. Devlink has just gained something similar to ethto

[PATCH net-next 7/7] net: aquantia: implement vlan offload configuration

2019-06-22 Thread Igor Russkikh
set_features should update flags and reinit hardware if vlan offload settings were changed. Signed-off-by: Igor Russkikh Tested-by: Nikita Danilov --- .../net/ethernet/aquantia/atlantic/aq_main.c | 34 +++ 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/drivers/n

[PATCH net-next 3/7] maintainers: declare aquantia atlantic driver maintenance

2019-06-22 Thread Igor Russkikh
Aquantia is resposible now for all new features and bugfixes. Reflect that in MAINTAINERS. Signed-off-by: Igor Russkikh --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0c55b0fedbe2..0f525f1a12dd 100644 --- a/MAINTAINERS +++ b/MAINTAINER

[PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

2019-06-22 Thread Igor Russkikh
As it was discussed some time previously, driver is better to report kernel version string, as it in a best way identifies the codebase. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 7 +++ drivers/net/ethernet/aquantia/atlantic/ver.h| 5 - 2 file

[PATCH net-next 4/7] net: aquantia: added vlan offload related macros and functions

2019-06-22 Thread Igor Russkikh
Register declaration macros required to work with vlan offload mode. Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- .../atlantic/hw_atl/hw_atl_b0_internal.h | 7 +++ .../aquantia/atlantic/hw_atl/hw_atl_llh.c | 16 .../aquantia/atlantic/hw_atl/hw_atl_

[PATCH net-next 0/7] net: aquantia: implement vlan offloads

2019-06-22 Thread Igor Russkikh
This patchset introduces hardware VLAN offload support and also does some maintenance: we replace driver version with uts version string, add documentation file for atlantic driver, and update maintainers adding Igor as a maintainer. Igor Russkikh (7): net: aquantia: replace internal driver vers

[PATCH net-next 5/7] net: aquantia: adding fields and device features for vlan offload

2019-06-22 Thread Igor Russkikh
Updating features and vlan_features with vlan HW offload. Added vlan_tag fields to rx/tx ring_buff to track vlan related data. Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 9 ++--- drivers/net/ethernet/aquantia/atlantic

[PATCH net-next 6/7] net: aquantia: vlan offloads logic in datapath

2019-06-22 Thread Igor Russkikh
Update datapath by adding logic related to hardware assisted vlan strip/insert behaviour. Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- .../net/ethernet/aquantia/atlantic/aq_nic.c | 23 +--- .../net/ethernet/aquantia/atlantic/aq_ring.c | 4 ++ .../aquantia/atlantic/hw_atl/h

[PATCH net-next 2/7] net: aquantia: add documentation for the atlantic driver

2019-06-22 Thread Igor Russkikh
Document contains configuration options description, details and examples of driver various settings. Signed-off-by: Igor Russkikh --- .../device_drivers/aquantia/atlantic.txt | 451 ++ 1 file changed, 451 insertions(+) create mode 100644 Documentation/networking/device_dr

Re: [PATCH v2 0/3] fix bugs when enable route_localnet

2019-06-22 Thread David Miller
From: Zhiqiang Liu Date: Sat, 22 Jun 2019 16:41:49 +0800 > Friendly ping ... I'm not applying this patch series without someone reviewing it.

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-22 Thread Neil Horman
On Fri, Jun 21, 2019 at 04:06:09PM -0400, Willem de Bruijn wrote: > On Fri, Jun 21, 2019 at 3:18 PM Neil Horman wrote: > > > > On Fri, Jun 21, 2019 at 02:31:17PM -0400, Willem de Bruijn wrote: > > > On Fri, Jun 21, 2019 at 12:42 PM Neil Horman > > > wrote: > > > > > > > > On Thu, Jun 20, 2019 at

[PATCH] sis900: remove TxIDLE

2019-06-22 Thread Sergej Benilov
Before "sis900: fix TX completion" patch, TX completion was done on TxIDLE interrupt. TX completion also was the only thing done on TxIDLE interrupt. Since "sis900: fix TX completion", TX completion is done on TxDESC interrupt. So it is not necessary any more to set and to check for TxIDLE. Elimi

[PATCH net] net: aquantia: fix vlans not working over bridged network

2019-06-22 Thread Igor Russkikh
From: Dmitry Bogdanov In configuration of vlan over bridge over aquantia device it was found that vlan tagged traffic is dropped on chip. The reason is that bridge device enables promisc mode, but in atlantic chip vlan filters will still apply. So we have to corellate promisc settings with vlan

Re: [PATCH v2 0/3] fix bugs when enable route_localnet

2019-06-22 Thread Zhiqiang Liu
Friendly ping ... > From: Shijie Luo > > When enable route_localnet, route of the 127/8 address is enabled. > But in some situations like arp_announce=2, ARP requests or reply > work abnormally. > > This patchset fix some bugs when enable route_localnet. > > Change History: > V2: > - Change