[PATCH net] net_sched: sch_mqprio: handle return value of mqprio_queue_get

2019-06-09 Thread Jacob Wen
It may return NULL thus we can't ignore it. --- net/sched/sch_mqprio.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/sched/sch_mqprio.c b/net/sched/sch_mqprio.c index d05086dc3866..d926056f72ac 100644 --- a/net/sched/sch_mqprio.c +++ b/net/sched/sch_mqprio.c @@ -491

Re: [PATCH net 1/2] ipv6: Dump route exceptions too in rt6_dump_route()

2019-06-09 Thread Vaittinen, Matti
Hi Dee Ho Peeps! Wow Stefano, you seem to be quite a detective :) How on earth did you match my new email to this sole netdev intrusion done back at the 2011 %) Impressive! On Sat, 2019-06-08 at 17:02 +0200, Stefano Brivio wrote: > > - retry adding NLM_F_MATCH (for net-next and iproute-next) ac

Re: [PATCH v4 net-next 00/20] net: Enable nexthop objects with IPv4 and IPv6 routes

2019-06-09 Thread Wei Wang
On Sat, Jun 8, 2019 at 2:53 PM David Ahern wrote: > > From: David Ahern > > This is the final set of the initial nexthop object work. When I > started this idea almost 2 years ago, it took 18 seconds to inject > 700k+ IPv4 routes with 1 hop and about 28 seconds for 4-paths. Some > of that time wa

tp->copied_seq used before assignment in tcp_check_urg

2019-06-09 Thread Zhongjie Wang
Hi all, We are a group of researchers at UC Riverside. We recently discovered some weird case in the TCP code in which the tp->copied_seq variable is used before assignment to an appropriate TCP sequence number. It's discovered with our symbolic execution tool, so we'd like to seek confirmation of

Re: [PATCH net-next] ipv6: tcp: send consistent autoflowlabel in TIME_WAIT state

2019-06-09 Thread David Miller
From: Eric Dumazet Date: Sat, 8 Jun 2019 17:58:51 -0700 > In case autoflowlabel is in action, skb_get_hash_flowi6() > derives a non zero skb->hash to the flowlabel. > > If skb->hash is zero, a flow dissection is performed. > > Since all TCP skbs sent from ESTABLISH state inherit their > skb->h

Re: [PATCH net] nfp: ensure skb network header is set for packet redirect

2019-06-09 Thread David Miller
From: Jakub Kicinski Date: Sat, 8 Jun 2019 17:48:03 -0700 > From: John Hurley > > Packets received at the NFP driver may be redirected to egress of another > netdev (e.g. in the case of OvS internal ports). On the egress path, some > processes, like TC egress hooks, may expect the network head

Re: [PATCH net-next 0/2] RGMII delays for SJA1105 DSA driver

2019-06-09 Thread David Miller
From: Vladimir Oltean Date: Sat, 8 Jun 2019 19:12:26 +0300 > This patchset configures the Tunable Delay Lines of the SJA1105 P/Q/R/S > switches. These add a programmable phase offset on the RGMII RX and TX > clock signals and get used by the driver for fixed-link interfaces that > use the rgmii-

Re: [PATCH net-next 1/1] net: phy: broadcom: Add genphy_suspend and genphy_resume for BCM5464

2019-06-09 Thread David Miller
From: Vladimir Oltean Date: Sat, 8 Jun 2019 16:53:56 +0300 > This puts the quad PHY ports in power-down mode when the PHY transitions > to the PHY_HALTED state. It is likely that all the other PHYs support > the BMCR_PDOWN bit, but I only have the BCM5464R to test. > > Signed-off-by: Vladimir

Re: [PATCH net] tcp: fix undo spurious SYNACK in passive Fast Open

2019-06-09 Thread David Miller
From: Yuchung Cheng Date: Fri, 7 Jun 2019 18:26:33 -0700 > Commit 794200d66273 ("tcp: undo cwnd on Fast Open spurious SYNACK > retransmit") may cause tcp_fastretrans_alert() to warn about pending > retransmission in Open state. This is triggered when the Fast Open > server both sends data and ha

Re: [PATCH net-next 0/4] Rethink PHYLINK callbacks for SJA1105 DSA

2019-06-09 Thread David Miller
From: Vladimir Oltean Date: Sat, 8 Jun 2019 16:03:40 +0300 > This patchset implements phylink_mac_link_up and phylink_mac_link_down, > while also removing the code that was modifying the EGRESS and INGRESS > MAC settings for STP and replacing them with the "inhibit TX" > functionality. Series a

Re: [pull request][net 0/7] Mellanox, mlx5 fixes 2019-06-07

2019-06-09 Thread David Miller
From: Saeed Mahameed Date: Fri, 7 Jun 2019 21:47:35 + > This series introduces some fixes to mlx5 driver. > > Please pull and let me know if there is any problem. Pulled. > For -stable v4.17 > ('net/mlx5: Avoid reloading already removed devices') > > For -stable v5.0 > ('net/mlx5e: Av

Re: pull-request: can 2019-06-07

2019-06-09 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 7 Jun 2019 23:15:32 +0200 > this is a pull reqeust of 9 patches for net/master. > > The first patch is by Alexander Dahl and removes a duplicate menu entry from > the Kconfig. The next patch by Joakim Zhang fixes the timeout in the flexcan > driver when settin

Re: [PATCH net-next 1/1] ipv6: tcp: fix potential NULL deref in tcp_v6_send_reset()

2019-06-09 Thread David Miller
From: Eric Dumazet Date: Fri, 7 Jun 2019 12:23:48 -0700 > syzbot found a crash in tcp_v6_send_reset() caused by my latest > change. > > Problem is that if an skb has been queued to socket prequeue, > skb_dst(skb)->dev can not anymore point to the device. > > Fortunately in this case the socket

Re: [PATCH v2 net-next 0/7] Avoid local_irq_save() and use napi_alloc_frag() where possible

2019-06-09 Thread David Miller
From: Sebastian Andrzej Siewior Date: Fri, 7 Jun 2019 21:20:33 +0200 > The first two patches remove local_irq_save() around > `netdev_alloc_cache' which does not work on -RT. Besides helping -RT it > whould benefit the users of the function since they can avoid disabling > interrupts and save a

Re: [PATCH] sis900: re-enable high throughput

2019-06-09 Thread David Miller
From: Eric Dumazet Date: Fri, 7 Jun 2019 12:18:21 -0700 > Note that this suggests the driver is not performing TX completion > fast enough. > > Looking at the driver, I do not see anything requesting interrupt > mitigation, so this might also be caused by a race in the driver > (some skbs being

Re: [PATCH net-next 0/2] SFP polling fixes

2019-06-09 Thread David Miller
From: Robert Hancock Date: Fri, 7 Jun 2019 10:42:34 -0600 > This has an updated version of an earlier patch to ensure that SFP > operations are stopped during shutdown, and another patch suggested by > Russell King to address a potential concurrency issue with SFP state > checks. Series applied

[RFC PATCH net-next 1/1] tc-testing: Scapy plugin and JSON verification for tdc

2019-06-09 Thread Lucas Bates
This is a draft version of two new tdc features. First, the scapy plugin. This requires the scapy Python module installed on the system (plugin was tested against v2.4.2). The intent is to install a given rule (as the command under test) and then generate packets to create statistics for that rule

Re: [PATCH net-next 1/1] net: phy: broadcom: Add genphy_suspend and genphy_resume for BCM5464

2019-06-09 Thread Florian Fainelli
On 6/8/2019 6:53 AM, Vladimir Oltean wrote: > This puts the quad PHY ports in power-down mode when the PHY transitions > to the PHY_HALTED state. It is likely that all the other PHYs support > the BMCR_PDOWN bit, but I only have the BCM5464R to test. Yes, they should all support that low power

explicit maps. Was: [RFC PATCH bpf-next 6/8] libbpf: allow specifying map definitions using BTF

2019-06-09 Thread Alexei Starovoitov
On 6/6/19 6:02 PM, Jakub Kicinski wrote: > On Fri, 7 Jun 2019 00:27:52 +, Alexei Starovoitov wrote: >> the solution we're discussing should solve BPF_ANNOTATE_KV_PAIR too. >> That hack must go. > > I see. > >> If I understood your objections to Andrii's format is that >> you don't like pointe

Re: [PATCH v2 next] nexthop: off by one in nexthop_mpath_select()

2019-06-09 Thread David Miller
From: Dan Carpenter Date: Fri, 7 Jun 2019 18:31:07 +0300 > The nhg->nh_entries[] array is allocated in nexthop_grp_alloc() and it > has nhg->num_nh elements so this check should be >= instead of >. > > Fixes: 430a049190de ("nexthop: Add support for nexthop groups") > Signed-off-by: Dan Carpenter

Re: [PATCH v3 net-next] net: fec_main: Use dev_err() instead of pr_err()

2019-06-09 Thread David Miller
From: Fabio Estevam Date: Fri, 7 Jun 2019 09:14:18 -0300 > dev_err() is more appropriate for printing error messages inside > drivers, so switch to dev_err(). > > Signed-off-by: Fabio Estevam > --- > Changes since v2: > - Use dev_err() instead of netdev_err() - Andy Applied.

Re: [PATCH net-next v2] cxgb4: Set initial IRQ affinity hints

2019-06-09 Thread David Miller
From: Nirranjan Kirubaharan Date: Fri, 7 Jun 2019 04:56:45 -0700 > Spread initial IRQ affinity hints across the device node CPUs, > for nic queue and uld queue IRQs, to load balance and avoid > all interrupts on CPU0. > > Signed-off-by: Nirranjan Kirubaharan > --- > v2: > - Used post increment

Re: [PATCH net] mpls: fix warning with multi-label encap

2019-06-09 Thread David Miller
From: George Wilkie Date: Fri, 7 Jun 2019 11:49:41 +0100 > If you configure a route with multiple labels, e.g. > ip route add 10.10.3.0/24 encap mpls 16/100 via 10.10.2.2 dev ens4 > A warning is logged: > kernel: [ 130.561819] netlink: 'ip': attribute type 1 has an invalid > length. > >

Re: [PATCH net v3] net: phy: rename Asix Electronics PHY driver

2019-06-09 Thread David Miller
From: Michael Schmitz Date: Fri, 7 Jun 2019 17:37:34 +1200 > [Resent to net instead of net-next - may clash with Anders Roxell's patch > series addressing duplicate module names] > > Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") > introduced a new PHY driver drivers/net

Re: [PATCH v2 net] ipv6: flowlabel: fl6_sock_lookup() must use atomic_inc_not_zero

2019-06-09 Thread David Miller
From: Eric Dumazet Date: Thu, 6 Jun 2019 14:32:34 -0700 > Before taking a refcount, make sure the object is not already > scheduled for deletion. > > Same fix is needed in ipv6_flowlabel_opt() > > Fixes: 18367681a10b ("ipv6 flowlabel: Convert np->ipv6_fl_list to RCU.") > Signed-off-by: Eric Du

[PATCH net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del()

2019-06-09 Thread Taehee Yoo
ASSERT_OVSL() in ovs_vport_del() is unnecessary because ovs_vport_del() is only called by ovs_dp_detach_port() and ovs_dp_detach_port() calls ASSERT_OVSL() too. Signed-off-by: Taehee Yoo --- net/openvswitch/vport.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/openvswitch/vport.c b/ne

[PATCH net-next] net: netlink: make netlink_walk_start() void return type

2019-06-09 Thread Taehee Yoo
netlink_walk_start() needed to return an error code because of rhashtable_walk_init(). but that was converted to rhashtable_walk_enter() and it is a void type function. so now netlink_walk_start() doesn't need any return value. Signed-off-by: Taehee Yoo --- net/netlink/af_netlink.c | 15 +++---

[PATCH net] net: openvswitch: do not free vport if register_netdevice() is failed.

2019-06-09 Thread Taehee Yoo
In order to create an internal vport, internal_dev_create() is used and that calls register_netdevice() internally. If register_netdevice() fails, it calls dev->priv_destructor() to free private data of netdev. actually, a private data of this is a vport. Hence internal_dev_create() should not fre

Re: [PATCH] staging: isdn: To make hysdn_proc_entry static.

2019-06-09 Thread gre...@linuxfoundation.org
On Sun, Jun 09, 2019 at 12:24:59AM +, Rishiraj Manwatkar wrote: > Made hysdn_proc_entry static as suggested by Sparse tool. Why is this indented? > > Signed-off-by: Rishiraj Manwatkar > --- > drivers/staging/isdn/hysdn/hysdn_procconf.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele