Hi netdev!
I'm kernel newbie and I'm not sure it's right place to ask though, if
not please let me know the right place. :)
I sent this mail to ask about net_device interface feature called
'tx-udp_tnl-segmentation'. Ethtool does not appear correct status of
offloading, even if the vxlan offloadi
On Thu, Jun 06, 2019 at 01:59:42PM -0700, Jonathan Lemon wrote:
> Check that bpf_map_lookup_elem lookup and structure
> access operats correctly.
>
> Signed-off-by: Jonathan Lemon
Acked-by: Martin KaFai Lau
On Thu, Jun 06, 2019 at 01:59:41PM -0700, Jonathan Lemon wrote:
> Sync uapi/linux/bpf.h
>
> Signed-off-by: Jonathan Lemon
Acked-by: Martin KaFai Lau
On Thu, Jun 06, 2019 at 10:51:39AM -0700, Stanislav Fomichev wrote:
> Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and
> BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks.
>
> BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments.
> BPF_CGROUP_GETSOCKOPT can modify the supplied bu
Hi Andrew,
Am 07.06.2019 um 13:59 schrieb Andrew Lunn:
On Fri, Jun 07, 2019 at 12:34:47PM +1200, Michael Schmitz wrote:
Hi Andew, Anders,
sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY
driver that I just forgot to resend.
It'll clash with your patch, Anders - are
[Resent to net instead of net-next - may clash with Anders Roxell's patch
series addressing duplicate module names]
Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver")
introduced a new PHY driver drivers/net/phy/asix.c that causes a module
name conflict with a pre-existiting dri
On 06/06, Andrii Nakryiko wrote:
> On Thu, Jun 6, 2019 at 3:27 PM Stanislav Fomichev wrote:
> >
> > On 06/06, Andrii Nakryiko wrote:
> > > On Thu, Jun 6, 2019 at 12:03 PM Stanislav Fomichev
> > > wrote:
> > > >
> > > > Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and
> > > > BPF_CGROU
On Thu, Jun 06, 2019 at 08:37:59PM +, Keller, Jacob E wrote:
> No. We use the timecounter to track the time offset, not the
> frequency. That is, our hardware can't represent 64bits of time, but
> it can adjust frequency. The time counter is used to track the
> adjustments from adjtime and set
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, June 6, 2019 8:49 PM
> To: Parav Pandit
> Cc: dsah...@gmail.com; netdev@vger.kernel.org; Jiri Pirko
>
> Subject: Re: [PATCH iproute2-next] devlink: Increase bus,device buffer size to
> 64 bytes
>
> On Thu, 6 Jun 2019 0
On 6/6/2019 1:57 PM, Robert Hancock wrote:
> On 2019-06-06 12:09 p.m., Russell King - ARM Linux admin wrote:
>>> @@ -1466,6 +1467,11 @@ static void sfp_sm_mod_remove(struct sfp *sfp)
>>> static void sfp_sm_event(struct sfp *sfp, unsigned int event)
>>> {
>>> mutex_lock(&sfp->sm_mutex);
>>>
On 2019/06/07 4:41, Jesper Dangaard Brouer wrote:
On Thu, 6 Jun 2019 20:04:20 +0900
Toshiaki Makita wrote:
On 2019/06/05 16:59, Jesper Dangaard Brouer wrote:
On Wed, 5 Jun 2019 14:36:12 +0900
Toshiaki Makita wrote:
This is introduced for admins to check what is happening on XDP_TX when
When we perform an inexact match on FIB nodes via fib6_locate_1(), longer
prefixes will be preferred to shorter ones. However, it might happen that
a node, with higher fn_bit value than some other, has no valid routing
information.
In this case, we'll pick that node, but it will be discarded by th
The commands 'ip -6 route list cache' and 'ip -6 route flush cache'
don't work at all after route exceptions have been moved to a separate
hash table in commit 2b760fcf5cfb ("ipv6: hook up exception table to store
dst cache"). Fix that.
v2: Add count of routes handled in partial dumps, and skip th
Since commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst
cache"), route exceptions reside in a separate hash table, and won't be
found by walking the FIB, so they won't be dumped to userspace on a
RTM_GETROUTE message.
This causes 'ip -6 route list cache' and 'ip -6 route flush cache
On Fri, Jun 07, 2019 at 12:34:47PM +1200, Michael Schmitz wrote:
> Hi Andew, Anders,
>
> sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY
> driver that I just forgot to resend.
>
> It'll clash with your patch, Anders - are you happy to drop the
> CONFIG_ASIX_PHY from y
On Thu, 6 Jun 2019 16:48:51 -0600
David Ahern wrote:
> On 6/6/19 4:37 PM, Martin Lau wrote:
> >> I don't think that can happen in practice, or at least I haven't found a
> >> way to create enough valid exceptions for the same node.
> > That I am not sure. It is not unusual to have many pmtu ex
On Fri, 7 Jun 2019 01:04:14 +, Bshara, Nafea wrote:
> On Jun 6, 2019, at 4:43 PM, Jakub Kicinski wrote:
> >>> Okay, then you know which one is which. Are there multiple ENAs but
> >>> one EFA?
> >>
> >> Yes, very possible. Very common
> >>
> >> Typical use case that instances have one ena f
Sent from my iPhone
On Jun 6, 2019, at 4:43 PM, Jakub Kicinski wrote:
>>> Okay, then you know which one is which. Are there multiple ENAs but
>>> one EFA?
>>
>> Yes, very possible. Very common
>>
>> Typical use case that instances have one ena for control plane, one
>> for internet facing
On Fri, 7 Jun 2019 00:27:52 +, Alexei Starovoitov wrote:
> the solution we're discussing should solve BPF_ANNOTATE_KV_PAIR too.
> That hack must go.
I see.
> If I understood your objections to Andrii's format is that
> you don't like pointer part of key/value while Andrii explained
> why we p
Hi Andew, Anders,
sorry I dropped the ball on that one - I've got a patch for the ax88796b
PHY driver that I just forgot to resend.
It'll clash with your patch, Anders - are you happy to drop the
CONFIG_ASIX_PHY from your series?
Cheers,
Michael
On 7/06/19 12:58 AM, Andrew Lunn wrote
On 6/6/19 5:10 PM, Jakub Kicinski wrote:
> On Thu, 6 Jun 2019 23:27:36 +, Alexei Starovoitov wrote:
>> On 6/6/19 4:02 PM, Andrii Nakryiko wrote:
struct {
int type;
int max_entries;
} my_map __attribute__((map(int,struct my_value))) = {
.typ
On Thu, 6 Jun 2019 23:27:36 +, Alexei Starovoitov wrote:
> On 6/6/19 4:02 PM, Andrii Nakryiko wrote:
> >> struct {
> >> int type;
> >> int max_entries;
> >> } my_map __attribute__((map(int,struct my_value))) = {
> >> .type = BPF_MAP_TYPE_ARRAY,
> >> .max_entr
On Thu, Jun 6, 2019 at 4:49 PM Daniel Borkmann wrote:
>
> Please refer to the patch 1/6 as the main patch with the details
> on the current sendmsg hook API limitations and proposal to fix
> it in order to work with basic applications like DNS. Remaining
> patches are the usual uapi and tooling up
Trivial patch to bpftool in order to complete enabling attaching programs
to BPF_CGROUP_UDP{4,6}_RECVMSG.
Signed-off-by: Daniel Borkmann
Acked-by: Andrey Ignatov
Acked-by: Martin KaFai Lau
---
tools/bpf/bpftool/Documentation/bpftool-cgroup.rst | 6 +-
tools/bpf/bpftool/Documentation/bpftoo
Sync BPF uapi header in order to pull in BPF_CGROUP_UDP{4,6}_RECVMSG
attach types. This is done and preferred as an extra patch in order
to ease sync of libbpf.
Signed-off-by: Daniel Borkmann
Acked-by: Andrey Ignatov
Acked-by: Martin KaFai Lau
---
tools/include/uapi/linux/bpf.h | 2 ++
1 file
Another trivial patch to libbpf in order to enable identifying and
attaching programs to BPF_CGROUP_UDP{4,6}_RECVMSG by section name.
Signed-off-by: Daniel Borkmann
---
tools/lib/bpf/libbpf.c | 4
1 file changed, 4 insertions(+)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
Intention of cgroup bind/connect/sendmsg BPF hooks is to act transparently
to applications as also stated in original motivation in 7828f20e3779 ("Merge
branch 'bpf-cgroup-bind-connect'"). When recently integrating the latter
two hooks into Cilium to enable host based load-balancing with Kubernetes
Add cgroup/recvmsg{4,6} to test_section_names as well. Test run output:
# ./test_section_names
libbpf: failed to guess program type based on ELF section name 'InvAliD'
libbpf: supported section(type) names are: [...]
libbpf: failed to guess attach type based on ELF section name 'InvAliD'
Extend test_sock_addr for recvmsg test cases, bigger parts of the
sendmsg code can be reused for this. Below are the strace view of
the recvmsg rewrites; the sendmsg side does not have a BPF prog
connected to it for the context of this test:
IPv4 test case:
[pid 4846] bpf(BPF_PROG_ATTACH, {tar
Please refer to the patch 1/6 as the main patch with the details
on the current sendmsg hook API limitations and proposal to fix
it in order to work with basic applications like DNS. Remaining
patches are the usual uapi and tooling updates as well as test
cases. Thanks a lot!
v2 -> v3:
- Add att
Inclusion of 'dev' is allowed by the syntax but not handled
correctly by the command. It produces no output for show
command and falsely successful for change command but does
not make any changes.
can be verified with the following steps
# ip -6 tunnel add ip6tnl1 mode ip6gre local fd::1 remote
On Thu, 6 Jun 2019 23:21:25 +, Bshara, Nafea wrote:
> > On Jun 6, 2019, at 4:08 PM, Jakub Kicinski
> > wrote:
> > On Thu, 6 Jun 2019 22:57:21 +, Bshara, Nafea wrote:
> >>> Having said that, it's entirely unclear to me what the user scenario is
> >>> here. You say "which two devices rel
On Fri, Jun 07, 2019 at 12:58:52AM +0200, Stefano Brivio wrote:
> On Thu, 6 Jun 2019 22:37:11 +
> Martin Lau wrote:
>
> > On Fri, Jun 07, 2019 at 12:17:47AM +0200, Stefano Brivio wrote:
> > > On Thu, 6 Jun 2019 21:44:58 +
> > > Martin Lau wrote:
> > >
> > > > > + if (!(filter->fla
On Thu, Jun 6, 2019 at 3:27 PM Stanislav Fomichev wrote:
>
> On 06/06, Andrii Nakryiko wrote:
> > On Thu, Jun 6, 2019 at 12:03 PM Stanislav Fomichev wrote:
> > >
> > > Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and
> > > BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks.
> > >
> > > BPF_CGROUP_
On 6/6/19 4:02 PM, Andrii Nakryiko wrote:
>> struct {
>> int type;
>> int max_entries;
>> } my_map __attribute__((map(int,struct my_value))) = {
>> .type = BPF_MAP_TYPE_ARRAY,
>> .max_entries = 16,
>> };
>>
>> Of course this would need BPF backend support, but at
From: Robert Hancock
Date: Thu, 6 Jun 2019 16:28:04 -0600
> This is a series of enhancements and bug fixes in order to get the mainline
> version of this driver into a more generally usable state, including on
> x86 or ARM platforms. It also converts the driver to use the phylink API
> in order
Sent from my iPhone
> On Jun 6, 2019, at 4:08 PM, Jakub Kicinski
> wrote:
>
> On Thu, 6 Jun 2019 22:57:21 +, Bshara, Nafea wrote:
>>> Having said that, it's entirely unclear to me what the user scenario is
>>> here. You say "which two devices related", yet you only have one bit,
>>> so i
On 6/6/19 4:58 PM, Stefano Brivio wrote:
>>> This also means that to avoid sending duplicates in the case where at
>>> least one rt6_fill_node() call goes through and one fails, we would
>>> need to track the last bucket and entry sent, or, alternatively, to
>>> make sure we can fit the whole node
On Thu, 6 Jun 2019 10:50:56 -0700, Vedang Patel wrote:
> Currently, we are seeing non-critical packets being transmitted outside of
> their timeslice. We can confirm that the packets are being dequeued at the
> right time. So, the delay is induced in the hardware side. The most likely
> reason is
On Fri, 7 Jun 2019 00:58:52 +0200
Stefano Brivio wrote:
> On Thu, 6 Jun 2019 22:37:11 +
> Martin Lau wrote:
>
> > On Fri, Jun 07, 2019 at 12:17:47AM +0200, Stefano Brivio wrote:
> > > On Thu, 6 Jun 2019 21:44:58 +
> > > Martin Lau wrote:
> > >
> > > > > + if (!(filter->flags
On Thu, 6 Jun 2019 22:57:21 +, Bshara, Nafea wrote:
> > Having said that, it's entirely unclear to me what the user scenario is
> > here. You say "which two devices related", yet you only have one bit,
> > so it can indicate that there is another device, not _which_ device is
> > related. Inf
On Thu, 6 Jun 2019 16:47:00 -0600
David Ahern wrote:
> On 6/6/19 3:18 PM, Stefano Brivio wrote:
> > On Thu, 6 Jun 2019 14:57:33 -0600
> > David Ahern wrote:
> >
> >>> This will cause a non-trivial conflict with commit cc5c073a693f
> >>> ("ipv6: Move exception bucket to fib6_nh") on net-next.
Urgent Attention
This is my second time I am sending you this notification, simply contact
Diplomat David Mousn with your contact information and your
nearest airport to land, so that he can deliver the Package worth ($20.5
Million USD) as he just landed in your country now but misplaced your
i
On Thu, Jun 6, 2019 at 2:09 PM Daniel Borkmann wrote:
>
> On 06/04/2019 07:31 PM, Andrii Nakryiko wrote:
> > On Tue, Jun 4, 2019 at 6:45 AM Stanislav Fomichev wrote:
> >> On 06/03, Stanislav Fomichev wrote:
> BTF is mandatory for _any_ new feature.
> >>> If something is easy to support witho
(side note: change was reverted in net stable)
On Wed, Jun 5, 2019 at 8:33 AM David Ahern wrote:
> On 6/4/19 10:58 PM, Lorenzo Colitti wrote:
> > As for making this change in 5.3: we might be able to structure the
> > code differently in a future Android release, assuming the same
> > userspace c
On Thu, 6 Jun 2019 22:37:11 +
Martin Lau wrote:
> On Fri, Jun 07, 2019 at 12:17:47AM +0200, Stefano Brivio wrote:
> > On Thu, 6 Jun 2019 21:44:58 +
> > Martin Lau wrote:
> >
> > > > + if (!(filter->flags & RTM_F_CLONED)) {
> > > > + err = rt6_fill_node(net, arg->sk
Sent from my iPhone
> On Jun 6, 2019, at 3:05 PM, Jakub Kicinski
> wrote:
>
>> On Thu, 6 Jun 2019 21:40:19 +, Bshara, Nafea wrote:
>> On 6/6/19, 10:16 AM, "Jakub Kicinski" wrote:
>>
>>Hi Samih!
>>
>>Please don't top post on Linux kernel mailing lists.
>>
>>>On Thu, 6 Jun
On 6/6/19 4:37 PM, Martin Lau wrote:
>> I don't think that can happen in practice, or at least I haven't found a
>> way to create enough valid exceptions for the same node.
> That I am not sure. It is not unusual to have many pmtu exceptions in
> a gateway node.
>
yes.
Stefano: you could genera
On 6/6/19 3:18 PM, Stefano Brivio wrote:
> On Thu, 6 Jun 2019 14:57:33 -0600
> David Ahern wrote:
>
>>> This will cause a non-trivial conflict with commit cc5c073a693f
>>> ("ipv6: Move exception bucket to fib6_nh") on net-next. I can submit
>>> an equivalent patch against net-next, if it helps.
>
On 6/6/19 10:10 AM, Xin Long wrote:
> On Thu, Jun 6, 2019 at 11:35 PM David Ahern wrote:
>>
>> On 6/2/19 5:10 AM, Xin Long wrote:
>>> In Jianlin's testing, netperf was broken with 'Connection reset by peer',
>>> as the cookie check failed in rt6_check() and ip6_dst_check() always
>>> returned NULL
On Fri, Jun 07, 2019 at 12:17:47AM +0200, Stefano Brivio wrote:
> On Thu, 6 Jun 2019 21:44:58 +
> Martin Lau wrote:
>
> > > + if (!(filter->flags & RTM_F_CLONED)) {
> > > + err = rt6_fill_node(net, arg->skb, rt, NULL, NULL, NULL, 0,
> > > + RTM_NEWROUTE,
>
On Thu, Jun 6, 2019 at 9:43 AM Lorenz Bauer wrote:
>
> Thanks for sending this RFC! For me, the biggest draw is that map-in-map
> would be so much nicer to use, plus automatic dumping of map values.
>
> Others on the thread have raised this point already: not everybody lives
> on the bleeding edge
Jonathan Lemon writes:
> On 6 Jun 2019, at 14:14, Toke Høiland-Jørgensen wrote:
>
>> Jonathan Lemon writes:
>>
>>> On 6 Jun 2019, at 12:24, Daniel Borkmann wrote:
>>>
On 06/06/2019 08:15 PM, Jonathan Lemon wrote:
> On 6 Jun 2019, at 9:15, Toke Høiland-Jørgensen wrote:
>> Alexei Star
The axienet driver requires the use of an axistream-connected attribute,
but this isn't documented in the devicetree bindings. Document how this
attribute is supposed to be used, including the upcoming change to make
the usage of this attribute optional.
Signed-off-by: Robert Hancock
---
.../dev
Failing initialization on a missing MAC address property is excessive.
We can just fall back to using a random MAC instead, which at least
leaves the interface in a functioning state.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 5 +++--
1 file changed, 3
On some platforms, such as iMX6 with PCIe devices, crashes or hangs can
occur if the axienet device continues to perform DMA transfers after
parent devices/busses have been shut down. Shut down the axienet
interface during its shutdown callback in order to avoid this.
Signed-off-by: Robert Hancock
Add support for setting the RX and TX ring sizes for this driver using
ethtool. Also increase the default RX ring size as the previous default
was far too low for good performance in some configurations.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/xilinx_axienet.h | 2 +
This driver was previously always calculating the MDIO clock divisor
(from AXI bus clock to MDIO bus clock) based on the CPU clock frequency,
assuming that it is the same as the AXI bus frequency, but that
simplistic method only works on the MicroBlaze platform.
Add support for specifying the cloc
These registers are important for troubleshooting the state of the DMA
cores.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
b/dri
The MDIO bus for this driver was being named using the result of
of_address_to_resource on a node which may not have any resource on it,
but the return value of that call was not checked so it was using some
random value in the bus name. Change to name the MDIO bus based on the
resource start of th
The mdio child node for the MDIO bus is generally required when using
this driver but was not documented other than being shown in the
example. Document it as an optional (but usually required) parameter.
Signed-off-by: Robert Hancock
---
Documentation/devicetree/bindings/net/xilinx_axienet.txt
Convert this driver to use the phylink API rather than the legacy PHY
API. This allows for better support for SFP modules connected using a
1000BaseX or SGMII interface.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/Kconfig | 2 +-
drivers/net/ethernet/xilinx/xili
The MDIO clock divisor register setting was only applied on the initial
startup when the driver was loaded. However, this setting is cleared
when the device is reset, such as would occur when the interface was
taken down and brought up again, and so the MDIO bus would be
non-functional afterwards.
Previously this driver only handled interrupts from the DMA RX and TX
blocks, not from the Ethernet core itself. Add optional support for
the Ethernet core interrupt, which is used to detect rx_missed and
framing errors signalled by the hardware. In order to use this
interrupt, a third interrupt ne
This driver was previously using the parent node of the specified PHY
node as the device node to register the MDIO bus on. Andrew Lunn
pointed out this is wrong as the PHY node is potentially not even
underneath the MDIO bus for the current device instance. Find the MDIO
node explicitly by looking
This driver should now build on (at least) X86 and ARM platforms, so add
them as supported platforms for the driver in Kconfig.
Signed-off-by: Robert Hancock
Reviewed-by: Andrew Lunn
---
drivers/net/ethernet/xilinx/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
Specify IRQF_SHARED to support shared interrupts. If the interrupt
handler is called and the device is not indicating an interrupt,
just return IRQ_NONE rather than spewing error messages.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 14 --
1
This driver was casting skb pointers to u32 and storing them as such in
the DMA buffer descriptor, which is obviously broken on 64-bit. The area
of the buffer descriptor being used is not accessed by the hardware and
has sufficient room for a 32 or 64-bit pointer, so just store the skb
pointer as s
The Xilinx DMA blocks each have their own reset register, but they both
reset the entire DMA engine, so only one of them needs to be reset.
Also, when stopping the device, we need to not just command the DMA
blocks to stop, but wait for them to stop, and trigger a device reset
to ensure that they
This driver was using in_be32 and out_be32 IO accessors which do not
exist on most platforms. Also, the use of big-endian accessors does not
seem correct as this hardware is accessed over an AXI bus which, to the
extent it has an endian-ness, is little-endian. Switch to standard
ioread32/iowrite32
Currently the axienet driver requires the use of a second devicetree
node, referenced by an axistream-connected attribute on the Ethernet
device node, which contains the resources for the AXI DMA block used by the
device. This setup is problematic for a use case we have where the Ethernet
and DMA c
It is possible that the interrupt handler fires and frees up space in
the TX ring in between checking for sufficient TX ring space and
stopping the TX queue in axienet_start_xmit. If this happens, the
queue wake from the interrupt handler will occur before the queue is
stopped, causing a lost wakeu
Since the MDIO is is brought up before the netdev is registered, it
should be torn down after the netdev is removed. Otherwise, PHY accesses
can potentially access freed MDIO bus references and cause a crash.
Signed-off-by: Robert Hancock
Reviewed-by: Andrew Lunn
---
drivers/net/ethernet/xilinx
This is a series of enhancements and bug fixes in order to get the mainline
version of this driver into a more generally usable state, including on
x86 or ARM platforms. It also converts the driver to use the phylink API
in order to provide support for SFP modules.
Changes since v4:
-Use reverse c
On 06/06, Andrii Nakryiko wrote:
> On Thu, Jun 6, 2019 at 12:03 PM Stanislav Fomichev wrote:
> >
> > Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and
> > BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks.
> >
> > BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments.
> > BPF_CGROU
Document the newly added option (skip-skb-check) on the etf man-page.
Signed-off-by: Vedang Patel
---
man/man8/tc-etf.8 | 10 ++
1 file changed, 10 insertions(+)
diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
index 30a12de7d2c7..2e01a591dbaa 100644
--- a/man/man8/tc-etf.8
+++ b/man/
> On Jun 6, 2019, at 2:46 PM, Stephen Hemminger
> wrote:
>
> On Thu, 6 Jun 2019 21:13:50 +
> "Patel, Vedang" wrote:
>
>>> On Jun 6, 2019, at 12:43 PM, Stephen Hemminger
>>> wrote:
>>>
>>> On Thu, 6 Jun 2019 10:52:18 -0700
>>> Vedang Patel wrote:
>>>
@@ -405,6 +420,7 @@ static
From: Vinicius Costa Gomes
This allows a new parameter, flags, to be passed to taprio. Currently, it
only supports enabling the txtime-assist mode. But, we plan to add
different modes for taprio (e.g. hardware offloading) and this parameter
will be useful in enabling those modes.
Signed-off-by:
This should only be updated after the kernel patches related to
txtime-offload have been merged into the kernel.
Signed-off-by: Vedang Patel
---
include/uapi/linux/pkt_sched.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
ETF Qdisc currently checks for a socket with SO_TXTIME socket option. If
either is not present, the packet is dropped. In the future commits, we
want other Qdiscs to add packet with launchtime to the ETF Qdisc. Also,
there are some packets (e.g. ICMP packets) which may not have a socket
associated
This adds support for setting the txtime_delay parameter which is useful
for the txtime offload mode of taprio.
Signed-off-by: Vedang Patel
---
tc/q_taprio.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/tc/q_taprio.c b/tc/q_taprio.c
index 930ecb9d1e
Add documentation for the latest options, flags and txtime-delay, to the
taprio manpage.
This also adds an example to run tc in txtime offload mode.
Signed-off-by: Vedang Patel
---
man/man8/tc-taprio.8 | 40
1 file changed, 40 insertions(+)
diff --git a
On Thu, 6 Jun 2019 21:44:58 +
Martin Lau wrote:
> > + if (!(filter->flags & RTM_F_CLONED)) {
> > + err = rt6_fill_node(net, arg->skb, rt, NULL, NULL, NULL, 0,
> > + RTM_NEWROUTE,
> > + NETLINK_CB(arg->cb->skb).portid,
> >
On Thu, Jun 6, 2019 at 1:17 PM Hechao Li wrote:
>
> Adding a new API libbpf_num_possible_cpus() that helps user with
> per-CPU map operations.
>
> Signed-off-by: Hechao Li
> ---
> tools/lib/bpf/libbpf.c | 57
> tools/lib/bpf/libbpf.h | 16 +++
On Thu, 6 Jun 2019 21:40:19 +, Bshara, Nafea wrote:
> On 6/6/19, 10:16 AM, "Jakub Kicinski" wrote:
>
> Hi Samih!
>
> Please don't top post on Linux kernel mailing lists.
>
> On Thu, 6 Jun 2019 10:23:40 +, Jubran, Samih wrote:
> > As of today there are no flags e
On 6/6/19 3:52 PM, David Miller wrote:
> From: David Ahern
> Date: Wed, 5 Jun 2019 16:15:05 -0700
>
>> +for (i = 0; i < nhg->num_nh; ++i) {
>
> Please "i++" here, it's more canonical.
>
I am stunned my fingers even typed that (++i instead of i++).
We can avoid another indirect call per packet wrapping the rx
handler call with the proper helper.
To ensure that even the last listed direct call experience
measurable gain, despite the additional conditionals we must
traverse before reaching it, I tested reversing the order of the
listed options
The mlx5_core driver uses several indirect calls in fast-path, some of them
are invoked on each ingress packet, even for the XDP-only traffic.
This series leverage the indirect call wrappers infrastructure the avoid
the expansive RETPOLINE overhead for 2 indirect calls in fast-path.
Each call is
Experimental results[1] has shown that resorting to several branches
and a direct-call is faster than indirect call via retpoline, even
when the number of added branches go up 5.
This change adds two additional helpers, to cope with indirect calls
with up to 4 available direct call option. We will
We can avoid an indirect call per packet wrapping the skb creation
with the appropriate helper.
Signed-off-by: Paolo Abeni
---
.../net/ethernet/mellanox/mlx5/core/en_rx.c | 22 ++-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5
On 6 Jun 2019, at 14:14, Toke Høiland-Jørgensen wrote:
> Jonathan Lemon writes:
>
>> On 6 Jun 2019, at 12:24, Daniel Borkmann wrote:
>>
>>> On 06/06/2019 08:15 PM, Jonathan Lemon wrote:
On 6 Jun 2019, at 9:15, Toke Høiland-Jørgensen wrote:
> Alexei Starovoitov writes:
>> On Thu,
From: David Ahern
Date: Wed, 5 Jun 2019 16:15:18 -0700
> + for (i = 0; i < newg->num_nh; ++i)
> + newg->nh_entries[i].nh_parent = old;
i++ please.
> + for (i = 0; i < oldg->num_nh; ++i)
> + oldg->nh_entries[i].nh_parent = new;
Likewise.
From: David Ahern
Date: Wed, 5 Jun 2019 16:15:05 -0700
> + for (i = 0; i < nhg->num_nh; ++i) {
Please "i++" here, it's more canonical.
On Thu, Jun 6, 2019 at 12:03 PM Stanislav Fomichev wrote:
>
> Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and
> BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks.
>
> BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments.
> BPF_CGROUP_GETSOCKOPT can modify the supplied buffer.
>
On 06/06/2019 10:51 PM, Andrey Ignatov wrote:
> Andrey Ignatov [Thu, 2019-06-06 13:45 -0700]:
>> Daniel Borkmann [Thu, 2019-06-06 07:36 -0700]:
>>> Please refer to the patch 1/4 as the main patch with the details
>>> on the current sendmsg hook API limitations and proposal to fix
>>> it in order
On Thu, 6 Jun 2019 21:13:50 +
"Patel, Vedang" wrote:
> > On Jun 6, 2019, at 12:43 PM, Stephen Hemminger
> > wrote:
> >
> > On Thu, 6 Jun 2019 10:52:18 -0700
> > Vedang Patel wrote:
> >
> >> @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu,
> >> FILE *f, struct rt
On Thu, Jun 06, 2019 at 10:13:41PM +0200, Stefano Brivio wrote:
> Since commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst
> cache"), route exceptions reside in a separate hash table, and won't be
> found by walking the FIB, so they won't be dumped to userspace on a
> RTM_GETROUTE mes
On Wed, 5 Jun 2019 00:30:16 +0200
Davide Caratti wrote:
> the following TDC test case:
>
> b776 - Replace simple action with invalid goto chain control
>
> checks if the kernel correctly validates the 'goto chain' control action,
> when it is specified in 'act_simple' rules. The test systemat
On Thu, 6 Jun 2019 17:32:09 -0400
Roman Mashak wrote:
> The following operation fails:
> % sudo tc actions add action pipe index 1
> % sudo tc filter add dev lo parent : \
>protocol ip pref 10 u32 match ip src 127.0.0.2 \
>flowid 1:10 action gact index 1
>
> Bad action type
On Thu, 6 Jun 2019 17:32:09 -0400
Roman Mashak wrote:
> The following operation fails:
> % sudo tc actions add action pipe index 1
> % sudo tc filter add dev lo parent : \
>protocol ip pref 10 u32 match ip src 127.0.0.2 \
>flowid 1:10 action gact index 1
>
> Bad action type
1 - 100 of 287 matches
Mail list logo
