Re: [PATCH v2] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device

On 5/17/2019 20:17, wenxu wrote: > > 在 2019/5/18 6:11, Mark Bloch 写道: >> >> On 5/17/19 2:17 AM, we...@ucloud.cn wrote: >>> From: wenxu >>> >>> The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0. >>> packet received from mlx_p0 or mlx_p1 and in the ingress tc flower >>> forward

patch for iproute2

Hello iproute2 maintainer. (Sorry, I don't know your name) I recently noticed a discrepancy: the internal documentation for the ip command says that an *RTT* value can be sufficed with "s" (second) or "ms" (millisecond), but in practice no suffix of any kind is accepted. I found that that comm

[PATCH v2] net: Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics.

Author: Felipe Gasper Date: Fri May 17 16:54:40 2019 -0500 net: Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics. This adds the ability for Netlink to report a socket’s UID along with the other UNIX diagnostic information that is already available. This will allow diagnostic to

Re: [PATCH v2] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device

在 2019/5/18 6:11, Mark Bloch 写道: > > On 5/17/19 2:17 AM, we...@ucloud.cn wrote: >> From: wenxu >> >> The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0. >> packet received from mlx_p0 or mlx_p1 and in the ingress tc flower >> forward to vf0. The tc rule can't be offloaded becaus

Re: [PATCH] net/mlx5e: restrict the real_dev of vlan device is the same as uplink device

There will be multiple vlan device which maybe not belong to the uplink rep device, so wen can limit it 在 2019/5/18 4:30, Saeed Mahameed 写道: > On Wed, 2019-05-15 at 17:25 +0800, we...@ucloud.cn wrote: >> From: wenxu >> >> When register indr block for vlan device, it should check the >> real_dev

Re: [PATCH 0/3] resolve module name conflict for asix PHY and USB modules

Thanks Andrew, makes perfect sense - patch resent. Cheers, Michael Am 18.05.2019 um 09:20 schrieb Andrew Lunn: On Sat, May 18, 2019 at 08:25:15AM +1200, Michael Schmitz wrote: Haven't heard back in a while, so here goes: Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY

[PATCH v2] net: phy: rename Asix Electronics PHY driver

Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") introduced a new PHY driver drivers/net/phy/asix.c that causes a module name conflict with a pre-existiting driver (drivers/net/usb/asix.c). The PHY driver is used by the X-Surf 100 ethernet card driver, and loaded by that driv

[PATCH 4/5] samples/bpf: fix tracex5_user build error

Add missing symbols to tools/include/linux/filter.h to fix a build failure: make -C samples/bpf/../../tools/lib/bpf/ RM='rm -rf' LDFLAGS= srctree=samples/bpf/../../ O= HOSTCC samples/bpf/tracex5_user.o samples/bpf/tracex5_user.c: In function ‘install_accept_all_seccomp’: samples/bpf/tracex5_us

[PATCH 5/5] samples/bpf: fix hbm build error

Fix the following build error by declaring bpf_spin_lock in hbm.c. Including the UAPI header generates tons of redefined symbol errors, and including it in hbm.h breaks hbm_out_kern.c. make -C samples/bpf/../../tools/lib/bpf/ RM='rm -rf' LDFLAGS= srctree=samples/bpf/../../ O= HOSTCC samples/bp

[PATCH 3/5] samples/bpf: fix xdpsock_user build error

Remove duplicate typedef, and use PRIu64 to be both 32 and 64 bit aware. Fix the following error: samples/bpf/xdpsock_user.c:52:15: error: conflicting types for ‘u64’ 52 | typedef __u64 u64; | ^~~ In file included from ./tools/include/linux/compiler.h:87, fr

[PATCH 1/5] samples/bpf: fix test_lru_dist build

Fix the following error by removing a duplicate struct definition: samples/bpf/test_lru_dist.c:39:8: error: redefinition of ‘struct list_head’ 39 | struct list_head { |^ In file included from samples/bpf/test_lru_dist.c:9: ./tools/include/linux/types.h:69:8: note: original

[PATCH 2/5] libbpf: add missing typedef

Sync tools/include/linux/types.h with the UAPI one to fix this build error: make -C samples/bpf/../../tools/lib/bpf/ RM='rm -rf' LDFLAGS= srctree=samples/bpf/../../ O= HOSTCC samples/bpf/sock_example In file included from samples/bpf/sock_example.c:27: /usr/include/linux/ip.h:102:2: error: unk

[PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver

Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special BroadRReach 100BaseT1 PHYs used in automotive. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Guenter Roeck Cc: Heiner Kallweit Cc: Jean Delvare Cc: linux-hw...@vger.kernel.org --- V2: - Use phy_modi

Re: pull-request: bpf 2019-05-18

From: Daniel Borkmann Date: Sat, 18 May 2019 01:14:00 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix bpftool's raw BTF dump in relation to forward declarations of union/ >structs, and another fix to unexport logging helpers,

pull-request: bpf 2019-05-18

Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix bpftool's raw BTF dump in relation to forward declarations of union/ structs, and another fix to unexport logging helpers, from Andrii. 2) Fix inode permission check for retrieving bpf

[PATCH 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

There are certain cases, notably when transitioning between sleep and active state, when Broadcom SDIO WiFi cards will produce errors on the SDIO bus. This is evident from the source code where you can see that we try commands in a loop until we either get success or we've tried too many times. T

[PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354

In commit 29f6589140a1 ("brcmfmac: disable command decode in sdio_aos") we disabled something called "command decode in sdio_aos" for a whole bunch of Broadcom SDIO WiFi parts. After that patch landed I find that my kernel log on rk3288-veyron-minnie and rk3288-veyron-speedy is filled with: brcm

[PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep

This series attempts to deal better with the expected transmission errors that we get when waking up the SDIO-based WiFi on rk3288-veyron-minnie, rk3288-veyron-speedy, and rk3288-veyron-mickey. Some details about those errors can be found in , but to summarize it here: if

RE: [Intel-wired-lan] [PATCH][next] i40e: mark expected switch fall-through

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Gustavo A. R. Silva > Sent: Wednesday, May 1, 2019 1:56 PM > To: Kirsher, Jeffrey T ; David S. Miller > > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vg

Re: [Intel-wired-lan] i40e X722 RSS problem with NAT-Traversal IPsec packets

On Fri, May 17, 2019 at 10:23 AM Lennart Sorensen wrote: > OK I applied that and see this: > > i40e: Intel(R) Ethernet Connection XL710 Network Driver - version 2.1.7-k > i40e: Copyright (c) 2013 - 2014 Intel Corporation. > i40e :3d:00.0: fw 3.10.52896 api 1.6 nvm 4.00 0x80001577 1.1767.0 > i4

Re: [pull request][net 00/11] Mellanox, mlx5 fixes 2019-05-17

From: Saeed Mahameed Date: Fri, 17 May 2019 20:19:29 + > This series introduces some fixes to mlx5 driver. > For more information please see tag log below. > > Please pull and let me know if there is any problem. Pulled. > For -stable v4.19 > net/mlx5e: Fix ethtool rxfh commands when CON

Re: [PATCH v2] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device

On 5/17/19 2:17 AM, we...@ucloud.cn wrote: > From: wenxu > > The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0. > packet received from mlx_p0 or mlx_p1 and in the ingress tc flower > forward to vf0. The tc rule can't be offloaded because there is > no indr_register_block for t

Re: [PATCH bpf] bpf: Check sk_fullsock() before returning from bpf_sk_lookup()

On Fri, May 17, 2019 at 02:51:48PM -0700, Eric Dumazet wrote: > > > On 5/17/19 2:21 PM, Martin KaFai Lau wrote: > > The BPF_FUNC_sk_lookup_xxx helpers return RET_PTR_TO_SOCKET_OR_NULL. > > Meaning a fullsock ptr and its fullsock's fields in bpf_sock can be > > accessed, e.g. type, protocol, mark

Re: [PATCH net-next RFC] ipv6: elide flowlabel check if no exclusive leases exist

On Fri, May 17, 2019 at 4:32 PM Eric Dumazet wrote: > > > > On 5/17/19 8:56 AM, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Processes can request ipv6 flowlabels with cmsg IPV6_FLOWINFO. > > If not set, by default an autogenerated flowlabel is selected. > > > > Explicit flowlabels

Re: [PATCH bpf] bpf: Check sk_fullsock() before returning from bpf_sk_lookup()

On 5/17/19 2:21 PM, Martin KaFai Lau wrote: > The BPF_FUNC_sk_lookup_xxx helpers return RET_PTR_TO_SOCKET_OR_NULL. > Meaning a fullsock ptr and its fullsock's fields in bpf_sock can be > accessed, e.g. type, protocol, mark and priority. > Some new helper, like bpf_sk_storage_get(), also expects

Re: [PATCH bpf-next 0/2] Move bpf_printk to bpf_helpers.h

On Thu, May 16, 2019 at 11:43:03AM -0700, Alexei Starovoitov wrote: > On Thu, May 16, 2019 at 4:21 AM Michal Rostecki > wrote: > > > > This series of patches move the commonly used bpf_printk macro to > > bpf_helpers.h which is already included in all BPF programs which > > defined that macro on

[PATCH bpf] bpf: Check sk_fullsock() before returning from bpf_sk_lookup()

The BPF_FUNC_sk_lookup_xxx helpers return RET_PTR_TO_SOCKET_OR_NULL. Meaning a fullsock ptr and its fullsock's fields in bpf_sock can be accessed, e.g. type, protocol, mark and priority. Some new helper, like bpf_sk_storage_get(), also expects ARG_PTR_TO_SOCKET is a fullsock. bpf_sk_lookup() curre

Re: [PATCH 0/3] resolve module name conflict for asix PHY and USB modules

On Sat, May 18, 2019 at 08:25:15AM +1200, Michael Schmitz wrote: > Haven't heard back in a while, so here goes: > > Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") > introduced a new PHY driver drivers/net/phy/asix.c that causes a module > name conflict with a pre-existitin

[PATCH 0/1] Fix for VM_FLUSH_RESET_PERMS on sparc

Meelis Roos reported issues with the new VM_FLUSH_RESET_PERMS flag on the sparc architecture. When freeing many BPF JITs simultaneously, the vfree flush operations can become stuck waiting as they each try to vm_unmap_aliases(). It also came up that using this flag is not needed for architectures

[PATCH 1/1] vmalloc: Fix issues with flush flag

Meelis Roos reported issues with the new VM_FLUSH_RESET_PERMS flag on the sparc architecture. When freeing many BPF JITs at once the free operations can become stuck waiting for locks as they each try to vm_unmap_aliases(). Calls to this function happen frequently on some archs, but in vmalloc its

Re: [PATCH v2] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device

On Fri, 2019-05-17 at 17:17 +0800, we...@ucloud.cn wrote: > From: wenxu > > The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0. > packet received from mlx_p0 or mlx_p1 and in the ingress tc flower > forward to vf0. The tc rule can't be offloaded because there is > no indr_registe

Re: [PATCH net-next RFC] ipv6: elide flowlabel check if no exclusive leases exist

On 5/17/19 8:56 AM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Processes can request ipv6 flowlabels with cmsg IPV6_FLOWINFO. > If not set, by default an autogenerated flowlabel is selected. > > Explicit flowlabels require a control operation per label plus a > datapath check on eve

Re: [PATCH] net/mlx5e: restrict the real_dev of vlan device is the same as uplink device

On Wed, 2019-05-15 at 17:25 +0800, we...@ucloud.cn wrote: > From: wenxu > > When register indr block for vlan device, it should check the > real_dev > of vlan device is same as uplink device. Or it will set offload rule > to mlx5e which will never hit. > I would improve the commit message, it i

Re: 5.1 `ip route get addr/cidr` regression

On Fri, May 17, 2019 at 10:19 PM Jason A. Donenfeld wrote: > > On Fri, May 17, 2019 at 7:39 PM David Ahern wrote: > > Not sure why Jason is not seeing that. Really odd that he hits the error > > AND does not get a message back since it requires an updated ip command > > to set the strict checking

[PATCH 0/3] resolve module name conflict for asix PHY and USB modules

Haven't heard back in a while, so here goes: Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") introduced a new PHY driver drivers/net/phy/asix.c that causes a module name conflict with a pre-existiting driver (drivers/net/usb/asix.c). The PHY driver is used by the X-Surf 1

[PATCH 2/3] net: 8390: switch X-Surf 100 driver to use ax88796b PHY

The asix.c driver name causes a module name conflict with a driver of the same name in drivers/net/usb. Select the new ax88796b PHY driver when X-SURF 100 support is configured. Signed-off-by: Michael Schmitz Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") --- drivers/net/

[PATCH 3/3] net: phy: remove old Asix Electronics PHY driver

The asix.c driver name causes a module name conflict with a driver of the same name in drivers/net/usb. Now that a new ax88796b.c driver has been added, remove drivers/net/phy/asix.c. Signed-off-by: Michael Schmitz Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") --- driver

[PATCH 1/3] net: phy: new ax88796b.c Asix Electronics PHY driver

The asix.c driver name causes a module name conflict with a driver of the same name in drivers/net/usb. Add new ax88796b.c driver to prepare for removal of drivers/net/phy/asix.c later. Signed-off-by: Michael Schmitz Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") --- driv

[net 06/11] net/mlx5e: Fix ethtool rxfh commands when CONFIG_MLX5_EN_RXNFC is disabled

ethtool user spaces needs to know ring count via ETHTOOL_GRXRINGS when executing (ethtool -x) which is retrieved via ethtool get_rxnfc callback, in mlx5 this callback is disabled when CONFIG_MLX5_EN_RXNFC=n. This patch allows only ETHTOOL_GRXRINGS command on mlx5e_get_rxnfc() when CONFIG_MLX5_EN_R

[net 07/11] net/mlx5e: Fix number of vports for ingress ACL configuration

From: Eli Britstein With the cited commit, ACLs are configured for the VF ports. The loop for the number of ports had the wrong number. Fix it. Fixes: 184867373d8c ("net/mlx5e: ACLs for priority tag mode") Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed ---

[net 08/11] net/mlx5e: Add missing ethtool driver info for representors

From: Dmytro Linkin For all representors added firmware version info to show in ethtool driver info. For uplink representor, because only it is tied to the pci device sysfs, added pci bus info. Fixes: ff9b85de5d5d ("net/mlx5e: Add some ethtool port control entries to the uplink rep netdev") Sig

[net 09/11] net/mlx5e: Additional check for flow destination comparison

From: Dmytro Linkin Flow destination comparison has an inaccuracy: code see no difference between same vf ports, which belong to different pfs. Example: If start ping from VF0 (PF1) to VF1 (PF1) and mirror all traffic to VF0 (PF2), icmp reply to VF0 (PF1) and mirrored flow to VF0 (PF2) would be

[net 02/11] net/mlx5: Add meaningful return codes to status_to_err function

From: Valentine Fatiev Current version of function status_to_err return -1 for any status returned by mlx5_cmd_invoke function. In case status is MLX5_DRIVER_STATUS_ABORTED we should return 0 to the caller as we assume command completed successfully on FW. If error returned we are getting confusi

[net 01/11] net/mlx5: Imply MLXFW in mlx5_core

mlxfw can be compiled as external module while mlx5_core can be builtin, in such case mlx5 will act like mlxfw is disabled. Since mlxfw is just a service library for mlx* drivers, imply it in mlx5_core to make it always reachable if it was enabled. Fixes: 3ffaabecd1a1 ("net/mlx5e: Support the fla

[pull request][net 00/11] Mellanox, mlx5 fixes 2019-05-17

Hi Dave, This series introduces some fixes to mlx5 driver. For more information please see tag log below. Please pull and let me know if there is any problem. For -stable v4.19 net/mlx5e: Fix ethtool rxfh commands when CONFIG_MLX5_EN_RXNFC is disabled net/mlx5: Imply MLXFW in mlx5_core For

[net 10/11] net/mlx5e: Fix no rewrite fields with the same match

From: Eli Britstein With commit 27c11b6b844c ("net/mlx5e: Do not rewrite fields with the same match") there are no rewrites if the rewrite value is the same as the matched value. However, if the field is not matched, the rewrite is also wrongly skipped. Fix it. Fixes: 27c11b6b844c ("net/mlx5e: D

[net 05/11] net/mlx5e: Fix wrong xmit_more application

From: Tariq Toukan Cited patch refactored the xmit_more indication while not preserving its functionality. Fix it. Fixes: 3c31ff22b25f ("drivers: mellanox: use netdev_xmit_more() helper") Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_

[net 04/11] net/mlx5: Fix peer pf disable hca command

From: Bodong Wang The command was mistakenly using enable_hca in embedded CPU field. Fixes: 22e939a91dcb (net/mlx5: Update enable HCA dependency) Signed-off-by: Bodong Wang Reported-by: Alex Rosenbaum Signed-off-by: Alex Rosenbaum Reviewed-by: Daniel Jurgens Signed-off-by: Saeed Mahameed --

[net 11/11] net/mlx5e: Fix possible modify header actions memory leak

From: Eli Britstein The cited commit could disable the modify header flag, but did not free the allocated memory for the modify header actions. Fix it. Fixes: 27c11b6b844cd ("net/mlx5e: Do not rewrite fields with the same match") Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan Signed-off-b

[net 03/11] net/mlx5: E-Switch, Correct type to u16 for vport_num and int for vport_index

From: Parav Pandit To avoid any ambiguity between vport index and vport number, rename functions that had vport, to vport_num or vport_index appropriately. vport_num is u16 hence change mlx5_eswitch_index_to_vport_num() return type to u16. vport_index is an int in vport array. Hence change inpu

Re: 5.1 `ip route get addr/cidr` regression

On Fri, May 17, 2019 at 7:39 PM David Ahern wrote: > Not sure why Jason is not seeing that. Really odd that he hits the error > AND does not get a message back since it requires an updated ip command > to set the strict checking flag and that command understands extack. > Perhaps no libmnl? Right

Re: ARCNET Contemporary Controls PCI20EX PCIe Card

On Fri, May 17, 2019 at 07:03:19PM +, Kenton, Stephen M. wrote: > I've got some old optical (as in eyeglasses) equipment that only talks > over ARCNET that I want to get up and running. The PEX PCIe-to-PCI > bridge is on the card with the SMC COM20022 and lspci sees them > > 02:00.0 PCI brid

ARCNET Contemporary Controls PCI20EX PCIe Card

I've got some old optical (as in eyeglasses) equipment that only talks over ARCNET that I want to get up and running. The PEX PCIe-to-PCI bridge is on the card with the SMC COM20022 and lspci sees them 02:00.0 PCI bridge [0604]: PLX Technology, Inc. PEX 8111 PCI Express-to-PCI Bridge [10b5:8111]

ethtool 5.1 released

ethtool version 5.1 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-5.1.tar.xz Release notes: * Feature: Add support for 200Gbps (50Gbps per lane) link mode * Feature: si

Re: [PATCH] lib: Correct comment of prandom_seed

From: Philippe Mazenauer Date: Fri, 17 May 2019 10:44:44 + > Variable 'entropy' was wrongly documented as 'seed', changed comment to > reflect actual variable name. > > ../lib/random32.c:179: warning: Function parameter or member 'entropy' not > described in 'prandom_seed' > ../lib/random32

KASAN: use-after-free Read in tls_push_sg

Hello, syzbot found the following crash on: HEAD commit:35c99ffa Merge tag 'for_linus' of git://git.kernel.org/pub.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=10ff3322a0 kernel config: https://syzkaller.appspot.com/x/.config?x=82f0809e8f0a8c87 da

Re: [PATCH] net: caif: fix the value of size argument of snprintf

From: Weikang shi Date: Fri, 17 May 2019 15:59:22 +0800 > From: swkhack > > Because the function snprintf write at most size bytes(including the > null byte).So the value of the argument size need not to minus one. > > Signed-off-by: swkhack Applied.

Re: dsa: using multi-gbps speeds on CPU port

On Fri, May 17, 2019 at 11:10:10AM -0700, Florian Fainelli wrote: > On 5/17/19 11:03 AM, Russell King - ARM Linux admin wrote: > > On Fri, May 17, 2019 at 05:37:00PM +, Ioana Ciornei wrote: > >>> Subject: Re: dsa: using multi-gbps speeds on CPU port > >>> > >>> Hi everyone, > >>> > >>> On Wed,

Re: [RFC bpf-next 0/7] busy poll support for AF_XDP sockets

On Thu, 16 May 2019 14:37:51 +0200, Magnus Karlsson wrote: > Applications > method cores irqstxpushrxdrop l2fwd > --- > r-t-c 2 y 35.9 11.28.6

Re: dsa: using multi-gbps speeds on CPU port

On 5/17/19 11:03 AM, Russell King - ARM Linux admin wrote: > On Fri, May 17, 2019 at 05:37:00PM +, Ioana Ciornei wrote: >>> Subject: Re: dsa: using multi-gbps speeds on CPU port >>> >>> Hi everyone, >>> >>> On Wed, 15 May 2019 09:09:26 -0700 >>> Florian Fainelli wrote: >>> On 5/15/19 7:02

Re: [Intel-wired-lan] [PATCH] igb: add parameter to ignore nvm checksum validation

On Fri, May 17, 2019 at 09:58:46AM -0700, Alexander Duyck wrote: > > I don't think you can say because the checksum is valid that all data > > contained > > inside is also valid. You can have a valid checksum , and someone screwed > > up the > > data prior to the checksum getting computed. > > I

Re: [PATCH iproute2] ip route: Set rtm_dst_len to 32 for all ip route get requests

On Fri, 17 May 2019 10:59:13 -0700 David Ahern wrote: > From: David Ahern > > Jason reported that ip route get with a prefix length is now > failing: > $ 192.168.50.0/24 > RTNETLINK answers: Invalid argument > > iproute2 now uses strict mode and strict mode in the kernel > requires rtm

[PATCH] Fix MACsec kernel panics, oopses and bugs

MACsec causes oopses followed by a kernel panic when attached directly or indirectly to a bridge. It causes erroneous checksum messages when attached to vxlan. When I did investigate I did find skb leaks, apparent skb mis-handling and superfluous code. The attached patch fixes all MACsec misbehav

Re: dsa: using multi-gbps speeds on CPU port

On Fri, May 17, 2019 at 05:37:00PM +, Ioana Ciornei wrote: > > Subject: Re: dsa: using multi-gbps speeds on CPU port > > > > Hi everyone, > > > > On Wed, 15 May 2019 09:09:26 -0700 > > Florian Fainelli wrote: > > > > >On 5/15/19 7:02 AM, Maxime Chevallier wrote: > > >> Hi Andrew, > > >> > >

[PATCH iproute2] ip route: Set rtm_dst_len to 32 for all ip route get requests

From: David Ahern Jason reported that ip route get with a prefix length is now failing: $ 192.168.50.0/24 RTNETLINK answers: Invalid argument iproute2 now uses strict mode and strict mode in the kernel requires rtm_dst_len to be 32. Non-strict mode ignores the prefix length, so this allo

Re: [iproute2 2/3] tc: jsonify tbf qdisc parameters

On Fri, 17 May 2019 11:35:16 -0600 David Ahern wrote: > On 5/6/19 10:18 AM, Nir Weiner wrote: > > > if (prate64) { > > - fprintf(f, "peakrate %s ", sprint_rate(prate64, b1)); > > + print_string(PRINT_ANY, "peakrate", "peakrate %s ", > > sprint_rate(prate64, b1)); > >

Re: 5.1 `ip route get addr/cidr` regression

On 5/17/19 11:35 AM, Stephen Hemminger wrote: > On Fri, 17 May 2019 09:17:51 -0600 > David Ahern wrote: > >> On 5/17/19 4:22 AM, Jason A. Donenfeld wrote: >>> Hi, >>> >>> I'm back now and catching up with a lot of things. A few people have >>> mentioned to me that wg-quick(8), a bash script that

Re: 5.1 `ip route get addr/cidr` regression

On 5/17/19 11:35 AM, Stephen Hemminger wrote: > On Fri, 17 May 2019 09:17:51 -0600 > David Ahern wrote: > >> On 5/17/19 4:22 AM, Jason A. Donenfeld wrote: >>> Hi, >>> >>> I'm back now and catching up with a lot of things. A few people have >>> mentioned to me that wg-quick(8), a bash script that

RE: dsa: using multi-gbps speeds on CPU port

> Subject: Re: dsa: using multi-gbps speeds on CPU port > > Hi everyone, > > On Wed, 15 May 2019 09:09:26 -0700 > Florian Fainelli wrote: > > >On 5/15/19 7:02 AM, Maxime Chevallier wrote: > >> Hi Andrew, > >> > >> On Wed, 15 May 2019 15:27:01 +0200 > >> Andrew Lunn wrote: > >> > >>> I think yo

Re: 5.1 `ip route get addr/cidr` regression

On Fri, 17 May 2019 09:17:51 -0600 David Ahern wrote: > On 5/17/19 4:22 AM, Jason A. Donenfeld wrote: > > Hi, > > > > I'm back now and catching up with a lot of things. A few people have > > mentioned to me that wg-quick(8), a bash script that makes a bunch of > > iproute2 invocations, appears t

Re: [iproute2 2/3] tc: jsonify tbf qdisc parameters

On 5/6/19 10:18 AM, Nir Weiner wrote: > if (prate64) { > - fprintf(f, "peakrate %s ", sprint_rate(prate64, b1)); > + print_string(PRINT_ANY, "peakrate", "peakrate %s ", > sprint_rate(prate64, b1)); > if (qopt->mtu || qopt->peakrate.mpu) { >

Re: [Intel-wired-lan] i40e X722 RSS problem with NAT-Traversal IPsec packets

On Fri, May 17, 2019 at 09:42:19AM -0700, Alexander Duyck wrote: > So the patch below/attached should resolve the issues you are seeing > with your system in terms of UDPv4 RSS. What you should see with this > patch is the first function to come up will display some "update input > mask" messages,

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

On 17/05/2019 16:27, Edward Cree wrote: > I'm now leaning towards the > approach of adding "unsigned long cookie" to struct flow_action_entry > and populating it with (unsigned long)act in tc_setup_flow_action(). For concreteness, here's what that looks like: patch 1 is replaced with the follow

Re: [Intel-wired-lan] [PATCH] igb: add parameter to ignore nvm checksum validation

On Fri, May 17, 2019 at 9:36 AM Daniel Walker wrote: > > On Fri, May 17, 2019 at 08:16:34AM -0700, Alexander Duyck wrote: > > On Thu, May 16, 2019 at 6:48 PM Florian Fainelli > > wrote: > > > > > > > > > > > > On 5/16/2019 6:03 PM, Daniel Walker wrote: > > > > On Thu, May 16, 2019 at 03:02:18PM

Re: [Intel-wired-lan] [PATCH] igb: add parameter to ignore nvm checksum validation

On 5/17/19 9:36 AM, Daniel Walker wrote: > On Fri, May 17, 2019 at 08:16:34AM -0700, Alexander Duyck wrote: >> On Thu, May 16, 2019 at 6:48 PM Florian Fainelli >> wrote: >>> >>> >>> >>> On 5/16/2019 6:03 PM, Daniel Walker wrote: On Thu, May 16, 2019 at 03:02:18PM -0700, Florian Fainelli wrot

Re: [Intel-wired-lan] i40e X722 RSS problem with NAT-Traversal IPsec packets

On Thu, May 16, 2019 at 4:32 PM Alexander Duyck wrote: > > On Thu, May 16, 2019 at 11:37 AM Lennart Sorensen > wrote: > > > > On Thu, May 16, 2019 at 02:34:08PM -0400, Lennart Sorensen wrote: > > > Here is what I see: > > > > > > i40e: Intel(R) Ethernet Connection XL710 Network Driver - version 2

Re: [Intel-wired-lan] [PATCH] igb: add parameter to ignore nvm checksum validation

On Fri, May 17, 2019 at 08:16:34AM -0700, Alexander Duyck wrote: > On Thu, May 16, 2019 at 6:48 PM Florian Fainelli wrote: > > > > > > > > On 5/16/2019 6:03 PM, Daniel Walker wrote: > > > On Thu, May 16, 2019 at 03:02:18PM -0700, Florian Fainelli wrote: > > >> On 5/16/19 12:55 PM, Nikunj Kela (nke

[PATCH net-next RFC] ipv6: elide flowlabel check if no exclusive leases exist

From: Willem de Bruijn Processes can request ipv6 flowlabels with cmsg IPV6_FLOWINFO. If not set, by default an autogenerated flowlabel is selected. Explicit flowlabels require a control operation per label plus a datapath check on every connection (every datagram if unconnected). This is parti

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

On 15/05/2019 20:39, Edward Cree wrote: > A point for discussion: would it be better if, instead of the tcfa_index > (for which the driver has to know the rules about which flow_action > types share a namespace), we had some kind of globally unique cookie? > In the same way that rule->cookie is

Re: 5.1 `ip route get addr/cidr` regression

On Fri, May 17, 2019 at 5:21 PM David Ahern wrote: > > On 5/17/19 8:17 AM, Michal Kubecek wrote: > > AFAIK the purpose of 'ip route get' always was to let the user check > > the result of a route lookup, i.e. "what route would be used if I sent > > a packet to an address". To be honest I would hav

Re: 5.1 `ip route get addr/cidr` regression

On 5/17/19 8:17 AM, Michal Kubecek wrote: > AFAIK the purpose of 'ip route get' always was to let the user check > the result of a route lookup, i.e. "what route would be used if I sent > a packet to an address". To be honest I would have to check how exactly > was "ip route get /" implemented befo

Re: 5.1 `ip route get addr/cidr` regression

On 5/17/19 4:22 AM, Jason A. Donenfeld wrote: > Hi, > > I'm back now and catching up with a lot of things. A few people have > mentioned to me that wg-quick(8), a bash script that makes a bunch of > iproute2 invocations, appears to be broken on 5.1. I've distilled the > behavior change down to the

Re: [Intel-wired-lan] [PATCH] igb: add parameter to ignore nvm checksum validation

On Thu, May 16, 2019 at 6:48 PM Florian Fainelli wrote: > > > > On 5/16/2019 6:03 PM, Daniel Walker wrote: > > On Thu, May 16, 2019 at 03:02:18PM -0700, Florian Fainelli wrote: > >> On 5/16/19 12:55 PM, Nikunj Kela (nkela) wrote: > >>> > >>> > >>> On 5/16/19, 12:35 PM, "Jeff Kirsher" wrote: > >>>

[PATCH] net: Treat sock->sk_drops as an unsigned int when printing

Currently, procfs socket stats format sk_drops as a signed int (%d). For large values this will cause a negative number to be printed. We know the drop count can never be a negative so change the format specifier to %u. Signed-off-by: Patrick Talbert --- net/ipv4/ping.c | 2 +- net/ipv

Re: dsa: using multi-gbps speeds on CPU port

Hi everyone, On Wed, 15 May 2019 09:09:26 -0700 Florian Fainelli wrote: >On 5/15/19 7:02 AM, Maxime Chevallier wrote: >> Hi Andrew, >> >> On Wed, 15 May 2019 15:27:01 +0200 >> Andrew Lunn wrote: >> >>> I think you are getting your terminology wrong. 'master' is eth0 in >>> the example you g

Re: [PATCH] Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics.

> On May 17, 2019, at 12:59 AM, Andy Lutomirski wrote: > >> On May 16, 2019, at 8:25 PM, Felipe wrote: >> >> Author: Felipe Gasper >> Date: Thu May 16 12:16:53 2019 -0500 >> >> Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics. >> >> This adds the ability for Netlink to report a s

Re: [PATCH iproute2-next] treewide: refactor help messages

On Fri, 17 May 2019 15:38:28 +0200 Matteo Croce wrote: > Every tool in the iproute2 package have one or more function to show > an help message to the user. Some of these functions print the help > line by line with a series of printf call, e.g. ip/xfrm_state.c does > 60 fprintf calls. > If we gr

Re: [PATCH] net: sysctl: cleanup net_sysctl_init error exit paths

Hello David, On Thu, May 16, 2019 at 02:27:44PM -0700, David Miller wrote: > From: "George G. Davis" > Date: Thu, 16 May 2019 11:23:08 -0400 > > > Unwind net_sysctl_init error exit goto spaghetti code > > > > Suggested-by: Joshua Frkuska > > Signed-off-by: George G. Davis > > Cleanups are no

[PATCH v2] ipvs: Fix use-after-free in ip_vs_in

BUG: KASAN: use-after-free in ip_vs_in.part.29+0xe8/0xd20 [ip_vs] Read of size 4 at addr 8881e9b26e2c by task sshd/5603 CPU: 0 PID: 5603 Comm: sshd Not tainted 4.19.39+ #30 Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011 Call Trace: dump_stack+0x71/0xab print_address_description+0x6a/0x270

Re: 5.1 `ip route get addr/cidr` regression

On Fri, May 17, 2019 at 12:22:41PM +0200, Jason A. Donenfeld wrote: > Hi, > > I'm back now and catching up with a lot of things. A few people have > mentioned to me that wg-quick(8), a bash script that makes a bunch of > iproute2 invocations, appears to be broken on 5.1. I've distilled the > behav

Re: RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

On Thu, 16 May 2019 at 21:33, Alexei Starovoitov wrote: > > On Thu, May 16, 2019 at 09:41:34AM +0100, Lorenz Bauer wrote: > > On Wed, 15 May 2019 at 18:16, Joe Stringer wrote: > > > > > > On Wed, May 15, 2019 at 8:11 AM Lorenz Bauer wrote: > > > > > > > > In the BPF-based TPROXY session with Joe

[PATCH iproute2-next] treewide: refactor help messages

Every tool in the iproute2 package have one or more function to show an help message to the user. Some of these functions print the help line by line with a series of printf call, e.g. ip/xfrm_state.c does 60 fprintf calls. If we group all the calls to a single one and just concatenate strings, we

Re: [PATCH] ARM: dts: Introduce the NXP LS1021A-TSN board

On Fri, May 17, 2019 at 03:05:59PM +0300, Vladimir Oltean wrote: > Hi Shawn, > > Thanks for the feedback! > Do you want a v2 now (will you merge it for 5.2) or should I send it > after the merge window closes? It's a 5.3 material. Shawn > The "nxp,sja1105t" compatible is not undocumented but be

Re: Kernel UDP behavior with missing destinations

On Fri, May 17, 2019 at 8:57 AM David Laight wrote: > > From: Willem de Bruijn > > Sent: 17 May 2019 04:23 > > On Thu, May 16, 2019 at 8:27 PM Adam Urban wrote: > > > > > > And replying to your earlier comment about TTL, yes I think a TTL on > > > arp_queues would be hugely helpful. > > > > > > I

RE: Kernel UDP behavior with missing destinations

From: Willem de Bruijn > Sent: 17 May 2019 04:23 > On Thu, May 16, 2019 at 8:27 PM Adam Urban wrote: > > > > And replying to your earlier comment about TTL, yes I think a TTL on > > arp_queues would be hugely helpful. > > > > In any environment where you are streaming time-sensitive UDP traffic, >

Re: [PATCH bpf] selftests/bpf: fix bpf_get_current_task

On 05/17/2019 06:34 AM, Alexei Starovoitov wrote: > Fix bpf_get_current_task() declaration. > > Signed-off-by: Alexei Starovoitov Applied, thanks!

Re: [PATCH bpf] bpftool: fix BTF raw dump of FWD's fwd_kind

On 05/17/2019 08:21 AM, Andrii Nakryiko wrote: > kflag bit determines whether FWD is for struct or union. Use that bit. > > Fixes: c93cc69004df ("bpftool: add ability to dump BTF types") > Signed-off-by: Andrii Nakryiko Applied, thanks!

Re: [PATCH] ARM: dts: Introduce the NXP LS1021A-TSN board

On Fri, 17 May 2019 at 04:05, Shawn Guo wrote: > > On Mon, May 06, 2019 at 04:08:00AM +0300, Vladimir Oltean wrote: > > The LS1021A-TSN is a development board built by VVDN/Argonboards in > > partnership with NXP. > > > > It features the LS1021A SoC and the first-generation SJA1105T Ethernet > > s

Re: [PATCH v2] RDMA: Directly cast the sockaddr union to sockaddr

On Thu, May 16, 2019 at 12:21:48PM -0300, Jason Gunthorpe wrote: > On Thu, May 16, 2019 at 02:44:28PM +0200, Simon Horman wrote: > > On Mon, May 13, 2019 at 09:55:21PM -0300, Jason Gunthorpe wrote: > > > gcc 9 now does allocation size tracking and thinks that passing the member > > > of a union and

Re: [PATCH] lib: Correct comment of prandom_seed

On Fri, 17 May 2019, Philippe Mazenauer wrote: > Variable 'entropy' was wrongly documented as 'seed', changed comment to > reflect actual variable name. > > ../lib/random32.c:179: warning: Function parameter or member 'entropy' not > described in 'prandom_seed' > ../lib/random32.c:179: warning:

  1   2   >