[PATCH iproute2] rdma: Update node type strings

2019-05-14 Thread Gal Pressman
Fix typo in usnic_udp node type and add a string for the unspecified node type. Signed-off-by: Gal Pressman --- rdma/dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rdma/dev.c b/rdma/dev.c index 339625202200..904836221c1b 100644 --- a/rdma/dev.c +++ b/rdma/dev.c @@ -1

[PATCH] net: sh_eth: fix mdio access in sh_eth_close() for some SoCs

2019-05-14 Thread Yoshihiro Shimoda
The sh_eth_close() resets the MAC and then calls phy_stop() so that mdio read access result is incorrect without any error according to kernel trace like below: ifconfig-216 [003] .n.. 109.133124: mdio_access: ee70.ethernet- read phy:0x01 reg:0x00 val:0x To fix the issue, th

Re: [Intel-wired-lan] [PATCH] e1000e: Work around hardware unit hang by disabling TSO

2019-05-14 Thread Neftin, Sasha
On 5/9/2019 13:34, Juliana Rodrigueiro wrote: When forwarding traffic to a client behind NAT, some e1000e devices become unstable, hanging and then being reset by the watchdog. Output from syslog: kernel: e1000e :00:19.0 eth0: Detected Hardware Unit Hang: kernel: TDH <5f>

Re: [PATCH v4 1/2] Bluetooth: hci_qca: Load customized NVM based on the device property

2019-05-14 Thread Balakrishna Godavarthi
Hi Rocky, On 2019-05-12 08:49, Rocky Liao wrote: QCA BTSOC NVM is a customized firmware file and different vendors may want to have different BTSOC configuration (e.g. Configure SCO over PCM or I2S, Setting Tx power, etc.) via this file. This patch will allow vendors to download different NVM fi

KASAN: use-after-free Read in timer_is_static_object (2)

2019-05-14 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:63863ee8 Merge tag 'gcc-plugins-v5.2-rc1' of ssh://gitolit.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=128b8d74a0 kernel config: https://syzkaller.appspot.com/x/.config?x=52ff73a1f6d0b441 da

Re: [bpf PATCH v4 1/4] bpf: tls, implement unhash to avoid transition out of ESTABLISHED

2019-05-14 Thread John Fastabend
Jakub Kicinski wrote: > On Tue, 14 May 2019 15:34:55 -0700, John Fastabend wrote: > > John Fastabend wrote: > > > Jakub Kicinski wrote: > > > > On Thu, 09 May 2019 21:57:49 -0700, John Fastabend wrote: > > > > > @@ -2042,12 +2060,14 @@ void tls_sw_free_resources_tx(struct sock *sk) > > > > >

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Stanislav Fomichev
On Tue, May 14, 2019 at 8:42 PM Alexei Starovoitov wrote: > > On Tue, May 14, 2019 at 8:38 PM Stanislav Fomichev wrote: > > > > Take a look at the patches 2-4 in the current series where I convert > > the callers. > > > > (Though, I'd rename xxx_dereference to xxx_rcu_dereference for clarity we >

[PATCH bpf] libbpf: don't fail when feature probing fails

2019-05-14 Thread Stanislav Fomichev
Otherwise libbpf is unusable from unprivileged process with kernel.kernel.unprivileged_bpf_disabled=1. All I get is EPERM from the probes, even if I just want to open an ELF object and look at what progs/maps it has. Instead of dying on probes, let's just pr_debug the error and try to continue. S

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Stanislav Fomichev
On Tue, May 14, 2019 at 8:16 PM Alexei Starovoitov wrote: > > On Tue, May 14, 2019 at 07:56:36PM -0700, Stanislav Fomichev wrote: > > On 05/14, Eric Dumazet wrote: > > > > > > > > > On 5/14/19 7:27 PM, Alexei Starovoitov wrote: > > > > > > > what about activate_effective_progs() ? > > > > I wouldn

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Alexei Starovoitov
On Tue, May 14, 2019 at 8:38 PM Stanislav Fomichev wrote: > > Take a look at the patches 2-4 in the current series where I convert > the callers. > > (Though, I'd rename xxx_dereference to xxx_rcu_dereference for clarity we > get to a v2). please make a fresh repost _after_ bpf-next opens.

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Alexei Starovoitov
On Tue, May 14, 2019 at 07:56:36PM -0700, Stanislav Fomichev wrote: > On 05/14, Eric Dumazet wrote: > > > > > > On 5/14/19 7:27 PM, Alexei Starovoitov wrote: > > > > > what about activate_effective_progs() ? > > > I wouldn't want to lose the annotation there. > > > but then array_free will lose

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Stanislav Fomichev
On 05/14, Alexei Starovoitov wrote: > On Tue, May 14, 2019 at 10:53 AM Stanislav Fomichev wrote: > > > > Existing __rcu annotations don't add anything to the safety. > > what do you mean? > BPF_PROG_RUN_ARRAY derefs these pointers under rcu. And I'm not removing them from the struct definitions,

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Stanislav Fomichev
On 05/14, Eric Dumazet wrote: > > > On 5/14/19 7:27 PM, Alexei Starovoitov wrote: > > > what about activate_effective_progs() ? > > I wouldn't want to lose the annotation there. > > but then array_free will lose it? It would not have have it because the input is the result of bpf_prog_array_allo

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Eric Dumazet
On 5/14/19 7:27 PM, Alexei Starovoitov wrote: > what about activate_effective_progs() ? > I wouldn't want to lose the annotation there. > but then array_free will lose it? > in some cases it's called without mutex in a destruction path. > also how do you propose to solve different 'mtx' in > lo

[PATCH bpf] bpf: relax inode permission check for retrieving bpf program

2019-05-14 Thread Chenbo Feng
For iptable module to load a bpf program from a pinned location, it only retrieve a loaded program and cannot change the program content so requiring a write permission for it might not be necessary. Also when adding or removing an unrelated iptable rule, it might need to flush and reload the xt_bp

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Alexei Starovoitov
On Tue, May 14, 2019 at 7:11 PM Stanislav Fomichev wrote: > > On 05/14, Alexei Starovoitov wrote: > > On Tue, May 14, 2019 at 10:53 AM Stanislav Fomichev > > wrote: > > > > > > Existing __rcu annotations don't add anything to the safety. > > > > what do you mean? > > BPF_PROG_RUN_ARRAY derefs th

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Alexei Starovoitov
On Tue, May 14, 2019 at 10:53 AM Stanislav Fomichev wrote: > > Existing __rcu annotations don't add anything to the safety. what do you mean? BPF_PROG_RUN_ARRAY derefs these pointers under rcu.

Re: [BUG] rtlwifi: a crash in error handling code of rtl_pci_probe()

2019-05-14 Thread Jia-Ju Bai
On 2019/5/15 9:08, Larry Finger wrote: On 5/14/19 8:07 AM, Jia-Ju Bai wrote: In rtl_pci_probe(), when request_irq() in rtl_pci_intr_mode_legacy() in rtl_pci_intr_mode_decide() fails, a crash occurs. The crash information is as follows: [ 108.271155] kasan: CONFIG_KASAN_INLINE enabled [ 10

Re: [BUG] rtlwifi: a crash in error handling code of rtl_pci_probe()

2019-05-14 Thread Larry Finger
On 5/14/19 8:07 AM, Jia-Ju Bai wrote: In rtl_pci_probe(), when request_irq() in rtl_pci_intr_mode_legacy() in rtl_pci_intr_mode_decide() fails, a crash occurs. The crash information is as follows: [  108.271155] kasan: CONFIG_KASAN_INLINE enabled [  108.271163] kasan: GPF could be caused by NUL

Re: [PATCH v2 0/3] auth_gss: netns refcount leaks when use-gss-proxy==1

2019-05-14 Thread J. Bruce Fields
Whoops, I was slow to test these. I'm getting failuring krb5 nfs mounts, and the following the server's logs. Dropping the three patches for now. --b. [ 40.894408] remove_proc_entry: removing non-empty directory 'net/rpc', leaking at least 'use-gss-proxy' [ 40.897352] WARNING: CPU: 2 PID:

[PATCH v2] hv_sock: Add support for delayed close

2019-05-14 Thread Sunil Muthuswamy
Currently, hvsock does not implement any delayed or background close logic. Whenever the hvsock socket is closed, a FIN is sent to the peer, and the last reference to the socket is dropped, which leads to a call to .destruct where the socket can hang indefinitely waiting for the peer to close it's

[PATCH net] ipv6: fix src addr routing with the exception table

2019-05-14 Thread Wei Wang
From: Wei Wang When inserting route cache into the exception table, the key is generated with both src_addr and dest_addr with src addr routing. However, current logic always assumes the src_addr used to generate the key is a /128 host address. This is not true in the following scenarios: 1. When

[PATCH v2] atm: iphase: Avoid copying pointers to user space.

2019-05-14 Thread Fuqian Huang
Remove the MEMDUMP_DEV case in ia_ioctl to avoid copy pointers to user space. Signed-off-by: Fuqian Huang --- drivers/atm/iphase.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c index 5278c57dce73..302cf0ba1600 100644 --- a/drivers/atm/iphase

Re: [PATCH rdma-next 0/2] DevX fixes

2019-05-14 Thread Jason Gunthorpe
On Tue, May 14, 2019 at 02:44:10PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > There are two very short but important fixes to DevX flows. applied to for-next Jason

Re: [RFC 2] Validate required parameters in inet6_validate_link_af

2019-05-14 Thread Jakub Kicinski
On Mon, 13 May 2019 15:05:30 +, Maxim Mikityanskiy wrote: > + err = -EINVAL; > + > + if (tb[IFLA_INET6_ADDR_GEN_MODE]) { > + u8 mode = nla_get_u8(tb[IFLA_INET6_ADDR_GEN_MODE]); > + > + if (check_addr_gen_mode(mode) < 0) > + return -EINVAL; > +

Re: [PATCH net] nfp: flower: add rcu locks when accessing netdev for tunnels

2019-05-14 Thread Jakub Kicinski
On Tue, 14 May 2019 16:03:39 -0700 (PDT), David Miller wrote: > From: Jakub Kicinski > Date: Tue, 14 May 2019 14:28:19 -0700 > > > From: Pieter Jansen van Vuuren > > > > Add rcu locks when accessing netdev when processing route request > > and tunnel keep alive messages received from hardware.

Re: [PATCH net-next,RFC 1/2] net: flow_offload: add flow_block_cb API

2019-05-14 Thread Pablo Neira Ayuso
On Tue, May 14, 2019 at 04:57:19PM +0200, Jiri Pirko wrote: > Thu, May 09, 2019 at 06:39:50PM CEST, pa...@netfilter.org wrote: > >This patch renames: > > > >* struct tcf_block_cb to flow_block_cb. > >* struct tc_block_offload to flow_block_offload. > > > >And it exposes the flow_block_cb API throug

Re: [PATCH net] nfp: flower: add rcu locks when accessing netdev for tunnels

2019-05-14 Thread David Miller
From: Jakub Kicinski Date: Tue, 14 May 2019 14:28:19 -0700 > From: Pieter Jansen van Vuuren > > Add rcu locks when accessing netdev when processing route request > and tunnel keep alive messages received from hardware. > > Fixes: 8e6a9046b66a ("nfp: flower vxlan neighbour offload") > Fixes: 85

Re: [PATCH net-next,RFC 2/2] netfilter: nf_tables: add hardware offload support

2019-05-14 Thread Pablo Neira Ayuso
On Tue, May 14, 2019 at 07:01:08PM +0200, Jiri Pirko wrote: > Thu, May 09, 2019 at 06:39:51PM CEST, pa...@netfilter.org wrote: > >This patch adds hardware offload support for nftables through the > >existing netdev_ops->ndo_setup_tc() interface, the TC_SETUP_CLSFLOWER > >classifier and the flow rul

Re: [PATCH] atm: iphase: Avoid copying pointers to user space.

2019-05-14 Thread David Miller
From: Fuqian Huang Date: Tue, 14 May 2019 23:11:59 +0800 > When ia_cmds.sub_cmd is MEMDUMP_DEV in ia_ioctl, > nullify the pointer fields of iadev before copying > the whole structure to user space. > > Signed-off-by: Fuqian Huang Honestly I'd rather you just remove the MEMDUMP_DEV ioctl altoge

Re: [bpf PATCH v4 1/4] bpf: tls, implement unhash to avoid transition out of ESTABLISHED

2019-05-14 Thread Jakub Kicinski
On Tue, 14 May 2019 15:34:55 -0700, John Fastabend wrote: > John Fastabend wrote: > > Jakub Kicinski wrote: > > > On Thu, 09 May 2019 21:57:49 -0700, John Fastabend wrote: > > > > @@ -2042,12 +2060,14 @@ void tls_sw_free_resources_tx(struct sock *sk) > > > > if (atomic_read(&ctx->encryp

Re: [PATCH v2] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread David Miller
From: YueHaibing Date: Tue, 14 May 2019 22:55:32 +0800 > BUG: unable to handle kernel paging request at a018f000 ... > If ppp_deflate fails to register in deflate_init, > module initialization failed out, however > ppp_deflate_draft may has been regiestred and not > unregistered before r

Re: [PATCH net RESEND] net: macb: fix error format in dev_err()

2019-05-14 Thread David Miller
From: Luca Ceresoli Date: Tue, 14 May 2019 15:23:07 +0200 > Errors are negative numbers. Using %u shows them as very large positive > numbers such as 4294967277 that don't make sense. Use the %d format > instead, and get a much nicer -19. > > Signed-off-by: Luca Ceresoli > Fixes: b48e0bab142f (

Re: [PATCH net v3] rtnetlink: always put IFLA_LINK for links with a link-netnsid

2019-05-14 Thread David Miller
From: Sabrina Dubroca Date: Tue, 14 May 2019 15:12:19 +0200 > Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when > iflink == ifindex. > > In some cases, a device can be created in a different netns with the > same ifindex as its parent. That device will not dump its IFLA_LINK >

Re: [PATCH net] net/mlx4_core: Change the error print to info print

2019-05-14 Thread David Miller
From: wangyunjian Date: Tue, 14 May 2019 19:03:19 +0800 > From: Yunjian Wang > > The error print within mlx4_flow_steer_promisc_add() should > be a info print. > > Fixes: 592e49dda812 ('net/mlx4: Implement promiscuous mode with device > managed flow-steering') > Signed-off-by: Yunjian Wang

Re: [bpf PATCH v4 1/4] bpf: tls, implement unhash to avoid transition out of ESTABLISHED

2019-05-14 Thread John Fastabend
John Fastabend wrote: > Jakub Kicinski wrote: > > On Thu, 09 May 2019 21:57:49 -0700, John Fastabend wrote: > > > @@ -2042,12 +2060,14 @@ void tls_sw_free_resources_tx(struct sock *sk) > > > if (atomic_read(&ctx->encrypt_pending)) > > > crypto_wait_req(-EINPROGRESS, &ctx->async_wait); >

Re: [PATCH] NFC: Orphan the subsystem

2019-05-14 Thread David Miller
From: Johannes Berg Date: Tue, 14 May 2019 11:02:31 +0200 > Samuel clearly hasn't been working on this in many years and > patches getting to the wireless list are just being ignored > entirely now. Mark the subsystem as orphan to reflect the > current state and revert back to the netdev list so

Re: [v3, PATCH 0/4] fix some bugs in stmmac

2019-05-14 Thread David Miller
This series doesn't apply to my 'net' tree, mainly because something like patch #3 is already in my tree.

Re: [PATCH] net: Always descend into dsa/

2019-05-14 Thread David Miller
From: Florian Fainelli Date: Mon, 13 May 2019 14:06:24 -0700 > Jiri reported that with a kernel built with CONFIG_FIXED_PHY=y, > CONFIG_NET_DSA=m and CONFIG_NET_DSA_LOOP=m, we would not get to a > functional state where the mock-up driver is registered. Turns out that > we are not descending into

Re: [PATCH v2 net] tcp: fix retrans timestamp on passive Fast Open

2019-05-14 Thread David Miller
From: Yuchung Cheng Date: Mon, 13 May 2019 10:32:05 -0700 > Commit c7d13c8faa74 ("tcp: properly track retry time on > passive Fast Open") sets the start of SYNACK retransmission > time on passive Fast Open in "retrans_stamp". However the > timestamp is not reset upon the handshake has completed.

[PATCH net] nfp: flower: add rcu locks when accessing netdev for tunnels

2019-05-14 Thread Jakub Kicinski
From: Pieter Jansen van Vuuren Add rcu locks when accessing netdev when processing route request and tunnel keep alive messages received from hardware. Fixes: 8e6a9046b66a ("nfp: flower vxlan neighbour offload") Fixes: 856f5b135758 ("nfp: flower vxlan neighbour keep-alive") Signed-off-by: Pieter

Re: [PULL] vhost: cleanups and fixes

2019-05-14 Thread pr-tracker-bot
The pull request you sent on Tue, 14 May 2019 17:11:47 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/35c99ffa20edd3c24be352d28a63cd3a23121282 Thank you! -- Deet-doot-dot, I am a bot

[PATCH bpf 1/2] selftests/bpf: add missing \n to flow_dissector CHECK errors

2019-05-14 Thread Stanislav Fomichev
Otherwise, in case of an error, everything gets mushed together. Fixes: a5cb33464e53 ("selftests/bpf: make flow dissector tests more extensible") Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 8 1 file changed, 4 insertions(+), 4 deletio

[PATCH bpf 2/2] selftests/bpf: add prog detach to flow_dissector test

2019-05-14 Thread Stanislav Fomichev
In case we are not running in a namespace (which we don't do by default), let's try to detach the bpf program that we use for eth_get_headlen tests. Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less mode") Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/

[PATCH] libertas/libertas_tf: fix spelling mistake "Donwloading" -> "Downloading"

2019-05-14 Thread Colin King
From: Colin Ian King There is are two spelling mistakes in lbtf_deb_usb2 messages, fix these. Signed-off-by: Colin Ian King --- drivers/net/wireless/marvell/libertas/if_usb.c| 2 +- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

RE: [PATCH] hv_sock: Fix data loss upon socket close

2019-05-14 Thread Sunil Muthuswamy
> -Original Message- > From: Dexuan Cui > Sent: Friday, May 10, 2019 8:57 PM > To: Sunil Muthuswamy ; KY Srinivasan > ; Haiyang Zhang ; > Stephen Hemminger ; Sasha Levin ; > David S. Miller ; > Michael Kelley > Cc: netdev@vger.kernel.org; linux-hyp...@vger.kernel.org; > linux-ker...

[PATCH net 1/2] flow_offload: support CVLAN match

2019-05-14 Thread Edward Cree
Plumb it through from the flow_dissector. Signed-off-by: Edward Cree --- include/net/flow_offload.h | 2 ++ net/core/flow_offload.c| 7 +++ 2 files changed, 9 insertions(+) diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h index 6200900434e1..a2df99f9b196 100644 --- a

[PATCH net 2/2] net/mlx5e: Fix calling wrong function to get inner vlan key and mask

2019-05-14 Thread Edward Cree
From: Jianbo Liu When flow_rule_match_XYZ() functions were first introduced, flow_rule_match_cvlan() for inner vlan is missing. In mlx5_core driver, to get inner vlan key and mask, flow_rule_match_vlan() is just called, which is wrong because it obtains outer vlan information by FLOW_DISSECTOR_K

[PATCH net 0/2] flow_offload: fix CVLAN support

2019-05-14 Thread Edward Cree
When the flow_offload infrastructure was added, CVLAN matches weren't plumbed through, and flow_rule_match_vlan() was incorrectly called in the mlx5 driver when populating CVLAN match information. This series adds flow_rule_match_cvlan(), and uses it in the mlx5 code. Both patches should also g

Re: [PATCH mlx5-next 2/2] net/mlx5: Set completion EQs as shared resources

2019-05-14 Thread Saeed Mahameed
On Tue, May 14, 2019 at 4:44 AM Leon Romanovsky wrote: > > From: Yishai Hadas > > Mark completion EQs as shared resources so that they can be used by CQs > with uid != 0. > > Fixes: 7efce3691d33 ("IB/mlx5: Add obj create and destroy functionality") > Signed-off-by: Yishai Hadas > Signed-off-by:

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-14 Thread Wei Wang
I think the bug is because when creating exceptions, src_addr is not always set even though fib6_info is in the subtree. (because of rt6_is_gw_or_nonexthop() check) However, when looking up for exceptions, we always set src_addr to the passed in flow->src_addr if fib6_info is in the subtree. That c

Re: [PATCH 2/5] rhashtable: reorder some inline functions and macros.

2019-05-14 Thread Jakub Kicinski
On Fri, 12 Apr 2019 11:52:08 +1000, NeilBrown wrote: > This patch only moves some code around, it doesn't > change the code at all. > A subsequent patch will benefit from this as it needs > to add calls to functions which are now defined before the > call-site, but weren't before. > > Signed-off-b

Re: IP-Aliasing for IPv6?

2019-05-14 Thread Heiner Kallweit
On 14.05.2019 20:49, M. Buecher wrote: > Preamble: I'm just a network hobbyist at home, so please bear with me if > something in this mail is "stupid" from an expert's point of view. > > According to the documentation [1] "IP-Aliasing" is an obsolete way to manage > multiple IP[v4]-addresses/mas

Re: [PATCH][next] iwlwifi: d3: Use struct_size() helper

2019-05-14 Thread Gustavo A. R. Silva
On 5/14/19 12:16 AM, Luciano Coelho wrote: > > Thanks! Applied to our internal tree and it will reach the mainline > following our normal upstreaming process. > Awesome. :) Thanks, Luciano. -- Gustavo

IP-Aliasing for IPv6?

2019-05-14 Thread M. Buecher
Preamble: I'm just a network hobbyist at home, so please bear with me if something in this mail is "stupid" from an expert's point of view. According to the documentation [1] "IP-Aliasing" is an obsolete way to manage multiple IP[v4]-addresses/masks on an interface. For having multiple IP[v4]-a

Re: [RFC net-next v2 00/14] net: stmmac: Selftests

2019-05-14 Thread David Miller
From: Jose Abreu Date: Tue, 14 May 2019 17:45:22 +0200 > [ Submitting with net-next closed for proper review and testing. ] > > This introduces selftests support in stmmac driver. We add 9 basic sanity > checks and MAC loopback support for all cores within the driver. This way > more tests can e

Re: [PATCH bpf 0/3] BPF LRU map fix

2019-05-14 Thread Alexei Starovoitov
On Tue, May 14, 2019 at 10:24 AM Andrii Nakryiko wrote: > > On Mon, May 13, 2019 at 4:19 PM Daniel Borkmann wrote: > > > > This set fixes LRU map eviction in combination with map lookups out > > of system call side from user space. Main patch is the second one and > > test cases are adapted and a

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Stanislav Fomichev
On 05/14, Alexei Starovoitov wrote: > On Tue, May 14, 2019 at 10:30:02AM -0700, Stanislav Fomichev wrote: > > On 05/14, Alexei Starovoitov wrote: > > > On Mon, May 13, 2019 at 11:57 AM Stanislav Fomichev > > > wrote: > > > > > > > > On 05/08, Stanislav Fomichev wrote: > > > > > On 05/08, Alexei S

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Alexei Starovoitov
On Tue, May 14, 2019 at 10:30:02AM -0700, Stanislav Fomichev wrote: > On 05/14, Alexei Starovoitov wrote: > > On Mon, May 13, 2019 at 11:57 AM Stanislav Fomichev > > wrote: > > > > > > On 05/08, Stanislav Fomichev wrote: > > > > On 05/08, Alexei Starovoitov wrote: > > > > > On Wed, May 08, 2019 a

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-14 Thread Petr Štetiar
Srinivas Kandagatla [2019-05-14 16:13:22]: > On 13/05/2019 12:16, Petr Štetiar wrote: > > Srinivas Kandagatla [2019-05-13 11:06:48]: > > > > > On 13/05/2019 10:07, Petr Štetiar wrote: > > > > Srinivas Kandagatla [2019-05-13 > > > > 09:25:55]: > > > > > > > > > My initial idea was to add comp

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Stanislav Fomichev
On 05/14, Alexei Starovoitov wrote: > On Mon, May 13, 2019 at 11:57 AM Stanislav Fomichev wrote: > > > > On 05/08, Stanislav Fomichev wrote: > > > On 05/08, Alexei Starovoitov wrote: > > > > On Wed, May 08, 2019 at 10:18:41AM -0700, Stanislav Fomichev wrote: > > > > > Right now we are not using rc

Re: [PATCH bpf 0/3] BPF LRU map fix

2019-05-14 Thread Andrii Nakryiko
On Mon, May 13, 2019 at 4:19 PM Daniel Borkmann wrote: > > This set fixes LRU map eviction in combination with map lookups out > of system call side from user space. Main patch is the second one and > test cases are adapted and added in the last one. Thanks! > > Daniel Borkmann (3): > bpf: add m

Re: [PATCH net-next,RFC 2/2] netfilter: nf_tables: add hardware offload support

2019-05-14 Thread Jiri Pirko
Thu, May 09, 2019 at 06:39:51PM CEST, pa...@netfilter.org wrote: >This patch adds hardware offload support for nftables through the >existing netdev_ops->ndo_setup_tc() interface, the TC_SETUP_CLSFLOWER >classifier and the flow rule API. This hardware offload support is >available for the NFPROTO_N

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Alexei Starovoitov
On Mon, May 13, 2019 at 11:57 AM Stanislav Fomichev wrote: > > On 05/08, Stanislav Fomichev wrote: > > On 05/08, Alexei Starovoitov wrote: > > > On Wed, May 08, 2019 at 10:18:41AM -0700, Stanislav Fomichev wrote: > > > > Right now we are not using rcu api correctly: we pass __rcu pointers > > > >

Re: [PATCH bpf 1/3] bpf: add map_lookup_elem_sys_only for lookups from syscall side

2019-05-14 Thread Andrii Nakryiko
On Tue, May 14, 2019 at 12:59 AM Daniel Borkmann wrote: > > On 05/14/2019 07:04 AM, Andrii Nakryiko wrote: > > On Mon, May 13, 2019 at 4:20 PM Daniel Borkmann > > wrote: > >> > >> Add a callback map_lookup_elem_sys_only() that map implementations > >> could use over map_lookup_elem() from system

Re: [Intel-wired-lan] i40e X722 RSS problem with NAT-Traversal IPsec packets

2019-05-14 Thread Lennart Sorensen
On Mon, May 13, 2019 at 12:04:00PM -0700, Alexander Duyck wrote: > So I recreated the first packet you listed via text2pcap, replayed it > on my test system via tcpreplay, updated my configuration to 12 > queues, and used the 2 hash keys you listed. I ended up seeing the > traffic bounce between qu

RE: [PATCH] hv_sock: Fix data loss upon socket close

2019-05-14 Thread Sunil Muthuswamy
> -Original Message- > From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of David Miller > Sent: Thursday, May 9, 2019 1:58 PM > To: Sunil Muthuswamy > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; sas...@kernel.org; Dexuan Cui > ; Michael Kelley ; > netdev@vger.ker

Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking

2019-05-14 Thread Serge Semin
Hello Peter On Tue, May 14, 2019 at 07:53:21AM -0400, Peter Geis wrote: > On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit wrote: > > > > On 12.05.2019 04:50, Peter Geis wrote: > > > On 5/11/2019 10:37 PM, Andrew Lunn wrote: > > >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote: > > >>

Re: [PATCH bpf] libbpf: detect supported kernel BTF features and sanitize BTF

2019-05-14 Thread Andrii Nakryiko
On Tue, May 14, 2019 at 2:24 AM Lorenz Bauer wrote: > > On Fri, 10 May 2019 at 17:19, Andrii Nakryiko > wrote: > > > > On Fri, May 10, 2019 at 8:17 AM Lorenz Bauer wrote: > > > > > > On Fri, 10 May 2019 at 15:16, Andrii Nakryiko > > > wrote: > > > > > > > > On Fri, May 10, 2019 at 2:46 AM Lor

Re: [PATCH] net: Always descend into dsa/

2019-05-14 Thread Jiri Pirko
Mon, May 13, 2019 at 11:06:24PM CEST, f.faine...@gmail.com wrote: >Jiri reported that with a kernel built with CONFIG_FIXED_PHY=y, >CONFIG_NET_DSA=m and CONFIG_NET_DSA_LOOP=m, we would not get to a >functional state where the mock-up driver is registered. Turns out that >we are not descending into

[RFC net-next v2 10/14] net: stmmac: dwxgmac2: Also pass control frames while in promisc mode

2019-05-14 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- dr

[RFC net-next v2 09/14] net: stmmac: dwmac4/5: Also pass control frames while in promisc mode

2019-05-14 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- dr

[RFC net-next v2 12/14] net: stmmac: dwmac1000: Fix Hash Filter

2019-05-14 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 1 +

[RFC net-next v2 00/14] net: stmmac: Selftests

2019-05-14 Thread Jose Abreu
[ Submitting with net-next closed for proper review and testing. ] This introduces selftests support in stmmac driver. We add 9 basic sanity checks and MAC loopback support for all cores within the driver. This way more tests can easily be added in the future and can be run in virtually any MAC/GM

[RFC net-next v2 07/14] net: stmmac: Switch MMC functions to HWIF callbacks

2019-05-14 Thread Jose Abreu
XGMAC has a different MMC module. Lets use HWIF callbacks for MMC module so that correct callbacks are automatically selected. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/

[RFC net-next v2 04/14] net: stmmac: dwmac4/5: Add MAC loopback support

2019-05-14 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac4/5 cores. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h |

[RFC net-next v2 08/14] net: stmmac: dwmac1000: Also pass control frames while in promisc mode

2019-05-14 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- dr

[RFC net-next v2 11/14] net: stmmac: Introduce selftests support

2019-05-14 Thread Jose Abreu
We add support for selftests on stmmac driver with 9 basic sanity checks for now: - MAC Loopback - PHY Loopback - MMC Counters - EEE - Hash Filter Multicast - Perfect Filter Unicast - Multicast Filter All - Unicast Filter All -

[RFC net-next v2 14/14] net: stmmac: dwmac4/5: Fix Hash Filter

2019-05-14 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Fout out while running stmmac selftests Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1 + driv

[RFC net-next v2 06/14] net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback

2019-05-14 Thread Jose Abreu
From: Corentin Labbe This patch enable use of set_mac_loopback in dwmac-sun8i Signed-off-by: Corentin Labbe Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 13 + 1

[RFC net-next v2 13/14] net: stmmac: dwmac1000: Clear unused address entries

2019-05-14 Thread Jose Abreu
In case we don't use a given address entry we need to clear it because it could contain previous values that are no longer valid. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin La

[RFC net-next v2 05/14] net: stmmac: dwxgmac2: Add MAC loopback support

2019-05-14 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwxgmac2 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h |

[RFC net-next v2 03/14] net: stmmac: dwmac1000: Add MAC loopback support

2019-05-14 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac1000 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c

[RFC net-next v2 02/14] net: stmmac: dwmac100: Add MAC loopback support

2019-05-14 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac100 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c |

[RFC net-next v2 01/14] net: stmmac: Add MAC loopback callback to HWIF

2019-05-14 Thread Jose Abreu
In preparation for the addition of selftests support for stmmac we add a new callback to HWIF that can be used to set the controller in loopback mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/

Re: getneigh: add nondump to retrieve single entry

2019-05-14 Thread Roopa Prabhu
On Mon, May 13, 2019 at 9:04 AM wrote: > > From: Leonard Zgrablic > > Currently there is only a dump version of RTM_GETNEIGH for PF_UNSPEC in > RTNETLINK that dumps neighbor entries, no non-dump version that can be used to > retrieve a single neighbor entry. > > Add support for the non-dump (doit

Re: [PATCH 5/5] net: phy: dp83867: Use unsigned variables to store unsigned properties

2019-05-14 Thread Trent Piepho
On Mon, 2019-05-13 at 23:43 +0200, Andrew Lunn wrote: > > > > > > Are there any in tree users of DP83867_CLK_O_SEL_REF_CLK? We have to > > > be careful changing its meaning. But if nobody is actually using it... > > > > Nope. I doubt this will affect anyone. They'd need to strap the phy > > to

Re: [PATCH v2] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread Guillaume Nault
On Tue, May 14, 2019 at 10:55:32PM +0800, YueHaibing wrote: > If ppp_deflate fails to register in deflate_init, > module initialization failed out, however > ppp_deflate_draft may has been regiestred and not > unregistered before return. > Thanks! Acked-by: Guillaume Nault

Re: [PATCH] NFC: Orphan the subsystem

2019-05-14 Thread Samuel Ortiz
Hi Johannes, On Tue, May 14, 2019 at 11:02:31AM +0200, Johannes Berg wrote: > Samuel clearly hasn't been working on this in many years and > patches getting to the wireless list are just being ignored > entirely now. Mark the subsystem as orphan to reflect the > current state and revert back to th

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-14 Thread Srinivas Kandagatla
On 13/05/2019 12:16, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-13 11:06:48]: On 13/05/2019 10:07, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-13 09:25:55]: My initial idea was to add compatible strings to the cell so that most of the encoding information can be derived from

[PATCH] atm: iphase: Avoid copying pointers to user space.

2019-05-14 Thread Fuqian Huang
When ia_cmds.sub_cmd is MEMDUMP_DEV in ia_ioctl, nullify the pointer fields of iadev before copying the whole structure to user space. Signed-off-by: Fuqian Huang --- drivers/atm/iphase.c | 73 +--- 1 file changed, 70 insertions(+), 3 deletions(-)

[PATCH v2] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread YueHaibing
BUG: unable to handle kernel paging request at a018f000 PGD 3270067 P4D 3270067 PUD 3271063 PMD 2307eb067 PTE 0 Oops: [#1] PREEMPT SMP CPU: 0 PID: 4138 Comm: modprobe Not tainted 5.1.0-rc7+ #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.9.3-0-ge2fc41e-prebuilt.qem

Re: [PATCH net-next,RFC 1/2] net: flow_offload: add flow_block_cb API

2019-05-14 Thread Jiri Pirko
Thu, May 09, 2019 at 06:39:50PM CEST, pa...@netfilter.org wrote: >This patch renames: > >* struct tcf_block_cb to flow_block_cb. >* struct tc_block_offload to flow_block_offload. > >And it exposes the flow_block_cb API through net/flow_offload.h. This >renames the existing codebase to adapt it to t

Re: [PATCH] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread YueHaibing
On 2019/5/14 22:05, Guillaume Nault wrote: > On Tue, May 14, 2019 at 03:43:00PM +0800, YueHaibing wrote: >> >> If ppp_deflate fails to register in deflate_init, >> module initialization failed out, however >> ppp_deflate_draft may has been regiestred and not >> unregistered before return. >> Then t

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-14 Thread Stefano Brivio
On Mon, 13 May 2019 23:12:31 -0700 Wei Wang wrote: > Thanks Mikael for reporting this issue. And thanks David for the bisection. > Let me spend some time to reproduce it and see what is going on. Mikael, by the way, once this is sorted out, it would be nice if you could add your test as a case i

Re: [PATCH v2 2/4] mfd: ioc3: Add driver for SGI IOC3 chip

2019-05-14 Thread Thomas Bogendoerfer
On Fri, 10 May 2019 08:14:19 +0100 Lee Jones wrote: > On Thu, 09 May 2019, Thomas Bogendoerfer wrote: > > > > + } > > > > + pr_err("ioc3: CRC error in NIC address\n"); > > > > +} > > > > > > This all looks like networking code. If this is the case, it should > > > be moved to driver

Re: [PATCH] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread Guillaume Nault
On Tue, May 14, 2019 at 03:43:00PM +0800, YueHaibing wrote: > > If ppp_deflate fails to register in deflate_init, > module initialization failed out, however > ppp_deflate_draft may has been regiestred and not > unregistered before return. > Then the seconed modprobe will trigger crash like this.

Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-14 Thread Oliver Neukum
On Di, 2019-05-14 at 12:11 +, Igor Russkikh wrote: > On 09.05.2019 12:08, Oliver Neukum wrote: > > When writing to the phy on BE architectures an internal data structure > > was directly given, leading to it being byte swapped in the wrong > > way for the CPU in 50% of all cases. A temporary bu

Re: mvpp2: oops on first received packet

2019-05-14 Thread Yanko Kaneti
On Tue, 2019-05-14 at 14:32 +0200, Maxime Chevallier wrote: > Hi Yanko, > > > On Tue, 14 May 2019 10:29:31 +0300 > > Yanko Kaneti wrote: > > > > > Hello, > > > > > > I am trying to get some Fedora working on the MACCHIATObin SingleShot > > > and I am getting an OOPS on what seems to be the firs

Re: [PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Luca Ceresoli
Hi Andrew, On 14/05/19 14:35, Andrew Lunn wrote: > On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote: >> Errors are negative numbers. Using %u shows them as very large positive >> numbers such as 4294967277 that don't make sense. Use the %d format >> instead, and get a much nicer -19.

  1   2   >