On Tue, May 14, 2019 at 10:56:54AM +0800, Weilong Chen wrote:
> The remote host answers to an ICMP timestamp request.
> This allows an attacker to know the time and date on your host.
>
> This path is an another way contrast to iptables rules:
> iptables -A input -p icmp --icmp-type timestamp-requ
If register_pernet_subsys success in smc_init,
we should cleanup it in case any other error.
Fixes: 64e28b52c7a6 (net/smc: add pnet table namespace support")
Signed-off-by: YueHaibing
---
net/smc/af_smc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/smc/af_smc.c b/
Thanks Mikael for reporting this issue. And thanks David for the bisection.
Let me spend some time to reproduce it and see what is going on.
From: David Ahern
Date: Mon, May 13, 2019 at 8:35 PM
To: Mikael Magnusson, , Martin KaFai Lau, Wei Wang
> On 5/13/19 1:22 PM, Mikael Magnusson wrote:
> > H
On Mon, 2019-05-13 at 21:33 +0800, Cyrus Lien wrote:
> Killer series loadded IWL_22000_HR_B_FW_PRE prefixed firmware instead
> IWL_CC_A_FW_PRE prefixed firmware.
>
> Add killer series to the check logic as iwl_ax200_cfg_cc.
>
> Signed-off-by: Cyrus Lien
> ---
> drivers/net/wireless/intel/iwlwif
On Sat, 2019-05-04 at 17:33 +0800, Jia-Ju Bai wrote:
> In the error handling code of iwl_req_fw_callback(),
> iwl_dealloc_ucode()
> is called to free data. In iwl_drv_stop(), iwl_dealloc_ucode() is
> called
> again, which can cause double-free problems.
>
> To fix this bug, the call to iwl_dealloc
On Wed, 2019-04-03 at 11:03 -0500, Gustavo A. R. Silva wrote:
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
>
> So, change the following form:
>
> sizeof(*pa
On Wed, 2019-04-03 at 10:59 -0500, Gustavo A. R. Silva wrote:
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
>
> So, change the following form:
>
> sizeof(*pa
On Mon, May 13, 2019 at 4:20 PM Daniel Borkmann wrote:
>
> Add a callback map_lookup_elem_sys_only() that map implementations
> could use over map_lookup_elem() from system call side in case the
> map implementation needs to handle the latter differently than from
> the BPF data path. If map_looku
I'm having trouble getting Debian Buster up and running on qemu-system-
sparc64 and so haven't been able to reproduce. Is this currently working for
people?
I just reinstalled the machine from
https://cdimage.debian.org/cdimage/ports/2019-05-09/debian-10.0-sparc64-NETINST-1.iso
and there's a eve
The tcp_bpf_wait_data() routine needs to check timeo != 0 before
calling sk_wait_event() otherwise we may see unexpected stalls
on receiver.
Arika did all the leg work here I just formaatted, posted and ran
a few tests.
Fixes: 604326b41a6fb ("bpf, sockmap: convert to generic sk_msg interface")
Re
Hi Andrew,
Add a Fixes:tag in series v3, please review.
On Tue, 2019-05-14 at 05:00 +0200, Andrew Lunn wrote:
> On Tue, May 14, 2019 at 10:28:49AM +0800, Biao Huang wrote:
> > changes in v2:
> >
> > 1. update rx_tai
On 2019/5/14 上午1:51, Stefano Garzarella wrote:
On Mon, May 13, 2019 at 06:01:52PM +0800, Jason Wang wrote:
On 2019/5/10 下午8:58, Stefano Garzarella wrote:
In order to increase host -> guest throughput with large packets,
we can use 64 KiB RX buffers.
Signed-off-by: Stefano Garzarella
---
Currently we will not update the receive descriptor tail pointer in
stmmac_rx_refill. Rx dma will think no available descriptors and stop
once received packets exceed DMA_RX_SIZE, so that the rx only test will fail.
Update the receive tail pointer in stmmac_rx_refill to add more descriptors
to the
The specific clk_csr value can be zero, and
stmmac_clk is necessary for MDC clock which can be set dynamically.
So, change the condition from plat->clk_csr to plat->stmmac_clk to
fix clk_csr can't be zero issue.
Fixes: cd7201f477b9 ("stmmac: MDC clock dynamically based on the csr clock
input")
Si
The value of MTL_OPERATION_MODE is modified, and should
be write back to the register.
Fixes: d0a9c9f9c6d0 ("net: stmmac: configure mtl rx and tx algorithms")
Signed-off-by: Biao Huang
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/
1. the frequency of csr clock is 66.5MHz, so the csr_clk value should
be 0 other than 5.
2. the csr_clk can be got from device tree, so remove initialization here.
Fixes: 9992f37e346b ("stmmac: dwmac-mediatek: add support for mt2712")
Signed-off-by: Biao Huang
---
.../net/ethernet/stmicro/stmmac
changes in v3:
add a Fixes:tag for each patch
changes in v2:
On 5/13/19 1:22 PM, Mikael Magnusson wrote:
> Hello list,
>
> I think I have found a regression in 4.15+ kernels. IPv6 PMTU discovery
> doesn't seem to work with source-specific routing (AKA source-address
> dependent routing, SADR).
>
> I made a test script (see attachment). It sets up a test en
On Tue, May 14, 2019 at 10:28:49AM +0800, Biao Huang wrote:
> changes in v2:
>
> 1. update rx_tail_addr as Jose's comment
>
> 2. changes clk_csr condition as Alex's proposition
Changes in v2:
1. reverse Christmas tree order in dwmac4_set_filter
2. remove clause 45 patch, waiting for cl45 patch from Boon Leong
v1:
1. get hash table size in hw feature reigster, and add support
for taller hash table(128/256) in dwmac4.
2. only clear PR/HMC/PM bits of GMAC_PACKET_FILTER, to avoid
side effect to functions of other bits.
Signed-off-by: Biao Huang
---
drivers/net/ethernet/stmicro/stmmac/common.h |7 +--
On 5/13/19 9:31 AM, Willem de Bruijn wrote:
>>
>> +/* based on tcp_recv_timestamp */
>
> Which itself is based on __sock_recv_timestamp. Which this resembles
> even more closely, as both pass an skb. Instead of duplicating the
> core code yet again, we can probably factor out and reuse it. Netlink
On 5/9/19 10:51 AM, David Miller wrote:
> From: David Ahern
> Date: Thu, 9 May 2019 08:55:42 -0700
>
>> From: David Ahern
>>
>> Add support for timestamping netlink messages. If a socket wants a
>> timestamp, it is added when the skb clone is queued to the socket.
>>
>> Allow userspace to know
The remote host answers to an ICMP timestamp request.
This allows an attacker to know the time and date on your host.
This path is an another way contrast to iptables rules:
iptables -A input -p icmp --icmp-type timestamp-request -j DROP
iptables -A output -p icmp --icmp-type timestamp-reply -j DR
1. the frequency of csr clock is 66.5MHz, so the csr_clk value should
be 0 other than 5.
2. the csr_clk can be got from device tree, so remove initialization here.
Change-Id: I3cd92fe380150fec6daa2d3acaab69a6d58344c0
Signed-off-by: Biao Huang
---
.../net/ethernet/stmicro/stmmac/dwmac-mediatek.c
Currently we will not update the receive descriptor tail pointer in
stmmac_rx_refill. Rx dma will think no available descriptors and stop
once received packets exceed DMA_RX_SIZE, so that the rx only test will fail.
Update the receive tail pointer in stmmac_rx_refill to add more descriptors
to the
changes in v2:
1. update rx_tail_addr as Jose's comment
2. changes clk_csr condition as Alex's proposition
3. remove init lines in dwmac-mediatek, get clk_
The value of MTL_OPERATION_MODE is modified, and should
be write back to the register.
Signed-off-by: Biao Huang
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
b/drivers/net/etherne
The specific clk_csr value can be zero, and
stmmac_clk is necessary for MDC clock which can be set dynamically.
So, change the condition from plat->clk_csr to plat->stmmac_clk to
fix clk_csr can't be zero issue.
Signed-off-by: Biao Huang
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |
On Mon, 2019-05-13 at 10:01 -0700, Rick Edgecombe wrote:
> On Mon, 2019-05-13 at 17:01 +0300, Meelis Roos wrote:
> > I tested yesterdays 5.2 devel git and it failed to boot on my Sun Fire V445
> > (4x UltraSparc III). Init is started and it hangs there:
> >
> > [ 38.414436] Run /sbin/init as ini
gcc 9 now does allocation size tracking and thinks that passing the member
of a union and then accessing beyond that member's bounds is an overflow.
Instead of using the union member, use the entire union with a cast to
get to the sockaddr. gcc will now know that the memory extends the full
size o
From: Stanislav Fomichev
Date: Mon, May 13, 2019 at 7:21 PM
To: Stanislav Fomichev
Cc: Willem de Bruijn , Network
Development, bpf, David Miller, Alexei Starovoitov, Daniel Borkmann,
Willem de Bruijn , Petar Penkov
> > On 05/13, Willem de Bruijn wrote:
> > > On Mon, May 13, 2019 at 5:21 PM Willem
On 05/13/2019 04:19 PM, John Fastabend wrote:
> A couple fixes for sockmap code. Previously this was bundled with a tls
> fix for unhash() path however, that is becoming a larger fix so push
> these on their own.
Agree, applied, thanks!
On 05/13/2019 09:04 PM, Stanislav Fomichev wrote:
> Both of them are not declared in the headers and not used outside
> of bpf_trace.c file.
>
> Fixes: a38d1107f937c ("bpf: support raw tracepoints in modules")
> Signed-off-by: Stanislav Fomichev
Applied, thanks!
On 5/13/2019 1:42 PM, Jonathan Lemon wrote:
Tossing in my .02 cents:
I anticipate that most users of AF_XDP will want packet processing
for a given RX queue occurring on a single core - otherwise we end
up with cache delays. The usual model is one thread, one socket,
one core, but this isn't e
On 05/13/2019 06:59 PM, Eric Dumazet wrote:
> synchronize_rcu() is fine when the rcu callbacks only need
> to free memory (kfree_rcu() or direct kfree() call rcu call backs)
>
> __dev_map_entry_free() is a bit more complex, so we need to make
> sure that call queued __dev_map_entry_free() callback
On Mon, 13 May 2019 14:06:24 -0700, Florian Fainelli
wrote:
> Jiri reported that with a kernel built with CONFIG_FIXED_PHY=y,
> CONFIG_NET_DSA=m and CONFIG_NET_DSA_LOOP=m, we would not get to a
> functional state where the mock-up driver is registered. Turns out that
> we are not descending into
> On 05/13, Willem de Bruijn wrote:
> > On Mon, May 13, 2019 at 5:21 PM Willem de Bruijn
> > wrote:
> > >
> > > On Mon, May 13, 2019 at 5:02 PM Stanislav Fomichev
> > > wrote:
> > > >
> > > > On 05/13, Willem de Bruijn wrote:
> > > > > On Mon, May 13, 2019 at 3:53 PM Stanislav Fomichev
> > > >
One of the biggest issues we face right now with picking LRU map over
regular hash table is that a map walk out of user space, for example,
to just dump the existing entries or to remove certain ones, will
completely mess up LRU eviction heuristics and wrong entries such
as just created ones will g
The test_lru_map is relying on marking the LRU map entry via regular
BPF map lookup from system call side. This is basically for simplicity
reasons. Given we fixed marking entries in that case, the test needs
to be fixed as well. Here we add a small drop-in replacement to retain
existing behavior f
Add a callback map_lookup_elem_sys_only() that map implementations
could use over map_lookup_elem() from system call side in case the
map implementation needs to handle the latter differently than from
the BPF data path. If map_lookup_elem_sys_only() is set, this will
be preferred pick for map look
This set fixes LRU map eviction in combination with map lookups out
of system call side from user space. Main patch is the second one and
test cases are adapted and added in the last one. Thanks!
Daniel Borkmann (3):
bpf: add map_lookup_elem_sys_only for lookups from syscall side
bpf, lru: avo
On 05/13, Willem de Bruijn wrote:
> On Mon, May 13, 2019 at 5:21 PM Willem de Bruijn
> wrote:
> >
> > On Mon, May 13, 2019 at 5:02 PM Stanislav Fomichev wrote:
> > >
> > > On 05/13, Willem de Bruijn wrote:
> > > > On Mon, May 13, 2019 at 3:53 PM Stanislav Fomichev
> > > > wrote:
> > > > >
> > >
The pull request you sent on Mon, 13 May 2019 10:08:08 -0700 (PDT):
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git refs/heads/master
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a3958f5e13e23f6e68c3cc1210639f63728a950f
Thank you!
--
Deet-doot-dot, I
On Mon, May 13, 2019 at 5:21 PM Willem de Bruijn
wrote:
>
> On Mon, May 13, 2019 at 5:02 PM Stanislav Fomichev wrote:
> >
> > On 05/13, Willem de Bruijn wrote:
> > > On Mon, May 13, 2019 at 3:53 PM Stanislav Fomichev
> > > wrote:
> > > >
> > > > If we have a flow dissector BPF program attached
Please ignore
net-next boot error: WARNING: workqueue cpumask: online intersect > possible
intersect
bpf-next boot error: WARNING: workqueue cpumask: online intersect > possible
intersect
bpf boot error: WARNING: workqueue cpumask: online intersect > possible
intersect
net boot error: W
On 5/13/19 10:03 AM, mcma...@arista.com wrote:
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 30f6fd8f68e0..981f1568710b 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> +static int neigh_find_fill(struct neigh_table *tbl, const void *pkey,
> +
2019-05-13, 17:13:36 +0200, Nicolas Dichtel wrote:
> Le 13/05/2019 à 17:08, Sabrina Dubroca a écrit :
> > 2019-05-13, 16:50:51 +0200, Nicolas Dichtel wrote:
> >> Le 13/05/2019 à 15:47, Sabrina Dubroca a écrit :
> >>> Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
> >>> iflink
> > Hi Trent
> >
> > I already deleted the patches. For patch 3:
> >
> > + if (dp83867->clk_output_sel > DP83867_CLK_O_SEL_REF_CLK &&
> > +dp83867->clk_output_sel != DP83867_CLK_O_SEL_OFF) {
> > + phydev_err(phydev, "ti,clk-output-sel value %u out of
> > range\n
Hello,
syzbot found the following crash on:
HEAD commit:d4c26eb6 net: ethernet: stmmac: dwmac-sun8i: enable suppor..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=1467a174a0
kernel config: https://syzkaller.appspot.com/x/.config?x=de3262a7df18d5ca
dashboa
On Mon, 2019-05-13 at 22:46 +0200, Andrew Lunn wrote:
> > > Perhaps you could tell me if the approach I've taken in patch 3,
> > > "Add ability to disable output clock", and patch 4, "Disable tx/rx
> > > delay when not configured", are considered acceptable? I can conceive
> > > of arguments for
On 5/7/2019 11:06 PM, Bjorn Andersson wrote:
In order to prevent overconsumption of resources on the remote side QRTR
implements a flow control mechanism.
The mechanism works by the sender keeping track of the number of
outstanding unconfirmed messages that has been transmitted to a
particula
On Mon, May 13, 2019 at 5:02 PM Stanislav Fomichev wrote:
>
> On 05/13, Willem de Bruijn wrote:
> > On Mon, May 13, 2019 at 3:53 PM Stanislav Fomichev wrote:
> > >
> > > If we have a flow dissector BPF program attached to the namespace,
> > > FLOW_DISSECTOR_KEY_ETH_ADDRS won't trigger because we
Jiri reported that with a kernel built with CONFIG_FIXED_PHY=y,
CONFIG_NET_DSA=m and CONFIG_NET_DSA_LOOP=m, we would not get to a
functional state where the mock-up driver is registered. Turns out that
we are not descending into drivers/net/dsa/ unconditionally, and we
won't be able to link-in dsa_
On 05/13, Willem de Bruijn wrote:
> On Mon, May 13, 2019 at 3:53 PM Stanislav Fomichev wrote:
> >
> > If we have a flow dissector BPF program attached to the namespace,
> > FLOW_DISSECTOR_KEY_ETH_ADDRS won't trigger because we exit early.
>
> I suppose that this is true for a variety of keys? For
Hi Vinicius,
On 04/29/2019 06:48 PM, Vinicius Costa Gomes wrote:
Hi,
Changes from RFC:
- Removed the patches for taprio offloading, because of the lack of
in-tree user > - Updated the links to point to the PATCH version of this
series;
Original cover letter:
Overview
This R
Hello,
syzbot found the following crash on:
HEAD commit:69dda13f Merge git://git.kernel.org/pub/scm/linux/kernel/g..
git tree: bpf
console output: https://syzkaller.appspot.com/x/log.txt?x=152a7100a0
kernel config: https://syzkaller.appspot.com/x/.config?x=de3262a7df18d5ca
dashboa
Hello,
syzbot found the following crash on:
HEAD commit:b970afcf Merge tag 'powerpc-5.2-1' of ssh://gitolite.kerne..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1306c794a0
kernel config: https://syzkaller.appspot.com/x/.config?x=de3262a7df18d5ca
da
Hello,
syzbot found the following crash on:
HEAD commit:80f23212 Merge git://git.kernel.org/pub/scm/linux/kernel/g..
git tree: bpf-next
console output: https://syzkaller.appspot.com/x/log.txt?x=129cb09ca0
kernel config: https://syzkaller.appspot.com/x/.config?x=62ac41ed59f810ed
da
> > Perhaps you could tell me if the approach I've taken in patch 3,
> > "Add ability to disable output clock", and patch 4, "Disable tx/rx
> > delay when not configured", are considered acceptable? I can conceive
> > of arguments for alternate approaches. I would like to add support for
> > th
Tossing in my .02 cents:
I anticipate that most users of AF_XDP will want packet processing
for a given RX queue occurring on a single core - otherwise we end
up with cache delays. The usual model is one thread, one socket,
one core, but this isn't enforced anywhere in the AF_XDP code and is
up
On Mon, May 13, 2019 at 3:53 PM Stanislav Fomichev wrote:
>
> If we have a flow dissector BPF program attached to the namespace,
> FLOW_DISSECTOR_KEY_ETH_ADDRS won't trigger because we exit early.
I suppose that this is true for a variety of keys? For instance, also
FLOW_DISSECTOR_KEY_IPV4_ADDRS.
On 13.05.2019 21:58, Trent Piepho wrote:
> On Sat, 2019-05-11 at 14:32 +0200, Heiner Kallweit wrote:
>> On 11.05.2019 12:41, Heiner Kallweit wrote:
>>> On 10.05.2019 23:46, Trent Piepho wrote:
The variables used to store u32 DT properties were signed
ints. This
doesn't work properly
On Sat, 2019-05-11 at 14:32 +0200, Heiner Kallweit wrote:
> On 11.05.2019 12:41, Heiner Kallweit wrote:
> > On 10.05.2019 23:46, Trent Piepho wrote:
> > > The variables used to store u32 DT properties were signed
> > > ints. This
> > > doesn't work properly if the value of the property were to
> >
On 5/13/19 10:32 AM, Yuchung Cheng wrote:
> Commit c7d13c8faa74 ("tcp: properly track retry time on
> passive Fast Open") sets the start of SYNACK retransmission
> time on passive Fast Open in "retrans_stamp". However the
> timestamp is not reset upon the handshake has completed. As a
> result,
Hi Vinicius,
On 04/09/2019 08:32 PM, Vinicius Costa Gomes wrote:
Hi,
Overview
This RFC has two objectives, it adds support for changing the running
schedules during "runtime", explained in more detail later, and
proposes an interface between taprio and the drivers for hardware
offloa
Hello list,
I think I have found a regression in 4.15+ kernels. IPv6 PMTU discovery
doesn't seem to work with source-specific routing (AKA source-address
dependent routing, SADR).
I made a test script (see attachment). It sets up a test environment
with three network namespaces (a, b and c)
On Mon, May 13, 2019 at 9:55 AM Lennart Sorensen
wrote:
>
> On Fri, May 03, 2019 at 04:59:35PM -0400, Lennart Sorensen wrote:
> > On Fri, May 03, 2019 at 10:19:47AM -0700, Alexander Duyck wrote:
> > > The TCP flow could be bypassing RSS and may be using ATR to decide
> > > where the Rx packets are
Both of them are not declared in the headers and not used outside
of bpf_trace.c file.
Fixes: a38d1107f937c ("bpf: support raw tracepoints in modules")
Signed-off-by: Stanislav Fomichev
---
kernel/trace/bpf_trace.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/t
On 05/08, Stanislav Fomichev wrote:
> On 05/08, Alexei Starovoitov wrote:
> > On Wed, May 08, 2019 at 10:18:41AM -0700, Stanislav Fomichev wrote:
> > > Right now we are not using rcu api correctly: we pass __rcu pointers
> > > to bpf_prog_array_xyz routines but don't use rcu_dereference on them
> >
If we have a flow dissector BPF program attached to the namespace,
FLOW_DISSECTOR_KEY_ETH_ADDRS won't trigger because we exit early.
Handle FLOW_DISSECTOR_KEY_ETH_ADDRS before BPF and only if we have
an skb (used by tc-flower only).
Fixes: d58e468b1112 ("flow_dissector: implements flow dissector
Make sure that everything that's coming from a pre-defined mac address
can be dropped.
Signed-off-by: Stanislav Fomichev
---
.../selftests/bpf/test_flow_dissector.sh | 23 +++
1 file changed, 23 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_flow_dissector.sh
On Sun, May 12, 2019 at 08:17:01PM -0700, David Miller wrote:
> From: Jason Gunthorpe
> Date: Mon, 13 May 2019 01:11:42 +
>
> > I think the specific sockaddr types should only ever be used if we
> > *know* the sa_family is that type. If the sa_family is not known then
> > it should be sockadd
From: Jagdish Motwani
This patch fixes netfilter hook traversal when there are more than 1 hooks
returning NF_QUEUE verdict. When the first queue reinjects the packet,
'nf_reinject' starts traversing hooks with a proper hook_index. However,
if it again receives a NF_QUEUE verdict (by some other n
IFLA_LINK is typoed in subject line, you might want to fix that if respinning.
-Ed
This patch fixes netfilter hook traversal when there are more than 1 hooks
returning NF_QUEUE verdict. When the first queue reinjects the packet,
'nf_reinject' starts traversing hooks with a proper hook_index. However, if it
again receives a NF_QUEUE verdict (by some other netfilter hook), it queue
On 5/13/19 10:25 AM, Mark Rutland wrote:
> On Mon, May 13, 2019 at 10:20:19AM -0700, 'Eric Dumazet' via syzkaller wrote:
>> On Mon, May 13, 2019 at 10:17 AM Mark Rutland wrote:
>>>
>>> On Mon, May 13, 2019 at 09:38:55AM -0700, 'Eric Dumazet' via syzkaller
>>> wrote:
Various things in eBPF
From: David Miller
Date: Fri, May 10, 2019 at 4:41 PM
To:
Cc: ,
> From: Yuchung Cheng
> Date: Fri, 10 May 2019 16:00:19 -0700
>
> > Fixes: 3844718c20d0 ("tcp: properly track retry time on passive Fast Open")
>
> This is not a valid commit ID.
Oops submitting a v2. sorry for the typo
Commit c7d13c8faa74 ("tcp: properly track retry time on
passive Fast Open") sets the start of SYNACK retransmission
time on passive Fast Open in "retrans_stamp". However the
timestamp is not reset upon the handshake has completed. As a
result, future data packet retransmission may not update it in
On Mon, May 13, 2019 at 10:20:19AM -0700, 'Eric Dumazet' via syzkaller wrote:
> On Mon, May 13, 2019 at 10:17 AM Mark Rutland wrote:
> >
> > On Mon, May 13, 2019 at 09:38:55AM -0700, 'Eric Dumazet' via syzkaller
> > wrote:
> > > Various things in eBPF really require us to disable preemption
> > >
On Mon, May 13, 2019 at 10:17 AM Mark Rutland wrote:
>
> On Mon, May 13, 2019 at 09:38:55AM -0700, 'Eric Dumazet' via syzkaller wrote:
> > Various things in eBPF really require us to disable preemption
> > before running an eBPF program.
>
> Is that true for all eBPF uses? I note that we don't dis
On Mon, May 13, 2019 at 09:38:55AM -0700, 'Eric Dumazet' via syzkaller wrote:
> Various things in eBPF really require us to disable preemption
> before running an eBPF program.
Is that true for all eBPF uses? I note that we don't disable preemption
in the lib/test_bpf.c module, for example.
If it
David Miller wrote:
>From: Jay Vosburgh
>Date: Mon, 13 May 2019 09:43:30 -0700
>
>> That would be my preference, as the 29c4948293bf commit looks to
>> be the change actually being fixed.
>
>Sorry I pushed the original commit message out :-(
>
>But isn't the Fixes: tag he choose the one whe
Fixes all over:
1) Netdev refcnt leak in nf_flow_table, from Taehee Yoo.
2) Fix RCU usage in nf_tables, from Florian Westphal.
3) Fix DSA build when NET_DSA_TAG_BRCM_PREPEND is not set, from
Yue Haibing.
4) Add missing page read/write ops to realtek driver, from Heiner
Kallweit.
5) End
On Mon, 2019-05-13 at 17:01 +0300, Meelis Roos wrote:
> I tested yesterdays 5.2 devel git and it failed to boot on my Sun Fire V445
> (4x UltraSparc III). Init is started and it hangs there:
>
> [ 38.414436] Run /sbin/init as init process
> [ 38.530711] random: fast init done
> [ 39.580678]
From: Corentin Labbe
Date: Mon, 13 May 2019 13:06:39 +
> When adding more MAC address to a dwmac-sun8i interface, the device goes
> directly in promiscuous mode.
> This is due to IFF_UNICAST_FLT missing flag.
>
> So since the hardware support unicast filtering, let's add IFF_UNICAST_FLT.
>
synchronize_rcu() is fine when the rcu callbacks only need
to free memory (kfree_rcu() or direct kfree() call rcu call backs)
__dev_map_entry_free() is a bit more complex, so we need to make
sure that call queued __dev_map_entry_free() callbacks have completed.
sysbot report:
BUG: KASAN: use-aft
On 05/13, Eric Dumazet wrote:
> Various things in eBPF really require us to disable preemption
> before running an eBPF program.
>
> syzbot reported :
>
> BUG: assuming atomic context at net/core/flow_dissector.c:737
> in_atomic(): 0, irqs_disabled(): 0, pid: 24710, name: syz-executor.3
> 2 locks
From: Grygorii Strashko
Date: Mon, 13 May 2019 16:16:36 +0300
> Fix reported build fail:
> ERROR: "cpsw_ale_flush_multicast"
> [drivers/net/ethernet/ti/keystone_netcp_ethss.ko] undefined!
> ERROR: "cpsw_ale_create" [drivers/net/ethernet/ti/keystone_netcp_ethss.ko]
> undefined!
> ERROR: "cpsw_al
On Fri, May 03, 2019 at 04:59:35PM -0400, Lennart Sorensen wrote:
> On Fri, May 03, 2019 at 10:19:47AM -0700, Alexander Duyck wrote:
> > The TCP flow could be bypassing RSS and may be using ATR to decide
> > where the Rx packets are processed. Now that I think about it there is
> > a possibility th
From: Eric Dumazet
Date: Mon, 13 May 2019 09:38:55 -0700
> Various things in eBPF really require us to disable preemption
> before running an eBPF program.
>
> syzbot reported :
. ..
> Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook")
> Signed-off-by: Eric Dumazet
> Rep
On 5/13/19 9:18 AM, Nicolas Dichtel wrote:
> Adding this attribute may change the output of 'ip link'.
> See this patch for example:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=95ec655bc465
>
>
I figured that would be the response, but wanted to make sure.
On Mon, 13 May 2019 17:18:28 +0200
Nicolas Dichtel wrote:
> Le 13/05/2019 à 17:07, David Ahern a écrit :
> > On 5/13/19 7:47 AM, Sabrina Dubroca wrote:
> >> Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
> >> iflink == ifindex.
> >>
> >> In some cases, a device can be crea
From: Jarod Wilson
Date: Fri, 10 May 2019 17:57:09 -0400
> There's currently a problem with toggling arp_validate on and off with an
> active-backup bond. At the moment, you can start up a bond, like so:
...
> The problem lies in bond_options.c, where passing in arp_validate=0
> results in bond-
From: Jay Vosburgh
Date: Mon, 13 May 2019 09:43:30 -0700
> That would be my preference, as the 29c4948293bf commit looks to
> be the change actually being fixed.
Sorry I pushed the original commit message out :-(
But isn't the Fixes: tag he choose the one where the logic actually
causes p
Jarod Wilson wrote:
>On 5/10/19 6:53 PM, Jay Vosburgh wrote:
>> Jarod Wilson wrote:
>>
>>> There's currently a problem with toggling arp_validate on and off with an
>>> active-backup bond. At the moment, you can start up a bond, like so:
>>>
>>> modprobe bonding mode=1 arp_interval=100 arp_valid
Various things in eBPF really require us to disable preemption
before running an eBPF program.
syzbot reported :
BUG: assuming atomic context at net/core/flow_dissector.c:737
in_atomic(): 0, irqs_disabled(): 0, pid: 24710, name: syz-executor.3
2 locks held by syz-executor.3/24710:
#0: e8
On Sun, May 12, 2019 at 4:52 PM Daniel Borkmann wrote:
>
> On 05/12/2019 03:09 AM, Stanislav Fomichev wrote:
> > On 05/11, Andrii Nakryiko wrote:
> >> On Fri, May 10, 2019 at 3:00 PM Stanislav Fomichev
> >> wrote:
> >>> On 05/10, Andrii Nakryiko wrote:
> On Fri, May 10, 2019 at 2:36 PM Stan
From: Maxim Mikityanskiy
Date: Mon, 13 May 2019 15:05:28 +
> A recent bug in systemd [1] triggered the following kernel warning:
>
> A link change request failed with some changes committed already.
> Interface eth1 may have been left with an inconsistent configuration,
> please check.
Functionally this patch looks fine, but it has several style things that
need to be fixed.
The Subject line of the mail should be:
[PATCH net-next] getneigh: add nondump to retrieve single entry
Also, your timing is wrong. net-next is still closed.
Since there are multiple style errors, learn t
1 - 100 of 194 matches
Mail list logo
